date:20180221

[mynewt-core] 01/01: Merge pull request #833 from mlaz/fix_nrfx_glue

2018-02-21 Thread mlaz

This is an automated email from the ASF dual-hosted git repository.

mlaz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git

commit fa50ac0deff5b62f18a28e76a5cdb3a8b3c4d242
Merge: 70c6614 6ba05cc
Author: Miguel Azevedo 
AuthorDate: Wed Feb 21 23:23:14 2018 -0300

Merge pull request #833 from mlaz/fix_nrfx_glue

fixing sr_from_macro global symbol conflict

 hw/mcu/nordic/include/nrfx_glue.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
To stop receiving notification emails like this one, please contact
m...@apache.org.

[mynewt-core] branch master updated (70c6614 -> fa50ac0)

2018-02-21 Thread mlaz

This is an automated email from the ASF dual-hosted git repository.

mlaz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git.


from 70c6614  Merge pull request #832 from rymanluk/fix_flow_ctrl
 add 6ba05cc  fixing sr_from_macro global symbol conflict
 new fa50ac0  Merge pull request #833 from mlaz/fix_nrfx_glue

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 hw/mcu/nordic/include/nrfx_glue.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
To stop receiving notification emails like this one, please contact
m...@apache.org.

[GitHub] mlaz closed pull request #833: fixing sr_from_macro global symbol conflict

2018-02-21 Thread GitBox

mlaz closed pull request #833: fixing sr_from_macro global symbol conflict
URL: https://github.com/apache/mynewt-core/pull/833
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/hw/mcu/nordic/include/nrfx_glue.h 
b/hw/mcu/nordic/include/nrfx_glue.h
index ba245e3a1..ef8dd8410 100644
--- a/hw/mcu/nordic/include/nrfx_glue.h
+++ b/hw/mcu/nordic/include/nrfx_glue.h
@@ -97,7 +97,7 @@ extern "C" {
 /**
  * @brief Macro for entering into a critical section.
  */
-os_sr_t sr_from_macro;
+static os_sr_t sr_from_macro __attribute__((unused));
 
 #define NRFX_CRITICAL_SECTION_ENTER() OS_ENTER_CRITICAL(sr_from_macro);
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad opened a new pull request #69: bll - Allow OwnAddrType to be specified in linux.

2018-02-21 Thread GitBox

ccollins476ad opened a new pull request #69: bll - Allow OwnAddrType to be 
specified in linux.
URL: https://github.com/apache/mynewt-newtmgr/pull/69
 
 
   Prior to this commit, newtmgr always used a public address to connect.
   
   This commit makes two changes (Linux only):
   * allows the user to specify own address type with the `own_addr_type` 
connection setting.
   * uses a value of 0x10 (10 ms) for the scan interval and scan window (was: 
2.5 ms for both).
   
   These changes only have an effect in Linux.  In macOS, the CoreBluetooth 
library does not allow these settings to be specified at connect time.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mlaz opened a new pull request #836: PWM add cycle interrupt handling to pwm_nrf52 driver

2018-02-21 Thread GitBox

mlaz opened a new pull request #836: PWM add cycle interrupt handling to 
pwm_nrf52 driver
URL: https://github.com/apache/mynewt-core/pull/836
 
 
   To-Do:
   
   - [ ] have the user set interrupt priority  
   - [ ] update pwm_test in order to have this working there


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[mynewt-newt] 01/01: Merge pull request #136 from ccollins476ad/rm-newtmgr

2018-02-21 Thread ccollins

This is an automated email from the ASF dual-hosted git repository.

ccollins pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git

commit d79fedc210acec26e36f5d646b9d6bf16683cc33
Merge: 1c5338c d86ae1b
Author: ccollins476ad 
AuthorDate: Wed Feb 21 14:58:29 2018 -0800

Merge pull request #136 from ccollins476ad/rm-newtmgr

Remove outdated newtmgr from newt repo.

 newtmgr/Godeps/Godeps.json |   149 -
 newtmgr/Godeps/Readme  | 5 -
 newtmgr/cli/commands.go|79 -
 newtmgr/cli/common.go  |49 -
 newtmgr/cli/config.go  |85 -
 newtmgr/cli/connprofile.go |   219 -
 newtmgr/cli/crash.go   |97 -
 newtmgr/cli/datetime.go|   107 -
 newtmgr/cli/echo.go|76 -
 newtmgr/cli/echoctrl.go|45 -
 newtmgr/cli/fs.go  |   216 -
 newtmgr/cli/image.go   |   657 -
 newtmgr/cli/logs.go|   373 -
 newtmgr/cli/mpstats.go |83 -
 newtmgr/cli/reset.go   |66 -
 newtmgr/cli/runtest.go |   150 -
 newtmgr/cli/stats.go   |   130 -
 newtmgr/cli/taskstats.go   |88 -
 newtmgr/cli/usage.go   |45 -
 newtmgr/config/connprofile.go  |   228 -
 newtmgr/core/core_convert.go   |   333 -
 newtmgr/newtmgr.go |26 -
 newtmgr/nmutil/nmutil.go   |78 -
 newtmgr/protocol/cmdrunner.go  |   117 -
 newtmgr/protocol/config.go |89 -
 newtmgr/protocol/coreerase.go  |64 -
 newtmgr/protocol/corelist.go   |64 -
 newtmgr/protocol/coreload.go   |   142 -
 newtmgr/protocol/crash.go  |71 -
 newtmgr/protocol/datetime.go   |77 -
 newtmgr/protocol/defs.go   |43 -
 newtmgr/protocol/echo.go   |   109 -
 newtmgr/protocol/fsdefs.go |24 -
 newtmgr/protocol/fsdownload.go |   102 -
 newtmgr/protocol/fsupload.go   |   104 -
 newtmgr/protocol/imagedefs.go  |77 -
 newtmgr/protocol/imageerase.go |64 -
 newtmgr/protocol/imagestate.go |   128 -
 newtmgr/protocol/imageupload.go|   101 -
 newtmgr/protocol/logs.go   |   342 -
 newtmgr/protocol/mpstats.go|69 -
 newtmgr/protocol/nmgr.go   |   107 -
 newtmgr/protocol/omgr.go   |   122 -
 newtmgr/protocol/reset.go  |48 -
 newtmgr/protocol/runtest.go|   148 -
 newtmgr/protocol/stats.go  |   138 -
 newtmgr/protocol/taskstats.go  |70 -
 newtmgr/transport/conn.go  |   119 -
 newtmgr/transport/connble.go   |   220 -
 newtmgr/transport/connble_darwin.go|23 -
 newtmgr/transport/connble_linux.go |26 -
 newtmgr/transport/connserial.go|   257 -
 newtmgr/transport/connudp.go   |   101 -
 .../vendor/github.com/Sirupsen/logrus/.gitignore   | 1 -
 .../vendor/github.com/Sirupsen/logrus/.travis.yml  | 9 -
 .../vendor/github.com/Sirupsen/logrus/CHANGELOG.md |66 -
 newtmgr/vendor/github.com/Sirupsen/logrus/LICENSE  |21 -
 .../vendor/github.com/Sirupsen/logrus/README.md|   426 -
 .../vendor/github.com/Sirupsen/logrus/alt_exit.go  |64 -
 newtmgr/vendor/github.com/Sirupsen/logrus/doc.go   |26 -
 newtmgr/vendor/github.com/Sirupsen/logrus/entry.go |   275 -
 .../vendor/github.com/Sirupsen/logrus/exported.go  |   193 -
 .../vendor/github.com/Sirupsen/logrus/formatter.go |45 -
 newtmgr/vendor/github.com/Sirupsen/logrus/hooks.go |34 -
 .../github.com/Sirupsen/logrus/json_formatter.go   |69 -
 .../vendor/github.com/Sirupsen/logrus/logger.go|   308 -
 .../vendor/github.com/Sirupsen/logrus/logrus.go|   143 -
 .../Sirupsen/logrus/terminal_appengine.go  | 8 -
 .../github.com/Sirupsen/logrus/terminal_bsd.go |10 -
 .../github.com/Sirupsen/logrus/terminal_linux.go   |14 -
 .../Sirupsen/logrus/terminal_notwindows.go |22 -
 .../github.com/Sirupsen/logrus/terminal_solaris.go |15 -
 .../github.com/Sirupsen/logrus/terminal_windows.go |27 -

[mynewt-newt] 01/01: Merge pull request #137 from ccollins476ad/auto-repos

2018-02-21 Thread ccollins

This is an automated email from the ASF dual-hosted git repository.

ccollins pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git

commit 1c5338c931c0ef1c2224de19d243411fc9e5ef0b
Merge: f0c5704 9bc2a45
Author: ccollins476ad 
AuthorDate: Wed Feb 21 14:58:12 2018 -0800

Merge pull request #137 from ccollins476ad/auto-repos

 Don't require repo TOC in project.yml

 newt/project/project.go | 13 +
 1 file changed, 9 insertions(+), 4 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
ccoll...@apache.org.

[GitHub] ccollins476ad closed pull request #137: Don't require repo TOC in project.yml

2018-02-21 Thread GitBox

ccollins476ad closed pull request #137:  Don't require repo TOC in project.yml
URL: https://github.com/apache/mynewt-newt/pull/137
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/newt/project/project.go b/newt/project/project.go
index cdd0b84f..6a00ef88 100644
--- a/newt/project/project.go
+++ b/newt/project/project.go
@@ -558,10 +558,15 @@ func (proj *Project) loadConfig() error {
r.AddIgnoreDir(ignDir)
}
 
-   rstrs := yc.GetValStringSlice("project.repositories", nil)
-   for _, repoName := range rstrs {
-   if err := proj.loadRepo(repoName, yc); err != nil {
-   return err
+   // Assume every item starting with "repository." is a repository 
descriptor
+   // and try to load it.
+   for k, _ := range yc.AllSettings() {
+   repoName := strings.TrimPrefix(k, "repository.")
+   if repoName != k {
+   if err := proj.loadRepo(repoName, yc); err != nil {
+   util.StatusMessage(util.VERBOSITY_QUIET,
+   "* Warning: %s\n", err.Error())
+   }
}
}
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[mynewt-newt] branch master updated (1c5338c -> d79fedc)

2018-02-21 Thread ccollins

This is an automated email from the ASF dual-hosted git repository.

ccollins pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git.


from 1c5338c  Merge pull request #137 from ccollins476ad/auto-repos
 add d86ae1b  Remove outdated newtmgr from newt repo.
 new d79fedc  Merge pull request #136 from ccollins476ad/rm-newtmgr

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 newtmgr/Godeps/Godeps.json |   149 -
 newtmgr/Godeps/Readme  | 5 -
 newtmgr/cli/commands.go|79 -
 newtmgr/cli/common.go  |49 -
 newtmgr/cli/config.go  |85 -
 newtmgr/cli/connprofile.go |   219 -
 newtmgr/cli/crash.go   |97 -
 newtmgr/cli/datetime.go|   107 -
 newtmgr/cli/echo.go|76 -
 newtmgr/cli/echoctrl.go|45 -
 newtmgr/cli/fs.go  |   216 -
 newtmgr/cli/image.go   |   657 -
 newtmgr/cli/logs.go|   373 -
 newtmgr/cli/mpstats.go |83 -
 newtmgr/cli/reset.go   |66 -
 newtmgr/cli/runtest.go |   150 -
 newtmgr/cli/stats.go   |   130 -
 newtmgr/cli/taskstats.go   |88 -
 newtmgr/cli/usage.go   |45 -
 newtmgr/config/connprofile.go  |   228 -
 newtmgr/core/core_convert.go   |   333 -
 newtmgr/newtmgr.go |26 -
 newtmgr/nmutil/nmutil.go   |78 -
 newtmgr/protocol/cmdrunner.go  |   117 -
 newtmgr/protocol/config.go |89 -
 newtmgr/protocol/coreerase.go  |64 -
 newtmgr/protocol/corelist.go   |64 -
 newtmgr/protocol/coreload.go   |   142 -
 newtmgr/protocol/crash.go  |71 -
 newtmgr/protocol/datetime.go   |77 -
 newtmgr/protocol/defs.go   |43 -
 newtmgr/protocol/echo.go   |   109 -
 newtmgr/protocol/fsdefs.go |24 -
 newtmgr/protocol/fsdownload.go |   102 -
 newtmgr/protocol/fsupload.go   |   104 -
 newtmgr/protocol/imagedefs.go  |77 -
 newtmgr/protocol/imageerase.go |64 -
 newtmgr/protocol/imagestate.go |   128 -
 newtmgr/protocol/imageupload.go|   101 -
 newtmgr/protocol/logs.go   |   342 -
 newtmgr/protocol/mpstats.go|69 -
 newtmgr/protocol/nmgr.go   |   107 -
 newtmgr/protocol/omgr.go   |   122 -
 newtmgr/protocol/reset.go  |48 -
 newtmgr/protocol/runtest.go|   148 -
 newtmgr/protocol/stats.go  |   138 -
 newtmgr/protocol/taskstats.go  |70 -
 newtmgr/transport/conn.go  |   119 -
 newtmgr/transport/connble.go   |   220 -
 newtmgr/transport/connble_darwin.go|23 -
 newtmgr/transport/connble_linux.go |26 -
 newtmgr/transport/connserial.go|   257 -
 newtmgr/transport/connudp.go   |   101 -
 .../vendor/github.com/Sirupsen/logrus/.gitignore   | 1 -
 .../vendor/github.com/Sirupsen/logrus/.travis.yml  | 9 -
 .../vendor/github.com/Sirupsen/logrus/CHANGELOG.md |66 -
 newtmgr/vendor/github.com/Sirupsen/logrus/LICENSE  |21 -
 .../vendor/github.com/Sirupsen/logrus/README.md|   426 -
 .../vendor/github.com/Sirupsen/logrus/alt_exit.go  |64 -
 newtmgr/vendor/github.com/Sirupsen/logrus/doc.go   |26 -
 newtmgr/vendor/github.com/Sirupsen/logrus/entry.go |   275 -
 .../vendor/github.com/Sirupsen/logrus/exported.go  |   193 -
 .../vendor/github.com/Sirupsen/logrus/formatter.go |45 -
 newtmgr/vendor/github.com/Sirupsen/logrus/hooks.go |34 -
 .../github.com/Sirupsen/logrus/json_formatter.go   |69 -
 .../vendor/github.com/Sirupsen/logrus/logger.go|   308 -
 .../vendor/github.com/Sirupsen/logrus/logrus.go|   143 -
 .../Sirupsen/logrus/terminal_appengine.go  | 8 -
 .../github.com/Sirupsen/logrus/terminal_bsd.go |10 -
 .../github.com/Sirupsen/logrus/terminal_linux.go   |14 -

[mynewt-newt] branch master updated (f0c5704 -> 1c5338c)

2018-02-21 Thread ccollins

This is an automated email from the ASF dual-hosted git repository.

ccollins pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git.


from f0c5704  Merge pull request #133 from ccollins476ad/lflags
 add 9bc2a45  Don't require repo TOC in project.yml
 new 1c5338c  Merge pull request #137 from ccollins476ad/auto-repos

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 newt/project/project.go | 13 +
 1 file changed, 9 insertions(+), 4 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
ccoll...@apache.org.

[GitHub] vrahane opened a new pull request #835: oic: fixing `oc_resource_t` structure arrangement

2018-02-21 Thread GitBox

vrahane opened a new pull request #835: oic: fixing `oc_resource_t` structure 
arrangement
URL: https://github.com/apache/mynewt-core/pull/835
 
 
   - Because of the enum forward declaration, oc_resource_t
 arrangement was different for oc_ri.c and oc_core_res.c
 source files.
   - This fixes #834


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vrahane opened a new issue #834: oic: fixing `oc_resource_t` structure arrangement which was different for different sources after building

2018-02-21 Thread GitBox

vrahane opened a new issue #834: oic: fixing `oc_resource_t` structure 
arrangement which was different for different sources after building
URL: https://github.com/apache/mynewt-core/issues/834
 
 
   Issue:
   This was basically caused because of forward declaration of an enum. 
Changing this would mean moving around headers and creating a new one for enums.
   
   ```
   (gdb) p _resources[0]
   $24 = (oc_resource_t *) 0x20003078 
   (gdb) p _resources[0].get_handler
   $25 = (oc_request_handler_t *) 0x20003098 
   (gdb) p &((oc_resource_t *) 0x20003078)->get_handler
   $26 = (oc_request_handler_t *) 0x20003094 
   ```
   
   ```
   (gdb) p &((oc_resource_t *) 0x20003080)->next   
(gdb) p _resources[0].next
   $11 = (struct {...} *) 0x20003080   $19 
= (struct {...} *) 0x20003080 
   (gdb) p &((oc_resource_t *) 0x20003080)->device 
(gdb) p _resources[0].device
   $12 = (int *) 0x20003084  $20 
= (int *) 0x20003084 
   (gdb) p &((oc_resource_t *) 0x20003080)->uri
(gdb) p _resources[0].uri
   $13 = (oc_string_t *) 0x20003088  $21 
= (oc_string_t *) 0x20003088 
   (gdb) p &((oc_resource_t *) 0x20003080)->types  
(gdb) p _resources[0].types
   $14 = (oc_string_array_t *) 0x20003090   $22 
= (oc_string_array_t *) 0x20003090 
   (gdb) p &((oc_resource_t *) 0x20003080)->interfaces 
(gdb) p _resources[0].interfaces
   $15 = (oc_interface_mask_t *) 0x20003098 $23 
= (oc_interface_mask_t *) 0x20003098 
   (gdb) p &((oc_resource_t *) 0x20003080)->default_interface  
(gdb) p _resources[0].default_interface
   $16 = (oc_interface_mask_t *) 0x20003099 $24 
= (oc_interface_mask_t *) 0x20003099 
   (gdb) p &((oc_resource_t *) 0x20003080)->properties 
(gdb) p _resources[0].properties
   $17 = (oc_resource_properties_t *) 0x2000309a    $25 
= (oc_resource_properties_t *) 0x2000309c 
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad closed pull request #68: Remove hardcoded "newtmgr" strings.

2018-02-21 Thread GitBox

ccollins476ad closed pull request #68: Remove hardcoded "newtmgr" strings.
URL: https://github.com/apache/mynewt-newtmgr/pull/68
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/newtmgr/cli/commands.go b/newtmgr/cli/commands.go
index 585243c..0c30c5b 100644
--- a/newtmgr/cli/commands.go
+++ b/newtmgr/cli/commands.go
@@ -37,7 +37,7 @@ func Commands() *cobra.Command {
logLevelStr := ""
nmCmd := {
Use:   nmutil.ToolInfo.ExeName,
-   Short: nmutil.ToolInfo.ShortName + " helps you manage remote 
devices running the Mynewt OS",
+   Short: nmutil.ToolInfo.ShortName + " helps you manage remote 
devices",
PersistentPreRun: func(cmd *cobra.Command, args []string) {
NewtmgrLogLevel, err := log.ParseLevel(logLevelStr)
if err != nil {
diff --git a/newtmgr/cli/interactive.go b/newtmgr/cli/interactive.go
index a8a957e..09bd105 100644
--- a/newtmgr/cli/interactive.go
+++ b/newtmgr/cli/interactive.go
@@ -3,9 +3,9 @@ package cli
 import (
"container/list"
"fmt"
-   "gopkg.in/abiosoft/ishell.v1"
"github.com/runtimeco/go-coap"
"github.com/spf13/cobra"
+   "gopkg.in/abiosoft/ishell.v1"
"mynewt.apache.org/newt/util"
"mynewt.apache.org/newtmgr/newtmgr/nmutil"
"mynewt.apache.org/newtmgr/nmxact/nmxutil"
@@ -508,9 +508,10 @@ func startInteractive(cmd *cobra.Command, args []string) {
 func interactiveCmd() *cobra.Command {
 
shellCmd := {
-   Use:   "interactive",
-   Short: "Run newtmgr interactive mode (used for COAP only)",
-   Run:   startInteractive,
+   Use: "interactive",
+   Short: "Run " + nmutil.ToolInfo.ShortName +
+   " interactive mode (used for COAP only)",
+   Run: startInteractive,
}
 
return shellCmd


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[mynewt-newtmgr] 01/01: Merge pull request #67 from ccollins476ad/dbl-shutdown

2018-02-21 Thread ccollins

This is an automated email from the ASF dual-hosted git repository.

ccollins pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git

commit 1ac17c144c3b2aabc99a9959376566cf73845938
Merge: 9f0b79b 355c9c8
Author: ccollins476ad 
AuthorDate: Wed Feb 21 12:36:50 2018 -0800

Merge pull request #67 from ccollins476ad/dbl-shutdown

Fix panic when BLE session is closed twice.

 nmxact/nmble/naked_sesn.go | 54 ++
 1 file changed, 31 insertions(+), 23 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
ccoll...@apache.org.

[mynewt-newtmgr] 01/01: Merge pull request #68 from ccollins476ad/rm-newtmgr-string

2018-02-21 Thread ccollins

This is an automated email from the ASF dual-hosted git repository.

ccollins pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git

commit f24b1451bf22c022629cc3447fbca89dc3c78bb6
Merge: 1ac17c1 346002c
Author: ccollins476ad 
AuthorDate: Wed Feb 21 12:37:03 2018 -0800

Merge pull request #68 from ccollins476ad/rm-newtmgr-string

Remove hardcoded "newtmgr" strings.

 newtmgr/cli/commands.go| 2 +-
 newtmgr/cli/interactive.go | 9 +
 2 files changed, 6 insertions(+), 5 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
ccoll...@apache.org.

[mynewt-newtmgr] branch master updated (9f0b79b -> 1ac17c1)

2018-02-21 Thread ccollins

This is an automated email from the ASF dual-hosted git repository.

ccollins pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git.


from 9f0b79b  Merge pull request #66 from mkiiskila/coap_delete_payload
 add 355c9c8  Fix panic when BLE session is closed twice.
 new 1ac17c1  Merge pull request #67 from ccollins476ad/dbl-shutdown

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 nmxact/nmble/naked_sesn.go | 54 ++
 1 file changed, 31 insertions(+), 23 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
ccoll...@apache.org.

[mynewt-newtmgr] branch master updated (1ac17c1 -> f24b145)

2018-02-21 Thread ccollins

This is an automated email from the ASF dual-hosted git repository.

ccollins pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git.


from 1ac17c1  Merge pull request #67 from ccollins476ad/dbl-shutdown
 add 346002c  Remove hardcoded "newtmgr" strings.
 new f24b145  Merge pull request #68 from ccollins476ad/rm-newtmgr-string

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 newtmgr/cli/commands.go| 2 +-
 newtmgr/cli/interactive.go | 9 +
 2 files changed, 6 insertions(+), 5 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
ccoll...@apache.org.

[GitHub] ccollins476ad closed pull request #67: Fix panic when BLE session is closed twice.

2018-02-21 Thread GitBox

ccollins476ad closed pull request #67: Fix panic when BLE session is closed 
twice.
URL: https://github.com/apache/mynewt-newtmgr/pull/67
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/nmxact/nmble/naked_sesn.go b/nmxact/nmble/naked_sesn.go
index b93fb90..0391ce6 100644
--- a/nmxact/nmble/naked_sesn.go
+++ b/nmxact/nmble/naked_sesn.go
@@ -35,6 +35,20 @@ import (
"mynewt.apache.org/newtmgr/nmxact/task"
 )
 
+type NakedSesnState int
+
+const (
+   // Session not open and no open in progress.
+   NS_STATE_CLOSED NakedSesnState = iota
+
+   // Open in progress.
+   NS_STATE_OPENING_ACTIVE
+   NS_STATE_OPENING_IDLE
+
+   // Open complete.
+   NS_STATE_OPEN
+)
+
 // Implements a BLE session that does not acquire the master resource on
 // connect.  The user of this type must acquire the resource manually.
 type NakedSesn struct {
@@ -52,12 +66,7 @@ type NakedSesn struct {
// Protects `enabled` and `opening`.
mtx sync.Mutex
 
-   // True if the session is open or being opened.
-   enabled bool
-
-   // True if session is being opened; used to prevent a full shutdown in
-   // mid-open to allow retries.
-   opening bool
+   state NakedSesnState
 
shuttingDown bool
 
@@ -117,7 +126,7 @@ func (s *NakedSesn) shutdown(cause error) error {
s.mtx.Lock()
defer s.mtx.Unlock()
 
-   if s.shuttingDown || (!s.enabled && !s.opening) {
+   if s.shuttingDown || s.state == NS_STATE_CLOSED {
return nmxutil.NewSesnClosedError(
"Attempt to close an already-closed session")
}
@@ -157,14 +166,14 @@ func (s *NakedSesn) shutdown(cause error) error {
 
// Call the on-close callback if the session was fully open.
s.mtx.Lock()
-   opening := s.opening
-   s.enabled = false
+   opening := s.state == NS_STATE_OPENING_ACTIVE || s.state == 
NS_STATE_OPENING_IDLE
+   if !opening {
+   s.state = NS_STATE_CLOSED
+   }
s.mtx.Unlock()
 
-   if !opening {
-   if s.cfg.OnCloseCb != nil {
-   s.cfg.OnCloseCb(s, cause)
-   }
+   if !opening && s.cfg.OnCloseCb != nil {
+   s.cfg.OnCloseCb(s, cause)
}
 
return nil
@@ -190,12 +199,12 @@ func (s *NakedSesn) Open() error {
s.mtx.Lock()
defer s.mtx.Unlock()
 
-   if s.opening || s.enabled {
+   if s.state != NS_STATE_CLOSED {
return nmxutil.NewSesnAlreadyOpenError(
"Attempt to open an already-open BLE session")
}
 
-   s.opening = true
+   s.state = NS_STATE_OPENING_IDLE
return nil
}
 
@@ -206,7 +215,7 @@ func (s *NakedSesn) Open() error {
s.mtx.Lock()
defer s.mtx.Unlock()
 
-   s.opening = false
+   s.state = NS_STATE_CLOSED
}()
 
var err error
@@ -230,7 +239,7 @@ func (s *NakedSesn) Open() error {
s.bx.AddSesn(s.conn.connHandle, s)
 
s.mtx.Lock()
-   s.enabled = true
+   s.state = NS_STATE_OPEN
s.mtx.Unlock()
 
return nil
@@ -243,13 +252,12 @@ func (s *NakedSesn) OpenConnected(
s.mtx.Lock()
defer s.mtx.Unlock()
 
-   if s.opening || s.enabled {
+   if s.state != NS_STATE_CLOSED {
return nmxutil.NewSesnAlreadyOpenError(
"Attempt to open an already-open BLE session")
}
-   nmxutil.Assert(!s.opening)
 
-   s.opening = true
+   s.state = NS_STATE_OPENING_ACTIVE
return nil
}
 
@@ -260,7 +268,7 @@ func (s *NakedSesn) OpenConnected(
s.mtx.Lock()
defer s.mtx.Unlock()
 
-   s.opening = false
+   s.state = NS_STATE_CLOSED
}()
 
if err := s.init(); err != nil {
@@ -290,7 +298,7 @@ func (s *NakedSesn) OpenConnected(
s.bx.AddSesn(connHandle, s)
 
s.mtx.Lock()
-   s.enabled = true
+   s.state = NS_STATE_OPEN
s.mtx.Unlock()
 
return nil
@@ -463,7 +471,7 @@ func (s *NakedSesn) IsOpen() bool {
s.mtx.Lock()
defer s.mtx.Unlock()
 
-   return s.enabled
+   return s.state == NS_STATE_OPEN
 }
 
 func (s *NakedSesn) MtuIn() int {


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific

[GitHub] mlaz opened a new pull request #833: fixing sr_from_macro global symbol conflict

2018-02-21 Thread GitBox

mlaz opened a new pull request #833: fixing sr_from_macro global symbol conflict
URL: https://github.com/apache/mynewt-core/pull/833
 
 
   This PR fixes the Global Symbol Conflict on sr_from_macro


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] matthewwarnes commented on a change in pull request #829: add driver for ADXL345 sensor

2018-02-21 Thread GitBox

matthewwarnes commented on a change in pull request #829: add driver for 
ADXL345 sensor
URL: https://github.com/apache/mynewt-core/pull/829#discussion_r169761199
 
 

 ##
 File path: hw/drivers/sensors/adxl345/src/adxl345.c
 ##
 @@ -0,0 +1,1262 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * resarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include 
+#include 
+#include 
+
+#include "defs/error.h"
+#include "os/os.h"
+#include "sysinit/sysinit.h"
 
 Review comment:
   I will sort the requested changes. I should also be able to add in IRQ bits, 
I mostly haven't done that yet as I wasn't sure how to implement it yet.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vrahane commented on issue #829: add driver for ADXL345 sensor

2018-02-21 Thread GitBox

vrahane commented on issue #829: add driver for ADXL345 sensor
URL: https://github.com/apache/mynewt-core/pull/829#issuecomment-367458263
 
 
   Sounds good. Support for thresholds and tap detection are quite useful in 
the Sensor API.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[mynewt-core] branch master updated (1191a1a -> 70c6614)

2018-02-21 Thread rymek

This is an automated email from the ASF dual-hosted git repository.

rymek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git.


from 1191a1a  Merge pull request #830 from 
andrzej-kaczmarek/fix-min-win-offset
 add c718e65  native/hal_uart: Disable software flow control
 new 70c6614  Merge pull request #832 from rymanluk/fix_flow_ctrl

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 hw/mcu/native/src/hal_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
To stop receiving notification emails like this one, please contact
ry...@apache.org.

[mynewt-core] 01/01: Merge pull request #832 from rymanluk/fix_flow_ctrl

2018-02-21 Thread rymek

This is an automated email from the ASF dual-hosted git repository.

rymek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git

commit 70c66141028111236e06179ec40e2ee208341522
Merge: 1191a1a c718e65
Author: Łukasz Rymanowski 
AuthorDate: Wed Feb 21 17:56:41 2018 +0100

Merge pull request #832 from rymanluk/fix_flow_ctrl

native/hal_uart: Disable software flow control

 hw/mcu/native/src/hal_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
To stop receiving notification emails like this one, please contact
ry...@apache.org.

[GitHub] rymanluk closed pull request #832: native/hal_uart: Disable software flow control

2018-02-21 Thread GitBox

rymanluk closed pull request #832: native/hal_uart: Disable software flow 
control
URL: https://github.com/apache/mynewt-core/pull/832
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/hw/mcu/native/src/hal_uart.c b/hw/mcu/native/src/hal_uart.c
index 979b57b68..13664db00 100644
--- a/hw/mcu/native/src/hal_uart.c
+++ b/hw/mcu/native/src/hal_uart.c
@@ -262,7 +262,7 @@ uart_pty_set_attr(int fd)
 
 tios.c_cflag &= ~(CSIZE | CSTOPB | PARENB);
 tios.c_cflag |= CS8 | CREAD;
-tios.c_iflag = IGNPAR | IXON;
+tios.c_iflag = IGNPAR;
 tios.c_oflag = 0;
 tios.c_lflag = 0;
 if (tcsetattr(fd, TCSAFLUSH, ) < 0) {


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] andrzej-kaczmarek closed pull request #830: nimble/ll: Fix BLE_LL_CONN_INIT_MIN_WIN_OFFSET

2018-02-21 Thread GitBox

andrzej-kaczmarek closed pull request #830: nimble/ll: Fix 
BLE_LL_CONN_INIT_MIN_WIN_OFFSET
URL: https://github.com/apache/mynewt-core/pull/830
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/net/nimble/controller/src/ble_ll_sched.c 
b/net/nimble/controller/src/ble_ll_sched.c
index 8d32121b6..4b46c0be6 100644
--- a/net/nimble/controller/src/ble_ll_sched.c
+++ b/net/nimble/controller/src/ble_ll_sched.c
@@ -402,6 +402,8 @@ ble_ll_sched_master_new(struct ble_ll_conn_sm *connsm,
 assert(0);
 }
 }
+earliest_start += MYNEWT_VAL(BLE_LL_CONN_INIT_MIN_WIN_OFFSET) *
+  BLE_LL_SCHED_32KHZ_TICKS_PER_SLOT;
 itvl_t = connsm->conn_itvl_ticks;
 
 /* We have to find a place for this schedule */
@@ -630,6 +632,8 @@ ble_ll_sched_master_new(struct ble_ll_conn_sm *connsm,
 assert(0);
 }
 }
+earliest_start += MYNEWT_VAL(BLE_LL_CONN_INIT_MIN_WIN_OFFSET) *
+  BLE_LL_SCHED_32KHZ_TICKS_PER_SLOT;
 earliest_end = earliest_start + dur;
 itvl_t = connsm->conn_itvl_ticks;
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[mynewt-core] branch master updated (6d55bf7 -> 1191a1a)

2018-02-21 Thread andk

This is an automated email from the ASF dual-hosted git repository.

andk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git.


from 6d55bf7  Merge pull request #828 from wes3/nrf52840_uart
 add cf8ca1b  nimble/ll: Fix BLE_LL_CONN_INIT_MIN_WIN_OFFSET
 new 1191a1a  Merge pull request #830 from 
andrzej-kaczmarek/fix-min-win-offset

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 net/nimble/controller/src/ble_ll_sched.c | 4 
 1 file changed, 4 insertions(+)

-- 
To stop receiving notification emails like this one, please contact
a...@apache.org.

[GitHub] jacobrosenthal commented on issue #831: apps/ble: Fix GATT discovery in some apps

2018-02-21 Thread GitBox

jacobrosenthal commented on issue #831: apps/ble: Fix GATT discovery in some 
apps
URL: https://github.com/apache/mynewt-core/pull/831#issuecomment-367373064
 
 
   Which for posterity looked like this
   ```
   000876 [ts=6843696ssb, mod=4 level=0] Command Status: status=0 cmd_pkts=1 
ocf=0xd ogf=0x8
   000878 [ts=6859320ssb, mod=4 level=0] LE connection complete. handle=1 
role=0 paddrtype=1 addr=f9.7b.73.ef.2c.63 local_rpa=0.0.0.0.0.0 
peer_rpa=0.0.0.0.0.0 itvl=40 latency=0 spvn_tmo=256 mca=4
   000878 [ts=6859320ssb, mod=64 level=1] Connection established handle=1 
our_ota_addr_type=0 our_ota_addr=0a:0a:0a:0a:0a:0a our_id_addr_type=0 
our_id_addr=0a:0a:0a:0a:0a:0a peer_ota_addr_type=1 
peer_ota_addr=f9:7b:73:ef:2c:63 peer_id_addr_type=1 
peer_id_addr=f9:7b:73:ef:2c:63 conn_itvl=40 conn_latency=0 
supervision_timeout=256 encrypted=0 authenticated=0 bonded=0
   000879 [ts=6867132ssb, mod=4 level=1] GATT procedure initiated: discover all 
services
   000879 [ts=6867132ssb, mod=4 level=0] txed att command: read group type req; 
conn=1 start_handle=0x0001 end_handle=0x
   000879 [ts=6867132ssb, mod=4 level=0] host tx hci data; handle=1 length=11
   000879 [ts=6867132ssb, mod=4 level=0] ble_hs_hci_acl_tx(): 0x01 0x00 0x0b 
0x00 0x07 0x00 0x04 0x00 0x10 0x01 0x00 0xff 0xff 0x00 0x28 
   000879 [ts=6867132ssb, mod=4 level=0] ble_hs_hci_cmd_send: ogf=0x08 
ocf=0x0016 len=2
   000879 [ts=6867132ssb, mod=4 level=0] 0x16 0x20 0x02 0x01 0x00 
   000879 [ts=6867132ssb, mod=4 level=0] Command Status: status=0 cmd_pkts=1 
ocf=0x16 ogf=0x8
   000879 [ts=6867132ssb, mod=4 level=0]Unknown LE event
   000885 [ts=6914004ssb, mod=4 level=0] LE Remote Used Features. handle=1 
feat=01 00 00 00 00 00 00 00 
   000885 [ts=6914004ssb, mod=4 level=0] Number of Completed Packets: 
num_handles=1
   000885 [ts=6914004ssb, mod=4 level=0] handle:1 pkts:1
   000891 [ts=6960876ssb, mod=4 level=0] ble_hs_hci_evt_acl_process(): 
conn_handle=1 pb=2 len=24 data=0x14 0x00 0x04 0x00 0x11 0x06 0x01 0x00 0x07 
0x00 0x00 0x18 0x08 0x00 0x08 0x00 0x01 0x18 0x09 0x00 0x11 0x00 0x0a 0x18 
   000892 [ts=6968688ssb, mod=4 level=0] rxed att command: read group type rsp; 
conn=1 length=6
   000892 [ts=6968688ssb, mod=4 level=0] txed att command: read group type req; 
conn=1 start_handle=0x0012 end_handle=0x
   000892 [ts=6968688ssb, mod=4 level=0] host tx hci data; handle=1 length=11
   000892 [ts=6968688ssb, mod=4 level=0] ble_hs_hci_acl_tx(): 0x01 0x00 0x0b 
0x00 0x07 0x00 0x04 0x00 0x10 0x12 0x00 0xff 0xff 0x00 0x28 
   000898 [ts=7015624ssb, mod=4 level=0] Number of Completed Packets: 
num_handles=1
   000898 [ts=7015624ssb, mod=4 level=0] handle:1 pkts:1
   000904 [ts=7062496ssb, mod=4 level=0] ble_hs_hci_evt_acl_process(): 
conn_handle=1 pb=2 len=18 data=0x0e 0x00 0x04 0x00 0x11 0x06 0x12 0x00 0x17 
0x00 0x0d 0x18 0x18 0x00 0x1b 0x00 0x0f 0x18 
   000904 [ts=7062496ssb, mod=4 level=0] rxed att command: read group type rsp; 
conn=1 length=6
   000904 [ts=7062496ssb, mod=4 level=0] txed att command: read group type req; 
conn=1 start_handle=0x001c end_handle=0x
   000905 [ts=7070308ssb, mod=4 level=0] host tx hci data; handle=1 length=11
   000905 [ts=7070308ssb, mod=4 level=0] ble_hs_hci_acl_tx(): 0x01 0x00 0x0b 
0x00 0x07 0x00 0x04 0x00 0x10 0x1c 0x00 0xff 0xff 0x00 0x28 
   000911 [ts=7117180ssb, mod=4 level=0] Number of Completed Packets: 
num_handles=1
   000911 [ts=7117180ssb, mod=4 level=0] handle:1 pkts:1
   000917 [ts=7164052ssb, mod=4 level=0] ble_hs_hci_evt_acl_process(): 
conn_handle=1 pb=2 len=26 data=0x16 0x00 0x04 0x00 0x11 0x14 0x1c 0x00 0xff 
0xff 0x02 0x50 0xf4 0x1d 0x0a 0x4b 0x89 0x90 0x99 0x4c 0xac 0x6c 0x00 0x30 0xba 
0xf0 
   000917 [ts=7164052ssb, mod=4 level=0] rxed att command: read group type rsp; 
conn=1 length=20
   000917 [ts=7164052ssb, mod=4 level=1] GATT procedure initiated: discover all 
characteristics; start_handle=1 end_handle=7
   000917 [ts=7164052ssb, mod=4 level=0] txed att command: read type req; 
conn=1 start_handle=0x0001 end_handle=0x0007
   000918 [ts=7171864ssb, mod=4 level=0] host tx hci data; handle=1 length=11
   000918 [ts=7171864ssb, mod=4 level=0] ble_hs_hci_acl_tx(): 0x01 0x00 0x0b 
0x00 0x07 0x00 0x04 0x00 0x08 0x01 0x00 0x07 0x00 0x03 0x28 
   000923 [ts=7210924ssb, mod=4 level=0] Number of Completed Packets: 
num_handles=1
   000923 [ts=7210924ssb, mod=4 level=0] handle:1 pkts:1
   000930 [ts=7265608ssb, mod=4 level=0] ble_hs_hci_evt_acl_process(): 
conn_handle=1 pb=2 len=27 data=0x17 0x00 0x04 0x00 0x09 0x07 0x02 0x00 0x0a 
0x03 0x00 0x00 0x2a 0x04 0x00 0x02 0x05 0x00 0x01 0x2a 0x06 0x00 0x02 0x07 0x00 
0x04 0x2a 
   000930 [ts=7265608ssb, mod=4 level=0] rxed att command: read type rsp; 
conn=1 length=7
   000930 [ts=7265608ssb, mod=4 level=0] txed att command: read type req; 
conn=1 start_handle=0x0007 end_handle=0x0007
   000930 [ts=7265608ssb, mod=4 level=0] host tx hci data; handle=1 length=11
   000930 [ts=7265608ssb, mod=4 level=0] ble_hs_hci_acl_tx(): 0x01 0x00

[GitHub] jacobrosenthal commented on issue #831: apps/ble: Fix GATT discovery in some apps

2018-02-21 Thread GitBox

jacobrosenthal commented on issue #831: apps/ble: Fix GATT discovery in some 
apps
URL: https://github.com/apache/mynewt-core/pull/831#issuecomment-367372562
 
 
   Confirm this fixes problem I was seeing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jacobrosenthal commented on issue #830: nimble/ll: Fix BLE_LL_CONN_INIT_MIN_WIN_OFFSET

2018-02-21 Thread GitBox

jacobrosenthal commented on issue #830: nimble/ll: Fix 
BLE_LL_CONN_INIT_MIN_WIN_OFFSET
URL: https://github.com/apache/mynewt-core/pull/830#issuecomment-367372589
 
 
   Confirm this fixes problem I was seeing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[mynewt-core] 01/01: Merge pull request #828 from wes3/nrf52840_uart

2018-02-21 Thread wes3

This is an automated email from the ASF dual-hosted git repository.

wes3 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git

commit 6d55bf7d9820009c8f22b8e94fa41a9634ec23c6
Merge: 3b58dde be19af0
Author: wes3 
AuthorDate: Wed Feb 21 07:51:17 2018 -0800

Merge pull request #828 from wes3/nrf52840_uart

hal/uart: Fix nrf52840 (and nrf52) uart1 addition.

 hw/drivers/uart/uart_hal/src/uart_hal.c |  7 +++--
 hw/mcu/nordic/nrf52xxx/src/hal_uart.c   | 50 -
 2 files changed, 42 insertions(+), 15 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
w...@apache.org.

[GitHub] rymanluk opened a new pull request #832: native/hal_uart: Disable software flow control

2018-02-21 Thread GitBox

rymanluk opened a new pull request #832: native/hal_uart: Disable software flow 
control
URL: https://github.com/apache/mynewt-core/pull/832
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] andrzej-kaczmarek opened a new pull request #831: apps/ble: Fix GATT discovery in some apps

2018-02-21 Thread GitBox

andrzej-kaczmarek opened a new pull request #831: apps/ble: Fix GATT discovery 
in some apps
URL: https://github.com/apache/mynewt-core/pull/831
 
 
   This fixes an issue with GATT discovery in few sample apps which
   results in an infinite loop with characteristics discovery if peer's
   database has service with no characteristics due to invalid check for
   empty service.
   
   The same fix is applied to bletiny and btshell which do not have this
   issue anymore, but the original fix just hidden the issue instead of
   fixing the root cause.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkiiskila commented on a change in pull request #829: add driver for ADXL345 sensor

2018-02-21 Thread GitBox

mkiiskila commented on a change in pull request #829: add driver for ADXL345 
sensor
URL: https://github.com/apache/mynewt-core/pull/829#discussion_r169570798
 
 

 ##
 File path: hw/drivers/sensors/adxl345/src/adxl345.c
 ##
 @@ -0,0 +1,1262 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * resarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include 
+#include 
+#include 
+
+#include "defs/error.h"
+#include "os/os.h"
+#include "sysinit/sysinit.h"
 
 Review comment:
   Move this line a bit higher. There are syscfg settings which impact how 
includes from os/os.h are read in.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] andrzej-kaczmarek commented on issue #830: nimble/ll: Fix BLE_LL_CONN_INIT_MIN_WIN_OFFSET

2018-02-21 Thread GitBox

andrzej-kaczmarek commented on issue #830: nimble/ll: Fix 
BLE_LL_CONN_INIT_MIN_WIN_OFFSET
URL: https://github.com/apache/mynewt-core/pull/830#issuecomment-367254221
 
 
   @jacobrosenthal 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] andrzej-kaczmarek opened a new pull request #830: nimble/ll: Fix BLE_LL_CONN_INIT_MIN_WIN_OFFSET

2018-02-21 Thread GitBox

andrzej-kaczmarek opened a new pull request #830: nimble/ll: Fix 
BLE_LL_CONN_INIT_MIN_WIN_OFFSET
URL: https://github.com/apache/mynewt-core/pull/830
 
 
   The code which calculates earliest connection event start does not take
   BLE_LL_CONN_INIT_MIN_WIN_OFFSET into account, but we still update tx
   windows offset in state machine with its value. As a result when this
   setting is set to non-zero value we schedule first connection event
   earlier than what slave calculates from CONNECT_IND PDU so connection
   cannot be established.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[mynewt-newtmgr] branch master updated (214ef2c -> 9f0b79b)

2018-02-21 Thread marko

This is an automated email from the ASF dual-hosted git repository.

marko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git.


from 214ef2c  Merge pull request #53 from apache/go-ble
 add 75bfc43  newtmgr; allow payload in CoAP DELETE
 new 9f0b79b  Merge pull request #66 from mkiiskila/coap_delete_payload

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 newtmgr/cli/res.go   | 12 
 nmxact/nmcoap/nmcoap.go  | 11 +++
 nmxact/sesn/sesn_util.go | 10 ++
 nmxact/xact/res.go   |  3 ++-
 4 files changed, 27 insertions(+), 9 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
ma...@apache.org.

[GitHub] mkiiskila closed pull request #66: newtmgr; allow payload in CoAP DELETE

2018-02-21 Thread GitBox

mkiiskila closed pull request #66: newtmgr; allow payload in CoAP DELETE
URL: https://github.com/apache/mynewt-newtmgr/pull/66
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/newtmgr/cli/res.go b/newtmgr/cli/res.go
index af9cef0..d9c4f2a 100644
--- a/newtmgr/cli/res.go
+++ b/newtmgr/cli/res.go
@@ -249,10 +249,22 @@ func resDeleteCmd(cmd *cobra.Command, args []string) {
 
path := args[1]
 
+   var m map[string]interface{}
+   m, err = extractResKv(args[2:])
+   if err != nil {
+   nmUsage(cmd, err)
+   }
+
+   b, err := nmxutil.EncodeCborMap(m)
+   if err != nil {
+   nmUsage(nil, util.ChildNewtError(err))
+   }
+
c := xact.NewDeleteResCmd()
c.SetTxOptions(nmutil.TxOptions())
c.Path = path
c.Typ = rt
+   c.Value = b
 
res, err := c.Run(s)
if err != nil {
diff --git a/nmxact/nmcoap/nmcoap.go b/nmxact/nmcoap/nmcoap.go
index 117f64d..4e5386c 100644
--- a/nmxact/nmcoap/nmcoap.go
+++ b/nmxact/nmcoap/nmcoap.go
@@ -132,15 +132,18 @@ func CreatePost(isTcp bool, resUri string, token []byte,
return m, nil
 }
 
-func CreateDelete(isTcp bool, resUri string, token []byte) (coap.Message, 
error) {
+func CreateDelete(isTcp bool, resUri string, token []byte,
+   val []byte) (coap.Message, error) {
+
if err := validateToken(token); err != nil {
return nil, err
}
 
p := coap.MessageParams{
-   Type:  coap.Confirmable,
-   Code:  coap.DELETE,
-   Token: token,
+   Type:coap.Confirmable,
+   Code:coap.DELETE,
+   Token:   token,
+   Payload: val,
}
 
m := buildMessage(isTcp, p)
diff --git a/nmxact/sesn/sesn_util.go b/nmxact/sesn/sesn_util.go
index 4bf51dd..d554682 100644
--- a/nmxact/sesn/sesn_util.go
+++ b/nmxact/sesn/sesn_util.go
@@ -102,9 +102,11 @@ func postResourceOnce(s Sesn, resType ResourceType,
 }
 
 func deleteResourceOnce(s Sesn, resType ResourceType,
-   uri string, opt TxOptions) (coap.COAPCode, []byte, error) {
+   uri string, value []byte,
+   opt TxOptions) (coap.COAPCode, []byte, error) {
 
-   req, err := nmcoap.CreateDelete(s.CoapIsTcp(), uri, nmxutil.NextToken())
+   req, err := nmcoap.CreateDelete(s.CoapIsTcp(), uri, nmxutil.NextToken(),
+   value)
if err != nil {
return 0, nil, err
}
@@ -178,10 +180,10 @@ func PostResource(s Sesn, resType ResourceType, uri 
string,
 }
 
 func DeleteResource(s Sesn, resType ResourceType, uri string,
-   o TxOptions) (coap.COAPCode, []byte, error) {
+   value []byte, o TxOptions) (coap.COAPCode, []byte, error) {
 
return txCoap(func() (coap.COAPCode, []byte, error) {
-   return deleteResourceOnce(s, resType, uri, o)
+   return deleteResourceOnce(s, resType, uri, value, o)
}, o.Tries)
 }
 
diff --git a/nmxact/xact/res.go b/nmxact/xact/res.go
index 7285b68..dc4819f 100644
--- a/nmxact/xact/res.go
+++ b/nmxact/xact/res.go
@@ -179,6 +179,7 @@ type DeleteResCmd struct {
CmdBase
Path string
Typ  sesn.ResourceType
+   Value []byte
 }
 
 func NewDeleteResCmd() *DeleteResCmd {
@@ -205,7 +206,7 @@ func (r *DeleteResResult) Status() int {
 }
 
 func (c *DeleteResCmd) Run(s sesn.Sesn) (Result, error) {
-   status, val, err := sesn.DeleteResource(s, c.Typ, c.Path, c.TxOptions())
+   status, val, err := sesn.DeleteResource(s, c.Typ, c.Path, c.Value, 
c.TxOptions())
if err != nil {
return nil, err
}


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

37 matches

Mail list logo