[GitHub] jacobrosenthal commented on issue #980: util/button: Use the button id in callback instead of button pointer

2018-03-30 Thread GitBox
jacobrosenthal commented on issue #980: util/button: Use the button id in callback instead of button pointer URL: https://github.com/apache/mynewt-core/pull/980#issuecomment-377655058 Separate from this. But thoughts on returning os callbacks to make these more newty. Could put which

[GitHub] ncasaril commented on issue #940: nrf52xxx_i2c: Fix to allow hal_i2c_clear_bus to read from input-buffer

2018-03-30 Thread GitBox
ncasaril commented on issue #940: nrf52xxx_i2c: Fix to allow hal_i2c_clear_bus to read from input-buffer URL: https://github.com/apache/mynewt-core/pull/940#issuecomment-377636234 @vrahane I think I understand that it would need to be resolved to a port, but the same thing would then

[GitHub] ccollins476ad commented on issue #934: util/parse - Additional parsing functions.

2018-03-30 Thread GitBox
ccollins476ad commented on issue #934: util/parse - Additional parsing functions. URL: https://github.com/apache/mynewt-core/pull/934#issuecomment-377631716 FYI- there was a bug in parsing address strings with leading double colons (e.g., "::1:2:3:4"). I just force pushed a fix.

[GitHub] mlampert opened a new pull request #983: Some fixes for C++ compatibility.

2018-03-30 Thread GitBox
mlampert opened a new pull request #983: Some fixes for C++ compatibility. URL: https://github.com/apache/mynewt-core/pull/983 Ran into issues compiling a C++ source code with `arm-none-eabi-c++ (15:6.3.1+svn253039-1+b1) 6.3.1 20170620`

[GitHub] mlampert commented on issue #947: Refactor/easing library

2018-03-30 Thread GitBox
mlampert commented on issue #947: Refactor/easing library URL: https://github.com/apache/mynewt-core/pull/947#issuecomment-377616242 A general comment on the "precision" question. I love the library, use it all the time ever since the PR was posted the first time. Yet, as is it is

[GitHub] mlampert commented on a change in pull request #947: Refactor/easing library

2018-03-30 Thread GitBox
mlampert commented on a change in pull request #947: Refactor/easing library URL: https://github.com/apache/mynewt-core/pull/947#discussion_r178368672 ## File path: util/easing/src/easing.c ## @@ -69,125 +69,128 @@ static inline float quadratic_in(float step, float

[GitHub] mlampert commented on a change in pull request #947: Refactor/easing library

2018-03-30 Thread GitBox
mlampert commented on a change in pull request #947: Refactor/easing library URL: https://github.com/apache/mynewt-core/pull/947#discussion_r178368672 ## File path: util/easing/src/easing.c ## @@ -69,125 +69,128 @@ static inline float quadratic_in(float step, float

[GitHub] mlampert commented on a change in pull request #947: Refactor/easing library

2018-03-30 Thread GitBox
mlampert commented on a change in pull request #947: Refactor/easing library URL: https://github.com/apache/mynewt-core/pull/947#discussion_r178368006 ## File path: util/easing/src/easing.c ## @@ -43,12 +43,12 @@ static inline float exponential_out(float step, float

[GitHub] mlampert commented on a change in pull request #947: Refactor/easing library

2018-03-30 Thread GitBox
mlampert commented on a change in pull request #947: Refactor/easing library URL: https://github.com/apache/mynewt-core/pull/947#discussion_r178365725 ## File path: util/easing/src/easing.c ## @@ -69,125 +69,128 @@ static inline float quadratic_in(float step, float

[GitHub] ccollins476ad opened a new issue #24: Helper functions for subscribing to notifications / indications

2018-03-30 Thread GitBox
ccollins476ad opened a new issue #24: Helper functions for subscribing to notifications / indications URL: https://github.com/apache/mynewt-nimble/issues/24 Currently, an application subscribes to notifications or indications by performing a GATT write procedure on the appropriate CCCD.

[GitHub] vrahane commented on issue #940: nrf52xxx_i2c: Fix to allow hal_i2c_clear_bus to read from input-buffer

2018-03-30 Thread GitBox
vrahane commented on issue #940: nrf52xxx_i2c: Fix to allow hal_i2c_clear_bus to read from input-buffer URL: https://github.com/apache/mynewt-core/pull/940#issuecomment-377584468 @ncasaril hope you got what I mean in the above comment ?

[GitHub] vrahane closed pull request #982: Requesting-lp5523_registers enum additions to lp5523.h

2018-03-30 Thread GitBox
vrahane closed pull request #982: Requesting-lp5523_registers enum additions to lp5523.h URL: https://github.com/apache/mynewt-core/pull/982 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] vrahane commented on issue #982: Requesting-lp5523_registers enum additions to lp5523.h

2018-03-30 Thread GitBox
vrahane commented on issue #982: Requesting-lp5523_registers enum additions to lp5523.h URL: https://github.com/apache/mynewt-core/pull/982#issuecomment-377579698 Already merged. This is an automated message from the Apache

[GitHub] JustineKH opened a new pull request #982: Requesting-lp5523_registers enum additions to lp5523.h

2018-03-30 Thread GitBox
JustineKH opened a new pull request #982: Requesting-lp5523_registers enum additions to lp5523.h URL: https://github.com/apache/mynewt-core/pull/982 Tabs to spaces--rebased This is an automated message from the Apache Git

[mynewt-core] branch master updated: Requesting-lp5523_registers enum additions to lp5523.h (#981)

2018-03-30 Thread vipulrahane
This is an automated email from the ASF dual-hosted git repository. vipulrahane pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new cdf5ed9 Requesting-lp5523_registers

[GitHub] vrahane closed pull request #981: Requesting-lp5523_registers enum additions to lp5523.h

2018-03-30 Thread GitBox
vrahane closed pull request #981: Requesting-lp5523_registers enum additions to lp5523.h URL: https://github.com/apache/mynewt-core/pull/981 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] JustineKH opened a new pull request #981: Requesting-lp5523_registers enum additions to lp5523.h

2018-03-30 Thread GitBox
JustineKH opened a new pull request #981: Requesting-lp5523_registers enum additions to lp5523.h URL: https://github.com/apache/mynewt-core/pull/981 Added lp5523 register values to lp5523_resgister enum. This is an

[mynewt-core] branch master updated (2268a67 -> 9c38bea)

2018-03-30 Thread ccollins
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 2268a67 Fix boot_serial to follow flash write alignment add 9d1e7bd Don't include os/mynewt.h from

[GitHub] ccollins476ad closed pull request #979: Don't include os/mynewt.h from primitive headers.

2018-03-30 Thread GitBox
ccollins476ad closed pull request #979: Don't include os/mynewt.h from primitive headers. URL: https://github.com/apache/mynewt-core/pull/979 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sdalu opened a new pull request #980: util/button: Use the button id in callback instead of button pointer

2018-03-30 Thread GitBox
sdalu opened a new pull request #980: util/button: Use the button id in callback instead of button pointer URL: https://github.com/apache/mynewt-core/pull/980 It doesn't look useful to have the whole button structure exposed in the user callback

[GitHub] utzig closed pull request #978: Fix boot_serial to follow flash write alignment

2018-03-30 Thread GitBox
utzig closed pull request #978: Fix boot_serial to follow flash write alignment URL: https://github.com/apache/mynewt-core/pull/978 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[mynewt-core] branch master updated: Fix slot0 size in f3disco to avoid writing after end

2018-03-30 Thread utzig
This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new ebc6bd1 Fix slot0 size in f3disco to avoid

[mynewt-core] branch master updated: Fix boot_serial to follow flash write alignment

2018-03-30 Thread utzig
This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 2268a67 Fix boot_serial to follow flash

[GitHub] utzig closed pull request #977: Fix slot0 size in f3disco to avoid writing after end

2018-03-30 Thread GitBox
utzig closed pull request #977: Fix slot0 size in f3disco to avoid writing after end URL: https://github.com/apache/mynewt-core/pull/977 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[mynewt-core] branch master updated: Fix stm32f3 uart overrun handling

2018-03-30 Thread utzig
This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 14d8ce3 Fix stm32f3 uart overrun handling

[GitHub] utzig closed pull request #975: Fix stm32f3 uart overrun handling

2018-03-30 Thread GitBox
utzig closed pull request #975: Fix stm32f3 uart overrun handling URL: https://github.com/apache/mynewt-core/pull/975 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull