[GitHub] [mynewt-core] utzig commented on issue #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on issue #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#issuecomment-508870616 Yes, we add them by hand. Your looks correct and I am not sure why RAT did not identify it; I'll check later. --

[GitHub] [mynewt-core] agross-korg commented on issue #1906: hw/bsp/dialog: Add generation of dialog header on images

agross-korg commented on issue #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#issuecomment-508853069 Do we typically add the license headers by hand or use RAT? I don't think this one needs to be excluded, does it? ---

[GitHub] [mynewt-core] agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300786949 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282

[GitHub] [mynewt-core] agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300786959 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282

[GitHub] [mynewt-core] agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300786928 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282

[GitHub] [mynewt-core] agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300786869 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282

[GitHub] [mynewt-core] agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300786891 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282

[GitHub] [mynewt-core] agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300786851 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282

[GitHub] [mynewt-core] agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300786764 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282

[GitHub] [mynewt-core] agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300738348 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282

[GitHub] [mynewt-core] agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300733978 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282

[GitHub] [mynewt-core] agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

agross-korg commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300733787 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282

[GitHub] [mynewt-core] utzig commented on issue #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on issue #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#issuecomment-508801322 @agross-korg Also you need to include a commit adding the script to `/.rat-excludes`. RAT is so awesome that you can just edi

[GitHub] [mynewt-core] utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300730268 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282 @@ +#!

[GitHub] [mynewt-core] utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300729745 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282 @@ +#!

[GitHub] [mynewt-core] utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300728822 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282 @@ +#!

[GitHub] [mynewt-core] utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300730411 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282 @@ +#!

[GitHub] [mynewt-core] utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300729387 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282 @@ +#!

[GitHub] [mynewt-core] utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300727947 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282 @@ +#!

[GitHub] [mynewt-core] utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300732615 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282 @@ +#!

[GitHub] [mynewt-core] utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300732310 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282 @@ +#!

[GitHub] [mynewt-core] utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300729320 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282 @@ +#!

[GitHub] [mynewt-core] utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images

utzig commented on a change in pull request #1906: hw/bsp/dialog: Add generation of dialog header on images URL: https://github.com/apache/mynewt-core/pull/1906#discussion_r300730734 ## File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_header_tool.py ## @@ -0,0 +1,282 @@ +#!

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration

andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration URL: https://github.com/apache/mynewt-nimble/pull/508#discussion_r300707183 ## File path: porting/npl/riot/include/syscfg/syscfg.h ## @@ -830,7 +830,8 @@ #endif

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration

andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration URL: https://github.com/apache/mynewt-nimble/pull/508#discussion_r300705983 ## File path: porting/npl/riot/include/syscfg/syscfg.h ## @@ -830,7 +830,8 @@ #endif

[GitHub] [mynewt-core] mlaz merged pull request #1907: Changing the device closed by battery_adc_close

mlaz merged pull request #1907: Changing the device closed by battery_adc_close URL: https://github.com/apache/mynewt-core/pull/1907 This is an automated message from the Apache Git Service. To respond to the message, please

[mynewt-core] branch master updated: close the correct device in battery_adc_close

This is an automated email from the ASF dual-hosted git repository. mlaz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new c2579ed close the correct device in battery_

[GitHub] [mynewt-nimble] haukepetersen commented on a change in pull request #508: npl/riot: strip down the default configuration

haukepetersen commented on a change in pull request #508: npl/riot: strip down the default configuration URL: https://github.com/apache/mynewt-nimble/pull/508#discussion_r300701575 ## File path: porting/npl/riot/include/syscfg/syscfg.h ## @@ -830,7 +830,8 @@ #endif #if

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration

andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration URL: https://github.com/apache/mynewt-nimble/pull/508#discussion_r300697476 ## File path: porting/npl/riot/include/syscfg/syscfg.h ## @@ -830,7 +830,8 @@ #endif

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum

andrzej-kaczmarek commented on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum URL: https://github.com/apache/mynewt-nimble/pull/477#issuecomment-508759910 Note: to the best of my knowledge things work in NimBLE as I describe below, but there is very slight chance that so

[GitHub] [mynewt-nimble] haukepetersen opened a new pull request #508: npl/riot: strip down the default configuration

haukepetersen opened a new pull request #508: npl/riot: strip down the default configuration URL: https://github.com/apache/mynewt-nimble/pull/508 The intention for the NimBLE RIOT port is to provide a rather simplistic default configuration, which can be extended from inside the RIOT buil

[GitHub] [mynewt-nimble] haukepetersen commented on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum

haukepetersen commented on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum URL: https://github.com/apache/mynewt-nimble/pull/477#issuecomment-508702215 so from what I learned, I further disabled the controller's data length extension by default for the RIOT port. As the `

[GitHub] [mynewt-nimble] haukepetersen commented on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum

haukepetersen commented on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum URL: https://github.com/apache/mynewt-nimble/pull/477#issuecomment-508676739 Oh, I am too tired this morning, everything I needed is actually in the email archive posted above... To summariz

[GitHub] [mynewt-nimble] haukepetersen commented on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum

haukepetersen commented on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum URL: https://github.com/apache/mynewt-nimble/pull/477#issuecomment-508669650 @simonratner my browser did not refresh in properly, so I only saw your comment just now. Could you maybe elaborate, whe

[GitHub] [mynewt-nimble] haukepetersen edited a comment on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum

haukepetersen edited a comment on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum URL: https://github.com/apache/mynewt-nimble/pull/477#issuecomment-508668178 This discussion is quite fruitful for me, and I hope I don't start to annoy anyone :-) To go forward, I'd

[GitHub] [mynewt-nimble] haukepetersen commented on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum

haukepetersen commented on issue #477: npl/riot: reduce default MSYS_1_BLOCK_SIZE to minimum URL: https://github.com/apache/mynewt-nimble/pull/477#issuecomment-508668178 This discussion is quite fruitful for me, and I hope I don't start to annoy anyone :-) To go forward, I'd like to