[GitHub] [mynewt-newt] ccollins476ad closed pull request #360: Allow project.yml to override version commits
ccollins476ad closed pull request #360: Allow project.yml to override version commits URL: https://github.com/apache/mynewt-newt/pull/360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-newt] ccollins476ad opened a new pull request #361: Allow repo hash to correspond to version number
ccollins476ad opened a new pull request #361: Allow repo hash to correspond to version number URL: https://github.com/apache/mynewt-newt/pull/361 When resolving repo versions, newt uses this procedure: 1. Resolve inter-repo dependencies. 2. Resolve project.yml dependencies. Allow project.yml to override dependencies from step 1. There was a bug affecting both steps in the procedure. If a dependency specifies a commit hash that corresponds exactly to a version number, then the dependency was ignored. This PR fixes the problem so that commit hashes are always honored, whether or not they correspond to version numbers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-newt] ccollins476ad opened a new pull request #360: Allow project.yml to override version commits
ccollins476ad opened a new pull request #360: Allow project.yml to override version commits URL: https://github.com/apache/mynewt-newt/pull/360 When resolving repo versions, newt uses this procedure: 1. Resolve inter-repo dependencies. 2. Resolve project.yml dependencies. Allow project.yml to override dependencies from step 1. There was a bug in step 2. If `project.yml` specifies a commit hash that corresponds exactly to a version number, then the override was ignored. This PR fixes the problem so that a project.yml override is always used. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #730: nimble/host: Fix setting connection flags after pairing
andrzej-kaczmarek opened a new pull request #730: nimble/host: Fix setting connection flags after pairing URL: https://github.com/apache/mynewt-nimble/pull/730 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-mcumgr] mlaz merged pull request #46: Zephyr support
mlaz merged pull request #46: Zephyr support URL: https://github.com/apache/mynewt-mcumgr/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-mcumgr] branch master updated: DFU working on zephyr
This is an automated email from the ASF dual-hosted git repository. mlaz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-mcumgr.git The following commit(s) were added to refs/heads/master by this push: new 384dc8e DFU working on zephyr new 2424f04 Merge pull request #46 from mlaz/run_zephyr 384dc8e is described below commit 384dc8e1c4e9f1aff981d1d51a55cad65f5f6d44 Author: Miguel Azevedo AuthorDate: Sat Nov 2 19:54:50 2019 + DFU working on zephyr --- cborattr/Kconfig | 22 -- cborattr/src/cborattr.c| 16 +- cmd/fs_mgmt/port/zephyr/src/zephyr_fs_mgmt.c | 2 +- cmd/img_mgmt/CMakeLists.txt| 2 +- cmd/img_mgmt/include/img_mgmt/img_mgmt_config.h| 6 +- cmd/img_mgmt/include/img_mgmt/img_mgmt_impl.h | 2 +- cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c | 257 - cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt_log.c | 90 cmd/img_mgmt/src/img_mgmt.c| 6 +- cmd/img_mgmt/src/img_mgmt_state.c | 1 + cmd/log_mgmt/CMakeLists.txt| 4 +- cmd/log_mgmt/Kconfig | 59 - cmd/os_mgmt/port/zephyr/src/zephyr_os_mgmt.c | 2 +- cmd/os_mgmt/src/os_mgmt.c | 1 + cmd/stat_mgmt/port/zephyr/src/zephyr_stat_mgmt.c | 4 +- mgmt/src/mgmt.c| 1 + samples/smp_svr/zephyr/CMakeLists.txt | 2 + samples/smp_svr/zephyr/prj.conf| 2 +- samples/smp_svr/zephyr/src/main.c | 5 +- smp/src/smp.c | 2 +- 20 files changed, 380 insertions(+), 106 deletions(-) diff --git a/cborattr/Kconfig b/cborattr/Kconfig deleted file mode 100644 index ed54c7a..000 --- a/cborattr/Kconfig +++ /dev/null @@ -1,22 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE image -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this image -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this image except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# Under the License. - -config CBORATTR_MAX_SIZE -int "Maximum chunk size for image uploads" -default 512 -help - The maximum size of a CBOR attribute during decoding diff --git a/cborattr/src/cborattr.c b/cborattr/src/cborattr.c index 662836a..e94a490 100644 --- a/cborattr/src/cborattr.c +++ b/cborattr/src/cborattr.c @@ -17,24 +17,23 @@ * under the License. */ -//#include #include "cborattr/cborattr.h" #include "tinycbor/cbor.h" #include "tinycbor/cbor_buf_reader.h" +#ifdef __ZEPHYR__ +#include +#define CBORATTR_MAX_SIZE CONFIG_MGMT_CBORATTR_MAX_SIZE +#endif + #ifdef MYNEWT +#include "syscfg/syscfg.h" #include "tinycbor/cbor_mbuf_reader.h" #include "tinycbor/cbor_mbuf_writer.h" #include "os/os_mbuf.h" #define CBORATTR_MAX_SIZE MYNEWT_VAL(CBORATTR_MAX_SIZE) -#else -#define CBORATTR_MAX_SIZE CONFIG_CBORATTR_MAX_SIZE #endif - -static int cbor_write_val(struct CborEncoder *enc, - const struct cbor_out_val_t *val); - /* this maps a CborType to a matching CborAtter Type. The mapping is not * one-to-one because of signedness of integers * and therefore we need a function to do this trickery */ @@ -409,6 +408,9 @@ cbor_read_flat_attrs(const uint8_t *data, int len, } #ifdef MYNEWT +static int cbor_write_val(struct CborEncoder *enc, + const struct cbor_out_val_t *val); + /* * Read in cbor key/values from os_mbuf pointed by m, and fill them * into attrs. diff --git a/cmd/fs_mgmt/port/zephyr/src/zephyr_fs_mgmt.c b/cmd/fs_mgmt/port/zephyr/src/zephyr_fs_mgmt.c index 231a0f8..66af8c4 100644 --- a/cmd/fs_mgmt/port/zephyr/src/zephyr_fs_mgmt.c +++ b/cmd/fs_mgmt/port/zephyr/src/zephyr_fs_mgmt.c @@ -17,7 +17,7 @@ * under the License. */ -#include +#include #include #include diff --git a/cmd/img_mgmt/CMakeLists.txt b/cmd/img_mgmt/CMakeLists.txt index 1166d7d..3c54e05 100644 --- a/cmd/img_mgmt/CMakeLists.txt +++ b/cmd/img_mgmt/CMakeLists.txt @@ -4,8 +4,8 @@ target_include_directories(MCUMGR INTERFACE zephyr_library_sources( port/zephyr/src/zephyr_img_mgmt.c +port/zephyr/src/zephyr_img_mgmt_log.c src/img_mgmt.c src/img_mgmt_state.c src/img_mgmt_util.c -src/stubs.c ) diff --git
[GitHub] [mynewt-nimble] wnnwoo commented on issue #712: A case in ble_ll_sched_adv_reschedule
wnnwoo commented on issue #712: A case in ble_ll_sched_adv_reschedule URL: https://github.com/apache/mynewt-nimble/issues/712#issuecomment-573721791 Dose my blog resole ur question? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] haukepetersen merged pull request #729: npl/riot: adapt to xtimer API change
haukepetersen merged pull request #729: npl/riot: adapt to xtimer API change URL: https://github.com/apache/mynewt-nimble/pull/729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-nimble] branch master updated: npl/riot: adapt to xtimer API change
This is an automated email from the ASF dual-hosted git repository.
hauke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git
The following commit(s) were added to refs/heads/master by this push:
new 37245d0 npl/riot: adapt to xtimer API change
37245d0 is described below
commit 37245d0c3f239c35c0c734a337c7b6301fcfd70b
Author: Hauke Petersen
AuthorDate: Mon Jan 13 15:12:39 2020 +0100
npl/riot: adapt to xtimer API change
---
porting/npl/riot/include/nimble/nimble_npl_os.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/porting/npl/riot/include/nimble/nimble_npl_os.h
b/porting/npl/riot/include/nimble/nimble_npl_os.h
index 67eb74e..61c1ea8 100644
--- a/porting/npl/riot/include/nimble/nimble_npl_os.h
+++ b/porting/npl/riot/include/nimble/nimble_npl_os.h
@@ -209,7 +209,7 @@ ble_npl_callout_stop(struct ble_npl_callout *co)
static inline bool
ble_npl_callout_is_active(struct ble_npl_callout *c)
{
-return (c->timer.target || c->timer.long_target);
+return (c->timer.offset || c->timer.long_offset);
}
static inline ble_npl_time_t
[GitHub] [mynewt-nimble] haukepetersen opened a new pull request #729: npl/riot: adapt to xtimer API change
haukepetersen opened a new pull request #729: npl/riot: adapt to xtimer API change URL: https://github.com/apache/mynewt-nimble/pull/729 The `xtimer` API in RIOT was recently changed (see https://github.com/RIOT-OS/RIOT/pull/9530). So far, this change was applied to nimble in RIOT using a patch in RIOTs package system. This PR upstreams that fix to NimBLE. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] sjanc opened a new issue #2156: Update NRFX to 2.0
sjanc opened a new issue #2156: Update NRFX to 2.0 URL: https://github.com/apache/mynewt-core/issues/2156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] sjanc commented on issue #728: Update NRFX to 2.0
sjanc commented on issue #728: Update NRFX to 2.0 URL: https://github.com/apache/mynewt-nimble/issues/728#issuecomment-573657249 this should be on core :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] sjanc closed issue #728: Update NRFX to 2.0
sjanc closed issue #728: Update NRFX to 2.0 URL: https://github.com/apache/mynewt-nimble/issues/728 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-nimble] branch master updated: nimble/ll: Fix setting anchor point and WFR for sync PDUs
This is an automated email from the ASF dual-hosted git repository.
janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git
The following commit(s) were added to refs/heads/master by this push:
new 713914f nimble/ll: Fix setting anchor point and WFR for sync PDUs
713914f is described below
commit 713914f1cad2f4a6328d6e5b2b11ed3f04224884
Author: Szymon Janc
AuthorDate: Fri Jan 10 15:07:26 2020 +0100
nimble/ll: Fix setting anchor point and WFR for sync PDUs
Don't set anchor point in the middle of expected window for first
packet. Now we set anchor to calculated point in time and adjust
WFR with window widenning (and offset if synchronizing).
This was affecting pass rate when repeatedly running periodic
advertising and sync transfer tests. Especially LL/CON/SLA/BV-105-C
and LL/CON/MAS/BV-101-C.
---
nimble/controller/src/ble_ll_sync.c | 49 ++---
1 file changed, 8 insertions(+), 41 deletions(-)
diff --git a/nimble/controller/src/ble_ll_sync.c
b/nimble/controller/src/ble_ll_sync.c
index 2bae8e2..8645e91 100644
--- a/nimble/controller/src/ble_ll_sync.c
+++ b/nimble/controller/src/ble_ll_sync.c
@@ -475,11 +475,16 @@ ble_ll_sync_event_start_cb(struct ble_ll_sched_item *sch)
*/
sm->flags |= BLE_LL_SYNC_SM_FLAG_SET_ANCHOR;
-/* set wfr timer, for first PDU pointed with AuxPtr we use offset
- * unit, for other PDU we use current window widening
+/* Set WFR timer.
+ * If establishing we always adjust with offset unit.
+ * If this is first packet of sync (one that was pointed by from
+ * SyncInfo we don't adjust WFT with window widening.
*/
-if (sm->flags & BLE_LL_SYNC_SM_FLAG_SYNC_INFO) {
+if (sm->flags & BLE_LL_SYNC_SM_FLAG_ESTABLISHING) {
wfr_usecs = (sm->flags & BLE_LL_SYNC_SM_FLAG_OFFSET_300) ? 300 :
30;
+if (!(sm->flags & BLE_LL_SYNC_SM_FLAG_SYNC_INFO)) {
+wfr_usecs += 2 * sm->window_widening;
+}
} else {
wfr_usecs = 2 * sm->window_widening;
}
@@ -1141,18 +1146,6 @@ ble_ll_sync_next_event(struct ble_ll_sync_sm *sm,
uint32_t cur_ww_adjust)
return -1;
}
-/* if we are establishing, adjust window widening with offset unit
- * uncertainty, since we set anchor point in the middle of offset window
- * it is enough to adjust for half of offset
- */
-if (sm->flags & BLE_LL_SYNC_SM_FLAG_ESTABLISHING) {
-if (sm->flags & BLE_LL_SYNC_SM_FLAG_OFFSET_300) {
-cur_ww += 150;
-} else {
-cur_ww += 15;
-}
-}
-
cur_ww += BLE_LL_JITTER_USECS;
/* if updated anchor is pass last anchor + timeout it means we will not be
@@ -1401,19 +1394,6 @@ ble_ll_sync_info_event(const uint8_t *addr, uint8_t
addr_type, int rpa_index,
sm->anchor_point = sm->sch.start_time + g_ble_ll_sched_offset_ticks;
sm->anchor_point_usecs = sm->sch.remainder;
-
-/* set anchor point in middle of offset window */
-if (sm->flags & BLE_LL_SYNC_SM_FLAG_OFFSET_300) {
-sm->anchor_point_usecs += 150;
-} else {
-sm->anchor_point_usecs += 15;
-}
-
-while (sm->anchor_point_usecs >= 31) {
-sm->anchor_point++;
-sm->anchor_point_usecs -= 31;
-}
-
sm->last_anchor_point = sm->anchor_point;
#if MYNEWT_VAL(BLE_VERSION) >= 51
@@ -1794,7 +1774,6 @@ ble_ll_sync_transfer_get(const uint8_t *addr, uint8_t
addr_type, uint8_t sid)
memcpy(>adv_addr, addr, BLE_DEV_ADDR_LEN);
sm->flags |= BLE_LL_SYNC_SM_FLAG_ESTABLISHING;
-sm->flags |= BLE_LL_SYNC_SM_FLAG_SYNC_INFO;
return sm;
}
}
@@ -2003,18 +1982,6 @@ ble_ll_sync_periodic_ind(struct ble_ll_conn_sm *connsm,
sm->anchor_point = sm->sch.start_time + g_ble_ll_sched_offset_ticks;
sm->anchor_point_usecs = sm->sch.remainder;
-/* set anchor point in middle of offset window */
-if (sm->flags & BLE_LL_SYNC_SM_FLAG_OFFSET_300) {
-sm->anchor_point_usecs += 150;
-} else {
-sm->anchor_point_usecs += 15;
-}
-
-while (sm->anchor_point_usecs >= 31) {
-sm->anchor_point++;
-sm->anchor_point_usecs -= 31;
-}
-
if (reports_disabled) {
sm->flags |= BLE_LL_SYNC_SM_FLAG_DISABLED;
}
[GitHub] [mynewt-nimble] sjanc merged pull request #727: nimble/ll: Fix setting anchor point and WFR for sync PDUs
sjanc merged pull request #727: nimble/ll: Fix setting anchor point and WFR for sync PDUs URL: https://github.com/apache/mynewt-nimble/pull/727 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] sjanc commented on issue #727: nimble/ll: Fix setting anchor point and WFR for sync PDUs
sjanc commented on issue #727: nimble/ll: Fix setting anchor point and WFR for sync PDUs URL: https://github.com/apache/mynewt-nimble/pull/727#issuecomment-573636032 @haukepetersen seems like riot port is broken with latest master, could you check this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2155: WIP - add travis checking of coding style
utzig commented on issue #2155: WIP - add travis checking of coding style URL: https://github.com/apache/mynewt-core/pull/2155#issuecomment-573582156 @sjanc I agree, but my idea is to not enforce anything, this check should never fail the CI at least in the beginning, it'll be only for informational purposes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] sjanc opened a new issue #728: Update NRFX to 2.0
sjanc opened a new issue #728: Update NRFX to 2.0 URL: https://github.com/apache/mynewt-nimble/issues/728 This is needed to add support for latest chips from Nordic. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] JaydenH215 commented on issue #712: A case in ble_ll_sched_adv_reschedule
JaydenH215 commented on issue #712: A case in ble_ll_sched_adv_reschedule
URL: https://github.com/apache/mynewt-nimble/issues/712#issuecomment-573572939
> Yes, it may overlap the next_sch
>
> and the procedure will judge whether it is overlapped it in the next
iteration in this while loop, the procedure will go and find the right position
until the end of the Q.
>
> U can refer this doc.
> https://wnnwoo.github.io/2020/01/05/nimble-scheduler/
```
if (entry == end_overlap) {
rand_ticks = (orig_start + max_delay_ticks) - sch->start_time;
if (rand_ticks > max_delay_ticks) {
/* No place for advertisement. */
rc = -1;
} else {
if (next_sch == NULL) {
TAILQ_INSERT_TAIL(_ble_ll_sched_q, sch, link);
} else {
TAILQ_INSERT_BEFORE(next_sch, sch, link);
}
}
break;
}
```
But the latter condition should be true, it will 'break' and will not enter
the while again.
I have read your blog and thank you for sharing. I am also learning nimble
and hope to make friends with you.
[https://jaydenh215.github.io/](https://jaydenh215.github.io/)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] sjanc commented on issue #2155: WIP - add travis checking of coding style
sjanc commented on issue #2155: WIP - add travis checking of coding style URL: https://github.com/apache/mynewt-core/pull/2155#issuecomment-573571887 I think we should also clarify our coding style docs with any rule that is enforced byt this script. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #717: Add more detail about the MACRO description
sjanc commented on a change in pull request #717: Add more detail about the
MACRO description
URL: https://github.com/apache/mynewt-nimble/pull/717#discussion_r365700276
##
File path: nimble/controller/include/controller/ble_ll_sched.h
##
@@ -31,13 +31,13 @@ extern "C" {
/*
* Worst case time needed for scheduled advertising item. This is the longest
* possible time to receive a scan request and send a scan response (with the
- * appropriate IFS time between them). This number is calculated using the
+ * appropriate IFS time between them) on LE Uncoded PHY 1M. This number is
calculated using the
Review comment:
Yeap, I'm fine with emphasizing that this is for legacy PDUs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] sjanc commented on issue #712: A case in ble_ll_sched_adv_reschedule
sjanc commented on issue #712: A case in ble_ll_sched_adv_reschedule URL: https://github.com/apache/mynewt-nimble/issues/712#issuecomment-573557791 Hi, Since our documentation needs improvements, it would be great if you consider updating it with your notes and send PR :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
