[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2258: Documentation SGM4056

2020-04-01 Thread GitBox
apache-mynewt-bot commented on issue #2258: Documentation SGM4056
URL: https://github.com/apache/mynewt-core/pull/2258#issuecomment-607345354
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] ccollins476ad commented on a change in pull request #392: Update documentation for mfg create

2020-04-01 Thread GitBox
ccollins476ad commented on a change in pull request #392: Update documentation 
for mfg create
URL: https://github.com/apache/mynewt-newt/pull/392#discussion_r401717802
 
 

 ##
 File path: docs/command_list/newt_mfg.rst
 ##
 @@ -87,16 +87,25 @@ The ``rb_blinky_rsa`` package needs a pkg.yml file. In 
addition it is needs a mf
 .. code-block:: console
 
 $  more mfgs/rb_blinky_rsa/mfg.yml
-mfg.bootloader: 'targets/rb_boot'
-mfg.images:
-- 'targets/rb_blinky'
+mfg.bsp: "@apache-mynewt-core/hw/bsp/rb-nano2"
+mfg.targets:
+- rb_boot:
+  name: "targets/rb_boot"
+  area: FLASH_AREA_BOOTLOADER
+  offset: 0x0
+- rb_blinky:
+  name: "targets/rb_blinky"
+  area: FLASH_AREA_IMAGE_0
+  offset: 0x0
+mfg.meta:
+area: FLASH_AREA_BOOTLOADER
 
 Build the bootloader and app images.
 
 .. code-block:: console
 
-$ newt build rb_boot
-$ newt create-image rb_blinky 0.0.1
+$ newt build rb_boot && newt create-image rb_boot 0.0.1
 
 Review comment:
   Assuming `rb_boot` is a boot loader target, that should be `newt build 
rb_boot` (rather than `newt create-image rb_boot 0.0.1`).
   
   `create-image` would also work, but it creates an unnecessary `.img` file 
with an image header (and it requires you to specify a version number that 
doesn't get included anywhere).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[mynewt-core] branch master updated: docs/os/bsp: Add board support section

2020-04-01 Thread mlaz
This is an automated email from the ASF dual-hosted git repository.

mlaz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
 new 3c0dda3  docs/os/bsp: Add board support section
 new aa3578d  Merge pull request #2254 from caspermeijn/doc-pinetime
3c0dda3 is described below

commit 3c0dda32c5e6bd099e272f3e409a5bec9e68e24d
Author: Casper Meijn 
AuthorDate: Sat Mar 28 23:02:02 2020 +0100

docs/os/bsp: Add board support section

Add a new section to the documentation which lists the status of BSPs.
The first page is the status of the PineTime BSP.
---
 docs/os/bsp/index.rst | 28 
 docs/os/bsp/pinetime.rst  | 41 +
 docs/os/os_user_guide.rst |  1 +
 3 files changed, 70 insertions(+)

diff --git a/docs/os/bsp/index.rst b/docs/os/bsp/index.rst
new file mode 100644
index 000..933cdca
--- /dev/null
+++ b/docs/os/bsp/index.rst
@@ -0,0 +1,28 @@
+..
+  #
+  # Copyright 2020 Casper Meijn 
+  #
+  # Licensed under the Apache License, Version 2.0 (the "License");
+  # you may not use this file except in compliance with the License.
+  # You may obtain a copy of the License at
+  #
+  # http://www.apache.org/licenses/LICENSE-2.0
+  #
+  # Unless required by applicable law or agreed to in writing, software
+  # distributed under the License is distributed on an "AS IS" BASIS,
+  # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  # See the License for the specific language governing permissions and
+  # limitations under the License.
+  #
+
+Board support
+=
+
+This section lists some of the supported boards, their current status and 
+links to tutorial specific to the board. A list of all supported boards can
+be found in `@apache-mynewt-core/hw/bsp 
`__.
+
+.. toctree::
+:maxdepth: 1
+
+PineTime 
diff --git a/docs/os/bsp/pinetime.rst b/docs/os/bsp/pinetime.rst
new file mode 100644
index 000..615f014
--- /dev/null
+++ b/docs/os/bsp/pinetime.rst
@@ -0,0 +1,41 @@
+..
+  #
+  # Copyright 2020 Casper Meijn 
+  #
+  # Licensed under the Apache License, Version 2.0 (the "License");
+  # you may not use this file except in compliance with the License.
+  # You may obtain a copy of the License at
+  #
+  # http://www.apache.org/licenses/LICENSE-2.0
+  #
+  # Unless required by applicable law or agreed to in writing, software
+  # distributed under the License is distributed on an "AS IS" BASIS,
+  # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  # See the License for the specific language governing permissions and
+  # limitations under the License.
+  #
+
+PineTime smartwatch
+===
+
+This page is about the board support package for the Pine64 PineTime 
smartwatch. 
+You can find some general documentation at the `device wiki 
`__. 
+You could buy a dev kit in the `store 
`__.
+
+.. contents::
+  :local:
+  :depth: 2
+
+Status
+~~
+
+Currently the status is: incomplete.
+
+The board support package contains the code for booting the device and the pin 
+definitions. This means you can load an application like blinky, but no 
+pheriphirals can be used. New drivers will be added in the future.
+
+Tutorials
+~
+
+-  :doc:`../../tutorials/blinky/pinetime`
diff --git a/docs/os/os_user_guide.rst b/docs/os/os_user_guide.rst
index 7f56ccc..806683b 100644
--- a/docs/os/os_user_guide.rst
+++ b/docs/os/os_user_guide.rst
@@ -22,6 +22,7 @@ OS User Guide
Test Utilities 
JSON 
Manufacturing support 
+   Board support 
 
 This guide provides comprehensive information about Mynewt OS, the
 real-time operating system for embedded systems. It is intended both for



[GitHub] [mynewt-core] mlaz merged pull request #2254: docs/os/bsp: Add board support section

2020-04-01 Thread GitBox
mlaz merged pull request #2254: docs/os/bsp: Add board support section
URL: https://github.com/apache/mynewt-core/pull/2254
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] caspermeijn opened a new pull request #2258: Documentation sgm4056

2020-04-01 Thread GitBox
caspermeijn opened a new pull request #2258: Documentation sgm4056
URL: https://github.com/apache/mynewt-core/pull/2258
 
 
   This add documentation pages for charger-control and the SGM4056 driver. See 
also the tutorial in https://github.com/apache/mynewt-documentation/pull/94.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[mynewt-core] branch master updated (c418c0c -> 9dee495)

2020-04-01 Thread mlaz
This is an automated email from the ASF dual-hosted git repository.

mlaz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git.


from c418c0c  Merge pull request #2257 from JuulLabs/id-serial_mfg
 new 048fb40  hw/drivers/chg_ctrl/sgm4056: Add SGM4056 driver
 new 17f7f5e  hw/drivers/chg_ctrl/sgm4056: Add charge control integration
 new 778a8f6  hw/bsp/pinetime: Enable SGM4056 charger driver
 new 9dee495  Merge pull request #2255 from caspermeijn/sgm4056

The 9571 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 hw/bsp/pinetime/pkg.yml|   1 +
 hw/bsp/pinetime/src/hal_bsp.c  |  15 ++
 .../chg_ctrl/sgm4056/include/sgm4056/sgm4056.h |  81 +
 hw/drivers/chg_ctrl/{bq24040 => sgm4056}/pkg.yml   |   9 +-
 hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c  | 202 +
 .../drivers/chg_ctrl/sgm4056}/syscfg.yml   |   4 +-
 6 files changed, 306 insertions(+), 6 deletions(-)
 create mode 100644 hw/drivers/chg_ctrl/sgm4056/include/sgm4056/sgm4056.h
 copy hw/drivers/chg_ctrl/{bq24040 => sgm4056}/pkg.yml (87%)
 create mode 100644 hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c
 copy {boot/stub => hw/drivers/chg_ctrl/sgm4056}/syscfg.yml (88%)



[GitHub] [mynewt-core] mlaz merged pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
mlaz merged pull request #2255: Add SGM4056 charger driver to pinetime BSP
URL: https://github.com/apache/mynewt-core/pull/2255
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] mlaz commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
mlaz commented on issue #2255: Add SGM4056 charger driver to pinetime BSP
URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607317147
 
 
   Looks good, thanks for the changes, @caspermeijn 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[mynewt-core] branch master updated: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-04-01 Thread benmccrea
This is an automated email from the ASF dual-hosted git repository.

benmccrea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
 new 7e4c027  sys/id: Add optional id/serial_mfg field for storing 
manufacturer serial numbers
 new c418c0c  Merge pull request #2257 from JuulLabs/id-serial_mfg
7e4c027 is described below

commit 7e4c02772b3d91f21a199f0cfd835f85d5e11120
Author: Ben McCrea 
AuthorDate: Tue Mar 31 19:46:13 2020 -0700

sys/id: Add optional id/serial_mfg field for storing manufacturer serial 
numbers
---
 sys/id/include/id/id.h |  8 
 sys/id/src/id.c| 15 +++
 sys/id/syscfg.yml  |  7 +++
 3 files changed, 30 insertions(+)

diff --git a/sys/id/include/id/id.h b/sys/id/include/id/id.h
index d730e93..8e20124 100644
--- a/sys/id/include/id/id.h
+++ b/sys/id/include/id/id.h
@@ -32,6 +32,14 @@ extern "C" {
 extern char id_serial[];
 #endif
 
+#if MYNEWT_VAL(ID_SERIAL_MFG_PRESENT)
+/*
+ * Maximum expected serial_mfg number string length.
+ */
+#define ID_SERIAL_MFG_MAX_LEN   MYNEWT_VAL(ID_SERIAL_MFG_MAX_LEN)
+extern char id_serial_mfg[];
+#endif
+
 #if MYNEWT_VAL(ID_MANUFACTURER_LOCAL)
 /*
  * Maximum expected manufacturer string length.
diff --git a/sys/id/src/id.c b/sys/id/src/id.c
index 79a7c87..4a6a2e5 100644
--- a/sys/id/src/id.c
+++ b/sys/id/src/id.c
@@ -51,6 +51,9 @@ const char *id_app_str = "";
 #if MYNEWT_VAL(ID_SERIAL_PRESENT)
 char id_serial[ID_SERIAL_MAX_LEN];
 #endif
+#if MYNEWT_VAL(ID_SERIAL_MFG_PRESENT)
+char id_serial_mfg[ID_SERIAL_MFG_MAX_LEN];
+#endif
 #if MYNEWT_VAL(ID_MANUFACTURER_LOCAL)
 char id_manufacturer[ID_MANUFACTURER_MAX_LEN];
 #endif
@@ -88,6 +91,10 @@ id_conf_get(int argc, char **argv, char *val, int 
val_len_max)
 } else if (!strcmp(argv[0], "serial")) {
 return (char *)id_serial;
 #endif
+#if MYNEWT_VAL(ID_SERIAL_MFG_PRESENT)
+} else if (!strcmp(argv[0], "serial_mfg")) {
+return (char *)id_serial_mfg;
+#endif
 #if MYNEWT_VAL(ID_MANUFACTURER_PRESENT)
 } else if (!strcmp(argv[0], "mfger")) {
 return (char *)id_manufacturer;
@@ -116,6 +123,11 @@ id_conf_set(int argc, char **argv, char *val)
 return CONF_VALUE_SET(val, CONF_STRING, id_serial);
 }
 #endif
+#if MYNEWT_VAL(ID_SERIAL_MFG_PRESENT)
+if (!strcmp(argv[0], "serial_mfg")) {
+return CONF_VALUE_SET(val, CONF_STRING, id_serial_mfg);
+}
+#endif
 #if MYNEWT_VAL(ID_MANUFACTURER_LOCAL)
 if (!strcmp(argv[0], "mfger")) {
 return CONF_VALUE_SET(val, CONF_STRING, id_manufacturer);
@@ -154,6 +166,9 @@ id_conf_export(void (*export_func)(char *name, char *val),
 #if MYNEWT_VAL(ID_SERIAL_PRESENT)
 export_func("id/serial", id_serial);
 #endif /* ID_SERIAL_PRESENT */
+#if MYNEWT_VAL(ID_SERIAL_MFG_PRESENT)
+export_func("id/serial_mfg", id_serial_mfg);
+#endif /* ID_SERIAL_MFG_PRESENT */
 #if MYNEWT_VAL(ID_MANUFACTURER_PRESENT)
 #if MYNEWT_VAL(ID_MANUFACTURER_LOCAL)
 export_func("id/mfger", id_manufacturer);
diff --git a/sys/id/syscfg.yml b/sys/id/syscfg.yml
index 107b804..3248708 100644
--- a/sys/id/syscfg.yml
+++ b/sys/id/syscfg.yml
@@ -24,6 +24,13 @@ syscfg.defs:
 description: Maximum length of id/serial value
 value: 64
 
+ID_SERIAL_MFG_PRESENT:
+description: 'Device manufacturing serial number exported as 
sys/id/serial_mfg.'
+value: 0
+ID_SERIAL_MFG_MAX_LEN:
+description: Maximum length of id/serial_mfg value
+value: 32
+
 ID_MANUFACTURER_PRESENT:
 description: 'Device manufacturer string exported as sys/id/mfger.'
 value: 0



[GitHub] [mynewt-core] benmccrea merged pull request #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number

2020-04-01 Thread GitBox
benmccrea merged pull request #2257: sys/id: Add optional id/serial_mfg field 
for storing manufacturer serial number
URL: https://github.com/apache/mynewt-core/pull/2257
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] dwld edited a comment on issue #391: Fix for @repo targets in mfg create

2020-04-01 Thread GitBox
dwld edited a comment on issue #391: Fix for @repo targets in mfg create
URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607291079
 
 
   @utzig, here is the output of the current master newt build as it is:
   ```
   $ newt -ldebug mfg create p_nrf52_ble 0.0.0.5
   ...
   2020/04/01 16:30:41.371 [DEBUG] goroutine 1 [running]:
   mynewt.apache.org/newt/util.NewNewtError(0xc0005a1760, 0xa3, 0xc7f190)
   C://Github/mynewt-newt/util/util.go:77 
+0xd3
   mynewt.apache.org/newt/util.FmtNewtError(0x84555a, 0x2, 0xc7f190, 0x1, 
0x1, 0x0)
   C://Github/mynewt-newt/util/util.go:84 
+0x72
   mynewt.apache.org/newt/newt/mfg.newMfgBuildTarget(0xc000150840, 0x12, 
0xc000150de0, 0x15, 0x0, 0x0, 0xc00067e210, 0x0, 0x0, 0x0, ...)
   
C://Github/mynewt-newt/newt/mfg/build.go:226 +0x59e
   mynewt.apache.org/newt/newt/mfg.newMfgBuilder(0xcc26e0, 0xc00043a120, 
0x2, 0x2, 0x0, 0x0, 0x0, 0xc00059d170, 0x0, 0x0, ...)
   
C://Github/mynewt-newt/newt/mfg/build.go:439 +0x255
   mynewt.apache.org/newt/newt/mfg.LoadMfgEmitter(0xcc26e0, 0x5, 
0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
   
C://Github/mynewt-newt/newt/mfg/misc.go:54 +0x15b
   mynewt.apache.org/newt/newt/cli.mfgCreateRunCmd(0xceec80, 0xc000108210, 
0x2, 0x3)
   
C://Github/mynewt-newt/newt/cli/mfg_cmds.go:117 
+0x1ba
   github.com/spf13/cobra.(*Command).execute(0xceec80, 0xc0001080f0, 0x3, 
0x3, 0xceec80, 0xc0001080f0)
   
C://go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:830
 +0x2b1
   github.com/spf13/cobra.(*Command).ExecuteC(0xc8cf00, 0x845c6b, 0x4, 0x7)
   
C://go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914
 +0x302
   github.com/spf13/cobra.(*Command).Execute(...)
   
C://go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:864
   main.main()
   C://Github/mynewt-newt/newt/newt.go:180 
+0x19e
   
   goroutine 6 [syscall]:
   os/signal.signal_recv(0x0)
   C:/Anwendungen/Go/src/runtime/sigqueue.go:147 +0xa3
   os/signal.loop()
   C:/Anwendungen/Go/src/os/signal/signal_unix.go:23 +0x29
   created by os/signal.init.0
   C:/Anwendungen/Go/src/os/signal/signal_unix.go:29 +0x48
   
   Error: failed to read manifest file: open 
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_boot/app/boot/mynewt/manifest.json:
 The system cannot find the path specified.
   ```
   
   With the fix, the command works for me and outputs the following paths as 
its inputs:
   ```
   $ newt -ldebug mfg create p_nrf52_ble 0.0.0.5
   ...
   Creating a manufacturing image from the following files:
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_ble/app/apps//manifest.json
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_ble/app/apps/.elf
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_ble/app/apps/.img
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_boot/app/@mcuboot/boot/mynewt/manifest.json
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_boot/app/@mcuboot/boot/mynewt/mynewt.elf
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_boot/app/@mcuboot/boot/mynewt/mynewt.elf.bin
   ```
   
   The nrf52_boot ```target.yml``` looks like this:
   ```
   target.app: "@mcuboot/boot/mynewt"
   target.bsp: "@apache-mynewt-core/hw/bsp/nordic_pca10056"
   target.build_profile: optimized
   ```
   
   The `mfg.yml` looks like this:
   ```
   mfb.bsp: "@apache-mynewt-core/hw/bsp/nordic_pca10056"
   
   mfg.targets:
   - nrf52_boot:
 name: "targets/nrf52_boot"
 offset: 0x0
 area: FLASH_AREA_BOOTLOADER
   - nrf52_ble:
 name: "targets/nrf52_ble"
 offset: 0x0
 area: FLASH_AREA_IMAGE_0
   mfg.meta:
   area: FLASH_AREA_BOOTLOADER
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] dwld commented on issue #391: Fix for @repo targets in mfg create

2020-04-01 Thread GitBox
dwld commented on issue #391: Fix for @repo targets in mfg create
URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607291079
 
 
   @utzig, here is the output of the current master newt build as it is:
   ```
   2020/04/01 16:30:41.371 [DEBUG] goroutine 1 [running]:
   mynewt.apache.org/newt/util.NewNewtError(0xc0005a1760, 0xa3, 0xc7f190)
   C://Github/mynewt-newt/util/util.go:77 
+0xd3
   mynewt.apache.org/newt/util.FmtNewtError(0x84555a, 0x2, 0xc7f190, 0x1, 
0x1, 0x0)
   C://Github/mynewt-newt/util/util.go:84 
+0x72
   mynewt.apache.org/newt/newt/mfg.newMfgBuildTarget(0xc000150840, 0x12, 
0xc000150de0, 0x15, 0x0, 0x0, 0xc00067e210, 0x0, 0x0, 0x0, ...)
   
C://Github/mynewt-newt/newt/mfg/build.go:226 +0x59e
   mynewt.apache.org/newt/newt/mfg.newMfgBuilder(0xcc26e0, 0xc00043a120, 
0x2, 0x2, 0x0, 0x0, 0x0, 0xc00059d170, 0x0, 0x0, ...)
   
C://Github/mynewt-newt/newt/mfg/build.go:439 +0x255
   mynewt.apache.org/newt/newt/mfg.LoadMfgEmitter(0xcc26e0, 0x5, 
0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
   
C://Github/mynewt-newt/newt/mfg/misc.go:54 +0x15b
   mynewt.apache.org/newt/newt/cli.mfgCreateRunCmd(0xceec80, 0xc000108210, 
0x2, 0x3)
   
C://Github/mynewt-newt/newt/cli/mfg_cmds.go:117 
+0x1ba
   github.com/spf13/cobra.(*Command).execute(0xceec80, 0xc0001080f0, 0x3, 
0x3, 0xceec80, 0xc0001080f0)
   
C://go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:830
 +0x2b1
   github.com/spf13/cobra.(*Command).ExecuteC(0xc8cf00, 0x845c6b, 0x4, 0x7)
   
C://go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914
 +0x302
   github.com/spf13/cobra.(*Command).Execute(...)
   
C://go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:864
   main.main()
   C://Github/mynewt-newt/newt/newt.go:180 
+0x19e
   
   goroutine 6 [syscall]:
   os/signal.signal_recv(0x0)
   C:/Anwendungen/Go/src/runtime/sigqueue.go:147 +0xa3
   os/signal.loop()
   C:/Anwendungen/Go/src/os/signal/signal_unix.go:23 +0x29
   created by os/signal.init.0
   C:/Anwendungen/Go/src/os/signal/signal_unix.go:29 +0x48
   
   Error: failed to read manifest file: open 
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_boot/app/boot/mynewt/manifest.json:
 The system cannot find the path specified.
   ```
   
   With the fix, the command works for me and outputs the following paths as 
its inputs:
   ```
   Creating a manufacturing image from the following files:
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_ble/app/apps//manifest.json
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_ble/app/apps/.elf
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_ble/app/apps/.img
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_boot/app/@mcuboot/boot/mynewt/manifest.json
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_boot/app/@mcuboot/boot/mynewt/mynewt.elf
   
C:/Entwicklung/newt_ble_central/bin/targets/nrf52_boot/app/@mcuboot/boot/mynewt/mynewt.elf.bin
   ```
   
   The nrf52_boot ```target.yml``` looks like this:
   ```
   target.app: "@mcuboot/boot/mynewt"
   target.bsp: "@apache-mynewt-core/hw/bsp/nordic_pca10056"
   target.build_profile: optimized
   ```
   
   The `mfg.yml` looks like this:
   ```
   mfb.bsp: "@apache-mynewt-core/hw/bsp/nordic_pca10056"
   
   mfg.targets:
   - nrf52_boot:
 name: "targets/nrf52_boot"
 offset: 0x0
 area: FLASH_AREA_BOOTLOADER
   - nrf52_ble:
 name: "targets/nrf52_ble"
 offset: 0x0
 area: FLASH_AREA_IMAGE_0
   mfg.meta:
   area: FLASH_AREA_BOOTLOADER
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] dwld commented on issue #391: Fix for @repo targets

2020-04-01 Thread GitBox
dwld commented on issue #391: Fix for @repo targets
URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607261142
 
 
   Hi @utzig, thanks for your feedback. I'll gather the debug output. Perhaps 
my .mfg file or my targets are not correct. I just published a documentation 
update idea, could you perhaps check it? 
https://github.com/apache/mynewt-newt/pull/392
   Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] dwld opened a new pull request #392: Update documentation for mfg create

2020-04-01 Thread GitBox
dwld opened a new pull request #392: Update documentation for mfg create
URL: https://github.com/apache/mynewt-newt/pull/392
 
 
   Documentation update for the mfg create command in order to match the 
current implementation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] utzig commented on issue #391: Fix for @repo targets

2020-04-01 Thread GitBox
utzig commented on issue #391: Fix for @repo targets
URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607243692
 
 
   This use of `Name()` in those functions has been like this for basically 
ever. All my MCUBoot targets look something like the one you mentioned 
(`target.app: "@mcuboot/boot/mynewt"`) and I see no build issues, what errors 
exactly am I expected to see? Please copy some `newt -ldebug ...` output here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] dwld opened a new pull request #391: Fix for @repo targets

2020-04-01 Thread GitBox
dwld opened a new pull request #391: Fix for @repo targets
URL: https://github.com/apache/mynewt-newt/pull/391
 
 
   Without the fix, building targets such as
   target.app: "@mcuboot/boot/mynewt" fails,
   since the path to the .manifest, .hex and .bin is wrong.
   
   This can be fixed by using the target app's FullName() instead of Name().


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] kasjer commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
kasjer commented on issue #2255: Add SGM4056 charger driver to pinetime BSP
URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607136582
 
 
   > I had some problems with the rebase and squash. But I fixed the history 
now ;-)
   
   Thanks, as soon as @mlaz is satisfied with his change requests it will be 
merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] caspermeijn commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
caspermeijn commented on issue #2255: Add SGM4056 charger driver to pinetime BSP
URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607093858
 
 
   I had some problems with the rebase and squash. But I fixed the history now 
;-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] caspermeijn commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
caspermeijn commented on a change in pull request #2255: Add SGM4056 charger 
driver to pinetime BSP
URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401421249
 
 

 ##
 File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c
 ##
 @@ -0,0 +1,192 @@
+/*
+ * Copyright 2020 Casper Meijn 
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "sgm4056/sgm4056.h"
+#include "hal/hal_gpio.h"
+
+#if MYNEWT_VAL(SGM4056_USE_CHARGE_CONTROL)
+
+static int 
+sgm4056_chg_ctrl_get_status(struct charge_control * chg_ctrl, int * status)
 
 Review comment:
   I fix this. The rebase was more complex then I expected, but I managed to 
figure it out ;-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver 
to pinetime BSP
URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607083823
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to 
pinetime BSP
URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607092226
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to 
pinetime BSP
URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607083823
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver 
to pinetime BSP
URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-606501796
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/drivers/chg_ctrl/sgm4056/include/sgm4056/sgm4056.h
   
   
   ```diff
   @@ -28,24 +28,24 @@
struct sgm4056_dev {
struct os_dev dev;
#if MYNEWT_VAL(SGM4056_USE_CHARGE_CONTROL)
   -struct charge_control   chg_ctrl;
   +struct charge_control chg_ctrl;
struct os_event interrupt_event;
#endif
struct sgm4056_dev_config config;
};

/**
   -* Init function for SGM4056 charger
   -* @return 0 on success, non-zero on failure
   -*/
   + * Init function for SGM4056 charger
   + * @return 0 on success, non-zero on failure
   + */
int sgm4056_dev_init(struct os_dev *dev, void *arg);

/**
   - * Reads the state of the power presence indication. Value is 1 when the 
input 
   + * Reads the state of the power presence indication. Value is 1 when the 
input
 * voltage is above the POR threshold but below the OVP threshold and 0 
otherwise.
 *
 * @param dev The sgm4056 device to read on
   - * @param power_present Power presence indication to be returned by the 
   + * @param power_present Power presence indication to be returned by the
 *  function (0 if input voltage is not detected, 1 if it is detected)
 *
 * @return 0 on success, non-zero on failure
   @@ -53,11 +53,11 @@
int sgm4056_get_power_presence(struct sgm4056_dev *dev, int *power_present);

/**
   - * Reads the state of the charge indication. Value is 1 when a charge cycle 
   + * Reads the state of the charge indication. Value is 1 when a charge cycle
 * started and will be 0 when the end-of-charge (EOC) condition is met.
 *
 * @param dev The sgm4056 device to read on
   - * @param charging Charge indication to be returned by the 
   + * @param charging Charge indication to be returned by the
 *  function (0 if battery is not charging, 1 if it is charging)
 *
 * @return 0 on success, non-zero on failure
   @@ -65,7 +65,7 @@
int sgm4056_get_charge_indicator(struct sgm4056_dev *dev, int *charging);

/**
   - * Reads the state of the charger. This is a combination of the power 
presence 
   + * Reads the state of the charger. This is a combination of the power 
presence
 * and charge indications. Value is either:
 * - CHARGE_CONTROL_STATUS_NO_SOURCE, when no power present
 * - CHARGE_CONTROL_STATUS_CHARGING, when power present and charging
   ```
   
   
   
    hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c
   
   
   ```diff
   @@ -19,7 +19,7 @@

#if MYNEWT_VAL(SGM4056_USE_CHARGE_CONTROL)

   -static int 
   +static int
sgm4056_chg_ctrl_get_status(struct charge_control * chg_ctrl, int * status)
{
struct sgm4056_dev *dev;
   @@ -37,10 +37,10 @@
return rc;
}

   -static int 
   -sgm4056_chg_ctrl_read(struct charge_control * chg_ctrl, 
   -charge_control_type_t type, charge_control_data_func_t data_func, 
   -void *data_arg, uint32_t timeout)
   +static int
   +sgm4056_chg_ctrl_read(struct charge_control * chg_ctrl,
   +  charge_control_type_t type, 
charge_control_data_func_t data_func,
   +  void *data_arg, uint32_t timeout)
{
int rc = 0;
int status;
   @@ -51,8 +51,8 @@
goto err;
}

   -if(data_func) {
   -data_func(chg_ctrl, data_arg, (void*), 
CHARGE_CONTROL_TYPE_STATUS);
   +if (data_func) {
   +data_func(chg_ctrl, data_arg, (void *), 
CHARGE_CONTROL_TYPE_STATUS);
}
}

   @@ -80,7 +80,7 @@
NULL, NULL, OS_TIMEOUT_NEVER);
}

   -static void 
   +static void
sgm4056_irq_handler(void *arg)
{
struct sgm4056_dev *dev = (struct sgm4056_dev *)arg;
   @@ -90,8 +90,9 @@
}
#endif

   -int 
   -sgm4056_dev_init(struct os_dev *odev, void *arg) {
   +int
   +sgm4056_dev_init(struct os_dev *odev, void *arg)
   +{
struct sgm4056_dev *dev = (struct sgm4056_dev *)odev;
const struct sgm4056_dev_config *cfg = arg;
int rc = 0;
   @@ -107,7 +108,8 @@
dev->interrupt_event.ev_cb = sgm4056_interrupt_event_handler;
dev->interrupt_event.ev_arg = dev;

   -rc = hal_gpio_irq_init(dev->config.power_presence_pin, 
sgm4056_irq_handler, dev, HAL_GPIO_TRIG_BOTH, HAL_GPIO_PULL_NONE);
   +rc = hal_gpio_irq_init(dev->config.power_presence_pin, 
sgm4056_irq_handler, dev, HAL_GPIO_TRIG_BOTH,
   +   HAL_GPIO_PULL_NONE);
hal_gpio_irq_enable(dev->config.power_presence_pin);
#else
rc = hal_gpio_init_in(dev->config.power_presence_pin,