[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2262: da1469x: otp and serial script enhancements

2020-04-06 Thread GitBox
apache-mynewt-bot commented on issue #2262: da1469x: otp and serial script 
enhancements
URL: https://github.com/apache/mynewt-core/pull/2262#issuecomment-610149019
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] h2zero commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-06 Thread GitBox
h2zero commented on a change in pull request #790: nimble/store: Fix nimble 
store behavior when CCCDs exceed static defined limit
URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r404497436
 
 

 ##
 File path: nimble/host/src/ble_store_util.c
 ##
 @@ -230,16 +315,43 @@ ble_store_util_delete_oldest_peer(void)
 int
 ble_store_util_status_rr(struct ble_store_status_event *event, void *arg)
 {
+int rc = BLE_HS_EUNKNOWN;
+ble_addr_t peer_id_addr;
+int num_peers;
+
 switch (event->event_code) {
 case BLE_STORE_EVENT_OVERFLOW:
 switch (event->overflow.obj_type) {
-case BLE_STORE_OBJ_TYPE_OUR_SEC:
-case BLE_STORE_OBJ_TYPE_PEER_SEC:
-case BLE_STORE_OBJ_TYPE_CCCD:
-return ble_gap_unpair_oldest_peer();
-
-default:
-return BLE_HS_EUNKNOWN;
+case BLE_STORE_OBJ_TYPE_OUR_SEC:
+case BLE_STORE_OBJ_TYPE_PEER_SEC:
+return ble_gap_unpair_oldest_peer();
+case BLE_STORE_OBJ_TYPE_CCCD:
+if ((rc = ble_gap_unpair_oldest_peer()) == BLE_HS_ENOENT) {
 
 Review comment:
   I believe @rymanluk is correct, if the current peer exceeds the cccd limit 
it will likely unpair that peer and disconnect. I like the do nothing if full 
approach here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] h2zero opened a new issue #793: min\max_ce_len, how is it used internally?

2020-04-06 Thread GitBox
h2zero opened a new issue #793: min\max_ce_len, how is it used internally?
URL: https://github.com/apache/mynewt-nimble/issues/793
 
 
   I've been trying to track down errors when acting as a client connecting to 
multiple peripheral devices. What I have experienced so far is when the 
connection intervals are short, approx. 20ms, 2 connections are fine but once 
connected to a 3rd it causes an error and aborts on the esp32.
   
   I am finding by setting the min_ce_len to half of the default initial value, 
0x0010 to 0x0008, the errors dissipate. 
   
   So what I'm asking is does the min_ce_len specify a fixed time slot that 
NimBLE reserves for that particular connection, regardless of any communication 
between the devices?
   
   If so would that mean in this instance with 2 devices connected, each with 
20ms connection intervals and 10ms minimum connection event lengths that there 
would be no time available to support a 3rd connection?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #792: nimble/host: Improve find conn by ble_addr_t

2020-04-06 Thread GitBox
apache-mynewt-bot commented on issue #792: nimble/host: Improve find conn by 
ble_addr_t
URL: https://github.com/apache/mynewt-nimble/pull/792#issuecomment-610115342
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] nkaje opened a new pull request #2262: do not merge: da1469x otp and serial script enhancements

2020-04-06 Thread GitBox
nkaje opened a new pull request #2262: do not merge: da1469x otp and serial 
script enhancements
URL: https://github.com/apache/mynewt-core/pull/2262
 
 
   This PR provides script enhancements to 
   
   1. da146x_serial.py: Makes the reset script optional. Use manual reset 
method or script to enter serial load mode.
   2. otp_tool.py: Provide a common function that flushes serial port when 
initially opened.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] rymanluk opened a new pull request #792: nimble/host: Improve find conn by ble_addr_t

2020-04-06 Thread GitBox
rymanluk opened a new pull request #792: nimble/host: Improve find conn by 
ble_addr_t
URL: https://github.com/apache/mynewt-nimble/pull/792
 
 
   This function compares ble_addr_t and the problems starts when type 0x02
   or 0x03 is used in conn
   
   Usually it is user who should take care about the proper type, but
   problem might happen when this function is called in the event of
   storage overflow and we might end up with type > 0x01 in conn but we are
   looking for ble_addr_t found in the storage where address is already
   translated to Public or Random.
   
   This patch fixes that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[mynewt-nimble] branch master updated: btshell: Add command to unpair oldest device

2020-04-06 Thread rymek
This is an automated email from the ASF dual-hosted git repository.

rymek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git


The following commit(s) were added to refs/heads/master by this push:
 new 6d07410  btshell: Add command to unpair oldest device
6d07410 is described below

commit 6d074107b8a6c7044d0dff95f52f848477643a9a
Author: Łukasz Rymanowski 
AuthorDate: Mon Apr 6 15:50:12 2020 +0200

btshell: Add command to unpair oldest device
---
 apps/btshell/src/cmd.c | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/apps/btshell/src/cmd.c b/apps/btshell/src/cmd.c
index 2713443..8a87875 100644
--- a/apps/btshell/src/cmd.c
+++ b/apps/btshell/src/cmd.c
@@ -2691,12 +2691,25 @@ cmd_security_unpair(int argc, char **argv)
 {
 ble_addr_t peer;
 int rc;
+int oldest;
 
 rc = parse_arg_all(argc - 1, argv + 1);
 if (rc != 0) {
 return rc;
 }
 
+rc = parse_arg_bool_dflt("oldest", 0, );
+if (rc != 0) {
+console_printf("invalid 'oldest' parameter\n");
+return rc;
+}
+
+if (oldest) {
+rc = ble_gap_unpair_oldest_peer();
+console_printf("Unpair oldest status: 0x%02x\n", rc);
+return 0;
+}
+
 rc = parse_dev_addr("peer_", cmd_peer_addr_types, );
 if (rc != 0) {
 console_printf("invalid 'peer_addr' parameter\n");
@@ -2714,6 +2727,7 @@ cmd_security_unpair(int argc, char **argv)
 
 #if MYNEWT_VAL(SHELL_CMD_HELP)
 static const struct shell_param security_unpair_params[] = {
+{"oldest", "usage: =[true|false], default: false"},
 {"peer_addr_type", "usage: =[public|random|public_id|random_id], default: 
public"},
 {"peer_addr", "usage: =[XX:XX:XX:XX:XX:XX]"},
 {NULL, NULL}



[GitHub] [mynewt-nimble] rymanluk merged pull request #791: btshell: Add command to unpair the oldest device

2020-04-06 Thread GitBox
rymanluk merged pull request #791: btshell: Add command to unpair the oldest 
device
URL: https://github.com/apache/mynewt-nimble/pull/791
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2252: [RFC] I2S API and driver for STM32 MCUs

2020-04-06 Thread GitBox
apache-mynewt-bot removed a comment on issue #2252: [RFC] I2S API and driver 
for STM32 MCUs
URL: https://github.com/apache/mynewt-core/pull/2252#issuecomment-606714969
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2252: [RFC] I2S API and driver for STM32 MCUs

2020-04-06 Thread GitBox
apache-mynewt-bot commented on issue #2252: [RFC] I2S API and driver for STM32 
MCUs
URL: https://github.com/apache/mynewt-core/pull/2252#issuecomment-609856939
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/drivers/i2s/i2s_stm32f4/src/i2s_stm32f4.c
   
   
   ```diff
   @@ -469,7 +469,7 @@
}
}
#endif
   -/* Fallthrough */
   +/* Fallthrough */
case HAL_I2S_STATE_READY:
assert(i2s_data->active_buffer == NULL);
i2s_data->active_buffer = i2s_driver_buffer_get(i2s);
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #791: btshell: Add command to unpair the oldest device

2020-04-06 Thread GitBox
apache-mynewt-bot commented on issue #791: btshell: Add command to unpair the 
oldest device
URL: https://github.com/apache/mynewt-nimble/pull/791#issuecomment-609831897
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-06 Thread GitBox
rymanluk commented on a change in pull request #790: nimble/store: Fix nimble 
store behavior when CCCDs exceed static defined limit
URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r404129458
 
 

 ##
 File path: nimble/host/src/ble_store_util.c
 ##
 @@ -230,16 +315,43 @@ ble_store_util_delete_oldest_peer(void)
 int
 ble_store_util_status_rr(struct ble_store_status_event *event, void *arg)
 {
+int rc = BLE_HS_EUNKNOWN;
+ble_addr_t peer_id_addr;
+int num_peers;
+
 switch (event->event_code) {
 case BLE_STORE_EVENT_OVERFLOW:
 switch (event->overflow.obj_type) {
-case BLE_STORE_OBJ_TYPE_OUR_SEC:
-case BLE_STORE_OBJ_TYPE_PEER_SEC:
-case BLE_STORE_OBJ_TYPE_CCCD:
-return ble_gap_unpair_oldest_peer();
-
-default:
-return BLE_HS_EUNKNOWN;
+case BLE_STORE_OBJ_TYPE_OUR_SEC:
+case BLE_STORE_OBJ_TYPE_PEER_SEC:
+return ble_gap_unpair_oldest_peer();
+case BLE_STORE_OBJ_TYPE_CCCD:
+if ((rc = ble_gap_unpair_oldest_peer()) == BLE_HS_ENOENT) {
 
 Review comment:
   @prasad-alatkar are you sure that `ble_gap_unpair_oldest_peer()` will not 
unpair current peer? For me it looks it will.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] h2zero edited a comment on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs

2020-04-06 Thread GitBox
h2zero edited a comment on issue #788: nimble/store: 
`ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can 
cause infinite loop for CCCDs
URL: https://github.com/apache/mynewt-nimble/issues/788#issuecomment-609818788
 
 
   @prasad-alatkar Yes, you are correct. It was just a quick patch to get by 
while developing the cpp library to avoid that error. Didn’t want to do any big 
changes to the NimBLE core code yet.
   
   I do not think we should store cccd data if not bonding though, maybe a 
combination of my fix and a proper round robin cccd store patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] h2zero commented on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs

2020-04-06 Thread GitBox
h2zero commented on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in 
`ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs
URL: https://github.com/apache/mynewt-nimble/issues/788#issuecomment-609818788
 
 
   Yes, you are correct. It was just a quick patch to get by while developing 
the cpp library to avoid that error. Didn’t want to do any big changes to the 
NimBLE core code yet.
   
   I do not think we should store cccd data if not bonding though, maybe a 
combination of my fix and a proper round robin cccd store patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] rymanluk opened a new pull request #791: btshell: Add command to unpair the oldest device

2020-04-06 Thread GitBox
rymanluk opened a new pull request #791: btshell: Add command to unpair the 
oldest device
URL: https://github.com/apache/mynewt-nimble/pull/791
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] prasad-alatkar commented on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs

2020-04-06 Thread GitBox
prasad-alatkar commented on issue #788: nimble/store: 
`ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can 
cause infinite loop for CCCDs
URL: https://github.com/apache/mynewt-nimble/issues/788#issuecomment-609676002
 
 
   @h2zero your proposed solution may avoid this issue when "Bonding" is not 
enabled, but the issue will eventually pop-up in case of bonding is enabled 
(i.e. `ble_hs_cfg.sm_bonding = 1`). 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-06 Thread GitBox
apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble 
store behavior when CCCDs exceed static defined limit
URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-608547695
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-06 Thread GitBox
apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store 
behavior when CCCDs exceed static defined limit
URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-609581758
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services