[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2263: shell_bridge: update to be used with mcumgr, update imgmgr cli to be used with shell_bridge
apache-mynewt-bot commented on issue #2263: shell_bridge: update to be used
with mcumgr, update imgmgr cli to be used with shell_bridge
URL: https://github.com/apache/mynewt-core/pull/2263#issuecomment-611283922
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2263: shell_bridge: update to be used with mcumgr, update imgmgr cli to be used with shell_bridge
apache-mynewt-bot removed a comment on issue #2263: shell_bridge: update to be
used with mcumgr, update imgmgr cli to be used with shell_bridge
URL: https://github.com/apache/mynewt-core/pull/2263#issuecomment-611270873
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2263: shell_bridge: update to be used with mcumgr
apache-mynewt-bot commented on issue #2263: shell_bridge: update to be used
with mcumgr
URL: https://github.com/apache/mynewt-core/pull/2263#issuecomment-611270873
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] vrahane opened a new pull request #76: mgmt: Add shell mgmt ID from mynewt-core
vrahane opened a new pull request #76: mgmt: Add shell mgmt ID from mynewt-core URL: https://github.com/apache/mynewt-mcumgr/pull/76 - This was not transitioned when forking off This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] vrahane opened a new pull request #2263: shell_bridge: update to be used with mcumgr
vrahane opened a new pull request #2263: shell_bridge: update to be used with mcumgr URL: https://github.com/apache/mynewt-core/pull/2263 This was not updated on transitioning to mcumgr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] wes3 merged pull request #2262: da1469x: otp and serial script enhancements
wes3 merged pull request #2262: da1469x: otp and serial script enhancements URL: https://github.com/apache/mynewt-core/pull/2262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-core] branch master updated: da1469x: otp and serial script enhancements (#2262)
This is an automated email from the ASF dual-hosted git repository.
wes3 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 817ba5b da1469x: otp and serial script enhancements (#2262)
817ba5b is described below
commit 817ba5b516da1241a7f0e9355b1fa0834c15c53d
Author: Naveen Kaje
AuthorDate: Wed Apr 8 12:07:46 2020 -0500
da1469x: otp and serial script enhancements (#2262)
* hw/bsp/da1469x: da1469x_serial: Make the reset script optional
Make the reset script an optional parameter. This gives the
user an option to manually reset the board to make it enter
the serial load mode or use JLink or OpenOCD based reset script.
Signed-off-by: Naveen Kaje
* hw/bsp/da1469x: otp_tool: provide common function for serial
Provide common method for serial port opening opens the port, flushes
and returns port handle. This eleminates repeated code.
Signed-off-by: Naveen Kaje
* hw/bsp/da1469x: da1469x_serial: drain the port after open
Drain the port after opening to ensure the
buffers are empty.
Signed-off-by: Naveen Kaje
---
hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py | 16 +-
hw/bsp/dialog_da1469x-dk-pro/otp_tool.py | 70 +-
2 files changed, 39 insertions(+), 47 deletions(-)
diff --git a/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py
b/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py
index 1d7d7aa..598c609 100755
--- a/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py
+++ b/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py
@@ -26,7 +26,7 @@ from datetime import datetime
@click.argument('infile')
@click.option('-u', '--uart', required=True, help='uart port')
-@click.option('-r', '--reset_script', required=True, help='Custom reset script
to switch to serial load')
+@click.option('-r', '--reset_script', required=False, help='Custom reset
script to switch to serial load')
@click.command(help='Load the provided file using serial load protocol')
def load(infile, uart, reset_script):
try:
@@ -35,6 +35,15 @@ def load(infile, uart, reset_script):
except serial.SerialException:
raise SystemExit("Failed to open serial port")
+# drain serial port buffer
+try:
+while True:
+data = ser.read(1)
+if len(data) == 0:
+break
+except serial.SerialException:
+raise SystemExit("Failed to open serial port")
+
try:
f = open(infile, "rb")
except IOError:
@@ -59,12 +68,15 @@ def load(infile, uart, reset_script):
prev = datetime.now()
reset_delay_us = 25
+if reset_script is None:
+print("Please reset board to enter ROM uart recovery")
+
while True:
elapsed = datetime.now() - prev
if elapsed.seconds >= 15:
raise SystemExit("Failed to receive SOM, aborting")
if not som_detected and not reset_triggered:
-if elapsed.microseconds >= reset_delay_us:
+if reset_script and elapsed.microseconds >= reset_delay_us:
print("Triggering SWD reset...")
# Run in background
os.system(reset_script + " &")
diff --git a/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py
b/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py
index fbe3086..8883365 100755
--- a/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py
+++ b/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py
@@ -125,14 +125,26 @@ def validate_response(response):
return True
-def otp_read_key(index, segment, uart):
-seg_map = {'signature': 0, 'data': 1, 'qspi': 2}
-
+def get_serial_port(port, baudrate, timeout, bytesize, stopbits):
try:
-ser = serial.Serial(port=uart, baudrate=100, timeout=1,
-bytesize=8, stopbits=serial.STOPBITS_ONE)
+ser = serial.Serial(port=port, baudrate=baudrate, timeout=timeout,
+bytesize=bytesize, stopbits=stopbits)
except serial.SerialException:
raise SystemExit("Failed to open serial port")
+# drain serial port buffer
+try:
+while True:
+data = ser.read(1)
+if len(data) == 0:
+break
+except serial.SerialException:
+raise SystemExit("Failed to open serial port")
+return ser
+
+
+def otp_read_key(index, segment, uart):
+seg_map = {'signature': 0, 'data': 1, 'qspi': 2}
+ser = get_serial_port(uart, 100, 1, 8, serial.STOPBITS_ONE)
cmd = cmd_read_key(0xaa55aa55, Cmd.OTP_READ_KEY, seg_map[segment], index)
data = struct.pack('', *cmd)
@@ -196,11 +208,7 @@ def otp_write_key(infile, index, segment, uart):
seg_map = {'signature': 0, 'data': 1, 'qspi': 2}
-try:
-ser = serial.Serial(port=uart, baudrate=100, timeout=1,
-bytesize=8, stopbits=serial.STOPBITS_ONE)
-
[GitHub] [mynewt-core] nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements
nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements URL: https://github.com/apache/mynewt-core/pull/2262#issuecomment-611059047 **Test logs** - Manual reset ``` $./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Please reset board to enter ROM uart recovery b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Use reset script ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -r repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/reset.sh -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Triggering SWD reset... b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Communicate with the target ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py test-alive-target -u /dev/ttyUSB0 Successfully communicated with target ``` and performed other one time programmable routines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements
nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements URL: https://github.com/apache/mynewt-core/pull/2262#issuecomment-611059047 **Test logs** - Manual reset ``` $./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Please reset board to enter ROM uart recovery b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Use reset script ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -r repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/reset.sh -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Triggering SWD reset... b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Communicate with the target: ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py test-alive-target -u /dev/ttyUSB0 Successfully communicated with target ``` and performed other one time programmable routines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements
nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements URL: https://github.com/apache/mynewt-core/pull/2262#issuecomment-611059047 **Test logs** - Manual reset ``` ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Please reset board to enter ROM uart recovery b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Use reset script ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -r repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/reset.sh -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Triggering SWD reset... b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Communicate with the target: ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py test-alive-target -u /dev/ttyUSB0 Successfully communicated with target ``` and performed other one time programmable routines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements
nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements URL: https://github.com/apache/mynewt-core/pull/2262#issuecomment-611059047 **Test logs** -Manual reset: ``` ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Please reset board to enter ROM uart recovery b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Use reset script ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -r repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/reset.sh -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Triggering SWD reset... b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Communicate with the target: ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py test-alive-target -u /dev/ttyUSB0 Successfully communicated with target ``` and performed other one time programmable routines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements
nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements URL: https://github.com/apache/mynewt-core/pull/2262#issuecomment-611059047 - Test logs Manual reset: ``` ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Please reset board to enter ROM uart recovery b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Use reset script ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -r repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/reset.sh -u /dev/ttyUSB1 ./bin/targets ./bin/targets/ram_executable/ram_executable.elf.bin Triggering SWD reset... b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Communicate with the target: ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py test-alive-target -u /dev/ttyUSB0 Successfully communicated with target ``` and performed other one time programmable routines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements
nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements URL: https://github.com/apache/mynewt-core/pull/2262#issuecomment-611059047 - Test logs Manual reset: ``` ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Please reset board to enter ROM uart recovery b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Use reset script ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -r repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/reset.sh -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Triggering SWD reset... b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Communicate with the target: ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py test-alive-target -u /dev/ttyUSB0 Successfully communicated with target ``` and performed other one time programmable routines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements
nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements URL: https://github.com/apache/mynewt-core/pull/2262#issuecomment-611059047 - Test logs Manual reset: ``` ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Please reset board to enter ROM uart recovery b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` - Use reset script ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -r repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/reset.sh -u /dev/ttyUSB1 ./bin/targets ./bin/targets/ram_executable/ram_executable.elf.bin Triggering SWD reset... b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` Communicate with the target: ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py test-alive-target -u /dev/ttyUSB0 Successfully communicated with target ``` and performed other one time programmable routines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] nkaje commented on issue #2262: da1469x: otp and serial script enhancements
nkaje commented on issue #2262: da1469x: otp and serial script enhancements URL: https://github.com/apache/mynewt-core/pull/2262#issuecomment-611059047 Test logs Manual reset: ``` ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Please reset board to enter ROM uart recovery b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` Communicate with the target: ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py test-alive-target -u /dev/ttyUSB0 Successfully communicated with target ``` and performed other one time programmable routines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements
nkaje edited a comment on issue #2262: da1469x: otp and serial script enhancements URL: https://github.com/apache/mynewt-core/pull/2262#issuecomment-611059047 - Test logs Manual reset: ``` ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py load -u /dev/ttyUSB1 ./bin/targets/ram_executable/ram_executable.elf.bin Please reset board to enter ROM uart recovery b'\x02' Detected serial boot protocol Loading application to RAM Successfully loaded RAM, board will now boot executable ``` Communicate with the target: ``` $ ./repos/apache-mynewt-core/hw/bsp/dialog_da1469x-dk-pro/otp_tool.py test-alive-target -u /dev/ttyUSB0 Successfully communicated with target ``` and performed other one time programmable routines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] sjanc commented on issue #785: [npl] linux porting layer unit tests fail
sjanc commented on issue #785: [npl] linux porting layer unit tests fail URL: https://github.com/apache/mynewt-nimble/issues/785#issuecomment-610997957 hmm works for me for both 1.3 and master [janc@ix test]$ make test ./test_npl_task.exe All tests passed ./test_npl_callout.exe All tests passed ./test_npl_eventq.exe All tests passed ./test_npl_sem.exe All tests passed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit
prasad-alatkar commented on a change in pull request #790: nimble/store: Fix
nimble store behavior when CCCDs exceed static defined limit
URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r405530825
##
File path: nimble/host/src/ble_store_util.c
##
@@ -230,16 +315,43 @@ ble_store_util_delete_oldest_peer(void)
int
ble_store_util_status_rr(struct ble_store_status_event *event, void *arg)
{
+int rc = BLE_HS_EUNKNOWN;
+ble_addr_t peer_id_addr;
+int num_peers;
+
switch (event->event_code) {
case BLE_STORE_EVENT_OVERFLOW:
switch (event->overflow.obj_type) {
-case BLE_STORE_OBJ_TYPE_OUR_SEC:
-case BLE_STORE_OBJ_TYPE_PEER_SEC:
-case BLE_STORE_OBJ_TYPE_CCCD:
-return ble_gap_unpair_oldest_peer();
-
-default:
-return BLE_HS_EUNKNOWN;
+case BLE_STORE_OBJ_TYPE_OUR_SEC:
+case BLE_STORE_OBJ_TYPE_PEER_SEC:
+return ble_gap_unpair_oldest_peer();
+case BLE_STORE_OBJ_TYPE_CCCD:
+if ((rc = ble_gap_unpair_oldest_peer()) == BLE_HS_ENOENT) {
Review comment:
Hi @rymanluk I think for some peers `CCCD` will exist but `peer_sec` and
`our_sec` won't exist (Ref: [subscribe-event
ble_gatts_clt_cfg_access](https://github.com/apache/mynewt-nimble/blob/9e26fbe97b3d0bb3a22f15ed9c6035be648d1104/nimble/host/src/ble_gatts.c#L782)).
So we need mechanism to clean these stored CCCDs, that is why I have
introduced `ble_store_clean_old_cccd()` function.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
svn commit: r38856 - /dev/mynewt/apache-mynewt-1.8.0/rc2/ /dev/mynewt/apache-nimble-1.3.0/rc2/ /release/mynewt/apache-mynewt-1.8.0/ /release/mynewt/apache-nimble-1.3.0/
Author: janc Date: Wed Apr 8 13:36:38 2020 New Revision: 38856 Log: Apache Mynewt 1.8.0 and Apache NimBLE 1.3.0 release Added: release/mynewt/apache-mynewt-1.8.0/ release/mynewt/apache-mynewt-1.8.0/apache-mynewt-blinky-1.8.0.tgz - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz release/mynewt/apache-mynewt-1.8.0/apache-mynewt-blinky-1.8.0.tgz.asc - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz.asc release/mynewt/apache-mynewt-1.8.0/apache-mynewt-blinky-1.8.0.tgz.sha512 - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz.sha512 release/mynewt/apache-mynewt-1.8.0/apache-mynewt-core-1.8.0.tgz - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-core-1.8.0.tgz release/mynewt/apache-mynewt-1.8.0/apache-mynewt-core-1.8.0.tgz.asc - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-core-1.8.0.tgz.asc release/mynewt/apache-mynewt-1.8.0/apache-mynewt-core-1.8.0.tgz.sha512 - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-core-1.8.0.tgz.sha512 release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-1.8.0.tgz - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-1.8.0.tgz release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-1.8.0.tgz.asc - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-1.8.0.tgz.asc release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-1.8.0.tgz.sha512 - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-1.8.0.tgz.sha512 release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-bin-linux-1.8.0.tgz - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-linux-1.8.0.tgz release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-bin-linux-1.8.0.tgz.asc - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-linux-1.8.0.tgz.asc release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-bin-linux-1.8.0.tgz.sha512 - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-linux-1.8.0.tgz.sha512 release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-bin-osx-1.8.0.tgz - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-osx-1.8.0.tgz release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-bin-osx-1.8.0.tgz.asc - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-osx-1.8.0.tgz.asc release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-bin-osx-1.8.0.tgz.sha512 - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-osx-1.8.0.tgz.sha512 release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-bin-windows-1.8.0.tgz - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-windows-1.8.0.tgz release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-bin-windows-1.8.0.tgz.asc - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-windows-1.8.0.tgz.asc release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newt-bin-windows-1.8.0.tgz.sha512 - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-windows-1.8.0.tgz.sha512 release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newtmgr-1.8.0.tgz - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-1.8.0.tgz release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newtmgr-1.8.0.tgz.asc - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-1.8.0.tgz.asc release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newtmgr-1.8.0.tgz.sha512 - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-1.8.0.tgz.sha512 release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newtmgr-bin-linux-1.8.0.tgz - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-linux-1.8.0.tgz release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newtmgr-bin-linux-1.8.0.tgz.asc - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-linux-1.8.0.tgz.asc release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newtmgr-bin-linux-1.8.0.tgz.sha512 - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-linux-1.8.0.tgz.sha512 release/mynewt/apache-mynewt-1.8.0/apache-mynewt-newtmgr-bin-osx-1.8.0.tgz - copied unchanged from r38855, dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-osx-1.8.0.tgz
[GitHub] [mynewt-core] sjanc closed issue #2102: `vers: 0-latest` not accepted by newt 1.7.0
sjanc closed issue #2102: `vers: 0-latest` not accepted by newt 1.7.0 URL: https://github.com/apache/mynewt-core/issues/2102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] sjanc commented on issue #2102: `vers: 0-latest` not accepted by newt 1.7.0
sjanc commented on issue #2102: `vers: 0-latest` not accepted by newt 1.7.0 URL: https://github.com/apache/mynewt-core/issues/2102#issuecomment-610957493 Hi, tutorial is now updated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-newtmgr] annotated tag mynewt_1_8_0_tag updated (15c6a24 -> 725b1f0)
This is an automated email from the ASF dual-hosted git repository. janc pushed a change to annotated tag mynewt_1_8_0_tag in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git. *** WARNING: tag mynewt_1_8_0_tag was modified! *** from 15c6a24 (commit) to 725b1f0 (tag) tagging 15c6a24d57d6dbdcf33646df365b2c64a12de251 (commit) replaces mynewt_1_8_0_rc1_tag by Szymon Janc on Wed Apr 8 14:51:58 2020 +0200 - Log - Mynewt 1.8.0 --- No new revisions were added by this update. Summary of changes:
[mynewt-newt] annotated tag mynewt_1_8_0_tag updated (725740e -> 1e9e62d)
This is an automated email from the ASF dual-hosted git repository. janc pushed a change to annotated tag mynewt_1_8_0_tag in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git. *** WARNING: tag mynewt_1_8_0_tag was modified! *** from 725740e (commit) to 1e9e62d (tag) tagging 725740e08825a4a15d6270cccd7ff45fdd928312 (commit) replaces mynewt_1_8_0_rc1_tag by Szymon Janc on Wed Apr 8 14:51:44 2020 +0200 - Log - Mynewt 1.8.0 --- No new revisions were added by this update. Summary of changes:
[mynewt-blinky] annotated tag mynewt_1_8_0_tag updated (34e9aae -> ee7fb86)
This is an automated email from the ASF dual-hosted git repository. janc pushed a change to annotated tag mynewt_1_8_0_tag in repository https://gitbox.apache.org/repos/asf/mynewt-blinky.git. *** WARNING: tag mynewt_1_8_0_tag was modified! *** from 34e9aae (commit) to ee7fb86 (tag) tagging 34e9aae78f3ab4a4307bf99b4e25be11060aa526 (commit) replaces mynewt_1_8_0_rc1_tag by Szymon Janc on Wed Apr 8 14:52:03 2020 +0200 - Log - Mynewt 1.8.0 --- No new revisions were added by this update. Summary of changes:
[mynewt-nimble] annotated tag nimble_1_3_0_tag updated (97ce3ea -> e5058bc)
This is an automated email from the ASF dual-hosted git repository. janc pushed a change to annotated tag nimble_1_3_0_tag in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git. *** WARNING: tag nimble_1_3_0_tag was modified! *** from 97ce3ea (commit) to e5058bc (tag) tagging 97ce3eacaaa79e8ed6cf71717149ced4f5328ee7 (commit) replaces nimble_1_3_0_rc1_tag by Szymon Janc on Wed Apr 8 14:52:30 2020 +0200 - Log - NimBLE 1.3.0 --- No new revisions were added by this update. Summary of changes:
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #794: Apps: add peripheral
apache-mynewt-bot removed a comment on issue #794: Apps: add peripheral
URL: https://github.com/apache/mynewt-nimble/pull/794#issuecomment-610901730
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apps/peripheral/src/main.c
```diff
@@ -78,10 +78,10 @@
default:
MODLOG_DFLT(ERROR, "Advertising event not handled,"
"event code: %u\n", event->type);
-break;
+break;
}
return 0;
-}
+}
static void
advertise(void)
@@ -116,7 +116,7 @@
rsp_fields.name = (uint8_t *)device_name;
rsp_fields.name_len = strlen(device_name);
rsp_fields.name_is_complete = 1;
-
+
rc = ble_gap_adv_set_fields();
assert(rc == 0);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #794: Apps: add peripheral
apache-mynewt-bot commented on issue #794: Apps: add peripheral
URL: https://github.com/apache/mynewt-nimble/pull/794#issuecomment-610926423
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit
rymanluk commented on a change in pull request #790: nimble/store: Fix nimble
store behavior when CCCDs exceed static defined limit
URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r405456758
##
File path: nimble/host/src/ble_store_util.c
##
@@ -230,16 +315,43 @@ ble_store_util_delete_oldest_peer(void)
int
ble_store_util_status_rr(struct ble_store_status_event *event, void *arg)
{
+int rc = BLE_HS_EUNKNOWN;
+ble_addr_t peer_id_addr;
+int num_peers;
+
switch (event->event_code) {
case BLE_STORE_EVENT_OVERFLOW:
switch (event->overflow.obj_type) {
-case BLE_STORE_OBJ_TYPE_OUR_SEC:
-case BLE_STORE_OBJ_TYPE_PEER_SEC:
-case BLE_STORE_OBJ_TYPE_CCCD:
-return ble_gap_unpair_oldest_peer();
-
-default:
-return BLE_HS_EUNKNOWN;
+case BLE_STORE_OBJ_TYPE_OUR_SEC:
+case BLE_STORE_OBJ_TYPE_PEER_SEC:
+return ble_gap_unpair_oldest_peer();
+case BLE_STORE_OBJ_TYPE_CCCD:
+if ((rc = ble_gap_unpair_oldest_peer()) == BLE_HS_ENOENT) {
Review comment:
I believe that `ble_store_util_delete_peer()` deletes all what we need.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #794: Apps: add peripheral
apache-mynewt-bot removed a comment on issue #794: Apps: add peripheral
URL: https://github.com/apache/mynewt-nimble/pull/794#issuecomment-610880529
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apps/peripheral/src/main.c
```diff
@@ -53,14 +53,13 @@
/* Connection failed; resume advertising */
advertise();
conn_handle = 0;
-}
-else {
+} else {
conn_handle = event->connect.conn_handle;
}
break;
case BLE_GAP_EVENT_CONN_UPDATE_REQ:
/* connected device requests update of connection parameters,
-and these are being filled in - NULL sets default values */
+ and these are being filled in - NULL sets default values */
MODLOG_DFLT(INFO, "updating conncetion parameters...\n");
event->conn_update_req.conn_handle = conn_handle;
event->conn_update_req.peer_params = NULL;
@@ -71,18 +70,18 @@
event->disconnect.reason);
/* reset conn_handle */
-conn_handle = BLE_HS_CONN_HANDLE_NONE;
+conn_handle = BLE_HS_CONN_HANDLE_NONE;
/* Connection terminated; resume advertising */
advertise();
-break;
+break;
default:
MODLOG_DFLT(ERROR, "Advertising event not handled,"
"event code: %u\n", event->type);
-break;
+break;
}
return 0;
-}
+}
static void
advertise(void)
@@ -93,8 +92,8 @@
struct ble_gap_adv_params adv_params;
struct ble_hs_adv_fields fields;
/* advertising payload is split into advertising data and advertising
-response, because all data cannot fit into single packet; name of device
-is sent as response to scan request */
+ response, because all data cannot fit into single packet; name of
device
+ is sent as response to scan request */
struct ble_hs_adv_fields rsp_fields;
/*fill all fields and parameters with zeros*/
@@ -103,7 +102,7 @@
memset(_fields, 0, sizeof(rsp_fields));
adv_params.conn_mode = BLE_GAP_CONN_MODE_UND;
-adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
+adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
fields.flags = BLE_HS_ADV_F_DISC_GEN |
BLE_HS_ADV_F_BREDR_UNSUP;
@@ -117,7 +116,7 @@
rsp_fields.name = (uint8_t *)device_name;
rsp_fields.name_len = strlen(device_name);
rsp_fields.name_is_complete = 1;
-
+
rc = ble_gap_adv_set_fields();
assert(rc == 0);
@@ -130,7 +129,7 @@
assert(rc == 0);
}
-static void
+static void
on_sync(void)
{
int rc;
@@ -150,10 +149,11 @@
MODLOG_DFLT(INFO, "Resetting state; reason=%d\n", reason);
}
-int main(int argc, char **argv)
+int
+main(int argc, char **argv)
{
int rc;
-
+
/* Initialize all packages. */
sysinit();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #794: Apps: add peripheral
apache-mynewt-bot commented on issue #794: Apps: add peripheral
URL: https://github.com/apache/mynewt-nimble/pull/794#issuecomment-610901730
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apps/peripheral/src/main.c
```diff
@@ -78,10 +78,10 @@
default:
MODLOG_DFLT(ERROR, "Advertising event not handled,"
"event code: %u\n", event->type);
-break;
+break;
}
return 0;
-}
+}
static void
advertise(void)
@@ -116,7 +116,7 @@
rsp_fields.name = (uint8_t *)device_name;
rsp_fields.name_len = strlen(device_name);
rsp_fields.name_is_complete = 1;
-
+
rc = ble_gap_adv_set_fields();
assert(rc == 0);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #795: Apps readme
apache-mynewt-bot commented on issue #795: Apps readme
URL: https://github.com/apache/mynewt-nimble/pull/795#issuecomment-610897857
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apps/peripheral/src/main.c
```diff
@@ -53,14 +53,13 @@
/* Connection failed; resume advertising */
advertise();
conn_handle = 0;
-}
-else {
+} else {
conn_handle = event->connect.conn_handle;
}
break;
case BLE_GAP_EVENT_CONN_UPDATE_REQ:
/* connected device requests update of connection parameters,
-and these are being filled in - NULL sets default values */
+ and these are being filled in - NULL sets default values */
MODLOG_DFLT(INFO, "updating conncetion parameters...\n");
event->conn_update_req.conn_handle = conn_handle;
event->conn_update_req.peer_params = NULL;
@@ -71,18 +70,18 @@
event->disconnect.reason);
/* reset conn_handle */
-conn_handle = BLE_HS_CONN_HANDLE_NONE;
+conn_handle = BLE_HS_CONN_HANDLE_NONE;
/* Connection terminated; resume advertising */
advertise();
-break;
+break;
default:
MODLOG_DFLT(ERROR, "Advertising event not handled,"
"event code: %u\n", event->type);
-break;
+break;
}
return 0;
-}
+}
static void
advertise(void)
@@ -93,8 +92,8 @@
struct ble_gap_adv_params adv_params;
struct ble_hs_adv_fields fields;
/* advertising payload is split into advertising data and advertising
-response, because all data cannot fit into single packet; name of device
-is sent as response to scan request */
+ response, because all data cannot fit into single packet; name of
device
+ is sent as response to scan request */
struct ble_hs_adv_fields rsp_fields;
/*fill all fields and parameters with zeros*/
@@ -103,7 +102,7 @@
memset(_fields, 0, sizeof(rsp_fields));
adv_params.conn_mode = BLE_GAP_CONN_MODE_UND;
-adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
+adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
fields.flags = BLE_HS_ADV_F_DISC_GEN |
BLE_HS_ADV_F_BREDR_UNSUP;
@@ -117,7 +116,7 @@
rsp_fields.name = (uint8_t *)device_name;
rsp_fields.name_len = strlen(device_name);
rsp_fields.name_is_complete = 1;
-
+
rc = ble_gap_adv_set_fields();
assert(rc == 0);
@@ -130,7 +129,7 @@
assert(rc == 0);
}
-static void
+static void
on_sync(void)
{
int rc;
@@ -150,10 +149,11 @@
MODLOG_DFLT(INFO, "Resetting state; reason=%d\n", reason);
}
-int main(int argc, char **argv)
+int
+main(int argc, char **argv)
{
int rc;
-
+
/* Initialize all packages. */
sysinit();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #794: Apps: add peripheral
apache-mynewt-bot commented on issue #794: Apps: add peripheral
URL: https://github.com/apache/mynewt-nimble/pull/794#issuecomment-610880529
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apps/peripheral/src/main.c
```diff
@@ -53,14 +53,13 @@
/* Connection failed; resume advertising */
advertise();
conn_handle = 0;
-}
-else {
+} else {
conn_handle = event->connect.conn_handle;
}
break;
case BLE_GAP_EVENT_CONN_UPDATE_REQ:
/* connected device requests update of connection parameters,
-and these are being filled in - NULL sets default values */
+ and these are being filled in - NULL sets default values */
MODLOG_DFLT(INFO, "updating conncetion parameters...\n");
event->conn_update_req.conn_handle = conn_handle;
event->conn_update_req.peer_params = NULL;
@@ -71,18 +70,18 @@
event->disconnect.reason);
/* reset conn_handle */
-conn_handle = BLE_HS_CONN_HANDLE_NONE;
+conn_handle = BLE_HS_CONN_HANDLE_NONE;
/* Connection terminated; resume advertising */
advertise();
-break;
+break;
default:
MODLOG_DFLT(ERROR, "Advertising event not handled,"
"event code: %u\n", event->type);
-break;
+break;
}
return 0;
-}
+}
static void
advertise(void)
@@ -93,8 +92,8 @@
struct ble_gap_adv_params adv_params;
struct ble_hs_adv_fields fields;
/* advertising payload is split into advertising data and advertising
-response, because all data cannot fit into single packet; name of device
-is sent as response to scan request */
+ response, because all data cannot fit into single packet; name of
device
+ is sent as response to scan request */
struct ble_hs_adv_fields rsp_fields;
/*fill all fields and parameters with zeros*/
@@ -103,7 +102,7 @@
memset(_fields, 0, sizeof(rsp_fields));
adv_params.conn_mode = BLE_GAP_CONN_MODE_UND;
-adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
+adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
fields.flags = BLE_HS_ADV_F_DISC_GEN |
BLE_HS_ADV_F_BREDR_UNSUP;
@@ -117,7 +116,7 @@
rsp_fields.name = (uint8_t *)device_name;
rsp_fields.name_len = strlen(device_name);
rsp_fields.name_is_complete = 1;
-
+
rc = ble_gap_adv_set_fields();
assert(rc == 0);
@@ -130,7 +129,7 @@
assert(rc == 0);
}
-static void
+static void
on_sync(void)
{
int rc;
@@ -150,10 +149,11 @@
MODLOG_DFLT(INFO, "Resetting state; reason=%d\n", reason);
}
-int main(int argc, char **argv)
+int
+main(int argc, char **argv)
{
int rc;
-
+
/* Initialize all packages. */
sysinit();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] Reynevan94 opened a new pull request #795: Apps readme
Reynevan94 opened a new pull request #795: Apps readme URL: https://github.com/apache/mynewt-nimble/pull/795 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] Reynevan94 opened a new pull request #794: Apps: add peripheral
Reynevan94 opened a new pull request #794: Apps: add peripheral URL: https://github.com/apache/mynewt-nimble/pull/794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit
apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store
behavior when CCCDs exceed static defined limit
URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-610780987
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit
apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble
store behavior when CCCDs exceed static defined limit
URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-610629250
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
