date:20210205

[GitHub] [mynewt-nimble] DurandA opened a new issue #911: apps/blehr: shared variable safety

2021-02-05 Thread GitBox



DurandA opened a new issue #911:
URL: https://github.com/apache/mynewt-nimble/issues/911


   
https://github.com/apache/mynewt-nimble/blob/7b5b5e5b512133e50ef8a517b13e7269f9c821fd/apps/blehr/src/main.c#L33
   
   Probably not an actual bug, but shouldn't `notify_state` in principle use an 
`atomic_bool` or another locking mechanism?
   
   It is written in `blehr_gap_event` callback while it is read in the 
`blehr_tx_hrate` from a timer task.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] kasjer commented on pull request #2413: STM32 RTC based os tick

2021-02-05 Thread GitBox



kasjer commented on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-774317871


   > @kasjer Looks good to me but needs a rebase.
   
   @vrahane I rebased with necessary corrections, thanks for checking out.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2413: STM32 RTC based os tick

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-731284061


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2413: STM32 RTC based os tick

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-774317539


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #910: nimble/phy: Fix tx_late handling

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #910:
URL: https://github.com/apache/mynewt-nimble/pull/910#issuecomment-774286632


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #910: nimble/phy: Fix tx_late handling

2021-02-05 Thread GitBox



andrzej-kaczmarek opened a new pull request #910:
URL: https://github.com/apache/mynewt-nimble/pull/910


   Disabling some errors temporarily to avoid tx_late does not work
   properly because those errors are not reset when BS is reset and we
   may still have CMAC error after those errors are enabled.
   
   To make things work let's just keep all relevant errors disabled and
   ignore them since we can use exceptions status to detect tx_late pretty
   consistently.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] mlaz merged pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



mlaz merged pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[mynewt-core] branch master updated (1a19155 -> 0d34e3a)

2021-02-05 Thread mlaz

This is an automated email from the ASF dual-hosted git repository.

mlaz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git.


from 1a19155  Merge pull request #2471 from benmccrea/fix-cc-alt-eventq
 new fc77156  hal/mcu/nxp: Added NXP Kinetis K8xF MCU support. hal/bsp 
Added frdm-k82f BSP.
 new c65d0e9  mcu/nxp/kinetis: Make MCU_FLASH_MIN_WRITE_SIZE configurable 
on the sub-family level. Remove MK64F12 unneeded dependencies, already included 
on kinetis level.
 new 0d34e3a  Merge pull request #2467 from mlaz/k8xf_support

The 9886 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .rat-excludes  | 8 +
 .style_ignored_dirs| 3 +-
 hw/bsp/frdm-k82f/MK82FN256xxx15_flash.ld   |   240 +
 hw/bsp/frdm-k82f/boot-MK82FN256xxx15_flash.ld  |   235 +
 hw/bsp/frdm-k82f/bsp.yml   |63 +
 .../frdm-k82_debug.cmd}| 0
 .../pkg.yml => bsp/frdm-k82f/frdm-k82_debug.sh}|28 +-
 .../frdm-k82_download.cmd} | 0
 hw/bsp/frdm-k82f/frdm-k82_download.sh  |39 +
 hw/bsp/frdm-k82f/include/bsp/bsp.h |42 +
 hw/bsp/frdm-k82f/pkg.yml   |64 +
 .../src/arch/cortex_m4/startup_MK82F25615.S|   881 +
 hw/bsp/frdm-k82f/src/clock_config.c|   411 +
 hw/bsp/frdm-k82f/src/clock_config.h|   146 +
 hw/bsp/frdm-k82f/src/hal_bsp.c |   298 +
 hw/bsp/frdm-k82f/syscfg.yml|77 +
 hw/mcu/nxp/kinetis/MK64F12/pkg.yml | 2 -
 hw/mcu/nxp/kinetis/MK64F12/syscfg.yml  | 1 +
 .../nxp/kinetis/MK8xF/MK82F/include/MK82F25615.h   | 27511 +++
 .../MK8xF/MK82F/include/MK82F25615_features.h  |  2101 ++
 .../MK8xF/MK82F/include/fsl_device_registers.h |35 +
 .../MK8xF/MK82F/include/system_MK82F25615.h|   132 +
 .../nxp/kinetis/{MK64F12 => MK8xF/MK82F}/pkg.yml   | 8 +-
 .../kinetis/MK8xF/MK82F/src/system_MK82F25615.c|   212 +
 hw/mcu/nxp/kinetis/MK8xF/include/fsl_clock.h   |  1640 ++
 hw/mcu/nxp/kinetis/MK8xF/include/mcu/cmsis_nvic.h  |47 +
 hw/mcu/nxp/kinetis/MK8xF/include/mcu/cortex_m4.h   |42 +
 .../nxp/kinetis/MK8xF/include/mcu/frdm-k8xf_hal.h  |36 +
 .../kinetis/{MK64F12 => MK8xF}/include/mcu/mcu.h   | 0
 hw/mcu/nxp/kinetis/{MK64F12 => MK8xF}/pkg.yml  | 7 +-
 hw/mcu/nxp/kinetis/MK8xF/src/fsl_clock.c   |  2379 ++
 hw/mcu/nxp/kinetis/{MK64F12 => MK8xF}/syscfg.yml   | 8 +
 hw/mcu/nxp/kinetis/syscfg.yml  | 3 +-
 hw/mcu/nxp/pkg.yml | 1 +
 34 files changed, 36676 insertions(+), 24 deletions(-)
 create mode 100644 hw/bsp/frdm-k82f/MK82FN256xxx15_flash.ld
 create mode 100644 hw/bsp/frdm-k82f/boot-MK82FN256xxx15_flash.ld
 create mode 100644 hw/bsp/frdm-k82f/bsp.yml
 copy hw/bsp/{vbluno52/vbluno52_download.cmd => frdm-k82f/frdm-k82_debug.cmd} 
(100%)
 copy hw/{mcu/nxp/kinetis/MK64F12/pkg.yml => bsp/frdm-k82f/frdm-k82_debug.sh} 
(54%)
 mode change 100644 => 100755
 copy hw/bsp/{vbluno52/vbluno52_download.cmd => 
frdm-k82f/frdm-k82_download.cmd} (100%)
 create mode 100755 hw/bsp/frdm-k82f/frdm-k82_download.sh
 create mode 100644 hw/bsp/frdm-k82f/include/bsp/bsp.h
 create mode 100644 hw/bsp/frdm-k82f/pkg.yml
 create mode 100644 hw/bsp/frdm-k82f/src/arch/cortex_m4/startup_MK82F25615.S
 create mode 100644 hw/bsp/frdm-k82f/src/clock_config.c
 create mode 100644 hw/bsp/frdm-k82f/src/clock_config.h
 create mode 100644 hw/bsp/frdm-k82f/src/hal_bsp.c
 create mode 100644 hw/bsp/frdm-k82f/syscfg.yml
 create mode 100644 hw/mcu/nxp/kinetis/MK8xF/MK82F/include/MK82F25615.h
 create mode 100644 hw/mcu/nxp/kinetis/MK8xF/MK82F/include/MK82F25615_features.h
 create mode 100644 
hw/mcu/nxp/kinetis/MK8xF/MK82F/include/fsl_device_registers.h
 create mode 100644 hw/mcu/nxp/kinetis/MK8xF/MK82F/include/system_MK82F25615.h
 copy hw/mcu/nxp/kinetis/{MK64F12 => MK8xF/MK82F}/pkg.yml (79%)
 create mode 100644 hw/mcu/nxp/kinetis/MK8xF/MK82F/src/system_MK82F25615.c
 create mode 100644 hw/mcu/nxp/kinetis/MK8xF/include/fsl_clock.h
 create mode 100644 hw/mcu/nxp/kinetis/MK8xF/include/mcu/cmsis_nvic.h
 create mode 100644 hw/mcu/nxp/kinetis/MK8xF/include/mcu/cortex_m4.h
 create mode 100644 hw/mcu/nxp/kinetis/MK8xF/include/mcu/frdm-k8xf_hal.h
 copy hw/mcu/nxp/kinetis/{MK64F12 => MK8xF}/include/mcu/mcu.h (100%)
 copy hw/mcu/nxp/kinetis/{MK64F12 => MK8xF}/pkg.yml (84%)
 create mode 100644 hw/mcu/nxp/kinetis/MK8xF/src/fsl_clock.c
 copy hw/mcu/nxp/kinetis/{MK64F12 => MK8xF}/syscfg.yml (84%)

[GitHub] [mynewt-core] benmccrea merged pull request #2471: charge-control: Fix to allow usage of an alternate event queue.

2021-02-05 Thread GitBox



benmccrea merged pull request #2471:
URL: https://github.com/apache/mynewt-core/pull/2471


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[mynewt-core] branch master updated: charge-control: Fix to allow usage of an alternate event queue.

2021-02-05 Thread benmccrea

This is an automated email from the ASF dual-hosted git repository.

benmccrea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
 new 01d9008  charge-control: Fix to allow usage of an alternate event 
queue.
 new 1a19155  Merge pull request #2471 from benmccrea/fix-cc-alt-eventq
01d9008 is described below

commit 01d9008875dd262830e16d4fc8775ac56a9f0cfb
Author: Ben McCrea 
AuthorDate: Wed Feb 3 12:54:00 2021 -0800

charge-control: Fix to allow usage of an alternate event queue.
---
 hw/charge-control/src/charge_control.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/hw/charge-control/src/charge_control.c 
b/hw/charge-control/src/charge_control.c
index 683e701..8b29543 100644
--- a/hw/charge-control/src/charge_control.c
+++ b/hw/charge-control/src/charge_control.c
@@ -181,6 +181,10 @@ static struct os_event charge_control_read_event = {
 .ev_cb = charge_control_read_ev_cb,
 };
 
+#ifdef MYNEWT_VAL_CHARGE_CONTROL_MGR_EVQ
+extern struct os_eventq MYNEWT_VAL(CHARGE_CONTROL_MGR_EVQ);
+#endif
+
 /* =
  * == PKG ==
  * =
@@ -210,7 +214,7 @@ charge_control_read_ev_cb(struct os_event *ev)
 struct charge_control_read_ev_ctx *ccrec;
 
 ccrec = ev->ev_arg;
-rc = charge_control_read(ccrec->ccrec_charge_control, ccrec->ccrec_type, 
+rc = charge_control_read(ccrec->ccrec_charge_control, ccrec->ccrec_type,
 NULL, NULL, OS_TIMEOUT_NEVER);
 assert(rc == 0);
 }
@@ -801,7 +805,7 @@ charge_control_mgr_init(void)
 struct os_timezone ostz;
 
 #ifdef MYNEWT_VAL_CHARGE_CONTROL_MGR_EVQ
-charge_control_mgr_evq_set(MYNEWT_VAL(CHARGE_CONTROL_MGR_EVQ));
+charge_control_mgr_evq_set(_VAL(CHARGE_CONTROL_MGR_EVQ));
 #else
 charge_control_mgr_evq_set(os_eventq_dflt_get());
 #endif

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-774187087


   
   ## Style check fail: Payload was too large



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-774141805


   
   ## Style check fail: Payload was too large



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



mlaz commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r571145012



##
File path: hw/bsp/frdm-k82f/src/hal_bsp.c
##
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "os/mynewt.h"
+#include "bsp/bsp.h"
+#include "hal/hal_bsp.h"
+#include "hal/hal_flash_int.h"
+#include "flash_map/flash_map.h"
+#include "hal/hal_flash.h"
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+#include 
+#endif
+#if MYNEWT_VAL(UART_0) || MYNEWT_VAL(UART_1) || MYNEWT_VAL(UART_2) || \
+MYNEWT_VAL(UART_3) || MYNEWT_VAL(UART_4)
+#include "uart/uart.h"
+#include "uart_hal/uart_hal.h"
+#include "hal/hal_uart.h"
+#endif
+#if MYNEWT_VAL(I2C_0) || MYNEWT_VAL(I2C_1) || MYNEWT_VAL(I2C_2) || 
MYNEWT_VAL(I2C_3)
+#include "hal/hal_i2c.h"
+#endif
+#if MYNEWT_VAL(SPI_0_MASTER) || MYNEWT_VAL(SPI_1_MASTER) || \
+MYNEWT_VAL(SPI_2_MASTER) || MYNEWT_VAL(SPI_0_SLAVE) || \
+MYNEWT_VAL(SPI_1_SLAVE) || MYNEWT_VAL(SPI_2_SLAVE)
+#include "hal/hal_spi.h"
+#endif
+#include "mcu/cmsis_nvic.h"
+#include "mcu/frdm-k8xf_hal.h"
+#include "fsl_device_registers.h"
+#include "fsl_common.h"
+#include "fsl_clock.h"
+#include "fsl_port.h"
+#include "clock_config.h"
+
+#if MYNEWT_VAL(UART_0)
+static struct uart_dev os_bsp_uart0;
+#endif
+#if MYNEWT_VAL(UART_1)
+static struct uart_dev os_bsp_uart1;
+#endif
+#if MYNEWT_VAL(UART_2)
+static struct uart_dev os_bsp_uart2;
+#endif
+#if MYNEWT_VAL(UART_3)
+static struct uart_dev os_bsp_uart3;
+#endif
+#if MYNEWT_VAL(UART_4)
+static struct uart_dev os_bsp_uart4;
+#endif
+
+#if MYNEWT_VAL(I2C_0)
+static const struct nxp_hal_i2c_cfg hal_i2c0_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_0_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_0_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_0_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_1)
+static const struct nxp_hal_i2c_cfg hal_i2c1_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_1_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_1_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_1_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_2)
+static const struct nxp_hal_i2c_cfg hal_i2c2_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_2_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_2_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_2_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_3)
+static const struct nxp_hal_i2c_cfg hal_i2c3_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_3_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_3_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_3_FREQ_KHZ),
+};
+#endif
+
+
+/*
+ * What memory to include in coredump.
+ */
+static const struct hal_bsp_mem_dump dump_cfg[] = {
+[0] = {
+.hbmd_start = &__DATA_ROM,
+.hbmd_size = RAM_SIZE
+}
+};
+
+static void init_hardware(void)
+{
+/* Disable the MPU otherwise USB cannot access the bus */
+SYSMPU->CESR = 0;
+
+/* Enable all the ports */
+SIM->SCGC5 |= (SIM_SCGC5_PORTA_MASK | SIM_SCGC5_PORTB_MASK | 
SIM_SCGC5_PORTC_MASK | SIM_SCGC5_PORTD_MASK |
+   SIM_SCGC5_PORTE_MASK);
+}
+
+extern void BOARD_BootClockRUN(void);
+
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+static struct eflash_crypto_dev enc_flash_dev0 = {
+.ecd_dev = {
+.efd_hal = {
+.hf_itf = _flash_funcs,
+},
+.efd_hwdev = _flash_dev,
+}
+};
+#endif
+
+const struct hal_flash *
+hal_bsp_flash_dev(uint8_t id)
+{
+if (id == 0) {
+return _flash_dev;
+}
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+if (id == 1) {
+return _qspi_dev;
+}
+#endif
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+if (id == 2) {
+return _flash_dev0.ecd_dev.efd_hal;
+}
+#endif
+return NULL;
+}
+
+const struct hal_bsp_mem_dump *
+hal_bsp_core_dump(int *area_cnt)
+{
+*area_cnt = sizeof(dump_cfg) / sizeof(dump_cfg[0]);
+return dump_cfg;
+}
+
+int
+hal_bsp_power_state(int state)
+{
+return (0);
+}
+
+/*!
+ * @brief Function to override ARMGCC default function _sbrk
+ *
+ * _sbrk is called by malloc. ARMGCC default _sbrk compares "SP" register and
+ * heap end, if heap end is larger than "SP", then _sbrk returns error and
+ * memory allocation failed. This function changes to compare __HeapLimit with
+ * heap end.
+ */
+void *_sbrk(int incr)
+{
+extern char

[GitHub] [mynewt-core] utzig commented on a change in pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



utzig commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r571134718



##
File path: hw/bsp/frdm-k82f/src/hal_bsp.c
##
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "os/mynewt.h"
+#include "bsp/bsp.h"
+#include "hal/hal_bsp.h"
+#include "hal/hal_flash_int.h"
+#include "flash_map/flash_map.h"
+#include "hal/hal_flash.h"
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+#include 
+#endif
+#if MYNEWT_VAL(UART_0) || MYNEWT_VAL(UART_1) || MYNEWT_VAL(UART_2) || \
+MYNEWT_VAL(UART_3) || MYNEWT_VAL(UART_4)
+#include "uart/uart.h"
+#include "uart_hal/uart_hal.h"
+#include "hal/hal_uart.h"
+#endif
+#if MYNEWT_VAL(I2C_0) || MYNEWT_VAL(I2C_1) || MYNEWT_VAL(I2C_2) || 
MYNEWT_VAL(I2C_3)
+#include "hal/hal_i2c.h"
+#endif
+#if MYNEWT_VAL(SPI_0_MASTER) || MYNEWT_VAL(SPI_1_MASTER) || \
+MYNEWT_VAL(SPI_2_MASTER) || MYNEWT_VAL(SPI_0_SLAVE) || \
+MYNEWT_VAL(SPI_1_SLAVE) || MYNEWT_VAL(SPI_2_SLAVE)
+#include "hal/hal_spi.h"
+#endif
+#include "mcu/cmsis_nvic.h"
+#include "mcu/frdm-k8xf_hal.h"
+#include "fsl_device_registers.h"
+#include "fsl_common.h"
+#include "fsl_clock.h"
+#include "fsl_port.h"
+#include "clock_config.h"
+
+#if MYNEWT_VAL(UART_0)
+static struct uart_dev os_bsp_uart0;
+#endif
+#if MYNEWT_VAL(UART_1)
+static struct uart_dev os_bsp_uart1;
+#endif
+#if MYNEWT_VAL(UART_2)
+static struct uart_dev os_bsp_uart2;
+#endif
+#if MYNEWT_VAL(UART_3)
+static struct uart_dev os_bsp_uart3;
+#endif
+#if MYNEWT_VAL(UART_4)
+static struct uart_dev os_bsp_uart4;
+#endif
+
+#if MYNEWT_VAL(I2C_0)
+static const struct nxp_hal_i2c_cfg hal_i2c0_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_0_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_0_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_0_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_1)
+static const struct nxp_hal_i2c_cfg hal_i2c1_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_1_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_1_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_1_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_2)
+static const struct nxp_hal_i2c_cfg hal_i2c2_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_2_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_2_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_2_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_3)
+static const struct nxp_hal_i2c_cfg hal_i2c3_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_3_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_3_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_3_FREQ_KHZ),
+};
+#endif
+
+
+/*
+ * What memory to include in coredump.
+ */
+static const struct hal_bsp_mem_dump dump_cfg[] = {
+[0] = {
+.hbmd_start = &__DATA_ROM,
+.hbmd_size = RAM_SIZE
+}
+};
+
+static void init_hardware(void)
+{
+/* Disable the MPU otherwise USB cannot access the bus */
+SYSMPU->CESR = 0;
+
+/* Enable all the ports */
+SIM->SCGC5 |= (SIM_SCGC5_PORTA_MASK | SIM_SCGC5_PORTB_MASK | 
SIM_SCGC5_PORTC_MASK | SIM_SCGC5_PORTD_MASK |
+   SIM_SCGC5_PORTE_MASK);
+}
+
+extern void BOARD_BootClockRUN(void);
+
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+static struct eflash_crypto_dev enc_flash_dev0 = {
+.ecd_dev = {
+.efd_hal = {
+.hf_itf = _flash_funcs,
+},
+.efd_hwdev = _flash_dev,
+}
+};
+#endif
+
+const struct hal_flash *
+hal_bsp_flash_dev(uint8_t id)
+{
+if (id == 0) {
+return _flash_dev;
+}
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+if (id == 1) {
+return _qspi_dev;
+}
+#endif
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+if (id == 2) {
+return _flash_dev0.ecd_dev.efd_hal;
+}
+#endif
+return NULL;
+}
+
+const struct hal_bsp_mem_dump *
+hal_bsp_core_dump(int *area_cnt)
+{
+*area_cnt = sizeof(dump_cfg) / sizeof(dump_cfg[0]);
+return dump_cfg;
+}
+
+int
+hal_bsp_power_state(int state)
+{
+return (0);
+}
+
+/*!
+ * @brief Function to override ARMGCC default function _sbrk
+ *
+ * _sbrk is called by malloc. ARMGCC default _sbrk compares "SP" register and
+ * heap end, if heap end is larger than "SP", then _sbrk returns error and
+ * memory allocation failed. This function changes to compare __HeapLimit with
+ * heap end.
+ */
+void *_sbrk(int incr)
+{
+extern

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-774141805


   
   ## Style check fail: Payload was too large



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-774081521


   
   ## Style check fail: Payload was too large



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



mlaz commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r571093344



##
File path: hw/bsp/frdm-k82f/src/hal_bsp.c
##
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "os/mynewt.h"
+#include "bsp/bsp.h"
+#include "hal/hal_bsp.h"
+#include "hal/hal_flash_int.h"
+#include "flash_map/flash_map.h"
+#include "hal/hal_flash.h"
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+#include 
+#endif
+#if MYNEWT_VAL(UART_0) || MYNEWT_VAL(UART_1) || MYNEWT_VAL(UART_2) || \
+MYNEWT_VAL(UART_3) || MYNEWT_VAL(UART_4)
+#include "uart/uart.h"
+#include "uart_hal/uart_hal.h"
+#include "hal/hal_uart.h"
+#endif
+#if MYNEWT_VAL(I2C_0) || MYNEWT_VAL(I2C_1) || MYNEWT_VAL(I2C_2) || 
MYNEWT_VAL(I2C_3)
+#include "hal/hal_i2c.h"
+#endif
+#if MYNEWT_VAL(SPI_0_MASTER) || MYNEWT_VAL(SPI_1_MASTER) || \
+MYNEWT_VAL(SPI_2_MASTER) || MYNEWT_VAL(SPI_0_SLAVE) || \
+MYNEWT_VAL(SPI_1_SLAVE) || MYNEWT_VAL(SPI_2_SLAVE)
+#include "hal/hal_spi.h"
+#endif
+#include "mcu/cmsis_nvic.h"
+#include "mcu/frdm-k8xf_hal.h"
+#include "fsl_device_registers.h"
+#include "fsl_common.h"
+#include "fsl_clock.h"
+#include "fsl_port.h"
+#include "clock_config.h"
+
+#if MYNEWT_VAL(UART_0)
+static struct uart_dev os_bsp_uart0;
+#endif
+#if MYNEWT_VAL(UART_1)
+static struct uart_dev os_bsp_uart1;
+#endif
+#if MYNEWT_VAL(UART_2)
+static struct uart_dev os_bsp_uart2;
+#endif
+#if MYNEWT_VAL(UART_3)
+static struct uart_dev os_bsp_uart3;
+#endif
+#if MYNEWT_VAL(UART_4)
+static struct uart_dev os_bsp_uart4;
+#endif
+
+#if MYNEWT_VAL(I2C_0)
+static const struct nxp_hal_i2c_cfg hal_i2c0_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_0_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_0_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_0_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_1)
+static const struct nxp_hal_i2c_cfg hal_i2c1_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_1_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_1_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_1_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_2)
+static const struct nxp_hal_i2c_cfg hal_i2c2_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_2_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_2_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_2_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_3)
+static const struct nxp_hal_i2c_cfg hal_i2c3_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_3_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_3_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_3_FREQ_KHZ),
+};
+#endif
+
+
+/*
+ * What memory to include in coredump.
+ */
+static const struct hal_bsp_mem_dump dump_cfg[] = {
+[0] = {
+.hbmd_start = &__DATA_ROM,
+.hbmd_size = RAM_SIZE
+}
+};
+
+static void init_hardware(void)
+{
+/* Disable the MPU otherwise USB cannot access the bus */
+SYSMPU->CESR = 0;
+
+/* Enable all the ports */
+SIM->SCGC5 |= (SIM_SCGC5_PORTA_MASK | SIM_SCGC5_PORTB_MASK | 
SIM_SCGC5_PORTC_MASK | SIM_SCGC5_PORTD_MASK |
+   SIM_SCGC5_PORTE_MASK);
+}
+
+extern void BOARD_BootClockRUN(void);
+
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+static struct eflash_crypto_dev enc_flash_dev0 = {
+.ecd_dev = {
+.efd_hal = {
+.hf_itf = _flash_funcs,
+},
+.efd_hwdev = _flash_dev,
+}
+};
+#endif
+
+const struct hal_flash *
+hal_bsp_flash_dev(uint8_t id)
+{
+if (id == 0) {
+return _flash_dev;
+}
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+if (id == 1) {
+return _qspi_dev;
+}
+#endif
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+if (id == 2) {
+return _flash_dev0.ecd_dev.efd_hal;
+}
+#endif
+return NULL;
+}
+
+const struct hal_bsp_mem_dump *
+hal_bsp_core_dump(int *area_cnt)
+{
+*area_cnt = sizeof(dump_cfg) / sizeof(dump_cfg[0]);
+return dump_cfg;
+}
+
+int
+hal_bsp_power_state(int state)
+{
+return (0);
+}
+
+/*!
+ * @brief Function to override ARMGCC default function _sbrk
+ *
+ * _sbrk is called by malloc. ARMGCC default _sbrk compares "SP" register and
+ * heap end, if heap end is larger than "SP", then _sbrk returns error and
+ * memory allocation failed. This function changes to compare __HeapLimit with
+ * heap end.
+ */
+void *_sbrk(int incr)
+{
+extern char

[GitHub] [mynewt-core] utzig commented on a change in pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



utzig commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r571044755



##
File path: hw/bsp/frdm-k82f/src/hal_bsp.c
##
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "os/mynewt.h"
+#include "bsp/bsp.h"
+#include "hal/hal_bsp.h"
+#include "hal/hal_flash_int.h"
+#include "flash_map/flash_map.h"
+#include "hal/hal_flash.h"
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+#include 
+#endif
+#if MYNEWT_VAL(UART_0) || MYNEWT_VAL(UART_1) || MYNEWT_VAL(UART_2) || \
+MYNEWT_VAL(UART_3) || MYNEWT_VAL(UART_4)
+#include "uart/uart.h"
+#include "uart_hal/uart_hal.h"
+#include "hal/hal_uart.h"
+#endif
+#if MYNEWT_VAL(I2C_0) || MYNEWT_VAL(I2C_1) || MYNEWT_VAL(I2C_2) || 
MYNEWT_VAL(I2C_3)
+#include "hal/hal_i2c.h"
+#endif
+#if MYNEWT_VAL(SPI_0_MASTER) || MYNEWT_VAL(SPI_1_MASTER) || \
+MYNEWT_VAL(SPI_2_MASTER) || MYNEWT_VAL(SPI_0_SLAVE) || \
+MYNEWT_VAL(SPI_1_SLAVE) || MYNEWT_VAL(SPI_2_SLAVE)
+#include "hal/hal_spi.h"
+#endif
+#include "mcu/cmsis_nvic.h"
+#include "mcu/frdm-k8xf_hal.h"
+#include "fsl_device_registers.h"
+#include "fsl_common.h"
+#include "fsl_clock.h"
+#include "fsl_port.h"
+#include "clock_config.h"
+
+#if MYNEWT_VAL(UART_0)
+static struct uart_dev os_bsp_uart0;
+#endif
+#if MYNEWT_VAL(UART_1)
+static struct uart_dev os_bsp_uart1;
+#endif
+#if MYNEWT_VAL(UART_2)
+static struct uart_dev os_bsp_uart2;
+#endif
+#if MYNEWT_VAL(UART_3)
+static struct uart_dev os_bsp_uart3;
+#endif
+#if MYNEWT_VAL(UART_4)
+static struct uart_dev os_bsp_uart4;
+#endif
+
+#if MYNEWT_VAL(I2C_0)
+static const struct nxp_hal_i2c_cfg hal_i2c0_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_0_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_0_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_0_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_1)
+static const struct nxp_hal_i2c_cfg hal_i2c1_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_1_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_1_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_1_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_2)
+static const struct nxp_hal_i2c_cfg hal_i2c2_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_2_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_2_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_2_FREQ_KHZ),
+};
+#endif
+#if MYNEWT_VAL(I2C_3)
+static const struct nxp_hal_i2c_cfg hal_i2c3_cfg = {
+.pin_sda = MYNEWT_VAL(I2C_3_PIN_SDA),
+.pin_scl = MYNEWT_VAL(I2C_3_PIN_SCL),
+.frequency = MYNEWT_VAL(I2C_3_FREQ_KHZ),
+};
+#endif
+
+
+/*
+ * What memory to include in coredump.
+ */
+static const struct hal_bsp_mem_dump dump_cfg[] = {
+[0] = {
+.hbmd_start = &__DATA_ROM,
+.hbmd_size = RAM_SIZE
+}
+};
+
+static void init_hardware(void)
+{
+/* Disable the MPU otherwise USB cannot access the bus */
+SYSMPU->CESR = 0;
+
+/* Enable all the ports */
+SIM->SCGC5 |= (SIM_SCGC5_PORTA_MASK | SIM_SCGC5_PORTB_MASK | 
SIM_SCGC5_PORTC_MASK | SIM_SCGC5_PORTD_MASK |
+   SIM_SCGC5_PORTE_MASK);
+}
+
+extern void BOARD_BootClockRUN(void);
+
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+static struct eflash_crypto_dev enc_flash_dev0 = {
+.ecd_dev = {
+.efd_hal = {
+.hf_itf = _flash_funcs,
+},
+.efd_hwdev = _flash_dev,
+}
+};
+#endif
+
+const struct hal_flash *
+hal_bsp_flash_dev(uint8_t id)
+{
+if (id == 0) {
+return _flash_dev;
+}
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+if (id == 1) {
+return _qspi_dev;
+}
+#endif
+#if MYNEWT_VAL(ENC_FLASH_DEV)
+if (id == 2) {
+return _flash_dev0.ecd_dev.efd_hal;
+}
+#endif
+return NULL;
+}
+
+const struct hal_bsp_mem_dump *
+hal_bsp_core_dump(int *area_cnt)
+{
+*area_cnt = sizeof(dump_cfg) / sizeof(dump_cfg[0]);
+return dump_cfg;
+}
+
+int
+hal_bsp_power_state(int state)
+{
+return (0);
+}
+
+/*!
+ * @brief Function to override ARMGCC default function _sbrk
+ *
+ * _sbrk is called by malloc. ARMGCC default _sbrk compares "SP" register and
+ * heap end, if heap end is larger than "SP", then _sbrk returns error and
+ * memory allocation failed. This function changes to compare __HeapLimit with
+ * heap end.
+ */
+void *_sbrk(int incr)
+{
+extern

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2401: hw/mcu/dialog: Keep GPIO mux powered if non-GPIO pins enabled

2021-02-05 Thread GitBox



kasjer commented on a change in pull request #2401:
URL: https://github.com/apache/mynewt-core/pull/2401#discussion_r571030345



##
File path: hw/mcu/dialog/da1469x/src/hal_gpio.c
##
@@ -90,6 +90,7 @@ static struct hal_gpio_irq hal_gpio_irqs[HAL_GPIO_MAX_IRQ];
 #if MYNEWT_VAL(MCU_GPIO_RETAINABLE_NUM) >= 0
 static uint32_t g_mcu_gpio_latch_state[2];
 static uint8_t g_mcu_gpio_retained_num;
+static uint32_t g_mcu_gpio_can_sleep;

Review comment:
   for now this variable is used only with values 0/1 maybe uint32_t is too 
much





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-774081521


   
   ## Style check fail: Payload was too large



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-773710118


   
   ## Style check fail: Payload was too large



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



mlaz commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r571021811



##
File path: hw/mcu/nxp/kinetis/MK8xF/include/mcu/frdm-k8xf_hal.h
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef __MCU_FRDMK8XF_BSP_H_
+#define __MCU_FRDMK8XF_BSP_H_
+
+#ifdef __cplusplus
+ extern "C" {
+#endif
+
+struct hal_flash;
+extern const struct hal_flash kinetis_flash_dev;
+extern const struct hal_flash nxp_qspi_dev;
+
+struct nxp_hal_i2c_cfg {
+int8_t pin_scl;
+int8_t pin_sda;
+uint32_t frequency;
+};
+
+struct nxp_hal_spi_cfg {
+uint32_t clk_pin;
+uint32_t pcs_pin;
+uint32_t sout_pin;
+uint32_t sin_pin;
+};

Review comment:
   Done.

##
File path: .rat-excludes
##
@@ -291,6 +291,15 @@ fsl_clock.c
 MK64FN1M0xxx12_flash.ld
 boot-MK64FN1M0xxx12_flash.ld
 startup_MK64F12.S
+MK82FN256xxx15_flash.ld
+boot-MK82FN256xxx15_flash.ld
+startup_MK82F25615.S
+MK82F25615.h
+MK82F25615_features.h
+system_MK82F25615.h
+system_MK82F25615.c
+fsl_clock.h
+

Review comment:
   Done.

##
File path: hw/mcu/nxp/kinetis/MK64F12/pkg.yml
##
@@ -23,6 +23,4 @@ pkg.author: "Apache Mynewt "
 pkg.homepage: "http://mynewt.apache.org/;
 
 pkg.deps:
-- "@apache-mynewt-core/hw/hal"
-- "@apache-mynewt-core/hw/cmsis-core"

Review comment:
   Done.

##
File path: hw/mcu/nxp/kinetis/MK64F12/syscfg.yml
##
@@ -17,3 +17,4 @@
 #
 syscfg.vals:
 OS_TICKS_PER_SEC: 1000
+MCU_FLASH_MIN_WRITE_SIZE: 2

Review comment:
   Done.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2472: MTB in core dump

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774009509


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2472: MTB in core dump

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774018154


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2472: MTB in core dump

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774009509


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] kasjer opened a new pull request #2472: MTB in core dump

2021-02-05 Thread GitBox



kasjer opened a new pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472


   - MTB registers are stored in RAM when crash happens so MTB can be used 
check what lead to crash
   - MTB is also stopped in __assert_function() not only in default interrupt 
handler
   - disassemble of non existing memory region does not stop script for 
continuing
   - instruction preceding exception are displayed



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] utzig commented on a change in pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



utzig commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r570888242



##
File path: .rat-excludes
##
@@ -291,6 +291,15 @@ fsl_clock.c
 MK64FN1M0xxx12_flash.ld
 boot-MK64FN1M0xxx12_flash.ld
 startup_MK64F12.S
+MK82FN256xxx15_flash.ld
+boot-MK82FN256xxx15_flash.ld
+startup_MK82F25615.S
+MK82F25615.h
+MK82F25615_features.h
+system_MK82F25615.h
+system_MK82F25615.c
+fsl_clock.h
+

Review comment:
   Remove the empty line.

##
File path: hw/mcu/nxp/kinetis/MK64F12/pkg.yml
##
@@ -23,6 +23,4 @@ pkg.author: "Apache Mynewt "
 pkg.homepage: "http://mynewt.apache.org/;
 
 pkg.deps:
-- "@apache-mynewt-core/hw/hal"
-- "@apache-mynewt-core/hw/cmsis-core"

Review comment:
   Unrelated to K8x, move into another commit with rationale.

##
File path: hw/mcu/nxp/kinetis/MK64F12/syscfg.yml
##
@@ -17,3 +17,4 @@
 #
 syscfg.vals:
 OS_TICKS_PER_SEC: 1000
+MCU_FLASH_MIN_WRITE_SIZE: 2

Review comment:
   Move K6x changes into another commit.

##
File path: hw/mcu/nxp/kinetis/MK8xF/include/mcu/frdm-k8xf_hal.h
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef __MCU_FRDMK8XF_BSP_H_
+#define __MCU_FRDMK8XF_BSP_H_
+
+#ifdef __cplusplus
+ extern "C" {
+#endif
+
+struct hal_flash;
+extern const struct hal_flash kinetis_flash_dev;
+extern const struct hal_flash nxp_qspi_dev;
+
+struct nxp_hal_i2c_cfg {
+int8_t pin_scl;
+int8_t pin_sda;
+uint32_t frequency;
+};
+
+struct nxp_hal_spi_cfg {
+uint32_t clk_pin;
+uint32_t pcs_pin;
+uint32_t sout_pin;
+uint32_t sin_pin;
+};

Review comment:
   Why are `nxp_hal_i2c_cfg` and `nxp_hal_spi_cfg` redefined here if they 
are already in `mcu/kinetis_hal.h`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2459: net/osdp: Add OSDP library

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #2459:
URL: https://github.com/apache/mynewt-core/pull/2459#issuecomment-765806173







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] utzig commented on pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



utzig commented on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-773702301


   This is not properly rebased, you can just drop the first two commits.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2466: mcu/nxp: Update NXP SDK and add Kinetis common HAL.

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #2466:
URL: https://github.com/apache/mynewt-core/pull/2466#issuecomment-772985567







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] utzig merged pull request #2470: [KINETIS] Turn pyocd into a reusable script

2021-02-05 Thread GitBox



utzig merged pull request #2470:
URL: https://github.com/apache/mynewt-core/pull/2470


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] vrahane edited a comment on pull request #2456: Update lwip_base to LWIP 2.1.2

2021-02-05 Thread GitBox



vrahane edited a comment on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-773202724


   Next step is merging it @jeremywood. Thank you.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2465: Update mbedTLS from 2.16.5 to 2.16.9

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #2465:
URL: https://github.com/apache/mynewt-core/pull/2465#issuecomment-772805332


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #908: nimble/test: Fix LE SC tests

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #908:
URL: https://github.com/apache/mynewt-nimble/pull/908#issuecomment-773216768


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] utzig edited a comment on pull request #2466: mcu/nxp: Update NXP SDK and add Kinetis common HAL.

2021-02-05 Thread GitBox



utzig edited a comment on pull request #2466:
URL: https://github.com/apache/mynewt-core/pull/2466#issuecomment-773691606


   @mlaz I am fine with this now, please force-push again to check if no RAT 
issues remain, for some reason it was no updating the message.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] kasjer merged pull request #2439: Fixed MMC starting frequency

2021-02-05 Thread GitBox



kasjer merged pull request #2439:
URL: https://github.com/apache/mynewt-core/pull/2439


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-773614820







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] utzig merged pull request #2468: hw/mcu/stm: Add missing ld file for nucleo-l073rz BSP

2021-02-05 Thread GitBox



utzig merged pull request #2468:
URL: https://github.com/apache/mynewt-core/pull/2468


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2471: charge-control: Fix to allow usage of an alternate event queue.

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2471:
URL: https://github.com/apache/mynewt-core/pull/2471#issuecomment-773698727


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2463: hw/mcu/da1469x: Fix HAL UART creation

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2463:
URL: https://github.com/apache/mynewt-core/pull/2463#issuecomment-773085640


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] vrahane commented on pull request #2413: STM32 RTC based os tick

2021-02-05 Thread GitBox



vrahane commented on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-773207940


   @kasjer Looks good to me but needs a rebase.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] vrahane merged pull request #2456: Update lwip_base to LWIP 2.1.2

2021-02-05 Thread GitBox



vrahane merged pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] vrahane merged pull request #2459: net/osdp: Add OSDP library

2021-02-05 Thread GitBox



vrahane merged pull request #2459:
URL: https://github.com/apache/mynewt-core/pull/2459


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2461: stm32 spi bus driver

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #2461:
URL: https://github.com/apache/mynewt-core/pull/2461#issuecomment-772577358


   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/bus/drivers/spi_stm32/src/spi_stm32.c
   
   
   ```diff
   @@ -66,15 +66,15 @@

#if MYNEWT_VAL(SPI_STM32_STAT)
STATS_SECT_START(spi_stm32_stats_section)
   -STATS_SECT_ENTRY(read_bytes)
   -STATS_SECT_ENTRY(written_bytes)
   -STATS_SECT_ENTRY(dma_transferred_bytes)
   +STATS_SECT_ENTRY(read_bytes)
   +STATS_SECT_ENTRY(written_bytes)
   +STATS_SECT_ENTRY(dma_transferred_bytes)
STATS_SECT_END

STATS_NAME_START(spi_stm32_stats_section)
   -STATS_NAME(spi_stm32_stats_section, read_bytes)
   -STATS_NAME(spi_stm32_stats_section, written_bytes)
   -STATS_NAME(spi_stm32_stats_section, dma_transferred_bytes)
   +STATS_NAME(spi_stm32_stats_section, read_bytes)
   +STATS_NAME(spi_stm32_stats_section, written_bytes)
   +STATS_NAME(spi_stm32_stats_section, dma_transferred_bytes)
STATS_NAME_END(spi_stm32_stats_section)
#endif

   @@ -649,8 +649,8 @@

static int
spi_stm32_read(struct bus_dev *bdev, struct bus_node *bnode,
   - uint8_t *buf, uint16_t length, os_time_t timeout,
   - uint16_t flags)
   +   uint8_t *buf, uint16_t length, os_time_t timeout,
   +   uint16_t flags)
{
struct bus_spi_dev *dev = (struct bus_spi_dev *)bdev;
struct bus_spi_node *node = (struct bus_spi_node *)bnode;
   @@ -690,8 +690,8 @@

static int
spi_stm32_write(struct bus_dev *bdev, struct bus_node *bnode,
   -  const uint8_t *buf, uint16_t length, os_time_t timeout,
   -  uint16_t flags)
   +const uint8_t *buf, uint16_t length, os_time_t timeout,
   +uint16_t flags)
{
struct bus_spi_dev *dev = (struct bus_spi_dev *)bdev;
struct bus_spi_node *node = (struct bus_spi_node *)bnode;
   ```
   
   
   
    hw/bus/drivers/spi_stm32/stm32f0xx/src/spidmacfg.c
   
   
   ```diff
   @@ -22,11 +22,13 @@
#include 

#define DMA_IRQn(ch) ((ch) == DMA1_CH1 ? DMA1_Ch1_IRQn : \
   -((ch) >= DMA1_CH2 && (ch) <= DMA1_CH3) || ((ch) >= 
DMA2_CH1 && (ch) <=DMA2_CH2) ? DMA1_Channel2_3_IRQn : \
   -DMA1_Channel4_5_IRQn)
   +  ((ch) >= DMA1_CH2 && (ch) <= DMA1_CH3) || \
   +  ((ch) >= DMA2_CH1 && (ch) <= DMA2_CH2) ? 
DMA1_Channel2_3_IRQn : \
   +  DMA1_Channel4_5_IRQn)
#define DMA_IRQ_HANDLER(ch) ((ch) == DMA1_CH1 ? stm32_dma1_1_irq_handler : \
   -((ch) >= DMA1_CH2 && (ch) <= DMA1_CH3) || ((ch) >= 
DMA2_CH1 && (ch) <=DMA2_CH2) ? stm32_dma1_2_3_irq_handler : \
   -stm32_dma1_4_5_6_7_irq_handler)
   + ((ch) >= DMA1_CH2 && (ch) <= DMA1_CH3) || \
   + ((ch) >= DMA2_CH1 && (ch) <= DMA2_CH2) ? 
stm32_dma1_2_3_irq_handler : \
   + stm32_dma1_4_5_6_7_irq_handler)

#define SPI_DMA_RX_CHANNEL_DEFINE(dma, ch, name)\
const struct stm32_dma_cfg DMA ## dma ## _channel ## ch = { \
   ```
   
   
   
    hw/bus/drivers/spi_stm32/stm32l0xx/src/spidmacfg.c
   
   
   ```diff
   @@ -21,7 +21,7 @@
#include 
#include 

   -#define DMA_IRQn(ch) ((uint8_t)DMA1_Channel1_IRQn + (((DMA1_CH3) > 3) ? 2 : 
((DMA1_CH3) >> 1 )))
   +#define DMA_IRQn(ch) ((uint8_t)DMA1_Channel1_IRQn + (((DMA1_CH3) > 3) ? 2 : 
((DMA1_CH3) >> 1)))
#define DMA_IRQ_HANDLER(ch) (((ch) > DMA1_CH3) ? 
stm32_dma1_4_5_6_7_irq_handler : stm32_dma1_2_3_irq_handler)

extern DMA_HandleTypeDef *stm32_dma_ch[];
   ```
   
   
   
    hw/bus/drivers/spi_stm32/stm32wbxx/src/spidmacfg.c
   
   
   ```diff
   @@ -22,7 +22,7 @@
#include 

#define SPI_DMA_RX_CHANNEL_DEFINE(dma, ch, spi_num) 
\
   -const struct stm32_dma_cfg DMA ## dma ## _channel ## ch ## _spi ## 
spi_num ##_rx = { \
   +const struct stm32_dma_cfg DMA ## dma ## _channel ## ch ## _spi ## 
spi_num ## _rx = { \
DMA ## dma ## _CH ## ch,
\
DMA ## dma ## _Channel ## ch ## _IRQn,  
\
stm32_dma ## dma ## _ ## ch ## _irq_handler,
\
   @@ -40,7 +40,7 @@
}

#define SPI_DMA_TX_CHANNEL_DEFINE(dma, ch, spi_num) 
\
   -const struct stm32_dma_cfg DMA ## dma ## _channel ## ch ## _spi ## 
spi_num ##_tx = { \
   +const struct stm32_dma_cfg DMA ## dma ## _channel ## ch ## _spi ## 
spi_num ## _tx = { \
DMA ## dma ## _CH ## ch,
\
DMA ##

[GitHub] [mynewt-nimble] v01d commented on pull request #906: NuttX fixes

2021-02-05 Thread GitBox



v01d commented on pull request #906:
URL: https://github.com/apache/mynewt-nimble/pull/906#issuecomment-773359617


   sorry, I missed a small change, I just force pushed. The change I added is 
this:
   ```
   diff --git a/porting/npl/nuttx/src/os_callout.c 
b/porting/npl/nuttx/src/os_callout.c
   index fe12a8e3..e4580da9 100644
   --- a/porting/npl/nuttx/src/os_callout.c
   +++ b/porting/npl/nuttx/src/os_callout.c
   @@ -28,6 +28,10 @@

#include "nimble/nimble_npl.h"

   +#ifndef CONFIG_NIMBLE_CALLOUT_THREAD_STACKSIZE
   +#define CONFIG_NIMBLE_CALLOUT_THREAD_STACKSIZE 1024
   +#endif
   +
struct ble_npl_callout *pending_callout = NULL;

bool thread_started = false;
   @@ -81,7 +85,10 @@ ble_npl_callout_init(struct ble_npl_callout *c,
struct sigevent event;

if (!thread_started) {
   -pthread_create(_thread, NULL, callout_handler, NULL);
   +pthread_attr_t attr;
   +pthread_attr_init();
   +pthread_attr_setstacksize(, 
CONFIG_NIMBLE_CALLOUT_THREAD_STACKSIZE);
   +pthread_create(_thread, , callout_handler, NULL);
thread_started = true;
}

   diff --git a/porting/npl/nuttx/src/os_task.c 
b/porting/npl/nuttx/src/os_task.c
   index 2e020236..ab535a36 100644
   --- a/porting/npl/nuttx/src/os_task.c
   +++ b/porting/npl/nuttx/src/os_task.c
   @@ -60,8 +60,10 @@ ble_npl_task_init(struct ble_npl_task *t, const char 
*name, ble_npl_task_func_t
if (err) return err;
err = pthread_attr_getschedparam (>attr, >param);
if (err) return err;
   +#if CONFIG_RR_INTERVAL > 0
err = pthread_attr_setschedpolicy(>attr, SCHED_RR);
if (err) return err;
   +#endif
t->param.sched_priority = prio;
err = pthread_attr_setschedparam (>attr, >param);
if (err) return err;
   @@ -69,6 +71,11 @@ ble_npl_task_init(struct ble_npl_task *t, const char 
*name, ble_npl_task_func_t
t->name = name;
err = pthread_create(>handle, >attr, func, arg);

   +if (err == ENOMEM)
   +  {
   +err = OS_ENOMEM;
   +  }
   +
return err;
}
   ```
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #906: NuttX fixes

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #906:
URL: https://github.com/apache/mynewt-nimble/pull/906#issuecomment-773227350


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2468: hw/mcu/stm: Add missing ld file for nucleo-l073rz BSP

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2468:
URL: https://github.com/apache/mynewt-core/pull/2468#issuecomment-773084997


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] kasjer merged pull request #2463: hw/mcu/da1469x: Fix HAL UART creation

2021-02-05 Thread GitBox



kasjer merged pull request #2463:
URL: https://github.com/apache/mynewt-core/pull/2463


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] utzig merged pull request #2465: Update mbedTLS from 2.16.5 to 2.16.9

2021-02-05 Thread GitBox



utzig merged pull request #2465:
URL: https://github.com/apache/mynewt-core/pull/2465


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2459: net/osdp: Add OSDP library

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2459:
URL: https://github.com/apache/mynewt-core/pull/2459#issuecomment-773218592







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-772988534







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2461: stm32 spi bus driver

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2461:
URL: https://github.com/apache/mynewt-core/pull/2461#issuecomment-773090058


   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/bus/drivers/spi_stm32/src/spi_stm32.c
   
   
   ```diff
   @@ -66,15 +66,15 @@

#if MYNEWT_VAL(SPI_STM32_STAT)
STATS_SECT_START(spi_stm32_stats_section)
   -STATS_SECT_ENTRY(read_bytes)
   -STATS_SECT_ENTRY(written_bytes)
   -STATS_SECT_ENTRY(dma_transferred_bytes)
   +STATS_SECT_ENTRY(read_bytes)
   +STATS_SECT_ENTRY(written_bytes)
   +STATS_SECT_ENTRY(dma_transferred_bytes)
STATS_SECT_END

STATS_NAME_START(spi_stm32_stats_section)
   -STATS_NAME(spi_stm32_stats_section, read_bytes)
   -STATS_NAME(spi_stm32_stats_section, written_bytes)
   -STATS_NAME(spi_stm32_stats_section, dma_transferred_bytes)
   +STATS_NAME(spi_stm32_stats_section, read_bytes)
   +STATS_NAME(spi_stm32_stats_section, written_bytes)
   +STATS_NAME(spi_stm32_stats_section, dma_transferred_bytes)
STATS_NAME_END(spi_stm32_stats_section)
#endif

   ```
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] mlaz merged pull request #2466: mcu/nxp: Update NXP SDK and add Kinetis common HAL.

2021-02-05 Thread GitBox



mlaz merged pull request #2466:
URL: https://github.com/apache/mynewt-core/pull/2466


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] kasjer commented on pull request #2463: hw/mcu/da1469x: Fix HAL UART creation

2021-02-05 Thread GitBox



kasjer commented on pull request #2463:
URL: https://github.com/apache/mynewt-core/pull/2463#issuecomment-773107660


   > @kasjer LGTM. I tested with `HAL_UART: 1` and all works. There is a CI 
failure (style?). I approved but I'll wait for someone else to review the CI 
failure before merging.
   
   @benmccrea Right now CI fails due to missing linker script **stm32l073.ld** 
which has nothing to do with this PR. This happened while CI was not really 
working for a while. Pending #2468 addresses this problem.
   So I think we can merge this one.
   Tanks for testing it out.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc merged pull request #908: nimble/test: Fix LE SC tests

2021-02-05 Thread GitBox



sjanc merged pull request #908:
URL: https://github.com/apache/mynewt-nimble/pull/908


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #908: nimble/test: Fix LE SC tests

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #908:
URL: https://github.com/apache/mynewt-nimble/pull/908#issuecomment-772577803


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc merged pull request #906: NuttX fixes

2021-02-05 Thread GitBox



sjanc merged pull request #906:
URL: https://github.com/apache/mynewt-nimble/pull/906


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2466: mcu/nxp: Update NXP SDK and add Kinetis common HAL.

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2466:
URL: https://github.com/apache/mynewt-core/pull/2466#issuecomment-773567186







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] utzig commented on pull request #2466: mcu/nxp: Update NXP SDK and add Kinetis common HAL.

2021-02-05 Thread GitBox



utzig commented on pull request #2466:
URL: https://github.com/apache/mynewt-core/pull/2466#issuecomment-773691606


   @mlaz I am fine with this now, please force-push again to check if not RAT 
issues remain, for some reason it was no updating the message.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] vrahane commented on pull request #2456: Update lwip_base to LWIP 2.1.2

2021-02-05 Thread GitBox



vrahane commented on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-773202724


   Next step is merging it @jeremywood.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #906: NuttX fixes

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #906:
URL: https://github.com/apache/mynewt-nimble/pull/906#issuecomment-773227350







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2469: [mailmap] Revert to logging @apache.org

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2469:
URL: https://github.com/apache/mynewt-core/pull/2469#issuecomment-773490314


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2463: hw/mcu/da1469x: Fix HAL UART creation

2021-02-05 Thread GitBox



apache-mynewt-bot removed a comment on pull request #2463:
URL: https://github.com/apache/mynewt-core/pull/2463#issuecomment-772578023


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2465: Update mbedTLS from 2.16.5 to 2.16.9

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2465:
URL: https://github.com/apache/mynewt-core/pull/2465#issuecomment-773173219


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2470: [KINETIS] Turn pyocd into a reusable script

2021-02-05 Thread GitBox



apache-mynewt-bot commented on pull request #2470:
URL: https://github.com/apache/mynewt-core/pull/2470#issuecomment-773536998


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

65 matches

Mail list logo