[GitHub] [mynewt-nimble] KKopyscinski commented on a change in pull request #924: btshell/cmd.c: make strcpy in parse_dev_addr memory safe

2021-02-25 Thread GitBox
KKopyscinski commented on a change in pull request #924: URL: https://github.com/apache/mynewt-nimble/pull/924#discussion_r583442831 ## File path: apps/btshell/src/cmd.c ## @@ -99,7 +99,10 @@ parse_dev_addr(const char *prefix, const struct kv_pair *addr_types, char name[3

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #924: btshell/cmd.c: make strcpy in parse_dev_addr memory safe

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #924: URL: https://github.com/apache/mynewt-nimble/pull/924#issuecomment-786473711 ## Style check summary No suggestions at this time! This is an automat

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #924: btshell/cmd.c: make strcpy in parse_dev_addr memory safe

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #924: URL: https://github.com/apache/mynewt-nimble/pull/924#issuecomment-786472430 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #924: btshell/cmd.c: check string sizes before copy/concat operations

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #924: URL: https://github.com/apache/mynewt-nimble/pull/924#issuecomment-784876662 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #924: btshell/cmd.c: check string sizes before copy/concat operations

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #924: URL: https://github.com/apache/mynewt-nimble/pull/924#issuecomment-786472430 ## Style check summary No suggestions at this time! This is an automat

[GitHub] [mynewt-core] KKopyscinski merged pull request #2501: hw: handle hal_spi_enable/disable errors

2021-02-25 Thread GitBox
KKopyscinski merged pull request #2501: URL: https://github.com/apache/mynewt-core/pull/2501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[mynewt-core] branch master updated: hw: handle hal_spi_enable/disable errors hal_spi_enable/disable errors were handled, but not everywhere. This unifies handling manner.

2021-02-25 Thread kopyscinski
This is an automated email from the ASF dual-hosted git repository. kopyscinski pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 299b8ee hw: handle hal_spi_enable/dis

[GitHub] [mynewt-core] kasjer merged pull request #2505: mmc: Decrease mmc/sd initialization time

2021-02-25 Thread GitBox
kasjer merged pull request #2505: URL: https://github.com/apache/mynewt-core/pull/2505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[mynewt-core] branch master updated: mmc: Decrease mmc/sd initialization time

2021-02-25 Thread jerzy
This is an automated email from the ASF dual-hosted git repository. jerzy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 7362378 mmc: Decrease mmc/sd initialization

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2501: hw: handle hal_spi_enable/disable errors

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2501: URL: https://github.com/apache/mynewt-core/pull/2501#issuecomment-784977712 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2501: hw: handle hal_spi_enable/disable errors

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2501: URL: https://github.com/apache/mynewt-core/pull/2501#issuecomment-786441495 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/

[GitHub] [mynewt-core] KKopyscinski commented on a change in pull request #2501: hw: handle hal_spi_enable/disable errors

2021-02-25 Thread GitBox
KKopyscinski commented on a change in pull request #2501: URL: https://github.com/apache/mynewt-core/pull/2501#discussion_r583409470 ## File path: hw/drivers/flash/at45db/src/at45db.c ## @@ -446,7 +446,10 @@ at45db_init(const struct hal_flash *hal_flash_dev) } hal_s

[GitHub] [mynewt-core] utzig merged pull request #2478: Add more Mbed TLS alt implementations support

2021-02-25 Thread GitBox
utzig merged pull request #2478: URL: https://github.com/apache/mynewt-core/pull/2478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[mynewt-core] branch master updated (9ea6df6 -> c061b58)

2021-02-25 Thread utzig
This is an automated email from the ASF dual-hosted git repository. utzig pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 9ea6df6 sensor_shell: return error in sensor_cmd_notify if no sensor found new 05a15a2 crypto: mbedtls: a

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2478: Allow Mbed TLS ECP code to use alt implementations

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2478: URL: https://github.com/apache/mynewt-core/pull/2478#issuecomment-786135188 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2478: Allow Mbed TLS ECP code to use alt implementations

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2478: URL: https://github.com/apache/mynewt-core/pull/2478#issuecomment-786136149 ## Style check summary No suggestions at this time! This is an automat

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2478: Allow Mbed TLS ECP code to use alt implementations

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2478: URL: https://github.com/apache/mynewt-core/pull/2478#issuecomment-786131280 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2478: Allow Mbed TLS ECP code to use alt implementations

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2478: URL: https://github.com/apache/mynewt-core/pull/2478#issuecomment-786135188 ## Style check summary No suggestions at this time! This is an automat

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2478: Allow Mbed TLS ECP code to use alt implementations

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2478: URL: https://github.com/apache/mynewt-core/pull/2478#issuecomment-786131280 ## Style check summary No suggestions at this time! This is an automat

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2478: Allow Mbed TLS ECP code to use alt implementations

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2478: URL: https://github.com/apache/mynewt-core/pull/2478#issuecomment-777529332 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #924: btshell/cmd.c: check string sizes before copy/concat operations

2021-02-25 Thread GitBox
sjanc commented on a change in pull request #924: URL: https://github.com/apache/mynewt-nimble/pull/924#discussion_r581818538 ## File path: apps/btshell/src/cmd.c ## @@ -99,7 +99,10 @@ parse_dev_addr(const char *prefix, const struct kv_pair *addr_types, char name[32];

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785977418 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785970022 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785970022 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785966624 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785949782 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785966624 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785949782 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785945079 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785921849 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785945079 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785921849 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785761301 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2505: mmc: Decrease mmc/sd initialization time

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2505: URL: https://github.com/apache/mynewt-core/pull/2505#issuecomment-785848986 ## Style check summary No suggestions at this time! This is an automat

[mynewt-core] branch master updated: sensor_shell: return error in sensor_cmd_notify if no sensor found

2021-02-25 Thread kopyscinski
This is an automated email from the ASF dual-hosted git repository. kopyscinski pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 9ea6df6 sensor_shell: return error in

[GitHub] [mynewt-core] KKopyscinski merged pull request #2504: sensor_shell: return error in sensor_cmd_notify if no sensor found

2021-02-25 Thread GitBox
KKopyscinski merged pull request #2504: URL: https://github.com/apache/mynewt-core/pull/2504 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [mynewt-core] kasjer opened a new pull request #2505: mmc: Decrease mmc/sd initialization time

2021-02-25 Thread GitBox
kasjer opened a new pull request #2505: URL: https://github.com/apache/mynewt-core/pull/2505 SD specification section "6.4.1 Power Up" requires 74 clocks with high CS. Code was sending 592 clocks (it was sending 74 bytes). Now code sends 10 bytes (80 cycles). -

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2504: sensor_shell: return error in sensor_cmd_notify if no sensor found

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2504: URL: https://github.com/apache/mynewt-core/pull/2504#issuecomment-785833847 ## Style check summary No suggestions at this time! This is an automat

[GitHub] [mynewt-core] KKopyscinski opened a new pull request #2504: sensor_shell: return error in sensor_cmd_notify if no sensor found

2021-02-25 Thread GitBox
KKopyscinski opened a new pull request #2504: URL: https://github.com/apache/mynewt-core/pull/2504 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2501: hw: handle hal_spi_enable/disable errors

2021-02-25 Thread GitBox
kasjer commented on a change in pull request #2501: URL: https://github.com/apache/mynewt-core/pull/2501#discussion_r582683525 ## File path: hw/drivers/flash/at45db/src/at45db.c ## @@ -446,7 +446,10 @@ at45db_init(const struct hal_flash *hal_flash_dev) } hal_spi_set

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785761301 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2499: [WIP] Fixes for Coverity issues

2021-02-25 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2499: URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-785042952 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[mynewt-core] branch master updated (3f49303 -> 7b63b59)

2021-02-25 Thread kopyscinski
This is an automated email from the ASF dual-hosted git repository. kopyscinski pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 3f49303 Merge pull request #2496 from benmccrea/console-restore-echo-setting add 7b63b59 sensor_cre

[GitHub] [mynewt-core] KKopyscinski merged pull request #2503: sensor_creator: initialize sensor configs with zeros

2021-02-25 Thread GitBox
KKopyscinski merged pull request #2503: URL: https://github.com/apache/mynewt-core/pull/2503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2503: sensor_creator: initialize sensor configs with zeros

2021-02-25 Thread GitBox
apache-mynewt-bot commented on pull request #2503: URL: https://github.com/apache/mynewt-core/pull/2503#issuecomment-785755207 ## Style check summary No suggestions at this time! This is an automat

[GitHub] [mynewt-core] KKopyscinski opened a new pull request #2503: sensor_creator: initialize sensor configs with zeros

2021-02-25 Thread GitBox
KKopyscinski opened a new pull request #2503: URL: https://github.com/apache/mynewt-core/pull/2503 Some default sensor configurations have uninitialized member fields, which later were used as value to set in [sensor_name]_config(). Now all values are 0 by default, and non-zero values