[GitHub] [mynewt-core] vrahane merged pull request #2540: mcu/nrf5340: Fix spi device names
vrahane merged pull request #2540: URL: https://github.com/apache/mynewt-core/pull/2540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] branch master updated: mcu/nrf5340: Fix spi device names
This is an automated email from the ASF dual-hosted git repository.
vipulrahane pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 2f52b9f mcu/nrf5340: Fix spi device names
new 88323a5 Merge pull request #2540 from
vikrant-proxy/nrf53/spi-periph-fix
2f52b9f is described below
commit 2f52b9fe4377c1bb0159b32bdfa384272d7db0d7
Author: Vikrant More
AuthorDate: Thu Mar 18 23:36:28 2021 -0700
mcu/nrf5340: Fix spi device names
---
hw/mcu/nordic/nrf5340/src/hal_spi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/mcu/nordic/nrf5340/src/hal_spi.c
b/hw/mcu/nordic/nrf5340/src/hal_spi.c
index 81e5464..ded7bc6 100644
--- a/hw/mcu/nordic/nrf5340/src/hal_spi.c
+++ b/hw/mcu/nordic/nrf5340/src/hal_spi.c
@@ -294,7 +294,7 @@ nrf5340_spi3_irq_handler(void)
{
os_trace_isr_enter();
if (nrf5340_hal_spi3.spi_type == HAL_SPI_TYPE_MASTER) {
-#if MYNEWT_VAL(SPI_2_MASTER)
+#if MYNEWT_VAL(SPI_3_MASTER)
nrf5340_irqm_handler(&nrf5340_hal_spi3);
#endif
} else {
@@ -311,8 +311,8 @@ void
nrf5340_spi4_irq_handler(void)
{
os_trace_isr_enter();
-if (nrf5340_hal_spi3.spi_type == HAL_SPI_TYPE_MASTER) {
-nrf5340_irqm_handler(&nrf5340_hal_spi3);
+if (nrf5340_hal_spi4.spi_type == HAL_SPI_TYPE_MASTER) {
+nrf5340_irqm_handler(&nrf5340_hal_spi4);
}
os_trace_isr_exit();
}
[GitHub] [mynewt-core] vikrant-proxy opened a new pull request #2540: mcu/nrf5340: Fix spi device names
vikrant-proxy opened a new pull request #2540: URL: https://github.com/apache/mynewt-core/pull/2540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski edited a comment on pull request #941: ble_sm: add Secure Connections Only mode
KKopyscinski edited a comment on pull request #941:
URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-802592107
Tests GAP/SEC/SEM-BI-{20-23}-C require security mode described as "Security
Mode 1 Level 2/3 with LE
Secure Connections Pairing only", level depending on test. For now, Secure
Connections Pairing Only mode is implemented as described in BT Core
Specification, Version 5.2, Vol 3, Part C 10.2.4 Secure Connections Only mode.
These tests pass with SC Only enabled with level 4, as they just check if key
is not shorter than 16 bytes, by checking if pairing fails for keys 7-15 bytes
long. I wonder how consistent these specs really are? Do these tests just check
if MITM flag has influence on pairing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #941: ble_sm: add Secure Connections Only mode
KKopyscinski commented on pull request #941:
URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-802592107
Tests GAP/SEC/SEM-BI-{20-23}-C require security mode described as "Security
Mode 1 Level 2/3 with LE
Secure Connections Pairing only", level depending on test. For now, Secure
Connections Pairing Only mode is implemented as described in BT Core
Specification, Version 5.2, Vol 3, Part C 10.2.4 Secure Connections Only mode.
These tests pass with SC Only enabled with level 4, as they just check if key
is not shorter than 16 bytes, by checking if pairing fails for keys 7-15 bytes
long. I wonder how consistent these specs really are?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] ncasaril commented on issue #940: blehci-usb app fails on assert when trying to upload an image using newtmgr
ncasaril commented on issue #940: URL: https://github.com/apache/mynewt-nimble/issues/940#issuecomment-802498625 Tweaking a buffer size in tinyusb is a workaround: https://github.com/hathach/tinyusb/blob/6cf110b5d0efc8556fbb7aeabef583d8c000ae4b/src/class/bth/bth_device.h#L39 This value needs to be bigger than the MTU with a margin or newtmgr will fail to upload. Could this be an issue with fragmenting the data over usb that's not taken care of in the bth_device? Tagging @kasjer as he's named in bth_device.c. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2538: hw/util/buzzer: Tone generator with the PWM peripheral
apache-mynewt-bot commented on pull request #2538:
URL: https://github.com/apache/mynewt-core/pull/2538#issuecomment-802401394
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2538: hw/util/buzzer: Tone generator with the PWM peripheral
apache-mynewt-bot removed a comment on pull request #2538:
URL: https://github.com/apache/mynewt-core/pull/2538#issuecomment-801861212
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2539: Add QSPI for NRF5340
vrahane commented on pull request #2539: URL: https://github.com/apache/mynewt-core/pull/2539#issuecomment-802398005 @kasjer There are some coding style fixes, not sure if we want to do those considering some of this stuff is from ARM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on a change in pull request #2538: hw/util/buzzer: Tone generator with the PWM peripheral
vrahane commented on a change in pull request #2538: URL: https://github.com/apache/mynewt-core/pull/2538#discussion_r596922717 ## File path: apps/buzzer/beep/pkg.yml ## @@ -17,7 +17,7 @@ # under the License. # -pkg.name: apps/beep +pkg.name: apps/buzzer/beep Review comment: I think you should just call it apps/buzzer and place the app under it as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #941: ble_sm: add Secure Connections Only mode
apache-mynewt-bot removed a comment on pull request #941:
URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-801890438
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #941: ble_sm: add Secure Connections Only mode
apache-mynewt-bot commented on pull request #941:
URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-801920937
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2539: Add QSPI for NRF5340
apache-mynewt-bot commented on pull request #2539:
URL: https://github.com/apache/mynewt-core/pull/2539#issuecomment-801916378
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
hw/mcu/nordic/nrf5340/src/system_nrf5340.c
```diff
@@ -1,24 +1,24 @@
/*
-Copyright (c) 2009-2020 ARM Limited. All rights reserved.
+ Copyright (c) 2009-2020 ARM Limited. All rights reserved.
SPDX-License-Identifier: Apache-2.0
-Licensed under the Apache License, Version 2.0 (the License); you may
-not use this file except in compliance with the License.
-You may obtain a copy of the License at
+ Licensed under the Apache License, Version 2.0 (the License); you may
+ not use this file except in compliance with the License.
+ You may obtain a copy of the License at
www.apache.org/licenses/LICENSE-2.0
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an AS IS BASIS, WITHOUT
-WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-
-NOTICE: This file has been modified by Nordic Semiconductor ASA.
-
-*/
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an AS IS BASIS, WITHOUT
+ WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+ NOTICE: This file has been modified by Nordic Semiconductor ASA.
+
+ */
/* NOTE: Template files (including this one) are application specific and
therefore expected to
be copied into the application project folder prior to its use! */
@@ -68,181 +69,172 @@
#endif
}
-void SystemInit(void)
+void
+SystemInit(void)
{
#if !defined(NRF_TRUSTZONE_NONSECURE)
-/* Perform Secure-mode initialization routines. */
-
-/* Set all ARM SAU regions to NonSecure if TrustZone extensions are
enabled.
-* Nordic SPU should handle Secure Attribution tasks */
+/* Perform Secure-mode initialization routines. */
+
+/* Set all ARM SAU regions to NonSecure if TrustZone extensions are
enabled.
+ * Nordic SPU should handle Secure Attribution tasks */
#if defined (__ARM_FEATURE_CMSE) && (__ARM_FEATURE_CMSE == 3U)
- SAU->CTRL |= (1 << SAU_CTRL_ALLNS_Pos);
-#endif
-
-/* Workaround for Errata 97 "ERASEPROTECT, APPROTECT, or startup
problems" found at the Errata document
- for your device located at
https://infocenter.nordicsemi.com/index.jsp */
-if (nrf53_errata_97())
-{
-if (*((volatile uint32_t *)0x50004A20ul) == 0)
-{
-*((volatile uint32_t *)0x50004A20ul) = 0xDul;
-*((volatile uint32_t *)0x5000491Cul) = 0x1ul;
-*((volatile uint32_t *)0x5000491Cul) = 0x0ul;
-}
+SAU->CTRL |= (1 << SAU_CTRL_ALLNS_Pos);
+#endif
+
+/* Workaround for Errata 97 "ERASEPROTECT, APPROTECT, or startup
problems" found at the Errata document
+ for your device located at
https://infocenter.nordicsemi.com/index.jsp */
+if (nrf53_errata_97()) {
+if (*((volatile uint32_t *)0x50004A20ul) == 0) {
+*((volatile uint32_t *)0x50004A20ul) = 0xDul;
+*((volatile uint32_t *)0x5000491Cul) = 0x1ul;
+*((volatile uint32_t *)0x5000491Cul) = 0x0ul;
}
-
-/* Trimming of the device. Copy all the trimming values from FICR
into the target addresses. Trim
- until one ADDR is not initialized. */
-uint32_t index = 0;
-for (index = 0; index < 32ul && NRF_FICR_S->TRIMCNF[index].ADDR !=
(uint32_t *)0xul; index++){
-#if defined ( __ICCARM__ )
-/* IAR will complain about the order of volatile pointer
accesses. */
+}
+
+/* Trimming of the device. Copy all the trimming values from FICR into
the target addresses. Trim
+ until one ADDR is not initialized. */
+uint32_t index = 0;
+for (index = 0; index < 32ul && NRF_FICR_S->TRIMCNF[index].ADDR !=
(uint32_t *)0xul; index++) {
+#if defined (__ICCARM__)
+/* IAR will complain about the order of volatile pointer accesses.
*/
#pragma diag_suppress=Pa082
#endif
-*NRF_FICR_S->TRIMCNF[index].ADDR =
NRF_FICR_S->TRIMCNF[index].DATA;
-#if defined ( __ICCARM__ )
+*NRF_FICR_S->TRIMCNF[ind
[GitHub] [mynewt-core] kasjer opened a new pull request #2539: Add QSPI for NRF5340
kasjer opened a new pull request #2539: URL: https://github.com/apache/mynewt-core/pull/2539 This PR adds: - hal for QSPI - QSPI flasd device in pca10095 bsp bsp.yml is not yet modified to have this flash used for any purpose. It is possible to move slot 1 to this external flash. Encryption is not implemented yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #941: ble_sm: add Secure Connections Only mode
apache-mynewt-bot removed a comment on pull request #941:
URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-801883954
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #941: ble_sm: add Secure Connections Only mode
apache-mynewt-bot commented on pull request #941:
URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-801890438
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #941: ble_sm: add Secure Connections Only mode
apache-mynewt-bot commented on pull request #941:
URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-801883954
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request #941: ble_sm: add Secure Connections Only mode
KKopyscinski opened a new pull request #941: URL: https://github.com/apache/mynewt-nimble/pull/941 Added mode allowing to enforce pairing only in SC mode 1 level 4. This mode is required to pass GAP/SEC/SEM/BI testcases. Added BLE_SM_SC_LVL config to allow pairing only in selected levels. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2538: hw/util/buzzer: Tone generator with the PWM peripheral
apache-mynewt-bot commented on pull request #2538:
URL: https://github.com/apache/mynewt-core/pull/2538#issuecomment-801861212
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2538: hw/util/buzzer: Tone generator with the PWM peripheral
apache-mynewt-bot removed a comment on pull request #2538:
URL: https://github.com/apache/mynewt-core/pull/2538#issuecomment-801561674
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski closed pull request #939: sm: fail pairing in SC only mode if keysize is less than 128 bit
KKopyscinski closed pull request #939: URL: https://github.com/apache/mynewt-nimble/pull/939 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #939: sm: fail pairing in SC only mode if keysize is less than 128 bit
KKopyscinski commented on pull request #939: URL: https://github.com/apache/mynewt-nimble/pull/939#issuecomment-801849271 This is not fully compatible with both Bluetooth and test specs. I close it for now, as solving the issue requires different approach This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] utzig merged pull request #2534: doc: Fix post_link_cmds newt extcmd documentation
utzig merged pull request #2534: URL: https://github.com/apache/mynewt-core/pull/2534 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] branch master updated: doc: Fix post_link_cmds newt extcmd documentation
This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 7cbaf03 doc: Fix post_link_cmds newt extcmd documentation new e245901 Merge pull request #2534 from utzig/fix-post-link-doc 7cbaf03 is described below commit 7cbaf0371b4a7d39aa4fa652c111521f7a902bf6 Author: Fabio Utzig AuthorDate: Tue Mar 16 13:14:58 2021 -0300 doc: Fix post_link_cmds newt extcmd documentation The `post_build_cmds` step was renamed to `post_link_cmds` with https://github.com/apache/mynewt-newt/commit/39005b80a6a034244061898c1b610dd7e4e34a36 Fix extcmd documentation appropriately. Signed-off-by: Fabio Utzig --- docs/os/modules/extcmd/extcmd.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/os/modules/extcmd/extcmd.rst b/docs/os/modules/extcmd/extcmd.rst index 3ee98bf..0e752c5 100644 --- a/docs/os/modules/extcmd/extcmd.rst +++ b/docs/os/modules/extcmd/extcmd.rst @@ -6,7 +6,7 @@ three types of commands: 1. pre_build_cmds (run before the build) 2. pre_link_cmds (run after compilation, before linking) -3. post_build_cmds (run after the build) +3. post_link_cmds (run after linking) Example ~~~ @@ -22,8 +22,8 @@ Example (apps/blinky/pkg.yml): pkg.pre_link_cmds: scripts/pre_link.sh: 500 -pkg.post_build_cmds: -scripts/post_build.sh: 100 +pkg.post_link_cmds: +scripts/post_link.sh: 100 For each command, the string on the left specifies the command to run. @@ -37,7 +37,7 @@ When newt builds this example, it performs the following sequence: - [compile] - scripts/pre_link.sh - [link] -- scripts/post_build.sh +- scripts/post_link.sh If other packages specify custom commands, those commands would also be executed during the above sequence. For example, if another package
[GitHub] [mynewt-core] kasjer merged pull request #2536: Update NRFX to release 2.4.0
kasjer merged pull request #2536: URL: https://github.com/apache/mynewt-core/pull/2536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] andrzej-kaczmarek commented on pull request #2538: hw/drivers/buzzer: Tone generator with the PWM peripheral
andrzej-kaczmarek commented on pull request #2538: URL: https://github.com/apache/mynewt-core/pull/2538#issuecomment-801685510 imo this should be `hw/util/buzzer` since it's not a driver for a specific device This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
