[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DR
apache-mynewt-bot removed a comment on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820390986
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
apache-mynewt-bot commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820678141
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
vrahane commented on pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820623728 @utzig done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
utzig commented on pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820617171 > @utzig your are right, I did push to origin by mistake and then deleted it right after. The recent commits should fix that I guess. Looks like it did, seems to require a rebase to sync with Travis again, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
vrahane commented on pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820616250 @utzig your are right, I did push to origin by mistake and then deleted it right after. The recent commits should fix that I guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on a change in pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
vrahane commented on a change in pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#discussion_r614273425
##
File path: hw/mcu/nordic/nrf5340/src/hal_system.c
##
@@ -72,6 +81,7 @@ hal_debugger_connected(void)
void
hal_system_clock_start(void)
{
+
Review comment:
done
##
File path: hw/mcu/nordic/nrf5340/src/hal_system.c
##
@@ -36,6 +36,15 @@
void
hal_system_init(void)
{
+
Review comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[mynewt-core] branch aditihilbert-patch-1 created (now 34755c4)
This is an automated email from the ASF dual-hosted git repository. utzig pushed a change to branch aditihilbert-patch-1 in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. at 34755c4 Update newtmgr.h No new revisions were added by this update.
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #963: targets: Add sample target for controller on NRF5340 bsp
apache-mynewt-bot commented on pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-820444879
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #963: targets: Add sample target for controller on NRF5340 bsp
apache-mynewt-bot removed a comment on pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-816570593
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[mynewt-site] branch asf-site updated: asf-site update Thu Apr 15 13:36:47 UTC 2021
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/mynewt-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 24ac7ca asf-site update Thu Apr 15 13:36:47 UTC 2021 24ac7ca is described below commit 24ac7ca2651ee28cb6ce63b83537a96ca255a21c Author: jenkins AuthorDate: Thu Apr 15 13:36:47 2021 + asf-site update Thu Apr 15 13:36:47 UTC 2021 --- sitemap.xml.gz| Bin 282 -> 282 bytes v0_9_0/sitemap.xml.gz | Bin 2210 -> 2210 bytes v1_0_0/sitemap.xml.gz | Bin 3217 -> 3217 bytes v1_1_0/sitemap.xml.gz | Bin 3446 -> 3446 bytes v1_2_0/sitemap.xml.gz | Bin 3469 -> 3469 bytes v1_3_0/sitemap.xml.gz | Bin 3467 -> 3467 bytes 6 files changed, 0 insertions(+), 0 deletions(-) diff --git a/sitemap.xml.gz b/sitemap.xml.gz index bb78fef..093f669 100644 Binary files a/sitemap.xml.gz and b/sitemap.xml.gz differ diff --git a/v0_9_0/sitemap.xml.gz b/v0_9_0/sitemap.xml.gz index 82c7ac8..21895f9 100644 Binary files a/v0_9_0/sitemap.xml.gz and b/v0_9_0/sitemap.xml.gz differ diff --git a/v1_0_0/sitemap.xml.gz b/v1_0_0/sitemap.xml.gz index cc763f0..8429306 100644 Binary files a/v1_0_0/sitemap.xml.gz and b/v1_0_0/sitemap.xml.gz differ diff --git a/v1_1_0/sitemap.xml.gz b/v1_1_0/sitemap.xml.gz index df9d054..e95702f 100644 Binary files a/v1_1_0/sitemap.xml.gz and b/v1_1_0/sitemap.xml.gz differ diff --git a/v1_2_0/sitemap.xml.gz b/v1_2_0/sitemap.xml.gz index 53b6518..ab89102 100644 Binary files a/v1_2_0/sitemap.xml.gz and b/v1_2_0/sitemap.xml.gz differ diff --git a/v1_3_0/sitemap.xml.gz b/v1_3_0/sitemap.xml.gz index 7b099c2..44a6821 100644 Binary files a/v1_3_0/sitemap.xml.gz and b/v1_3_0/sitemap.xml.gz differ
[mynewt-site] 04/05: asf-site update Thu Apr 15 11:49:11 UTC 2021
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/mynewt-site.git commit 491f2aa20713beb162af14c55b052c680c3727b9 Author: jenkins AuthorDate: Thu Apr 15 11:49:11 2021 + asf-site update Thu Apr 15 11:49:11 UTC 2021 --- sitemap.xml.gz| Bin 282 -> 282 bytes v0_9_0/sitemap.xml.gz | Bin 2210 -> 2210 bytes v1_0_0/sitemap.xml.gz | Bin 3217 -> 3217 bytes v1_1_0/sitemap.xml.gz | Bin 3446 -> 3446 bytes v1_2_0/sitemap.xml.gz | Bin 3469 -> 3469 bytes v1_3_0/sitemap.xml.gz | Bin 3467 -> 3467 bytes 6 files changed, 0 insertions(+), 0 deletions(-) diff --git a/sitemap.xml.gz b/sitemap.xml.gz index 9ce6887..4664d1b 100644 Binary files a/sitemap.xml.gz and b/sitemap.xml.gz differ diff --git a/v0_9_0/sitemap.xml.gz b/v0_9_0/sitemap.xml.gz index f7292f1..73ab487 100644 Binary files a/v0_9_0/sitemap.xml.gz and b/v0_9_0/sitemap.xml.gz differ diff --git a/v1_0_0/sitemap.xml.gz b/v1_0_0/sitemap.xml.gz index aba4537..91fe1aa 100644 Binary files a/v1_0_0/sitemap.xml.gz and b/v1_0_0/sitemap.xml.gz differ diff --git a/v1_1_0/sitemap.xml.gz b/v1_1_0/sitemap.xml.gz index 8ce1048..d5965db 100644 Binary files a/v1_1_0/sitemap.xml.gz and b/v1_1_0/sitemap.xml.gz differ diff --git a/v1_2_0/sitemap.xml.gz b/v1_2_0/sitemap.xml.gz index 035e8ea..be05fcb 100644 Binary files a/v1_2_0/sitemap.xml.gz and b/v1_2_0/sitemap.xml.gz differ diff --git a/v1_3_0/sitemap.xml.gz b/v1_3_0/sitemap.xml.gz index 52ee05a..156c820 100644 Binary files a/v1_3_0/sitemap.xml.gz and b/v1_3_0/sitemap.xml.gz differ
[mynewt-site] 05/05: asf-site update Thu Apr 15 13:30:18 UTC 2021
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/mynewt-site.git commit b603985d792739fb992e63300fe460633ec18d31 Author: jenkins AuthorDate: Thu Apr 15 13:30:18 2021 + asf-site update Thu Apr 15 13:30:18 UTC 2021 --- sitemap.xml.gz| Bin 282 -> 282 bytes v0_9_0/sitemap.xml.gz | Bin 2210 -> 2210 bytes v1_0_0/sitemap.xml.gz | Bin 3217 -> 3217 bytes v1_1_0/sitemap.xml.gz | Bin 3446 -> 3446 bytes v1_2_0/sitemap.xml.gz | Bin 3469 -> 3469 bytes v1_3_0/sitemap.xml.gz | Bin 3467 -> 3467 bytes 6 files changed, 0 insertions(+), 0 deletions(-) diff --git a/sitemap.xml.gz b/sitemap.xml.gz index 4664d1b..bb78fef 100644 Binary files a/sitemap.xml.gz and b/sitemap.xml.gz differ diff --git a/v0_9_0/sitemap.xml.gz b/v0_9_0/sitemap.xml.gz index 73ab487..82c7ac8 100644 Binary files a/v0_9_0/sitemap.xml.gz and b/v0_9_0/sitemap.xml.gz differ diff --git a/v1_0_0/sitemap.xml.gz b/v1_0_0/sitemap.xml.gz index 91fe1aa..cc763f0 100644 Binary files a/v1_0_0/sitemap.xml.gz and b/v1_0_0/sitemap.xml.gz differ diff --git a/v1_1_0/sitemap.xml.gz b/v1_1_0/sitemap.xml.gz index d5965db..df9d054 100644 Binary files a/v1_1_0/sitemap.xml.gz and b/v1_1_0/sitemap.xml.gz differ diff --git a/v1_2_0/sitemap.xml.gz b/v1_2_0/sitemap.xml.gz index be05fcb..53b6518 100644 Binary files a/v1_2_0/sitemap.xml.gz and b/v1_2_0/sitemap.xml.gz differ diff --git a/v1_3_0/sitemap.xml.gz b/v1_3_0/sitemap.xml.gz index 156c820..7b099c2 100644 Binary files a/v1_3_0/sitemap.xml.gz and b/v1_3_0/sitemap.xml.gz differ
[mynewt-site] branch asf-site updated (ff03e69 -> b603985)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/mynewt-site.git. discard ff03e69 asf-site update Thu Apr 15 11:54:27 UTC 2021 discard dc67019 asf-site update Wed Apr 14 23:10:35 UTC 2021 new f37 asf-site update Wed Apr 14 22:00:17 UTC 2021 new 79bc20e asf-site update Thu Apr 15 09:32:18 UTC 2021 new cfb7a20 asf-site update Thu Apr 15 11:43:08 UTC 2021 new 491f2aa asf-site update Thu Apr 15 11:49:11 UTC 2021 new b603985 asf-site update Thu Apr 15 13:30:18 UTC 2021 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (ff03e69) \ N -- N -- N refs/heads/asf-site (b603985) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 5 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: download/index.html| 3 +- index.html | 94 +++ known_issues/index.html| 6 +- master/_sources/newt/install/newt_linux.rst.txt| 16 +- master/_static/pygments.css| 7 +- master/network/ble_setup/ble_sync_cb.html | 10 +- master/newt/install/newt_linux.html| 16 +- master/os/core_os/event_queue/event_queue.html | 4 +- master/os/core_os/mbuf/mbuf.html | 38 +-- master/os/core_os/memory_pool/memory_pool.html | 2 +- master/os/core_os/mynewt_os.html | 10 +- master/os/core_os/porting/port_bsp.html| 4 +- master/os/core_os/sanity/sanity.html | 20 +- master/os/core_os/task/task.html | 2 +- master/os/core_os/time/os_time.html| 12 +- master/os/modules/bootloader/bootloader.html | 8 +- master/os/modules/config/config.html | 12 +- master/os/modules/console/console.html | 26 +- master/os/modules/drivers/chg_ctrl/chg_ctrl.html | 8 +- master/os/modules/drivers/chg_ctrl/sgm4056.html| 8 +- master/os/modules/drivers/flash.html | 26 +- master/os/modules/drivers/mmc.html | 2 +- master/os/modules/fcb/fcb.html | 14 +- master/os/modules/fs/fs.html | 34 +-- master/os/modules/fs/otherfs.html | 2 +- master/os/modules/hal/hal_spi/hal_spi.html | 4 +- master/os/modules/hal/hal_timer/hal_timer.html | 2 +- master/os/modules/json/json.html | 20 +- master/os/modules/logs/logs.html | 8 +- master/os/modules/sensor_framework/sensor_api.html | 16 +- .../os/modules/sensor_framework/sensor_create.html | 14 +- .../os/modules/sensor_framework/sensor_driver.html | 30 +-- .../sensor_framework/sensor_listener_api.html | 2 +- master/os/modules/shell/shell.html | 10 +- master/searchindex.js | 2 +- .../ble/bleprph/bleprph-sections/bleprph-adv.html | 8 +- .../bleprph-sections/bleprph-chr-access.html | 12 +- .../bleprph-sections/bleprph-gap-event.html| 4 +- .../bleprph/bleprph-sections/bleprph-svc-reg.html | 6 +- master/tutorials/ble/eddystone.html| 26 +- master/tutorials/ble/ibeacon.html | 16 +- master/tutorials/blinky/blinky_console.html| 6 +- master/tutorials/os_fundamentals/event_queue.html | 62 ++--- master/tutorials/os_fundamentals/tasks_lesson.html | 8 +- master/tutorials/other/chg_ctrl_on_pinetime.html | 12 +- master/tutorials/other/unit_test.html | 6 +- master/tutorials/sensors/air_quality_ble.html | 20 +- master/tutorials/sensors/air_quality_sensor.html | 52 ++-- master/tutorials/sensors/nrf52_adc.html| 26 +- master/tutorials/sensors/sensor_bleprph_oic.html | 6 +- .../tutorials/sensors/sensor_offboard_config.html | 24 +- .../sensors/sensor_thingy_lis2dh12_onb.html| 18 +- sitemap.xml.gz | Bin 282 -> 282 bytes v0_9_0/download/index.html | 9 +- v0_9_0/faq/answers/index.html | 12 +- v0_9_0/faq/how_to_edit_docs/index.html
[mynewt-site] 01/05: asf-site update Wed Apr 14 22:00:17 UTC 2021
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/mynewt-site.git commit f37fd18887998859cf89a67aff283f4c3166 Author: jenkins AuthorDate: Wed Apr 14 22:00:17 2021 + asf-site update Wed Apr 14 22:00:17 UTC 2021 --- sitemap.xml.gz| Bin 284 -> 284 bytes v0_9_0/sitemap.xml.gz | Bin 2216 -> 2216 bytes v1_0_0/sitemap.xml.gz | Bin 3239 -> 3239 bytes v1_1_0/sitemap.xml.gz | Bin 3464 -> 3464 bytes v1_2_0/sitemap.xml.gz | Bin 3487 -> 3487 bytes v1_3_0/sitemap.xml.gz | Bin 3483 -> 3483 bytes 6 files changed, 0 insertions(+), 0 deletions(-) diff --git a/sitemap.xml.gz b/sitemap.xml.gz index adb0efc..2058ee3 100644 Binary files a/sitemap.xml.gz and b/sitemap.xml.gz differ diff --git a/v0_9_0/sitemap.xml.gz b/v0_9_0/sitemap.xml.gz index 6109b36..9abeb49 100644 Binary files a/v0_9_0/sitemap.xml.gz and b/v0_9_0/sitemap.xml.gz differ diff --git a/v1_0_0/sitemap.xml.gz b/v1_0_0/sitemap.xml.gz index f8e1529..7661056 100644 Binary files a/v1_0_0/sitemap.xml.gz and b/v1_0_0/sitemap.xml.gz differ diff --git a/v1_1_0/sitemap.xml.gz b/v1_1_0/sitemap.xml.gz index bf19791..cc2f1f1 100644 Binary files a/v1_1_0/sitemap.xml.gz and b/v1_1_0/sitemap.xml.gz differ diff --git a/v1_2_0/sitemap.xml.gz b/v1_2_0/sitemap.xml.gz index 4e83284..fd729a5 100644 Binary files a/v1_2_0/sitemap.xml.gz and b/v1_2_0/sitemap.xml.gz differ diff --git a/v1_3_0/sitemap.xml.gz b/v1_3_0/sitemap.xml.gz index dc79f75..8268316 100644 Binary files a/v1_3_0/sitemap.xml.gz and b/v1_3_0/sitemap.xml.gz differ
[GitHub] [mynewt-core] sjanc merged pull request #2562: hw/ipc_nrf5340: Allow sending data in fragments
sjanc merged pull request #2562: URL: https://github.com/apache/mynewt-core/pull/2562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] branch master updated: hw/ipc_nrf5340: Allow sending data in fragments
This is an automated email from the ASF dual-hosted git repository.
janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 716f6f1 hw/ipc_nrf5340: Allow sending data in fragments
716f6f1 is described below
commit 716f6f16e8aa8439d4f791d04973cd4c20b35095
Author: Szymon Janc
AuthorDate: Mon Apr 12 17:39:47 2021 +0200
hw/ipc_nrf5340: Allow sending data in fragments
This allows to send data over IPC in fragments. Previously data size
was limited to IPC buffer size. In extreme case IPC buffer can now have
size of 2, although this may result in excessive number of interrupts.
---
.../ipc_nrf5340/include/ipc_nrf5340/ipc_nrf5340.h | 3 +-
hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c | 44 ++
hw/drivers/ipc_nrf5340/syscfg.yml | 1 +
3 files changed, 32 insertions(+), 16 deletions(-)
diff --git a/hw/drivers/ipc_nrf5340/include/ipc_nrf5340/ipc_nrf5340.h
b/hw/drivers/ipc_nrf5340/include/ipc_nrf5340/ipc_nrf5340.h
index 199b52d..1f0b478 100644
--- a/hw/drivers/ipc_nrf5340/include/ipc_nrf5340/ipc_nrf5340.h
+++ b/hw/drivers/ipc_nrf5340/include/ipc_nrf5340/ipc_nrf5340.h
@@ -48,7 +48,8 @@ void ipc_nrf5340_recv(int channel, ipc_nrf5340_recv_cb cb,
void *user_data);
/**
* Sends data over specified IPC channel. IPC uses ring buffer for data
passing.
- * If there is not enough space to store data -ENOMEM error is returned.
+ * If IPC_NRF5340_BLOCKING_WRITE is not enable and there is not enough space to
+ * store data SYS_ENOMEM error is returned.
*
* @param channel IPC channel number to send on
* @param dataData to be sent over IPC. If this is NULL only signal is
diff --git a/hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
b/hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
index cdd..7e13d0e 100644
--- a/hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
+++ b/hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
@@ -51,19 +51,13 @@ ipc_nrf5340_shm_get_data_length(uint16_t head, uint16_t
tail)
return ((unsigned int)(head - tail)) % IPC_BUF_SIZE;
}
-static int
+/* this function assumes that there is enough space for data */
+static void
ipc_nrf5340_shm_write(struct ipc_shm *shm, const void *data, uint16_t data_len)
{
uint16_t head = shm->head;
uint16_t len;
-/* check if data will fit */
-while (data_len + ipc_nrf5340_shm_get_data_length(head, shm->tail) >=
IPC_BUF_SIZE) {
-#if !MYNEWT_VAL(IPC_NRF5340_BLOCKING_WRITE)
-return -ENOMEM;
-#endif
-}
-
len = min(data_len, IPC_BUF_SIZE - head);
memcpy(shm->buf + head, data, len);
@@ -76,8 +70,6 @@ ipc_nrf5340_shm_write(struct ipc_shm *shm, const void *data,
uint16_t data_len)
head %= IPC_BUF_SIZE;
shm->head = head;
-
-return 0;
}
static uint16_t
@@ -212,17 +204,39 @@ ipc_nrf5340_recv(int channel, ipc_nrf5340_recv_cb cb,
void *user_data)
int
ipc_nrf5340_send(int channel, const void *data, uint16_t len)
{
-int rc = 0;
+struct ipc_shm *shm;
+uint16_t frag_len;
+uint16_t space;
assert(channel < IPC_MAX_CHANS);
+shm = [channel];
if (data && len) {
-rc = ipc_nrf5340_shm_write([channel], data, len);
-}
+while (len) {
+do {
+space = IPC_BUF_SIZE - 1;
+space -= ipc_nrf5340_shm_get_data_length(shm->head, shm->tail);
+#if !MYNEWT_VAL(IPC_NRF5340_BLOCKING_WRITE)
+/* assert since that will always fail for non-blocking write
+ * indicating use error
+ */
+assert(len < IPC_BUF_SIZE);
+if (len > space) {
+return SYS_ENOMEM;
+}
+#endif
+} while (space == 0);
-NRF_IPC->TASKS_SEND[channel] = 1;
+frag_len = min(len, space);
+ipc_nrf5340_shm_write(shm, data, frag_len);
+NRF_IPC->TASKS_SEND[channel] = 1;
-return rc;
+data += frag_len;
+len -= frag_len;
+}
+}
+
+return 0;
}
uint16_t
diff --git a/hw/drivers/ipc_nrf5340/syscfg.yml
b/hw/drivers/ipc_nrf5340/syscfg.yml
index 3820223..c92518a 100644
--- a/hw/drivers/ipc_nrf5340/syscfg.yml
+++ b/hw/drivers/ipc_nrf5340/syscfg.yml
@@ -28,6 +28,7 @@ syscfg.defs:
Shared memory ring buffer size used for IPC (per enabled channel).
It is recommended to use size which is power of two.
value: 256
+range: 2..65535
IPC_NRF5340_BLOCKING_WRITE:
description: >
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #540: nimble/host: Add support to accept or reject pairing request through GAP event
apache-mynewt-bot commented on pull request #540:
URL: https://github.com/apache/mynewt-nimble/pull/540#issuecomment-820402832
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #540: nimble/host: Add support to accept or reject pairing request through GAP event
apache-mynewt-bot removed a comment on pull request #540:
URL: https://github.com/apache/mynewt-nimble/pull/540#issuecomment-813635131
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] kasjer commented on pull request #963: targets: Add sample target for controller on NRF5340 bsp
kasjer commented on pull request #963: URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-820392565 Settings recommended by @sjanc applied. Added on setting that can be removed later ```yml IPC_NRF5340_BUF_SZ: 1024 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
apache-mynewt-bot commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820390986
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DR
apache-mynewt-bot removed a comment on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-819147320
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
sjanc commented on pull request #971: URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-820383758 do I get it right that without this patch pairing would end with success even though remote peer is not knowing our private key? How would it calculate valid DHKey and then mackey and LTK? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on a change in pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
sjanc commented on a change in pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#discussion_r613983459
##
File path: hw/mcu/nordic/nrf5340/src/hal_system.c
##
@@ -72,6 +81,7 @@ hal_debugger_connected(void)
void
hal_system_clock_start(void)
{
+
Review comment:
nitpick
##
File path: hw/mcu/nordic/nrf5340/src/hal_system.c
##
@@ -36,6 +36,15 @@
void
hal_system_init(void)
{
+
Review comment:
why empty line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] utzig closed pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
utzig closed pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-site] branch master updated: Update python requirements with upto date versions
This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-site.git The following commit(s) were added to refs/heads/master by this push: new 0fab732 Update python requirements with upto date versions 0fab732 is described below commit 0fab732bdcc5bf77a947a8546139bee728d68472 Author: Fabio Utzig AuthorDate: Wed Apr 14 20:12:08 2021 -0300 Update python requirements with upto date versions Signed-off-by: Fabio Utzig --- requirements.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/requirements.txt b/requirements.txt index 309285a..226d3a3 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,5 +1,5 @@ -mkdocs==1.0.4 -sh==1.12.14 -Sphinx==1.8.4 -recommonmark==0.5.0 -breathe==4.11.1 +mkdocs==1.1.2 +sh==1.14.1 +Sphinx==3.5.4 +recommonmark==0.6.0 +breathe==4.28.0
[GitHub] [mynewt-site] utzig merged pull request #533: Update python requirements with upto date versions
utzig merged pull request #533: URL: https://github.com/apache/mynewt-site/pull/533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
sjanc commented on pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820353281 fair enough, two nitpicks though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
utzig commented on pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820352297 @vrahane The Travis fail on the branch is a bit weird, did you first push the branch upstream instead of to your own fork? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
apache-mynewt-bot commented on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-820315413
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] prasad-alatkar commented on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
prasad-alatkar commented on pull request #971: URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-820314794 @sjanc @rymanluk Could you guys take a look ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] prasad-alatkar opened a new pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
prasad-alatkar opened a new pull request #971: URL: https://github.com/apache/mynewt-nimble/pull/971 Issue: In case of secure connection pairing and Paskkey Entry method, there is chance that MITM attacker can reply with same public key as received from vulnerable BLE device. This can potentially authenticate MITM attacker. This PR fixes this potential vulnerability. Solution: Check if the peer public key is same as our generated public key. Return fail if the public keys match to avoid 'Impersonation in Passkey entry protocol' vulnerability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen merged pull request #967: npl/riot: rework to use RIOTs ztimer
haukepetersen merged pull request #967: URL: https://github.com/apache/mynewt-nimble/pull/967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-nimble] branch master updated (1d073cc -> 940cc0b)
This is an automated email from the ASF dual-hosted git repository. hauke pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git. from 1d073cc transport/cmac: Fix race on LL event write add 940cc0b npl/riot: rework to use RIOTs ztimer No new revisions were added by this update. Summary of changes: porting/npl/riot/include/nimble/nimble_npl_os.h | 45 ++--- porting/npl/riot/src/npl_os_riot.c | 27 +-- 2 files changed, 26 insertions(+), 46 deletions(-)
[GitHub] [mynewt-nimble] haukepetersen commented on pull request #967: npl/riot: rework to use RIOTs ztimer
haukepetersen commented on pull request #967: URL: https://github.com/apache/mynewt-nimble/pull/967#issuecomment-820275191 Worked, Murdock is happy now :-) All green -> go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] simonratner edited a comment on issue #2535: Compiler packages for appcore and netcore of nRF5340
simonratner edited a comment on issue #2535: URL: https://github.com/apache/mynewt-core/issues/2535#issuecomment-820256580 Yes, although I am not sure what the result of specifying multiple `-mcpu` options is. Would this prevent the compiler package from specifying a default? I have not tested this with cflags, but with lflags the order of options is also not preserved currently, which could make this trickier (https://github.com/apache/mynewt-newt/issues/429). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] simonratner commented on issue #2535: Compiler packages for appcore and netcore of nRF5340
simonratner commented on issue #2535: URL: https://github.com/apache/mynewt-core/issues/2535#issuecomment-820256580 Yes, although I am not sure what the result of specifying multiple `-mcpu` options is. Would this prevent the mcu package from specifying a default? I have not tested this with cflags, but with lflags the order of options is also not preserved currently, which could make this trickier (https://github.com/apache/mynewt-newt/issues/429). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] prasad-alatkar commented on pull request #540: nimble/host: Add support to accept or reject pairing request through GAP event
prasad-alatkar commented on pull request #540: URL: https://github.com/apache/mynewt-nimble/pull/540#issuecomment-820253068 @rymanluk Can you please take a look at the PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #967: npl/riot: rework to use RIOTs ztimer
apache-mynewt-bot commented on pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967#issuecomment-820249775
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #967: npl/riot: rework to use RIOTs ztimer
apache-mynewt-bot removed a comment on pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967#issuecomment-817832209
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #963: [RFC] targets: Add sample target for controller on NRF5340 bsp
sjanc commented on pull request #963: URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-820206685 MSYS_1_BLOCK_COUNT: 12 MSYS_1_BLOCK_SIZE: 292 BLE_LL_CFG_FEAT_DATA_LEN_EXT: 1 BLE_LL_CFG_FEAT_LE_2M_PHY: 1 BLE_LL_CFG_FEAT_LE_CODED_PHY: 1 BLE_LL_CFG_FEAT_LL_PRIVACY: 1 BLE_LL_CFG_FEAT_CTRL_TO_HOST_FLOW_CONTROL: 1 BLE_LL_CONN_INIT_MAX_TX_BYTES: 251 BLE_LL_CONN_INIT_SLOTS: 4 BLE_LL_DTM: 1 BLE_LL_DTM_EXTENSIONS: 1 BLE_LL_VND_EVENT_ON_ASSERT: 1 BLE_MAX_CONNECTIONS: 5 BLE_EXT_ADV: 1 BLE_EXT_ADV_MAX_SIZE: 1650 BLE_MAX_PERIODIC_SYNCS: 5 BLE_MULTI_ADV_INSTANCES: 5 BLE_PERIODIC_ADV: 1 BLE_PERIODIC_ADV_SYNC_TRANSFER: 1 BLE_HCI_TRANSPORT: nrf5340 BLE_VERSION: 51 This is config I'm using for testing, since we have plenty of RAM just for netcore we can be generous with MSYS configuration :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #970: ll/rand: restructure rand initialization
apache-mynewt-bot removed a comment on pull request #970:
URL: https://github.com/apache/mynewt-nimble/pull/970#issuecomment-819802376
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #970: ll/rand: restructure rand initialization
apache-mynewt-bot commented on pull request #970:
URL: https://github.com/apache/mynewt-nimble/pull/970#issuecomment-820194409
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen commented on pull request #970: ll/rand: restructure rand initialization
haukepetersen commented on pull request #970: URL: https://github.com/apache/mynewt-nimble/pull/970#issuecomment-820187387 Yes and no. Seeding the jrand48 during init of course takes away the (non-deterministic) delay between TRNG init and jrand48 seeding. But if I understand `ble_ll_rand_data_get()` correctly, it should only return after the needed number of random bytes was actually created, right? Or do I miss something about the ` trng might not be accessible yet`? Does this mean, that the `tnrg_read()` loop in `ble_ll_rand_get_data()` gets stuck? Or might that loop not return any randomness? If so a solution might be to do the late seeding of jrand only for the case that TRNG is used, and stick to the seeding on init if that is not the case. In any case, I would prefer a deterministic behavior of the `rand` module, so its not dependent on who and when the initial calls to its functions are made... But I just discovered that I messed up the scope in the init function, right now jrand is never seeded in case the TRNG is used... Will fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #970: ll/rand: restructure rand initialization
sjanc commented on pull request #970: URL: https://github.com/apache/mynewt-nimble/pull/970#issuecomment-820179809 The commit you mentioned has this in commit message "Use jrand48 instead and provide wrapper for late initialization. This is to avoid seeding on init beacouse trng might not be accessible yet." Wouldn't this commit re-introduce this behaviour? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
