[GitHub] [mynewt-core] vikrant-proxy commented on pull request #2558: nrf5340 combine app/net build
vikrant-proxy commented on pull request #2558: URL: https://github.com/apache/mynewt-core/pull/2558#issuecomment-824493539 @kasjer can you mark `build_net_core.sh` as executable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
apache-mynewt-bot commented on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-824173296
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
apache-mynewt-bot removed a comment on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-820930665
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
prasad-alatkar commented on a change in pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#discussion_r617676406
##
File path: nimble/host/src/ble_sm_sc.c
##
@@ -612,6 +612,14 @@ ble_sm_sc_public_key_rx(uint16_t conn_handle, struct
os_mbuf **om,
}
cmd = (struct ble_sm_public_key *)(*om)->om_data;
+/* Check if the peer public key is same as our generated public key.
+ * Return fail if the public keys match. */
+if (ble_sm_sc_keys_generated) {
+if (memcmp(cmd, ble_sm_sc_pub_key, 64) == 0) {
+res->enc_cb = 1;
+res->sm_err = BLE_SM_ERR_AUTHREQ;
Review comment:
Added return. I will create unit test for the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
prasad-alatkar commented on a change in pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#discussion_r617547801
##
File path: nimble/host/src/ble_sm_sc.c
##
@@ -612,6 +612,14 @@ ble_sm_sc_public_key_rx(uint16_t conn_handle, struct
os_mbuf **om,
}
cmd = (struct ble_sm_public_key *)(*om)->om_data;
+/* Check if the peer public key is same as our generated public key.
+ * Return fail if the public keys match. */
+if (ble_sm_sc_keys_generated) {
Review comment:
Yes, the check is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2579: mcu/da1469x: Move .init_array sections to flash
apache-mynewt-bot commented on pull request #2579:
URL: https://github.com/apache/mynewt-core/pull/2579#issuecomment-824048992
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] kasjer opened a new pull request #2579: mcu/da1469x: Move .init_array sections to flash
kasjer opened a new pull request #2579: URL: https://github.com/apache/mynewt-core/pull/2579 content of .init_array* sections is meant to be executed only once during system start. For no apparent reason those arrays were put in data section. This would results in wast of RAM for C++ code built if it was not for the fact that KEEP keyword was missing so such sections would not result in final build (RAM nor FLASH) because by compiler design content of those section is not referenced explicitly and relays on linker using them without apparent reference. Sections are now moved to .text and used KEEP keyword to make sure constructors will be executed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2576: baselibc cpp global constructors
apache-mynewt-bot removed a comment on pull request #2576:
URL: https://github.com/apache/mynewt-core/pull/2576#issuecomment-823917747
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2576: baselibc cpp global constructors
apache-mynewt-bot commented on pull request #2576:
URL: https://github.com/apache/mynewt-core/pull/2576#issuecomment-824033345
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2578: mcu/nrf5x: Move .init_array sections to flash
apache-mynewt-bot commented on pull request #2578:
URL: https://github.com/apache/mynewt-core/pull/2578#issuecomment-824022839
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] kasjer opened a new pull request #2578: mcu/nrf5x: Move .init_array sections to flash
kasjer opened a new pull request #2578: URL: https://github.com/apache/mynewt-core/pull/2578 content of .init_array* sections is meant to be executed only once during system start. For no apparent reason those arrays were put in data section. This would results in wast of RAM for C++ code built if it was not for the fact that KEEP keyword was missing so such sections would not result in final build (RAM nor FLASH) because by compiler design content of those section is not referenced explicitly and relays on linker using them without apparent reference. Sections are now moved to .text and used KEEP keyword to make sure constructors will be executed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2577: mcu/stm32: Move .init_array sections to flash
apache-mynewt-bot commented on pull request #2577:
URL: https://github.com/apache/mynewt-core/pull/2577#issuecomment-824014237
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] kasjer opened a new pull request #2577: mcu/stm32: Move .init_array sections to flash
kasjer opened a new pull request #2577: URL: https://github.com/apache/mynewt-core/pull/2577 content of .init_array* sections is meant to be executed only once during system start. For no apparent reason those arrays were put in data section. This results in wast of RAM when C++ code is built. Sections are now moved to .text. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-newtmgr] eshaulx opened a new issue #184: DFU Device with Zephyr & MCUboot over SMP
eshaulx opened a new issue #184: URL: https://github.com/apache/mynewt-newtmgr/issues/184 question here, I am using nRF52840 device with zephyr application & MCUboot + SMP service the DFU is now done using: [](https://github.com/apache/mynewt-mcumgr-cli) or using Nordic connect mobile application. DFU is done via BLE - so far so good, now I want to integrate the DFU process into my proprietary GO application running on a Linux machine. I am new at GO, and trying to understand how to integrate that with my GO application. I understand that the CLI is a wrapper of the actual library : [](https://github.com/apache/mynewt-newtmgr) Do i need to add the https://github.com/apache/mynewt-newtmgr as go module and use it? if yes, how can i use it? I found no documentation or other casses useres used the above library into their own applications. Thanks in advance guys! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2576: baselibc cpp global constructors
apache-mynewt-bot commented on pull request #2576:
URL: https://github.com/apache/mynewt-core/pull/2576#issuecomment-823917747
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] kasjer opened a new pull request #2576: baselibc cpp global constructors
kasjer opened a new pull request #2576: URL: https://github.com/apache/mynewt-core/pull/2576 Code required to execute global object constructors was usually not called. hifive1 and two other stm32 boards had calls to __libc_init_array while all the others did not. Now **__libc_init_array()** is executed for all cases in **_start()** baselibc version of this function is provided so tool chain's one does not need to be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2575: riscv toolchain changes
apache-mynewt-bot commented on pull request #2575:
URL: https://github.com/apache/mynewt-core/pull/2575#issuecomment-823897120
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] andrzej-kaczmarek closed pull request #2561: hw/mcu/cmac: Fix os_cputime wrap around handling
andrzej-kaczmarek closed pull request #2561: URL: https://github.com/apache/mynewt-core/pull/2561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] kasjer opened a new pull request #2575: Kasjer/riscv toolchain changes
kasjer opened a new pull request #2575: URL: https://github.com/apache/mynewt-core/pull/2575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #958: Mesh sync March 2021
apache-mynewt-bot removed a comment on pull request #958: URL: https://github.com/apache/mynewt-nimble/pull/958#issuecomment-812326014 ## Style check fail: Payload was too large -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #958: Mesh sync March 2021
apache-mynewt-bot commented on pull request #958: URL: https://github.com/apache/mynewt-nimble/pull/958#issuecomment-823841397 ## Style check fail: Payload was too large -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
