[GitHub] [mynewt-core] vikrant-proxy closed pull request #2588: nrf53/ipc: add MCU_APP_CORE guard for NET_GPIO header includes

2021-05-05 Thread GitBox


vikrant-proxy closed pull request #2588:
URL: https://github.com/apache/mynewt-core/pull/2588


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2588: nrf53/ipc: add MCU_APP_CORE guard for NET_GPIO header includes

2021-05-05 Thread GitBox


apache-mynewt-bot commented on pull request #2588:
URL: https://github.com/apache/mynewt-core/pull/2588#issuecomment-833225981


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-core] vikrant-proxy opened a new pull request #2588: nrf53/ipc: add MCU_APP_CORE guard for NET_GPIO header includes

2021-05-05 Thread GitBox


vikrant-proxy opened a new pull request #2588:
URL: https://github.com/apache/mynewt-core/pull/2588


   The header file `nrf5340_hal.h` is for app core and should be guarded 
accordingly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-core] utzig merged pull request #2587: fs: littlefs: add migrate/readonly build options

2021-05-05 Thread GitBox


utzig merged pull request #2587:
URL: https://github.com/apache/mynewt-core/pull/2587


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[mynewt-core] branch master updated: fs: littlefs: add migrate/readonly build options

2021-05-05 Thread utzig
This is an automated email from the ASF dual-hosted git repository.

utzig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
 new 406e623  fs: littlefs: add migrate/readonly build options
 new 1d72ee5  Merge pull request #2587 from utzig/littlefs-options
406e623 is described below

commit 406e623689bf51d79a56138327f7782f35c068a7
Author: Fabio Utzig 
AuthorDate: Wed May 5 12:20:21 2021 -0300

fs: littlefs: add migrate/readonly build options

Add syscfg options that enable building the v1 metadata format migration
to v2, and read-only support (for smaller build sizes).

Signed-off-by: Fabio Utzig 
---
 fs/littlefs/pkg.yml|  6 ++
 fs/littlefs/syscfg.yml | 10 ++
 2 files changed, 16 insertions(+)

diff --git a/fs/littlefs/pkg.yml b/fs/littlefs/pkg.yml
index 2c14a32..8c3471b 100644
--- a/fs/littlefs/pkg.yml
+++ b/fs/littlefs/pkg.yml
@@ -33,5 +33,11 @@ pkg.deps:
 - "@apache-mynewt-core/kernel/os"
 - "@apache-mynewt-core/sys/flash_map"
 
+pkg.cflags.LITTLEFS_MIGRATE_V1:
+- -DLFS_MIGRATE
+
+pkg.cflags.LITTLEFS_READONLY:
+- -DLFS_READONLY
+
 pkg.init:
 littlefs_pkg_init: 'MYNEWT_VAL(LITTLEFS_SYSINIT_STAGE)'
diff --git a/fs/littlefs/syscfg.yml b/fs/littlefs/syscfg.yml
index a45fd39..4dbbad0 100644
--- a/fs/littlefs/syscfg.yml
+++ b/fs/littlefs/syscfg.yml
@@ -36,6 +36,16 @@ syscfg.defs:
 must have the same size.
 value: -1
 
+LITTLEFS_MIGRATE_V1:
+description: >
+Enable support for migrating LFSv1 filesystems to v2.
+value: 0
+
+LITTLEFS_READONLY:
+description: >
+Build LittleFS without write support.
+value: 0
+
 LITTLEFS_BLOCK_COUNT:
 description: >
 Number of blocks/sectors use by this partition.


[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2587: fs: littlefs: add migrate/readonly build options

2021-05-05 Thread GitBox


apache-mynewt-bot commented on pull request #2587:
URL: https://github.com/apache/mynewt-core/pull/2587#issuecomment-832863245


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-core] utzig opened a new pull request #2587: fs: littlefs: add migrate/readonly build options

2021-05-05 Thread GitBox


utzig opened a new pull request #2587:
URL: https://github.com/apache/mynewt-core/pull/2587


   Add syscfg options that enable building the v1 metadata format migration to 
v2, and read-only support (for smaller build sizes).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-core] utzig merged pull request #2586: Fix trailing spaces in yaml files

2021-05-05 Thread GitBox


utzig merged pull request #2586:
URL: https://github.com/apache/mynewt-core/pull/2586


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[mynewt-core] branch master updated: Fix trailing spaces in yaml files

2021-05-05 Thread utzig
This is an automated email from the ASF dual-hosted git repository.

utzig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
 new 61aa3ae  Fix trailing spaces in yaml files
 new 810bf0d  Merge pull request #2586 from 
utzig/yaml-trailing-space-cleanup
61aa3ae is described below

commit 61aa3ae7f355e5d81341d1e06f2b66db3d178294
Author: Fabio Utzig 
AuthorDate: Sun May 2 22:06:49 2021 -0300

Fix trailing spaces in yaml files

Clean up trailing spaces, to avoid copypasta of pkg.yml and syscfg.yml
with trailing spaces in the license headers to keep propagating.

Signed-off-by: Fabio Utzig 
---
 apps/bleprph_oic/pkg.yml|  4 ++--
 apps/bleprph_oic/syscfg.yml |  2 +-
 apps/blesplit/pkg.yml   |  2 +-
 apps/bus_test/lis2dh_node/pkg.yml   |  2 +-
 apps/bus_test/pkg.yml   |  2 +-
 apps/coremark/pkg.yml   |  2 +-
 apps/ffs2native/pkg.yml |  2 +-
 apps/lora_app_shell/pkg.yml |  2 +-
 apps/loraping/pkg.yml   |  2 +-
 apps/lorashell/pkg.yml  |  2 +-
 apps/metrics/pkg.yml|  8 
 apps/metrics/syscfg.yml |  2 +-
 apps/ocf_sample/pkg.yml |  2 +-
 apps/sensors_test/pkg.yml   |  2 +-
 apps/slinky/pkg.yml |  2 +-
 apps/splitty/pkg.yml|  2 +-
 apps/testbench/pkg.yml  |  2 +-
 apps/trng_test/pkg.yml  |  4 ++--
 apps/trng_test/syscfg.yml   |  2 +-
 boot/split/pkg.yml  |  2 +-
 boot/split/syscfg.yml   |  2 +-
 boot/split_app/pkg.yml  |  2 +-
 boot/stub/pkg.yml   |  2 +-
 compiler/arc/pkg.yml|  2 +-
 compiler/arm-none-eabi-m0/compiler.yml  |  2 +-
 compiler/arm-none-eabi-m0/pkg.yml   |  2 +-
 compiler/arm-none-eabi-m3/compiler.yml  |  2 +-
 compiler/arm-none-eabi-m3/pkg.yml   |  2 +-
 compiler/arm-none-eabi-m33/compiler.yml |  2 +-
 compiler/arm-none-eabi-m33/pkg.yml  |  2 +-
 compiler/arm-none-eabi-m4/compiler.yml  |  2 +-
 compiler/arm-none-eabi-m4/pkg.yml   |  2 +-
 compiler/arm-none-eabi-m7/compiler.yml  |  2 +-
 compiler/arm-none-eabi-m7/pkg.yml   |  2 +-
 compiler/sim/pkg.yml|  2 +-
 crypto/mbedtls/pkg.yml  |  2 +-
 crypto/mbedtls/selftest/pkg.yml |  4 ++--
 crypto/tinycrypt/pkg.yml|  2 +-
 encoding/base62/pkg.yml |  2 +-
 encoding/base62/selftest/pkg.yml|  4 ++--
 encoding/base64/pkg.yml |  2 +-
 encoding/base64/selftest/pkg.yml|  4 ++--
 encoding/cborattr/pkg.yml   |  2 +-
 encoding/json/hosttest/pkg.yml  |  4 ++--
 encoding/json/pkg.yml   |  4 ++--
 encoding/json/selftest/pkg.yml  |  4 ++--
 encoding/tinycbor/pkg.yml   |  6 +++---
 fs/disk/pkg.yml |  2 +-
 fs/fatfs/pkg.yml|  2 +-
 fs/fatfs/syscfg.yml |  2 +-
 fs/fcb/pkg.yml  |  2 +-
 fs/fcb/selftest/pkg.yml |  4 ++--
 fs/fcb2/pkg.yml |  2 +-
 fs/fcb2/selftest/pkg.yml|  4 ++--
 fs/fs/pkg.yml   |  2 +-
 fs/nffs/pkg.yml |  2 +-
 fs/nffs/selftest/pkg.yml|  4 ++--
 hw/bsp/ada_feather_stm32f405/pkg.yml|  2 +-
 hw/bsp/apollo2_evb/bsp.yml  |  2 +-
 hw/bsp/b-l072z-lrwan1/pkg.yml   |  2 +-
 hw/bsp/b-l475e-iot01a/pkg.yml   |  2 +-
 hw/bsp/black_vet6/pkg.yml   |  2 +-
 hw/bsp/bluepill/bsp.yml |  2 +-
 hw/bsp/calliope_mini/syscfg.yml |  4 ++--
 hw/bsp/native-armv7/pkg.yml |  2 +-
 hw/bsp/native-mips/pkg.yml  |  2 +-
 hw/bsp/native/pkg.yml   |  2 +-
 hw/bsp/nucleo-f072rb/pkg.yml|  2 +-
 hw/bsp/nucleo-f103rb/pkg.yml|  2 +-
 hw/bsp/nucleo-f103rb/syscfg.yml |  2 +-
 hw/bsp/nucleo-f303k8/pkg.yml|  2 +-
 hw/bsp/nucleo-f303re/pkg.yml|  2 +-
 hw/bsp/nucleo-f401re/pkg.yml|  2 +-
 hw/bsp/nucleo-f411re/pkg.yml|  2 

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #958: Mesh sync March 2021

2021-05-05 Thread GitBox


apache-mynewt-bot commented on pull request #958:
URL: https://github.com/apache/mynewt-nimble/pull/958#issuecomment-832584097


   
   ## Style check fail: Payload was too large


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #958: Mesh sync March 2021

2021-05-05 Thread GitBox


apache-mynewt-bot removed a comment on pull request #958:
URL: https://github.com/apache/mynewt-nimble/pull/958#issuecomment-830085501


   
   ## Style check fail: Payload was too large


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing

2021-05-05 Thread GitBox


apache-mynewt-bot commented on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-832454524


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing

2021-05-05 Thread GitBox


apache-mynewt-bot removed a comment on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-832442568


   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/test/src/ble_sm_sc_test.c
   
   
   ```diff
   @@ -2298,8 +2292,7 @@
 * Responder key distribution: 5
 * Peer responds with same public key
 */
   -TEST_CASE_SELF(ble_sm_sc_us_pk_iio2_rio4_b1_iat0_rat0_ik7_rk5_peer_same_pk)
   -{
   +TEST_CASE_SELF(ble_sm_sc_us_pk_iio2_rio4_b1_iat0_rat0_ik7_rk5_peer_same_pk) 
{
struct ble_sm_test_params params;

params = (struct ble_sm_test_params) {
   ```
   
   
   
    nimble/host/test/src/ble_sm_test_util.c
   
   
   ```diff
   @@ -2597,11 +2584,10 @@
}

static void
   -ble_sm_test_util_us_sc_bad_once_no_init(
   -struct ble_sm_test_params *params,
   -struct ble_hs_conn *conn,
   -struct ble_sm_test_util_entity *our_entity,
   -struct ble_sm_test_util_entity *peer_entity)
   +ble_sm_test_util_us_sc_bad_once_no_init(struct ble_sm_test_params *params,
   +struct ble_hs_conn *conn,
   +struct ble_sm_test_util_entity 
*our_entity,
   +struct ble_sm_test_util_entity 
*peer_entity)
{
int rc;

   @@ -2709,11 +2695,10 @@
}

static void
   -ble_sm_test_util_peer_sc_good_once_no_init(
   -struct ble_sm_test_params *params,
   -struct ble_hs_conn *conn,
   -struct ble_sm_test_util_entity *our_entity,
   -struct ble_sm_test_util_entity *peer_entity)
   +ble_sm_test_util_peer_sc_good_once_no_init(struct ble_sm_test_params 
*params,
   +   struct ble_hs_conn *conn,
   +   struct ble_sm_test_util_entity 
*our_entity,
   +   struct ble_sm_test_util_entity 
*peer_entity)
{
int num_iters;
int rc;
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing

2021-05-05 Thread GitBox


apache-mynewt-bot removed a comment on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-831340410


   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/test/src/ble_sm_sc_test.c
   
   
   ```diff
   @@ -2298,8 +2292,7 @@
 * Responder key distribution: 5
 * Peer responds with same public key
 */
   -TEST_CASE_SELF(ble_sm_sc_us_pk_iio2_rio4_b1_iat0_rat0_ik7_rk5_peer_same_pk)
   -{
   +TEST_CASE_SELF(ble_sm_sc_us_pk_iio2_rio4_b1_iat0_rat0_ik7_rk5_peer_same_pk) 
{
struct ble_sm_test_params params;

params = (struct ble_sm_test_params) {
   ```
   
   
   
    nimble/host/test/src/ble_sm_test_util.c
   
   
   ```diff
   @@ -2597,11 +2584,10 @@
}

static void
   -ble_sm_test_util_us_sc_bad_once_no_init(
   -struct ble_sm_test_params *params,
   -struct ble_hs_conn *conn,
   -struct ble_sm_test_util_entity *our_entity,
   -struct ble_sm_test_util_entity *peer_entity)
   +ble_sm_test_util_us_sc_bad_once_no_init(struct ble_sm_test_params *params,
   +struct ble_hs_conn *conn,
   +struct ble_sm_test_util_entity 
*our_entity,
   +struct ble_sm_test_util_entity 
*peer_entity)
{
int num_iters;
int rc;
   @@ -2714,11 +2700,10 @@
}

static void
   -ble_sm_test_util_peer_sc_good_once_no_init(
   -struct ble_sm_test_params *params,
   -struct ble_hs_conn *conn,
   -struct ble_sm_test_util_entity *our_entity,
   -struct ble_sm_test_util_entity *peer_entity)
   +ble_sm_test_util_peer_sc_good_once_no_init(struct ble_sm_test_params 
*params,
   +   struct ble_hs_conn *conn,
   +   struct ble_sm_test_util_entity 
*our_entity,
   +   struct ble_sm_test_util_entity 
*peer_entity)
{
int num_iters;
int rc;
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing

2021-05-05 Thread GitBox


apache-mynewt-bot commented on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-832442568


   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/test/src/ble_sm_sc_test.c
   
   
   ```diff
   @@ -2298,8 +2292,7 @@
 * Responder key distribution: 5
 * Peer responds with same public key
 */
   -TEST_CASE_SELF(ble_sm_sc_us_pk_iio2_rio4_b1_iat0_rat0_ik7_rk5_peer_same_pk)
   -{
   +TEST_CASE_SELF(ble_sm_sc_us_pk_iio2_rio4_b1_iat0_rat0_ik7_rk5_peer_same_pk) 
{
struct ble_sm_test_params params;

params = (struct ble_sm_test_params) {
   ```
   
   
   
    nimble/host/test/src/ble_sm_test_util.c
   
   
   ```diff
   @@ -2597,11 +2584,10 @@
}

static void
   -ble_sm_test_util_us_sc_bad_once_no_init(
   -struct ble_sm_test_params *params,
   -struct ble_hs_conn *conn,
   -struct ble_sm_test_util_entity *our_entity,
   -struct ble_sm_test_util_entity *peer_entity)
   +ble_sm_test_util_us_sc_bad_once_no_init(struct ble_sm_test_params *params,
   +struct ble_hs_conn *conn,
   +struct ble_sm_test_util_entity 
*our_entity,
   +struct ble_sm_test_util_entity 
*peer_entity)
{
int rc;

   @@ -2709,11 +2695,10 @@
}

static void
   -ble_sm_test_util_peer_sc_good_once_no_init(
   -struct ble_sm_test_params *params,
   -struct ble_hs_conn *conn,
   -struct ble_sm_test_util_entity *our_entity,
   -struct ble_sm_test_util_entity *peer_entity)
   +ble_sm_test_util_peer_sc_good_once_no_init(struct ble_sm_test_params 
*params,
   +   struct ble_hs_conn *conn,
   +   struct ble_sm_test_util_entity 
*our_entity,
   +   struct ble_sm_test_util_entity 
*peer_entity)
{
int num_iters;
int rc;
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org