This is an automated email from the ASF dual-hosted git repository.
vipulrahane pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-mcumgr.git
The following commit(s) were added to refs/heads/master by this push:
new afa95ba cmd/img_mgmt: Call dfu stop
vrahane commented on a change in pull request #2611:
URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646181312
##
File path: hw/drivers/ram/spiram/src/spiram.c
##
@@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev)
int
spiram_read(struct spiram_de
vrahane commented on a change in pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649485185
##
File path: hw/mcu/nordic/nrf5340/syscfg.yml
##
@@ -25,13 +25,15 @@ syscfg.defs:
- $notnull
choices:
- nRF5340_AP
vrahane opened a new pull request #125:
URL: https://github.com/apache/mynewt-mcumgr/pull/125
- DFU stop callback needs to be called when erase is performed, since the
DFU state of the image gets cleared
--
This is an automated message from the Apache Git Service.
To respond to the messa
vrahane commented on a change in pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649397245
##
File path: hw/mcu/nordic/nrf5340/syscfg.yml
##
@@ -25,13 +25,15 @@ syscfg.defs:
- $notnull
choices:
- nRF5340_AP
vrahane commented on a change in pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649397141
##
File path: hw/mcu/nordic/nrf5340/pkg.yml
##
@@ -104,3 +104,10 @@ pkg.deps.I2C_3':
pkg.deps.NRF5340_EMBED_NET_CORE:
- "@apache-mynewt-core/h
vrahane commented on a change in pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649380996
##
File path: hw/mcu/nordic/nrf5340/syscfg.yml
##
@@ -25,13 +25,15 @@ syscfg.defs:
- $notnull
choices:
- nRF5340_AP
kasjer commented on pull request #2605:
URL: https://github.com/apache/mynewt-core/pull/2605#issuecomment-858539553
> Also, a basic CLI to query registers of the chip would be useful for
debugging.
I will add separate PR for that that.
--
This is an automated message from the Apac
kasjer commented on pull request #2605:
URL: https://github.com/apache/mynewt-core/pull/2605#issuecomment-858539315
> So, the code looks really clean, we do need to handle errors in various
places. I think adding STATS and LOG messages for figuring out what is going
wrong would be helpful
sjanc commented on a change in pull request #2605:
URL: https://github.com/apache/mynewt-core/pull/2605#discussion_r649086710
##
File path: hw/drivers/uart/max3107/src/max3107.c
##
@@ -0,0 +1,1090 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
utzig merged pull request #123:
URL: https://github.com/apache/mynewt-mcumgr/pull/123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
This is an automated email from the ASF dual-hosted git repository.
utzig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-mcumgr.git
The following commit(s) were added to refs/heads/master by this push:
new 6a10fa6 img_mgmt: Add interpretation of "
de-nordic commented on a change in pull request #123:
URL: https://github.com/apache/mynewt-mcumgr/pull/123#discussion_r649070524
##
File path: cmd/img_mgmt/src/img_mgmt.c
##
@@ -394,42 +394,49 @@ img_mgmt_upload(struct mgmt_ctxt *ctxt)
.data_len = 0,
.data_sh
de-nordic commented on a change in pull request #123:
URL: https://github.com/apache/mynewt-mcumgr/pull/123#discussion_r649061301
##
File path: cmd/img_mgmt/src/img_mgmt.c
##
@@ -394,42 +394,49 @@ img_mgmt_upload(struct mgmt_ctxt *ctxt)
.data_len = 0,
.data_sh
utzig commented on a change in pull request #123:
URL: https://github.com/apache/mynewt-mcumgr/pull/123#discussion_r649044768
##
File path: cmd/img_mgmt/src/img_mgmt.c
##
@@ -394,42 +394,49 @@ img_mgmt_upload(struct mgmt_ctxt *ctxt)
.data_len = 0,
.data_sha_le
de-nordic opened a new pull request #124:
URL: https://github.com/apache/mynewt-mcumgr/pull/124
The PR is series of fixes that to the Zephyr fork that:
- change slot selection logic in `img_mgmt_find_best_area_id` to just check
if slot1 is available, as basically that was what the funct
de-nordic commented on pull request #124:
URL: https://github.com/apache/mynewt-mcumgr/pull/124#issuecomment-858466003
Please take a look @mlaz, @nvlsianpu , @utzig, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
de-nordic commented on pull request #123:
URL: https://github.com/apache/mynewt-mcumgr/pull/123#issuecomment-858453717
Hello :) @mlaz @nvlsianpu @utzig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
de-nordic commented on pull request #123:
URL: https://github.com/apache/mynewt-mcumgr/pull/123#issuecomment-858452954
Note: image 0 has been marked as auto-select; this is due to compatibility
with current state as this is the number that is always being sent, if no
override from `-n` par
de-nordic opened a new pull request #123:
URL: https://github.com/apache/mynewt-mcumgr/pull/123
The commit extends img_mgmt_upload_req with image member that will
be used to hold image number; it also adds code that picks the
image number from update frame.
Signed-off-by: Domini
sjanc commented on a change in pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r648922768
##
File path: hw/mcu/nordic/nrf5340/pkg.yml
##
@@ -104,3 +104,10 @@ pkg.deps.I2C_3':
pkg.deps.NRF5340_EMBED_NET_CORE:
- "@apache-mynewt-core/hw/
21 matches
Mail list logo
