[GitHub] [mynewt-nimble] sjanc opened a new pull request #1004: Fix scanner assert on receiving AUX_ADV_IND

2021-07-22 Thread GitBox


sjanc opened a new pull request #1004:
URL: https://github.com/apache/mynewt-nimble/pull/1004


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-nimble] KKopyscinski commented on a change in pull request #1003: host/l2cap: disconnect if received packet is larger than MPS

2021-07-22 Thread GitBox


KKopyscinski commented on a change in pull request #1003:
URL: https://github.com/apache/mynewt-nimble/pull/1003#discussion_r674545428



##
File path: nimble/host/src/ble_l2cap.c
##
@@ -387,6 +387,15 @@ ble_l2cap_rx(struct ble_hs_conn *conn,
 goto err;
 }
 
+if (l2cap_hdr.len > chan->my_coc_mps) {

Review comment:
   Yes, I think you are right. What's more, I think only dynamic range CIDs 
use `my_coc_mps` field, and for others MPS=MTU of channel, which varies from 
channel to channel. I added 3 cases for `BLE_L2CAP_CID_ATT`, 
`BLE_L2CAP_CID_SIG` and `BLE_L2CAP_CID_SM`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org