[GitHub] [mynewt-artifact] vrahane commented on pull request #28: Allow "extra" information in a manifest
vrahane commented on pull request #28: URL: https://github.com/apache/mynewt-artifact/pull/28#issuecomment-887680792 @ccollins476ad this needs a rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-artifact] branch master updated: image: Function to convert image to a byte slice
This is an automated email from the ASF dual-hosted git repository.
vipulrahane pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-artifact.git
The following commit(s) were added to refs/heads/master by this push:
new 1794f79 image: Function to convert image to a byte slice
new 4f94303 Merge pull request #24 from ccollins476ad/image-bin
1794f79 is described below
commit 1794f7972c3c6dba99dfe3bdc85354cfe0984e3d
Author: Christopher Collins
AuthorDate: Thu Jun 4 14:15:14 2020 -0700
image: Function to convert image to a byte slice
---
image/image.go | 19 +++
1 file changed, 19 insertions(+)
diff --git a/image/image.go b/image/image.go
index f7ef6e6..90191fc 100644
--- a/image/image.go
+++ b/image/image.go
@@ -20,6 +20,8 @@
package image
import (
+ "bufio"
+ "bytes"
"encoding/binary"
"fmt"
"io"
@@ -774,3 +776,20 @@ func DecryptHwFull(img Image, secret []byte) (Image,
error) {
func (img *Image) IsEncrypted() bool {
return img.Header.Flags&IMAGE_F_ENCRYPTED != 0
}
+
+func (img *Image) Bin() ([]byte, error) {
+ b := &bytes.Buffer{}
+ w := bufio.NewWriter(b)
+
+ _, err := img.Write(w)
+ if err != nil {
+ return nil, err
+ }
+
+ err = w.Flush()
+ if err != nil {
+ return nil, err
+ }
+
+ return b.Bytes(), nil
+}
[GitHub] [mynewt-artifact] vrahane merged pull request #24: image: Function to convert image to a byte slice
vrahane merged pull request #24: URL: https://github.com/apache/mynewt-artifact/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] prasad-alatkar commented on pull request #540: nimble/host: Add support to accept or reject pairing request through GAP event
prasad-alatkar commented on pull request #540: URL: https://github.com/apache/mynewt-nimble/pull/540#issuecomment-887586637 > @prasad-alatkar looks like unit tests are failing. newt test @apache-mynewt-nimble/nimble/host/test could you check that? Also could you please add a patch to btshell which would allow to test this patch? Thanks @rymanluk , as per my understanding the failure is seen in unit test : `ble_sm_test_case_peer_lgcy_fail_confirm`. However, I am a little confused with the error prints here: `nimble_host_test.elf: nimble/host/src/ble_hs.c:194: ble_hs_lock: Assertion `!ble_hs_locked_by_cur_task()' failed`. It seems that `ble_hs_lock` is getting called twice somewhere, but the PR changes do not add any extra host lock. Could you please help here to pass the CI tests ? I am not very familiar with BT tests here, could you please let me know if it is possible to collect debug logs through CI ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] vikrant-proxy commented on a change in pull request #2627: ipc nrf5340 flash
vikrant-proxy commented on a change in pull request #2627:
URL: https://github.com/apache/mynewt-core/pull/2627#discussion_r677465530
##
File path: hw/bsp/nordic_pca10095_net/src/hal_bsp.c
##
@@ -48,13 +48,18 @@ hal_bsp_flash_dev(uint8_t id)
* Internal flash mapped to id 0.
*/
if (id == 0) {
-return &nrf5340_net_flash_dev;
+return &nrf5340_flash_dev;
}
#if MCUBOOT_MYNEWT
if (id == 1) {
return &nrf5340_net_vflash_dev.nv_flash;
}
#endif
+#if MYNEWT_VAL(IPC_NRF5340_FLASH_CLIENT)
Review comment:
should this have been `IPC_NRF5340_FLASH_SERVER` given appcore is the
client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc opened a new pull request #1005: apps: Add periodic advertising instance to ext_advertiser sample
sjanc opened a new pull request #1005: URL: https://github.com/apache/mynewt-nimble/pull/1005 Add new instance that advertises 1650 bytes of periodic data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] vikrant-proxy commented on a change in pull request #2627: ipc nrf5340 flash
vikrant-proxy commented on a change in pull request #2627:
URL: https://github.com/apache/mynewt-core/pull/2627#discussion_r677465530
##
File path: hw/bsp/nordic_pca10095_net/src/hal_bsp.c
##
@@ -48,13 +48,18 @@ hal_bsp_flash_dev(uint8_t id)
* Internal flash mapped to id 0.
*/
if (id == 0) {
-return &nrf5340_net_flash_dev;
+return &nrf5340_flash_dev;
}
#if MCUBOOT_MYNEWT
if (id == 1) {
return &nrf5340_net_vflash_dev.nv_flash;
}
#endif
+#if MYNEWT_VAL(IPC_NRF5340_FLASH_CLIENT)
Review comment:
should this have been `IPC_NRF5340_FLASH_SERVER` given appcore is the
client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
