[GitHub] [mynewt-core] sjanc closed pull request #2925: Use exact commit sha for GH Actions that are not certified

[GitBox]

sjanc closed pull request #2925: Use exact commit sha for GH Actions that are 
not certified
URL: https://github.com/apache/mynewt-core/pull/2925


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2925: Use exact commit sha for GH Actions that are not certified

[GitBox]

apache-mynewt-bot commented on PR #2925:
URL: https://github.com/apache/mynewt-core/pull/2925#issuecomment-1398187378

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] bvdberg commented on issue #1421: When using COC server and send is stalled, disconnects are not detected

[GitBox]

bvdberg commented on issue #1421:
URL: https://github.com/apache/mynewt-nimble/issues/1421#issuecomment-1398186397

   Nothing is logged in the device. The PC side detects a connection drop (and 
starts trying to re-connect). The Device (Nimble) side doesn't log anything 
special. The device is still running (blinking LEDs etc). Could it be that it 
runs out of a command buffer and cannot get a disconnect message up?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] sjanc opened a new pull request, #2925: Use exact commit sha for GH Actions that are not certified

[GitBox]

sjanc opened a new pull request, #2925:
URL: https://github.com/apache/mynewt-core/pull/2925

   ASF policy requires to use exact sha instead of tags for actions that are 
not certified by Github or ASF.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1432: Initial Github Action integration

[GitBox]

apache-mynewt-bot commented on PR #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432#issuecomment-1398159988

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] sjanc merged pull request #2922: Initial Github Action integration

[GitBox]

sjanc merged PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2922: Initial Github Action integration

[GitBox]

apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1398099934

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2924: stm32: Update syscfg for timers

[GitBox]

apache-mynewt-bot commented on PR #2924:
URL: https://github.com/apache/mynewt-core/pull/2924#issuecomment-1397998787

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] kasjer opened a new pull request, #2924: stm32: Update syscfg for timers

[GitBox]

kasjer opened a new pull request, #2924:
URL: https://github.com/apache/mynewt-core/pull/2924

   TIMER_3, TIMER_4 and TIMER_5 were referenced at code stm32_periph.c yet 
there were not definitions for them.
   This just adds missing definitions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

[GitBox]

apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397996704

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

[GitBox]

apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397991343

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_gatt_priv.h
   
   
   ```diff
   @@ -34,57 +34,57 @@
struct ble_att_prep_write_cmd;

STATS_SECT_START(ble_gattc_stats)
   -STATS_SECT_ENTRY(mtu)
   -STATS_SECT_ENTRY(mtu_fail)
   -STATS_SECT_ENTRY(disc_all_svcs)
   -STATS_SECT_ENTRY(disc_all_svcs_fail)
   -STATS_SECT_ENTRY(disc_svc_uuid)
   -STATS_SECT_ENTRY(disc_svc_uuid_fail)
   -STATS_SECT_ENTRY(find_inc_svcs)
   -STATS_SECT_ENTRY(find_inc_svcs_fail)
   -STATS_SECT_ENTRY(disc_all_chrs)
   -STATS_SECT_ENTRY(disc_all_chrs_fail)
   -STATS_SECT_ENTRY(disc_chrs_uuid)
   -STATS_SECT_ENTRY(disc_chrs_uuid_fail)
   -STATS_SECT_ENTRY(disc_all_dscs)
   -STATS_SECT_ENTRY(disc_all_dscs_fail)
   -STATS_SECT_ENTRY(read)
   -STATS_SECT_ENTRY(read_fail)
   -STATS_SECT_ENTRY(read_uuid)
   -STATS_SECT_ENTRY(read_uuid_fail)
   -STATS_SECT_ENTRY(read_long)
   -STATS_SECT_ENTRY(read_long_fail)
   -STATS_SECT_ENTRY(read_mult)
   -STATS_SECT_ENTRY(read_mult_fail)
   -STATS_SECT_ENTRY(write_no_rsp)
   -STATS_SECT_ENTRY(write_no_rsp_fail)
   -STATS_SECT_ENTRY(write)
   -STATS_SECT_ENTRY(write_fail)
   -STATS_SECT_ENTRY(write_long)
   -STATS_SECT_ENTRY(write_long_fail)
   -STATS_SECT_ENTRY(write_reliable)
   -STATS_SECT_ENTRY(write_reliable_fail)
   -STATS_SECT_ENTRY(notify)
   -STATS_SECT_ENTRY(notify_fail)
   -STATS_SECT_ENTRY(multi_notify)
   -STATS_SECT_ENTRY(multi_notify_fail)
   -STATS_SECT_ENTRY(indicate)
   -STATS_SECT_ENTRY(indicate_fail)
   -STATS_SECT_ENTRY(proc_timeout)
   +STATS_SECT_ENTRY(mtu)
   +STATS_SECT_ENTRY(mtu_fail)
   +STATS_SECT_ENTRY(disc_all_svcs)
   +STATS_SECT_ENTRY(disc_all_svcs_fail)
   +STATS_SECT_ENTRY(disc_svc_uuid)
   +STATS_SECT_ENTRY(disc_svc_uuid_fail)
   +STATS_SECT_ENTRY(find_inc_svcs)
   +STATS_SECT_ENTRY(find_inc_svcs_fail)
   +STATS_SECT_ENTRY(disc_all_chrs)
   +STATS_SECT_ENTRY(disc_all_chrs_fail)
   +STATS_SECT_ENTRY(disc_chrs_uuid)
   +STATS_SECT_ENTRY(disc_chrs_uuid_fail)
   +STATS_SECT_ENTRY(disc_all_dscs)
   +STATS_SECT_ENTRY(disc_all_dscs_fail)
   +STATS_SECT_ENTRY(read)
   +STATS_SECT_ENTRY(read_fail)
   +STATS_SECT_ENTRY(read_uuid)
   +STATS_SECT_ENTRY(read_uuid_fail)
   +STATS_SECT_ENTRY(read_long)
   +STATS_SECT_ENTRY(read_long_fail)
   +STATS_SECT_ENTRY(read_mult)
   +STATS_SECT_ENTRY(read_mult_fail)
   +STATS_SECT_ENTRY(write_no_rsp)
   +STATS_SECT_ENTRY(write_no_rsp_fail)
   +STATS_SECT_ENTRY(write)
   +STATS_SECT_ENTRY(write_fail)
   +STATS_SECT_ENTRY(write_long)
   +STATS_SECT_ENTRY(write_long_fail)
   +STATS_SECT_ENTRY(write_reliable)
   +STATS_SECT_ENTRY(write_reliable_fail)
   +STATS_SECT_ENTRY(notify)
   +STATS_SECT_ENTRY(notify_fail)
   +STATS_SECT_ENTRY(multi_notify)
   +STATS_SECT_ENTRY(multi_notify_fail)
   +STATS_SECT_ENTRY(indicate)
   +STATS_SECT_ENTRY(indicate_fail)
   +STATS_SECT_ENTRY(proc_timeout)
STATS_SECT_END
extern STATS_SECT_DECL(ble_gattc_stats) ble_gattc_stats;

STATS_SECT_START(ble_gatts_stats)
   -STATS_SECT_ENTRY(svcs)
   -STATS_SECT_ENTRY(chrs)
   -STATS_SECT_ENTRY(dscs)
   -STATS_SECT_ENTRY(svc_def_reads)
   -STATS_SECT_ENTRY(svc_inc_reads)
   -STATS_SECT_ENTRY(chr_def_reads)
   -STATS_SECT_ENTRY(chr_val_reads)
   -STATS_SECT_ENTRY(chr_val_writes)
   -STATS_SECT_ENTRY(dsc_reads)
   -STATS_SECT_ENTRY(dsc_writes)
   +STATS_SECT_ENTRY(svcs)
   +STATS_SECT_ENTRY(chrs)
   +STATS_SECT_ENTRY(dscs)
   +STATS_SECT_ENTRY(svc_def_reads)
   +STATS_SECT_ENTRY(svc_inc_reads)
   +STATS_SECT_ENTRY(chr_def_reads)
   +STATS_SECT_ENTRY(chr_val_reads)
   +STATS_SECT_ENTRY(chr_val_writes)
   +STATS_SECT_ENTRY(dsc_reads)
   +STATS_SECT_ENTRY(dsc_writes)
STATS_SECT_END
extern STATS_SECT_DECL(ble_gatts_stats) ble_gatts_stats;

   ```
   
   
   
    nimble/host/src/ble_gattc.c
   
   
   ```diff
   @@ -434,48 +434,48 @@
/* Statistics. */
STATS_SECT_DECL(ble_gattc_stats) ble_gattc_stats;
STATS_NAME_START(ble_gattc_stats)
   -STATS_NAME(ble_gattc_stats, mtu)
   -STATS_NAME(ble_gattc_stats, mtu_fail)
   -STATS_NAME(ble_gattc_stats, disc_all_svcs)
   -STATS_NAME(ble_gattc_stats, disc_all_svcs_fail)
   -STATS_NAME(ble_gattc_stats, disc_svc_uuid)
   -STATS_NAME(ble_gattc_stats, disc_svc_uuid_fail)
   -STATS_NAME(ble_gattc_stats, find_inc_svcs)
   -STATS_NAME(ble_gattc_stats, find_inc_svcs_fail)
   -STATS_NAME(ble_gattc_stats, disc_all_chrs)
   -STATS_NAME(ble_gattc_stats, disc_all_chrs_fail)
   -STATS_NAME(ble_gattc_stats, disc_chrs_uuid)
   -STATS_NAME(ble_gattc_stats, disc_chrs_uuid_fail)
   -STATS_NAME(ble_gattc_stats, 

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

[GitBox]

apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397975025

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

[GitBox]

apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397965509

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_att.c
   
   
   ```diff
   @@ -78,61 +78,61 @@

STATS_SECT_DECL(ble_att_stats) ble_att_stats;
STATS_NAME_START(ble_att_stats)
   -STATS_NAME(ble_att_stats, error_rsp_rx)
   -STATS_NAME(ble_att_stats, error_rsp_tx)
   -STATS_NAME(ble_att_stats, mtu_req_rx)
   -STATS_NAME(ble_att_stats, mtu_req_tx)
   -STATS_NAME(ble_att_stats, mtu_rsp_rx)
   -STATS_NAME(ble_att_stats, mtu_rsp_tx)
   -STATS_NAME(ble_att_stats, find_info_req_rx)
   -STATS_NAME(ble_att_stats, find_info_req_tx)
   -STATS_NAME(ble_att_stats, find_info_rsp_rx)
   -STATS_NAME(ble_att_stats, find_info_rsp_tx)
   -STATS_NAME(ble_att_stats, find_type_value_req_rx)
   -STATS_NAME(ble_att_stats, find_type_value_req_tx)
   -STATS_NAME(ble_att_stats, find_type_value_rsp_rx)
   -STATS_NAME(ble_att_stats, find_type_value_rsp_tx)
   -STATS_NAME(ble_att_stats, read_type_req_rx)
   -STATS_NAME(ble_att_stats, read_type_req_tx)
   -STATS_NAME(ble_att_stats, read_type_rsp_rx)
   -STATS_NAME(ble_att_stats, read_type_rsp_tx)
   -STATS_NAME(ble_att_stats, read_req_rx)
   -STATS_NAME(ble_att_stats, read_req_tx)
   -STATS_NAME(ble_att_stats, read_rsp_rx)
   -STATS_NAME(ble_att_stats, read_rsp_tx)
   -STATS_NAME(ble_att_stats, read_blob_req_rx)
   -STATS_NAME(ble_att_stats, read_blob_req_tx)
   -STATS_NAME(ble_att_stats, read_blob_rsp_rx)
   -STATS_NAME(ble_att_stats, read_blob_rsp_tx)
   -STATS_NAME(ble_att_stats, read_mult_req_rx)
   -STATS_NAME(ble_att_stats, read_mult_req_tx)
   -STATS_NAME(ble_att_stats, read_mult_rsp_rx)
   -STATS_NAME(ble_att_stats, read_mult_rsp_tx)
   -STATS_NAME(ble_att_stats, read_group_type_req_rx)
   -STATS_NAME(ble_att_stats, read_group_type_req_tx)
   -STATS_NAME(ble_att_stats, read_group_type_rsp_rx)
   -STATS_NAME(ble_att_stats, read_group_type_rsp_tx)
   -STATS_NAME(ble_att_stats, write_req_rx)
   -STATS_NAME(ble_att_stats, write_req_tx)
   -STATS_NAME(ble_att_stats, write_rsp_rx)
   -STATS_NAME(ble_att_stats, write_rsp_tx)
   -STATS_NAME(ble_att_stats, prep_write_req_rx)
   -STATS_NAME(ble_att_stats, prep_write_req_tx)
   -STATS_NAME(ble_att_stats, prep_write_rsp_rx)
   -STATS_NAME(ble_att_stats, prep_write_rsp_tx)
   -STATS_NAME(ble_att_stats, exec_write_req_rx)
   -STATS_NAME(ble_att_stats, exec_write_req_tx)
   -STATS_NAME(ble_att_stats, exec_write_rsp_rx)
   -STATS_NAME(ble_att_stats, exec_write_rsp_tx)
   -STATS_NAME(ble_att_stats, notify_req_rx)
   -STATS_NAME(ble_att_stats, notify_req_tx)
   -STATS_NAME(ble_att_stats, indicate_req_rx)
   -STATS_NAME(ble_att_stats, indicate_req_tx)
   -STATS_NAME(ble_att_stats, indicate_rsp_rx)
   -STATS_NAME(ble_att_stats, indicate_rsp_tx)
   -STATS_NAME(ble_att_stats, multi_notify_req_rx)
   -STATS_NAME(ble_att_stats, write_cmd_rx)
   -STATS_NAME(ble_att_stats, write_cmd_tx)
   +STATS_NAME(ble_att_stats, error_rsp_rx)
   +STATS_NAME(ble_att_stats, error_rsp_tx)
   +STATS_NAME(ble_att_stats, mtu_req_rx)
   +STATS_NAME(ble_att_stats, mtu_req_tx)
   +STATS_NAME(ble_att_stats, mtu_rsp_rx)
   +STATS_NAME(ble_att_stats, mtu_rsp_tx)
   +STATS_NAME(ble_att_stats, find_info_req_rx)
   +STATS_NAME(ble_att_stats, find_info_req_tx)
   +STATS_NAME(ble_att_stats, find_info_rsp_rx)
   +STATS_NAME(ble_att_stats, find_info_rsp_tx)
   +STATS_NAME(ble_att_stats, find_type_value_req_rx)
   +STATS_NAME(ble_att_stats, find_type_value_req_tx)
   +STATS_NAME(ble_att_stats, find_type_value_rsp_rx)
   +STATS_NAME(ble_att_stats, find_type_value_rsp_tx)
   +STATS_NAME(ble_att_stats, read_type_req_rx)
   +STATS_NAME(ble_att_stats, read_type_req_tx)
   +STATS_NAME(ble_att_stats, read_type_rsp_rx)
   +STATS_NAME(ble_att_stats, read_type_rsp_tx)
   +STATS_NAME(ble_att_stats, read_req_rx)
   +STATS_NAME(ble_att_stats, read_req_tx)
   +STATS_NAME(ble_att_stats, read_rsp_rx)
   +STATS_NAME(ble_att_stats, read_rsp_tx)
   +STATS_NAME(ble_att_stats, read_blob_req_rx)
   +STATS_NAME(ble_att_stats, read_blob_req_tx)
   +STATS_NAME(ble_att_stats, read_blob_rsp_rx)
   +STATS_NAME(ble_att_stats, read_blob_rsp_tx)
   +STATS_NAME(ble_att_stats, read_mult_req_rx)
   +STATS_NAME(ble_att_stats, read_mult_req_tx)
   +STATS_NAME(ble_att_stats, read_mult_rsp_rx)
   +STATS_NAME(ble_att_stats, read_mult_rsp_tx)
   +STATS_NAME(ble_att_stats, read_group_type_req_rx)
   +STATS_NAME(ble_att_stats, read_group_type_req_tx)
   +STATS_NAME(ble_att_stats, read_group_type_rsp_rx)
   +STATS_NAME(ble_att_stats, read_group_type_rsp_tx)
   +STATS_NAME(ble_att_stats, write_req_rx)
   +STATS_NAME(ble_att_stats, write_req_tx)
   

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1432: Initial Github Action integration

[GitBox]

apache-mynewt-bot commented on PR #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432#issuecomment-1397737066

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2922: Initial Github Action integration

[GitBox]

apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1397695268

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1432: Initial Github Action integration

[GitBox]

apache-mynewt-bot commented on PR #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432#issuecomment-1397623248

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc commented on pull request #1432: Initial Github Action integration

[GitBox]

sjanc commented on PR #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432#issuecomment-1397621556

   verified locally with act


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1432: Initial Github Action integration

[GitBox]

sjanc opened a new pull request, #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432

   This adds:
- building all test targets on Linux
- runing 'newt test all'
- building dummy and Linux ports


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc opened a new issue, #1431: Add RAT check similar to core checks

[GitBox]

sjanc opened a new issue, #1431:
URL: https://github.com/apache/mynewt-nimble/issues/1431

   Should be implemented after migration to GH Actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc opened a new issue, #1430: Migrate from Travis to Github Actions

[GitBox]

sjanc opened a new issue, #1430:
URL: https://github.com/apache/mynewt-nimble/issues/1430

   - [ ] build test targets on Linux
   - [ ]  build test targets on Windows
   - [ ] build ports on Linux
   - [ ] style check
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] sjanc opened a new issue, #2923: Migrate from Travis to Github Actions

[GitBox]

sjanc opened a new issue, #2923:
URL: https://github.com/apache/mynewt-core/issues/2923

   - [ ] newt test all
   - [ ] blinky build for all BSPs 
   - [ ] build test targets on Linux
   - [ ] build test targets on Windows
   - [ ] style check
   - [ ] RAT check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1429: nimble/ll: Add missing definition of min and max macros

[GitBox]

apache-mynewt-bot commented on PR #1429:
URL: https://github.com/apache/mynewt-nimble/pull/1429#issuecomment-1397221924

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1429: nimble/ll: Add missing definition of min and max macros

[GitBox]

sjanc opened a new pull request, #1429:
URL: https://github.com/apache/mynewt-nimble/pull/1429

   Those were removed from headers to avoid conflicts with C++. Until we 
convert codebase to MIN/MAX macros just define those where needed.
   
   This was affecting RIOT port.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] rymanluk commented on issue #1421: When using COC server and send is stalled, disconnects are not detected

[GitBox]

rymanluk commented on issue #1421:
URL: https://github.com/apache/mynewt-nimble/issues/1421#issuecomment-1397101306

   Do you possibly have any logs to share?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2922: Initial Github Action integration

[GitBox]

apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1397061936

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

[GitBox]

apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1396809082

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

[GitBox]

apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1396655797

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_att_clt.c
   
   
   ```diff
   @@ -908,8 +906,8 @@
}


/*
   - * $multi handle value notification 
 *
   - 
*/
   +* $multi handle value notification  
*
   
+*/

int
ble_att_clt_tx_multi_notify(uint16_t conn_handle, struct ble_gatt_hv 
*tuples,
   @@ -977,8 +975,8 @@
}


/*
   - * $handle value indication 
 *
   - 
*/
   +* $handle value indication  
*
   
+*/

int
ble_att_clt_tx_indicate(uint16_t conn_handle, uint16_t handle,
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2922: Initial Github Action integration

[GitBox]

apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1396583877

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] sjanc commented on pull request #2922: Initial Github Action integration

[GitBox]

sjanc commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1396582342

   tested locally with 'act'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1428: Fixed a check in ble_att_clt_tx_prep_write() api

[GitBox]

apache-mynewt-bot commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1396493840

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

[GitBox]

apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1396446087

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_att_clt.c
   
   
   ```diff
   @@ -908,8 +906,8 @@
}


/
   -* $multi handle value notification  
*
   
-*/
   + * $multi handle value notification 
 *
   + 
*/

int
ble_att_clt_tx_multi_notify(uint16_t conn_handle, struct ble_gatt_hv 
*tuples,
   @@ -977,8 +975,8 @@
}


/
   -* $handle value indication  
*
   
-*/
   + * $handle value indication 
 *
   + 
*/

int
ble_att_clt_tx_indicate(uint16_t conn_handle, uint16_t handle,
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] rymanluk merged pull request #1427: ll: Fix compiler error

[GitBox]

rymanluk merged PR #1427:
URL: https://github.com/apache/mynewt-nimble/pull/1427


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2919: Add initial STM32H723ZG MCU support with external repos downloading

[GitBox]

apache-mynewt-bot commented on PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#issuecomment-1387382113

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/stm/stm32h7xx/src/system_stm32h7xx.c
   
   
   ```diff
   @@ -1,48 +1,48 @@
/**
   -  
**
   -  * @filesystem_stm32h7xx.c
   -  * @author  MCD Application Team
   -  * @brief   CMSIS Cortex-Mx Device Peripheral Access Layer System Source 
File.
   -  *
   -  *   This file provides two functions and one global variable to be called 
from
   -  *   user application:
   -  *  - SystemInit(): This function is called at startup just after 
reset and
   -  *  before branch to main program. This call is made 
inside
   -  *  the "startup_stm32h7xx.s" file.
   -  *
   -  *  - SystemCoreClock variable: Contains the core clock, it can be used
   -  *  by the user application to setup the 
SysTick
   -  *  timer or configure other parameters.
   -  *
   -  *  - SystemCoreClockUpdate(): Updates the variable SystemCoreClock 
and must
   -  * be called whenever the core clock is 
changed
   -  * during program execution.
   -  *
   -  *
   -  
**
   -  * @attention
   -  *
   -  * Copyright (c) 2017 STMicroelectronics.
   -  * All rights reserved.
   -  *
   -  * This software is licensed under terms that can be found in the LICENSE 
file
   -  * in the root directory of this software component.
   -  * If no LICENSE file comes with this software, it is provided AS-IS.
   -  *
   -  
**
   -  */
   + 
**
   + * @filesystem_stm32h7xx.c
   + * @author  MCD Application Team
   + * @brief   CMSIS Cortex-Mx Device Peripheral Access Layer System Source 
File.
   + *
   + *   This file provides two functions and one global variable to be called 
from
   + *   user application:
   + *  - SystemInit(): This function is called at startup just after reset 
and
   + *  before branch to main program. This call is made 
inside
   + *  the "startup_stm32h7xx.s" file.
   + *
   + *  - SystemCoreClock variable: Contains the core clock, it can be used
   + *  by the user application to setup the 
SysTick
   + *  timer or configure other parameters.
   + *
   + *  - SystemCoreClockUpdate(): Updates the variable SystemCoreClock and 
must
   + * be called whenever the core clock is 
changed
   + * during program execution.
   + *
   + *
   + 
**
   + * @attention
   + *
   + * Copyright (c) 2017 STMicroelectronics.
   + * All rights reserved.
   + *
   + * This software is licensed under terms that can be found in the LICENSE 
file
   + * in the root directory of this software component.
   + * If no LICENSE file comes with this software, it is provided AS-IS.
   + *
   + 
**
   + */

/** @addtogroup CMSIS
   -  * @{
   -  */
   + * @{
   + */

/** @addtogroup stm32h7xx_system
   -  * @{
   -  */
   + * @{
   + */

/** @addtogroup STM32H7xx_System_Private_Includes
   -  * @{
   -  */
   + * @{
   + */

#include "bsp/stm32h7xx_hal_conf.h"
#include "stm32h7xx.h"
   ```
   
   
   
    hw/mcu/stm/stm32_common/src/stm32_driver_mod_spi.c
   
   
   ```diff
   @@ -56,94 +57,92 @@
#if defined(STM32L152xC)
#include "stm32l1xx_hal.h"

   -HAL_StatusTypeDef HAL_SPI_Init(SPI_HandleTypeDef *hspi)
   -{
   -  /* Check the SPI handle allocation */
   -  if (hspi == NULL)
   -  {
   -return HAL_ERROR;
   -  }
   -
   -  /* Check the parameters */
   -  assert_param(IS_SPI_ALL_INSTANCE(hspi->Instance));
   -  assert_param(IS_SPI_MODE(hspi->Init.Mode));
   -  assert_param(IS_SPI_DATASIZE(hspi->Init.DataSize));
   -  assert_param(IS_SPI_CPOL(hspi->Init.CLKPolarity));
   -  assert_param(IS_SPI_CPHA(hspi->Init.CLKPhase));
   -  assert_param(IS_SPI_NSS(hspi->Init.NSS));
   -  assert_param(IS_SPI_BAUDRATE_PRESCALER(hspi->Init.BaudRatePrescaler));
   -  assert_param(IS_SPI_FIRST_BIT(hspi->Init.FirstBit));
   -
   -  hspi->Init.CRCCalculation = SPI_CRCCALCULATION_DISABLE;
   -  hspi->Init.CRCPolynomial = 1;
   -
   -  if (hspi->State == HAL_SPI_STATE_RESET)
   -  {
   -/* Allocate lock resource and 

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1428: Fixed a check in ble_att_clt_tx_prep_write() api

[GitBox]

apache-mynewt-bot commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1387374434

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] IshaESP commented on pull request #1428: Fixed a check in ble_att_clt_tx_prep_write() api

[GitBox]

IshaESP commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1387115322

   Hi @sjanc ,
   Can you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] IshaESP opened a new pull request, #1428: Fixed a check in ble_att_clt_tx_prep_write() api

[GitBox]

IshaESP opened a new pull request, #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428

   If application is going to send data more than MTU size using 
ble_gattc_write_long(), after sending first batch of data of MTU size the 
offset gets incremented by (MTU - BLE_ATT_PREP_WRITE_CMD_BASE_SZ). This check 
will always fail in that case, as offset will be equal to (MTU - 
BLE_ATT_PREP_WRITE_CMD_BASE_SZ), and (offset + OS_MBUF_PKTLEN(txom)) will 
always be greater than BLE_ATT_ATTR_MAX_LEN. Thus failing to send the whole 
data.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nffs] sjanc merged pull request #20: Remove travis integration

[GitBox]

sjanc merged PR #20:
URL: https://github.com/apache/mynewt-nffs/pull/20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nffs] sjanc opened a new pull request, #20: Remove travis integration

[GitBox]

sjanc opened a new pull request, #20:
URL: https://github.com/apache/mynewt-nffs/pull/20

   ASF is moving away from Travis towards GithubAction. Since this repo is 
mostly abandonned for now just disable travis. If needed (unlikely) we can add 
GHA in future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2919: Add initial STM32H723ZG MCU support with external repos downloading

[GitBox]

apache-mynewt-bot commented on PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#issuecomment-1385573128

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/stm/stm32h7xx/src/hal_timer_freq.c
   
   
   ```diff
   @@ -101,10 +101,10 @@
case (uintptr_t)TIM14:
#endif
#ifdef TIM23
   -case (uintptr_t)TIM23:
   +case (uintptr_t)TIM23:
#endif
#ifdef TIM24
   -case (uintptr_t)TIM24:
   +case (uintptr_t)TIM24:
#endif
freq = HAL_RCC_GetPCLK1Freq();
div = stm32_hal_timer_abp_clk_div(clocks.APB1CLKDivider);
   ```
   
   
   
    hw/mcu/stm/stm32h7xx/src/system_stm32h7xx.c
   
   
   ```diff
   @@ -1,48 +1,48 @@
/**
   -  
**
   -  * @filesystem_stm32h7xx.c
   -  * @author  MCD Application Team
   -  * @brief   CMSIS Cortex-Mx Device Peripheral Access Layer System Source 
File.
   -  *
   -  *   This file provides two functions and one global variable to be called 
from
   -  *   user application:
   -  *  - SystemInit(): This function is called at startup just after 
reset and
   -  *  before branch to main program. This call is made 
inside
   -  *  the "startup_stm32h7xx.s" file.
   -  *
   -  *  - SystemCoreClock variable: Contains the core clock, it can be used
   -  *  by the user application to setup the 
SysTick
   -  *  timer or configure other parameters.
   -  *
   -  *  - SystemCoreClockUpdate(): Updates the variable SystemCoreClock 
and must
   -  * be called whenever the core clock is 
changed
   -  * during program execution.
   -  *
   -  *
   -  
**
   -  * @attention
   -  *
   -  * Copyright (c) 2017 STMicroelectronics.
   -  * All rights reserved.
   -  *
   -  * This software is licensed under terms that can be found in the LICENSE 
file
   -  * in the root directory of this software component.
   -  * If no LICENSE file comes with this software, it is provided AS-IS.
   -  *
   -  
**
   -  */
   + 
**
   + * @filesystem_stm32h7xx.c
   + * @author  MCD Application Team
   + * @brief   CMSIS Cortex-Mx Device Peripheral Access Layer System Source 
File.
   + *
   + *   This file provides two functions and one global variable to be called 
from
   + *   user application:
   + *  - SystemInit(): This function is called at startup just after reset 
and
   + *  before branch to main program. This call is made 
inside
   + *  the "startup_stm32h7xx.s" file.
   + *
   + *  - SystemCoreClock variable: Contains the core clock, it can be used
   + *  by the user application to setup the 
SysTick
   + *  timer or configure other parameters.
   + *
   + *  - SystemCoreClockUpdate(): Updates the variable SystemCoreClock and 
must
   + * be called whenever the core clock is 
changed
   + * during program execution.
   + *
   + *
   + 
**
   + * @attention
   + *
   + * Copyright (c) 2017 STMicroelectronics.
   + * All rights reserved.
   + *
   + * This software is licensed under terms that can be found in the LICENSE 
file
   + * in the root directory of this software component.
   + * If no LICENSE file comes with this software, it is provided AS-IS.
   + *
   + 
**
   + */

/** @addtogroup CMSIS
   -  * @{
   -  */
   + * @{
   + */

/** @addtogroup stm32h7xx_system
   -  * @{
   -  */
   + * @{
   + */

/** @addtogroup STM32H7xx_System_Private_Includes
   -  * @{
   -  */
   + * @{
   + */

#include "bsp/stm32h7xx_hal_conf.h"
#include "stm32h7xx.h"
   ```
   
   
   
    hw/mcu/stm/stm32_common/src/stm32_driver_mod_spi.c
   
   
   ```diff
   @@ -56,94 +57,92 @@
#if defined(STM32L152xC)
#include "stm32l1xx_hal.h"

   -HAL_StatusTypeDef HAL_SPI_Init(SPI_HandleTypeDef *hspi)
   -{
   -  /* Check the SPI handle allocation */
   -  if (hspi == NULL)
   -  {
   -return HAL_ERROR;
   -  }
   -
   -  /* Check the parameters */
   -  assert_param(IS_SPI_ALL_INSTANCE(hspi->Instance));
   -  assert_param(IS_SPI_MODE(hspi->Init.Mode));
   -  assert_param(IS_SPI_DATASIZE(hspi->Init.DataSize));
   -  

[GitHub] [mynewt-nimble] Rubeer commented on issue #1170: GAP callback when receiving HCI completed packets

[GitBox]

Rubeer commented on issue #1170:
URL: https://github.com/apache/mynewt-nimble/issues/1170#issuecomment-1384268778

   I have a similar application. One problem is that BLE_GAP_EVENT_NOTIFY_TX  
is not called at a helpful time.
   It seems to be called directly from inside the send function (e.g. 
`ble_gattc_notify_custom`), and not when the actual data is sent. This can even 
cause crashes due to recursion if you try to send more data from that callback.
   
   For example, if you naively implement a stream using this event as feedback, 
you could get a callstack looking something like this:
   ble_gattc_notify_custom -> ble_gap_event -> ble_gattc_notify_custom -> 
ble_gap_event -> ble_gattc_notify_custom -> (stack overflow)
   
   Ideally there should be a separate "application tx flow control" callback 
that would:
   
   - Always be called _just before_ the connection interval.
   - Supply information about how much data is already queued in the controller 
and host. We want to keep these buffers/queues mostly empty to get the lowest 
latency.
   
   The goal here is that after receiving this callback, the application can 
fill up a packet up to the MTU size, and have it be sent right away. This setup 
would give you the lowest latency while maintaining decent throughput.
   
   Right now I am thinking of just hacking in my own callback somewhere around 
`ble_hs_hci_evt_num_completed_pkts` as well.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2922: Initial Github Action integration

[GitBox]

apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1384077057

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2922: Initial Github Action integration

[GitBox]

apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1384076192

   
   
   
   ## RAT Report (2023-01-16 13:38:26)
   
   ## New files with unknown licenses
   
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/da1469x_flash_loader/pkg.yml;>targets/da1469x_flash_loader/pkg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/da1469x_flash_loader/syscfg.yml;>targets/da1469x_flash_loader/syscfg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/da1469x_flash_loader/target.yml;>targets/da1469x_flash_loader/target.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_advertiser/pkg.yml;>targets/nordic_pca10056_advertiser/pkg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_advertiser/target.yml;>targets/nordic_pca10056_advertiser/target.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blecent/pkg.yml;>targets/nordic_pca10056_blecent/pkg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blecent/target.yml;>targets/nordic_pca10056_blecent/target.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blecsc/pkg.yml;>targets/nordic_pca10056_blecsc/pkg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blecsc/target.yml;>targets/nordic_pca10056_blecsc/target.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blehci/pkg.yml;>targets/nordic_pca10056_blehci/pkg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blehci/target.yml;>targets/nordic_pca10056_blehci/target.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blehci_strict_sched/pkg.yml;>targets/nordic_pca10056_blehci_strict_sched/pkg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blehci_strict_sched/syscfg.yml;>targets/nordic_pca10056_blehci_strict_sched/syscfg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blehci_strict_sched/target.yml;>targets/nordic_pca10056_blehci_strict_sched/target.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blehr/pkg.yml;>targets/nordic_pca10056_blehr/pkg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blehr/target.yml;>targets/nordic_pca10056_blehr/target.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blemesh/pkg.yml;>targets/nordic_pca10056_blemesh/pkg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blemesh/target.yml;>targets/nordic_pca10056_blemesh/target.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blemesh_cdb/pkg.yml;>targets/nordic_pca10056_blemesh_cdb/pkg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blemesh_cdb/syscfg.yml;>targets/nordic_pca10056_blemesh_cdb/syscfg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blemesh_cdb/target.yml;>targets/nordic_pca10056_blemesh_cdb/target.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blemesh_ext_adv/pkg.yml;>targets/nordic_pca10056_blemesh_ext_adv/pkg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blemesh_ext_adv/syscfg.yml;>targets/nordic_pca10056_blemesh_ext_adv/syscfg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blemesh_ext_adv/target.yml;>targets/nordic_pca10056_blemesh_ext_adv/target.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blemesh_light/pkg.yml;>targets/nordic_pca10056_blemesh_light/pkg.yml
   * https://github.com/apache/mynewt-core/blob/ebc1b384522a42a21bb3f150a9fff3883dad3074/targets/nordic_pca10056_blemesh_light/target.yml;>targets/nordic_pca10056_blemesh_light/target.yml
   * 

[GitHub] [mynewt-core] andrzej-kaczmarek merged pull request #2918: hw/mcu/nrf5340: Add missing #include

[GitBox]

andrzej-kaczmarek merged PR #2918:
URL: https://github.com/apache/mynewt-core/pull/2918


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] kasjer commented on a diff in pull request #2916: Update depracted clock source settings

[GitBox]

kasjer commented on code in PR #2916:
URL: https://github.com/apache/mynewt-core/pull/2916#discussion_r1071123581


##
hw/mcu/nordic/nrf51xxx/syscfg.yml:
##
@@ -97,32 +97,49 @@ syscfg.defs:
 description: 'reference mV in VDD if used'
 value: 0
 
-# The XTAL_xxx definitions are used to set the clock source used for the low
-# frequency clock. It is required that at least one of these sources is
-# enabled (the bsp should set one of these clock sources).
+MCU_LFCLK_SOURCE:
+description: >
+Selected source for low frequency clock (LFCLK).
+value:
+choices:
+- LFRC  # 32.768 kHz RC oscillator
+- LFXO  # 32.768 kHz crystal oscillator
+- LFSYNTH   # 32.768 kHz synthesized from HFCLK
+
+# Deprecated settings
+
 XTAL_32768:
-description: 'External 32k oscillator LF clock source.'
+description: Use MCU_LFCLK_SOURCE instead

Review Comment:
   I would be more specific in description:
   ```yml
   description: Use "MCU_LFCLK_SOURCE: LXFO" instead
   ```



##
hw/mcu/nordic/nrf51xxx/syscfg.yml:
##
@@ -97,32 +97,49 @@ syscfg.defs:
 description: 'reference mV in VDD if used'
 value: 0
 
-# The XTAL_xxx definitions are used to set the clock source used for the low
-# frequency clock. It is required that at least one of these sources is
-# enabled (the bsp should set one of these clock sources).
+MCU_LFCLK_SOURCE:
+description: >
+Selected source for low frequency clock (LFCLK).
+value:
+choices:
+- LFRC  # 32.768 kHz RC oscillator
+- LFXO  # 32.768 kHz crystal oscillator
+- LFSYNTH   # 32.768 kHz synthesized from HFCLK
+
+# Deprecated settings
+
 XTAL_32768:
-description: 'External 32k oscillator LF clock source.'
+description: Use MCU_LFCLK_SOURCE instead
 value: 0
 restrictions:
-- "!XTAL_32768_SYNTH"
 - "!XTAL_RC"
-
+- "!XTAL_32768_SYNTH"

Review Comment:
   Why reverse line order?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] kasjer commented on a diff in pull request #2915: apps: Allow stub/full implementation of packages in syscfg

[GitBox]

kasjer commented on code in PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#discussion_r1071117722


##
apps/bleprph_oic/syscfg.yml:
##
@@ -25,6 +25,10 @@ syscfg.defs:
 value: 0
 
 syscfg.vals:
+CONSOLE_MODE: full

Review Comment:
   I would deprecate _MODE it was first attempt. Later on for logs 
_IMPLEMENTATION was chosen as it more clear what it does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] sjanc commented on a diff in pull request #2915: apps: Allow stub/full implementation of packages in syscfg

[GitBox]

sjanc commented on code in PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#discussion_r1071116754


##
apps/bleprph_oic/syscfg.yml:
##
@@ -25,6 +25,10 @@ syscfg.defs:
 value: 0
 
 syscfg.vals:
+CONSOLE_MODE: full

Review Comment:
   I'm fine with renaming this to CONSOLE_IMPLEMENTATION to keep things 
consistent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1427: ll: Fix compiler error

[GitBox]

apache-mynewt-bot commented on PR #1427:
URL: https://github.com/apache/mynewt-nimble/pull/1427#issuecomment-1383870947

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] andrzej-kaczmarek merged pull request #2921: hw/mcu/nrf53: Enable DCDC on VREGH

[GitBox]

andrzej-kaczmarek merged PR #2921:
URL: https://github.com/apache/mynewt-core/pull/2921


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] kasjer commented on a diff in pull request #2919: Add initial STM32H723ZG MCU support with external repos downloading

[GitBox]

kasjer commented on code in PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#discussion_r1067124630


##
hw/bsp/nucleo-h723zg/bsp.yml:
##
@@ -0,0 +1,72 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+bsp.name: "NUCLEO-H723ZG"
+bsp.url: https://www.st.com/en/evaluation-tools/nucleo-h723zg.html
+bsp.maker: "STMicroelectronics"
+bsp.arch: cortex_m7
+bsp.compiler: compiler/arm-none-eabi-m7
+bsp.linkerscript:
+- "hw/bsp/nucleo-h723zg/nucleo-h723zg.ld"
+- "@apache-mynewt-core/hw/mcu/stm/stm32h7xx/stm32h723.ld"
+bsp.linkerscript.BOOT_LOADER.OVERWRITE:
+- "hw/bsp/nucleo-h723zg/boot-nucleo-h723zg.ld"
+- "@apache-mynewt-core/hw/mcu/stm/stm32h7xx/stm32h723.ld"
+bsp.downloadscript: "hw/bsp/nucleo-h723zg/nucleo-h723zg_download.sh"
+bsp.debugscript: "hw/bsp/nucleo-h723zg/nucleo-h723zg_debug.sh"
+bsp.downloadscript.WINDOWS.OVERWRITE: 
"hw/bsp/nucleo-h723zg/nucleo-h723zg_download.cmd"
+bsp.debugscript.WINDOWS.OVERWRITE: 
"hw/bsp/nucleo-h723zg/nucleo-h723zg_debug.cmd"

Review Comment:
   Not needed anymore. .cmd files can be removed.



##
hw/bsp/nucleo-h723zg/src/hal_bsp.c:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#include 
+
+#include "bsp/bsp.h"
+#include "os/mynewt.h"
+#include "spiflash/spiflash.h"
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+
+#if MYNEWT_VAL(ETH_0)
+#include 
+#include 
+#endif
+
+#if MYNEWT_VAL(PWM_0) || MYNEWT_VAL(PWM_1) || MYNEWT_VAL(PWM_2)
+#include 
+#endif
+
+#if MYNEWT_VAL(PWM_0)
+struct stm32_pwm_conf os_bsp_pwm0_cfg = {
+.tim = TIM3,
+.irq = TIM3_IRQn,
+};
+#endif
+#if MYNEWT_VAL(PWM_1)
+struct stm32_pwm_conf os_bsp_pwm1_cfg = {
+.tim = TIM4,
+.irq = TIM4_IRQn,
+};
+#endif
+#if MYNEWT_VAL(PWM_2)
+struct stm32_pwm_conf os_bsp_pwm2_cfg = {
+.tim = TIM11,
+.irq = TIM1_TRG_COM_TIM11_IRQn,
+};
+#endif
+
+int dupa = 6;
+
+/* FIXME: this works but shouldn't it be dual bank? */
+const uint32_t stm32_flash_sectors[] = {
+0x0800, /* 32kB  */
+0x08008000, /* 32kB  */
+0x0801, /* 32kB  */
+0x08018000, /* 32kB  */
+0x0802, /* 128kB */
+0x0804, /* 256kB */
+0x0808, /* 256kB */
+0x080c, /* 256kB */
+0x0810, /* 256kB */
+0x0814, /* 256kB */
+0x0818, /* 256kB */
+0x081c, /* 256kB */

Review Comment:
   This should have 8 sectors 128kB each



##
hw/bsp/nucleo-h723zg/src/hal_bsp.c:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#include 
+
+#include "bsp/bsp.h"
+#include "os/mynewt.h"
+#include "spiflash/spiflash.h"
+

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1427: ll: Fix compiler error

[GitBox]

apache-mynewt-bot commented on PR #1427:
URL: https://github.com/apache/mynewt-nimble/pull/1427#issuecomment-1381695239

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.

[GitBox]

apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1381685268

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2921: hw/mcu/nrf53: Enable DCDC on VREGH

[GitBox]

apache-mynewt-bot commented on PR #2921:
URL: https://github.com/apache/mynewt-core/pull/2921#issuecomment-1381646337

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] rymanluk opened a new pull request, #1427: ll: Fix compiler error

[GitBox]

rymanluk opened a new pull request, #1427:
URL: https://github.com/apache/mynewt-nimble/pull/1427

   Fixing false possitive compiler error
   
   
/home/rymek/projects/bletiny_proj/repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:456:12:
 error: array subscript  is outside array bounds of 'struct 
ble_ll_scan_advertisers[0]' 
[␛]8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Warray-bounds␇-Werror=array-bounds␛]8;;␇]
 456 | memcpy(>adv_addr, addr, BLE_DEV_ADDR_LEN);


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] andrzej-kaczmarek opened a new pull request, #2921: hw/mcu/nrf53: Enable DCDC on VREGH

[GitBox]

andrzej-kaczmarek opened a new pull request, #2921:
URL: https://github.com/apache/mynewt-core/pull/2921

   If high voltage mode is used, we should also enable DCDC on VREGH.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

[GitBox]

apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1381400815

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_att_clt.c
   
   
   ```diff
   @@ -908,8 +906,8 @@
}


/*
   - * $multi handle value notification 
 *
   - 
*/
   +* $multi handle value notification  
*
   
+*/

int
ble_att_clt_tx_multi_notify(uint16_t conn_handle, struct ble_gatt_hv 
*tuples,
   @@ -919,7 +917,7 @@
return BLE_HS_ENOTSUP;
#endif

   -struct os_mbuf* txom;
   +struct os_mbuf * txom;
struct ble_gatt_hv *tpl = tuples;
int rc;
uint16_t num = num_tuples;
   @@ -977,8 +975,8 @@
}


/*
   - * $handle value indication 
 *
   - 
*/
   +* $handle value indication  
*
   
+*/

int
ble_att_clt_tx_indicate(uint16_t conn_handle, uint16_t handle,
   ```
   
   
   
    nimble/host/src/ble_att_svr.c
   
   
   ```diff
   @@ -2519,13 +2519,13 @@
#if !MYNEWT_VAL(BLE_ATT_SVR_MULTI_NOTIFY)
return BLE_HS_ENOTSUP;
#endif
   -
   +
struct ble_gatt_hv tuple;
uint16_t value_len;
int rc;
int offset = 0;
int datalen = (*rxom)->om_len;
   -
   +
while (offset < datalen) {
memset(, 0, sizeof tuple);

   ```
   
   
   
    nimble/host/src/ble_gattc.c
   
   
   ```diff
   @@ -4233,7 +4233,7 @@

int rc;
int num = num_tuples;
   -struct ble_gatt_hv* tpl = tuples;
   +struct ble_gatt_hv * tpl = tuples;

STATS_INC(ble_gattc_stats, multi_notify);
ble_gattc_log_multi_notify(tuples, num_tuples);
   @@ -4241,8 +4241,8 @@
while (num) {
if (tpl->value == NULL) {
/* No custom attribute data; read the value from the specified
   -* attribute
   -*/
   + * attribute
   + */
tpl->value = ble_hs_mbuf_att_pkt();
if (tpl->value == NULL) {
rc = BLE_HS_ENOMEM;
   @@ -4283,7 +4283,7 @@

return rc;
}
   -
   +

/**
 * Deprecated. Should not be used. Use ble_gatts_notify_custom instead.
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] SumeetSingh19 opened a new pull request, #1426: NimBLE/Host: Feature Multi Handle Value Notification

[GitBox]

SumeetSingh19 opened a new pull request, #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426

   Added new feature to send and receive multi handle value notifications.
   Spec: ATT_MULTIPLE_HANDLE_VALUE_NTF (Vol 3, Part F, 3.4.7.4)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-mcumgr] szenglein-gessler opened a new issue, #165: SMP Client library

[GitBox]

szenglein-gessler opened a new issue, #165:
URL: https://github.com/apache/mynewt-mcumgr/issues/165

   Hi, 
   
   Is there an implementation that helps me create and parse SMP messages for a 
client?  Could I use this library for that purpose?
   
   I want to send SMP/mcumgr commands without going through the mcumgr CLI.  
Ideally it would expose the same features as the cli, but with a C api.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.

[GitBox]

apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1379966011

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2919: Add initial STM32H723ZG MCU support with external repos downloading

[GitBox]

apache-mynewt-bot commented on PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#issuecomment-1379239271

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/stm/stm32_common/src/stm32_driver_mod_spi.c
   
   
   ```diff
   @@ -699,7 +700,7 @@
}

/* Enable TXE, RXNE and ERR interrupt */
   -//__HAL_SPI_ENABLE_IT(hspi, (SPI_IT_TXE | SPI_IT_RXNE | SPI_IT_ERR));
   +/*__HAL_SPI_ENABLE_IT(hspi, (SPI_IT_TXE | SPI_IT_RXNE | SPI_IT_ERR)); */

/* MYNEWT: in slave mode write 1st byte to DR */
#if !MYNEWT_VAL(MCU_STM32H7)
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2919: Add initial STM32H723ZG MCU support with external repos downloading

[GitBox]

apache-mynewt-bot commented on PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#issuecomment-1378836922

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/stm/stm32_common/src/stm32_driver_mod_spi.c
   
   
   ```diff
   @@ -699,7 +700,7 @@
}

/* Enable TXE, RXNE and ERR interrupt */
   -//__HAL_SPI_ENABLE_IT(hspi, (SPI_IT_TXE | SPI_IT_RXNE | SPI_IT_ERR));
   +/*__HAL_SPI_ENABLE_IT(hspi, (SPI_IT_TXE | SPI_IT_RXNE | SPI_IT_ERR)); */

/* MYNEWT: in slave mode write 1st byte to DR */
#if !MYNEWT_VAL(MCU_STM32H7)
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.

[GitBox]

apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1378792885

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/include/host/ble_gatt.h
   
   
   ```diff
   @@ -477,7 +477,8 @@
/**
 * Deprecated. Should not be used. Use ble_gatts_notify_custom instead.
 */
   -int ble_gattc_notify_custom(uint16_t conn_handle, uint16_t att_handle, 
struct os_mbuf *om) NIMBLE_DEPRECATED("Use ble_gatts_notify_custom instead.");
   +int ble_gattc_notify_custom(uint16_t conn_handle, uint16_t att_handle, 
struct os_mbuf *om) NIMBLE_DEPRECATED(
   +"Use ble_gatts_notify_custom instead.");

/**
 * Sends a characteristic notification.  The content of the message is read
   @@ -517,7 +518,8 @@
/**
 * Deprecated. Should not be used. Use ble_gatts_indicate_custom instead.
 */
   -int ble_gattc_indicate_custom(uint16_t conn_handle, uint16_t 
chr_val_handle, struct os_mbuf *txom) NIMBLE_DEPRECATED("Use 
ble_gatts_indicate_custom instead.");
   +int ble_gattc_indicate_custom(uint16_t conn_handle, uint16_t 
chr_val_handle, struct os_mbuf *txom) NIMBLE_DEPRECATED(
   +"Use ble_gatts_indicate_custom instead.");

/**
 * Sends a characteristic indication.  The content of the message is read 
from
   @@ -536,7 +538,8 @@
/**
 * Deprecated. Should not be used. Use ble_gatts_indicate instead.
 */
   -int ble_gattc_indicate(uint16_t conn_handle, uint16_t chr_val_handle) 
NIMBLE_DEPRECATED("Use ble_gatts_indicate instead.");
   +int ble_gattc_indicate(uint16_t conn_handle, uint16_t chr_val_handle) 
NIMBLE_DEPRECATED(
   +"Use ble_gatts_indicate instead.");

int ble_gattc_init(void);

   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] IshaESP commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.

[GitBox]

IshaESP commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1066725095


##
nimble/host/include/host/ble_hs.h:
##
@@ -184,6 +184,22 @@ extern "C" {
 
 /** CSRK distibution and LinkKey are not supported */
 
+/**
+ * @}
+ */
+
+/**
+ * @brief LE deprecate warning
+ *
+ * @{
+ */
+
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-newt] m-gorecki opened a new pull request, #498: Copy pkg.deps field when using "target copy"

[GitBox]

m-gorecki opened a new pull request, #498:
URL: https://github.com/apache/mynewt-newt/pull/498

   Now using the command "target copy" will copy the field pkg.deps into the 
destination target.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] andrzej-kaczmarek merged pull request #2920: hw/mcu/nrf53: Request hfxo for lfsynth via api

[GitBox]

andrzej-kaczmarek merged PR #2920:
URL: https://github.com/apache/mynewt-core/pull/2920


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2920: hw/mcu/nrf53: Request hfxo for lfsynth via api

[GitBox]

apache-mynewt-bot commented on PR #2920:
URL: https://github.com/apache/mynewt-core/pull/2920#issuecomment-1376514245

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] andrzej-kaczmarek opened a new pull request, #2920: hw/mcu/nrf53: Request hfxo for lfsynth via api

[GitBox]

andrzej-kaczmarek opened a new pull request, #2920:
URL: https://github.com/apache/mynewt-core/pull/2920

   We need to request hfxo via API to make sure ref is held all the time, 
otherwise any other request/release will stop hfxo and thus break lfsynth.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] vovagorodok commented on issue #1416: LOG_LEVEL defines collision

[GitBox]

vovagorodok commented on issue #1416:
URL: https://github.com/apache/mynewt-nimble/issues/1416#issuecomment-1374537886

   What do You think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc merged pull request #1424: nimble/ll: Fix not being able to get back to default DLE values

[GitBox]

sjanc merged PR #1424:
URL: https://github.com/apache/mynewt-nimble/pull/1424


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc merged pull request #1425: nimble/ll: Allow to tune time needed for scheduling next conn event

[GitBox]

sjanc merged PR #1425:
URL: https://github.com/apache/mynewt-nimble/pull/1425


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] novumdun closed pull request #1406: nimble/ll: Fix compile errors

[GitBox]

novumdun closed pull request #1406: nimble/ll: Fix compile errors
URL: https://github.com/apache/mynewt-nimble/pull/1406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-newt] sjanc merged pull request #496: Don't do shallow clone on default

[GitBox]

sjanc merged PR #496:
URL: https://github.com/apache/mynewt-newt/pull/496


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-newtmgr] m-gorecki commented on a diff in pull request #192: Fix not working MTU exchange on newer versions of mac

[GitBox]

m-gorecki commented on code in PR #192:
URL: https://github.com/apache/mynewt-newtmgr/pull/192#discussion_r1052005242


##
newtmgr/bll/bll_common.go:
##
@@ -53,18 +53,25 @@ func exchangeMtu(cln ble.Client, preferredMtu uint16) 
(uint16, error) {
break
}
 
-   // If macOS returned a value other than 23, then MTU exchange 
has
+   // If macOS returned a value higher than 23, then MTU exchange 
has
// completed.
-   if mtu != bledefs.BLE_ATT_MTU_DFLT {
+   if mtu > bledefs.BLE_ATT_MTU_DFLT {
break
}
 
// Otherwise, give the OS some time to perform the exchange.
-   log.Debugf("macOS reports an MTU of 23.  " +
+   log.Debugf("macOS reports an MTU of <=23.  " +
"Assume exchange hasn't completed; wait and requery.")
time.Sleep(time.Second)
}
 
+   // On some versions of mac (e.g. monterey) workaround with
+   // looping three times seems to not work anymore. If after
+   // performing three loops MTU is still <=23 than hardcode it to 185.
+   if mtu <= bledefs.BLE_ATT_MTU_DFLT {

Review Comment:
   Fixed it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1425: nimble/ll: Allow to tune time needed for scheduling next conn event

[GitBox]

apache-mynewt-bot commented on PR #1425:
URL: https://github.com/apache/mynewt-nimble/pull/1425#issuecomment-1371466198

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] tannewt commented on a diff in pull request #1425: nimble/ll: Allow to tune time needed for scheduling next conn event

[GitBox]

tannewt commented on code in PR #1425:
URL: https://github.com/apache/mynewt-nimble/pull/1425#discussion_r1061871362


##
nimble/controller/syscfg.yml:
##
@@ -537,6 +537,15 @@ syscfg.defs:
 range: 1..257
 value: 32
 
+BLE_LL_CONN_EVENT_END_MARGIN:
+description: >
+Extra time needed for scheduling next connection event. Setting 
this
+value results in ending connection event sonner (in us) which gives

Review Comment:
   ```suggestion
   value results in ending connection event sooner (in 
microseconds) which gives
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1425: nimble/ll: Allow to tune time needed for scheduling next conn event

[GitBox]

apache-mynewt-bot commented on PR #1425:
URL: https://github.com/apache/mynewt-nimble/pull/1425#issuecomment-1371045875

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1425: nimble/ll: Allow to tune time needed for scheduling next conn event

[GitBox]

sjanc opened a new pull request, #1425:
URL: https://github.com/apache/mynewt-nimble/pull/1425

   This works by allowing to shorten connection event end time by specified 
number of us. This value should be tuned only after measuring performance as 
depends on various factors like build optimisation, cache, clock speed etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc closed pull request #1422: nimble/ll: Make default Resolve List size match HW supported size

[GitBox]

sjanc closed pull request #1422: nimble/ll: Make default Resolve List size 
match HW supported size
URL: https://github.com/apache/mynewt-nimble/pull/1422


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2919: Add initial STM32H723ZG MCU support with external repos downloading

[GitBox]

apache-mynewt-bot commented on PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#issuecomment-1369080223

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/stm/stm32_common/src/stm32_driver_mod_spi.c
   
   
   ```diff
   @@ -699,7 +700,7 @@
}

/* Enable TXE, RXNE and ERR interrupt */
   -//__HAL_SPI_ENABLE_IT(hspi, (SPI_IT_TXE | SPI_IT_RXNE | SPI_IT_ERR));
   +/*__HAL_SPI_ENABLE_IT(hspi, (SPI_IT_TXE | SPI_IT_RXNE | SPI_IT_ERR)); */

/* MYNEWT: in slave mode write 1st byte to DR */
#if !MYNEWT_VAL(MCU_STM32H7)
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] m-gorecki opened a new pull request, #2919: Add initial STM32H723ZG MCU support with external repos downloading

[GitBox]

m-gorecki opened a new pull request, #2919:
URL: https://github.com/apache/mynewt-core/pull/2919

   This adds initial Nucleo-H723ZG BSP and STM32H723ZG MCU support, but it uses 
new feature implemented to Newt, which is ability to download external 
repositories that do not contain project.yml file. This way we do not have to 
add hundreds of files from ST's repository to the core. In order for this to 
work you have to build Newt from this commit:
   

 and later add this to your project.yml file:
   
   repository.stm32h7:
   type: github
   vers: 68f3d2c0002489bd232963aeeaf9a58668befe7a-commit
   user: STMicroelectronics
   repo: STM32CubeH7
   
   After doing so you can run "newt upgrade" and try it out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] m-gorecki closed pull request #2910: Add initial STM32H723ZG MCU support

[GitBox]

m-gorecki closed pull request #2910: Add initial STM32H723ZG MCU support
URL: https://github.com/apache/mynewt-core/pull/2910


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-newt] m-gorecki opened a new pull request, #497: Allow to download external repos without project.yml file

[GitBox]

m-gorecki opened a new pull request, #497:
URL: https://github.com/apache/mynewt-newt/pull/497

   This allows to download external repos like SDK packages, which do not 
contain project.yml files. Now we do not have to keep all of the SDKs in 
apache-mynewt-core repository. This also allows to use "@" syntax in 
the pkg.include_dirs and pkg.src_dirs fields to add source/include files from 
specified folders from external repos.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2915: apps: Allow stub/full implementation of packages in syscfg

[GitBox]

apache-mynewt-bot commented on PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#issuecomment-1367924434

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2915: apps: Allow stub/full implementation of packages in syscfg

[GitBox]

apache-mynewt-bot commented on PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#issuecomment-1367909628

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2915: apps: Allow stub/full implementation of packages in syscfg

[GitBox]

apache-mynewt-bot commented on PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#issuecomment-1367909371

   
   
   
   ## RAT Report (2022-12-30 13:05:51)
   
   ## New files with unknown licenses
   
   * https://github.com/apache/mynewt-core/blob/1338fc8e9c1363cf69917234dbd5d15132ccbc22/sys/stats/pkg.yml;>sys/stats/pkg.yml
   * https://github.com/apache/mynewt-core/blob/1338fc8e9c1363cf69917234dbd5d15132ccbc22/sys/stats/syscfg.yml;>sys/stats/syscfg.yml
   
   ## 5 new files were excluded from check (.rat-excludes)
   
   
 Detailed analysis
   
   ## New files in this PR
   
   | License | File |
   |-|--|
   | AL | https://github.com/apache/mynewt-core/blob/a6e0e7b18ecca9be36a6491b7114762a99cddc3a/apps/ffs2native/syscfg.yml;>apps/ffs2native/syscfg.yml
 |
   | AL | https://github.com/apache/mynewt-core/blob/a6e0e7b18ecca9be36a6491b7114762a99cddc3a/apps/pwm_test/syscfg.yml;>apps/pwm_test/syscfg.yml
 |
   | AL | https://github.com/apache/mynewt-core/blob/a6e0e7b18ecca9be36a6491b7114762a99cddc3a/apps/rust_blinky/syscfg.yml;>apps/rust_blinky/syscfg.yml
 |
   | ?  | https://github.com/apache/mynewt-core/blob/1338fc8e9c1363cf69917234dbd5d15132ccbc22/sys/stats/pkg.yml;>sys/stats/pkg.yml
 |
   | ?  | https://github.com/apache/mynewt-core/blob/1338fc8e9c1363cf69917234dbd5d15132ccbc22/sys/stats/syscfg.yml;>sys/stats/syscfg.yml
 |
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2916: Update depracted clock source settings

[GitBox]

apache-mynewt-bot commented on PR #2916:
URL: https://github.com/apache/mynewt-core/pull/2916#issuecomment-1367896872

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1424: nimble/ll: Fix not being able to get back to default DLE values

[GitBox]

apache-mynewt-bot commented on PR #1424:
URL: https://github.com/apache/mynewt-nimble/pull/1424#issuecomment-1367392464

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1424: nimble/ll: Fix not being able to get back to default DLE values

[GitBox]

apache-mynewt-bot commented on PR #1424:
URL: https://github.com/apache/mynewt-nimble/pull/1424#issuecomment-1366804586

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1424: nimble/ll: Fix not being able to get back to default DLE values

[GitBox]

apache-mynewt-bot commented on PR #1424:
URL: https://github.com/apache/mynewt-nimble/pull/1424#issuecomment-1366794889

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/controller/src/ble_ll_ctrl.c
   
   
   ```diff
   @@ -2097,53 +2096,53 @@
(connsm->max_tx_time <= BLE_LL_CONN_SUPP_TIME_MIN) &&
(connsm->max_rx_time <= BLE_LL_CONN_SUPP_TIME_MIN)) {
return;
   -} else {
   -if ((connsm->max_tx_octets < BLE_LL_CONN_SUPP_BYTES_MIN) &&
   -(connsm->max_rx_octets < BLE_LL_CONN_SUPP_BYTES_MIN) &&
   -(connsm->max_tx_time < BLE_LL_CONN_SUPP_TIME_MIN) &&
   -(connsm->max_rx_time < BLE_LL_CONN_SUPP_TIME_MIN)) {
   -return;
   -}
   -
   -ble_ll_ctrl_proc_start(connsm, BLE_LL_CTRL_PROC_DATA_LEN_UPD, NULL);
   -}
   -
   -static void
   -ble_ll_ctrl_update_features(struct ble_ll_conn_sm *connsm, uint8_t *feat)
   -{
   -connsm->conn_features = feat[0];
   -memcpy(connsm->remote_features, feat + 1, 7);
   -
   -/* If we received peer's features for the 1st time, we should try DLE */
   -if (!connsm->csmflags.cfbit.rxd_features) {
   +} else {
   +if ((connsm->max_tx_octets < BLE_LL_CONN_SUPP_BYTES_MIN) &&
   +(connsm->max_rx_octets < BLE_LL_CONN_SUPP_BYTES_MIN) &&
   +(connsm->max_tx_time < BLE_LL_CONN_SUPP_TIME_MIN) &&
   +(connsm->max_rx_time < BLE_LL_CONN_SUPP_TIME_MIN)) {
   +return;
   +}
   +
   +ble_ll_ctrl_proc_start(connsm, BLE_LL_CTRL_PROC_DATA_LEN_UPD, 
NULL);
   +}
   +
   +static void
   +ble_ll_ctrl_update_features(struct ble_ll_conn_sm *connsm, uint8_t 
*feat)
   +{
   +connsm->conn_features = feat[0];
   +memcpy(connsm->remote_features, feat + 1, 7);
   +
   +/* If we received peer's features for the 1st time, we should 
try DLE */
   +if (!connsm->csmflags.cfbit.rxd_features) {
#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LE_CODED_PHY)
   -/*
   - * If connection was established on uncoded PHY, by default we use
   - * MaxTxTime and MaxRxTime applicable for that PHY since we are not
   - * allowed to indicate longer supported time if peer does not 
support
   - * LE Coded PHY. However, once we know that peer does support it we 
can
   - * update those values to ones applicable for coded PHY.
   - */
   -if (ble_ll_conn_rem_feature_check(connsm, 
BLE_LL_FEAT_LE_CODED_PHY)) {
   -if (connsm->host_req_max_tx_time) {
   -connsm->max_tx_time = max(connsm->max_tx_time,
   +/*
   + * If connection was established on uncoded PHY, by default 
we use
   + * MaxTxTime and MaxRxTime applicable for that PHY since we 
are not
   + * allowed to indicate longer supported time if peer does 
not support
   + * LE Coded PHY. However, once we know that peer does 
support it we can
   + * update those values to ones applicable for coded PHY.
   + */
   +if (ble_ll_conn_rem_feature_check(connsm, 
BLE_LL_FEAT_LE_CODED_PHY)) {
   +if (connsm->host_req_max_tx_time) {
   +connsm->max_tx_time = max(connsm->max_tx_time,
  connsm->host_req_max_tx_time);
   -} else {
   -connsm->max_tx_time = 
g_ble_ll_conn_params.conn_init_max_tx_time_coded;
   -}
   -if (connsm->host_req_max_rx_time) {
   -connsm->max_rx_time = max(connsm->max_rx_time,
   +} else {
   +connsm->max_tx_time = 
g_ble_ll_conn_params.conn_init_max_tx_time_coded;
   +}
   +if (connsm->host_req_max_rx_time) {
   +connsm->max_rx_time = max(connsm->max_rx_time,
  connsm->host_req_max_rx_time);
   -} else {
   -connsm->max_rx_time = BLE_LL_CONN_SUPP_TIME_MAX_CODED;
   -}
   -}
   -#endif
   -
   -connsm->csmflags.cfbit.pending_initiate_dle = 1;
   -connsm->csmflags.cfbit.rxd_features = 1;
   -}
   -}
   +} else {
   +connsm->max_rx_time = 
BLE_LL_CONN_SUPP_TIME_MAX_CODED;
   +}
   +}
   +#endif
   +
   +connsm->csmflags.cfbit.pending_initiate_dle = 1;
   +connsm->csmflags.cfbit.rxd_features = 1;
   +}
   +}

/**
 * Called when we receive a feature request or a peripheral initiated 
feature
   @@ -2746,320 +2745,320 

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1424: nimble/ll: Fix not being able to get back to default DLE values

[GitBox]

sjanc opened a new pull request, #1424:
URL: https://github.com/apache/mynewt-nimble/pull/1424

   If new DLE parameters were matching default values DLE update procedure was 
not started.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1406: nimble/ll: Fix compile errors

[GitBox]

apache-mynewt-bot commented on PR #1406:
URL: https://github.com/apache/mynewt-nimble/pull/1406#issuecomment-1366427081

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1423: nimble/phy/nrf5x: Fix PA for tx-tx transition

[GitBox]

andrzej-kaczmarek merged PR #1423:
URL: https://github.com/apache/mynewt-nimble/pull/1423


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1423: nimble/phy/nrf5x: Fix PA for tx-tx transition

[GitBox]

apache-mynewt-bot commented on PR #1423:
URL: https://github.com/apache/mynewt-nimble/pull/1423#issuecomment-1363899489

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] andrzej-kaczmarek merged pull request #2917: hw/mcu/nrf5340: Fix build with 6pf lfxo trim

[GitBox]

andrzej-kaczmarek merged PR #2917:
URL: https://github.com/apache/mynewt-core/pull/2917


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] andrzej-kaczmarek commented on a diff in pull request #2915: apps: Allow stub/full implementation of packages in syscfg

[GitBox]

andrzej-kaczmarek commented on code in PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#discussion_r1056253553


##
apps/bleprph_oic/pkg.yml:
##
@@ -30,10 +30,10 @@ pkg.deps:
 - "@apache-mynewt-nimble/nimble/host/services/gatt"
 - "@apache-mynewt-nimble/nimble/host/store/config"
 - "@apache-mynewt-nimble/nimble/transport"
-- "@apache-mynewt-core/sys/console/full"
-- "@apache-mynewt-core/sys/log/full"
+- "@apache-mynewt-core/sys/console/"

Review Comment:
   remove trailing `/`



##
apps/bleprph_oic/syscfg.yml:
##
@@ -25,6 +25,10 @@ syscfg.defs:
 value: 0
 
 syscfg.vals:
+CONSOLE_MODE: full

Review Comment:
   I do not recall if we have `CONSOLE_MODE` instead of 
`CONSOLE_IMPLEMENTATION` for a reason, but if it's just for 'historical 
reasons' we should add `CONSOLE_IMPLEMENTATION` and deprecate `CONSOLE_MODE`.
   
   @kasjer ^^ ?



##
sys/stats/pkg.yml:
##
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: sys/stats
+pkg.description: API common to both the full and stub log implementations.
+pkg.author: "Apache Mynewt "
+pkg.homepage: "http://mynewt.apache.org/;

Review Comment:
   https



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2918: hw/mcu/nrf5340: Add missing #include

[GitBox]

apache-mynewt-bot commented on PR #2918:
URL: https://github.com/apache/mynewt-core/pull/2918#issuecomment-1363857242

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1423: nimble/phy/nrf5x: Fix PA for tx-tx transition

[GitBox]

sjanc commented on code in PR #1423:
URL: https://github.com/apache/mynewt-nimble/pull/1423#discussion_r1056244315


##
nimble/drivers/nrf5x/src/ble_phy.c:
##
@@ -1096,6 +1096,11 @@ ble_phy_tx_end_isr(void)
 tx_time = NRF_TIMER0->CC[2] + tifs;
 /* Adjust for delay between EVENT_END and actual TX end time */
 tx_time += g_ble_phy_t_txenddelay[tx_phy_mode];
+
+#if PHY_USE_FEM_PA
+fem_time = tx_time - MYNEWT_VAL(BLE_FEM_PA_TURN_ON_US);

Review Comment:
   fem_time should now be under if PHY_USE_FEM



##
nimble/drivers/nrf5x/src/ble_phy.c:
##
@@ -1096,6 +1096,11 @@ ble_phy_tx_end_isr(void)
 tx_time = NRF_TIMER0->CC[2] + tifs;
 /* Adjust for delay between EVENT_END and actual TX end time */
 tx_time += g_ble_phy_t_txenddelay[tx_phy_mode];
+
+#if PHY_USE_FEM_PA
+fem_time = tx_time - MYNEWT_VAL(BLE_FEM_PA_TURN_ON_US);

Review Comment:
   fem_time should now be under #if PHY_USE_FEM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2917: hw/mcu/nrf5340: Fix build with 6pf lfxo trim

[GitBox]

apache-mynewt-bot commented on PR #2917:
URL: https://github.com/apache/mynewt-core/pull/2917#issuecomment-1363847144

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2917: hw/mcu/nrf5340: Fix build with 6pf lfxo trim

[GitBox]

apache-mynewt-bot commented on PR #2917:
URL: https://github.com/apache/mynewt-core/pull/2917#issuecomment-1363837027

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1423: nimble/phy/nrf5x: Fix PA for tx-tx transition

[GitBox]

apache-mynewt-bot commented on PR #1423:
URL: https://github.com/apache/mynewt-nimble/pull/1423#issuecomment-1363833962

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2916: Update depracted clock source settings

[GitBox]

apache-mynewt-bot commented on PR #2916:
URL: https://github.com/apache/mynewt-core/pull/2916#issuecomment-1363732947

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org