[GitHub] [mynewt-mcumgr] ErlendWithammerLux commented on issue #127: send image form one chip to another

2021-06-18 Thread GitBox
ErlendWithammerLux commented on issue #127: URL: https://github.com/apache/mynewt-mcumgr/issues/127#issuecomment-864008556 Thanks for the quick respons! Oh my, what rookie mistake! Okay I see, I'll start looking in to sending it directly then. -- This is an automated

[GitHub] [mynewt-nimble] tennten10 commented on issue #736: Issue in init and deInit of BLE and understanding of code

2021-06-18 Thread GitBox
tennten10 commented on issue #736: URL: https://github.com/apache/mynewt-nimble/issues/736#issuecomment-863548735 I'm having a similar issue when trying to deinit on esp32. I've traced it to ble_npl_sem_pend() inside the nimble_port_stop() function and it never gets past that. Were you

[GitHub] [mynewt-mcumgr] de-nordic commented on issue #127: send image form one chip to another

2021-06-18 Thread GitBox
de-nordic commented on issue #127: URL: https://github.com/apache/mynewt-mcumgr/issues/127#issuecomment-863991141 Hi, the offset is incorrect, you have counted bits not bytes, the correct offset is 12 (96/8). As far as I can tell, there is not other method to pass the image, with no

[GitHub] [mynewt-mcumgr] ErlendWithammerLux opened a new issue #127: send image form one chip to another

2021-06-18 Thread GitBox
ErlendWithammerLux opened a new issue #127: URL: https://github.com/apache/mynewt-mcumgr/issues/127 Hey! I'm trying to send an image from Slot 1 on the nrf9160dk_nrf9160 to Slot 1 on the nrf9160dk_52840. (on the nrf9160dk) Looking in the img_mgmt directory I didn't find any

[GitHub] [mynewt-nimble] kasjer opened a new pull request #992: ctype: Fix undefined behavior in ctype.h usage

2021-06-16 Thread GitBox
kasjer opened a new pull request #992: URL: https://github.com/apache/mynewt-nimble/pull/992 When parse.c is build against newlib nano following error shows up: iparse.c:304:20: error: array subscript has type 'char' [-Werror=char-subscripts] This can be easily fixed with

[GitHub] [mynewt-nimble] sjanc opened a new issue #991: get rid of nimble_opt_auto.h

2021-06-16 Thread GitBox
sjanc opened a new issue #991: URL: https://github.com/apache/mynewt-nimble/issues/991 Just use MYNET_VAL(FOO) directly or define nimble_opt_auto.h style config option locally in .c file This will allow to better match .h. and .c #ifdefs -- This is an automated message from the

[GitHub] [mynewt-nimble] sjanc opened a new issue #990: Add support for Eddystone and iBeacon over Extended Advertising

2021-06-16 Thread GitBox
sjanc opened a new issue #990: URL: https://github.com/apache/mynewt-nimble/issues/990 API should be extended with parameter for specifying which advertising instance should be configured for beacons. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mynewt-core] vrahane merged pull request #2614: nrf5340: Conditional Rev A errata 26 fix

2021-06-15 Thread GitBox
vrahane merged pull request #2614: URL: https://github.com/apache/mynewt-core/pull/2614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #124: Zephyr fixes

2021-06-15 Thread GitBox
de-nordic commented on pull request #124: URL: https://github.com/apache/mynewt-mcumgr/pull/124#issuecomment-861584931 @utzig @sjanc Sorry for inconvenience, can you look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [mynewt-mcumgr] de-nordic commented on a change in pull request #124: Zephyr fixes

2021-06-15 Thread GitBox
de-nordic commented on a change in pull request #124: URL: https://github.com/apache/mynewt-mcumgr/pull/124#discussion_r651889668 ## File path: cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c ## @@ -108,48 +108,23 @@ zephyr_img_mgmt_flash_area_id(int slot) break;

[GitHub] [mynewt-mcumgr] nvlsianpu commented on a change in pull request #124: Zephyr fixes

2021-06-15 Thread GitBox
nvlsianpu commented on a change in pull request #124: URL: https://github.com/apache/mynewt-mcumgr/pull/124#discussion_r651749652 ## File path: cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c ## @@ -108,48 +108,23 @@ zephyr_img_mgmt_flash_area_id(int slot) break;

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2615: max3107 shell

2021-06-15 Thread GitBox
kasjer commented on a change in pull request #2615: URL: https://github.com/apache/mynewt-core/pull/2615#discussion_r651663625 ## File path: hw/drivers/uart/max3107/max3107_0/pkg.yml ## @@ -0,0 +1,27 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [mynewt-core] kasjer merged pull request #2617: pic32: Fix tick timer handling

2021-06-15 Thread GitBox
kasjer merged pull request #2617: URL: https://github.com/apache/mynewt-core/pull/2617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-nimble] KKopyscinski opened a new issue #989: Multiple simultaneous connections cause reset after many PHY updates

2021-06-15 Thread GitBox
KKopyscinski opened a new issue #989: URL: https://github.com/apache/mynewt-nimble/issues/989 This was found using `blestress` app on nrf52840 DK. When test 7 (PHY updates from tx device - central) is executed it will cause silent restart during test 9 (connect and keep as many active

[GitHub] [mynewt-nimble] sjanc opened a new pull request #988: Fail on build if disabled feature is used

2021-06-15 Thread GitBox
sjanc opened a new pull request #988: URL: https://github.com/apache/mynewt-nimble/pull/988 This is initial work for https://github.com/apache/mynewt-nimble/issues/985. It covers mostly GAP roles. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2615: max3107 shell

2021-06-15 Thread GitBox
vrahane commented on a change in pull request #2615: URL: https://github.com/apache/mynewt-core/pull/2615#discussion_r651505831 ## File path: hw/drivers/uart/max3107/max3107_0/syscfg.yml ## @@ -0,0 +1,125 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #986: Blestress fixes

2021-06-15 Thread GitBox
KKopyscinski commented on pull request #986: URL: https://github.com/apache/mynewt-nimble/pull/986#issuecomment-861234131 All crashes are resolved - the only problem left is silent restart on RX side during test 9 if test 7 was executed before - for now, skip test 7. Reason of this

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2615: max3107 shell

2021-06-15 Thread GitBox
vrahane commented on a change in pull request #2615: URL: https://github.com/apache/mynewt-core/pull/2615#discussion_r651502556 ## File path: hw/drivers/uart/max3107/max3107_0/pkg.yml ## @@ -0,0 +1,27 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2615: max3107 shell

2021-06-15 Thread GitBox
vrahane commented on a change in pull request #2615: URL: https://github.com/apache/mynewt-core/pull/2615#discussion_r651501799 ## File path: hw/drivers/uart/max3107/max3107_0/pkg.yml ## @@ -0,0 +1,27 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [mynewt-core] kasjer opened a new pull request #2617: pic32: Fix tick timer handling

2021-06-14 Thread GitBox
kasjer opened a new pull request #2617: URL: https://github.com/apache/mynewt-core/pull/2617 Tick timer interrupt handler assumed it was execute before next tick interrupt should be fired. In case when interrupt was handled late (due to other interrupts or just blocked interrupt

[GitHub] [mynewt-core] vrahane commented on pull request #2614: nrf5340: Conditional Rev A errata 26 fix

2021-06-14 Thread GitBox
vrahane commented on pull request #2614: URL: https://github.com/apache/mynewt-core/pull/2614#issuecomment-860862209 @sjanc done, I have mentioned Errata 26 in the detailed commit message because it is needed for that. Kept the commit message generic enough. -- This is an automated

[GitHub] [mynewt-mcumgr] utzig commented on pull request #124: Zephyr fixes

2021-06-14 Thread GitBox
utzig commented on pull request #124: URL: https://github.com/apache/mynewt-mcumgr/pull/124#issuecomment-860852911 > @utzig Thanks for quick review! I will wait for @nvlsianpu approval! -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #124: Zephyr fixes

2021-06-14 Thread GitBox
de-nordic commented on pull request #124: URL: https://github.com/apache/mynewt-mcumgr/pull/124#issuecomment-860810894 @utzig Thanks for quick review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [mynewt-core] kasjer opened a new pull request #2616: i2s fixes

2021-06-14 Thread GitBox
kasjer opened a new pull request #2616: URL: https://github.com/apache/mynewt-core/pull/2616 Two fixes related to I2S. - NRF5x versions would assert when i2s_open and i2s_close were issued without transferring any data - i2s_write did not fill correctly sample count field in

[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #986: Blestress fixes

2021-06-14 Thread GitBox
KKopyscinski commented on pull request #986: URL: https://github.com/apache/mynewt-nimble/pull/986#issuecomment-859558048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [mynewt-core] vrahane commented on pull request #2614: nrf5340: Conditional Rev A errata 26 fix

2021-06-14 Thread GitBox
vrahane commented on pull request #2614: URL: https://github.com/apache/mynewt-core/pull/2614#issuecomment-859855921 @sjanc Can you please review ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [mynewt-core] vrahane merged pull request #2605: hw/drivers/uart: Add MAX3107 driver

2021-06-14 Thread GitBox
vrahane merged pull request #2605: URL: https://github.com/apache/mynewt-core/pull/2605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-mcumgr-cli] dakejahl commented on issue #20: ble Support on windows

2021-06-14 Thread GitBox
dakejahl commented on issue #20: URL: https://github.com/apache/mynewt-mcumgr-cli/issues/20#issuecomment-859899278 I am curious about this as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [mynewt-core] kasjer opened a new pull request #2615: max3107 shell

2021-06-14 Thread GitBox
kasjer opened a new pull request #2615: URL: https://github.com/apache/mynewt-core/pull/2615 This adds few commands for shell to manipulate registers of MAX3107. Second commit moves MAX3107_0 instance settings to separate package that will make it more clear what is instance and

[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #126: samples/smp_svr/zephyr: Update stack size

2021-06-14 Thread GitBox
de-nordic commented on pull request #126: URL: https://github.com/apache/mynewt-mcumgr/pull/126#issuecomment-859370494 Hi, please take a look @utzig , @nvlsianpu. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #126: samples/smp_svr/zephyr: Update stack size

2021-06-14 Thread GitBox
de-nordic opened a new pull request #126: URL: https://github.com/apache/mynewt-mcumgr/pull/126 The addition of image interpretation requires increase in stack size. Signed-off-by: Dominik Ermel -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mynewt-mcumgr] vrahane merged pull request #125: cmd/img_mgmt: Call dfu stop cb on erase

2021-06-14 Thread GitBox
vrahane merged pull request #125: URL: https://github.com/apache/mynewt-mcumgr/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-10 Thread GitBox
vrahane commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646181312 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2614: nrf5340: Conditional Rev A errata 26 fix

2021-06-10 Thread GitBox
vrahane commented on a change in pull request #2614: URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649485185 ## File path: hw/mcu/nordic/nrf5340/syscfg.yml ## @@ -25,13 +25,15 @@ syscfg.defs: - $notnull choices: -

[GitHub] [mynewt-mcumgr] vrahane opened a new pull request #125: cmd/img_mgmt: Call dfu stop cb on erase

2021-06-10 Thread GitBox
vrahane opened a new pull request #125: URL: https://github.com/apache/mynewt-mcumgr/pull/125 - DFU stop callback needs to be called when erase is performed, since the DFU state of the image gets cleared -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2614: nrf5340: Conditional Rev A errata 26 fix

2021-06-10 Thread GitBox
vrahane commented on a change in pull request #2614: URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649397245 ## File path: hw/mcu/nordic/nrf5340/syscfg.yml ## @@ -25,13 +25,15 @@ syscfg.defs: - $notnull choices: -

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2614: nrf5340: Conditional Rev A errata 26 fix

2021-06-10 Thread GitBox
vrahane commented on a change in pull request #2614: URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649397141 ## File path: hw/mcu/nordic/nrf5340/pkg.yml ## @@ -104,3 +104,10 @@ pkg.deps.I2C_3': pkg.deps.NRF5340_EMBED_NET_CORE: -

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2614: nrf5340: Conditional Rev A errata 26 fix

2021-06-10 Thread GitBox
vrahane commented on a change in pull request #2614: URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649380996 ## File path: hw/mcu/nordic/nrf5340/syscfg.yml ## @@ -25,13 +25,15 @@ syscfg.defs: - $notnull choices: -

[GitHub] [mynewt-core] kasjer commented on pull request #2605: hw/drivers/uart: Add MAX3107 driver

2021-06-10 Thread GitBox
kasjer commented on pull request #2605: URL: https://github.com/apache/mynewt-core/pull/2605#issuecomment-858539553 > Also, a basic CLI to query registers of the chip would be useful for debugging. I will add separate PR for that that. -- This is an automated message from the

[GitHub] [mynewt-core] kasjer commented on pull request #2605: hw/drivers/uart: Add MAX3107 driver

2021-06-10 Thread GitBox
kasjer commented on pull request #2605: URL: https://github.com/apache/mynewt-core/pull/2605#issuecomment-858539315 > So, the code looks really clean, we do need to handle errors in various places. I think adding STATS and LOG messages for figuring out what is going wrong would be helpful

[GitHub] [mynewt-core] sjanc commented on a change in pull request #2605: hw/drivers/uart: Add MAX3107 driver

2021-06-10 Thread GitBox
sjanc commented on a change in pull request #2605: URL: https://github.com/apache/mynewt-core/pull/2605#discussion_r649086710 ## File path: hw/drivers/uart/max3107/src/max3107.c ## @@ -0,0 +1,1090 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [mynewt-mcumgr] utzig merged pull request #123: img_mgmt: Add interpretation of "image" parameter

2021-06-10 Thread GitBox
utzig merged pull request #123: URL: https://github.com/apache/mynewt-mcumgr/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-mcumgr] de-nordic commented on a change in pull request #123: img_mgmt: Add interpretation of "image" parameter

2021-06-10 Thread GitBox
de-nordic commented on a change in pull request #123: URL: https://github.com/apache/mynewt-mcumgr/pull/123#discussion_r649070524 ## File path: cmd/img_mgmt/src/img_mgmt.c ## @@ -394,42 +394,49 @@ img_mgmt_upload(struct mgmt_ctxt *ctxt) .data_len = 0,

[GitHub] [mynewt-mcumgr] de-nordic commented on a change in pull request #123: img_mgmt: Add interpretation of "image" parameter

2021-06-10 Thread GitBox
de-nordic commented on a change in pull request #123: URL: https://github.com/apache/mynewt-mcumgr/pull/123#discussion_r649061301 ## File path: cmd/img_mgmt/src/img_mgmt.c ## @@ -394,42 +394,49 @@ img_mgmt_upload(struct mgmt_ctxt *ctxt) .data_len = 0,

[GitHub] [mynewt-mcumgr] utzig commented on a change in pull request #123: img_mgmt: Add interpretation of "image" parameter

2021-06-10 Thread GitBox
utzig commented on a change in pull request #123: URL: https://github.com/apache/mynewt-mcumgr/pull/123#discussion_r649044768 ## File path: cmd/img_mgmt/src/img_mgmt.c ## @@ -394,42 +394,49 @@ img_mgmt_upload(struct mgmt_ctxt *ctxt) .data_len = 0,

[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #124: Zephyr fixes

2021-06-10 Thread GitBox
de-nordic opened a new pull request #124: URL: https://github.com/apache/mynewt-mcumgr/pull/124 The PR is series of fixes that to the Zephyr fork that: - change slot selection logic in `img_mgmt_find_best_area_id` to just check if slot1 is available, as basically that was what the

[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #124: Zephyr fixes

2021-06-10 Thread GitBox
de-nordic commented on pull request #124: URL: https://github.com/apache/mynewt-mcumgr/pull/124#issuecomment-858466003 Please take a look @mlaz, @nvlsianpu , @utzig, Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #123: img_mgmt: Add interpretation of "image" parameter

2021-06-10 Thread GitBox
de-nordic commented on pull request #123: URL: https://github.com/apache/mynewt-mcumgr/pull/123#issuecomment-858453717 Hello :) @mlaz @nvlsianpu @utzig -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #123: img_mgmt: Add interpretation of "image" parameter

2021-06-10 Thread GitBox
de-nordic commented on pull request #123: URL: https://github.com/apache/mynewt-mcumgr/pull/123#issuecomment-858452954 Note: image 0 has been marked as auto-select; this is due to compatibility with current state as this is the number that is always being sent, if no override from `-n`

[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #123: img_mgmt: Add interpretation of "image" parameter

2021-06-10 Thread GitBox
de-nordic opened a new pull request #123: URL: https://github.com/apache/mynewt-mcumgr/pull/123 The commit extends img_mgmt_upload_req with image member that will be used to hold image number; it also adds code that picks the image number from update frame. Signed-off-by:

[GitHub] [mynewt-core] sjanc commented on a change in pull request #2614: nrf5340: Conditional Rev A errata 26 fix

2021-06-10 Thread GitBox
sjanc commented on a change in pull request #2614: URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r648922768 ## File path: hw/mcu/nordic/nrf5340/pkg.yml ## @@ -104,3 +104,10 @@ pkg.deps.I2C_3': pkg.deps.NRF5340_EMBED_NET_CORE: -

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2605: hw/drivers/uart: Add MAX3107 driver

2021-06-09 Thread GitBox
kasjer commented on a change in pull request #2605: URL: https://github.com/apache/mynewt-core/pull/2605#discussion_r648330590 ## File path: hw/drivers/uart/max3107/src/max3107.c ## @@ -0,0 +1,1090 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2605: hw/drivers/uart: Add MAX3107 driver

2021-06-09 Thread GitBox
kasjer commented on a change in pull request #2605: URL: https://github.com/apache/mynewt-core/pull/2605#discussion_r648328693 ## File path: hw/drivers/uart/max3107/src/max3107.c ## @@ -0,0 +1,1090 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [mynewt-nimble] KKopyscinski closed issue #586: l2cap coc: Add timer guard on the receiver side

2021-06-09 Thread GitBox
KKopyscinski closed issue #586: URL: https://github.com/apache/mynewt-nimble/issues/586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-nimble] KKopyscinski commented on issue #586: l2cap coc: Add timer guard on the receiver side

2021-06-09 Thread GitBox
KKopyscinski commented on issue #586: URL: https://github.com/apache/mynewt-nimble/issues/586#issuecomment-857532339 The problem with missing frames is solved: both host and controller are working fine. Blestress was just configured not well enough: setting `BLE_ACL_BUF_SIZE:

[GitHub] [mynewt-core] sjanc commented on a change in pull request #2605: hw/drivers/uart: Add MAX3107 driver

2021-06-09 Thread GitBox
sjanc commented on a change in pull request #2605: URL: https://github.com/apache/mynewt-core/pull/2605#discussion_r648027114 ## File path: hw/drivers/uart/max3107/src/max3107.c ## @@ -0,0 +1,1090 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [mynewt-core] vrahane opened a new pull request #2614: nrf5340: Conditional Rev A errata 26 fix

2021-06-08 Thread GitBox
vrahane opened a new pull request #2614: URL: https://github.com/apache/mynewt-core/pull/2614 - As per Errata 26, CTRL-AP: APPROTECT.DISABLE and SECUREAPPROTECT.DISABLE registers are not functional - So we need to conditionally disable its usage ** BEFORE ** A `HardFault`

[GitHub] [mynewt-nimble] haukepetersen opened a new pull request #987: l2cap: implement echo request-response procedure (l2cap ping)

2021-06-08 Thread GitBox
haukepetersen opened a new pull request #987: URL: https://github.com/apache/mynewt-nimble/pull/987 For doing run-time link quality assessment I am in the need of the echo request-response procedure provided by the L2CAP signalling layer. As of now, this functionality is not exposed

[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request #986: Blestress fixes

2021-06-08 Thread GitBox
KKopyscinski opened a new pull request #986: URL: https://github.com/apache/mynewt-nimble/pull/986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [mynewt-core] kasjer merged pull request #2613: mbedtls xc32 build fixes

2021-06-07 Thread GitBox
kasjer merged pull request #2613: URL: https://github.com/apache/mynewt-core/pull/2613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-nimble] sjanc opened a new issue #985: Unify handling of disabled/enabled features

2021-06-07 Thread GitBox
sjanc opened a new issue #985: URL: https://github.com/apache/mynewt-nimble/issues/985 Currently (depending on feature) enabling/disabling is done by either compile time #ifdef, returning BLE_HS_ENOTSUP in runtime for disabled features, or by wrapping one feature on top of other API.

[GitHub] [mynewt-mcumgr] de-nordic commented on issue #116: fs mgmt not working under zephyr 2.5

2021-06-07 Thread GitBox
de-nordic commented on issue #116: URL: https://github.com/apache/mynewt-mcumgr/issues/116#issuecomment-855749085 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [mynewt-mcumgr] niclas-ats closed issue #116: fs mgmt not working under zephyr 2.5

2021-06-07 Thread GitBox
niclas-ats closed issue #116: URL: https://github.com/apache/mynewt-mcumgr/issues/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-mcumgr] de-nordic commented on issue #116: fs mgmt not working under zephyr 2.5

2021-06-07 Thread GitBox
de-nordic commented on issue #116: URL: https://github.com/apache/mynewt-mcumgr/issues/116#issuecomment-855682090 @niclas-ats Can you close the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-06 Thread GitBox
vrahane commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646181312 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-06 Thread GitBox
vrahane commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646181312 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-06 Thread GitBox
vrahane commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646181312 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-06 Thread GitBox
kasjer commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646178323 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-06 Thread GitBox
vrahane commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646156719 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-06 Thread GitBox
kasjer commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646098298 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] vikrant-proxy commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-05 Thread GitBox
vikrant-proxy commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646035849 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] vikrant-proxy commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-05 Thread GitBox
vikrant-proxy commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646035849 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-05 Thread GitBox
kasjer commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646035573 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-05 Thread GitBox
vrahane commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646035421 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] vikrant-proxy commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-05 Thread GitBox
vikrant-proxy commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r646035100 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] kasjer opened a new pull request #2613: mbedtls xc32 build fixes

2021-06-05 Thread GitBox
kasjer opened a new pull request #2613: URL: https://github.com/apache/mynewt-core/pull/2613 This changes one instance of `#include ""` to `#include <>` to allow build with xc32-gcc compiler. This is really a issue in the xc32 compiler not **mbedtls** but it can be fixed by changing

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-04 Thread GitBox
vrahane commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r644776652 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] kasjer merged pull request #2612: pic32: Fix crt0.S build error

2021-06-04 Thread GitBox
kasjer merged pull request #2612: URL: https://github.com/apache/mynewt-core/pull/2612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-core] kasjer merged pull request #2612: pic32: Fix crt0.S build error

2021-06-03 Thread GitBox
kasjer merged pull request #2612: URL: https://github.com/apache/mynewt-core/pull/2612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-03 Thread GitBox
vrahane commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r644776652 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-03 Thread GitBox
vrahane commented on a change in pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r644776652 ## File path: hw/drivers/ram/spiram/src/spiram.c ## @@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev) int spiram_read(struct

[GitHub] [mynewt-core] kasjer opened a new pull request #2612: pic32: Fix crt0.S build error

2021-06-03 Thread GitBox
kasjer opened a new pull request #2612: URL: https://github.com/apache/mynewt-core/pull/2612 xc32 compiler version 3.xx starts to complain about constant value range Error: repos/apache-mynewt-core/kernel/os/src/arch/pic32/startup/crt0.S: Assembler messages:

[GitHub] [mynewt-core] kasjer opened a new pull request #2611: hw/drivers/spiram: Fix 4 bytes address handling

2021-06-03 Thread GitBox
kasjer opened a new pull request #2611: URL: https://github.com/apache/mynewt-core/pull/2611 Even though there is no 4 bytes addressing RAM out there, because syscfg allowed such value to be set update code to handle this case correctly to be future proof. Also restriction was

[GitHub] [mynewt-nimble] tanupattrin closed issue #984: New ble

2021-06-02 Thread GitBox
tanupattrin closed issue #984: URL: https://github.com/apache/mynewt-nimble/issues/984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-nimble] tanupattrin opened a new issue #984: New ble

2021-06-02 Thread GitBox
tanupattrin opened a new issue #984: URL: https://github.com/apache/mynewt-nimble/issues/984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [mynewt-nimble] Wth-Esp commented on issue #983: Suggest change the name of function `ble_gattc_notify` and `ble_gattc_notify_custom` into `ble_gatts_notify`and `ble_gatts_notify_custom`

2021-06-02 Thread GitBox
Wth-Esp commented on issue #983: URL: https://github.com/apache/mynewt-nimble/issues/983#issuecomment-853069174 @sjanc Yes, I'm willing to do this. Please wait for my updates, maybe I will change other mistakes by the way. When the PR is ready, I will close this issue, thanks for your

[GitHub] [mynewt-nimble] sjanc edited a comment on issue #983: Suggest change the name of function `ble_gattc_notify` and `ble_gattc_notify_custom` into `ble_gatts_notify`and `ble_gatts_notify_custom`

2021-06-02 Thread GitBox
sjanc edited a comment on issue #983: URL: https://github.com/apache/mynewt-nimble/issues/983#issuecomment-852908520 yes, this is currently named like that for historical reasons :) but I'm totally fine with adding wrappers with fixed names and marking old ones as deprecated. Would you

[GitHub] [mynewt-nimble] sjanc commented on issue #983: Suggest change the name of function `ble_gattc_notify` and `ble_gattc_notify_custom` into `ble_gatts_notify`and `ble_gatts_notify_custom`

2021-06-02 Thread GitBox
sjanc commented on issue #983: URL: https://github.com/apache/mynewt-nimble/issues/983#issuecomment-852908520 yes, this is currently for historical reasons :) but I'm totally fine with adding wrappers with fixed names and marking old ones as deprecated. Would you like to send such PR?

[GitHub] [mynewt-core] utzig merged pull request #2610: nxp: kinetis: decrease LPUART RAM usage

2021-06-01 Thread GitBox
utzig merged pull request #2610: URL: https://github.com/apache/mynewt-core/pull/2610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-core] utzig commented on a change in pull request #2610: nxp: kinetis: decrease LPUART RAM usage

2021-06-01 Thread GitBox
utzig commented on a change in pull request #2610: URL: https://github.com/apache/mynewt-core/pull/2610#discussion_r642969547 ## File path: hw/mcu/nxp/kinetis/src/hal_lpuart.c ## @@ -70,25 +70,112 @@ struct hal_uart { }; /* UART configurations */ -static struct hal_uart

[GitHub] [mynewt-core] utzig commented on a change in pull request #2610: nxp: kinetis: decrease LPUART RAM usage

2021-06-01 Thread GitBox
utzig commented on a change in pull request #2610: URL: https://github.com/apache/mynewt-core/pull/2610#discussion_r642968941 ## File path: hw/mcu/nxp/kinetis/src/hal_lpuart.c ## @@ -345,12 +433,15 @@ hal_uart_config(int port, { struct hal_uart *u; lpuart_config_t

[GitHub] [mynewt-core] utzig commented on a change in pull request #2610: nxp: kinetis: decrease LPUART RAM usage

2021-06-01 Thread GitBox
utzig commented on a change in pull request #2610: URL: https://github.com/apache/mynewt-core/pull/2610#discussion_r642968668 ## File path: hw/mcu/nxp/kinetis/src/hal_lpuart.c ## @@ -410,7 +501,8 @@ hal_uart_config(int port, uconfig.enableTx = true; uconfig.enableRx

[GitHub] [mynewt-nimble] Wth-Esp opened a new issue #983: Suggest change the name of function `ble_gattc_notify` and `ble_gattc_notify_custom` into `ble_gatts_notify`and `ble_gatts_notify_custom`

2021-06-01 Thread GitBox
Wth-Esp opened a new issue #983: URL: https://github.com/apache/mynewt-nimble/issues/983 Notify procedure can only be operated by GATT Server. So, I think the ble_gattc_notify is not a proper name for notify, it makes me confuse when I call this function to customize a notify from

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2610: nxp: kinetis: decrease LPUART RAM usage

2021-06-01 Thread GitBox
kasjer commented on a change in pull request #2610: URL: https://github.com/apache/mynewt-core/pull/2610#discussion_r642848845 ## File path: hw/mcu/nxp/kinetis/src/hal_lpuart.c ## @@ -345,12 +433,15 @@ hal_uart_config(int port, { struct hal_uart *u; lpuart_config_t

[GitHub] [mynewt-core] utzig opened a new pull request #2610: nxp: kinetis: decrease RAM usage

2021-05-31 Thread GitBox
utzig opened a new pull request #2610: URL: https://github.com/apache/mynewt-core/pull/2610 Refactor LPUart driver to only allocated RAM proportional to the number of enabled Uarts; each UART uses about 230 bytes for its state, so having a single UART enabled should provide a significant

[GitHub] [mynewt-core] kasjer merged pull request #2608: sys/log/stub: avoid unused parameter warning

2021-05-31 Thread GitBox
kasjer merged pull request #2608: URL: https://github.com/apache/mynewt-core/pull/2608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-core] fjmolinas commented on a change in pull request #2608: sys/log/stub: avoid unused parameter warning

2021-05-31 Thread GitBox
fjmolinas commented on a change in pull request #2608: URL: https://github.com/apache/mynewt-core/pull/2608#discussion_r642400949 ## File path: sys/log/stub/include/log/log.h ## @@ -43,38 +43,62 @@ static inline int log_register(const char *name, struct log *log, const struct

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2608: sys/log/stub: avoid unused parameter warning

2021-05-31 Thread GitBox
kasjer commented on a change in pull request #2608: URL: https://github.com/apache/mynewt-core/pull/2608#discussion_r642389808 ## File path: sys/log/stub/include/log/log.h ## @@ -43,38 +43,62 @@ static inline int log_register(const char *name, struct log *log, const struct

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2605: hw/drivers/uart: Add MAX3107 driver

2021-05-31 Thread GitBox
kasjer commented on a change in pull request #2605: URL: https://github.com/apache/mynewt-core/pull/2605#discussion_r642387668 ## File path: hw/drivers/uart/max3107/syscfg.yml ## @@ -0,0 +1,134 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2605: hw/drivers/uart: Add MAX3107 driver

2021-05-31 Thread GitBox
kasjer commented on a change in pull request #2605: URL: https://github.com/apache/mynewt-core/pull/2605#discussion_r642386685 ## File path: hw/drivers/uart/max3107/src/max3107.c ## @@ -0,0 +1,1059 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

  1   2   3   4   5   6   7   8   9   10   >