[GitHub] [mynewt-core] kasjer commented on a diff in pull request #2856: net/ip/native_socks: Fix build on with -Werror=stringop-overflow

2022-06-28 Thread GitBox
kasjer commented on code in PR #2856: URL: https://github.com/apache/mynewt-core/pull/2856#discussion_r908085008 ## net/ip/native_sockets/src/native_sock.c: ## @@ -196,7 +196,7 @@ native_sock_mn_addr_to_addr(struct mn_sockaddr *ms, struct sockaddr *sa, sun->sun_len =

[GitHub] [mynewt-core] kasjer merged pull request #2855: mcu/nrf5340: Trust zone RAM clean update

2022-06-28 Thread GitBox
kasjer merged PR #2855: URL: https://github.com/apache/mynewt-core/pull/2855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2856: net/ip/native_socks: Fix build on with -Werror=stringop-overflow

2022-06-27 Thread GitBox
apache-mynewt-bot commented on PR #2856: URL: https://github.com/apache/mynewt-core/pull/2856#issuecomment-1167639163 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-mcumgr] sjanc opened a new pull request, #162: cmd/img_mgmt: Fix compilation with dummy hash enabled

2022-06-27 Thread GitBox
sjanc opened a new pull request, #162: URL: https://github.com/apache/mynewt-mcumgr/pull/162 Hash len is 32 bytes. repos/apache-mynewt-mcumgr/cmd/img_mgmt/src/img_mgmt.c: In function ‘img_mgmt_read_info’: repos/apache-mynewt-mcumgr/cmd/img_mgmt/src/img_mgmt.c:122:9:

[GitHub] [mynewt-core] sjanc opened a new pull request, #2856: net/ip/native_socks: Fix build on with -Werror=stringop-overflow

2022-06-27 Thread GitBox
sjanc opened a new pull request, #2856: URL: https://github.com/apache/mynewt-core/pull/2856 Werror=stringop-overflow= seems to be now enabled by default on GCC 11. repos/apache-mynewt-core/net/ip/native_sockets/src/native_sock.c: In function ‘native_sock_mn_addr_to_addr’:

[GitHub] [mynewt-newt] kasjer commented on pull request #480: Add special repo designators to expand

2022-06-27 Thread GitBox
kasjer commented on PR #480: URL: https://github.com/apache/mynewt-newt/pull/480#issuecomment-1167335114 Works correct when @@ is used, tested with @@bin that can be used in pkg.lflags -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [mynewt-newt] kasjer merged pull request #481: Fix misleading error message for mfg raw

2022-06-27 Thread GitBox
kasjer merged PR #481: URL: https://github.com/apache/mynewt-newt/pull/481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] kasjer opened a new pull request, #2855: mcu/nrf5340: Trust zone RAM clean update

2022-06-27 Thread GitBox
kasjer opened a new pull request, #2855: URL: https://github.com/apache/mynewt-core/pull/2855 RAM_SIZE was always taken from bps.h. With trust zone in place it may be that the bootloader had limited RAM assigned in linker scripts. This may happen when MCU_BOOT_MEASURED_STARTUP is

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2855: mcu/nrf5340: Trust zone RAM clean update

2022-06-27 Thread GitBox
apache-mynewt-bot commented on PR #2855: URL: https://github.com/apache/mynewt-core/pull/2855#issuecomment-1167053315 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] sjanc merged pull request #1278: ble_conn: fix auth_pyld_timer memleak

2022-06-27 Thread GitBox
sjanc merged PR #1278: URL: https://github.com/apache/mynewt-nimble/pull/1278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-06-27 Thread GitBox
sjanc commented on code in PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#discussion_r907058949 ## nimble/host/src/ble_l2cap_coc.c: ## @@ -40,6 +41,10 @@ static os_membuf_t ble_l2cap_coc_srv_mem[ static struct os_mempool ble_l2cap_coc_srv_pool; +static

[GitHub] [mynewt-nimble] sjanc merged pull request #1280: nimble/ll:: Make LL task stack size configurable

2022-06-27 Thread GitBox
sjanc merged PR #1280: URL: https://github.com/apache/mynewt-nimble/pull/1280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-06-27 Thread GitBox
andrzej-kaczmarek commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1166976101 Host supported features can be set by `HCI LE Set Host Feature`. NimBLE host does not have support for connection subrating so it does not set that bit. -- This is

[GitHub] [mynewt-newt] kasjer opened a new pull request, #481: Fix misleading error message for mfg raw

2022-06-27 Thread GitBox
kasjer opened a new pull request, #481: URL: https://github.com/apache/mynewt-newt/pull/481 Code checked existence of "name" field in yaml file and when not found reports that "filename" was missing. Now correct missing filed is reported. -- This is an automated message from the

[GitHub] [mynewt-nimble] bvdberg commented on pull request #1278: ble_conn: fix auth_pyld_timer memleak

2022-06-27 Thread GitBox
bvdberg commented on PR #1278: URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1166917530 rebased on update master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1278: ble_conn: fix auth_pyld_timer memleak

2022-06-27 Thread GitBox
apache-mynewt-bot commented on PR #1278: URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1166916139 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] sada45 opened a new issue, #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-06-26 Thread GitBox
sada45 opened a new issue, #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291 Hi! I have tried the connection subrating in the Spec 5.3 and may found an issue. Before the central sends the `SUBRATE_IND`, it will check wether the peripheral has the

[GitHub] [mynewt-nimble] ynyn1996 commented on issue #1285: Ble Mesh需要考虑密钥的安全管理

2022-06-26 Thread GitBox
ynyn1996 commented on issue #1285: URL: https://github.com/apache/mynewt-nimble/issues/1285#issuecomment-1166712141 The public and private keys used by Ble Mesh during network distribution are automatically generated after the device is powered on and stored in global variables. They are

[GitHub] [mynewt-nimble] mtm509 closed issue #1277: bt_mesh_init等函数参数指针判空问题

2022-06-25 Thread GitBox
mtm509 closed issue #1277: bt_mesh_init等函数参数指针判空问题 URL: https://github.com/apache/mynewt-nimble/issues/1277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [mynewt-nimble] andrzej-kaczmarek closed issue #1289: g_ble_ll_conn_params.central_chan_map needs to be removed from apache-mynewt-nimble/nimble/controller/src/ble_ll_adv.c:1380

2022-06-24 Thread GitBox
andrzej-kaczmarek closed issue #1289: g_ble_ll_conn_params.central_chan_map needs to be removed from apache-mynewt-nimble/nimble/controller/src/ble_ll_adv.c:1380 URL: https://github.com/apache/mynewt-nimble/issues/1289 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1290: nimble/ll: Fix reference to global channel map

2022-06-24 Thread GitBox
andrzej-kaczmarek merged PR #1290: URL: https://github.com/apache/mynewt-nimble/pull/1290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] andrzej-kaczmarek merged pull request #2854: sys/console: Fix include for ble monitor

2022-06-24 Thread GitBox
andrzej-kaczmarek merged PR #2854: URL: https://github.com/apache/mynewt-core/pull/2854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] kasjer merged pull request #2848: mcu/nrf52: Handle APROTECT

2022-06-24 Thread GitBox
kasjer merged PR #2848: URL: https://github.com/apache/mynewt-core/pull/2848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1290: nimble/ll: Fix reference to global channel map

2022-06-24 Thread GitBox
apache-mynewt-bot commented on PR #1290: URL: https://github.com/apache/mynewt-nimble/pull/1290#issuecomment-1165475257 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1286: nimble/ll: Fix direct addr type for ext adv reports

2022-06-24 Thread GitBox
andrzej-kaczmarek merged PR #1286: URL: https://github.com/apache/mynewt-nimble/pull/1286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1289: g_ble_ll_conn_params.central_chan_map needs to be removed from apache-mynewt-nimble/nimble/controller/src/ble_ll_adv.c:1380

2022-06-24 Thread GitBox
andrzej-kaczmarek commented on issue #1289: URL: https://github.com/apache/mynewt-nimble/issues/1289#issuecomment-1165454881 https://github.com/apache/mynewt-nimble/pull/1290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [mynewt-nimble] t3zeng opened a new issue, #1289: g_ble_ll_conn_params.central_chan_map needs to be removed from apache-mynewt-nimble/nimble/controller/src/ble_ll_adv.c:1380

2022-06-24 Thread GitBox
t3zeng opened a new issue, #1289: URL: https://github.com/apache/mynewt-nimble/issues/1289 The central_chan_map seems to have been removed from `struct ble_ll_conn_global_params` so it should no longer be referenced ``` Error:

[GitHub] [mynewt-nimble] bvdberg commented on pull request #1278: ble_conn: fix auth_pyld_timer memleak

2022-06-24 Thread GitBox
bvdberg commented on PR #1278: URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1165411741 I'm not sure about that. I see that at start, all connections you define (Max-Connections) get created and the timer also. They are never freed, since the Max number of

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1282: nimble/ll: Fix race between conn event and created

2022-06-24 Thread GitBox
andrzej-kaczmarek merged PR #1282: URL: https://github.com/apache/mynewt-nimble/pull/1282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1281: nimble/ll: Fix race between aux scan and scan disable

2022-06-24 Thread GitBox
andrzej-kaczmarek merged PR #1281: URL: https://github.com/apache/mynewt-nimble/pull/1281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1283: nimble/ll/css: Fix conn create hci with css disabled

2022-06-24 Thread GitBox
andrzej-kaczmarek merged PR #1283: URL: https://github.com/apache/mynewt-nimble/pull/1283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1284: nimble/ll: Update manufacturer id settings

2022-06-24 Thread GitBox
andrzej-kaczmarek merged PR #1284: URL: https://github.com/apache/mynewt-nimble/pull/1284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc commented on pull request #1278: ble_conn: fix auth_pyld_timer memleak

2022-06-24 Thread GitBox
sjanc commented on PR #1278: URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1165306690 I'm fine with having this hotfixed as is (although the leak will stil be present on each HCI reset call, right?) in long term I think we need to expand npl api so that every

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1280: nimble/ll:: Make LL task stack size configurable

2022-06-24 Thread GitBox
apache-mynewt-bot commented on PR #1280: URL: https://github.com/apache/mynewt-nimble/pull/1280#issuecomment-1165298125 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1287: nimble/transport: Add missing prototype for ble_monitor_out

2022-06-24 Thread GitBox
andrzej-kaczmarek merged PR #1287: URL: https://github.com/apache/mynewt-nimble/pull/1287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc commented on issue #1285: Ble Mesh需要考虑密钥的安全管理

2022-06-24 Thread GitBox
sjanc commented on issue #1285: URL: https://github.com/apache/mynewt-nimble/issues/1285#issuecomment-1165273552 Hello, This forum is international so please use English when reporting issues -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1288: Adjusting SC pairing

2022-06-24 Thread GitBox
apache-mynewt-bot commented on PR #1288: URL: https://github.com/apache/mynewt-nimble/pull/1288#issuecomment-1165228605 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request, #1288: Adjusting SC pairing

2022-06-24 Thread GitBox
KKopyscinski opened a new pull request, #1288: URL: https://github.com/apache/mynewt-nimble/pull/1288 This contains 2 commits: 1. rename BLE_SM_SC_LVL to BLE_SM_LVL - this is not SC only setting, but legacy one too 2. Check for SC in pairing request when in SC Only mode -- This is

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2854: sys/console: Fix include for ble monitor

2022-06-23 Thread GitBox
apache-mynewt-bot commented on PR #2854: URL: https://github.com/apache/mynewt-core/pull/2854#issuecomment-1164864676 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1287: nimble/transport: Add missing prototype for ble_monitor_out

2022-06-23 Thread GitBox
apache-mynewt-bot commented on PR #1287: URL: https://github.com/apache/mynewt-nimble/pull/1287#issuecomment-1164862240 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1286: nimble/ll: Fix direct addr type for ext adv reports

2022-06-23 Thread GitBox
apache-mynewt-bot commented on PR #1286: URL: https://github.com/apache/mynewt-nimble/pull/1286#issuecomment-1164546528 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1286: nimble/ll: Fix direct addr type for ext adv reports

2022-06-23 Thread GitBox
andrzej-kaczmarek opened a new pull request, #1286: URL: https://github.com/apache/mynewt-nimble/pull/1286 If direct address was an RPA and controller was not able to resolve it, the direct address type in extended advertising report shall be set to 0xFE. This fixes

[GitHub] [mynewt-nimble] ynyn1996 opened a new issue, #1285: Ble Mesh需要考虑密钥的安全管理

2022-06-23 Thread GitBox
ynyn1996 opened a new issue, #1285: URL: https://github.com/apache/mynewt-nimble/issues/1285 Ble Mesh在配网阶段使用的公私钥在设备上电后主动生成,并保存在全局变量里,后续并未释放。是否需要遵循密钥安全管理,使用完后清除密钥对,在每次使用时再生成? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [mynewt-core] kasjer merged pull request #2851: Ambiq Apollo3: Utilize ram buffer to handle flash to flash memory writes

2022-06-23 Thread GitBox
kasjer merged PR #2851: URL: https://github.com/apache/mynewt-core/pull/2851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1284: nimble/ll: Update manufacturer id settings

2022-06-22 Thread GitBox
apache-mynewt-bot commented on PR #1284: URL: https://github.com/apache/mynewt-nimble/pull/1284#issuecomment-1163566268 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1283: nimble/ll/css: Fix conn create hci with css disabled

2022-06-22 Thread GitBox
apache-mynewt-bot commented on PR #1283: URL: https://github.com/apache/mynewt-nimble/pull/1283#issuecomment-1163534507 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1284: nimble/ll: Update manufacturer id settings

2022-06-22 Thread GitBox
andrzej-kaczmarek opened a new pull request, #1284: URL: https://github.com/apache/mynewt-nimble/pull/1284 Rename BLE_LL_MFRG_ID to more readable BLE_LL_MANUFACTURER_ID and change default value to id assigned to Apache Foundation (0x0B65). -- This is an automated message from the

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1283: nimble/ll/css: Fix conn create hci with css disabled

2022-06-22 Thread GitBox
andrzej-kaczmarek opened a new pull request, #1283: URL: https://github.com/apache/mynewt-nimble/pull/1283 Need to skip conn interval checks if css is disabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mynewt-nimble] mgagic commented on issue #1052: Crash when restoring bonding

2022-06-22 Thread GitBox
mgagic commented on issue #1052: URL: https://github.com/apache/mynewt-nimble/issues/1052#issuecomment-1163088870 Hi @flonas955, any luck with this? I think I'm facing the exact same issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1273: nimble/ll: Fixes for connection strict scheduling

2022-06-22 Thread GitBox
andrzej-kaczmarek merged PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] t3zeng commented on a diff in pull request #2851: Ambiq Apollo3: Utilize ram buffer to handle flash to flash memory writes

2022-06-22 Thread GitBox
t3zeng commented on code in PR #2851: URL: https://github.com/apache/mynewt-core/pull/2851#discussion_r903720138 ## hw/mcu/ambiq/apollo3/src/hal_flash.c: ## @@ -168,6 +168,32 @@ apollo3_flash_write(const struct hal_flash *dev, uint32_t address, return rc; } +static int

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1280: nimble/ll:: Make LL task stack size configurable

2022-06-22 Thread GitBox
apache-mynewt-bot commented on PR #1280: URL: https://github.com/apache/mynewt-nimble/pull/1280#issuecomment-1163019577 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1273: nimble/ll: Fixes for connection strict scheduling

2022-06-22 Thread GitBox
apache-mynewt-bot commented on PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273#issuecomment-1163017791 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] sjanc merged pull request #1274: tools/hci_throughput: additional HCI cmds, PHY fixes

2022-06-22 Thread GitBox
sjanc merged PR #1274: URL: https://github.com/apache/mynewt-nimble/pull/1274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc merged pull request #1276: Apollo3: Properly accumulate full ACL packet before sending to BLE controller

2022-06-22 Thread GitBox
sjanc merged PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2851: Ambiq Apollo3: Utilize ram buffer to handle flash to flash memory writes

2022-06-21 Thread GitBox
apache-mynewt-bot commented on PR #2851: URL: https://github.com/apache/mynewt-core/pull/2851#issuecomment-1162157516 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1282: nimble/ll: Fix race between conn event and created

2022-06-21 Thread GitBox
apache-mynewt-bot commented on PR #1282: URL: https://github.com/apache/mynewt-nimble/pull/1282#issuecomment-1162078858 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1282: nimble/ll: Fix race between conn event and created

2022-06-21 Thread GitBox
andrzej-kaczmarek opened a new pull request, #1282: URL: https://github.com/apache/mynewt-nimble/pull/1282 In rare cases it's possible that 1st connection event is fired before LL processed new connection, thus its state is set to idle. In such case we can just skip the event and LL

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1281: nimble/ll: Fix race between aux scan and scan disable

2022-06-21 Thread GitBox
apache-mynewt-bot commented on PR #1281: URL: https://github.com/apache/mynewt-nimble/pull/1281#issuecomment-1161784411 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1281: nimble/ll: Fix race between aux scan and scan disable

2022-06-21 Thread GitBox
andrzej-kaczmarek opened a new pull request, #1281: URL: https://github.com/apache/mynewt-nimble/pull/1281 It's possible that scheduled aux is being received while scan sm is being disabled. In such case aux should not be processed since it cannot be handled properly anyway. -- This

[GitHub] [mynewt-nimble] sjanc commented on issue #1277: bt_mesh_init等函数参数指针判空问题

2022-06-21 Thread GitBox
sjanc commented on issue #1277: URL: https://github.com/apache/mynewt-nimble/issues/1277#issuecomment-1161522158 Hello, This forum is international so please use English -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [mynewt-core] andrzej-kaczmarek merged pull request #2853: hw/bsp/dialog: Add missing #include

2022-06-21 Thread GitBox
andrzej-kaczmarek merged PR #2853: URL: https://github.com/apache/mynewt-core/pull/2853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] kasjer commented on a diff in pull request #2851: Ambiq Apollo3: Utilize ram buffer to handle flash to flash memory writes

2022-06-21 Thread GitBox
kasjer commented on code in PR #2851: URL: https://github.com/apache/mynewt-core/pull/2851#discussion_r902209722 ## hw/mcu/ambiq/apollo3/src/hal_flash.c: ## @@ -168,6 +168,32 @@ apollo3_flash_write(const struct hal_flash *dev, uint32_t address, return rc; } +static int

[GitHub] [mynewt-core] kasjer merged pull request #2852: mcu/nrf5340: Fill main stack with pattern

2022-06-21 Thread GitBox
kasjer merged PR #2852: URL: https://github.com/apache/mynewt-core/pull/2852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] wes3 merged pull request #2825: sys/log: Add clearing log to log command

2022-06-20 Thread GitBox
wes3 merged PR #2825: URL: https://github.com/apache/mynewt-core/pull/2825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2853: hw/bsp/dialog: Add missing #include

2022-06-20 Thread GitBox
apache-mynewt-bot commented on PR #2853: URL: https://github.com/apache/mynewt-core/pull/2853#issuecomment-1160634336 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1280: nimble/ll:: Make LL task stack size configurable

2022-06-20 Thread GitBox
apache-mynewt-bot commented on PR #1280: URL: https://github.com/apache/mynewt-nimble/pull/1280#issuecomment-1160624944 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-core] andrzej-kaczmarek opened a new pull request, #2853: hw/bsp/dialog: Add missing #include

2022-06-20 Thread GitBox
andrzej-kaczmarek opened a new pull request, #2853: URL: https://github.com/apache/mynewt-core/pull/2853 Need to include syscfg.h since it uses MYNEWT_VAL_CHOICE(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on pull request #1280: nimble/ll:: Make LL task stack size configurable

2022-06-20 Thread GitBox
andrzej-kaczmarek commented on PR #1280: URL: https://github.com/apache/mynewt-nimble/pull/1280#issuecomment-1160520414 why this is defined in phy instead of controller pkg? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1280: nimble/ll:: Make LL task stack size configurable

2022-06-20 Thread GitBox
sjanc opened a new pull request, #1280: URL: https://github.com/apache/mynewt-nimble/pull/1280 This commit makes LL stack size configurable. Depending on compiler and platform default value may not be enough. It was reported that on nRF52840 90 words is not enough even if Ext Adv is

[GitHub] [mynewt-nimble] sjanc opened a new issue, #1279: Add babblesim targets to CI

2022-06-20 Thread GitBox
sjanc opened a new issue, #1279: URL: https://github.com/apache/mynewt-nimble/issues/1279 CI should build babblesim targets and eventually also execute tests via edtt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1278: ble_conn: fix auth_pyld_timer memleak

2022-06-20 Thread GitBox
apache-mynewt-bot commented on PR #1278: URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1160012674 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] bvdberg opened a new pull request, #1278: ble_conn: fix auth_pyld_timer memleak

2022-06-20 Thread GitBox
bvdberg opened a new pull request, #1278: URL: https://github.com/apache/mynewt-nimble/pull/1278 Every time a connection is made, the ble_npl_callout_init() is done. This causes a timer creation in some NPL cases (eg. FreeRTOS). The alloc behaviour of auth_pyld_timer is now in sync

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1276: Apollo3: Properly accumulate full ACL packet before sending to BLE controller

2022-06-17 Thread GitBox
apache-mynewt-bot commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1159225064 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-core] benmccrea merged pull request #2846: sensors/bmp388: Add compatibility for bmp390

2022-06-17 Thread GitBox
benmccrea merged PR #2846: URL: https://github.com/apache/mynewt-core/pull/2846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1276: Apollo3: Properly accumulate full ACL packet before sending to BLE controller

2022-06-17 Thread GitBox
apache-mynewt-bot commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1159047040 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] t3zeng commented on pull request #1276: Apollo3: Properly accumulate full ACL packet before sending to BLE controller

2022-06-17 Thread GitBox
t3zeng commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1158957273 > It would not hurt to fix style check complaints Oh sorry, I thought it would apply itself. What's the easiest way to apply it? I was just going to copy it in as a patch and

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2852: mcu/nrf5340: Fill main stack with pattern

2022-06-17 Thread GitBox
apache-mynewt-bot commented on PR #2852: URL: https://github.com/apache/mynewt-core/pull/2852#issuecomment-1158914418 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] kasjer commented on pull request #1276: Apollo3: Properly accumulate full ACL packet before sending to BLE controller

2022-06-17 Thread GitBox
kasjer commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1158877690 It would not hurt to fix style check complaints -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mynewt-core] kasjer opened a new pull request, #2852: mcu/nrf5340: Fill main stack with pattern

2022-06-17 Thread GitBox
kasjer opened a new pull request, #2852: URL: https://github.com/apache/mynewt-core/pull/2852 Main stack is now filled with pattern at startup for better control of stack usage. Signed-off-by: Jerzy Kasenberg -- This is an automated message from the Apache Git Service. To

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2851: Ambiq Apollo3: Utilize ram buffer to handle flash to flash memory writes

2022-06-15 Thread GitBox
apache-mynewt-bot commented on PR #2851: URL: https://github.com/apache/mynewt-core/pull/2851#issuecomment-1156886227 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] t3zeng commented on pull request #2851: Ambiq Apollo3: Utilize ram buffer to handle flash to flash memory writes

2022-06-15 Thread GitBox
t3zeng commented on PR #2851: URL: https://github.com/apache/mynewt-core/pull/2851#issuecomment-1156884661 @kasjer @sjanc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [mynewt-core] t3zeng opened a new pull request, #2851: Ambiq Apollo3: Utilize ram buffer to handle flash to flash memory writes

2022-06-15 Thread GitBox
t3zeng opened a new pull request, #2851: URL: https://github.com/apache/mynewt-core/pull/2851 Ambiq's internal flash writing functionality does not allow for direct flash to flash memory transfers. This change handles situations like that by transferring to an intermediary ram buffer. --

[GitHub] [mynewt-core] kasjer merged pull request #2849: sensors/lsm6dsl: add tilt function

2022-06-15 Thread GitBox
kasjer merged PR #2849: URL: https://github.com/apache/mynewt-core/pull/2849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2849: sensors/lsm6dsl: add tilt function

2022-06-15 Thread GitBox
apache-mynewt-bot commented on PR #2849: URL: https://github.com/apache/mynewt-core/pull/2849#issuecomment-1156684742 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-15 Thread GitBox
apache-mynewt-bot commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1156672583 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1273: nimble/ll: Fixes for connection strict scheduling

2022-06-15 Thread GitBox
apache-mynewt-bot commented on PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273#issuecomment-1156592372 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] t3zeng commented on pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-15 Thread GitBox
t3zeng commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1156488759 > I would change first line of commit message(s) to reflect that changes are for apollo transport and are not a general fixes. No probs, I have added apollo3 to the commit

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-15 Thread GitBox
apache-mynewt-bot commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1156411150 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] jrotkiewicz commented on a diff in pull request #1273: nimble/ll: Fixes for connection strict scheduling

2022-06-15 Thread GitBox
jrotkiewicz commented on code in PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273#discussion_r897885422 ## nimble/controller/src/ble_ll_ctrl.c: ## @@ -416,6 +419,18 @@ ble_ll_ctrl_conn_upd_make(struct ble_ll_conn_sm *connsm, uint8_t *pyld, instant =

[GitHub] [mynewt-nimble] kasjer commented on pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-15 Thread GitBox
kasjer commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1156356897 I would change first line of commit message(s) to reflect that changes are for apollo transport and are not a general fixes. -- This is an automated message from the Apache Git

[GitHub] [mynewt-nimble] t3zeng commented on a diff in pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-15 Thread GitBox
t3zeng commented on code in PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897856568 ## nimble/transport/apollo3/src/apollo3_ble_hci.c: ## @@ -275,16 +255,22 @@ apollo3_ble_hci_acl_tx(struct os_mbuf *om) { struct os_mbuf *x; int rc = 0;

[GitHub] [mynewt-nimble] mtm509 commented on issue #1277: bt_mesh_init等函数参数指针判空问题

2022-06-15 Thread GitBox
mtm509 commented on issue #1277: URL: https://github.com/apache/mynewt-nimble/issues/1277#issuecomment-1156215724 bt_mesh_init 等众多向用户提供的接口,指针参数都没有判空 比如还有cfg_cli.h中很多接口,也没有对指针参数判空 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [mynewt-nimble] mtm509 opened a new issue, #1277: bt_mesh_init等函数参数指针判空问题

2022-06-15 Thread GitBox
mtm509 opened a new issue, #1277: URL: https://github.com/apache/mynewt-nimble/issues/1277 bt_mesh_init等好多向用户提供的接口,指针参数好多都没有判空 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [mynewt-nimble] kasjer commented on pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-15 Thread GitBox
kasjer commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1156120929 change verified to work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a diff in pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-15 Thread GitBox
andrzej-kaczmarek commented on code in PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897652865 ## nimble/transport/apollo3/src/apollo3_ble_hci.c: ## @@ -275,16 +255,22 @@ apollo3_ble_hci_acl_tx(struct os_mbuf *om) { struct os_mbuf *x;

[GitHub] [mynewt-nimble] kasjer commented on a diff in pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-15 Thread GitBox
kasjer commented on code in PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897587417 ## nimble/transport/apollo3/src/apollo3_ble_hci.c: ## @@ -275,16 +255,22 @@ apollo3_ble_hci_acl_tx(struct os_mbuf *om) { struct os_mbuf *x; int rc = 0;

[GitHub] [mynewt-core] kasjer merged pull request #2850: mempool: Fix OS_MEMPOOL_SIZE when OS_MEMPOOL_GUARD is on

2022-06-15 Thread GitBox
kasjer merged PR #2850: URL: https://github.com/apache/mynewt-core/pull/2850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] t3zeng commented on a diff in pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-14 Thread GitBox
t3zeng commented on code in PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897508630 ## nimble/transport/apollo3/src/apollo3_ble_hci.c: ## @@ -275,16 +255,22 @@ apollo3_ble_hci_acl_tx(struct os_mbuf *om) { struct os_mbuf *x; int rc = 0;

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-14 Thread GitBox
apache-mynewt-bot commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1155949458 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

  1   2   3   4   5   6   7   8   9   10   >