[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1322: porting/nimble/include: Add check of macro

2022-08-15 Thread GitBox


apache-mynewt-bot commented on PR #1322:
URL: https://github.com/apache/mynewt-nimble/pull/1322#issuecomment-1215284032

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    porting/nimble/include/os/endian.h
   
   
   ```diff
   @@ -29,35 +29,35 @@
/* Internal helpers */
#ifndef os_bswap_64
#define os_bswap_64(x)   ((uint64_t)\
   - x) & 0xff00ull) >> 56) |   \
   -  (((x) & 0x00ffull) >> 40) |   \
   -  (((x) & 0xff00ull) >> 24) |   \
   -  (((x) & 0x00ffull) >>  8) |   \
   -  (((x) & 0xff00ull) <<  8) |   \
   -  (((x) & 0x00ffull) << 24) |   \
   -  (((x) & 0xff00ull) << 40) |   \
   -  (((x) & 0x00ffull) << 56)))
   +  x) & 0xff00ull) >> 56) |   \
   +   (((x) & 0x00ffull) >> 40) |   \
   +   (((x) & 0xff00ull) >> 24) |   \
   +   (((x) & 0x00ffull) >>  8) |   \
   +   (((x) & 0xff00ull) <<  8) |   \
   +   (((x) & 0x00ffull) << 24) |   \
   +   (((x) & 0xff00ull) << 40) |   \
   +   (((x) & 0x00ffull) << 56)))
#endif

#ifndef os_bswap_32
#define os_bswap_32(x)((uint32_t)   \
   -x) & 0xff00) >> 24) |   \
   - (((x) & 0x00ff) >>  8) |   \
   - (((x) & 0xff00) <<  8) |   \
   - (((x) & 0x00ff) << 24)))
   +   x) & 0xff00) >> 24) |   \
   +(((x) & 0x00ff) >>  8) |   \
   +(((x) & 0xff00) <<  8) |   \
   +(((x) & 0x00ff) << 24)))
#endif

#ifndef os_bswap_16
#define os_bswap_16(x)   ((uint16_t)\
   -x) & 0xff00) >> 8) |\
   - (((x) & 0x00ff) << 8)))
   -#endif
   -
   -#ifndef __BYTE_ORDER__ 
   +  x) & 0xff00) >> 8) |\
   +   (((x) & 0x00ff) << 8)))
   +#endif
   +
   +#ifndef __BYTE_ORDER__
#error  "Please define __BYTE_ORDER__ on complier"
#endif

   -#ifndef __ORDER_BIG_ENDIAN__ 
   +#ifndef __ORDER_BIG_ENDIAN__
#error  "Please define __ORDER_BIG_ENDIAN__ on complier"
#endif

   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] supperthomas opened a new pull request, #1322: porting/nimble/include: Add check of macro

2022-08-15 Thread GitBox


supperthomas opened a new pull request, #1322:
URL: https://github.com/apache/mynewt-nimble/pull/1322

   There isn't macro __BYTE_ORDER__ and __ORDER_BIG_ENDIAN__ on other compiler 
like KEIL or IAR. In that case, the complier will complier without error, but 
the HCI cmd will be BIG_ENDIAN as default which is wrong on ARM Cortex-m little 
endian platform.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2862: sys/shell: Add "/compat reset_cause" command

2022-08-12 Thread GitBox


apache-mynewt-bot commented on PR #2862:
URL: https://github.com/apache/mynewt-core/pull/2862#issuecomment-1213323124

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1321: nimble/ll/css: Add vs event to indicate slot change

2022-08-12 Thread GitBox


apache-mynewt-bot commented on PR #1321:
URL: https://github.com/apache/mynewt-nimble/pull/1321#issuecomment-1213222361

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] m-gorecki opened a new pull request, #2862: sys/shell: Add "/compat reset_cause" command

2022-08-12 Thread GitBox


m-gorecki opened a new pull request, #2862:
URL: https://github.com/apache/mynewt-core/pull/2862

   Command prints reset cause when called.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-08-12 Thread GitBox


apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1213031513

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1321: nimble/ll/css: Add vs event to indicate slot change

2022-08-12 Thread GitBox


andrzej-kaczmarek opened a new pull request, #1321:
URL: https://github.com/apache/mynewt-nimble/pull/1321

   If hci_vs support is enabled for CSS, an event will be sent every time
   slot chanes for a connection. Event is also sent after connection is
   created (after conn complete and csa events).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] wes3 merged pull request #2861: hw/usb/cdc_console: Modify flush if cdc tx bufsize defined

2022-08-11 Thread GitBox


wes3 merged PR #2861:
URL: https://github.com/apache/mynewt-core/pull/2861


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1320: apps/bleservo: Initial commit.

2022-08-11 Thread GitBox


apache-mynewt-bot commented on PR #1320:
URL: https://github.com/apache/mynewt-nimble/pull/1320#issuecomment-1212020389

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    apps/bleservo/src/gatt_svr.c
   
   
   ```diff
   @@ -82,24 +82,24 @@
.type = BLE_GATT_SVC_TYPE_PRIMARY,
.uuid = _svr_svc_servo_uuid.u,
.characteristics = (struct ble_gatt_chr_def[]) { {
   -/* Characteristic: servo angle*/
   -.uuid = _svr_chr_servo_angle_uuid.u,
   -.val_handle = _angle_val_handle,
   -.access_cb = gatt_svr_chr_access_servo_angle,
   -.flags = BLE_GATT_CHR_F_READ |
   - BLE_GATT_CHR_F_WRITE |
   - BLE_GATT_CHR_F_NOTIFY
   -}, {
   -/* Characteristic: servo PWM pulse duration*/
   -.uuid = _svr_chr_servo_pulse_duration_uuid.u,
   -.val_handle = _pulse_duration_val_handle,
   -.access_cb = gatt_svr_chr_access_servo_pulse_duration,
   -.flags = BLE_GATT_CHR_F_READ |
   - BLE_GATT_CHR_F_WRITE |
   - BLE_GATT_CHR_F_NOTIFY
   -}, {
   -0, /* No more characteristics in this service */
   -}, }
   + /* 
Characteristic: servo angle*/
   + .uuid = 
_svr_chr_servo_angle_uuid.u,
   + .val_handle = 
_angle_val_handle,
   + .access_cb = 
gatt_svr_chr_access_servo_angle,
   + .flags = 
BLE_GATT_CHR_F_READ |
   +  
BLE_GATT_CHR_F_WRITE |
   +  
BLE_GATT_CHR_F_NOTIFY
   + }, {
   + /* 
Characteristic: servo PWM pulse duration*/
   + .uuid = 
_svr_chr_servo_pulse_duration_uuid.u,
   + .val_handle = 
_pulse_duration_val_handle,
   + .access_cb = 
gatt_svr_chr_access_servo_pulse_duration,
   + .flags = 
BLE_GATT_CHR_F_READ |
   +  
BLE_GATT_CHR_F_WRITE |
   +  
BLE_GATT_CHR_F_NOTIFY
   + }, {
   + 0, /* No more 
characteristics in this service */
   + }, }
},

{
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1320: apps/bleservo: Initial commit.

2022-08-11 Thread GitBox


apache-mynewt-bot commented on PR #1320:
URL: https://github.com/apache/mynewt-nimble/pull/1320#issuecomment-1212004694

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    apps/bleservo/src/gatt_svr.c
   
   
   ```diff
   @@ -82,24 +82,24 @@
.type = BLE_GATT_SVC_TYPE_PRIMARY,
.uuid = _svr_svc_servo_uuid.u,
.characteristics = (struct ble_gatt_chr_def[]) { {
   -/* Characteristic: servo angle*/
   -.uuid = _svr_chr_servo_angle_uuid.u,
   -.val_handle = _angle_val_handle,
   -.access_cb = gatt_svr_chr_access_servo_angle,
   -.flags = BLE_GATT_CHR_F_READ |
   - BLE_GATT_CHR_F_WRITE |
   - BLE_GATT_CHR_F_NOTIFY
   -}, {
   -/* Characteristic: servo PWM pulse duration*/
   -.uuid = _svr_chr_servo_pulse_duration_uuid.u,
   -.val_handle = _pulse_duration_val_handle,
   -.access_cb = gatt_svr_chr_access_servo_pulse_duration,
   -.flags = BLE_GATT_CHR_F_READ |
   - BLE_GATT_CHR_F_WRITE |
   - BLE_GATT_CHR_F_NOTIFY
   -}, {
   -0, /* No more characteristics in this service */
   -}, }
   + /* 
Characteristic: servo angle*/
   + .uuid = 
_svr_chr_servo_angle_uuid.u,
   + .val_handle = 
_angle_val_handle,
   + .access_cb = 
gatt_svr_chr_access_servo_angle,
   + .flags = 
BLE_GATT_CHR_F_READ |
   +  
BLE_GATT_CHR_F_WRITE |
   +  
BLE_GATT_CHR_F_NOTIFY
   + }, {
   + /* 
Characteristic: servo PWM pulse duration*/
   + .uuid = 
_svr_chr_servo_pulse_duration_uuid.u,
   + .val_handle = 
_pulse_duration_val_handle,
   + .access_cb = 
gatt_svr_chr_access_servo_pulse_duration,
   + .flags = 
BLE_GATT_CHR_F_READ |
   +  
BLE_GATT_CHR_F_WRITE |
   +  
BLE_GATT_CHR_F_NOTIFY
   + }, {
   + 0, /* No more 
characteristics in this service */
   + }, }
},

{
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc merged pull request #1303: apps/blehr: Fix blehr notify stopped incorrectly

2022-08-11 Thread GitBox


sjanc merged PR #1303:
URL: https://github.com/apache/mynewt-nimble/pull/1303


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1320: apps/bleservo: Initial commit.

2022-08-11 Thread GitBox


apache-mynewt-bot commented on PR #1320:
URL: https://github.com/apache/mynewt-nimble/pull/1320#issuecomment-1211973098

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    apps/bleservo/src/ble_servo.h
   
   
   ```diff
   @@ -28,13 +28,13 @@
#endif

#define  PWM_CH_CFG_PIN  31
   -#define  PWM_CH_CFG_INV  false 
   +#define  PWM_CH_CFG_INV  false
#define  PWM_CH_NUM  0
#define  PWM_IRQ_PRIO1

   -/* 
   - * Servomotors work with 50 Hz PWM signal and accept pulse duration from 
around 1000us minimum (0 degree rotation) 
   - * to 2000us maximum (180 degree rotation). Unfortunataly those values of 
minimum and maximum 
   +/*
   + * Servomotors work with 50 Hz PWM signal and accept pulse duration from 
around 1000us minimum (0 degree rotation)
   + * to 2000us maximum (180 degree rotation). Unfortunataly those values of 
minimum and maximum
 * PWM pulse duration are only approximate and might differ with different 
servos, because they are not standardized.
 * Values defined below allow to adjust them for each servo you might use.
 */
   ```
   
   
   
    apps/bleservo/src/gatt_svr.c
   
   
   ```diff
   @@ -31,12 +31,12 @@

/* 5c3a659e-897e-45e1-b016-007107c96df6 */
static const ble_uuid128_t gatt_svr_chr_servo_angle_uuid =
   -BLE_UUID128_INIT(0xf6, 0x6d, 0xc9, 0x07, 0x71, 0x00, 0x16, 0xb0,
   +BLE_UUID128_INIT(0xf6, 0x6d, 0xc9, 0x07, 0x71, 0x00, 0x16, 0xb0,
 0xe1, 0x45, 0x7e, 0x89, 0x9e, 0x65, 0x3a, 0x5c);

/* 6d456567-8995-45e1-b016-007107c96df6 */
static const ble_uuid128_t gatt_svr_chr_servo_pulse_duration_uuid =
   -BLE_UUID128_INIT(0xf6, 0x6d, 0xc9, 0x07, 0x71, 0x00, 0x16, 0xb0,
   +BLE_UUID128_INIT(0xf6, 0x6d, 0xc9, 0x07, 0x71, 0x00, 0x16, 0xb0,
 0xe1, 0x45, 0x95, 0x89, 0x67, 0x65, 0x45, 0x6d);

/* Values kept in characteristics */
   @@ -50,11 +50,11 @@

static int
gatt_svr_chr_access_servo_angle(uint16_t conn_handle, uint16_t attr_handle,
   -   struct ble_gatt_access_ctxt *ctxt, void 
*arg);
   +struct ble_gatt_access_ctxt *ctxt, void 
*arg);

static int
gatt_svr_chr_access_servo_pulse_duration(uint16_t conn_handle, uint16_t 
attr_handle,
   -   struct ble_gatt_access_ctxt *ctxt, void 
*arg);
   + struct ble_gatt_access_ctxt *ctxt, 
void *arg);

static int
gatt_svr_chr_write(struct os_mbuf *om, uint16_t min_len, uint16_t max_len,
   @@ -82,29 +82,29 @@
.type = BLE_GATT_SVC_TYPE_PRIMARY,
.uuid = _svr_svc_servo_uuid.u,
.characteristics = (struct ble_gatt_chr_def[]) { {
   -/* Characteristic: servo angle*/
   -.uuid = _svr_chr_servo_angle_uuid.u,
   -.val_handle = _angle_val_handle,
   -.access_cb = gatt_svr_chr_access_servo_angle,
   -.flags = BLE_GATT_CHR_F_READ |
   - BLE_GATT_CHR_F_WRITE |
   - BLE_GATT_CHR_F_NOTIFY
   -}, {
   -/* Characteristic: servo PWM pulse duration*/
   -.uuid = _svr_chr_servo_pulse_duration_uuid.u,
   -.val_handle = _pulse_duration_val_handle,
   -.access_cb = gatt_svr_chr_access_servo_pulse_duration,
   -.flags = BLE_GATT_CHR_F_READ |
   - BLE_GATT_CHR_F_WRITE |
   - BLE_GATT_CHR_F_NOTIFY
   -}, {
   -0, /* No more characteristics in this service */
   -}, }
   + /* 
Characteristic: servo angle*/
   + .uuid = 
_svr_chr_servo_angle_uuid.u,
   + .val_handle = 
_angle_val_handle,
   + .access_cb = 
gatt_svr_chr_access_servo_angle,
   + .flags = 
BLE_GATT_CHR_F_READ |
   +  
BLE_GATT_CHR_F_WRITE |
   +  
BLE_GATT_CHR_F_NOTIFY
   + }, {
   + /* 
Characteristic: servo PWM pulse duration*/
   + .uuid = 
_svr_chr_servo_pulse_duration_uuid.u,
   + .val_handle = 
_pulse_duration_val_handle,
   + .access_cb = 
gatt_svr_chr_access_servo_pulse_duration,
   +

[GitHub] [mynewt-nimble] m-gorecki opened a new pull request, #1320: apps/bleservo: Initial commit.

2022-08-11 Thread GitBox


m-gorecki opened a new pull request, #1320:
URL: https://github.com/apache/mynewt-nimble/pull/1320

   nRF52840-DK BLE peripheral sample with PWM servo control ability.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc merged pull request #1318: Add "off" param to "scan" command.

2022-08-11 Thread GitBox


sjanc merged PR #1318:
URL: https://github.com/apache/mynewt-nimble/pull/1318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration

2022-08-11 Thread GitBox


andrzej-kaczmarek merged PR #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration

2022-08-11 Thread GitBox


apache-mynewt-bot commented on PR #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319#issuecomment-1211892334

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/drivers/nrf5340/src/ble_phy.c
   
   
   ```diff
   @@ -1386,7 +1387,8 @@
/* Toggle peripheral power to reset (just in case) */
NRF_RADIO_NS->POWER = 0;
NRF_RADIO_NS->POWER = 1;
   -*(volatile uint32_t *)(NRF_RADIO_NS_BASE + 0x774) = (*(volatile 
uint32_t* )(NRF_RADIO_NS_BASE + 0x774) & 0xfffe) | 0x0100;
   +*(volatile uint32_t *)(NRF_RADIO_NS_BASE +
   +   0x774) = (*(volatile uint32_t * 
)(NRF_RADIO_NS_BASE + 0x774) & 0xfffe) | 0x0100;

/* Errata 16 - RADIO: POWER register is not functional
 * Workaround: Reset all RADIO registers in firmware.
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration

2022-08-11 Thread GitBox


apache-mynewt-bot commented on PR #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319#issuecomment-1211883552

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/drivers/nrf5340/src/ble_phy.c
   
   
   ```diff
   @@ -1386,7 +1387,8 @@
/* Toggle peripheral power to reset (just in case) */
NRF_RADIO_NS->POWER = 0;
NRF_RADIO_NS->POWER = 1;
   -*(volatile uint32_t *)(NRF_RADIO_NS_BASE + 0x774) = (*(volatile 
uint32_t* )(NRF_RADIO_NS_BASE + 0x774) & 0xfffe) | 0x0100;
   +*(volatile uint32_t *)(NRF_RADIO_NS_BASE +
   +   0x774) = (*(volatile uint32_t * 
)(NRF_RADIO_NS_BASE + 0x774) & 0xfffe) | 0x0100;

/* Errata 16 - RADIO: POWER register is not functional
 * Workaround: Reset all RADIO registers in firmware.
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration

2022-08-11 Thread GitBox


apache-mynewt-bot commented on PR #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319#issuecomment-1211868114

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/drivers/nrf5340/src/ble_phy.c
   
   
   ```diff
   @@ -1385,7 +1386,8 @@
/* Toggle peripheral power to reset (just in case) */
NRF_RADIO_NS->POWER = 0;
NRF_RADIO_NS->POWER = 1;
   -*(volatile uint32_t *)(NRF_RADIO_NS_BASE + 0x774) = (*(volatile 
uint32_t* )(NRF_RADIO_NS_BASE + 0x774) & 0xfffe) | 0x0100;
   +*(volatile uint32_t *)(NRF_RADIO_NS_BASE +
   +   0x774) = (*(volatile uint32_t * 
)(NRF_RADIO_NS_BASE + 0x774) & 0xfffe) | 0x0100;

/* Errata 16 - RADIO: POWER register is not functional
 * Workaround: Reset all RADIO registers in firmware.
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration

2022-08-11 Thread GitBox


apache-mynewt-bot commented on PR #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319#issuecomment-1211863182

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/drivers/nrf5340/src/ble_phy.c
   
   
   ```diff
   @@ -1369,7 +1370,8 @@
/* Toggle peripheral power to reset (just in case) */
NRF_RADIO_NS->POWER = 0;
NRF_RADIO_NS->POWER = 1;
   -*(volatile uint32_t *)(NRF_RADIO_NS_BASE + 0x774) = (*(volatile 
uint32_t* )(NRF_RADIO_NS_BASE + 0x774) & 0xfffe) | 0x0100;
   +*(volatile uint32_t *)(NRF_RADIO_NS_BASE +
   +   0x774) = (*(volatile uint32_t * 
)(NRF_RADIO_NS_BASE + 0x774) & 0xfffe) | 0x0100;

/* Errata 16 - RADIO: POWER register is not functional
 * Workaround: Reset all RADIO registers in firmware.
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1318: Add "off" param to "scan" command.

2022-08-11 Thread GitBox


apache-mynewt-bot commented on PR #1318:
URL: https://github.com/apache/mynewt-nimble/pull/1318#issuecomment-1211861257

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration

2022-08-11 Thread GitBox


andrzej-kaczmarek opened a new pull request, #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319

   This allows to define PA/LNA turn-on time which allows it to fully turn
   on before actual rx/tx. Currently only supported by nRF53 PHY.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] m-gorecki opened a new pull request, #1318: Add "off" param to "scan" command.

2022-08-11 Thread GitBox


m-gorecki opened a new pull request, #1318:
URL: https://github.com/apache/mynewt-nimble/pull/1318

   Substitute parameter for "cancel".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2861: hw/usb/cdc_console: Modify flush if cdc tx bufsize defined

2022-08-10 Thread GitBox


apache-mynewt-bot commented on PR #2861:
URL: https://github.com/apache/mynewt-core/pull/2861#issuecomment-1211211517

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] wes3 opened a new pull request, #2861: hw/usb/cdc_console: Modify flush if cdc tx bufsize defined

2022-08-10 Thread GitBox


wes3 opened a new pull request, #2861:
URL: https://github.com/apache/mynewt-core/pull/2861

   If the user defines USBD_CDC_TX_BUFSIZE and that buffer size is
   larger than USBD_CDC_DATA_EP_SIZE, data will not be flushed
   immediately. This change will cause it to be flushed immediately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1317: nimble/ll: Use OTA max rx time for connection event calculations

2022-08-08 Thread GitBox


andrzej-kaczmarek merged PR #1317:
URL: https://github.com/apache/mynewt-nimble/pull/1317


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1317: nimble/ll: Use OTA max rx time for connection event calculations

2022-08-05 Thread GitBox


apache-mynewt-bot commented on PR #1317:
URL: https://github.com/apache/mynewt-nimble/pull/1317#issuecomment-1206381588

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/controller/src/ble_ll_conn.c
   
   
   ```diff
   @@ -1260,8 +1259,8 @@
#endif

ticks = (BLE_LL_IFS * 3) + connsm->ota_max_rx_time +
   -ble_ll_pdu_tx_time_get(next_txlen, tx_phy_mode) +
   -ble_ll_pdu_tx_time_get(cur_txlen, tx_phy_mode);
   +ble_ll_pdu_tx_time_get(next_txlen, tx_phy_mode) +
   +ble_ll_pdu_tx_time_get(cur_txlen, tx_phy_mode);

#if MYNEWT_VAL(BLE_LL_ROLE_CENTRAL)
if (connsm->conn_role == BLE_LL_CONN_ROLE_CENTRAL) {
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1317: nimble/ll: Use OTA max rx time for connection event calculations

2022-08-05 Thread GitBox


andrzej-kaczmarek opened a new pull request, #1317:
URL: https://github.com/apache/mynewt-nimble/pull/1317

   Using effective max rx time for connection event calculations is not
   optimal since it's possible that time to rx packet with max octets
   payload is shorter that effective max rx time. Instead, we should
   calculate time it takes to rx packaet with effectiva max octets payload
   and use it if less than effective max rx time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1309: nimble/ll: Fix privacy handling when connecting to a new device

2022-08-05 Thread GitBox


andrzej-kaczmarek merged PR #1309:
URL: https://github.com/apache/mynewt-nimble/pull/1309


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1314: nimble/ll/css: Fix window offset for 1st connection event

2022-08-05 Thread GitBox


andrzej-kaczmarek merged PR #1314:
URL: https://github.com/apache/mynewt-nimble/pull/1314


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1312: Fix possible MIC error

2022-08-05 Thread GitBox


andrzej-kaczmarek merged PR #1312:
URL: https://github.com/apache/mynewt-nimble/pull/1312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] rinehaidvon closed pull request #1305: use true block size to calculate net buf id

2022-08-04 Thread GitBox


rinehaidvon closed pull request #1305: use true block size to calculate net buf 
id
URL: https://github.com/apache/mynewt-nimble/pull/1305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1316: nimble/ll: Add vs command to change all data length parameters

2022-08-04 Thread GitBox


apache-mynewt-bot commented on PR #1316:
URL: https://github.com/apache/mynewt-nimble/pull/1316#issuecomment-1205471328

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1314: nimble/ll/css: Fix window offset for 1st connection event

2022-08-04 Thread GitBox


apache-mynewt-bot commented on PR #1314:
URL: https://github.com/apache/mynewt-nimble/pull/1314#issuecomment-1205407096

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/controller/src/ble_ll_sched.c
   
   
   ```diff
   @@ -524,7 +524,7 @@
connsm->css_period_idx++;
ble_ll_sched_css_set_conn_anchor(connsm);
sch->start_time =
   -connsm->anchor_point - g_ble_ll_sched_offset_ticks;
   +connsm->anchor_point - g_ble_ll_sched_offset_ticks;
} while (LL_TMR_LT(sch->start_time, orig_start_time));

sch->end_time = connsm->anchor_point;
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1312: Fix possible MIC error

2022-08-04 Thread GitBox


apache-mynewt-bot commented on PR #1312:
URL: https://github.com/apache/mynewt-nimble/pull/1312#issuecomment-1205266124

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/drivers/nrf52/src/ble_phy.c
   
   
   ```diff
   @@ -1102,7 +1100,8 @@
if (g_ble_phy_data.phy_encrypted) {
while (NRF_CCM->EVENTS_ENDCRYPT == 0) {
/* Make sure CCM finished */
   -};
   +}
   +;

/* Only set MIC failure flag if frame is not zero length */
if ((dptr[1] != 0) && (NRF_CCM->MICSTATUS == 0)) {
   ```
   
   
   
    nimble/drivers/nrf5340/src/ble_phy.c
   
   
   ```diff
   @@ -960,7 +960,8 @@
if (g_ble_phy_data.phy_encrypted) {
while (NRF_CCM_NS->EVENTS_ENDCRYPT == 0) {
/* Make sure CCM finished */
   -};
   +}
   +;

/* Only set MIC failure flag if frame is not zero length */
if ((dptr[1] != 0) && (NRF_CCM_NS->MICSTATUS == 0)) {
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] chrysn opened a new issue, #1315: Documentation: Assist in discovering ports

2022-08-04 Thread GitBox


chrysn opened a new issue, #1315:
URL: https://github.com/apache/mynewt-nimble/issues/1315

   nimble is portable both with respect to the operating system it runs on and 
to the radio modules, but starting at the project web page or repository it is 
hard to discover for which there is which level of support.
   
   I suggest that that the Supported Hardware section of the README be 
extended, eg. like this:
   
   > With the components in this repository, NimBLE supports Nordic nRF51 and 
nRF52 chipsets as controllers. Host runs on any board and architecture 
[supported](https://github.com/apache/mynewt-core#overview) by Apache Mynewt OS.
   >
   > Several other projects provide out-of-tree support for additional 
components:
   > * The [Espressif ESP-IDF contains a NimBLE 
port](https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/bluetooth/nimble/index.html)
 for ESP-32 devices.
   > * The [RIOT operating system contains a 
package](https://doc.riot-os.org/group__pkg__nimble.html) for using NimBLE.
   > * *If you publish a NimBLE port, please let us know to include it here!*
   
   I think that the ESP-IDF stuff is not really a port but more of a fork, but 
don't know it well enough to make a good assessment.
   
   The porting/targets directory contains snippets for Linux and nuttx, so they 
should probably also get mentions on that list if they're usable.
   
   That information might also be maintained, for example, in a wiki, but I 
think it's practical to have this highly visible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1314: nimble/ll/css: Fix window offset for 1st connection event

2022-08-04 Thread GitBox


andrzej-kaczmarek opened a new pull request, #1314:
URL: https://github.com/apache/mynewt-nimble/pull/1314

   Depending on timing, connection anchor point calculated for current
   period and requested slot might have already passed at the time
   advertising PDU is received and this causes window offset to be
   calculated incorrectly. In such case we just move connection to next
   period and recalculate anchor point again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] kasjer merged pull request #2860: riscv: Fix build warning

2022-08-04 Thread GitBox


kasjer merged PR #2860:
URL: https://github.com/apache/mynewt-core/pull/2860


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc merged pull request #1299: porting/npl/nuttx: fix callout_handler implement

2022-08-04 Thread GitBox


sjanc merged PR #1299:
URL: https://github.com/apache/mynewt-nimble/pull/1299


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc commented on pull request #1305: use true block size to calculate net buf id

2022-08-04 Thread GitBox


sjanc commented on PR #1305:
URL: https://github.com/apache/mynewt-nimble/pull/1305#issuecomment-1204844427

   Hi,
   
   could you update commit message with a bit of explanation on what is being 
fixed by this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc merged pull request #1313: tools/hci_throughput: Added tp tests over encrypted link

2022-08-04 Thread GitBox


sjanc merged PR #1313:
URL: https://github.com/apache/mynewt-nimble/pull/1313


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1313: tools/hci_throughput: Added tp tests over encrypted link

2022-08-03 Thread GitBox


apache-mynewt-bot commented on PR #1313:
URL: https://github.com/apache/mynewt-nimble/pull/1313#issuecomment-1204581852

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1312: nimble/phy/nrf: Fix possible MIC error

2022-08-03 Thread GitBox


apache-mynewt-bot commented on PR #1312:
URL: https://github.com/apache/mynewt-nimble/pull/1312#issuecomment-1204551323

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/drivers/nrf52/src/ble_phy.c
   
   
   ```diff
   @@ -1103,7 +1101,7 @@
/* Only set MIC failure flag if frame is not zero length */
if (dptr[1] != 0) {
/* Make sure CCM finished */
   -while(NRF_CCM->EVENTS_ENDCRYPT == 0) {
   +while (NRF_CCM->EVENTS_ENDCRYPT == 0) {
__WFE();
}
if (NRF_CCM->MICSTATUS == 0) {
   ```
   
   
   
    nimble/drivers/nrf5340/src/ble_phy.c
   
   
   ```diff
   @@ -961,7 +961,7 @@
/* Only set MIC failure flag if frame is not zero length */
if (dptr[1] != 0) {
/* Make sure CCM finished */
   -while(NRF_CCM_NS->EVENTS_ENDCRYPT == 0) {
   +while (NRF_CCM_NS->EVENTS_ENDCRYPT == 0) {
__WFE();
}
if (NRF_CCM_NS->MICSTATUS == 0) {
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2860: riscv: Fix build warning

2022-08-03 Thread GitBox


apache-mynewt-bot commented on PR #2860:
URL: https://github.com/apache/mynewt-core/pull/2860#issuecomment-1204221174

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/sifive/fe310/src/hal_flash.c
   
   
   ```diff
   @@ -64,15 +64,15 @@

static int
fe310_flash_read(const struct hal_flash *dev, uint32_t address, void *dst,
   -uint32_t num_bytes)
   + uint32_t num_bytes)
{
memcpy(dst, (void *)address, num_bytes);
return 0;
}

   -static int __attribute((section(".ram_text.fe310_flash_transmit")))
   -fe310_flash_transmit(uint8_t out_byte)
   -{
   +static int
   +__attribute((section(".ram_text.fe310_flash_transmit")))
   +fe310_flash_transmit(uint8_t out_byte) {
int in_byte;

/* Empty RX FIFO */
   @@ -80,15 +80,15 @@
}
SPI0_REG(SPI_REG_TXFIFO) = out_byte;
do {
   - in_byte = SPI0_REG(SPI_REG_RXFIFO);
   +in_byte = SPI0_REG(SPI_REG_RXFIFO);
} while (in_byte < 0);

return in_byte;
}

   -static int __attribute((section(".ram_text.fe310_flash_fifo_put")))
   -fe310_flash_fifo_put(uint8_t out_byte)
   -{
   +static int
   +__attribute((section(".ram_text.fe310_flash_fifo_put")))
   +fe310_flash_fifo_put(uint8_t out_byte) {
int went_out = 0;

/* Empty RX FIFO */
   @@ -105,9 +105,9 @@
return went_out;
}

   -static int __attribute((section(".ram_text.fe310_flash_fifo_write")))
   -fe310_flash_fifo_write(const uint8_t *ptr, int count)
   -{
   +static int
   +__attribute((section(".ram_text.fe310_flash_fifo_write")))
   +fe310_flash_fifo_write(const uint8_t *ptr, int count) {
int went_out = 0;

while (count > 0) {
   @@ -123,9 +123,9 @@
return went_out;
}

   -static int __attribute((section(".ram_text.fe310_flash_wait_till_ready")))
   -fe310_flash_wait_till_ready(void)
   -{
   +static int
   +__attribute((section(".ram_text.fe310_flash_wait_till_ready")))
   +fe310_flash_wait_till_ready(void) {
int status;
do {
SPI0_REG(SPI_REG_CSMODE) = SPI_CSMODE_HOLD;
   @@ -138,19 +138,19 @@
return 0;
}

   -static int __attribute((section(".ram_text.fe310_flash_write_enable")))
   -fe310_flash_write_enable(void)
   -{
   +static int
   +__attribute((section(".ram_text.fe310_flash_write_enable")))
   +fe310_flash_write_enable(void) {
SPI0_REG(SPI_REG_CSMODE) = SPI_CSMODE_HOLD;
fe310_flash_transmit(FLASH_CMD_WRITE_ENABLE);
SPI0_REG(SPI_REG_CSMODE) = SPI_CSMODE_AUTO;
return 0;
}

   -static int  __attribute((section(".ram_text.fe310_flash_write_page"))) 
__attribute((noinline))
   +static int
   +__attribute((section(".ram_text.fe310_flash_write_page"))) 
__attribute((noinline))
fe310_flash_write_page(const struct hal_flash *dev, uint32_t address,
   -  const void *src, uint32_t num_bytes)
   -{
   +  const void *src, uint32_t num_bytes) {
int sr;
/* Number of bytes that left controller FIFO */
int went_out = 0;
   @@ -232,9 +232,9 @@
return 0;
}

   -static int __attribute((section(".ram_text.fe310_flash_erase_sector"))) 
__attribute((noinline))
   -fe310_flash_erase_sector(const struct hal_flash *dev, uint32_t 
sector_address)
   -{
   +static int
   +__attribute((section(".ram_text.fe310_flash_erase_sector"))) 
__attribute((noinline))
   +fe310_flash_erase_sector(const struct hal_flash *dev, uint32_t 
sector_address) {
int sr;
__HAL_DISABLE_INTERRUPTS(sr);

   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] jrotkiewicz opened a new pull request, #1313: tools/hci_throughput: Added tp tests over encrypted link

2022-08-03 Thread GitBox


jrotkiewicz opened a new pull request, #1313:
URL: https://github.com/apache/mynewt-nimble/pull/1313

   @sjanc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1312: nimble/phy/nrf: Fix possible MIC error

2022-08-03 Thread GitBox


andrzej-kaczmarek opened a new pull request, #1312:
URL: https://github.com/apache/mynewt-nimble/pull/1312

   CCM may take longer to finish than our handling or rx isr end, so make
   sure that we wait for CCM before checking MIC status.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] kasjer opened a new pull request, #2860: riscv: Fix build warning

2022-08-03 Thread GitBox


kasjer opened a new pull request, #2860:
URL: https://github.com/apache/mynewt-core/pull/2860

   This eliminates following warning:
   
   /tmp/ccfBOXIv.s: Assembler messages:
   /tmp/ccfBOXIv.s:6: Warning: setting incorrect section attributes for 
.data.fe310_flash_transmit
   /tmp/ccfBOXIv.s:41: Warning: setting incorrect section attributes for 
.data.fe310_flash_fifo_put
   /tmp/ccfBOXIv.s:89: Warning: setting incorrect section attributes for 
.data.fe310_flash_fifo_write
   /tmp/ccfBOXIv.s:145: Warning: setting incorrect section attributes for 
.data.fe310_flash_wait_till_ready
   /tmp/ccfBOXIv.s:194: Warning: setting incorrect section attributes for 
.data.fe310_flash_write_enable
   /tmp/ccfBOXIv.s:232: Warning: setting incorrect section attributes for 
.data.fe310_flash_write_page
   /tmp/ccfBOXIv.s:419: Warning: setting incorrect section attributes for 
.data.fe310_flash_erase_sector
   
   .data. section gets default attributes that are no executable
   renaming .data to .ram_text fixes assembler warning
   This requries change to linker script that now has to include 
.ram_text.X in data section
   to work as it used to before change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2859: tinyusb/synopsys: Add RHPORT1 configuration option

2022-08-03 Thread GitBox


apache-mynewt-bot commented on PR #2859:
URL: https://github.com/apache/mynewt-core/pull/2859#issuecomment-1203694213

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] kasjer opened a new pull request, #2859: tinyusb/synopsys: Add RHPORT1 configuration option

2022-08-03 Thread GitBox


kasjer opened a new pull request, #2859:
URL: https://github.com/apache/mynewt-core/pull/2859

   Recent changes in TinyUSB headers require CFG_TUSB_RHPORT1_MODE
   to be present in synopsys based chips (STMF4, STMF7).
   It used to be defined in TinyUSB if not present.
   So far mynewt implementation does not use second USB port
   so it's safe to just define CFG_TUSB_RHPORT1_MODE the same way
   it used to be defined in TinyUSB repository to satisfy
   build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] kasjer merged pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-08-02 Thread GitBox


kasjer merged PR #2858:
URL: https://github.com/apache/mynewt-core/pull/2858


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] kasjer commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-08-02 Thread GitBox


kasjer commented on PR #2858:
URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1203517348

   @StarGate01 thanks for contributions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-08-02 Thread GitBox


apache-mynewt-bot commented on PR #2858:
URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1203216662

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-newt] sjanc merged pull request #484: Don't default to shallow clone for 'new' command

2022-08-02 Thread GitBox


sjanc merged PR #484:
URL: https://github.com/apache/mynewt-newt/pull/484


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-newt] sjanc opened a new pull request, #484: Don't default to shallow clone for 'new' command

2022-08-02 Thread GitBox


sjanc opened a new pull request, #484:
URL: https://github.com/apache/mynewt-newt/pull/484

   Release tag may no longer be on top of master branch and shallow
   copy would result if checkout fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1311: apps/bttester: add support for testing Periodic Advertising

2022-08-01 Thread GitBox


apache-mynewt-bot commented on PR #1311:
URL: https://github.com/apache/mynewt-nimble/pull/1311#issuecomment-1201108115

   
   ## Style check fail: Payload was too large


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1311: apps/bttester: add support for testing Periodic Advertising

2022-08-01 Thread GitBox


apache-mynewt-bot commented on PR #1311:
URL: https://github.com/apache/mynewt-nimble/pull/1311#issuecomment-1201100851

   
   ## Style check fail: Payload was too large


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1311: apps/bttester: add support for testing Periodic Advertising

2022-08-01 Thread GitBox


apache-mynewt-bot commented on PR #1311:
URL: https://github.com/apache/mynewt-nimble/pull/1311#issuecomment-1201041769

   
   ## Style check fail: Payload was too large


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] StarGate01 commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-30 Thread GitBox


StarGate01 commented on PR #2858:
URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1200314471

   @kasjer Thank you for the style comments; I have applied your suggestions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-30 Thread GitBox


apache-mynewt-bot commented on PR #2858:
URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1200313023

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/drivers/flash/spiflash/src/spiflash.c
   
   
   ```diff
   @@ -1374,24 +1378,24 @@
 * different pins, or of different type.
 * It is unlikely that flash depended packaged will work correctly.
 */
   -assert(MYNEWT_VAL(SPIFLASH_IGNORE_MANUFACTURER) || 
   +assert(MYNEWT_VAL(SPIFLASH_IGNORE_MANUFACTURER) ||
manufacturer == supported_chips[0].fc_jedec_id.ji_manufacturer);
   -if (!(MYNEWT_VAL(SPIFLASH_IGNORE_MANUFACTURER) || 
   -manufacturer == 
supported_chips[0].fc_jedec_id.ji_manufacturer)) {
   +if (!(MYNEWT_VAL(SPIFLASH_IGNORE_MANUFACTURER) ||
   +  manufacturer == 
supported_chips[0].fc_jedec_id.ji_manufacturer)) {
rc = -1;
goto err;
}
   -assert(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_TYPE) || 
   +assert(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_TYPE) ||
memory_type == supported_chips[0].fc_jedec_id.ji_type);
   -if (!(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_TYPE) || 
   -memory_type == supported_chips[0].fc_jedec_id.ji_type)) {
   +if (!(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_TYPE) ||
   +  memory_type == supported_chips[0].fc_jedec_id.ji_type)) {
rc = -1;
goto err;
}
   -assert(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_CAPACITY) || 
   +assert(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_CAPACITY) ||
capacity == supported_chips[0].fc_jedec_id.ji_capacity);
   -if (!(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_CAPACITY) || 
   -capacity == supported_chips[0].fc_jedec_id.ji_capacity)) {
   +if (!(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_CAPACITY) ||
   +  capacity == supported_chips[0].fc_jedec_id.ji_capacity)) {
rc = -1;
goto err;
}
   @@ -1425,12 +1429,12 @@
}
}
for (i = 0; supported_chips[i].fc_jedec_id.ji_manufacturer != 0; 
++i) {
   -if ((MYNEWT_VAL(SPIFLASH_IGNORE_MANUFACTURER) || 
   -manufacturer == 
supported_chips[i].fc_jedec_id.ji_manufacturer) &&
   -(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_TYPE) || 
   -memory_type == supported_chips[i].fc_jedec_id.ji_type) 
&&
   -(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_CAPACITY) || 
   -capacity == 
supported_chips[i].fc_jedec_id.ji_capacity)) {
   +if ((MYNEWT_VAL(SPIFLASH_IGNORE_MANUFACTURER) ||
   + manufacturer == 
supported_chips[i].fc_jedec_id.ji_manufacturer) &&
   +(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_TYPE) ||
   + memory_type == supported_chips[i].fc_jedec_id.ji_type) &&
   +(MYNEWT_VAL(SPIFLASH_IGNORE_MEMORY_CAPACITY) ||
   + capacity == supported_chips[i].fc_jedec_id.ji_capacity)) {
/* Device is supported */
dev->flash_chip = _chips[i];
break;
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] rinehaidvon opened a new issue, #1310: host/mesh Multi-thread call bt_mesh_model_send at the same time

2022-07-30 Thread GitBox


rinehaidvon opened a new issue, #1310:
URL: https://github.com/apache/mynewt-nimble/issues/1310

   when bt_mesh_model_send was called in two different thread. there are two 
msgs send in the same time.
   
   bt_mesh_model_send -> model_send -> bt_mesh_trans_send -> trans_encrypt 
   
   in function trans_encrypt, use current seqence num to create app nonce. 
maybe use same seqence num to create app nonce and encrypt different two msgs
   
   and then the msg send to network layer.
   
   bt_mesh_trans_send -> bt_mesh_net_send -> net_header_encode
   
   in function net_header_encode, put current seqence num into network pdu 
header and increase seqence num. 
   
   
   for example 
   
   send:
   
   transport layer:
   thread 1 send msg 1, use seqence num 1 to create app nonce, use appkey and 
app nonce encrypt msg 1
   thread 2 send msg 2, use seqence num 1 to create app nonce, use appkey and 
app nonce encrypt msg 2
   
   network layer:
   thread 1 send msg 1, put seqence num 1 into netowrk header of msg 1, and 
seqence num increase
   thread 2 send msg 2, put seqence num 2 into netowrk header of msg 2, and 
seqence num increase
   
   recv:
   
   recv msg 1, and msg 1 can be processed ok
   
   recv msg 2
   network layer
   parse network header, get seqence num is 2
   transport layer
   use seqence num 2 to create app nonce, so it can not be decrypted 
   
   Waiting for your replies! thank you so much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-29 Thread GitBox


apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1199173904

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1309: nimble/ll: Fix privacy handling when connecting to a new device

2022-07-29 Thread GitBox


apache-mynewt-bot commented on PR #1309:
URL: https://github.com/apache/mynewt-nimble/pull/1309#issuecomment-1199143777

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/controller/src/ble_ll_scan.c
   
   
   ```diff
   @@ -1285,7 +1284,7 @@
break;
}

   -/* fall-through */
   +/* fall-through */
case BLE_LL_ADDR_SUBTYPE_IDENTITY:
/* If AdvA is an identity address, we need to check if that device 
was
 * added to RL in order to use proper privacy mode.
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1309: nimble/ll: Fix privacy handling when connecting to a new device

2022-07-29 Thread GitBox


andrzej-kaczmarek opened a new pull request, #1309:
URL: https://github.com/apache/mynewt-nimble/pull/1309

   Using LL Privacy to initiate a connection to a new device (i.e. use 0x02
   or 0x03 as own address type, peer is using an RPA) requires host to add
   peer RPA and our IRK to resolving list. In this case we should allow to
   match that RPA as an identity address on resolving list so we can use
   proper privacy settings.
   
   Note that this is a bit of an unspecified behavior, i.e. HCI LE Add
   Device To Resolving List command parameters indicates that only identity
   addresses shall be added to resolving list, but this does not seem to be
   specified anywhere and there is no handling for non-identity address
   specified. So basically we allow RPA-as-an-identity to be added to
   resolving list, then if AdvA RPA does not match resolving list we just
   fall through to see if corresponding entry in resolving list exists and
   use it as identity address.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1297: nimble/ll: Fix continuation events handling

2022-07-28 Thread GitBox


andrzej-kaczmarek merged PR #1297:
URL: https://github.com/apache/mynewt-nimble/pull/1297


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc merged pull request #1304: apps/btshell: Add default own_addr_type check

2022-07-27 Thread GitBox


sjanc merged PR #1304:
URL: https://github.com/apache/mynewt-nimble/pull/1304


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc merged pull request #1308: host/sm: fix check in ble_sm_pair_req_rx

2022-07-27 Thread GitBox


sjanc merged PR #1308:
URL: https://github.com/apache/mynewt-nimble/pull/1308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1308: host/sm: fix check in ble_sm_pair_req_rx

2022-07-27 Thread GitBox


apache-mynewt-bot commented on PR #1308:
URL: https://github.com/apache/mynewt-nimble/pull/1308#issuecomment-1196565644

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1308: host/sm: fix check in ble_sm_pair_req_rx

2022-07-27 Thread GitBox


apache-mynewt-bot commented on PR #1308:
URL: https://github.com/apache/mynewt-nimble/pull/1308#issuecomment-1196518012

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_sm.c
   
   
   ```diff
   @@ -1833,7 +1832,7 @@
res->sm_err = BLE_SM_ERR_INVAL;
res->app_status = BLE_HS_SM_US_ERR(BLE_SM_ERR_INVAL);
} else if (MYNEWT_VAL(BLE_SM_SC_ONLY) && ((req->max_enc_key_size != 
BLE_SM_PAIR_KEY_SZ_MAX) ||
   -   !(req->authreq & BLE_SM_PAIR_AUTHREQ_SC))) {
   +  !(req->authreq & 
BLE_SM_PAIR_AUTHREQ_SC))) {
/* Fail if Secure Connections Only mode is on and remote does 
not meet
 * key size requirements - MITM was checked in last step. Fail 
if SC is not supported
 * by peer.
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1304: apps/btshell: Add default own_addr_type check

2022-07-27 Thread GitBox


apache-mynewt-bot commented on PR #1304:
URL: https://github.com/apache/mynewt-nimble/pull/1304#issuecomment-1196513945

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request, #1308: host/sm: fix check in ble_sm_pair_req_rx

2022-07-27 Thread GitBox


KKopyscinski opened a new pull request, #1308:
URL: https://github.com/apache/mynewt-nimble/pull/1308

   If SC_ONLY is enabled fail pairing request if either keysize is to small
   OR SC is not supported by peer. Previously it was an AND, which means
   both conditions must be true to fail pairing, which is not correct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc merged pull request #1307: tools/hci_throughput: Custom transport option

2022-07-27 Thread GitBox


sjanc merged PR #1307:
URL: https://github.com/apache/mynewt-nimble/pull/1307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1307: tools/hci_throughput: Custom transport option

2022-07-27 Thread GitBox


sjanc commented on code in PR #1307:
URL: https://github.com/apache/mynewt-nimble/pull/1307#discussion_r930716867


##
tools/hci_throughput/transport_factory.py:
##
@@ -18,15 +18,31 @@
 #
 
 import hci_socket
+import logging
+import traceback
+import sys
 
 class TransportFactory:
-   def __init__(self, device_index=None, device_mode=None,
- asyncio_loop=None) -> None:
-   if (type(device_index) == int or device_index.isnumeric()):
+   def __init__(self, device_index: str = None, device_mode=None,

Review Comment:
   something is wrong with whitespaces in this code block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] alberk8 commented on issue #1306: Example of starting and stopping ble

2022-07-26 Thread GitBox


alberk8 commented on issue #1306:
URL: https://github.com/apache/mynewt-nimble/issues/1306#issuecomment-1196241227

   Can someone please take a look at this implementation,  it looks like the 
deinit does not release the `TaskHandle_t host_task_h` [
nimble_port_freertos_deinit()](https://github.com/espressif/esp-nimble/blob/dac3a2a0f54589b10a4cff2a99526804747089df/porting/npl/freertos/src/nimble_port_freertos.c#L54)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] rymanluk commented on a diff in pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-26 Thread GitBox


rymanluk commented on code in PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#discussion_r930146040


##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -67,9 +67,9 @@ ble_l2cap_coc_srv_alloc(void)
 
 int
 ble_l2cap_coc_create_server(uint16_t psm, uint16_t mtu,
-ble_l2cap_event_fn *cb, void *cb_arg)
+ble_l2cap_event_fn *cb, void *cb_arg)

Review Comment:
   separate patch



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -35,7 +35,7 @@ static struct ble_l2cap_coc_srv_list ble_l2cap_coc_srvs;
 
 static os_membuf_t ble_l2cap_coc_srv_mem[
 OS_MEMPOOL_SIZE(MYNEWT_VAL(BLE_L2CAP_COC_MAX_NUM),
-sizeof (struct ble_l2cap_coc_srv))
+sizeof(struct ble_l2cap_coc_srv))

Review Comment:
   Can we make all those minor coding style changes as a separate patch ?



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -288,14 +298,16 @@ ble_l2cap_coc_rx_fn(struct ble_l2cap_chan *chan)
 ble_l2cap_sig_le_credits(chan->conn_handle, chan->scid, rx->credits);
 }
 
-BLE_HS_LOG(DEBUG, "Received partial sdu_len=%d, credits left=%d\n",
-   OS_MBUF_PKTLEN(rx->sdu), rx->credits);
+BLE_HS_LOG(DEBUG,
+   "Received partial sdu_len=%d, credits left=%d, 
current_sdu=%d\n",
+   OS_MBUF_PKTLEN(rx_sdu), rx->credits, chan->coc_rx.current_sdu);
 
 return 0;
 }
 
 void
-ble_l2cap_coc_set_new_mtu_mps(struct ble_l2cap_chan *chan, uint16_t mtu, 
uint16_t mps)
+ble_l2cap_coc_set_new_mtu_mps(struct ble_l2cap_chan *chan, uint16_t mtu,

Review Comment:
   separate patch 



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -218,12 +225,13 @@ ble_l2cap_coc_rx_fn(struct ble_l2cap_chan *chan)
 return BLE_HS_EBADDATA;
 }
 
-BLE_HS_LOG(DEBUG, "sdu_len=%d, received LE frame=%d, credits=%d\n",
-   sdu_len, om_total, rx->credits);
+BLE_HS_LOG(DEBUG,
+   "sdu_len=%d, received LE frame=%d, credits=%d, 
current_sdu=%d\n",
+   sdu_len, om_total, rx->credits, chan->coc_rx.current_sdu);
 
-os_mbuf_adj(*om , BLE_L2CAP_SDU_SIZE);
+os_mbuf_adj(*om, BLE_L2CAP_SDU_SIZE);

Review Comment:
   separate patch



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -113,7 +113,7 @@ ble_l2cap_get_first_available_bit(uint32_t *cid_mask)
  * a) If bit == 0 means all the bits are used
  * b) this function returns 1 + index
  */
-bit = __builtin_ffs(~(unsigned int)(cid_mask[i]));
+bit = __builtin_ffs(~(unsigned int) (cid_mask[i]));

Review Comment:
   separate patch



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -148,8 +148,8 @@ ble_l2cap_coc_srv_find(uint16_t psm)
 srv = NULL;
 STAILQ_FOREACH(cur, _l2cap_coc_srvs, next) {
 if (cur->psm == psm) {
-srv = cur;

Review Comment:
   separate patch



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -67,9 +67,9 @@ ble_l2cap_coc_srv_alloc(void)
 
 int
 ble_l2cap_coc_create_server(uint16_t psm, uint16_t mtu,
-ble_l2cap_event_fn *cb, void *cb_arg)
+ble_l2cap_event_fn *cb, void *cb_arg)
 {
-struct ble_l2cap_coc_srv * srv;
+struct ble_l2cap_coc_srv *srv;

Review Comment:
   separate patch



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -362,7 +379,7 @@ ble_l2cap_coc_create_srv_chan(struct ble_hs_conn *conn, 
uint16_t psm,
 static void
 ble_l2cap_event_coc_disconnected(struct ble_l2cap_chan *chan)
 {
-struct ble_l2cap_event event = { };
+struct ble_l2cap_event event = {};

Review Comment:
   separate patch



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -377,11 +394,12 @@ ble_l2cap_event_coc_disconnected(struct ble_l2cap_chan 
*chan)
 }
 
 void
-ble_l2cap_coc_cleanup_chan(struct ble_hs_conn *conn, struct ble_l2cap_chan 
*chan)
+ble_l2cap_coc_cleanup_chan(struct ble_hs_conn *conn,

Review Comment:
   really needed? If so "separate patch"



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -377,11 +394,12 @@ ble_l2cap_event_coc_disconnected(struct ble_l2cap_chan 
*chan)
 }
 
 void
-ble_l2cap_coc_cleanup_chan(struct ble_hs_conn *conn, struct ble_l2cap_chan 
*chan)
+ble_l2cap_coc_cleanup_chan(struct ble_hs_conn *conn,
+   struct ble_l2cap_chan *chan)
 {
 /* PSM 0 is used for fixed channels. */
 if (chan->psm == 0) {
-return;
+return;

Review Comment:
   separate patch



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -391,14 +409,16 @@ ble_l2cap_coc_cleanup_chan(struct ble_hs_conn *conn, 
struct ble_l2cap_chan *chan
  chan->scid - BLE_L2CAP_COC_CID_START);
 }
 
-os_mbuf_free_chain(chan->coc_rx.sdu);
-os_mbuf_free_chain(chan->coc_tx.sdu);
+for (int i = 0; i < BLE_L2CAP_SDU_BUFF_CNT; i++) {
+

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1307: tools/hci_throughput: Custom transport option

2022-07-26 Thread GitBox


apache-mynewt-bot commented on PR #1307:
URL: https://github.com/apache/mynewt-nimble/pull/1307#issuecomment-1195752370

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] jrotkiewicz opened a new pull request, #1307: tools/hci_throughput: Custom transport option

2022-07-26 Thread GitBox


jrotkiewicz opened a new pull request, #1307:
URL: https://github.com/apache/mynewt-nimble/pull/1307

   Added option to pass custom transport module.
   
   @sjanc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-26 Thread GitBox


apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1195381681

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] jrotkiewicz commented on a diff in pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-26 Thread GitBox


jrotkiewicz commented on code in PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#discussion_r929781378


##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -257,17 +265,19 @@ ble_l2cap_coc_rx_fn(struct ble_l2cap_chan *chan)
 
 rx->credits--;
 
-if (OS_MBUF_PKTLEN(rx->sdu) == rx->data_offset) {
-struct os_mbuf *sdu_rx = rx->sdu;
+if (OS_MBUF_PKTLEN(rx_sdu) == rx->data_offset) {
+struct os_mbuf *sdu_rx = rx_sdu;
 
 BLE_HS_LOG(DEBUG, "Received sdu_len=%d, credits left=%d\n",
-   OS_MBUF_PKTLEN(rx->sdu), rx->credits);
+   OS_MBUF_PKTLEN(rx_sdu), rx->credits);
 
 /* Lets get back control to os_mbuf to application.
  * Since it this callback application might want to set new sdu
  * we need to prepare space for this. Therefore we need sdu_rx
  */
-rx->sdu = NULL;
+rx_sdu = NULL;
+current_sdu =
+current_sdu < BLE_L2CAP_SDU_BUFF_CNT - 1 ? current_sdu + 1 : 0;

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] jrotkiewicz commented on a diff in pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-26 Thread GitBox


jrotkiewicz commented on code in PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#discussion_r929781103


##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -582,7 +597,12 @@ ble_l2cap_coc_recv_ready(struct ble_l2cap_chan *chan, 
struct os_mbuf *sdu_rx)
 return BLE_HS_EINVAL;
 }
 
-chan->coc_rx.sdu = sdu_rx;

Review Comment:
   fixed



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -186,10 +189,12 @@ ble_l2cap_coc_rx_fn(struct ble_l2cap_chan *chan)
 rx = >coc_rx;
 BLE_HS_DBG_ASSERT(rx != NULL);
 
+rx_sdu = rx->sdus[current_sdu];

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc merged pull request #1300: apps/bttester: do not distribute CSRK

2022-07-26 Thread GitBox


sjanc merged PR #1300:
URL: https://github.com/apache/mynewt-nimble/pull/1300


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] alberk8 opened a new issue, #1306: Example of starting and stopping ble

2022-07-25 Thread GitBox


alberk8 opened a new issue, #1306:
URL: https://github.com/apache/mynewt-nimble/issues/1306

   Is there any example of ble server/peripheral where the ble is stated, 
broadcast for a duration eg 90 seconds, then disposed/shutdown ble. Wait for 5 
minutes create start broadcast again in this cycle.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] kasjer commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-25 Thread GitBox


kasjer commented on PR #2858:
URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1193666753

   @StarGate01 maybe you could change your commit a little bit to be more 
consistent with mynewt style that requires opening brace `{` to be on the same 
line as `if`.
   Since new syscfg values have default value 0 it can be safely used in plain 
`if` (not `#if`)
   Instead of having:
   ```c
   #if !MYNEWT_VAL(SPIFLASH_IGNORE_MANUFACTURER)
   assert(manufacturer == 
supported_chips[0].fc_jedec_id.ji_manufacturer);
   if (manufacturer != supported_chips[0].fc_jedec_id.ji_manufacturer) {
   rc = -1;
   goto err;
   }
   #endif
   ```
   we would have:
   ```c
   assert(!MYNEWT_VAL(SPIFLASH_IGNORE_MANUFACTURER) &&
  manufacturer == 
supported_chips[0].fc_jedec_id.ji_manufacturer);
   if (!MYNEWT_VAL(SPIFLASH_IGNORE_MANUFACTURER) &&
   manufacturer != supported_chips[0].fc_jedec_id.ji_manufacturer) {
   rc = -1;
   goto err;
   }
   ```
   generate code would be the same and compiler would check syntax that 
otherwise would not be checked in some build depending on ignore flags and 
mynewt style would be preserved without additional pre-processor conditions 
added for style sake only.
   
   You can amend your commit and force push.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] rymanluk commented on a diff in pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-22 Thread GitBox


rymanluk commented on code in PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#discussion_r927661215


##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -186,10 +189,12 @@ ble_l2cap_coc_rx_fn(struct ble_l2cap_chan *chan)
 rx = >coc_rx;
 BLE_HS_DBG_ASSERT(rx != NULL);
 
+rx_sdu = rx->sdus[current_sdu];

Review Comment:
   are we sure tha rx_sdu will be non null?



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -582,7 +597,12 @@ ble_l2cap_coc_recv_ready(struct ble_l2cap_chan *chan, 
struct os_mbuf *sdu_rx)
 return BLE_HS_EINVAL;
 }
 
-chan->coc_rx.sdu = sdu_rx;

Review Comment:
   What if user call this function more time than BLE_L2CAP_SDU_BUFF_CNT ?
   
   Before we just overwrite chan->coc_rx.sdu which was not great as well.



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -186,10 +189,12 @@ ble_l2cap_coc_rx_fn(struct ble_l2cap_chan *chan)
 rx = >coc_rx;
 BLE_HS_DBG_ASSERT(rx != NULL);
 
+rx_sdu = rx->sdus[current_sdu];

Review Comment:
   btw - please add current_sdu to debug logs somewhere below



##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -257,17 +265,19 @@ ble_l2cap_coc_rx_fn(struct ble_l2cap_chan *chan)
 
 rx->credits--;
 
-if (OS_MBUF_PKTLEN(rx->sdu) == rx->data_offset) {
-struct os_mbuf *sdu_rx = rx->sdu;
+if (OS_MBUF_PKTLEN(rx_sdu) == rx->data_offset) {
+struct os_mbuf *sdu_rx = rx_sdu;
 
 BLE_HS_LOG(DEBUG, "Received sdu_len=%d, credits left=%d\n",
-   OS_MBUF_PKTLEN(rx->sdu), rx->credits);
+   OS_MBUF_PKTLEN(rx_sdu), rx->credits);
 
 /* Lets get back control to os_mbuf to application.
  * Since it this callback application might want to set new sdu
  * we need to prepare space for this. Therefore we need sdu_rx
  */
-rx->sdu = NULL;
+rx_sdu = NULL;
+current_sdu =
+current_sdu < BLE_L2CAP_SDU_BUFF_CNT - 1 ? current_sdu + 1 : 0;

Review Comment:
   what if user provided 2 buffers only and we just used the second?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1303: apps/blehr: Fix blehr notify stopped incorrectly

2022-07-22 Thread GitBox


apache-mynewt-bot commented on PR #1303:
URL: https://github.com/apache/mynewt-nimble/pull/1303#issuecomment-1192533907

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-22 Thread GitBox


apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1192501851

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-22 Thread GitBox


apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1192468699

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_l2cap_coc.c
   
   
   ```diff
   @@ -191,7 +191,7 @@

rx_sdu = rx->sdus[current_sdu];

   -//DFLT_LOG_CRITICAL("current_sdu: %d\n", current_sdu);
   +/*DFLT_LOG_CRITICAL("current_sdu: %d\n", current_sdu); */

om_total = OS_MBUF_PKTLEN(*om);

   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-mcumgr-cli] rlevano77 opened a new issue, #29: Image upload does not work over UDP - Zephyr smp_svr sample

2022-07-21 Thread GitBox


rlevano77 opened a new issue, #29:
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/29

   I am trying to setup the zephyr  samples/subsys/mgmt/mcumgr/smp_svr using UDP
   I am using Windows 11 and Golang v1.18.4
   After I added mcuboot to my atsame54_xpro board.
   I built the smp_svr with UDP support using :
   `west build -p auto -b myboard -d build-signed -- 
-DCONFIG_MCUBOOT_SIGNATURE_KEY_FILE=\"bootloader/mcuboot/root-rsa-2048.pem\" 
-DOVERLAY_CONFIG=overlay-udp.conf`
   
   mcuboot reconigze the image :
Booting Zephyr OS build zephyr-v3.1.0-812-g88ca3aca98c0  
   I: Starting bootloader
   I: Primary image: magic=unset, swap_type=0x1, copy_done=0x3, image_ok=0x3
   I: Scratch: magic=unset, swap_type=0x1, copy_done=0x3, image_ok=0x3
   I: Boot source: primary slot
   I: Swap type: none
   I: Bootloader chainload address offset: 0x1
   I: Jumping to the first image slot
   [00:00:00.255,000]  mdio_sam: transfer timedout MDIO
   [00:00:00.510,000]  mdio_sam: transfer timedout MDIO
   [00:00:00.765,000]  mdio_sam: transfer timedout MDIO
Booting Zephyr OS build zephyr-v3.1.0-812-g88ca3aca98c0  
   [00:00:01.020,000]  mdio_sam: transfer timedout MDIO
   [00:00:01.020,000]  eth_sam: MAC: 02:04:25:4b:d0:b9
   [00:00:01.020,000]  eth_sam: Queue 0 activated
   [00:00:06.069,000]  phy_mii: PHY (0) Link speed 100 Mb, full duplex
   [00:00:06.069,000]  eth_sam: Link up
   [00:00:06.070,000]  smp_udp_sample: Network connected
   [00:00:06.070,000]  smp_sample: build time: Jul 20 2022 06:19:25
   [00:00:06.070,000]  smp_udp: Started (IPv4)
   
   I tested the udp connection  and works ok :
   `$ mcumgr --conntype udp --connstring=[192.168.1.71]:1337 echo hello
   hello
   
   $ mcumgr --conntype udp --connstring=[192.168.1.71]:1337 image list
   Images:
image=0 slot=0
   version: 0.0.0
   bootable: true
   flags: active confirmed
   hash: 5fbc81f7d0f5e5de22f254746bc977ce8836bf364e576f4f03c418bd1451679c
   Split status: N/A (0)`
   
   But when I try to upload an image I only see
   $ mcumgr --conntype udp --connstring=[192.168.1.71]:1337 image upload 
build-signed/zephyr/zephyr.signed.bin
0 B / 71.88 KiB 
[]
   0.00%
   and nothing uploads.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] kasjer commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-21 Thread GitBox


kasjer commented on PR #2858:
URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1191269201

   Hi, I am out of office, idea is good so definitely I will support it, I
   have not seen the code, I will take a look next week.
   
   Thanks for your submittion.
   Jerzy
   
   czw., 21 lip 2022, 10:17 użytkownik Christoph Honal <
   ***@***.***> napisał:
   
   > @kasjer  Is this something you would consider
   > merging? The feature would be opt-in.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] StarGate01 commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-21 Thread GitBox


StarGate01 commented on PR #2858:
URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1191185810

   @kasjer Is this something you would consider merging? The feature would be 
opt-in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] Fanhang32 closed issue #1302: Do you have plan to support LE Audio?

2022-07-20 Thread GitBox


Fanhang32 closed issue #1302: Do you have plan to support LE Audio?
URL: https://github.com/apache/mynewt-nimble/issues/1302


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] m-gorecki opened a new pull request, #1304: apps/btshell: Add default own_addr_type check

2022-07-20 Thread GitBox


m-gorecki opened a new pull request, #1304:
URL: https://github.com/apache/mynewt-nimble/pull/1304

   On default the application has taken "public" as own address type. Now the 
application checks if public addres is available on the device and if not, on 
default it uses "random" as own addres type.
   It prevents advertising, scanning and connecting errors if the user won't 
change own address type in console, while working with a device, which has no 
public address available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] Fanhang32 opened a new pull request, #1303: apps/blehr: Fix blehr notify stopped incorrectly

2022-07-20 Thread GitBox


Fanhang32 opened a new pull request, #1303:
URL: https://github.com/apache/mynewt-nimble/pull/1303

   Don't stop blehr notity if other handles subscribed
   
   Signed-off-by: Fan Hang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] Fanhang32 opened a new issue, #1302: Do you have plan to support LE Audio?

2022-07-19 Thread GitBox


Fanhang32 opened a new issue, #1302:
URL: https://github.com/apache/mynewt-nimble/issues/1302

   Do you have plan to support LE Audio?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] novumdun opened a new issue, #1301: Is there any plan to support Bluetooth LE Audio?

2022-07-18 Thread GitBox


novumdun opened a new issue, #1301:
URL: https://github.com/apache/mynewt-nimble/issues/1301

   Nimble is very lovely to use but does not support Bluetooth LE Audio. So is 
there any plan to support Bluetooth LE Audio?
   Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1300: apps/bttester: do not distribute CSRK

2022-07-18 Thread GitBox


apache-mynewt-bot commented on PR #1300:
URL: https://github.com/apache/mynewt-nimble/pull/1300#issuecomment-1186923955

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request, #1300: apps/bttester: do not distribute CSRK

2022-07-18 Thread GitBox


KKopyscinski opened a new pull request, #1300:
URL: https://github.com/apache/mynewt-nimble/pull/1300

   BLE_SM_OUR_KEY_DIST and BLE_SM_THEIR_KEY_DIST should be set to 3,
   as we do not support security mode 2 - CSRK shall not be distributed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1299: porting/npl/nuttx: fix callout_handler implement

2022-07-15 Thread GitBox


apache-mynewt-bot commented on PR #1299:
URL: https://github.com/apache/mynewt-nimble/pull/1299#issuecomment-1185259720

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] mkeydevelop opened a new pull request, #1299: porting/npl/nuttx: fix callout_handler implement

2022-07-15 Thread GitBox


mkeydevelop opened a new pull request, #1299:
URL: https://github.com/apache/mynewt-nimble/pull/1299

   callout_thread is working for all timeout callout, it need
   an endless loop to catch all message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] AsafFisher opened a new issue, #1298: Library does not discover ANCS services.

2022-07-14 Thread GitBox


AsafFisher opened a new issue, #1298:
URL: https://github.com/apache/mynewt-nimble/issues/1298

   Using `ble_gattc_disc_all_svcs` will never show apple's ANCS services.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox


sada45 commented on issue #1291:
URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183854288

   Yes, that sounds reasonable to me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox


andrzej-kaczmarek commented on issue #1291:
URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183559883

   Checking SN in `ble_ll_conn_rx_isr_end` does only mean that previously txd 
PDU was acked, but the spec does not say anything about acking, it just states 
that a valid non-empty PDU has to be txd/rxd:
   
   > A continuation event is a connection event where, in at least one of the 
previous connContinuationNumber connection events (ignoring any before the last 
subrated connection event), **at least one packet was transmitted or validly 
received containing a Link Layer PDU with a non-zero Length field**.
   
   So `has_nonempty_pdu` is set in two cases:
   - for tx, when `ble_phy_tx` for non-empty PDU was successful, meaning it 
will be txd
   - for rx, in `ble_ll_conn_rx_data_pdu` when rxd PDU was determined to be 
valid and is non-empty
   
   There's one small catch for tx: in theory it's possible that radio will be 
disabled prior/during tx so in fact PDU will not be transmissted, but at the 
moment we do not handle this properly; also it likely won't be even noticed irl.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   3   4   5   6   7   8   9   10   >