[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2237: Adding bsp and mcu packages for dialog_da14695-dk-usb

2020-04-15 Thread GitBox 
apache-mynewt-bot commented on issue #2237: Adding bsp and mcu packages for 
dialog_da14695-dk-usb
URL: https://github.com/apache/mynewt-core/pull/2237#issuecomment-614335628
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2237: Adding bsp and mcu packages for dialog_da14695-dk-usb

2020-04-15 Thread GitBox 
apache-mynewt-bot commented on issue #2237: Adding bsp and mcu packages for 
dialog_da14695-dk-usb
URL: https://github.com/apache/mynewt-core/pull/2237#issuecomment-614314320
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/dialog/da14695/include/mcu/mcu.h
   
   
   ```diff
   @@ -116,7 +116,7 @@

#define MCU_GPIO_PORT0_PIN_COUNT32
#define MCU_GPIO_PORT0(pin)((0 * 32) + (pin))
   -#define MCU_GPIO_PORT1(pin)  ((1 * 32) + (pin))
   +#define MCU_GPIO_PORT1(pin)  ((1 * 32) + (pin))
#define MCU_DMA_CHAN_MAX8

#define MCU_PIN_GPADC_SEL0   MCU_GPIO_PORT1(9)
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2237: Adding bsp and mcu packages for dialog_da14695-dk-usb

2020-04-15 Thread GitBox 
apache-mynewt-bot commented on issue #2237: Adding bsp and mcu packages for 
dialog_da14695-dk-usb
URL: https://github.com/apache/mynewt-core/pull/2237#issuecomment-614273784
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/dialog/da14695/include/mcu/mcu.h
   
   
   ```diff
   @@ -115,8 +115,8 @@
#define MCU_GPIO_MODE_OUTPUT_OPEN_DRAIN 0x700/**< GPIO as an 
open-drain output */

#define MCU_GPIO_PORT0_PIN_COUNT32
   -#define MCU_GPIO_PORT0(pin) ((0 * 32) + (pin))
   -#define MCU_GPIO_PORT1(pin) ((1 * 32) + (pin))
   +#define MCU_GPIO_PORT0(pin) ((0 * 32) + (pin))
   +#define MCU_GPIO_PORT1(pin) ((1 * 32) + (pin))
#define MCU_DMA_CHAN_MAX8

#define MCU_PIN_GPADC_SEL0   MCU_GPIO_PORT1(9)
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services