apache-mynewt-bot commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-601770523
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
hw/mcu/stm/stm32_common/src/stm32_bootloader.c
```diff
@@ -1,4 +1,3 @@
-
#include
#include
#include
@@ -22,5 +21,5 @@
system_memory_reset_handler = (void (*)(void))(system_memory[1]);
system_memory_reset_handler();
-while(1) ;
+while (1);
}
```
hw/mcu/stm/stm32f1xx/include/mcu/mcu.h
```diff
@@ -34,10 +34,10 @@
defined(STM32F103x6) || defined(STM32F103xB) || defined(STM32F103xE)
#define STM32_SYSTEM_MEMORY 0x1000
#elif defined(STM32F105xC) || \
- defined(STM32F107xC)
+defined(STM32F107xC)
#define STM32_SYSTEM_MEMORY 0x1FFFB000
#elif defined(STM32F101xG) || \
- defined(STM32F103xG)
+defined(STM32F103xG)
#define STM32_SYSTEM_MEMORY 0x1FFFE000
#endif
```
hw/mcu/stm/stm32f4xx/include/mcu/mcu.h
```diff
@@ -31,7 +31,7 @@
defined(STM32F407xx) || \
defined(STM32F410Cx) || defined(STM32F410Rx) || defined(STM32F410Tx) ||
\
defined(STM32F411xE) || \
-defined(STM32F412Cx) || defined(STM32F412Rx) || defined(STM32F412Vx)
|| defined(STM32F412Zx) || \
+defined(STM32F412Cx) || defined(STM32F412Rx) || defined(STM32F412Vx) ||
defined(STM32F412Zx) || \
defined(STM32F415xx) || \
defined(STM32F417xx) || \
defined(STM32F427xx) || \
```
hw/mcu/stm/stm32l0xx/include/mcu/mcu.h
```diff
@@ -26,7 +26,8 @@
#define SVC_IRQ_NUMBER SVC_IRQn
-#if defined(STM32L010x4) || defined(STM32L010x6) || defined(STM32L010x8) ||
defined(STM32L010xB) || defined(STM32L011xx) || \
+#if defined(STM32L010x4) || defined(STM32L010x6) || defined(STM32L010x8) ||
defined(STM32L010xB) || \
+defined(STM32L011xx) || \
defined(STM32L021xx) || \
defined(STM32L031xx) || \
defined(STM32L041xx) || \
@@ -37,18 +38,18 @@
#define STM32_SYSTEM_MEMORY 0x1FF0
#endif
-/*
+/*
* Defines for naming GPIOs.
*/
-#define MCU_GPIO_PORTA(pin) ((0 * 16) + (pin))
-#define MCU_GPIO_PORTB(pin) ((1 * 16) + (pin))
-#define MCU_GPIO_PORTC(pin) ((2 * 16) + (pin))
-#define MCU_GPIO_PORTD(pin) ((3 * 16) + (pin))
-#define MCU_GPIO_PORTE(pin) ((4 * 16) + (pin))
-#define MCU_GPIO_PORTF(pin) ((5 * 16) + (pin))
-#define MCU_GPIO_PORTG(pin) ((6 * 16) + (pin))
-#define MCU_GPIO_PORTH(pin) ((7 * 16) + (pin))
-#define MCU_GPIO_PORTI(pin) ((8 * 16) + (pin))
+#define MCU_GPIO_PORTA(pin) ((0 * 16) + (pin))
+#define MCU_GPIO_PORTB(pin) ((1 * 16) + (pin))
+#define MCU_GPIO_PORTC(pin) ((2 * 16) + (pin))
+#define MCU_GPIO_PORTD(pin) ((3 * 16) + (pin))
+#define MCU_GPIO_PORTE(pin) ((4 * 16) + (pin))
+#define MCU_GPIO_PORTF(pin) ((5 * 16) + (pin))
+#define MCU_GPIO_PORTG(pin) ((6 * 16) + (pin))
+#define MCU_GPIO_PORTH(pin) ((7 * 16) + (pin))
+#define MCU_GPIO_PORTI(pin) ((8 * 16) + (pin))
#ifdef __cplusplus
}
```
hw/mcu/stm/stm32l1xx/include/mcu/mcu.h
```diff
@@ -33,7 +33,8 @@
defined(STM32L151xD) || defined(STM32L151xDX) || defined(STM32L151xE)
|| \
defined(STM32L152xB) || defined(STM32L152xBA) || defined(STM32L152xC)
|| defined(STM32L152xCA) || \
defined(STM32L152xD) || defined(STM32L152xDX) || defined(STM32L152xE)
|| \
-defined(STM32L162xC) || defined(STM32L162xCA) || defined(STM32L162xD)
|| defined(STM32L162xDX) || defined(STM32L162xE)
+defined(STM32L162xC) || defined(STM32L162xCA) || defined(STM32L162xD)
|| defined(STM32L162xDX) || \
+defined(STM32L162xE)
#define STM32_SYSTEM_MEMORY 0x1FF0
#endif
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
