[GitHub] [mynewt-nimble] h2zero commented on issue #783: Make ble_gap_rx_l2cap_update_req() behave like ble_gap_rx_param_req()

2020-04-13 Thread GitBox
h2zero commented on issue #783: Make ble_gap_rx_l2cap_update_req() behave like 
ble_gap_rx_param_req()
URL: https://github.com/apache/mynewt-nimble/pull/783#issuecomment-612954585
 
 
   @zacwbond What @rymanluk is saying is that the procedure you are suggesting 
would go against the bluetooth core spec, although it does help with the esp32 
issues. 
   
   The esp32 has some weird issues with connection parameters stuffing it up 
with multiple connections, this is a specific case though. I think it's better 
to handle it manually by just rejecting the request and then calling 
`ble_gap_update_params()` afterward. This may cause issues if your peripherals 
are picky about accepting their parameters though, in which case there's not 
much else to do but maintain this patch in your own code. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] h2zero commented on issue #783: Make ble_gap_rx_l2cap_update_req() behave like ble_gap_rx_param_req()

2020-04-07 Thread GitBox
h2zero commented on issue #783: Make ble_gap_rx_l2cap_update_req() behave like 
ble_gap_rx_param_req()
URL: https://github.com/apache/mynewt-nimble/pull/783#issuecomment-610571660
 
 
   I’ve been seeing this happen as well on esp32. Only way to prevent it I have 
found is to reject the peer request then manually change the parameters after. 
This PR makes more sense.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services