[GitHub] [mynewt-core] de-nordic commented on issue #2165: FIx: advance_internal should return error instead of using assert
de-nordic commented on issue #2165: FIx: advance_internal should return error instead of using assert URL: https://github.com/apache/mynewt-core/pull/2165#issuecomment-603168639 Abandoned. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] de-nordic commented on issue #2165: FIx: advance_internal should return error instead of using assert
de-nordic commented on issue #2165: FIx: advance_internal should return error instead of using assert URL: https://github.com/apache/mynewt-core/pull/2165#issuecomment-578073217 For example, in zephyr this evaluates to empty expression which will make code proceed as if in case of success. Additionally it cause compilation to warn about unused err variable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
