[GitHub] [mynewt-core] sjanc commented on a diff in pull request #2890: Add ETH support to PIC32 boards

[GitBox]

sjanc commented on code in PR #2890:
URL: https://github.com/apache/mynewt-core/pull/2890#discussion_r984898727


##########
hw/mcu/microchip/pic32mz/src/pic32mz_periph.c:
##########
@@ -372,11 +384,23 @@ pic32mz_periph_i2c_devs(void)
     }
 }
 
+static void
+pic32mz_periph_create_eth(void)
+{
+#if MYNEWT_VAL(ETH_0)
+    int rc;
+    rc = pic32_eth_init(&eth0_cfg);
+    assert(0);

Review Comment:
   this looks odd,   assert(rc == 0) maybe?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org