[GitHub] [mynewt-core] sjanc commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER

2021-04-15 Thread GitBox 


sjanc commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820353281


   fair enough, two nitpicks though


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] sjanc commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER

2021-04-13 Thread GitBox 


sjanc commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-818562723


   why not just always enable icache than?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org