KKopyscinski commented on a change in pull request #1001:
URL: https://github.com/apache/mynewt-nimble/pull/1001#discussion_r673979906
##########
File path: nimble/host/src/ble_l2cap_sig.c
##########
@@ -1543,6 +1543,7 @@ ble_l2cap_sig_disc_req_rx(uint16_t conn_handle, struct
ble_l2cap_sig_hdr *hdr,
if (!chan || (le16toh(req->scid) != chan->dcid)) {
os_mbuf_free_chain(txom);
ble_hs_unlock();
+ ble_l2cap_sig_reject_invalid_cid_tx(conn_handle, hdr->identifier,
req->dcid, req->scid);
Review comment:
I pushed the change but I checked it out again and turns out that this
requires another one PTS issue ticket: TS says that lower tester should send
invalid DCID, but PTS sends invalid SCID and valid DCID and expects
disconnection. Of course what we got here is OK, it just allowed test to pass
when it was wrong (before the push)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
