[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #540: nimble/host: Add support to accept or reject pairing request through GAP event

2021-04-15 Thread GitBox 


apache-mynewt-bot commented on pull request #540:
URL: https://github.com/apache/mynewt-nimble/pull/540#issuecomment-820402832


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #540: nimble/host: Add support to accept or reject pairing request through GAP event

2021-04-05 Thread GitBox 


apache-mynewt-bot commented on pull request #540:
URL: https://github.com/apache/mynewt-nimble/pull/540#issuecomment-813635131


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #540: nimble/host: Add support to accept or reject pairing request through GAP event

2021-04-05 Thread GitBox 


apache-mynewt-bot commented on pull request #540:
URL: https://github.com/apache/mynewt-nimble/pull/540#issuecomment-813631485


   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/include/host/ble_sm.h
   
   
   ```diff
   @@ -101,9 +101,9 @@
uint8_t action;
union {
uint32_t passkey;
   -uint8_t  oob[16];
   -uint8_t  numcmp_accept;
   -uint8_t  pairing_accept;
   +uint8_t oob[16];
   +uint8_t numcmp_accept;
   +uint8_t pairing_accept;
struct {
struct ble_sm_sc_oob_data *local;
struct ble_sm_sc_oob_data *remote;
   ```
   
   
   
    nimble/host/src/ble_sm.c
   
   
   ```diff
   @@ -934,8 +933,8 @@
}

if (proc->state == BLE_SM_PROC_STATE_NONE &&
   -   ((res->passkey_params.action != BLE_SM_IOACT_JUSTWORKS) ||
   -(res->passkey_params.action != BLE_SM_IOACT_REJECT))) {
   +((res->passkey_params.action != BLE_SM_IOACT_JUSTWORKS) ||
   + (res->passkey_params.action != BLE_SM_IOACT_REJECT))) {
rm = 1;
}

   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #540: nimble/host: Add support to accept or reject pairing request through GAP event

2020-05-21 Thread GitBox 


apache-mynewt-bot commented on pull request #540:
URL: https://github.com/apache/mynewt-nimble/pull/540#issuecomment-632318634


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #540: nimble/host: Add support to accept or reject pairing request through GAP event

2020-05-21 Thread GitBox 


apache-mynewt-bot commented on pull request #540:
URL: https://github.com/apache/mynewt-nimble/pull/540#issuecomment-632310248


   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_sm.c
   
   
   ```diff
   @@ -1813,12 +1812,12 @@
 */
rc = ble_sm_pairing_req(conn_handle, req);
if (rc != 0) {
   - /* The app indicated that the pairing request should be rejected. 
*/
   - res->sm_err = BLE_SM_ERR_AUTHREQ;
   - res->app_status = BLE_HS_SM_US_ERR(rc);
   - res->execute = 0;
   - return;
   - }
   +/* The app indicated that the pairing request should be rejected. */
   +res->sm_err = BLE_SM_ERR_AUTHREQ;
   +res->app_status = BLE_HS_SM_US_ERR(rc);
   +res->execute = 0;
   +return;
   +}

/* Check if there is storage capacity for a new bond.  If there isn't, 
ask
 * the application to make room.
   ```
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org