[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
apache-mynewt-bot removed a comment on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-832442568
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/host/test/src/ble_sm_sc_test.c
```diff
@@ -2298,8 +2292,7 @@
* Responder key distribution: 5
* Peer responds with same public key
*/
-TEST_CASE_SELF(ble_sm_sc_us_pk_iio2_rio4_b1_iat0_rat0_ik7_rk5_peer_same_pk)
-{
+TEST_CASE_SELF(ble_sm_sc_us_pk_iio2_rio4_b1_iat0_rat0_ik7_rk5_peer_same_pk)
{
struct ble_sm_test_params params;
params = (struct ble_sm_test_params) {
```
nimble/host/test/src/ble_sm_test_util.c
```diff
@@ -2597,11 +2584,10 @@
}
static void
-ble_sm_test_util_us_sc_bad_once_no_init(
-struct ble_sm_test_params *params,
-struct ble_hs_conn *conn,
-struct ble_sm_test_util_entity *our_entity,
-struct ble_sm_test_util_entity *peer_entity)
+ble_sm_test_util_us_sc_bad_once_no_init(struct ble_sm_test_params *params,
+struct ble_hs_conn *conn,
+struct ble_sm_test_util_entity
*our_entity,
+struct ble_sm_test_util_entity
*peer_entity)
{
int rc;
@@ -2709,11 +2695,10 @@
}
static void
-ble_sm_test_util_peer_sc_good_once_no_init(
-struct ble_sm_test_params *params,
-struct ble_hs_conn *conn,
-struct ble_sm_test_util_entity *our_entity,
-struct ble_sm_test_util_entity *peer_entity)
+ble_sm_test_util_peer_sc_good_once_no_init(struct ble_sm_test_params
*params,
+ struct ble_hs_conn *conn,
+ struct ble_sm_test_util_entity
*our_entity,
+ struct ble_sm_test_util_entity
*peer_entity)
{
int num_iters;
int rc;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
apache-mynewt-bot removed a comment on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-831340410
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/host/test/src/ble_sm_sc_test.c
```diff
@@ -2298,8 +2292,7 @@
* Responder key distribution: 5
* Peer responds with same public key
*/
-TEST_CASE_SELF(ble_sm_sc_us_pk_iio2_rio4_b1_iat0_rat0_ik7_rk5_peer_same_pk)
-{
+TEST_CASE_SELF(ble_sm_sc_us_pk_iio2_rio4_b1_iat0_rat0_ik7_rk5_peer_same_pk)
{
struct ble_sm_test_params params;
params = (struct ble_sm_test_params) {
```
nimble/host/test/src/ble_sm_test_util.c
```diff
@@ -2597,11 +2584,10 @@
}
static void
-ble_sm_test_util_us_sc_bad_once_no_init(
-struct ble_sm_test_params *params,
-struct ble_hs_conn *conn,
-struct ble_sm_test_util_entity *our_entity,
-struct ble_sm_test_util_entity *peer_entity)
+ble_sm_test_util_us_sc_bad_once_no_init(struct ble_sm_test_params *params,
+struct ble_hs_conn *conn,
+struct ble_sm_test_util_entity
*our_entity,
+struct ble_sm_test_util_entity
*peer_entity)
{
int num_iters;
int rc;
@@ -2714,11 +2700,10 @@
}
static void
-ble_sm_test_util_peer_sc_good_once_no_init(
-struct ble_sm_test_params *params,
-struct ble_hs_conn *conn,
-struct ble_sm_test_util_entity *our_entity,
-struct ble_sm_test_util_entity *peer_entity)
+ble_sm_test_util_peer_sc_good_once_no_init(struct ble_sm_test_params
*params,
+ struct ble_hs_conn *conn,
+ struct ble_sm_test_util_entity
*our_entity,
+ struct ble_sm_test_util_entity
*peer_entity)
{
int num_iters;
int rc;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
apache-mynewt-bot removed a comment on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-824173296
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
apache-mynewt-bot removed a comment on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-820930665
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #971: nimble/host: Fix potential MITM vulnerability in case of secure connection pairing
apache-mynewt-bot removed a comment on pull request #971:
URL: https://github.com/apache/mynewt-nimble/pull/971#issuecomment-820315413
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
