[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #717: Add more detail about the MACRO description

2020-01-20 Thread GitBox 
sjanc commented on a change in pull request #717: Add more detail about the 
MACRO description
URL: https://github.com/apache/mynewt-nimble/pull/717#discussion_r368414014
 
 

 ##
 File path: nimble/controller/include/controller/ble_ll_sched.h
 ##
 @@ -31,13 +31,13 @@ extern "C" {
 /*
  * Worst case time needed for scheduled advertising item. This is the longest
  * possible time to receive a scan request and send a scan response (with the
- * appropriate IFS time between them). This number is calculated using the
+ * appropriate IFS time between them) on LE Uncoded PHY 1M. This number is 
calculated using the
 
 Review comment:
   Please update PR with comment changes we discussed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #717: Add more detail about the MACRO description

2020-01-13 Thread GitBox 
sjanc commented on a change in pull request #717: Add more detail about the 
MACRO description
URL: https://github.com/apache/mynewt-nimble/pull/717#discussion_r365700276
 
 

 ##
 File path: nimble/controller/include/controller/ble_ll_sched.h
 ##
 @@ -31,13 +31,13 @@ extern "C" {
 /*
  * Worst case time needed for scheduled advertising item. This is the longest
  * possible time to receive a scan request and send a scan response (with the
- * appropriate IFS time between them). This number is calculated using the
+ * appropriate IFS time between them) on LE Uncoded PHY 1M. This number is 
calculated using the
 
 Review comment:
   Yeap, I'm fine with emphasizing that this is for legacy PDUs.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #717: Add more detail about the MACRO description

2020-01-07 Thread GitBox 
sjanc commented on a change in pull request #717: Add more detail about the 
MACRO description
URL: https://github.com/apache/mynewt-nimble/pull/717#discussion_r363681800
 
 

 ##
 File path: nimble/controller/include/controller/ble_ll_sched.h
 ##
 @@ -31,13 +31,13 @@ extern "C" {
 /*
  * Worst case time needed for scheduled advertising item. This is the longest
  * possible time to receive a scan request and send a scan response (with the
- * appropriate IFS time between them). This number is calculated using the
+ * appropriate IFS time between them) on LE Uncoded PHY 1M. This number is 
calculated using the
 
 Review comment:
   this is about legacy PDUs and those are on 1M by definition so not sure if 
this clear anything


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services