[GitHub] jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx

2018-02-08 Thread GitBox
jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx URL: https://github.com/apache/mynewt-core/pull/763#issuecomment-364343396 ADC is now in with minimal changes (for better or worse) Were getting close to squashing this. But mlaz and I are going back

[GitHub] jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx

2018-02-06 Thread GitBox
jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx URL: https://github.com/apache/mynewt-core/pull/763#issuecomment-363660211 @mlaz and I worked tonight on the port. Were pulling out the problematic nrfx_config, as its pretty clear the way this was handled in the

[GitHub] jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx

2018-02-06 Thread GitBox
jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx URL: https://github.com/apache/mynewt-core/pull/763#issuecomment-363660211 @mlaz and I worked tonight on the port. Were pulling out the problematic nrfx_config, as its pretty clear the way this was handled in the

[GitHub] jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx

2018-02-06 Thread GitBox
jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx URL: https://github.com/apache/mynewt-core/pull/763#issuecomment-363620970 @mlaz Seems like you deleted the adc_test you had in here? What did you run on nrf52 that I can test on nrf51?

[GitHub] jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx

2018-02-05 Thread GitBox
jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx URL: https://github.com/apache/mynewt-core/pull/763#issuecomment-363240635 Of note, the old nordic adc and pwm implementations are using the driver(drv) not hal implementations which can get pretty tied into

[GitHub] jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx

2018-02-05 Thread GitBox
jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx URL: https://github.com/apache/mynewt-core/pull/763#issuecomment-363240635 Of note, the old nordic adc and pwm implementations are using the driver(drv) not hal implementations which can get pretty tied into

[GitHub] jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx

2018-02-05 Thread GitBox
jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx URL: https://github.com/apache/mynewt-core/pull/763#issuecomment-363176817 Im not sure what you need tested for Test HAL I2C but I ran my drv2605 driver successfully on an nrf52 thingy

[GitHub] jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx

2018-02-05 Thread GitBox
jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx URL: https://github.com/apache/mynewt-core/pull/763#issuecomment-363169047 Are we trying to bring this in at the hal level or the driver level?

[GitHub] jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx

2018-02-05 Thread GitBox
jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx URL: https://github.com/apache/mynewt-core/pull/763#issuecomment-363152553 Trying to build this on an nrf52 thingy I get a compilation error ``` Error:

[GitHub] jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx

2018-01-24 Thread GitBox
jacobrosenthal commented on issue #763: [WIP - Do not merge] Integrate nrfx URL: https://github.com/apache/mynewt-core/pull/763#issuecomment-360356914 I can probably take the adc_nrf51 driver This is an automated message from