[GitHub] mkiiskila commented on issue #757: HW driver: drv2605l

2018-02-12 Thread GitBox
mkiiskila commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-365167518 You can merge your PRs yourself. We seem to have adopted a method of doing this where the person who opened the PR merges the code in after it has been

[GitHub] mkiiskila commented on issue #757: HW driver: drv2605l

2018-02-12 Thread GitBox
mkiiskila commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-365035593 Those could be done in a separate PR. IMHO, for static functions the length check does not seem as crucial, as the callers are local to file, and these can