sjanc commented on issue #671: Extended Advertising API URL: https://github.com/apache/mynewt-core/pull/671#issuecomment-346381104 Hi Chris, thanks for review! I think I've fixed all the issues mentioned, and few other bugs as well that I found while working on your comments:-) some notes: in ble_hs_hci_evt_le_adv_set_terminated() I left ble_gap_rx_conn_complete without error check as we need to terminate instance regardless of it (TBH I was thinking on making all HCI event handlers return void as there is nothing we can do on such errors anyway). For clarity, I added comment that this check is omitted on purpose.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
