This is an automated email from the ASF dual-hosted git repository.

utzig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git

commit fe9f26e670180220ca33dfb349a4c2b0ad7b2cac
Author: David Brown <david.br...@linaro.org>
AuthorDate: Wed Nov 22 13:55:00 2017 -0700

    newt: Remove execute permission on generated images
    
    The generated images are not executable on the host and should not have
    the execute bit set on them.  Change the permissions to allow read and
    write (mitigated by the umask) on the generated images.
---
 newt/image/image.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/newt/image/image.go b/newt/image/image.go
index 8a9f69e..0c20459 100644
--- a/newt/image/image.go
+++ b/newt/image/image.go
@@ -555,7 +555,7 @@ func (image *Image) generateV1(loader *Image) error {
        }
 
        imgFile, err := os.OpenFile(image.TargetImg,
-               os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0777)
+               os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0666)
        if err != nil {
                return util.NewNewtError(fmt.Sprintf("Can't open target image 
%s: %s",
                        image.TargetImg, err.Error()))
@@ -835,7 +835,7 @@ func (image *Image) generateV2(loader *Image) error {
        }
 
        imgFile, err := os.OpenFile(image.TargetImg,
-               os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0777)
+               os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0666)
        if err != nil {
                return util.NewNewtError(fmt.Sprintf("Can't open target image 
%s: %s",
                        image.TargetImg, err.Error()))

-- 
To stop receiving notification emails like this one, please contact
"commits@mynewt.apache.org" <commits@mynewt.apache.org>.

Reply via email to