This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
     new 2dba93dc8a JS: Enable contiouus completion of JS private members of 
classes (# prefixed)
     new 76ba9d1696 Merge pull request #6741 from 
matthiasblaesing/js_class_private_completion
2dba93dc8a is described below

commit 2dba93dc8af98c6525500b1bb29ef8debe65a54f
Author: Matthias Bläsing <mblaes...@doppel-helix.eu>
AuthorDate: Wed Nov 22 20:09:38 2023 +0100

    JS: Enable contiouus completion of JS private members of classes (# 
prefixed)
    
    The description of issues 214978 and 223050 was manually checked and
    behavior seems to be identical between master and this version.
    
    Unittests were run and did not regress.
    
    Closes: #6734
---
 .../org/netbeans/modules/javascript2/editor/JsLanguage.java  | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git 
a/webcommon/javascript2.editor/src/org/netbeans/modules/javascript2/editor/JsLanguage.java
 
b/webcommon/javascript2.editor/src/org/netbeans/modules/javascript2/editor/JsLanguage.java
index e0218805fe..dab743021b 100644
--- 
a/webcommon/javascript2.editor/src/org/netbeans/modules/javascript2/editor/JsLanguage.java
+++ 
b/webcommon/javascript2.editor/src/org/netbeans/modules/javascript2/editor/JsLanguage.java
@@ -165,11 +165,13 @@ public class JsLanguage extends DefaultLanguageConfig {
     public boolean isIdentifierChar(char c) {
         return super.isIdentifierChar(c)
                 // due to CC filtering of DOC annotations - see 
GsfCompletionProvider#getCompletableLanguage()
-                || c == '@'; //NOI18N
-                // see issue #214978 - it goes to the 
CodeTemplateCompletionProvider#query(), it would probably deserve
-                //  new API in the next release or are we wrongly embedding 
the jQuery? For now this fix doesn't look to
-                //  make troubles to another areas.
-//                || c == '#' || c == ':' || c == '.'; //NOI18N
+                || c == '@' //NOI18N
+                || c == '#' //NOI18N
+                //// see issue #214978 - it goes to the 
CodeTemplateCompletionProvider#query(), it would probably deserve
+                ////  new API in the next release or are we wrongly embedding 
the jQuery? For now this fix doesn't look to
+                ////  make troubles to another areas.
+                // || c == ':' || c == '.'; //NOI18N
+                ;
     }
 
     @Override


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to