[jira] [Commented] (NETBEANS-168) Background scanning process needs a rethink
[ https://issues.apache.org/jira/browse/NETBEANS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648953#comment-16648953 ] Christian Lenz commented on NETBEANS-168: - [~lkishalmi] sounds really great Thx for the explanation. I really appreciate your work. Doesn't matter what you did or not :) > Background scanning process needs a rethink > --- > > Key: NETBEANS-168 > URL: https://issues.apache.org/jira/browse/NETBEANS-168 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance, java - Platform, platform - Execution >Affects Versions: 8.2, Next > Environment: NetBeans 8.2, Windows 10 x64 >Reporter: Christian Lenz >Priority: Critical > > Often, while cloning, switching branch, merging, opening etc. etc. NetBeans > starts Background scanning for changes, but it is not real background, > because everything what you want to do then, like changing the branch, > commit, push, pull, open project, delete or whatever, is blocking by this > task and you can't cancel it, because it is essential. > Either we need to rethink about this process like to make everything or most > of the stuff doing things in parallel or the task should really be > cancelable. It is a pain in the ass for big projects when they start to scan > for changes. > It is a real world case because you acan see it when you work on NetBeans > modules. > Cheers > Chris -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-49) Please add smooth scrolling
[ https://issues.apache.org/jira/browse/NETBEANS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648959#comment-16648959 ] Christian Lenz commented on NETBEANS-49: Hey [~ebakke] hm ok, I thought that it was already in branch 100. Unfortunately not? IMHO, if everything was fine with that, it would be very nice, if we can have it in this release, but sure, maybe we should ask this topic at the mailing list, if this is still possible and an option. If not, yes it will come in 3 months into NetBeans 11.0. > Please add smooth scrolling > > > Key: NETBEANS-49 > URL: https://issues.apache.org/jira/browse/NETBEANS-49 > Project: NetBeans > Issue Type: Improvement > Components: platform - Window System >Reporter: Christian Lenz >Priority: Major > Labels: pull-request-available > Fix For: 10.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Inside the editor, when I scroll with my touchpad to the bottom, it jumps 9 > lines to the next, this is a lot. I don't like such gappings I would like to > have a smooth stepless scrolling, like in chrome or other windows native > apps. Please add this for horizontal and vertical scrolling, it will be much > better. Not only in editors, it should be available everywhere, where we have > scrollbars. > Regards > Chris -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1145) Automate build of Windows Launchers
[ https://issues.apache.org/jira/browse/NETBEANS-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi updated NETBEANS-1145: -- Priority: Major (was: Minor) > Automate build of Windows Launchers > --- > > Key: NETBEANS-1145 > URL: https://issues.apache.org/jira/browse/NETBEANS-1145 > Project: NetBeans > Issue Type: Improvement > Components: apisupport - Harness, platform - Launchers&CLI >Reporter: Svatopluk Dedic >Priority: Major > > See comments in > [https://github.com/apache/incubator-netbeans/pull/573#pullrequestreview-147108327] > : > The envisioned build process should monitor: > * apisupport.harness/lwindows-launcher-src > * ide/launcher/windows > * o.n.bootstrap/launcher/windows > and rebuild netbeans or application launchers. I am not so sure about > automatic upload to the extbin, the number of artifact from automated builds > could reach quite high. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-1415) Windows Launcher Build Scripts Broken After NB Folder Restructure.
Laszlo Kishalmi created NETBEANS-1415: - Summary: Windows Launcher Build Scripts Broken After NB Folder Restructure. Key: NETBEANS-1415 URL: https://issues.apache.org/jira/browse/NETBEANS-1415 Project: NetBeans Issue Type: Bug Components: platform - Launchers&CLI Affects Versions: 10.0 Reporter: Laszlo Kishalmi Assignee: Laszlo Kishalmi Well the Windows Launcher build needs to be updated with the new directory structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1415) Windows Launcher Build Scripts Broken After NB Folder Restructure.
[ https://issues.apache.org/jira/browse/NETBEANS-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-1415: - Labels: Windows pull-request-available (was: Windows) > Windows Launcher Build Scripts Broken After NB Folder Restructure. > -- > > Key: NETBEANS-1415 > URL: https://issues.apache.org/jira/browse/NETBEANS-1415 > Project: NetBeans > Issue Type: Bug > Components: platform - Launchers&CLI >Affects Versions: 10.0 >Reporter: Laszlo Kishalmi >Assignee: Laszlo Kishalmi >Priority: Blocker > Labels: Windows, pull-request-available > > Well the Windows Launcher build needs to be updated with the new directory > structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1145) Automate build of Windows Launchers
[ https://issues.apache.org/jira/browse/NETBEANS-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649258#comment-16649258 ] Laszlo Kishalmi commented on NETBEANS-1145: --- Thank you [~ebakke] for the instructions! After fixing NETBEANS-1415 locally I was able to build the Window launchers on Ubuntu. I'm going to create an INFRA request to make the required packages available on our build nodes. > Automate build of Windows Launchers > --- > > Key: NETBEANS-1145 > URL: https://issues.apache.org/jira/browse/NETBEANS-1145 > Project: NetBeans > Issue Type: Improvement > Components: apisupport - Harness, platform - Launchers&CLI >Reporter: Svatopluk Dedic >Priority: Major > > See comments in > [https://github.com/apache/incubator-netbeans/pull/573#pullrequestreview-147108327] > : > The envisioned build process should monitor: > * apisupport.harness/lwindows-launcher-src > * ide/launcher/windows > * o.n.bootstrap/launcher/windows > and rebuild netbeans or application launchers. I am not so sure about > automatic upload to the extbin, the number of artifact from automated builds > could reach quite high. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[incubator-netbeans] branch master updated: For multi-release modular jars, use the newest module-info available when detecting module name.
This is an automated email from the ASF dual-hosted git repository. jlahoda pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git The following commit(s) were added to refs/heads/master by this push: new 4f168de For multi-release modular jars, use the newest module-info available when detecting module name. 4f168de is described below commit 4f168de17f3936ae5c5b2eab694b60b984037066 Author: Jan Lahoda AuthorDate: Thu Oct 4 07:31:39 2018 +0200 For multi-release modular jars, use the newest module-info available when detecting module name. --- .../netbeans/modules/java/source/ModuleNames.java | 23 - .../modules/java/source/ModuleNamesTest.java | 39 ++ 2 files changed, 61 insertions(+), 1 deletion(-) diff --git a/java/java.source.base/src/org/netbeans/modules/java/source/ModuleNames.java b/java/java.source.base/src/org/netbeans/modules/java/source/ModuleNames.java index 8073c10..b4b7562 100644 --- a/java/java.source.base/src/org/netbeans/modules/java/source/ModuleNames.java +++ b/java/java.source.base/src/org/netbeans/modules/java/source/ModuleNames.java @@ -129,7 +129,28 @@ public final class ModuleNames { final FileObject root = URLMapper.findFileObject(rootUrl); if (root != null) { final FileObject file = FileUtil.getArchiveFile(root); -final FileObject moduleInfo = root.getFileObject(FileObjects.MODULE_INFO, FileObjects.CLASS); +FileObject moduleInfo = null; +//try versioned module-infos, as the source/target level is not available here, +//use the most up-to-date version: +FileObject versions = root.getFileObject("META-INF/versions"); +if (versions != null) { +int version = -1; +for (FileObject c : versions.getChildren()) { +try { +int currentVersion = Integer.parseInt(c.getNameExt()); +FileObject currentMI = c.getFileObject(FileObjects.MODULE_INFO, FileObjects.CLASS); +if (currentVersion > version && currentMI != null) { +moduleInfo = currentMI; +version = currentVersion; +} +} catch (NumberFormatException ex) { +//ok, ignore +} +} +} +if (moduleInfo == null) { +moduleInfo = root.getFileObject(FileObjects.MODULE_INFO, FileObjects.CLASS); +} if (moduleInfo != null) { try { final String modName = readModuleName(moduleInfo); diff --git a/java/java.source.base/test/unit/src/org/netbeans/modules/java/source/ModuleNamesTest.java b/java/java.source.base/test/unit/src/org/netbeans/modules/java/source/ModuleNamesTest.java index 1fd092e..d177add 100644 --- a/java/java.source.base/test/unit/src/org/netbeans/modules/java/source/ModuleNamesTest.java +++ b/java/java.source.base/test/unit/src/org/netbeans/modules/java/source/ModuleNamesTest.java @@ -432,6 +432,45 @@ public class ModuleNamesTest extends NbTestCase { } } +public void testVersionedModuleInfo() throws IOException { +final TraceHandler th = TraceHandler.register(); +try { +FileObject mod = FileUtil.getArchiveRoot(jar( +wd, +"dist.jar", //NOI18N +() -> Collections.singleton(Pair.of( +"META-INF/versions/9/module-info.class", //NOI18N +moduleInfoClz(moduleInfoJava("org.me.app", Collections.emptyList())).get()))//NOI18N +).get()); +String moduleName = names.getModuleName(mod.toURL(), false); +assertEquals("org.me.app", moduleName);//NOI18N +assertTrue(th.isCalculated()); +th.reset(); +mod = FileUtil.getArchiveRoot(jar( +wd, +"dist2.jar", //NOI18N +() -> Arrays.asList(Pair.of( +"META-INF/versions/9/module-info.class", //NOI18N +moduleInfoClz(moduleInfoJava("org.me.app", Collections.emptyList())).get()),//NOI18N +Pair.of( +"META-INF/versions/12/module-info.class", //NOI18N +moduleInfoClz(moduleInfoJava("org.me.app2", Collections.emptyList())).get()),//NOI18N +Pair.of( +"META-INF/versions/broken/module-info.class", //NOI18N +moduleInfoClz(moduleInfoJava("broken", Collections.empty
[incubator-netbeans] branch master updated: [NETBEANS-1386]: Fixing handling of non-modularized repositories in project.ActionProviderImpl.
This is an automated email from the ASF dual-hosted git repository. jlahoda pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git The following commit(s) were added to refs/heads/master by this push: new 9a14489 [NETBEANS-1386]: Fixing handling of non-modularized repositories in project.ActionProviderImpl. 9a14489 is described below commit 9a144897ed40f9091df133d6be05e0c4078c9392 Author: Jan Lahoda AuthorDate: Tue Oct 9 07:57:44 2018 +0200 [NETBEANS-1386]: Fixing handling of non-modularized repositories in project.ActionProviderImpl. --- .../netbeans/modules/java/openjdk/project/ActionProviderImpl.java | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/project/ActionProviderImpl.java b/java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/project/ActionProviderImpl.java index 9f71140..fae5bb8 100644 --- a/java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/project/ActionProviderImpl.java +++ b/java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/project/ActionProviderImpl.java @@ -112,7 +112,7 @@ public class ActionProviderImpl implements ActionProvider { genericScript = FileUtil.toFileObject(scriptFile); -if (project.moduleRepository.isConsolidatedRepo()) { +if (project.currentModule != null && project.moduleRepository.isConsolidatedRepo()) { String repoName = ShortcutUtils.getDefault().inferLegacyRepository(project); File fastBuild = InstalledFileLocator.getDefault().locate("scripts/build-" + repoName + "-consol.xml", "org.netbeans.modules.java.openjdk.project", false); if (fastBuild != null && ShortcutUtils.getDefault().shouldUseCustomBuild(repoName, FileUtil.getRelativePath(repo, project.getProjectDirectory( { @@ -185,7 +185,10 @@ public class ActionProviderImpl implements ActionProvider { command = COMMAND_BUILD_FAST; //XXX: should only do this if genericScript supports it } Properties props = new Properties(); -props.put("basedir", FileUtil.toFile(scriptFO == genericScript ? project.moduleRepository.getJDKRoot() : repository).getAbsolutePath()); +FileObject basedirFO = project.currentModule != null ? scriptFO == genericScript ? project.moduleRepository.getJDKRoot() + : repository + : repository.getParent(); +props.put("basedir", FileUtil.toFile(basedirFO).getAbsolutePath()); props.put("CONF", project.configurations.getActiveConfiguration().getLocation().getName()); props.put("nb.jdk.project.target.java.home", BuildUtils.findTargetJavaHome(project.getProjectDirectory()).getAbsolutePath()); RootKind kind = getKind(context); - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists