[netbeans] branch master updated (1bfefb6 -> 82af896)
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 1bfefb6 Merge pull request #2441 from Akshay-Gupta-Oracle/removeExtraGetPermit add 82af896 [NETBEANS-4891] Fix missing file node of generic Gradle root project No new revisions were added by this update. Summary of changes: .travis.yml| 1 + .../gradle/queries/GenericProjectSources.java | 111 + .../gradle/queries/GenericProjectSourcesTest.java | 53 ++ java/gradle.java/nbproject/project.properties | 1 + java/gradle.java/nbproject/project.xml | 9 +- .../gradle/java/classpath/GradleSourcesImpl.java | 5 - .../gradle/java/AbstractGradleJavaTestCase.java| 81 --- .../java/classpath/ClassPathProviderImplTest.java | 4 +- .../java/classpath/GradleSourcesImplTest.java | 15 ++- 9 files changed, 185 insertions(+), 95 deletions(-) create mode 100644 extide/gradle/src/org/netbeans/modules/gradle/queries/GenericProjectSources.java create mode 100644 extide/gradle/test/unit/src/org/netbeans/modules/gradle/queries/GenericProjectSourcesTest.java delete mode 100644 java/gradle.java/test/unit/src/org/netbeans/modules/gradle/java/AbstractGradleJavaTestCase.java - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated (1bfefb6 -> 82af896)
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 1bfefb6 Merge pull request #2441 from Akshay-Gupta-Oracle/removeExtraGetPermit add 82af896 [NETBEANS-4891] Fix missing file node of generic Gradle root project No new revisions were added by this update. Summary of changes: .travis.yml| 1 + .../gradle/queries/GenericProjectSources.java | 111 + .../gradle/queries/GenericProjectSourcesTest.java | 53 ++ java/gradle.java/nbproject/project.properties | 1 + java/gradle.java/nbproject/project.xml | 9 +- .../gradle/java/classpath/GradleSourcesImpl.java | 5 - .../gradle/java/AbstractGradleJavaTestCase.java| 81 --- .../java/classpath/ClassPathProviderImplTest.java | 4 +- .../java/classpath/GradleSourcesImplTest.java | 15 ++- 9 files changed, 185 insertions(+), 95 deletions(-) create mode 100644 extide/gradle/src/org/netbeans/modules/gradle/queries/GenericProjectSources.java create mode 100644 extide/gradle/test/unit/src/org/netbeans/modules/gradle/queries/GenericProjectSourcesTest.java delete mode 100644 java/gradle.java/test/unit/src/org/netbeans/modules/gradle/java/AbstractGradleJavaTestCase.java - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-4891] Fix missing file node of generic Gradle root project
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 82af896 [NETBEANS-4891] Fix missing file node of generic Gradle root
project
82af896 is described below
commit 82af8969406ae36fd9768e2ba901ab2f8b06d3d4
Author: Laszlo Kishalmi
AuthorDate: Fri Oct 9 11:11:13 2020 -0700
[NETBEANS-4891] Fix missing file node of generic Gradle root project
---
.travis.yml| 1 +
.../gradle/queries/GenericProjectSources.java | 111 +
.../gradle/queries/GenericProjectSourcesTest.java | 53 ++
java/gradle.java/nbproject/project.properties | 1 +
java/gradle.java/nbproject/project.xml | 9 +-
.../gradle/java/classpath/GradleSourcesImpl.java | 5 -
.../gradle/java/AbstractGradleJavaTestCase.java| 81 ---
.../java/classpath/ClassPathProviderImplTest.java | 4 +-
.../java/classpath/GradleSourcesImplTest.java | 15 ++-
9 files changed, 185 insertions(+), 95 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 3903520..8ccec65 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -360,6 +360,7 @@ matrix:
- hide-logs.sh ant $OPTS -f java/debugger.jpda.js test
- hide-logs.sh ant $OPTS -f java/debugger.jpda.projects test
- hide-logs.sh ant $OPTS -f java/debugger.jpda.projectsui test
+- hide-logs.sh ant $OPTS -f java/gradle.java test
#- ant $OPTS -f java/debugger.jpda.truffle test
#- ant $OPTS -f java/debugger.jpda.ui test
- travis_wait hide-logs.sh ant $OPTS -f java/editor.htmlui test
diff --git
a/extide/gradle/src/org/netbeans/modules/gradle/queries/GenericProjectSources.java
b/extide/gradle/src/org/netbeans/modules/gradle/queries/GenericProjectSources.java
new file mode 100644
index 000..64e422f
--- /dev/null
+++
b/extide/gradle/src/org/netbeans/modules/gradle/queries/GenericProjectSources.java
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.gradle.queries;
+
+import java.beans.PropertyChangeListener;
+import javax.swing.Icon;
+import javax.swing.event.ChangeListener;
+import org.netbeans.api.project.FileOwnerQuery;
+import org.netbeans.api.project.Project;
+import org.netbeans.api.project.ProjectManager;
+import org.netbeans.api.project.ProjectUtils;
+import org.netbeans.api.project.SourceGroup;
+import org.netbeans.api.project.Sources;
+import org.netbeans.modules.gradle.api.NbGradleProject;
+import org.netbeans.spi.project.ProjectServiceProvider;
+import org.openide.filesystems.FileObject;
+import org.openide.filesystems.FileUtil;
+
+/**
+ *
+ * @author lkishalmi
+ */
+@ProjectServiceProvider(service = Sources.class, projectType =
NbGradleProject.GRADLE_PROJECT_TYPE)
+public class GenericProjectSources implements Sources {
+private final Project project;
+
+public GenericProjectSources(Project project) {
+this.project = project;
+}
+@Override
+public SourceGroup[] getSourceGroups(String type) {
+return Sources.TYPE_GENERIC.equals(type)? new SourceGroup[]{new
ProjectSourceGroup()} : new SourceGroup[0];
+}
+
+@Override
+public void addChangeListener(ChangeListener listener) {
+}
+
+@Override
+public void removeChangeListener(ChangeListener listener) {
+}
+
+private final class ProjectSourceGroup implements SourceGroup {
+
+public ProjectSourceGroup() {
+}
+
+@Override
+public FileObject getRootFolder() {
+return project.getProjectDirectory();
+}
+
+@Override
+public String getName() {
+return ProjectUtils.getInformation(project).getName();
+}
+
+@Override
+public String getDisplayName() {
+return ProjectUtils.getInformation(project).getDisplayName();
+}
+
+@Override
+public Icon getIcon(boolean opened) {
+return null;
+}
+
+@Override
+public boolean
[netbeans] branch master updated: [NETBEANS-4891] Fix missing file node of generic Gradle root project
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 82af896 [NETBEANS-4891] Fix missing file node of generic Gradle root
project
82af896 is described below
commit 82af8969406ae36fd9768e2ba901ab2f8b06d3d4
Author: Laszlo Kishalmi
AuthorDate: Fri Oct 9 11:11:13 2020 -0700
[NETBEANS-4891] Fix missing file node of generic Gradle root project
---
.travis.yml| 1 +
.../gradle/queries/GenericProjectSources.java | 111 +
.../gradle/queries/GenericProjectSourcesTest.java | 53 ++
java/gradle.java/nbproject/project.properties | 1 +
java/gradle.java/nbproject/project.xml | 9 +-
.../gradle/java/classpath/GradleSourcesImpl.java | 5 -
.../gradle/java/AbstractGradleJavaTestCase.java| 81 ---
.../java/classpath/ClassPathProviderImplTest.java | 4 +-
.../java/classpath/GradleSourcesImplTest.java | 15 ++-
9 files changed, 185 insertions(+), 95 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 3903520..8ccec65 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -360,6 +360,7 @@ matrix:
- hide-logs.sh ant $OPTS -f java/debugger.jpda.js test
- hide-logs.sh ant $OPTS -f java/debugger.jpda.projects test
- hide-logs.sh ant $OPTS -f java/debugger.jpda.projectsui test
+- hide-logs.sh ant $OPTS -f java/gradle.java test
#- ant $OPTS -f java/debugger.jpda.truffle test
#- ant $OPTS -f java/debugger.jpda.ui test
- travis_wait hide-logs.sh ant $OPTS -f java/editor.htmlui test
diff --git
a/extide/gradle/src/org/netbeans/modules/gradle/queries/GenericProjectSources.java
b/extide/gradle/src/org/netbeans/modules/gradle/queries/GenericProjectSources.java
new file mode 100644
index 000..64e422f
--- /dev/null
+++
b/extide/gradle/src/org/netbeans/modules/gradle/queries/GenericProjectSources.java
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.gradle.queries;
+
+import java.beans.PropertyChangeListener;
+import javax.swing.Icon;
+import javax.swing.event.ChangeListener;
+import org.netbeans.api.project.FileOwnerQuery;
+import org.netbeans.api.project.Project;
+import org.netbeans.api.project.ProjectManager;
+import org.netbeans.api.project.ProjectUtils;
+import org.netbeans.api.project.SourceGroup;
+import org.netbeans.api.project.Sources;
+import org.netbeans.modules.gradle.api.NbGradleProject;
+import org.netbeans.spi.project.ProjectServiceProvider;
+import org.openide.filesystems.FileObject;
+import org.openide.filesystems.FileUtil;
+
+/**
+ *
+ * @author lkishalmi
+ */
+@ProjectServiceProvider(service = Sources.class, projectType =
NbGradleProject.GRADLE_PROJECT_TYPE)
+public class GenericProjectSources implements Sources {
+private final Project project;
+
+public GenericProjectSources(Project project) {
+this.project = project;
+}
+@Override
+public SourceGroup[] getSourceGroups(String type) {
+return Sources.TYPE_GENERIC.equals(type)? new SourceGroup[]{new
ProjectSourceGroup()} : new SourceGroup[0];
+}
+
+@Override
+public void addChangeListener(ChangeListener listener) {
+}
+
+@Override
+public void removeChangeListener(ChangeListener listener) {
+}
+
+private final class ProjectSourceGroup implements SourceGroup {
+
+public ProjectSourceGroup() {
+}
+
+@Override
+public FileObject getRootFolder() {
+return project.getProjectDirectory();
+}
+
+@Override
+public String getName() {
+return ProjectUtils.getInformation(project).getName();
+}
+
+@Override
+public String getDisplayName() {
+return ProjectUtils.getInformation(project).getDisplayName();
+}
+
+@Override
+public Icon getIcon(boolean opened) {
+return null;
+}
+
+@Override
+public boolean
[netbeans] branch master updated: [NETBEANS-3990]: Removing extra getPermit Method from TreeShims
This is an automated email from the ASF dual-hosted git repository.
akshaygupta pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 681f5e0 [NETBEANS-3990]: Removing extra getPermit Method from
TreeShims
new 1bfefb6 Merge pull request #2441 from
Akshay-Gupta-Oracle/removeExtraGetPermit
681f5e0 is described below
commit 681f5e07832bd8a448f9cd54f3df75de9bda9067
Author: Akshay=Gupta=Oracle
AuthorDate: Sun Oct 11 06:17:11 2020 +0530
[NETBEANS-3990]: Removing extra getPermit Method from TreeShims
---
.../JavaCompletionTask115FeaturesTest.java | 241 -
.../netbeans/modules/java/source/TreeShims.java| 14 --
2 files changed, 255 deletions(-)
diff --git
a/java/java.completion/test/unit/src/org/netbeans/modules/java/completion/JavaCompletionTask115FeaturesTest.java
b/java/java.completion/test/unit/src/org/netbeans/modules/java/completion/JavaCompletionTask115FeaturesTest.java
deleted file mode 100644
index 6f27a16..000
---
a/java/java.completion/test/unit/src/org/netbeans/modules/java/completion/JavaCompletionTask115FeaturesTest.java
+++ /dev/null
@@ -1,241 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.netbeans.modules.java.completion;
-
-import javax.lang.model.SourceVersion;
-import org.netbeans.junit.NbTestSuite;
-import org.netbeans.modules.java.source.parsing.JavacParser;
-
-
-/**
- *
- * @author arusinha
- */
-public class JavaCompletionTask115FeaturesTest extends CompletionTestBase {
-
-private static String SOURCE_LEVEL = "15"; //NOI18N
-
-public JavaCompletionTask115FeaturesTest(String testName) {
-super(testName);
-}
-
-public static NbTestSuite suite() {
-NbTestSuite suite = new NbTestSuite();
-try {
-SourceVersion.valueOf("RELEASE_15"); //NOI18N
-suite.addTestSuite(JavaCompletionTask115FeaturesTest.class);
-} catch (IllegalArgumentException ex) {
-//OK, no RELEASE_13, skip tests
-suite.addTest(new JavaCompletionTask115FeaturesTest("noop"));
//NOI18N
-}
-return suite;
-}
-
-public void testAfterTypeParams() throws Exception {
-performTest("Generics", 887, null,
"extendsAndImplementsAndPermitsKeywords.pass",SOURCE_LEVEL);
-}
-
-
-public void testAfterTypingTypeParams() throws Exception {
-performTest("GenericsNoTypeParams", 841, "", "extendsAndImplementsAndPermitsKeywords.pass",SOURCE_LEVEL);
-}
-
-public void testEmptyFileAfterTypingTypeParams() throws Exception {
-performTest("GenericsStart", 841, "", "extendsAndImplementsAndPermitsKeywords.pass",SOURCE_LEVEL);
-}
-
-public void testEmptyFileBeforeTypingDefaultModifier() throws Exception {
-performTest("Empty", 808, "package test;\ninterface Test {",
"interfaceMemberModifiersAndTypes.pass", SOURCE_LEVEL);
-}
-
-public void testBeforeDefaultModifier() throws Exception {
-performTest("Interface", 846, null,
"interfaceMemberModifiersAndTypes.pass", SOURCE_LEVEL);
-}
-
-public void testEmptyFileAfterTypingPackageDecl() throws Exception {
-performTest("Empty", 808, "package test;",
"topLevelKeywordsWithoutPackage.pass",SOURCE_LEVEL);
-}
-
-public void testEmptyFileAfterTypingIntefaceName() throws Exception {
-performTest("Empty", 808, "package test;\ninterface Test ",
"extendsAndPermitsKeywords.pass",SOURCE_LEVEL);
-}
-
-public void testEmptyFileBeforeTypingImplementsKeyword() throws Exception {
-performTest("Empty", 808, "package test;\npublic class Test extends
Object ", "implementsAndPermitsKeywords.pass",SOURCE_LEVEL);
-}
-
-public void testEmptyFileAfterTypingFieldDeclaration() throws Exception {
-performTest("MethodStart", 849, "public int field = hashCode() / 10;",
"memberModifiersTypesAndGenElements3.pass",SOURCE_LEVEL);
-}
-
-public void testEmptyFileAfterTypingMethodBody() throws Exception {
-performTest("MethodStart", 849, "public void op() {\n}",
"memberModifiersTypesAndGenElements.pass",SOURCE_LEVEL);
[netbeans] 01/01: Revert "[NETBEANS-3990]: Auto completion for Sealed Types"
This is an automated email from the ASF dual-hosted git repository.
akshaygupta pushed a commit to branch revert-2283-sealedAutocompletion
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit ec27aa6f6f93ad21c1abec6eb80085ef48e9b861
Author: Akshay Gupta <55184560+akshay-gupta-ora...@users.noreply.github.com>
AuthorDate: Sun Oct 11 05:37:43 2020 +0530
Revert "[NETBEANS-3990]: Auto completion for Sealed Types"
---
.../java/completion/JavaCompletionTask.java| 84 +--
.../15/CreateConstructorNonDefaultConstructor.pass | 155 -
...ConstructorNonDefaultConstructorInnerClass.pass | 153 -
.../15/CreateConstructorTest.pass | 156 -
.../15/CreateConstructorTestInnerClass.pass| 154 -
.../15/CreateConstructorWithConstructors.pass | 154 -
...reateConstructorWithConstructorsInnerClass.pass | 152 -
.../CreateConstructorWithDefaultConstructor.pass | 155 -
...onstructorWithDefaultConstructorInnerClass.pass | 153 -
.../15/OverrideAbstractList.pass | 176 ---
.../15/OverrideAbstractListAbstract.pass | 178 ---
.../15/UnimplementedMethod.pass| 142
.../15/classModifiersWithoutPublic.pass| 8 -
.../15/extendsAndImplementsAndPermitsKeywords.pass | 3 -
.../15/extendsAndPermitsKeywords.pass | 2 -
.../15/implementsAndPermitsKeywords.pass | 2 -
.../15/interfaceMemberModifiersAndTypes.pass | 140
.../15/memberModifiersStartingWithP.pass | 3 -
.../15/memberModifiersTypesAndGenElements.pass | 142
.../15/memberModifiersTypesAndGenElements2.pass| 143
.../15/memberModifiersTypesAndGenElements3.pass| 144
.../15/memberModifiersTypesAndGenElements4.pass| 150 -
.../JavaCompletionTaskTest/15/permitsKeyword.pass | 1 -
.../15/topLevelKeywords.pass | 11 -
.../15/topLevelKeywordsWithoutPackage.pass | 10 -
.../JavaCompletionTask115FeaturesTest.java | 241 -
.../netbeans/modules/java/source/TreeShims.java| 28 ---
27 files changed, 4 insertions(+), 2836 deletions(-)
diff --git
a/java/java.completion/src/org/netbeans/modules/java/completion/JavaCompletionTask.java
b/java/java.completion/src/org/netbeans/modules/java/completion/JavaCompletionTask.java
index 94d0d1e..47e18e5 100644
---
a/java/java.completion/src/org/netbeans/modules/java/completion/JavaCompletionTask.java
+++
b/java/java.completion/src/org/netbeans/modules/java/completion/JavaCompletionTask.java
@@ -49,7 +49,7 @@ import org.netbeans.api.java.source.ClassIndex.Symbols;
import org.netbeans.api.java.source.support.ErrorAwareTreePathScanner;
import org.netbeans.api.java.source.support.ReferencesCount;
import org.netbeans.api.lexer.TokenSequence;
-import org.netbeans.api.lexer.TokenUtilities;
+import org.netbeans.modules.java.completion.TreeShims;
import org.netbeans.modules.parsing.api.Source;
import org.openide.util.Pair;
@@ -168,19 +168,16 @@ public final class JavaCompletionTask extends BaseTask
{
private static final String MODULE_KEYWORD = "module"; //NOI18N
private static final String NATIVE_KEYWORD = "native"; //NOI18N
private static final String NEW_KEYWORD = "new"; //NOI18N
-private static final String NON_SEALED_KEYWORD = "non-sealed"; //NOI18N
private static final String NULL_KEYWORD = "null"; //NOI18N
private static final String OPEN_KEYWORD = "open"; //NOI18N
private static final String OPENS_KEYWORD = "opens"; //NOI18N
private static final String PACKAGE_KEYWORD = "package"; //NOI18N
-private static final String PERMITS_KEYWORD = "permits"; //NOI18N
private static final String PRIVATE_KEYWORD = "private"; //NOI18N
private static final String PROTECTED_KEYWORD = "protected"; //NOI18N
private static final String PROVIDES_KEYWORD = "provides"; //NOI18N
private static final String PUBLIC_KEYWORD = "public"; //NOI18N
private static final String RETURN_KEYWORD = "return"; //NOI18N
private static final String REQUIRES_KEYWORD = "requires"; //NOI18N
-private static final String SEALED_KEYWORD = "sealed"; //NOI18N
private static final String SHORT_KEYWORD = "short"; //NOI18N
private static final String STATIC_KEYWORD = "static"; //NOI18N
private static final String STRICT_KEYWORD = "strictfp"; //NOI18N
@@ -241,10 +238,8 @@ public final class JavaCompletionTask extends BaseTask {
private static final SourceVersion SOURCE_VERSION_RELEASE_11;
private static final SourceVersion SOURCE_VERSION_RELEASE_13;
private static final SourceVersion SOURCE_VERSION_RELEASE_14;
-private static final SourceVersion SOURCE_VERSION_RELEASE_15;
-
static {
-SourceVersion r10, r11, r13, r14, r15;
+
[netbeans] branch revert-2283-sealedAutocompletion created (now ec27aa6)
This is an automated email from the ASF dual-hosted git repository. akshaygupta pushed a change to branch revert-2283-sealedAutocompletion in repository https://gitbox.apache.org/repos/asf/netbeans.git. at ec27aa6 Revert "[NETBEANS-3990]: Auto completion for Sealed Types" This branch includes the following new commits: new ec27aa6 Revert "[NETBEANS-3990]: Auto completion for Sealed Types" The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch hectorespert-patch-1 updated (46e4361 -> 17df456)
This is an automated email from the ASF dual-hosted git repository. hectorespert pushed a change to branch hectorespert-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 46e4361 Clean jobs from Travis add 17df456 Run build No new revisions were added by this update. Summary of changes: nbbuild/jenkins/linux/Jenkinsfile.groovy | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch hectorespert-patch-1 updated (dbc140d -> 46e4361)
This is an automated email from the ASF dual-hosted git repository. hectorespert pushed a change to branch hectorespert-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from dbc140d Verify libs and licenses add 46e4361 Clean jobs from Travis No new revisions were added by this update. Summary of changes: .travis.yml | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch hectorespert-patch-1 updated (d7f254f -> dbc140d)
This is an automated email from the ASF dual-hosted git repository. hectorespert pushed a change to branch hectorespert-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from d7f254f Fix artifacts add dbc140d Verify libs and licenses No new revisions were added by this update. Summary of changes: nbbuild/jenkins/linux/Jenkinsfile.groovy | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch hectorespert-patch-1 updated (08c8bcf -> d7f254f)
This is an automated email from the ASF dual-hosted git repository. hectorespert pushed a change to branch hectorespert-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 08c8bcf Publish rat reports add d7f254f Fix artifacts No new revisions were added by this update. Summary of changes: nbbuild/jenkins/linux/Jenkinsfile.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch hectorespert-patch-1 updated (ecca5b8 -> 08c8bcf)
This is an automated email from the ASF dual-hosted git repository. hectorespert pushed a change to branch hectorespert-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from ecca5b8 Update Jenkinsfile.groovy add 08c8bcf Publish rat reports No new revisions were added by this update. Summary of changes: nbbuild/jenkins/linux/Jenkinsfile.groovy | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch hectorespert-patch-1 updated (990b809 -> ecca5b8)
This is an automated email from the ASF dual-hosted git repository. hectorespert pushed a change to branch hectorespert-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 990b809 Update Jenkinsfile.groovy add ecca5b8 Update Jenkinsfile.groovy No new revisions were added by this update. Summary of changes: nbbuild/jenkins/linux/Jenkinsfile.groovy | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch hectorespert-patch-1 updated (cb42c22 -> 990b809)
This is an automated email from the ASF dual-hosted git repository. hectorespert pushed a change to branch hectorespert-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from cb42c22 Test rat report add 990b809 Update Jenkinsfile.groovy No new revisions were added by this update. Summary of changes: nbbuild/jenkins/linux/Jenkinsfile.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch hectorespert-patch-1 updated (05abfc7 -> cb42c22)
This is an automated email from the ASF dual-hosted git repository. hectorespert pushed a change to branch hectorespert-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 05abfc7 Update Jenkinsfile.groovy add cb42c22 Test rat report No new revisions were added by this update. Summary of changes: nbbuild/jenkins/linux/Jenkinsfile.groovy | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated (7990cee -> 429c454)
This is an automated email from the ASF dual-hosted git repository.
akshaygupta pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git.
from 7990cee NETBEANS-4533 : Netbeans 4533 chinese char problem table
header (#2435)
new 0c53bab [NETBEANS-4311]: Auto completion for Sealed Types
new 429c454 Merge pull request #2283 from
Akshay-Gupta-Oracle/sealedAutocompletion
The 4480 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../java/completion/JavaCompletionTask.java| 84 ++-
.../15/CreateConstructorNonDefaultConstructor.pass | 155 +
...ConstructorNonDefaultConstructorInnerClass.pass | 153 +
.../15/CreateConstructorTest.pass | 156 +
.../15/CreateConstructorTestInnerClass.pass| 154 +
.../15/CreateConstructorWithConstructors.pass | 154 +
...reateConstructorWithConstructorsInnerClass.pass | 152 +
.../CreateConstructorWithDefaultConstructor.pass | 155 +
...onstructorWithDefaultConstructorInnerClass.pass | 153 +
.../15/OverrideAbstractList.pass | 176 +++
.../15/OverrideAbstractListAbstract.pass | 178 +++
.../15/UnimplementedMethod.pass| 142
.../15/classModifiersWithoutPublic.pass| 8 +
.../15/extendsAndImplementsAndPermitsKeywords.pass | 3 +
.../15/extendsAndPermitsKeywords.pass | 2 +
.../15/implementsAndPermitsKeywords.pass | 2 +
.../15/interfaceMemberModifiersAndTypes.pass | 140
.../{1.8 => 15}/memberModifiersStartingWithP.pass | 0
.../15/memberModifiersTypesAndGenElements.pass | 142
.../15/memberModifiersTypesAndGenElements2.pass| 143
.../15/memberModifiersTypesAndGenElements3.pass| 144
.../15/memberModifiersTypesAndGenElements4.pass| 150 +
.../JavaCompletionTaskTest/15/permitsKeyword.pass | 1 +
.../15/topLevelKeywords.pass | 11 +
.../15/topLevelKeywordsWithoutPackage.pass | 10 +
.../JavaCompletionTask115FeaturesTest.java | 241 +
.../netbeans/modules/java/source/TreeShims.java| 28 +++
27 files changed, 2833 insertions(+), 4 deletions(-)
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/CreateConstructorNonDefaultConstructor.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/CreateConstructorNonDefaultConstructorInnerClass.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/CreateConstructorTest.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/CreateConstructorTestInnerClass.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/CreateConstructorWithConstructors.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/CreateConstructorWithConstructorsInnerClass.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/CreateConstructorWithDefaultConstructor.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/CreateConstructorWithDefaultConstructorInnerClass.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/OverrideAbstractList.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/OverrideAbstractListAbstract.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/UnimplementedMethod.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/classModifiersWithoutPublic.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/extendsAndImplementsAndPermitsKeywords.pass
create mode 100644
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/15/extendsAndPermitsKeywords.pass
create mode 100644
[jira] [Updated] (NETBEANS-626) Number of row in "Insert Record(s)" modal panel is left after removming row JDK 10 only
[ https://issues.apache.org/jira/browse/NETBEANS-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-626: Labels: pull-request-available (was: ) > Number of row in "Insert Record(s)" modal panel is left after removming row > JDK 10 only > --- > > Key: NETBEANS-626 > URL: https://issues.apache.org/jira/browse/NETBEANS-626 > Project: NetBeans > Issue Type: Bug > Components: db - Show Data >Affects Versions: 9.0 >Reporter: Vldimir Orlyansky >Priority: Trivial > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Found in NetCat 9 through working with > [http://netbeans-vm.apache.org/synergy/client/app/#/assignment/2185/v/1] > It happens only under JDK 10. Under JDK 8 there is not such issue. > Click to view data and then click to "Insert Record(s)". > In modal panel create two rows. > Remove last row. > Number of row in column "#" will be present after removing last row. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-4888) Improve Java EE support
[ https://issues.apache.org/jira/browse/NETBEANS-4888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose resolved NETBEANS-4888. Resolution: Implemented Merged into master. > Improve Java EE support > --- > > Key: NETBEANS-4888 > URL: https://issues.apache.org/jira/browse/NETBEANS-4888 > Project: NetBeans > Issue Type: Improvement > Components: javaee - Code, javaee - JSF, xml - Schema >Affects Versions: 12.1 >Reporter: Jose >Assignee: Jose >Priority: Minor > Labels: pull-request-available > Fix For: 12.2 > > Attachments: PR-1234-before-1.png, PR-1234-before-2.png, > PR-1234-before-3.png > > Time Spent: 50m > Remaining Estimate: 0h > > - Fix wrong namespace for JSF 2.2 and 2.3 versions inside JSFCatalog > - Download a fresh web-facelettaglibrary_2_2.xsd from Oracle, previous one is > incorrect > - Add missing validations for FACELETS_TAGLIB_SCHEMA versions 22 and 23 > - Add missing Java EE 8 xml file > - Add missing Java EE 8 entries to some xml files > - Add missing directory to the rat-exclusions file > - Add missing connector_1_6.xsd file > - Add missing file to licenseinfo.xml > - Add missing directory to .gitignore > - Add missing Deployment Descriptor Files to a .properties file > - Add missing .xsd files to the EnterpriseCatalog file > - Add missing action that generates the application-client_8.mdd file -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch hectorespert-patch-1 updated (44072c3 -> 05abfc7)
This is an automated email from the ASF dual-hosted git repository. hectorespert pushed a change to branch hectorespert-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 44072c3 Update Jenkinsfile.groovy add 05abfc7 Update Jenkinsfile.groovy No new revisions were added by this update. Summary of changes: nbbuild/jenkins/linux/Jenkinsfile.groovy | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch hectorespert-patch-1 updated (a0febf0 -> 44072c3)
This is an automated email from the ASF dual-hosted git repository. hectorespert pushed a change to branch hectorespert-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from a0febf0 Create Jenkinsfile.groovy add 44072c3 Update Jenkinsfile.groovy No new revisions were added by this update. Summary of changes: nbbuild/jenkins/linux/Jenkinsfile.groovy | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch hectorespert-patch-1 created (now a0febf0)
This is an automated email from the ASF dual-hosted git repository. hectorespert pushed a change to branch hectorespert-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. at a0febf0 Create Jenkinsfile.groovy This branch includes the following new commits: new a0febf0 Create Jenkinsfile.groovy The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 01/01: Create Jenkinsfile.groovy
This is an automated email from the ASF dual-hosted git repository.
hectorespert pushed a commit to branch hectorespert-patch-1
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit a0febf043582b66acb09919ed0c2c39e7f02cdb5
Author: Hector Espert
AuthorDate: Sat Oct 10 20:16:21 2020 +0200
Create Jenkinsfile.groovy
---
nbbuild/jenkins/linux/Jenkinsfile.groovy | 33
1 file changed, 33 insertions(+)
diff --git a/nbbuild/jenkins/linux/Jenkinsfile.groovy
b/nbbuild/jenkins/linux/Jenkinsfile.groovy
new file mode 100644
index 000..095695a
--- /dev/null
+++ b/nbbuild/jenkins/linux/Jenkinsfile.groovy
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+agent {
+node {
+label 'ubuntu'
+}
+}
+stages {
+stage("Print env") {
+steps {
+sh 'printenv'
+}
+}
+}
+}
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch revert-2435-NETBEANS-4533-chinese-char-problem-table-header created (now f0d224d)
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a change to branch revert-2435-NETBEANS-4533-chinese-char-problem-table-header in repository https://gitbox.apache.org/repos/asf/netbeans.git. at f0d224d Revert "NETBEANS-4533 : Netbeans 4533 chinese char problem table header (#2435)" This branch includes the following new commits: new f0d224d Revert "NETBEANS-4533 : Netbeans 4533 chinese char problem table header (#2435)" The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 01/01: Revert "NETBEANS-4533 : Netbeans 4533 chinese char problem table header (#2435)"
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch
revert-2435-NETBEANS-4533-chinese-char-problem-table-header
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit f0d224d072da380c4faa55494b8190de8585fc9d
Author: Laszlo Kishalmi
AuthorDate: Sat Oct 10 10:20:37 2020 -0700
Revert "NETBEANS-4533 : Netbeans 4533 chinese char problem table header
(#2435)"
This reverts commit 7990cee5aa9d8460b563d7ad44d743843c6c064a.
---
.../o.n.swing.outline/src/org/netbeans/swing/etable/ETableHeader.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/platform/o.n.swing.outline/src/org/netbeans/swing/etable/ETableHeader.java
b/platform/o.n.swing.outline/src/org/netbeans/swing/etable/ETableHeader.java
index 719195d..1edf2cb 100644
--- a/platform/o.n.swing.outline/src/org/netbeans/swing/etable/ETableHeader.java
+++ b/platform/o.n.swing.outline/src/org/netbeans/swing/etable/ETableHeader.java
@@ -158,7 +158,8 @@ class ETableHeader extends JTableHeader {
Integer.toString(sortRank) :
sortRank+" "+valueString;
}
-label.setFont(label.getFont().deriveFont(Font.BOLD));
+// don't use deriveFont() - see #49973 for details
+label.setFont (new Font (label.getFont ().getName (),
Font.BOLD, label.getFont ().getSize ()));
if (ascending) {
sortIcon =
UIManager.getIcon("ETableHeader.ascendingIcon");
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: NETBEANS-4533 : Netbeans 4533 chinese char problem table header (#2435)
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 7990cee NETBEANS-4533 : Netbeans 4533 chinese char problem table
header (#2435)
7990cee is described below
commit 7990cee5aa9d8460b563d7ad44d743843c6c064a
Author: adrienDG <72509841+adrie...@users.noreply.github.com>
AuthorDate: Sat Oct 10 18:12:59 2020 +0200
NETBEANS-4533 : Netbeans 4533 chinese char problem table header (#2435)
* NETBEANS-4533 : use derive font bold to fix problem of sorting in
ETableHeader
* NETBEANS-4533 : use derive font bold to fix problem of sorting in
ETableHeader
---
.../o.n.swing.outline/src/org/netbeans/swing/etable/ETableHeader.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
a/platform/o.n.swing.outline/src/org/netbeans/swing/etable/ETableHeader.java
b/platform/o.n.swing.outline/src/org/netbeans/swing/etable/ETableHeader.java
index 1edf2cb..719195d 100644
--- a/platform/o.n.swing.outline/src/org/netbeans/swing/etable/ETableHeader.java
+++ b/platform/o.n.swing.outline/src/org/netbeans/swing/etable/ETableHeader.java
@@ -158,8 +158,7 @@ class ETableHeader extends JTableHeader {
Integer.toString(sortRank) :
sortRank+" "+valueString;
}
-// don't use deriveFont() - see #49973 for details
-label.setFont (new Font (label.getFont ().getName (),
Font.BOLD, label.getFont ().getSize ()));
+label.setFont(label.getFont().deriveFont(Font.BOLD));
if (ascending) {
sortIcon =
UIManager.getIcon("ETableHeader.ascendingIcon");
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-4618) HeapFactory cannot process multi heap segment files
[
https://issues.apache.org/jira/browse/NETBEANS-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Kishalmi resolved NETBEANS-4618.
---
Fix Version/s: 12.2
Resolution: Fixed
> HeapFactory cannot process multi heap segment files
> ---
>
> Key: NETBEANS-4618
> URL: https://issues.apache.org/jira/browse/NETBEANS-4618
> Project: NetBeans
> Issue Type: Bug
> Components: profiler - Base
>Affects Versions: 12.0, 12.0.1
>Reporter: Jaroslav Tulach
>Priority: Major
> Labels: pull-request-available
> Fix For: 12.2
>
> Attachments: multiheapsegment.hprof, singleheapsegment.hprof
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I am trying to generate {{.hprof}} file according to the [Java Profile
> 1.0.2|http://hg.openjdk.java.net/jdk6/jdk6/jdk/raw-file/tip/src/share/demo/jvmti/hprof/manual.html#mozTocId848088]
> specification. I believe I am fully following the specification (which
> allows multiple heap segments), but NetBeans Profiler library chokes up on my
> file and yields following exception:
> {code:java}
> java.lang.IllegalArgumentException: Invalid dump tag 0 at position 1415
> at
> org.netbeans.lib.profiler.heap.HprofHeap.readDumpTag(HprofHeap.java:1138)
> at
> org.netbeans.lib.profiler.heap.HprofHeap.fillHeapTagBounds(HprofHeap.java:1215)
> at org.netbeans.lib.profiler.heap.HprofHeap.(HprofHeap.java:140)
> at
> org.netbeans.lib.profiler.heap.HeapFactory.createHeap(HeapFactory.java:80)
> at
> org.netbeans.lib.profiler.heap.HeapFactory.createHeap(HeapFactory.java:49)
> {code}
> I am able to generate the file with a single heap segment (see
> [^singleheapsegment.hprof]) as well as multiple heap segments (see
> [^multiheapsegment.hprof]). The first one can be opened by NetBeans 12.x, the
> latter cannot.
>
> In my usecase I'd like to generate the file incrementally while my
> application is running. As such it is essential to flush the heap segments
> multiple times, otherwise I may run out of memory. It would be fantastic if
> the NetBeans heap profiler library could be enhanced to work with
> multiheapsegment files properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-4618) HeapFactory cannot process multi heap segment files
[
https://issues.apache.org/jira/browse/NETBEANS-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated NETBEANS-4618:
-
Labels: pull-request-available (was: )
> HeapFactory cannot process multi heap segment files
> ---
>
> Key: NETBEANS-4618
> URL: https://issues.apache.org/jira/browse/NETBEANS-4618
> Project: NetBeans
> Issue Type: Bug
> Components: profiler - Base
>Affects Versions: 12.0, 12.0.1
>Reporter: Jaroslav Tulach
>Priority: Major
> Labels: pull-request-available
> Attachments: multiheapsegment.hprof, singleheapsegment.hprof
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I am trying to generate {{.hprof}} file according to the [Java Profile
> 1.0.2|http://hg.openjdk.java.net/jdk6/jdk6/jdk/raw-file/tip/src/share/demo/jvmti/hprof/manual.html#mozTocId848088]
> specification. I believe I am fully following the specification (which
> allows multiple heap segments), but NetBeans Profiler library chokes up on my
> file and yields following exception:
> {code:java}
> java.lang.IllegalArgumentException: Invalid dump tag 0 at position 1415
> at
> org.netbeans.lib.profiler.heap.HprofHeap.readDumpTag(HprofHeap.java:1138)
> at
> org.netbeans.lib.profiler.heap.HprofHeap.fillHeapTagBounds(HprofHeap.java:1215)
> at org.netbeans.lib.profiler.heap.HprofHeap.(HprofHeap.java:140)
> at
> org.netbeans.lib.profiler.heap.HeapFactory.createHeap(HeapFactory.java:80)
> at
> org.netbeans.lib.profiler.heap.HeapFactory.createHeap(HeapFactory.java:49)
> {code}
> I am able to generate the file with a single heap segment (see
> [^singleheapsegment.hprof]) as well as multiple heap segments (see
> [^multiheapsegment.hprof]). The first one can be opened by NetBeans 12.x, the
> latter cannot.
>
> In my usecase I'd like to generate the file incrementally while my
> application is running. As such it is essential to flush the heap segments
> multiple times, otherwise I may run out of memory. It would be fantastic if
> the NetBeans heap profiler library could be enhanced to work with
> multiheapsegment files properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: Demonstrating problems with multiple segments
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 8ca1858 Demonstrating problems with multiple segments
8ca1858 is described below
commit 8ca18583d1f58b19bf8e87171f22e76f20acbf33
Author: Jaroslav Tulach
AuthorDate: Fri Sep 18 17:47:09 2020 +0200
Demonstrating problems with multiple segments
---
.../lib/profiler/heap/HeapSegmentTest.java | 122 ++
.../org/netbeans/lib/profiler/heap/HeapUtils.java | 439 +
2 files changed, 561 insertions(+)
diff --git
a/profiler/lib.profiler/test/unit/src/org/netbeans/lib/profiler/heap/HeapSegmentTest.java
b/profiler/lib.profiler/test/unit/src/org/netbeans/lib/profiler/heap/HeapSegmentTest.java
new file mode 100644
index 000..6141829
--- /dev/null
+++
b/profiler/lib.profiler/test/unit/src/org/netbeans/lib/profiler/heap/HeapSegmentTest.java
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.lib.profiler.heap;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.OutputStream;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.List;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import org.junit.Test;
+import org.netbeans.lib.profiler.heap.HeapUtils.HprofGenerator;
+
+public class HeapSegmentTest {
+@Test
+public void singleObject() throws IOException {
+singleObject(false);
+}
+
+@Test
+public void singleObjectMultipleSegments() throws IOException {
+singleObject(true);
+}
+
+private static void singleObject(boolean flush) throws IOException {
+File mydump = File.createTempFile("mydump", ".hprof");
+generateSingleObject(new FileOutputStream(mydump), flush);
+Heap heap = HeapFactory.createHeap(mydump);
+List allClasses = heap.getAllClasses();
+assertEquals(5, allClasses.size());
+assertEquals("java.lang.String", allClasses.get(0).getName());
+assertEquals("char[]", allClasses.get(1).getName());
+assertEquals("text.HelloWorld", allClasses.get(2).getName());
+
+Collection roots = new ArrayList<>(heap.getGCRoots());
+assertEquals("Thread & two locals", 5, roots.size());
+{
+Iterator it = roots.iterator();
+while (it.hasNext()) {
+if (it.next() instanceof ThreadObjectGCRoot) {
+continue;
+}
+it.remove();
+}
+}
+assertEquals("Only one thread", 2, roots.size());
+final Iterator it = roots.iterator();
+final Instance thread = it.next().getInstance();
+
+Object daemon = thread.getValueOfField("daemon");
+assertNotNull("daemon field found", daemon);
+Instance value = (Instance) thread.getValueOfField("name");
+assertNotNull("name assigned", value);
+assertEquals("java.lang.String", value.getJavaClass().getName());
+assertEquals(Boolean.class, daemon.getClass());
+assertFalse("It is not daemon", (Boolean) daemon);
+}
+
+private static void generateSingleObject(OutputStream os, boolean flush)
throws IOException {
+try (HprofGenerator gen = new HprofGenerator(os)) {
+gen.writeHeapSegment(new SampleDumpMemory(), flush);
+gen.writeHeapSegment(new SampleDumpMemory2(), flush);
+}
+}
+
+private static class SampleDumpMemory implements
HprofGenerator.Generator {
+@Override
+public void generate(HprofGenerator.HeapSegment seg) throws
IOException {
+int mainId = seg.dumpString("main");
+
+HprofGenerator.ClassInstance clazz =
seg.newClass("text.HelloWorld")
+.addField("daemon", Boolean.TYPE)
+.addField("name", String.class)
+.addField("priority", int.class)
+
[jira] [Updated] (NETBEANS-4895) FileUtil.isArchiveFile(URL) return true too easy on non existing file URL-s
[ https://issues.apache.org/jira/browse/NETBEANS-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-4895: - Labels: pull-request-available (was: ) > FileUtil.isArchiveFile(URL) return true too easy on non existing file URL-s > --- > > Key: NETBEANS-4895 > URL: https://issues.apache.org/jira/browse/NETBEANS-4895 > Project: NetBeans > Issue Type: Bug > Components: platform - Filesystems >Reporter: Laszlo Kishalmi >Assignee: Laszlo Kishalmi >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The current requirement for detecting a non existing file URL, to have a dot > in the "filename" part regardless of extension. With modular projects such > url-s would become more popular, like "javafx.base" would be a part of a non > existent class directory. Detecting these non existent directories as jar > files could fool the SourceForBinary Queries. > Proposed solution: Try to use the extension part of the supposed to be > filename to decide if it is an archive or not. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-4895) FileUtil.isArchiveFile(URL) return true too easy on non existing file URL-s
Laszlo Kishalmi created NETBEANS-4895: - Summary: FileUtil.isArchiveFile(URL) return true too easy on non existing file URL-s Key: NETBEANS-4895 URL: https://issues.apache.org/jira/browse/NETBEANS-4895 Project: NetBeans Issue Type: Bug Components: platform - Filesystems Reporter: Laszlo Kishalmi Assignee: Laszlo Kishalmi The current requirement for detecting a non existing file URL, to have a dot in the "filename" part regardless of extension. With modular projects such url-s would become more popular, like "javafx.base" would be a part of a non existent class directory. Detecting these non existent directories as jar files could fool the SourceForBinary Queries. Proposed solution: Try to use the extension part of the supposed to be filename to decide if it is an archive or not. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
