[jira] [Updated] (NETBEANS-5144) Can't set breakpoint in xhtml-File
[ https://issues.apache.org/jira/browse/NETBEANS-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] S. M. updated NETBEANS-5144: Description: Setting a breakpoint in a xhtml-file (JSF) does not work. (was: Setting a breakpoint in a xhtml-File (JSF) does not work.) > Can't set breakpoint in xhtml-File > -- > > Key: NETBEANS-5144 > URL: https://issues.apache.org/jira/browse/NETBEANS-5144 > Project: NetBeans > Issue Type: Bug > Components: cnd - Debugger >Affects Versions: 12.2 > Environment: Netbeans 12.2, Glassfish 4.1.2 >Reporter: S. M. >Priority: Major > > Setting a breakpoint in a xhtml-file (JSF) does not work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-5170) problem in edit jsp page in Raspberry Pi OS with ARMHF
WangYi created NETBEANS-5170: Summary: problem in edit jsp page in Raspberry Pi OS with ARMHF Key: NETBEANS-5170 URL: https://issues.apache.org/jira/browse/NETBEANS-5170 Project: NetBeans Issue Type: Bug Affects Versions: 12.2 Environment: Raspberry PI 4B OS with 8G RAM , Oracle jdk-8u271-linux-arm32-vfp-hflt. Reporter: WangYi create a Java Web project with Ant, create a jsp page,open the page in Editor,and the Exception was catched like this: java.lang.NullPointerExceptionjava.lang.NullPointerException at org.netbeans.modules.java.editor.base.semantic.TokenList.index(TokenList.java:364) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitExpressionStatement(SemanticHighlighterBase.java:740) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitExpressionStatement(SemanticHighlighterBase.java:280) at com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1555) at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:280) at com.sun.source.util.TreeScanner.scan(TreeScanner.java:105) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78) at com.sun.source.util.TreeScanner.visitBlock(TreeScanner.java:250) at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1074) at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:280) at com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:90) at com.sun.source.util.TreeScanner.visitMethod(TreeScanner.java:208) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitMethod(SemanticHighlighterBase.java:789) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitMethod(SemanticHighlighterBase.java:280) at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:940) at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:280) at com.sun.source.util.TreeScanner.scan(TreeScanner.java:105) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitClass(SemanticHighlighterBase.java:944) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitClass(SemanticHighlighterBase.java:280) at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:846) at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:280) at com.sun.source.util.TreeScanner.scan(TreeScanner.java:105) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitCompilationUnit(SemanticHighlighterBase.java:561) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitCompilationUnit(SemanticHighlighterBase.java:280) at com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:605) at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) at
[jira] [Updated] (NETBEANS-5101) Cryptic popup dialog on deploy new EJB-Bean-Projekt
[ https://issues.apache.org/jira/browse/NETBEANS-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] S. M. updated NETBEANS-5101: Environment: Netbeans 12.0, jdk 14.01 (was: Netbeans 12.0, Glassfish 4 and Glassfish 5, Project: jdk1.8.0_65, Netbeans: jdk 14.01) > Cryptic popup dialog on deploy new EJB-Bean-Projekt > --- > > Key: NETBEANS-5101 > URL: https://issues.apache.org/jira/browse/NETBEANS-5101 > Project: NetBeans > Issue Type: Bug > Components: javaee - EJB Project >Affects Versions: 12.0, 12.1, 12.2 > Environment: Netbeans 12.0, jdk 14.01 >Reporter: S. M. >Priority: Minor > Attachments: screen-shot-Deplay-EJBModule.png > > > Make a new EBJ-Module-Project and compile the empty project: A cryptic dialog > pops up - see attached picture. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5161) composite gradle projects cannot ne loaded
[ https://issues.apache.org/jira/browse/NETBEANS-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252331#comment-17252331 ] Laszlo Kishalmi commented on NETBEANS-5161: --- Could you share a minimal test project here or on GitHub? I can fix the actual IllegalArgumentException pretty easy, but that would mean that the libraries from potential imported project won't be displayed correctly. > composite gradle projects cannot ne loaded > -- > > Key: NETBEANS-5161 > URL: https://issues.apache.org/jira/browse/NETBEANS-5161 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 12.2 > Environment: windows 10, openjdk 14.0.2 >Reporter: Horváth András >Assignee: Laszlo Kishalmi >Priority: Major > Attachments: netbeans_1.png, netbeans_2.png, netbeans_details.txt > > > When trying to load a composite gradle project into netbeans an unexpeced > exception occours with message 'Invalig GAV format' referring to the included > project. > A dialog is opened also that some problems are to be resolved: priming build > required, however hitting the resolve button does nothing (on other projects > the project can be set to be a trusted one this way). > Allow gradle execution settings option is set to Always. > The included project (which is not a composite one) can be opened > successfully. > The composite project can be built from command line, also can be loaded in > netbeans 12.0. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-5156) There's unexpected exception whenever I open my project
[ https://issues.apache.org/jira/browse/NETBEANS-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi resolved NETBEANS-5156. --- Resolution: Duplicate > There's unexpected exception whenever I open my project > --- > > Key: NETBEANS-5156 > URL: https://issues.apache.org/jira/browse/NETBEANS-5156 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.0 >Reporter: Natasha Harjanto >Priority: Major > Fix For: 12.0 > > Attachments: 1.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-5157) There's unexpected exception whenever I open my project
[ https://issues.apache.org/jira/browse/NETBEANS-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi resolved NETBEANS-5157. --- Resolution: Duplicate > There's unexpected exception whenever I open my project > --- > > Key: NETBEANS-5157 > URL: https://issues.apache.org/jira/browse/NETBEANS-5157 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.0 >Reporter: Natasha Harjanto >Priority: Major > Fix For: 12.0 > > Attachments: 1.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: Illegal accesses are not allowed by default now, adding javac-related add-exports/add-opens.
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 1eb31fa Illegal accesses are not allowed by default now, adding
javac-related add-exports/add-opens.
1eb31fa is described below
commit 1eb31fa058abcdfce0b0c5c2177251c853ca2447
Author: Jan Lahoda
AuthorDate: Wed Dec 16 08:29:36 2020 +0100
Illegal accesses are not allowed by default now, adding javac-related
add-exports/add-opens.
---
nb/ide.launcher/netbeans.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nb/ide.launcher/netbeans.conf b/nb/ide.launcher/netbeans.conf
index f0e17c6..e9e30e3 100644
--- a/nb/ide.launcher/netbeans.conf
+++ b/nb/ide.launcher/netbeans.conf
@@ -62,7 +62,7 @@
netbeans_default_cachedir="${DEFAULT_CACHEDIR_ROOT}/@@metabuild.RawVersion@@"
# default command line arguments.
# (see: https://issues.apache.org/jira/browse/NETBEANS-1344)
#
-netbeans_default_options="-J-XX:+UseStringDeduplication -J-Xss2m
@@metabuild.logcli@@ -J-Djdk.gtk.version=2.2
-J-Dapple.laf.useScreenMenuBar=true -J-Dapple.awt.graphics.UseQuartz=true
-J-Dsun.java2d.noddraw=true -J-Dsun.java2d.dpiaware=true
-J-Dsun.zip.disableMemoryMapping=true -J-Dplugin.manager.check.updates=false
-J-Dnetbeans.extbrowser.manual_chrome_plugin_install=yes
-J--add-opens=java.base/java.net=ALL-UNNAMED
-J--add-opens=java.base/java.lang.ref=ALL-UNNAMED -J--add-opens=java.bas [...]
+netbeans_default_options="-J-XX:+UseStringDeduplication -J-Xss2m
@@metabuild.logcli@@ -J-Djdk.gtk.version=2.2
-J-Dapple.laf.useScreenMenuBar=true -J-Dapple.awt.graphics.UseQuartz=true
-J-Dsun.java2d.noddraw=true -J-Dsun.java2d.dpiaware=true
-J-Dsun.zip.disableMemoryMapping=true -J-Dplugin.manager.check.updates=false
-J-Dnetbeans.extbrowser.manual_chrome_plugin_install=yes
-J--add-opens=java.base/java.net=ALL-UNNAMED
-J--add-opens=java.base/java.lang.ref=ALL-UNNAMED -J--add-opens=java.bas [...]
# Default location of JDK:
# (set by installer or commented out if launcher should decide)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-5146) Make it possible to control TreeView-s scrollOnExpand property
[ https://issues.apache.org/jira/browse/NETBEANS-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi resolved NETBEANS-5146. --- Fix Version/s: 12.3 Resolution: Implemented > Make it possible to control TreeView-s scrollOnExpand property > -- > > Key: NETBEANS-5146 > URL: https://issues.apache.org/jira/browse/NETBEANS-5146 > Project: NetBeans > Issue Type: Improvement > Components: platform - Explorer >Reporter: Laszlo Kishalmi >Assignee: Laszlo Kishalmi >Priority: Major > Labels: pull-request-available > Fix For: 12.3 > > Time Spent: 20m > Remaining Estimate: 0h > > During fixing: NETBEANS-2387 it turned out that the scrollOnExpand property > of the underlying JTree is true by default. I'd either have to re-implement > the node based navigator view on simple JTree or expose the scrollOnExpand > property in TreeView. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-5161) composite gradle projects cannot ne loaded
[ https://issues.apache.org/jira/browse/NETBEANS-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi reassigned NETBEANS-5161: - Assignee: Laszlo Kishalmi > composite gradle projects cannot ne loaded > -- > > Key: NETBEANS-5161 > URL: https://issues.apache.org/jira/browse/NETBEANS-5161 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 12.2 > Environment: windows 10, openjdk 14.0.2 >Reporter: Horváth András >Assignee: Laszlo Kishalmi >Priority: Major > Attachments: netbeans_1.png, netbeans_2.png, netbeans_details.txt > > > When trying to load a composite gradle project into netbeans an unexpeced > exception occours with message 'Invalig GAV format' referring to the included > project. > A dialog is opened also that some problems are to be resolved: priming build > required, however hitting the resolve button does nothing (on other projects > the project can be set to be a trusted one this way). > Allow gradle execution settings option is set to Always. > The included project (which is not a composite one) can be opened > successfully. > The composite project can be built from command line, also can be loaded in > netbeans 12.0. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5161) composite gradle projects cannot ne loaded
[ https://issues.apache.org/jira/browse/NETBEANS-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-5161: - Labels: pull-request-available (was: ) > composite gradle projects cannot ne loaded > -- > > Key: NETBEANS-5161 > URL: https://issues.apache.org/jira/browse/NETBEANS-5161 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 12.2 > Environment: windows 10, openjdk 14.0.2 >Reporter: Horváth András >Assignee: Laszlo Kishalmi >Priority: Major > Labels: pull-request-available > Attachments: netbeans_1.png, netbeans_2.png, netbeans_details.txt > > Time Spent: 10m > Remaining Estimate: 0h > > When trying to load a composite gradle project into netbeans an unexpeced > exception occours with message 'Invalig GAV format' referring to the included > project. > A dialog is opened also that some problems are to be resolved: priming build > required, however hitting the resolve button does nothing (on other projects > the project can be set to be a trusted one this way). > Allow gradle execution settings option is set to Always. > The included project (which is not a composite one) can be opened > successfully. > The composite project can be built from command line, also can be loaded in > netbeans 12.0. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-5070] fix errors on text selection (#2597)
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 95a135b [NETBEANS-5070] fix errors on text selection (#2597)
95a135b is described below
commit 95a135b0aeae5b390112a69fe1a38130bba6c498
Author: Michal Hlavac
AuthorDate: Sun Dec 20 06:25:14 2020 +0100
[NETBEANS-5070] fix errors on text selection (#2597)
* [NETBEANS-5070] fix errors on text selection
* fixed paint selection
Co-authored-by: Michal Hlavac
---
.../src/org/netbeans/lib/terminalemulator/Line.java | 8
.../lib/terminalemulator/MyFontMetrics.java | 21 +++--
.../src/org/netbeans/lib/terminalemulator/Sel.java | 4 ++--
3 files changed, 17 insertions(+), 16 deletions(-)
diff --git
a/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/Line.java
b/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/Line.java
index 5ca5052..2e10f49 100644
--- a/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/Line.java
+++ b/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/Line.java
@@ -156,13 +156,13 @@ final class Line {
}
public int stringWidth(MyFontMetrics metrics, int at) {
+if (at > buf.length - 1) return 0;
return metrics.getFm().charsWidth(buf, 0, at);
}
-public byte width(MyFontMetrics metrics, int at) {
-if (at >= capacity)
-return 1;
-return (byte) metrics.wcwidth(charAt(at));
+public int charWidth(MyFontMetrics metrics, int at) {
+if (at > buf.length - 1) return 0;
+return metrics.getFm().charsWidth(buf, at, 1);
}
/*
diff --git
a/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/MyFontMetrics.java
b/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/MyFontMetrics.java
index 67a6ec2..e4c34b2 100644
---
a/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/MyFontMetrics.java
+++
b/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/MyFontMetrics.java
@@ -17,7 +17,7 @@
* under the License.
*/
-/*
+ /*
* "MyFontMetrics"
* MyFontMetrics.java 1.5 01/07/10
*/
@@ -123,10 +123,11 @@ class MyFontMetrics {
public MyFontMetrics(Component component) {
this.cmp = component;
-width = getFm().charWidth('a');
-height = getFm().getHeight();
-ascent = getFm().getAscent();
-leading = getFm().getLeading();
+this.fm = this.cmp.getFontMetrics(cmp.getFont());
+width = fm.charWidth('a');
+height = fm.getHeight();
+ascent = fm.getAscent();
+leading = fm.getLeading();
// HACK
// From all I can tell both xterm and DtTerm ignore the leading.
@@ -138,25 +139,25 @@ class MyFontMetrics {
// the following makes things match up, but if we ever undo this
// we'll have to go and adjust how everything is drawn (cursor,
// reverse-video attribute, underscore, bg stripe, selection etc.
-
height -= leading;
leading = 0;
-
-cwidth_cache = CacheFactory.cacheForFontMetrics(getFm());
+cwidth_cache = CacheFactory.cacheForFontMetrics(fm);
}
public FontMetrics getFm() {
-return this.cmp.getFontMetrics(cmp.getFont());
+//if (fm == null) fm = this.cmp.getFontMetrics(cmp.getFont()); // this
does not work very well
+return this.cmp.getFontMetrics(cmp.getFont()); // this seems not very
optimal
}
@Override
protected void finalize() {
-CacheFactory.disposeBy(getFm());
+CacheFactory.disposeBy(fm);
}
public int width;
public int height;
public int ascent;
public int leading;
+public FontMetrics fm;
public Component cmp;
private WidthCache cwidth_cache;
diff --git
a/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/Sel.java
b/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/Sel.java
index 0dd498c..30242f1 100644
--- a/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/Sel.java
+++ b/ide/lib.terminalemulator/src/org/netbeans/lib/terminalemulator/Sel.java
@@ -403,8 +403,8 @@ class Sel implements ClipboardOwner {
Point pbegin = term.toPixel(begin);
Point pend = term.toPixel(end);
- pend.y += term.metrics().height;
- pend.x += l.stringWidth(term.metrics(), ecol); // xterm actually
doesn't do this
+ pend.y += term.metrics().fm.getHeight();
+ pend.x += l.charWidth(term.metrics(), ecol);// xterm actually
doesn't do this
Dimension dim = new Dimension(pend.x - pbegin.x,
pend.y - pbegin.y);
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
[netbeans] branch master updated: NETBEANS-5034 fix wrong javadoc error hint
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new a5c6224 NETBEANS-5034 fix wrong javadoc error hint
a5c6224 is described below
commit a5c6224f82c3f6bf9311fc7abddd65c68fde276b
Author: Jakub Herkel
AuthorDate: Tue Nov 17 16:57:19 2020 +0100
NETBEANS-5034 fix wrong javadoc error hint
---
.../src/org/netbeans/modules/javadoc/hints/Analyzer.java | 2 +-
.../org/netbeans/modules/javadoc/hints/Analyzer2Test.java | 15 +++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/java/javadoc/src/org/netbeans/modules/javadoc/hints/Analyzer.java
b/java/javadoc/src/org/netbeans/modules/javadoc/hints/Analyzer.java
index 5c92f69..94772b2 100644
--- a/java/javadoc/src/org/netbeans/modules/javadoc/hints/Analyzer.java
+++ b/java/javadoc/src/org/netbeans/modules/javadoc/hints/Analyzer.java
@@ -633,7 +633,7 @@ final class Analyzer extends DocTreePathScanner> {
if (t == null) {
errors.add(ErrorDescriptionFactory.forSpan(ctx, start, end,
TAG_UNKNOWN(treeName)));
} else {
-if (!t.hasOptionalEndTag() && !isVoid(t)) {
+if (!isVoid(t)) {
tagStack.push(node);
}
}
diff --git
a/java/javadoc/test/unit/src/org/netbeans/modules/javadoc/hints/Analyzer2Test.java
b/java/javadoc/test/unit/src/org/netbeans/modules/javadoc/hints/Analyzer2Test.java
index d5a5d03..477c0ac 100644
---
a/java/javadoc/test/unit/src/org/netbeans/modules/javadoc/hints/Analyzer2Test.java
+++
b/java/javadoc/test/unit/src/org/netbeans/modules/javadoc/hints/Analyzer2Test.java
@@ -346,4 +346,19 @@ public class Analyzer2Test extends NbTestCase {
.run(JavadocHint.class)
.assertContainsWarnings("2:3-2:11:warning:End Tag Missing:
");
}
+
+public void testOptionalEndTag() throws Exception {
+HintTest.create()
+.input(
+"package test;\n" +
+"/**\n" +
+" * OneTwo\n" +
+" */\n" +
+"class Zima {\n" +
+"}\n")
+.preference(AVAILABILITY_KEY + true, true)
+.preference(SCOPE_KEY, "private")
+.run(JavadocHint.class)
+.assertWarnings();
+}
}
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
