[netbeans] branch master updated (188dd8c -> cebe93e)
This is an automated email from the ASF dual-hosted git repository.
sdedic pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git.
from 188dd8c Merge pull request #2999 from
JaroslavTulach/jtulach/NewProjectAction
new 6be2255 Simple handling of generics, see NETBEANS-5787
new 6e06542 Groovy CC supports LSP interface.
new d38ee49 Can optional skip items in a golden file.
new c78bf81 Adapted Groovy tests to check results in CompletionCollector,
too
new cebe93e Merge pull request #3001 from sdedic/groovy/lsp-completion
The 5548 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
groovy/groovy.editor/manifest.mf | 2 +-
groovy/groovy.editor/nbproject/project.xml | 9 +
.../editor/api/completion/CompletionHandler.java | 361 +
.../editor/api/completion/CompletionItem.java | 91 +++-
.../completion/provider/CompletionAccessor.java| 11 +
.../provider/GroovyCompletionCollector.java| 600 +
.../provider/GroovyCompletionImpl.java}| 392 ++
.../provider/GroovyElementsProvider.java | 18 +-
.../provider}/HTMLJavadocParser.java | 2 +-
.../completion/provider/JavaElementHandler.java| 47 +-
.../completion/provider/TransformationHandler.java | 25 +-
.../modules/groovy/editor/utils/GroovyUtils.java | 10 +
...r1.groovy.testCompletionInsideFor1_2.completion | 4 +-
...groovy.testCompletionNoPrefixString1.completion | 2 +-
...groovy.testCompletionNoPrefixString2.completion | 2 +-
testSpreadOperator1_stringArray_all.completion | 2 +-
.../groovy/editor/api/completion/AccessCCTest.java | 1 +
.../editor/api/completion/CamelCaseCCTest.java | 55 ++
.../editor/api/completion/CodeCompletionTest.java | 11 +-
.../editor/api/completion/DuplicatesCCTest.java| 11 +-
.../groovy/editor/api/completion/FieldCCTest.java | 11 +-
.../editor/api/completion/GroovyCCTestBase.java| 256 -
.../editor/api/completion/InferenceCCTest.java | 10 +-
.../editor/api/completion/NewVarsCCTest.java | 10 +-
.../netbeans/modules/csl/api/test/CslTestBase.java | 103 +++-
25 files changed, 1277 insertions(+), 769 deletions(-)
create mode 100644
groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/completion/provider/GroovyCompletionCollector.java
copy
groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/{api/completion/CompletionHandler.java
=> completion/provider/GroovyCompletionImpl.java} (54%)
rename
groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/{api/completion =>
completion/provider}/HTMLJavadocParser.java (99%)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5772) OSGi Bundles with dash in Bundle-Symbolic-Name are not installable or updatable
[ https://issues.apache.org/jira/browse/NETBEANS-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-5772: - Labels: pull-request-available (was: ) > OSGi Bundles with dash in Bundle-Symbolic-Name are not installable or > updatable > --- > > Key: NETBEANS-5772 > URL: https://issues.apache.org/jira/browse/NETBEANS-5772 > Project: NetBeans > Issue Type: Bug > Components: platform - Module System >Affects Versions: 12.3 >Reporter: Jens Hofschröer >Priority: Major > Labels: pull-request-available > Attachments: [NETBEANS-5772]_osgi-bundle-names.diff > > Time Spent: 10m > Remaining Estimate: 0h > > The NetBeans Module System is based on "Code-Name-Base" module names. These > names are formatted the same way as Java packages. OSGi uses "Symbolic Names" > that are "mostly" like Java Packages, but the OSGi specification allows also > a dash and an underscore to be part of that "symbolic-name" [1] and [2]. > In org.openide.modules.Dependency#checkCodeName() the check is that only a > NetBeans CNB/Java package is a valid identifier. This will prevent modules to > be installed or updated if they depend on these OSGi Bundles: > java.lang.IllegalArgumentException: Malformed dot-separated identifier: > org.apache.commons.commons-csv > at org.openide.modules.Dependency.checkCodeName(Dependency.java:176) > at org.openide.modules.Dependency.create(Dependency.java:254) > at > org.netbeans.modules.autoupdate.updateprovider.DummyModuleInfo.parseDeps(DummyModuleInfo.java:176) > at > org.netbeans.modules.autoupdate.updateprovider.DummyModuleInfo.(DummyModuleInfo.java:97) > at > org.netbeans.modules.autoupdate.updateprovider.ModuleItem.getModuleInfo(ModuleItem.java:150) > [catch] at > org.netbeans.modules.autoupdate.services.UpdateUnitFactory.appendUpdateItems(UpdateUnitFactory.java:169) > at > org.netbeans.modules.autoupdate.services.UpdateUnitFactory.getUpdateUnits(UpdateUnitFactory.java:118) > at > org.netbeans.modules.autoupdate.services.UpdateManagerImpl$Cache.(UpdateManagerImpl.java:267) > at > org.netbeans.modules.autoupdate.services.UpdateManagerImpl.getCache(UpdateManagerImpl.java:227) > at > org.netbeans.modules.autoupdate.services.UpdateManagerImpl.getUpdateUnits(UpdateManagerImpl.java:96) > at > org.netbeans.api.autoupdate.UpdateManager.getUpdateUnits(UpdateManager.java:78) > at > org.netbeans.modules.autoupdate.ui.PluginManagerUI.updateUnitsChanged(PluginManagerUI.java:656) > at > org.netbeans.modules.autoupdate.ui.UnitTab$3.updateUnitsChanged(UnitTab.java:168) > at > org.netbeans.modules.autoupdate.ui.UnitCategoryTableModel.fireUpdataUnitChange(UnitCategoryTableModel.java:261) > at > org.netbeans.modules.autoupdate.ui.UnitTab.fireUpdataUnitChange(UnitTab.java:619) > at org.netbeans.modules.autoupdate.ui.UnitTab$14$1.run(UnitTab.java:790) > at java.desktop/java.awt.event.InvocationEvent.dispatch(Unknown Source) > > [1] > [http://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#framework.module.bsn] > [2] > [http://docs.osgi.org/specification/osgi.core/7.0.0/ch01.html#framework.general.syntax] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5397) Generating entities from database fails when selecting multiple tables.
[ https://issues.apache.org/jira/browse/NETBEANS-5397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366552#comment-17366552 ] Peter Hendriks commented on NETBEANS-5397: -- [~matthiasblaesing] I tested this again with NB 12.4 with the new javac lib and this works fine now. I'm not sure if I should be the one closing this ticket but as far as I'm concerned this is solved. > Generating entities from database fails when selecting multiple tables. > --- > > Key: NETBEANS-5397 > URL: https://issues.apache.org/jira/browse/NETBEANS-5397 > Project: NetBeans > Issue Type: Bug > Components: javaee - Persistence >Affects Versions: 12.2, 12.3, 12.4 > Environment: !image-2021-03-02-11-40-58-636.png! >Reporter: Peter Hendriks >Priority: Blocker > Fix For: 12.4 > > Attachments: NBEntityCreationTest.zip, Screenshot 2021-03-02 at > 11.39.14.png, image-2021-03-02-11-40-58-636.png > > > At this moment, when adding entities from a db with the wizard and selecting > all tables. Entities will result in plain classes without even getters or > setters. > > The ide throws a persistence error. > > when adding the entities table for table at a time it works, np > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-5397) Generating entities from database fails when selecting multiple tables.
[ https://issues.apache.org/jira/browse/NETBEANS-5397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Bläsing resolved NETBEANS-5397. Resolution: Fixed > Generating entities from database fails when selecting multiple tables. > --- > > Key: NETBEANS-5397 > URL: https://issues.apache.org/jira/browse/NETBEANS-5397 > Project: NetBeans > Issue Type: Bug > Components: javaee - Persistence >Affects Versions: 12.2, 12.3, 12.4 > Environment: !image-2021-03-02-11-40-58-636.png! >Reporter: Peter Hendriks >Priority: Blocker > Fix For: 12.4 > > Attachments: NBEntityCreationTest.zip, Screenshot 2021-03-02 at > 11.39.14.png, image-2021-03-02-11-40-58-636.png > > > At this moment, when adding entities from a db with the wizard and selecting > all tables. Entities will result in plain classes without even getters or > setters. > > The ide throws a persistence error. > > when adding the entities table for table at a time it works, np > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-5803) Maven Micronaut projects can not be customized.
Martin Entlicher created NETBEANS-5803: -- Summary: Maven Micronaut projects can not be customized. Key: NETBEANS-5803 URL: https://issues.apache.org/jira/browse/NETBEANS-5803 Project: NetBeans Issue Type: Bug Components: projects - Maven Reporter: Martin Entlicher Assignee: Martin Entlicher The maven project support does not handle `https` XML namespace. http protocol is expected: `http://maven.apache.org/POM/4.0.0"` The maven project support does not handle https: `https://maven.apache.org/POM/4.0.0; ` -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Closed] (NETBEANS-5397) Generating entities from database fails when selecting multiple tables.
[ https://issues.apache.org/jira/browse/NETBEANS-5397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Bläsing closed NETBEANS-5397. -- > Generating entities from database fails when selecting multiple tables. > --- > > Key: NETBEANS-5397 > URL: https://issues.apache.org/jira/browse/NETBEANS-5397 > Project: NetBeans > Issue Type: Bug > Components: javaee - Persistence >Affects Versions: 12.2, 12.3, 12.4 > Environment: !image-2021-03-02-11-40-58-636.png! >Reporter: Peter Hendriks >Priority: Blocker > Fix For: 12.4 > > Attachments: NBEntityCreationTest.zip, Screenshot 2021-03-02 at > 11.39.14.png, image-2021-03-02-11-40-58-636.png > > > At this moment, when adding entities from a db with the wizard and selecting > all tables. Entities will result in plain classes without even getters or > setters. > > The ide throws a persistence error. > > when adding the entities table for table at a time it works, np > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5397) Generating entities from database fails when selecting multiple tables.
[ https://issues.apache.org/jira/browse/NETBEANS-5397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366677#comment-17366677 ] Matthias Bläsing commented on NETBEANS-5397: [~httpeter] sorry, that I missed updating this issue. Marked this as fixed and will close after this comment. In any case, you are encouraged to close issues you verify to be fixed. Thank you. > Generating entities from database fails when selecting multiple tables. > --- > > Key: NETBEANS-5397 > URL: https://issues.apache.org/jira/browse/NETBEANS-5397 > Project: NetBeans > Issue Type: Bug > Components: javaee - Persistence >Affects Versions: 12.2, 12.3, 12.4 > Environment: !image-2021-03-02-11-40-58-636.png! >Reporter: Peter Hendriks >Priority: Blocker > Fix For: 12.4 > > Attachments: NBEntityCreationTest.zip, Screenshot 2021-03-02 at > 11.39.14.png, image-2021-03-02-11-40-58-636.png > > > At this moment, when adding entities from a db with the wizard and selecting > all tables. Entities will result in plain classes without even getters or > setters. > > The ide throws a persistence error. > > when adding the entities table for table at a time it works, np > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5803) Maven Micronaut projects can not be customized.
[ https://issues.apache.org/jira/browse/NETBEANS-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Entlicher updated NETBEANS-5803: --- Fix Version/s: 12.5 > Maven Micronaut projects can not be customized. > --- > > Key: NETBEANS-5803 > URL: https://issues.apache.org/jira/browse/NETBEANS-5803 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Reporter: Martin Entlicher >Assignee: Martin Entlicher >Priority: Critical > Fix For: 12.5 > > Attachments: Screenshot from 2021-06-21 18-15-59.png > > > The maven project support does not handle `https` XML namespace. > http protocol is expected: > `http://maven.apache.org/POM/4.0.0"` > The maven project support does not handle https: > `https://maven.apache.org/POM/4.0.0; ` -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5803) Maven Micronaut projects can not be customized.
[ https://issues.apache.org/jira/browse/NETBEANS-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Entlicher updated NETBEANS-5803: --- Attachment: Screenshot from 2021-06-21 18-15-59.png > Maven Micronaut projects can not be customized. > --- > > Key: NETBEANS-5803 > URL: https://issues.apache.org/jira/browse/NETBEANS-5803 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Reporter: Martin Entlicher >Assignee: Martin Entlicher >Priority: Critical > Attachments: Screenshot from 2021-06-21 18-15-59.png > > > The maven project support does not handle `https` XML namespace. > http protocol is expected: > `http://maven.apache.org/POM/4.0.0"` > The maven project support does not handle https: > `https://maven.apache.org/POM/4.0.0; ` -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5803) Maven Micronaut projects can not be customized.
[ https://issues.apache.org/jira/browse/NETBEANS-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366700#comment-17366700 ] Martin Entlicher commented on NETBEANS-5803: This dialog is shown instead of the project customizer: !Screenshot from 2021-06-21 18-15-59.png! > Maven Micronaut projects can not be customized. > --- > > Key: NETBEANS-5803 > URL: https://issues.apache.org/jira/browse/NETBEANS-5803 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Reporter: Martin Entlicher >Assignee: Martin Entlicher >Priority: Critical > Attachments: Screenshot from 2021-06-21 18-15-59.png > > > The maven project support does not handle `https` XML namespace. > http protocol is expected: > `http://maven.apache.org/POM/4.0.0"` > The maven project support does not handle https: > `https://maven.apache.org/POM/4.0.0; ` -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5327) closing bracket stays indented in source+format on record class.
[
https://issues.apache.org/jira/browse/NETBEANS-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pieter van den Hombergh updated NETBEANS-5327:
--
Description:
Normally the source formatter puts the class-closing brace
at the start of the line.
This is not the case for java 14+ (preview) record types. Tested on 12.2 and
12.3-beta2 and 1.4-beta1
Formatting happens when you select soure>format or ctrl+shift+f (linux,
windows).
The problem appears to be related to the canonical constructor definition
_before_ the opening braces, because my normal setting
to put white space before closing parenthesis is also ignored.
{code:java}
// Some comments here
public record IntegerRange( Integer start, Integer end) implements // closing
parens should be preceded
Range { // by whitespace with my
settings
} // offending line, not undented to column 1
{code}
After further investigation, it appears to be influenced by the editor settings
'spaces, within parenthesis, method declaration' When this is turned off, the
effect does not appear.
was:
Normally the source formatter puts the class-closing brace
at the start of the line.
This is not the case for java 14+ (preview) record types. Tested on 12.2 and
12.3-beta2 and 1.4-beta1
Formatting happens when you select soure>format or ctrl+shift+f (linux,
windows).
The problem appears to be related to the canonical constructor definition
_before_ the opening braces, because my normal setting
to put white space before closing parenthesis is also ignored.
{code:java}
// Some comments here
public record IntegerRange( Integer start, Integer end) implements // closing
parens should be preceded
Range { // by whitespace with my
settings
} // offending line, not undented to column 1
{code}
> closing bracket stays indented in source+format on record class.
> -
>
> Key: NETBEANS-5327
> URL: https://issues.apache.org/jira/browse/NETBEANS-5327
> Project: NetBeans
> Issue Type: Improvement
> Components: editor - Formatting Indentation
>Affects Versions: 12.2, 12.3, 12.4
> Environment: ubuntu 20.04 jjdk16 ea netbeans 12.2 and 12.3-beta2
>Reporter: Pieter van den Hombergh
>Priority: Critical
>
> Normally the source formatter puts the class-closing brace
> at the start of the line.
> This is not the case for java 14+ (preview) record types. Tested on 12.2 and
> 12.3-beta2 and 1.4-beta1
> Formatting happens when you select soure>format or ctrl+shift+f (linux,
> windows).
> The problem appears to be related to the canonical constructor definition
> _before_ the opening braces, because my normal setting
> to put white space before closing parenthesis is also ignored.
> {code:java}
> // Some comments here
> public record IntegerRange( Integer start, Integer end) implements // closing
> parens should be preceded
> Range { // by whitespace with my
> settings
> } // offending line, not undented to column 1
> {code}
> After further investigation, it appears to be influenced by the editor
> settings 'spaces, within parenthesis, method declaration' When this is
> turned off, the effect does not appear.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5802) Gradle project wizard should use gradle init
[
https://issues.apache.org/jira/browse/NETBEANS-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366897#comment-17366897
]
Laszlo Kishalmi commented on NETBEANS-5802:
---
That feature would be really nice. Unfortunately my time and energy is focused
on other things than NetBeans these days.
> Gradle project wizard should use gradle init
>
>
> Key: NETBEANS-5802
> URL: https://issues.apache.org/jira/browse/NETBEANS-5802
> Project: NetBeans
> Issue Type: Improvement
> Components: projects - Gradle
>Affects Versions: 12.3
>Reporter: Jaroslav Tulach
>Assignee: Laszlo Kishalmi
>Priority: Major
>
> Hello Laszlo. As soon as I implemented the [VSCode project
> wizard|https://github.com/apache/netbeans/pull/2999] I got following feedback:
> {quote}The New Java Project wizard uses an unusual Gradle template with an
> older deprecated plugins syntax and jacoco included for some reason.
> To make this feature maintainable we should instead use the existing "gradle
> init" functionality:
> {code:java}
> gradle init --type java-application --test-framework junit-jupiter --dsl
> groovy --package com.example --project-name example
> {code}
> {quote}
> Shall we switch the new project in NetBeans to use the above given command?
> Do you want to do it? Or shall I do it?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-5802) Gradle project wizard should use gradle init
Jaroslav Tulach created NETBEANS-5802:
-
Summary: Gradle project wizard should use gradle init
Key: NETBEANS-5802
URL: https://issues.apache.org/jira/browse/NETBEANS-5802
Project: NetBeans
Issue Type: Improvement
Components: projects - Gradle
Affects Versions: 12.3
Reporter: Jaroslav Tulach
Assignee: Laszlo Kishalmi
Hello Laszlo. As soon as I implemented the [VSCode project
wizard|https://github.com/apache/netbeans/pull/2999] I got following feedback:
{quote}The New Java Project wizard uses an unusual Gradle template with an
older deprecated plugins syntax and jacoco included for some reason.
To make this feature maintainable we should instead use the existing "gradle
init" functionality:
{code:java}
gradle init --type java-application --test-framework junit-jupiter --dsl groovy
--package com.example --project-name example
{code}
{quote}
Shall we switch the new project in NetBeans to use the above given command? Do
you want to do it? Or shall I do it?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
