[jira] [Created] (NETBEANS-6146) JSP editor no response when type '<' for long time
James Z created NETBEANS-6146: - Summary: JSP editor no response when type '<' for long time Key: NETBEANS-6146 URL: https://issues.apache.org/jira/browse/NETBEANS-6146 Project: NetBeans Issue Type: Bug Components: javaee - JSP Affects Versions: 12.1 Reporter: James Z Each time when I edit a JSP page, once I type in '<' character the whole IDE will no any response about 70 seconds. I do not edit JSP usually, but this has been a long time issue to me. Edit HTML file no problem, only JSP file. Below is the log: INFO [org.netbeans.modules.masterfs.filebasedfs.FileBasedURLMapper]: URL=file:/Applications/NetBeans/Apache NetBeans 12.1.app/Contents/Resources/NetBeans/netbeans/enterprise/docs/syntaxref20.zip java.net.URISyntaxException: Illegal character in path at index 34: file:/Applications/NetBeans/Apache NetBeans 12.1.app/Contents/Resources/NetBeans/netbeans/enterprise/docs/syntaxref20.zip at java.base/java.net.URI$Parser.fail(URI.java:2938) at java.base/java.net.URI$Parser.checkChars(URI.java:3109) at java.base/java.net.URI$Parser.parseHierarchical(URI.java:3191) at java.base/java.net.URI$Parser.parse(URI.java:3139) at java.base/java.net.URI.(URI.java:623) at java.base/java.net.URL.toURI(URL.java:1063) [catch] at org.netbeans.modules.masterfs.filebasedfs.FileBasedURLMapper.getFileObjects(FileBasedURLMapper.java:73) at org.netbeans.modules.masterfs.MasterURLMapper.getFileObjects(MasterURLMapper.java:40) at org.openide.filesystems.URLMapper.findFileObject(URLMapper.java:188) at org.openide.filesystems.JarArchiveRootProvider.isArchiveFile(JarArchiveRootProvider.java:55) at org.openide.filesystems.FileUtil.getArchiveRoot(FileUtil.java:1847) at org.netbeans.modules.web.core.syntax.JspSyntaxSupport.initCompletionData(JspSyntaxSupport.java:896) at org.netbeans.modules.web.core.syntax.JspSyntaxSupport.getAllTags(JspSyntaxSupport.java:575) at org.netbeans.modules.web.core.syntax.JSPProcessor.createBeanVarDeclarations(JSPProcessor.java:136) at org.netbeans.modules.web.core.syntax.SimplifiedJspServlet.renderProcess(SimplifiedJspServlet.java:237) at org.netbeans.modules.web.core.syntax.JSPProcessor$2.run(JSPProcessor.java:325) at org.netbeans.editor.BaseDocument.render(BaseDocument.java:1402) at org.netbeans.modules.web.core.syntax.JSPProcessor.process(JSPProcessor.java:321) at org.netbeans.modules.web.core.syntax.EmbeddingProviderImpl.getEmbeddings(EmbeddingProviderImpl.java:52) at org.netbeans.modules.parsing.impl.TaskProcessor.callEmbeddingProvider(TaskProcessor.java:576) at org.netbeans.modules.parsing.impl.SourceCache.refresh(SourceCache.java:343) at org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.run(TaskProcessor.java:770) at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279) at org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.execute(TaskProcessor.java:702) at org.netbeans.modules.parsing.impl.TaskProcessor$CompilationJob.run(TaskProcessor.java:663) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033) WARNING [org.netbeans.modules.editor.bracesmatching.MasterMatcher]: Origin offsets out of range, origin = [1392, 1401], caretOffset = 1463, lookahead = 1, searching backwards. Offending BracesMatcher: org.netbeans.modules.html.editor.HtmlBracesMatching@6d6f9361 WARNING [org.netbeans.modules.editor.bracesmatching.MasterMatcher]: Origin offsets out of range, origin = [1392, 1401], caretOffset = 1463, lookahead = 2, searching forward. Offending BracesMatcher: org.netbeans.modules.html.editor.HtmlBracesMatching@4c5e28f8 INFO [org.netbeans.modules.web.core.jsploader.BaseJspEditorSupport$4]: property change fired with both new and old value null! java.lang.IllegalStateException at org.netbeans.modules.web.core.jsploader.BaseJspEditorSupport$4.propertyChange(BaseJspEditorSupport.java:165) at java.desktop/java.beans.PropertyChangeSupport.fire(PropertyChangeSupport.java:341) at java.desktop/java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:333) at java.desktop/java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:266) at org.openide.text.CloneableEditorSupport.firePropertyChange(CloneableEditorSupport.java:459) at org.openide.text.CloneableEditorSupport.fireDocumentChange(CloneableEditorSupport.java:1751) at org.openide.text.DocumentOpenClose$DocumentClose.run(DocumentOpenClose.java:976) at
[netbeans] branch master updated (d8805eb -> bf77340)
This is an automated email from the ASF dual-hosted git repository. matthiasblaesing pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from d8805eb Merge pull request #3170 from juneau001/NETBEANS-5892 new 3f47a99 updated collection to array inspection to refactor to T::new or new T[0]. new 8d3ea82 code formatting. new 56cf1c5 changed SourceVersion comparison as suggested in review. new bf77340 Merge pull request #3166 from mbien/col_to_array The 6053 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../modules/java/hints/perf/Bundle.properties | 18 ++-- .../org/netbeans/modules/java/hints/perf/Tiny.java | 110 +++-- .../netbeans/modules/java/hints/perf/TinyTest.java | 4 +- 3 files changed, 93 insertions(+), 39 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-5892] - Java Maven Web Project not created properly
This is an automated email from the ASF dual-hosted git repository. matthiasblaesing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new b99da4e [NETBEANS-5892] - Java Maven Web Project not created properly new d8805eb Merge pull request #3170 from juneau001/NETBEANS-5892 b99da4e is described below commit b99da4ed1d2a1aac3ec91d457267392656463a9c Author: Josh Juneau AuthorDate: Wed Sep 15 22:31:24 2021 -0500 [NETBEANS-5892] - Java Maven Web Project not created properly --- .../netbeans/modules/maven/j2ee/ui/wizard/archetype/Bundle.properties | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/ui/wizard/archetype/Bundle.properties b/enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/ui/wizard/archetype/Bundle.properties index 86df897..5e05795 100644 --- a/enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/ui/wizard/archetype/Bundle.properties +++ b/enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/ui/wizard/archetype/Bundle.properties @@ -19,9 +19,9 @@ mvn.archetypeGroupId.JakartaEE9=io.github.juneau001 mvn.archetypeVersion.JakartaEE9=1.1 mvn.archetypeArtifactId.JakartaEE9=webapp-jakartaee9 -mvn.archetypeGroupId.JakartaEE8=de.rieckpil.archetypes +mvn.archetypeGroupId.JakartaEE8=io.github.juneau001 mvn.archetypeVersion.JakartaEE8=1.0.0 -mvn.archetypeArtifactId.JakartaEE8=jakartaee8 +mvn.archetypeArtifactId.JakartaEE8=webapp-jakartaee8 mvn.archetypeGroupId.JavaEE8=io.github.juneau001 mvn.archetypeVersion.JavaEE8=1.3 mvn.archetypeArtifactId.JavaEE8=webapp-javaee8 - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated (0e1e0f3 -> 534408e)
This is an automated email from the ASF dual-hosted git repository. matthiasblaesing pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 0e1e0f3 LSP: minor bug fixes (#3256) new 91dbb39 registered "Run File" action to right click menu of hint files. new 9824797 reload global inspection on hint file save. new 21f3f6b Deque interface + descending iterator, java 8 language level updates. new 7bad9cf java 8 language level updates; diamonds, try-with-resource, lambdas etc. new 19331c8 severity for hintfile editor hints. new 534408e Merge pull request #3171 from mbien/hint_reload The 6047 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../hints/declarative/conditionapi/Context.java| 82 ++ .../hints/declarative/conditionapi/Matcher.java| 8 ++- .../debugging/DebuggingHighlightsLayerFactory.java | 1 + .../declarative/debugging/EvaluationSpanTask.java | 36 -- .../hints/declarative/debugging/HintWrapper.java | 2 +- .../debugging/ToggleDebuggingAction.java | 4 +- .../idebinding/HintsActionProvider.java| 19 ++--- .../hints/declarative/idebinding/HintsTask.java| 75 +++- .../idebinding/JavadocForBinaryQueryImpl.java | 6 +- .../idebinding/UpdateGlobalHintsOnSaveTask.java| 65 + .../java/hints/declarative/resources/layer.xml | 8 +++ 11 files changed, 189 insertions(+), 117 deletions(-) create mode 100644 java/java.hints.declarative/src/org/netbeans/modules/java/hints/declarative/idebinding/UpdateGlobalHintsOnSaveTask.java - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6083) Fix Imports move use statement before namespace and file-level docblock
[
https://issues.apache.org/jira/browse/NETBEANS-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432471#comment-17432471
]
frkinta commented on NETBEANS-6083:
---
I see.
In the previous example, when caret is after namespace line, nothing happen.
But before namespace line a dialog is opened and statements shifted
_using netbeans12.5_
> Fix Imports move use statement before namespace and file-level docblock
> ---
>
> Key: NETBEANS-6083
> URL: https://issues.apache.org/jira/browse/NETBEANS-6083
> Project: NetBeans
> Issue Type: Bug
> Components: php - Editor
>Affects Versions: 12.4, 12.5
>Reporter: frkinta
>Priority: Minor
> Attachments: fix_import.gif
>
>
> As you can see in the video, when I first hit _{{"Ctrl+Shift-I}}"_, all
> 'Exception' class of the project are not listed in dropdown.
> Then, when I hit again _{{"Ctrl+Shift-I}}"_ after file-level docblock added,
> all 'Exception' class of the project are listed except the PHP core Exception
> class. After validation, all use statements are moved to the top of the file
> and previously imported 'Exception' class disappear
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6083) Fix Imports move use statement before namespace and file-level docblock
[
https://issues.apache.org/jira/browse/NETBEANS-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432452#comment-17432452
]
Junichi Yamamoto edited comment on NETBEANS-6083 at 10/21/21, 1:22 PM:
---
Duplicate: https://issues.apache.org/jira/browse/NETBEANS-4978
I'll close this(NETBEANS-6083) as a Duplicate later.
was (Author: junichi11):
Duplicate: https://issues.apache.org/jira/browse/NETBEANS-4978
I'll close this as a Duplicate later.
> Fix Imports move use statement before namespace and file-level docblock
> ---
>
> Key: NETBEANS-6083
> URL: https://issues.apache.org/jira/browse/NETBEANS-6083
> Project: NetBeans
> Issue Type: Bug
> Components: php - Editor
>Affects Versions: 12.4, 12.5
>Reporter: frkinta
>Priority: Minor
> Attachments: fix_import.gif
>
>
> As you can see in the video, when I first hit _{{"Ctrl+Shift-I}}"_, all
> 'Exception' class of the project are not listed in dropdown.
> Then, when I hit again _{{"Ctrl+Shift-I}}"_ after file-level docblock added,
> all 'Exception' class of the project are listed except the PHP core Exception
> class. After validation, all use statements are moved to the top of the file
> and previously imported 'Exception' class disappear
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6083) Fix Imports move use statement before namespace and file-level docblock
[
https://issues.apache.org/jira/browse/NETBEANS-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432452#comment-17432452
]
Junichi Yamamoto commented on NETBEANS-6083:
Duplicate: https://issues.apache.org/jira/browse/NETBEANS-4978
I'll close this as a Duplicate later.
> Fix Imports move use statement before namespace and file-level docblock
> ---
>
> Key: NETBEANS-6083
> URL: https://issues.apache.org/jira/browse/NETBEANS-6083
> Project: NetBeans
> Issue Type: Bug
> Components: php - Editor
>Affects Versions: 12.4, 12.5
>Reporter: frkinta
>Priority: Minor
> Attachments: fix_import.gif
>
>
> As you can see in the video, when I first hit _{{"Ctrl+Shift-I}}"_, all
> 'Exception' class of the project are not listed in dropdown.
> Then, when I hit again _{{"Ctrl+Shift-I}}"_ after file-level docblock added,
> all 'Exception' class of the project are listed except the PHP core Exception
> class. After validation, all use statements are moved to the top of the file
> and previously imported 'Exception' class disappear
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6083) Fix Imports move use statement before namespace and file-level docblock
[
https://issues.apache.org/jira/browse/NETBEANS-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432450#comment-17432450
]
Junichi Yamamoto commented on NETBEANS-6083:
Thanks. Maybe, the cause is not a docblock comment but the caret position.
Please try to do it when the caret is after a namespace name.
I'm working on this problem.
> Fix Imports move use statement before namespace and file-level docblock
> ---
>
> Key: NETBEANS-6083
> URL: https://issues.apache.org/jira/browse/NETBEANS-6083
> Project: NetBeans
> Issue Type: Bug
> Components: php - Editor
>Affects Versions: 12.4, 12.5
>Reporter: frkinta
>Priority: Minor
> Attachments: fix_import.gif
>
>
> As you can see in the video, when I first hit _{{"Ctrl+Shift-I}}"_, all
> 'Exception' class of the project are not listed in dropdown.
> Then, when I hit again _{{"Ctrl+Shift-I}}"_ after file-level docblock added,
> all 'Exception' class of the project are listed except the PHP core Exception
> class. After validation, all use statements are moved to the top of the file
> and previously imported 'Exception' class disappear
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6083) Fix Imports move use statement before namespace and file-level docblock
[
https://issues.apache.org/jira/browse/NETBEANS-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432442#comment-17432442
]
frkinta edited comment on NETBEANS-6083 at 10/21/21, 1:14 PM:
--
*Class1.php*
{code:php}
https://www.php-fig.org/psr/psr-12/] and fix
import
was (Author: frkinta):
*Class1.php*
{code:php}
https://www.php-fig.org/psr/psr-12/] and fix
import
> Fix Imports move use statement before namespace and file-level docblock
> ---
>
> Key: NETBEANS-6083
> URL: https://issues.apache.org/jira/browse/NETBEANS-6083
> Project: NetBeans
> Issue Type: Bug
> Components: php - Editor
>Affects Versions: 12.4, 12.5
>Reporter: frkinta
>Priority: Minor
> Attachments: fix_import.gif
>
>
> As you can see in the video, when I first hit _{{"Ctrl+Shift-I}}"_, all
> 'Exception' class of the project are not listed in dropdown.
> Then, when I hit again _{{"Ctrl+Shift-I}}"_ after file-level docblock added,
> all 'Exception' class of the project are listed except the PHP core Exception
> class. After validation, all use statements are moved to the top of the file
> and previously imported 'Exception' class disappear
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6083) Fix Imports move use statement before namespace and file-level docblock
[
https://issues.apache.org/jira/browse/NETBEANS-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432442#comment-17432442
]
frkinta commented on NETBEANS-6083:
---
*Class1.php*
{code:php}
https://www.php-fig.org/psr/psr-12/] and fix
import
> Fix Imports move use statement before namespace and file-level docblock
> ---
>
> Key: NETBEANS-6083
> URL: https://issues.apache.org/jira/browse/NETBEANS-6083
> Project: NetBeans
> Issue Type: Bug
> Components: php - Editor
>Affects Versions: 12.4, 12.5
>Reporter: frkinta
>Priority: Minor
> Attachments: fix_import.gif
>
>
> As you can see in the video, when I first hit _{{"Ctrl+Shift-I}}"_, all
> 'Exception' class of the project are not listed in dropdown.
> Then, when I hit again _{{"Ctrl+Shift-I}}"_ after file-level docblock added,
> all 'Exception' class of the project are listed except the PHP core Exception
> class. After validation, all use statements are moved to the top of the file
> and previously imported 'Exception' class disappear
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5523) False positive on using "Require" in namespace
[
https://issues.apache.org/jira/browse/NETBEANS-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432348#comment-17432348
]
Junichi Yamamoto commented on NETBEANS-5523:
Thanks.
> False positive on using "Require" in namespace
> --
>
> Key: NETBEANS-5523
> URL: https://issues.apache.org/jira/browse/NETBEANS-5523
> Project: NetBeans
> Issue Type: Wish
> Components: php - Editor
>Affects Versions: Next
> Environment: Apache NetBeans IDE DEV (Build
> dev-decaf3341a9ce6147e26557e8a09fbf8a4cfc2f8)
>Reporter: Jayce
>Assignee: Junichi Yamamoto
>Priority: Trivial
> Attachments: NetbeansWrong.png
>
>
> Hi,
> This line is correct:
> {code:java}
> namespace \Foo\Bar\Require;
> {code}
> Netbeans report it as a syntax error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5523) False positive on using "Require" in namespace
[
https://issues.apache.org/jira/browse/NETBEANS-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432346#comment-17432346
]
Jayce commented on NETBEANS-5523:
-
i think it's this RFC:
https://wiki.php.net/rfc/namespaced_names_as_token
> False positive on using "Require" in namespace
> --
>
> Key: NETBEANS-5523
> URL: https://issues.apache.org/jira/browse/NETBEANS-5523
> Project: NetBeans
> Issue Type: Wish
> Components: php - Editor
>Affects Versions: Next
> Environment: Apache NetBeans IDE DEV (Build
> dev-decaf3341a9ce6147e26557e8a09fbf8a4cfc2f8)
>Reporter: Jayce
>Assignee: Junichi Yamamoto
>Priority: Trivial
> Attachments: NetbeansWrong.png
>
>
> Hi,
> This line is correct:
> {code:java}
> namespace \Foo\Bar\Require;
> {code}
> Netbeans report it as a syntax error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5523) False positive on using "Require" in namespace
[
https://issues.apache.org/jira/browse/NETBEANS-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432330#comment-17432330
]
Junichi Yamamoto commented on NETBEANS-5523:
> It IS correct,
I know it. It is implemented in PHP 8.0. (It is invalid in PHP 7.4 or older.)
There should be documentation somewhere (e.g. rfc, PHP manual). So I asked you
(Do you know where to find the documentation about it?) If you know it, please
tell me. If you don't know, I'll look for it later.
> False positive on using "Require" in namespace
> --
>
> Key: NETBEANS-5523
> URL: https://issues.apache.org/jira/browse/NETBEANS-5523
> Project: NetBeans
> Issue Type: Wish
> Components: php - Editor
>Affects Versions: Next
> Environment: Apache NetBeans IDE DEV (Build
> dev-decaf3341a9ce6147e26557e8a09fbf8a4cfc2f8)
>Reporter: Jayce
>Assignee: Junichi Yamamoto
>Priority: Trivial
> Attachments: NetbeansWrong.png
>
>
> Hi,
> This line is correct:
> {code:java}
> namespace \Foo\Bar\Require;
> {code}
> Netbeans report it as a syntax error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4978) PHP Menu Source->Fix uses break code
[ https://issues.apache.org/jira/browse/NETBEANS-4978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432322#comment-17432322 ] Jayce commented on NETBEANS-4978: - Bump, it's very annoying... > PHP Menu Source->Fix uses break code > > > Key: NETBEANS-4978 > URL: https://issues.apache.org/jira/browse/NETBEANS-4978 > Project: NetBeans > Issue Type: Improvement > Components: php - Editor >Affects Versions: 12.0 >Reporter: Jayce >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: 01BeforeFixUses.png, 02AfterFixUses.png, BugClass.php, > BugScreencast.mov > > > Using "Fix Uses" (Source menu) break code by moving "use \Package\To\Use;" > before "declare(strict_types=1);" > It does not happen if a use line is already present in the source code (at > the correct position). > declare(strict_types=1); must always be the first line. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5523) False positive on using "Require" in namespace
[
https://issues.apache.org/jira/browse/NETBEANS-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432318#comment-17432318
]
Jayce commented on NETBEANS-5523:
-
That's what i said.
It IS correct, but Netbeans falsely report it as incorrect, see screenshot
attached
> False positive on using "Require" in namespace
> --
>
> Key: NETBEANS-5523
> URL: https://issues.apache.org/jira/browse/NETBEANS-5523
> Project: NetBeans
> Issue Type: Wish
> Components: php - Editor
>Affects Versions: Next
> Environment: Apache NetBeans IDE DEV (Build
> dev-decaf3341a9ce6147e26557e8a09fbf8a4cfc2f8)
>Reporter: Jayce
>Assignee: Junichi Yamamoto
>Priority: Trivial
> Attachments: NetbeansWrong.png
>
>
> Hi,
> This line is correct:
> {code:java}
> namespace \Foo\Bar\Require;
> {code}
> Netbeans report it as a syntax error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5523) False positive on using "Require" in namespace
[
https://issues.apache.org/jira/browse/NETBEANS-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jayce updated NETBEANS-5523:
Attachment: NetbeansWrong.png
> False positive on using "Require" in namespace
> --
>
> Key: NETBEANS-5523
> URL: https://issues.apache.org/jira/browse/NETBEANS-5523
> Project: NetBeans
> Issue Type: Wish
> Components: php - Editor
>Affects Versions: Next
> Environment: Apache NetBeans IDE DEV (Build
> dev-decaf3341a9ce6147e26557e8a09fbf8a4cfc2f8)
>Reporter: Jayce
>Assignee: Junichi Yamamoto
>Priority: Trivial
> Attachments: NetbeansWrong.png
>
>
> Hi,
> This line is correct:
> {code:java}
> namespace \Foo\Bar\Require;
> {code}
> Netbeans report it as a syntax error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: LSP: minor bug fixes (#3256)
This is an automated email from the ASF dual-hosted git repository.
dbalek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 0e1e0f3 LSP: minor bug fixes (#3256)
0e1e0f3 is described below
commit 0e1e0f30f061180c5c900421c931c6c9db1824f3
Author: Dusan Balek
AuthorDate: Thu Oct 21 10:31:16 2021 +0200
LSP: minor bug fixes (#3256)
* GR-34384: Multiple hints suggesting to add the same import.
* GR-34412: Do not show MalformedURLException when untitled file is open in
VSCode.
* GR-34553: VSCode: Broken code completion inside a Java class body.
* GR-34533: Hint prefixed by .
* GR-34480: Changing the method name for introduce method refactoring
doesn't work.
* GR-33806: Generated equals method shows by default a warning.
* Enable tests for java.lsp.server module.
---
.travis.yml| 2 +-
.../org/netbeans/modules/parsing/api/Source.java | 2 +-
.../editor/java/JavaCompletionCollector.java | 46 +++--
.../editor/codegen/EqualsHashCodeGenerator.java| 76 ++
.../java/editor/imports/ComputeImports.java| 30 +-
.../codegen/EqualsHashCodeGeneratorTest.java | 15 +--
.../modules/java/hints/errors/Bundle.properties| 2 +-
java/java.lsp.server/nbproject/project.xml | 9 ++
.../server/protocol/TextDocumentServiceImpl.java | 109 -
.../java/lsp/server/protocol/ServerTest.java | 36 +++
10 files changed, 190 insertions(+), 137 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 9e3022d..b9f9842 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -363,7 +363,7 @@ matrix:
#- ant $OPTS -f java/java.kit test
#- ant $OPTS -f java/java.lexer test
#- ant $OPTS -f java/java.lexer test
-#- ant $OPTS -f java/java.lsp.server test
+- ant $OPTS -f java/java.lsp.server test
#- ant $OPTS -f java/java.metrics test
- ant $OPTS -f java/java.module.graph test
- ant $OPTS -f java/java.navigation test
diff --git a/ide/parsing.api/src/org/netbeans/modules/parsing/api/Source.java
b/ide/parsing.api/src/org/netbeans/modules/parsing/api/Source.java
index 6fd7899..f886f9e 100644
--- a/ide/parsing.api/src/org/netbeans/modules/parsing/api/Source.java
+++ b/ide/parsing.api/src/org/netbeans/modules/parsing/api/Source.java
@@ -908,7 +908,7 @@ public final class Source implements Lookup.Provider {
final boolean oldChanged = sourceChanged();
if (oldChanged == changed) {
start = Math.min(start, startOffset);
-end = Math.min(end, endOffset);
+end = Math.max(end, endOffset);
return new ASourceModificationEvent (getSource(), oldChanged,
start, end);
} else {
final ASourceModificationEvent other = new
ASourceModificationEvent(getSource(), changed, start, end);
diff --git
a/java/java.editor/src/org/netbeans/modules/editor/java/JavaCompletionCollector.java
b/java/java.editor/src/org/netbeans/modules/editor/java/JavaCompletionCollector.java
index bab6cf2..ce9aafc 100644
---
a/java/java.editor/src/org/netbeans/modules/editor/java/JavaCompletionCollector.java
+++
b/java/java.editor/src/org/netbeans/modules/editor/java/JavaCompletionCollector.java
@@ -64,7 +64,10 @@ import javax.lang.model.type.TypeVariable;
import javax.lang.model.type.WildcardType;
import javax.lang.model.util.Elements;
import javax.lang.model.util.Types;
+import javax.swing.text.BadLocationException;
import javax.swing.text.Document;
+import org.netbeans.api.editor.document.LineDocument;
+import org.netbeans.api.editor.document.LineDocumentUtils;
import org.netbeans.api.editor.mimelookup.MimeRegistration;
import org.netbeans.api.java.lexer.JavaTokenId;
import org.netbeans.api.java.source.CodeStyle;
@@ -158,6 +161,7 @@ public class JavaCompletionCollector implements
CompletionCollector {
JavaCompletionTask.LambdaItemFactory,
JavaCompletionTask.ModuleItemFactory {
private static final Set SUPPORTED_ELEMENT_KINDS = new
HashSet<>(Arrays.asList("PACKAGE", "CLASS", "INTERFACE", "ENUM",
"ANNOTATION_TYPE", "METHOD", "CONSTRUCTOR", "INSTANCE_INIT", "STATIC_INIT",
"FIELD", "ENUM_CONSTANT", "TYPE_PARAMETER", "MODULE"));
+private static final String EMPTY = "";
private static final String ERROR = "";
private static final int DEPRECATED = 10;
private final Document doc;
@@ -200,7 +204,7 @@ public class JavaCompletionCollector implements
CompletionCollector {
return CompletionCollector.newBuilder(simpleName)
.kind(Completion.Kind.Folder)
.sortText(String.format("%04d%s#%s", 1900, simpleName,
pkgFQN))
-.insertText(simpleName +
[netbeans] branch master updated: Don't search for parent folders when there is .mxignore file
This is an automated email from the ASF dual-hosted git repository.
jtulach pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 2f00fe2 Don't search for parent folders when there is .mxignore file
new e862a36 Merge pull request #3255 from
JaroslavTulach/jtulach/HonorMxIgnore
2f00fe2 is described below
commit 2f00fe22384a0d81cf1613cb79bbf8f928d89980
Author: Jaroslav Tulach
AuthorDate: Tue Oct 19 11:21:46 2021 +0200
Don't search for parent folders when there is .mxignore file
---
.../modules/java/mx/project/SuiteFactory.java | 16 +-
.../modules/java/mx/project/SuiteFactoryTest.java | 59 ++
2 files changed, 74 insertions(+), 1 deletion(-)
diff --git
a/java/java.mx.project/src/org/netbeans/modules/java/mx/project/SuiteFactory.java
b/java/java.mx.project/src/org/netbeans/modules/java/mx/project/SuiteFactory.java
index f43e519..7abdb95 100644
---
a/java/java.mx.project/src/org/netbeans/modules/java/mx/project/SuiteFactory.java
+++
b/java/java.mx.project/src/org/netbeans/modules/java/mx/project/SuiteFactory.java
@@ -63,7 +63,7 @@ public class SuiteFactory implements ProjectFactory2 {
// Support the case where a subproject is directly opened. The mx
// netbeans configuration generator generates java ant projects on the
// subproject level. This is detected and overriden by this factory.
-FileObject baseDir2 = fo.getParent() != null ?
fo.getParent().getParent() : null;
+FileObject baseDir2 = parentNoIgnore(parentNoIgnore(fo));
if (baseDir2 != null) {
final String mxDirName2 = "mx." + baseDir2.getNameExt();
@@ -74,6 +74,20 @@ public class SuiteFactory implements ProjectFactory2 {
}
}
+static FileObject parentNoIgnore(FileObject fo) {
+if (fo == null) {
+return null;
+}
+FileObject p = fo.getParent();
+if (p == null) {
+return null;
+}
+if (p.getFileObject(".mxignore") != null) { // NOI18N
+return null;
+}
+return p;
+}
+
@Override
public Project loadProject(FileObject dir, ProjectState ps) throws
IOException {
FileObject suitePy = findSuitePy(dir);
diff --git
a/java/java.mx.project/test/unit/src/org/netbeans/modules/java/mx/project/SuiteFactoryTest.java
b/java/java.mx.project/test/unit/src/org/netbeans/modules/java/mx/project/SuiteFactoryTest.java
new file mode 100644
index 000..053ee25
--- /dev/null
+++
b/java/java.mx.project/test/unit/src/org/netbeans/modules/java/mx/project/SuiteFactoryTest.java
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.java.mx.project;
+
+import org.junit.Test;
+import static org.junit.Assert.*;
+import org.openide.filesystems.FileObject;
+import org.openide.filesystems.FileUtil;
+
+public class SuiteFactoryTest {
+
+public SuiteFactoryTest() {
+}
+
+@Test
+public void honorMxIgnoreFileWhenTraveringToParent() throws Exception {
+FileObject root = FileUtil.createMemoryFileSystem().getRoot();
+FileObject f1 = root.createFolder("f1");
+FileObject f2 = f1.createData("x.txt");
+FileObject ignore = f1.createData(".mxignore");
+
+FileObject p = SuiteFactory.parentNoIgnore(f2);
+assertNull("Parent is ignored", p);
+}
+
+@Test
+public void simpleParentFound() throws Exception {
+FileObject root = FileUtil.createMemoryFileSystem().getRoot();
+FileObject f1 = root.createFolder("f1");
+FileObject f2 = f1.createData("x.txt");
+
+FileObject p = SuiteFactory.parentNoIgnore(f2);
+assertSame("Found the right parent", f1, p);
+}
+
+@Test
+public void rootHasNoParent() throws Exception {
+FileObject root = FileUtil.createMemoryFileSystem().getRoot();
+FileObject p = SuiteFactory.parentNoIgnore(root);
+assertNull("No parent for root", p);
+}
+
+}
-
To
[jira] [Closed] (NETBEANS-6087) Refactor a private function inside trait don't apply everywhere
[ https://issues.apache.org/jira/browse/NETBEANS-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junichi Yamamoto closed NETBEANS-6087. -- Fix Version/s: 12.6 Resolution: Fixed Fixed. > Refactor a private function inside trait don't apply everywhere > --- > > Key: NETBEANS-6087 > URL: https://issues.apache.org/jira/browse/NETBEANS-6087 > Project: NetBeans > Issue Type: Bug > Components: php - Editor, php - Refactoring >Affects Versions: 12.4, 12.5 >Reporter: frkinta >Assignee: Junichi Yamamoto >Priority: Minor > Labels: pull-request-available > Fix For: 12.6 > > Attachments: update_private_method_in_trait.gif > > Time Spent: 50m > Remaining Estimate: 0h > > I'm trying to refactor a private function inside trait but the function name > is not changed to the new one where they are called in other classes -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5523) False positive on using "Require" in namespace
[
https://issues.apache.org/jira/browse/NETBEANS-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432218#comment-17432218
]
Junichi Yamamoto commented on NETBEANS-5523:
It seems to be valid in PHP 8.0. Do you know where to find the documentation
about it?
> False positive on using "Require" in namespace
> --
>
> Key: NETBEANS-5523
> URL: https://issues.apache.org/jira/browse/NETBEANS-5523
> Project: NetBeans
> Issue Type: Wish
> Components: php - Editor
>Affects Versions: Next
> Environment: Apache NetBeans IDE DEV (Build
> dev-decaf3341a9ce6147e26557e8a09fbf8a4cfc2f8)
>Reporter: Jayce
>Assignee: Junichi Yamamoto
>Priority: Trivial
>
> Hi,
> This line is correct:
> {code:java}
> namespace \Foo\Bar\Require;
> {code}
> Netbeans report it as a syntax error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-6087] Use the refactoring feature for private members of trait instead of the instant renamer
This is an automated email from the ASF dual-hosted git repository.
tmysik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 60c71c7 [NETBEANS-6087] Use the refactoring feature for private
members of trait instead of the instant renamer
new e46dd1d Merge pull request #3257 from
junichi11/netbeans-6087-rename-private-trait-method
60c71c7 is described below
commit 60c71c7a1f17a21fcf00a584890b65fac3d3427d
Author: Junichi Yamamoto
AuthorDate: Wed Oct 20 19:46:41 2021 +0900
[NETBEANS-6087] Use the refactoring feature for private members of trait
instead of the instant renamer
- https://issues.apache.org/jira/browse/NETBEANS-6087
- Classes can also use private members of traits. If the declaration of the
member is in another file, only member names in the same file are renamed using
the instant renamer. So, we have to use the refactoring feature instead of it.
---
.../modules/php/editor/csl/InstantRenamerImpl.java | 7 +++--
.../php/findusages/WhereUsedSupport.java | 5 ++-
.../data/testfiles/findusages/testNB6087/index.php | 36 ++
...x.php.testNB6087_PrivateTraitField01.findUsages | 14 +
...x.php.testNB6087_PrivateTraitField02.findUsages | 14 +
php.testNB6087_PrivateTraitMethod01.findUsages | 14 +
php.testNB6087_PrivateTraitMethod02.findUsages | 14 +
.../testfiles/findusages/testNB6087/nb6087.php | 31 +++
...7.php.testNB6087_PrivateTraitField03.findUsages | 14 +
php.testNB6087_PrivateTraitMethod03.findUsages | 14 +
.../php/findusages/FindUsagesTestBase.java | 13 +++-
.../php/findusages/WhereUsedSupportTest.java | 24 +++
12 files changed, 196 insertions(+), 4 deletions(-)
diff --git
a/php/php.editor/src/org/netbeans/modules/php/editor/csl/InstantRenamerImpl.java
b/php/php.editor/src/org/netbeans/modules/php/editor/csl/InstantRenamerImpl.java
index f0ee97a..769674d 100644
---
a/php/php.editor/src/org/netbeans/modules/php/editor/csl/InstantRenamerImpl.java
+++
b/php/php.editor/src/org/netbeans/modules/php/editor/csl/InstantRenamerImpl.java
@@ -32,6 +32,7 @@ import
org.netbeans.modules.php.editor.api.elements.FieldElement;
import org.netbeans.modules.php.editor.api.elements.MethodElement;
import org.netbeans.modules.php.editor.api.elements.PhpElement;
import org.netbeans.modules.php.editor.api.elements.TypeConstantElement;
+import org.netbeans.modules.php.editor.api.elements.TypeElement;
import org.netbeans.modules.php.editor.model.Model;
import org.netbeans.modules.php.editor.model.Occurence;
import org.netbeans.modules.php.editor.model.Occurence.Accuracy;
@@ -75,13 +76,15 @@ public class InstantRenamerImpl implements InstantRenamer {
} else if (decl instanceof MethodElement) {
MethodElement meth = (MethodElement) decl;
PhpModifiers phpModifiers = meth.getPhpModifiers();
-if (phpModifiers.isPrivate()) {
+if (phpModifiers.isPrivate() &&
!meth.getType().isTrait()) {
+// NETBEANS-6087 private methods of trait are used
in classes
return checkAll(caretOccurence);
}
} else if (decl instanceof FieldElement) {
FieldElement fld = (FieldElement) decl;
PhpModifiers phpModifiers = fld.getPhpModifiers();
-if (phpModifiers.isPrivate()) {
+if (phpModifiers.isPrivate() &&
!fld.getType().isTrait()) {
+// NETBEANS-6087 private field of trait are used
in classes
return checkAll(caretOccurence);
}
} else if (decl instanceof TypeConstantElement) {
diff --git
a/php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/WhereUsedSupport.java
b/php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/WhereUsedSupport.java
index 112555d..48c8961 100644
---
a/php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/WhereUsedSupport.java
+++
b/php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/WhereUsedSupport.java
@@ -55,6 +55,8 @@ import org.netbeans.modules.php.editor.model.ModelElement;
import org.netbeans.modules.php.editor.model.ModelFactory;
import org.netbeans.modules.php.editor.model.ModelUtils;
import org.netbeans.modules.php.editor.model.Occurence;
+import org.netbeans.modules.php.editor.model.Scope;
+import org.netbeans.modules.php.editor.model.TraitScope;
import org.netbeans.modules.php.editor.model.TypeScope;
import org.netbeans.modules.php.editor.model.VariableName;
import
