[netbeans] 12/12: Upgraded the patched modules and the readme with building instructions.
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a commit to branch release110 in repository https://gitbox.apache.org/repos/asf/netbeans.git commit 67a590ca78f4ecf5483c8f67ed73052ce1e67473 Author: Laszlo Kishalmi AuthorDate: Sun May 19 14:08:03 2019 -0700 Upgraded the patched modules and the readme with building instructions. --- README.md | 11 +++ groovy/gradle.java/manifest.mf | 2 +- groovy/gradle.test/manifest.mf | 2 +- groovy/gradle/manifest.mf | 2 +- 4 files changed, 14 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index d09de65..dd39ad8 100644 --- a/README.md +++ b/README.md @@ -63,6 +63,17 @@ $ ant -Dcluster.config=platform **Note:** You can also use `php`, `enterprise`, etc. See the [cluster.properties](https://github.com/apache/incubator-netbeans/blob/master/nbbuild/cluster.properties) file. + Building Patch from Sources + +Patch source releases does not contain all the code sufficient to build a patch release. In oder to build a patch release, it is required to download the source code of a previous full release. The steps would be the following: + +1. Create a directory for the sources: ```mkdir netbeans-patch-src``` +2. Download the full release zip required for the patch. +3. Download the patch sources zip. +4. Unzip the release sources into ```netbeans-patch-src``` +5. Unzip the patch sources into ```netbeans-patch-src``` overwrite the existing ones. +6. Go to the ```netbeans-patch-src``` and follow the build instructions above. + Building Windows Launchers Windows launchers can be build using [MinGW](http://www.mingw.org/) both on Windows and Linux. diff --git a/groovy/gradle.java/manifest.mf b/groovy/gradle.java/manifest.mf index 4d4d451..42f31be 100644 --- a/groovy/gradle.java/manifest.mf +++ b/groovy/gradle.java/manifest.mf @@ -3,4 +3,4 @@ AutoUpdate-Show-In-Client: false OpenIDE-Module: org.netbeans.modules.gradle.java OpenIDE-Module-Layer: org/netbeans/modules/gradle/java/layer.xml OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/gradle/java/Bundle.properties -OpenIDE-Module-Specification-Version: 1.0.1 +OpenIDE-Module-Specification-Version: 1.0.2 diff --git a/groovy/gradle.test/manifest.mf b/groovy/gradle.test/manifest.mf index 11d2208..7ff88d6 100644 --- a/groovy/gradle.test/manifest.mf +++ b/groovy/gradle.test/manifest.mf @@ -2,4 +2,4 @@ Manifest-Version: 1.0 AutoUpdate-Show-In-Client: false OpenIDE-Module: org.netbeans.modules.gradle.test OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/gradle/test/Bundle.properties -OpenIDE-Module-Specification-Version: 1.0.1 +OpenIDE-Module-Specification-Version: 1.0.2 diff --git a/groovy/gradle/manifest.mf b/groovy/gradle/manifest.mf index fedf0d3..bc77264 100644 --- a/groovy/gradle/manifest.mf +++ b/groovy/gradle/manifest.mf @@ -3,5 +3,5 @@ AutoUpdate-Show-In-Client: false OpenIDE-Module: org.netbeans.modules.gradle OpenIDE-Module-Layer: org/netbeans/modules/gradle/layer.xml OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/gradle/Bundle.properties -OpenIDE-Module-Specification-Version: 1.0.1 +OpenIDE-Module-Specification-Version: 1.0.2 - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 11/12: [NETBEANS-2288] Fixed Auxialiary properties to use 'netbeans.' prefix as other part of the plugin expects.
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch release110
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit 562a736bf026d9d56594b981a85b01418c8b94ba
Author: Laszlo Kishalmi
AuthorDate: Sun May 19 07:13:41 2019 -0700
[NETBEANS-2288] Fixed Auxialiary properties to use 'netbeans.' prefix as
other part of the plugin expects.
---
.../modules/gradle/GradleAuxiliaryPropertiesImpl.java| 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git
a/groovy/gradle/src/org/netbeans/modules/gradle/GradleAuxiliaryPropertiesImpl.java
b/groovy/gradle/src/org/netbeans/modules/gradle/GradleAuxiliaryPropertiesImpl.java
index aa70c21..8aa974e 100644
---
a/groovy/gradle/src/org/netbeans/modules/gradle/GradleAuxiliaryPropertiesImpl.java
+++
b/groovy/gradle/src/org/netbeans/modules/gradle/GradleAuxiliaryPropertiesImpl.java
@@ -26,8 +26,10 @@ import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
+import java.util.HashSet;
import java.util.LinkedList;
import java.util.List;
+import java.util.Set;
import org.netbeans.api.project.ProjectManager;
import org.netbeans.spi.project.AuxiliaryProperties;
import org.openide.util.EditableProperties;
@@ -39,7 +41,10 @@ import org.openide.util.Mutex.Action;
*/
public class GradleAuxiliaryPropertiesImpl implements AuxiliaryProperties {
-private static final String PROP_PREFIX = "nb-config."; //NOI18N
+private static final String WRONG_PREFIX = "nb-config."; //NOI18N
+// USE THIS PREFIX [NETBEANS-2288], AS IT CAN BE OVERWRITTEN IN
+// GRADLE PROPERTY FILES
+private static final String PROP_PREFIX = "netbeans."; //NOI18N
final NbGradleProjectImpl project;
@@ -52,7 +57,8 @@ public class GradleAuxiliaryPropertiesImpl implements
AuxiliaryProperties {
return ProjectManager.mutex().readAccess(new Action() {
@Override
public String run() {
-return getProperties(shared).get(PROP_PREFIX + key);
+EditableProperties props = getProperties(shared);
+return props.getOrDefault(PROP_PREFIX + key,
props.get(WRONG_PREFIX + key));
}
});
}
@@ -65,6 +71,7 @@ public class GradleAuxiliaryPropertiesImpl implements
AuxiliaryProperties {
props.put(PROP_PREFIX + key, value);
} else {
props.remove(PROP_PREFIX + key);
+props.remove(WRONG_PREFIX + key);
}
putProperties(props, shared);
@@ -73,12 +80,15 @@ public class GradleAuxiliaryPropertiesImpl implements
AuxiliaryProperties {
@Override
public Iterable listKeys(boolean shared) {
-List ret = new LinkedList<>();
+Set ret = new HashSet<>();
EditableProperties props = getProperties(shared);
for (String key : props.keySet()) {
if (key.startsWith(PROP_PREFIX)) {
ret.add(key.substring(PROP_PREFIX.length()));
}
+if (key.startsWith(WRONG_PREFIX)) {
+ret.add(key.substring(WRONG_PREFIX.length()));
+}
}
return ret;
}
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 02/12: [NETBEANS-2346] Fixed index out of bound exception in GAV parsing.
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch release110
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit f6e014819a75ae9a8e35d01cf2eefc9cbaa50f7d
Author: Laszlo Kishalmi
AuthorDate: Sat Apr 6 05:35:25 2019 -0700
[NETBEANS-2346] Fixed index out of bound exception in GAV parsing.
---
.../modules/gradle/api/GradleBaseProject.java | 2 +-
.../modules/gradle/api/GradleConfiguration.java| 2 +-
.../modules/gradle/api/GradleDependency.java | 15 -
.../modules/gradle/nodes/ConfigurationsNode.java | 4 +-
.../actions/ActionMappingPropertyReaderTest.java | 22 +++---
.../modules/gradle/api/GradleDepandencyTest.java | 78 ++
6 files changed, 105 insertions(+), 18 deletions(-)
diff --git
a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleBaseProject.java
b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleBaseProject.java
index 8c16759..49a4f14 100644
--- a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleBaseProject.java
+++ b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleBaseProject.java
@@ -256,7 +256,7 @@ public final class GradleBaseProject implements
Serializable, ModuleSearchSuppor
@Override
public Set findModules(String gav) {
-String parts[] = gav.split(":");
+String parts[] = GradleDependency.gavSplit(gav);
if (parts.length != 3) {
throw new IllegalArgumentException("Invalid gav filter: " + gav);
}
diff --git
a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleConfiguration.java
b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleConfiguration.java
index f269b5e..fe6b233 100644
--- a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleConfiguration.java
+++ b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleConfiguration.java
@@ -86,7 +86,7 @@ public final class GradleConfiguration implements
Serializable, ModuleSearchSupp
@Override
public Set findModules(String gav) {
-String parts[] = gav.split(":");
+String parts[] = GradleDependency.gavSplit(gav);
if (parts.length != 3) {
throw new IllegalArgumentException("Invalid gav filter: " + gav);
}
diff --git
a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleDependency.java
b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleDependency.java
index 7d1decb..ab2b588 100644
--- a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleDependency.java
+++ b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleDependency.java
@@ -63,6 +63,19 @@ public abstract class GradleDependency implements
Serializable, Comparable artifacts) {
super(id);
this.artifacts = artifacts;
-String[] parts = id.split(":");
+String[] parts = gavSplit(id);
group = parts[0];
name = parts[1];
version = parts[2];
diff --git
a/groovy/gradle/src/org/netbeans/modules/gradle/nodes/ConfigurationsNode.java
b/groovy/gradle/src/org/netbeans/modules/gradle/nodes/ConfigurationsNode.java
index e57077e..4300195 100644
---
a/groovy/gradle/src/org/netbeans/modules/gradle/nodes/ConfigurationsNode.java
+++
b/groovy/gradle/src/org/netbeans/modules/gradle/nodes/ConfigurationsNode.java
@@ -290,7 +290,7 @@ public class ConfigurationsNode extends AbstractNode {
GradleProject gp = project.getGradleProject();
ArrayList ret = new ArrayList<>();
GradleConfiguration conf =
gp.getBaseProject().getConfigurations().get(configuration);
-// We can get null here ins ome extreme cases, e.g. when the
project is being deleted
+// We can get null here in some extreme cases, e.g. when the
project is being deleted
if (conf != null) {
ret.addAll(conf.getUnresolved());
ret.addAll(conf.getProjects());
@@ -370,7 +370,7 @@ public class ConfigurationsNode extends AbstractNode {
@Override
public String getDisplayName() {
-return module.getName() + ":" + module.getVersion();
+return module.getVersion().isEmpty() ? module.getName() :
module.getName() + ":" + module.getVersion();
}
@Override
diff --git
a/groovy/gradle/test/unit/src/org/netbeans/modules/gradle/actions/ActionMappingPropertyReaderTest.java
b/groovy/gradle/test/unit/src/org/netbeans/modules/gradle/actions/ActionMappingPropertyReaderTest.java
index 99a7dfd..d6ad668 100644
---
a/groovy/gradle/test/unit/src/org/netbeans/modules/gradle/actions/ActionMappingPropertyReaderTest.java
+++
b/groovy/gradle/test/unit/src/org/netbeans/modules/gradle/actions/ActionMappingPropertyReaderTest.java
@@ -22,10 +22,6 @@ import java.util.Arrays;
import java.util.HashSet;
import java.util.Properties;
import java.util.Set;
-import org.junit.After;
-import org.junit.AfterClass;
-import
[netbeans] 09/12: [NETBEANS-2527] Update TestSuites in a Gradle Test Run upon completion.
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch release110
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit 559a4722a6816c91299db127db490f4bd98a41e2
Author: Laszlo Kishalmi
AuthorDate: Sat May 18 09:25:32 2019 -0700
[NETBEANS-2527] Update TestSuites in a Gradle Test Run upon completion.
---
.../gradle/test/GradleTestProgressListener.java| 52 ++
.../modules/gradle/test/GradleTestSuite.java | 45 ---
2 files changed, 64 insertions(+), 33 deletions(-)
diff --git
a/groovy/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
b/groovy/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
index 383ba7c..ce2f76d 100644
---
a/groovy/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
+++
b/groovy/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
@@ -23,9 +23,9 @@ import org.netbeans.modules.gradle.api.NbGradleProject;
import java.util.Collection;
import org.netbeans.modules.gradle.spi.GradleProgressListenerProvider;
import java.util.EnumSet;
-import java.util.HashMap;
import java.util.Map;
import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import org.gradle.tooling.Failure;
@@ -57,11 +57,12 @@ import org.openide.util.Lookup;
* @author Laszlo Kishalmi
*/
@ProjectServiceProvider(service = GradleProgressListenerProvider.class,
projectType = NbGradleProject.GRADLE_PLUGIN_TYPE + "/java")
-public class GradleTestProgressListener implements ProgressListener,
GradleProgressListenerProvider {
+public final class GradleTestProgressListener implements ProgressListener,
GradleProgressListenerProvider {
final private Project project;
TestSession session;
-Map runningTests = new HashMap<>();
+
+Map runningTests = new ConcurrentHashMap<>();
public GradleTestProgressListener(Project project) {
this.project = project;
@@ -125,47 +126,42 @@ public class GradleTestProgressListener implements
ProgressListener, GradleProgr
}
private void sessionFinish(TestFinishEvent evt) {
-TestOperationResult result = evt.getResult();
-Report report = session.getReport(result.getEndTime() -
result.getStartTime());
+runningTests.clear();
CoreManager manager = getManager();
if (manager != null) {
manager.sessionFinished(session);
-manager.displayReport(session, report, true);
-manager.sessionFinished(session);
}
}
private void suiteStart(TestStartEvent evt, JvmTestOperationDescriptor op)
{
-if (op.getClassName() != null) {
-TestSuite suite = new GradleTestSuite(op);
-session.addSuite(suite);
+}
+
+private void suiteFinish(TestFinishEvent evt, JvmTestOperationDescriptor
op) {
+TestOperationResult result = evt.getResult();
+TestSuite currentSuite = session.getCurrentSuite();
+String suiteName = GradleTestSuite.suiteName(op);
+if (suiteName.equals(currentSuite.getName())) {
+Report report = session.getReport(result.getEndTime() -
result.getStartTime());
CoreManager manager = getManager();
if (manager != null) {
-manager.displaySuiteRunning(session, suite);
+manager.displayReport(session, report, true);
}
}
}
-private void suiteFinish(TestFinishEvent evt, JvmTestOperationDescriptor
op) {
-
-}
-
private void caseStart(TestStartEvent evt, JvmTestOperationDescriptor op) {
-Testcase tc = new GradleTestcase(op, session);
-if (op.getSuiteName() == null) {
-// Sometimes it is possible to receive testcase execution events
-// without suite. It is common with TestNG
-TestSuite currentSuite = session.getCurrentSuite();
-if ((currentSuite == null) ||
!currentSuite.getName().equals(op.getClassName())) {
-TestSuite suite = new GradleTestSuite(op);
-session.addSuite(suite);
-CoreManager manager = getManager();
-if (manager != null) {
-manager.displaySuiteRunning(session, suite);
-}
+assert session != null;
+assert op.getParent() != null;
+TestSuite currentSuite = session.getCurrentSuite();
+TestSuite newSuite = new GradleTestSuite((JvmTestOperationDescriptor)
op.getParent());
+if ((currentSuite == null) || !currentSuite.equals(newSuite)) {
+session.addSuite(newSuite);
+CoreManager manager = getManager();
+if (manager != null) {
+manager.displaySuiteRunning(session, newSuite);
}
}
-
[netbeans] 08/12: [NETBEANS-2035] Enable Always show Gradle Build output by default.
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch release110
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit 8a8e4728ab2fe0b378f677f154c1eadd1c6ec1f5
Author: Laszlo Kishalmi
AuthorDate: Fri Apr 26 11:34:46 2019 -0700
[NETBEANS-2035] Enable Always show Gradle Build output by default.
---
groovy/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/groovy/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java
b/groovy/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java
index 20bb104..6a0102d 100644
--- a/groovy/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java
+++ b/groovy/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java
@@ -170,7 +170,7 @@ public final class GradleSettings {
}
public boolean isAlwaysShowOutput() {
-return getPreferences().getBoolean(PROP_ALWAYS_SHOW_OUTPUT, false);
+return getPreferences().getBoolean(PROP_ALWAYS_SHOW_OUTPUT, true);
}
public void setStartDaemonOnStart(boolean b) {
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 07/12: [NETBEANS-2399] Make sub Project node as a Tree based on the paths on the Gradle projects
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch release110
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit 192bd9909d3389a544c6679028e6661481958dce
Author: Laszlo Kishalmi
AuthorDate: Sat Apr 20 08:01:36 2019 -0700
[NETBEANS-2399] Make sub Project node as a Tree based on the paths on
the Gradle projects
---
.../modules/gradle/nodes/SubProjectsNode.java | 79 --
1 file changed, 58 insertions(+), 21 deletions(-)
diff --git
a/groovy/gradle/src/org/netbeans/modules/gradle/nodes/SubProjectsNode.java
b/groovy/gradle/src/org/netbeans/modules/gradle/nodes/SubProjectsNode.java
index 3b25ef5..0114cb0 100644
--- a/groovy/gradle/src/org/netbeans/modules/gradle/nodes/SubProjectsNode.java
+++ b/groovy/gradle/src/org/netbeans/modules/gradle/nodes/SubProjectsNode.java
@@ -30,6 +30,7 @@ import java.io.File;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collection;
+import java.util.HashSet;
import java.util.List;
import javax.swing.AbstractAction;
import javax.swing.Action;
@@ -53,6 +54,11 @@ import org.openide.util.WeakListeners;
import static org.netbeans.modules.gradle.nodes.Bundle.*;
import java.util.Map;
+import java.util.Set;
+import java.util.TreeSet;
+import org.netbeans.modules.gradle.spi.Utils;
+import org.openide.ErrorManager;
+import org.openide.nodes.Children;
/**
*
@@ -63,14 +69,23 @@ public class SubProjectsNode extends AbstractNode {
@StaticResource
private static final String SP_BADGE
= "org/netbeans/modules/gradle/resources/gradle-badge.png";
-private final NbGradleProjectImpl proj;
@NbBundle.Messages("LBL_SubProjects=Sub Projects")
+public SubProjectsNode(NbGradleProjectImpl proj, String path) {
+super(FilterNode.Children.create(new SubProjectsChildFactory(proj,
path), true));
+if (":".equals(path)) { //NOI18N
+setName("SubProjects"); //NOI18N
+setDisplayName(LBL_SubProjects());
+} else {
+int colon = path.lastIndexOf(':', path.length() - 2);
+String partName = path.substring(colon + 1, path.length() - 1);
+setDisplayName(Utils.capitalize(partName));
+setName(path);
+}
+}
+
public SubProjectsNode(NbGradleProjectImpl proj) {
-super(FilterNode.Children.create(new SubProjectsChildFactory(proj),
true));
-this.proj = proj;
-setName("SubProjects"); //NOI18N
-setDisplayName(LBL_SubProjects());
+this(proj, ":"); //NOI18N
}
@Override
@@ -78,7 +93,7 @@ public class SubProjectsNode extends AbstractNode {
return new Action[]{};
}
-private Image getIcon(boolean opened) {
+private static Image getIcon(boolean opened) {
Image badge = ImageUtilities.loadImage(SP_BADGE, true); //NOI18N
return ImageUtilities.mergeImages(NodeUtils.getTreeFolderIcon(opened),
badge, 8, 8);
}
@@ -93,13 +108,15 @@ public class SubProjectsNode extends AbstractNode {
return getIcon(true);
}
-private static class SubProjectsChildFactory extends
ChildFactory {
+private static class SubProjectsChildFactory extends ChildFactory {
private final NbGradleProjectImpl project;
private final PropertyChangeListener listener;
+private final String rootPath;
-SubProjectsChildFactory(NbGradleProjectImpl proj) {
+SubProjectsChildFactory(NbGradleProjectImpl proj, String rootPath) {
project = proj;
+this.rootPath = rootPath;
NbGradleProject watcher = project.getProjectWatcher();
listener = new PropertyChangeListener() {
@Override
@@ -115,34 +132,54 @@ public class SubProjectsNode extends AbstractNode {
}
@Override
-protected boolean createKeys(final List modules) {
+protected boolean createKeys(final List paths) {
Map subProjects =
project.getGradleProject().getBaseProject().getSubProjects();
+Set components = new TreeSet();
+Set projects = new TreeSet<>();
for (String path : subProjects.keySet()) {
-File projDir = subProjects.get(path);
-FileObject fo = FileUtil.toFileObject(projDir);
+if (path.startsWith(rootPath)) {
+String relPath = path.substring(rootPath.length());
+int firstColon = relPath.indexOf(':');
+int lastColon = relPath.lastIndexOf(':');
+if ((firstColon >= 0) && (firstColon == lastColon)) {
+components.add(path.substring(0, rootPath.length() +
firstColon + 1));
+}
+if (firstColon < 0 ) {
+projects.add(path);
+}
+}
+}
+
[netbeans] 04/12: [NETBEANS-2348] Added support for 'Test Package'.
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch release110
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit ab050e858d20ba6eb3f7567aab913eff41a12599
Author: Laszlo Kishalmi
AuthorDate: Sat Apr 6 10:55:46 2019 -0700
[NETBEANS-2348] Added support for 'Test Package'.
---
.../gradle/java/GradleJavaTokenProvider.java | 32 ++
.../modules/gradle/java/JavaActionProvider.java| 30 +---
.../modules/gradle/java/action-mapping.xml | 3 ++
.../modules/gradle/ActionProviderImpl.java | 19 +++--
.../gradle/execute/GradleDaemonExecutor.java | 4 +--
5 files changed, 62 insertions(+), 26 deletions(-)
diff --git
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
index d396a45..980c122 100644
---
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
+++
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
@@ -57,11 +57,12 @@ import org.openide.util.Lookup;
public class GradleJavaTokenProvider implements ReplaceTokenProvider {
private static final Set SUPPORTED =
Collections.unmodifiableSet(new HashSet(Arrays.asList(
-"selectedClass",
-"selectedMethod",
-"affectedBuildTasks"
+"selectedClass", //NOI18N
+"selectedMethod", //NOI18N
+"selectedPackage", //NOI18N
+"affectedBuildTasks" //NOI18N
)));
-
+
final Project project;
public GradleJavaTokenProvider(Project project) {
@@ -76,22 +77,29 @@ public class GradleJavaTokenProvider implements
ReplaceTokenProvider {
@Override
public Map createReplacements(String action, Lookup
context) {
Map ret = new HashMap<>();
-processSelectedClass(ret, context);
+processSelectedPackageAndClass(ret, context);
processSelectedMethod(ret, context);
processSourceSets(ret, context);
return ret;
}
-private void processSelectedClass(final Map map, Lookup
context) {
+private void processSelectedPackageAndClass(final Map map,
Lookup context) {
FileObject fo = RunUtils.extractFileObjectfromLookup(context);
GradleJavaProject gjp = GradleJavaProject.get(project);
if ((gjp != null) && (fo != null)) {
File f = FileUtil.toFile(fo);
GradleJavaSourceSet sourceSet = gjp.containingSourceSet(f);
-if (sourceSet != null) {
-String relPath = sourceSet.relativePath(f);
-String className = relPath.substring(0,
relPath.lastIndexOf('.')).replace('/', '.');
-map.put("selectedClass", className);
+if (sourceSet != null) {
+if (f.isFile()) {
+String relPath = sourceSet.relativePath(f);
+String className = (relPath.lastIndexOf('.') > 0 ?
+relPath.substring(0, relPath.lastIndexOf('.')) :
+relPath).replace('/', '.');
+map.put("selectedClass", className); //NOI18N
+f = f.getParentFile();
+}
+String pkg = sourceSet.relativePath(f).replace('/', '.');
+map.put("selectedPackage", pkg); //NOI18N
}
}
}
@@ -102,7 +110,7 @@ public class GradleJavaTokenProvider implements
ReplaceTokenProvider {
String methodName = method != null ? method.getMethodName() : null;
if (fo != null) {
String selectedMethod = evaluateSingleMethod(fo, methodName);
- map.put("selectedMethod", selectedMethod);
+ map.put("selectedMethod", selectedMethod); //NOI18N
}
}
@@ -125,7 +133,7 @@ public class GradleJavaTokenProvider implements
ReplaceTokenProvider {
for (String task : buildTasks) {
tasks.append(task).append(' ');
}
-map.put("affectedBuildTasks", tasks.toString());
+map.put("affectedBuildTasks", tasks.toString()); //NOI18N
}
}
diff --git
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
index 305c786..3add6f2 100644
---
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
+++
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
@@ -25,6 +25,7 @@ import org.netbeans.modules.gradle.java.api.GradleJavaProject;
import org.netbeans.modules.gradle.java.api.GradleJavaSourceSet;
import org.netbeans.modules.gradle.spi.actions.DefaultGradleActionsProvider;
import org.netbeans.modules.gradle.spi.actions.GradleActionsProvider;
[netbeans] 10/12: [NETBEANS-2560] Fixing revression that disables all major actions on a Java Project
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch release110
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit 8b3ae0d7224413166924f4cb2f5691c10c7903c5
Author: Laszlo Kishalmi
AuthorDate: Sun May 19 06:14:02 2019 -0700
[NETBEANS-2560] Fixing revression that disables all major actions on a Java
Project
---
.../src/org/netbeans/modules/gradle/java/JavaActionProvider.java | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
index 4aab8cb..7c680e5 100644
---
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
+++
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
@@ -27,6 +27,9 @@ import
org.netbeans.modules.gradle.spi.actions.DefaultGradleActionsProvider;
import org.netbeans.modules.gradle.spi.actions.GradleActionsProvider;
import static
org.netbeans.modules.gradle.java.api.GradleJavaSourceSet.SourceType.*;
import java.io.File;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
import static org.netbeans.spi.project.ActionProvider.*;
import static org.netbeans.api.java.project.JavaProjectConstants.*;
import org.netbeans.api.java.source.ClasspathInfo;
@@ -82,9 +85,9 @@ public class JavaActionProvider extends
DefaultGradleActionsProvider {
if (gbp.hasPlugins(GATLING_PLUGIN) &&
COMMAND_RUN_SINGLE.equals(action)) {
ret = fo.getNameExt().endsWith(SIMULATION_POSTFIX);
} else {
-ret = false;
GradleJavaProject gjp = GradleJavaProject.get(project);
if ( gjp != null ) {
+ret = false;
switch (action) {
case COMMAND_COMPILE_SINGLE:
FileBuiltQuery.Status status =
FileBuiltQuery.getStatus(fo);
@@ -119,6 +122,8 @@ public class JavaActionProvider extends
DefaultGradleActionsProvider {
ret = sourceSet != null &&
sourceSet.getSourceType(dir) != RESOURCES;
}
break;
+default:
+ret = true;
}
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 03/12: [NETBEANS-2378] Tighten the Groovy more to the Gralde plugin
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a commit to branch release110 in repository https://gitbox.apache.org/repos/asf/netbeans.git commit 9c96f216e71a29c935032cc03ef658ca3932bf52 Author: Laszlo Kishalmi AuthorDate: Tue Apr 9 06:38:06 2019 -0700 [NETBEANS-2378] Tighten the Groovy more to the Gralde plugin --- groovy/gradle/manifest.mf | 1 + 1 file changed, 1 insertion(+) diff --git a/groovy/gradle/manifest.mf b/groovy/gradle/manifest.mf index b80a5f9..fedf0d3 100644 --- a/groovy/gradle/manifest.mf +++ b/groovy/gradle/manifest.mf @@ -4,3 +4,4 @@ OpenIDE-Module: org.netbeans.modules.gradle OpenIDE-Module-Layer: org/netbeans/modules/gradle/layer.xml OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/gradle/Bundle.properties OpenIDE-Module-Specification-Version: 1.0.1 + - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch release110 updated (7079e88 -> 67a590c)
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a change to branch release110 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 7079e88 Add Jenkinsfile new 2e0f5ad Ensuring important DTDs are used locally when running java.completion… (#1206) new f6e0148 [NETBEANS-2346] Fixed index out of bound exception in GAV parsing. new 9c96f21 [NETBEANS-2378] Tighten the Groovy more to the Gralde plugin new ab050e8 [NETBEANS-2348] Added support for 'Test Package'. new c03c53a [NETBEANS-2348] Less intrustive support for Test Package. new 303ffe5 [NETBEANS-2293] Fix possible NPE on selected method detection. new 192bd99 [NETBEANS-2399] Make sub Project node as a Tree based on the paths on the Gradle projects new 8a8e472 [NETBEANS-2035] Enable Always show Gradle Build output by default. new 559a472 [NETBEANS-2527] Update TestSuites in a Gradle Test Run upon completion. new 8b3ae0d [NETBEANS-2560] Fixing revression that disables all major actions on a Java Project new 562a736 [NETBEANS-2288] Fixed Auxialiary properties to use 'netbeans.' prefix as other part of the plugin expects. new 67a590c Upgraded the patched modules and the readme with building instructions. The 12 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: README.md | 11 +++ groovy/gradle.java/manifest.mf | 2 +- .../gradle/java/GradleJavaTokenProvider.java | 92 -- .../modules/gradle/java/JavaActionProvider.java| 80 ++- .../modules/gradle/java/action-mapping.xml | 4 +- .../gradle/java/api/output/LocationOpener.java | 58 ++ groovy/gradle.test/manifest.mf | 2 +- .../gradle/test/GradleTestProgressListener.java| 52 ++-- .../modules/gradle/test/GradleTestSuite.java | 45 +-- groovy/gradle/manifest.mf | 3 +- .../gradle/GradleAuxiliaryPropertiesImpl.java | 16 +++- .../modules/gradle/api/GradleBaseProject.java | 2 +- .../modules/gradle/api/GradleConfiguration.java| 2 +- .../modules/gradle/api/GradleDependency.java | 15 +++- .../gradle/execute/GradleDaemonExecutor.java | 4 +- .../modules/gradle/nodes/ConfigurationsNode.java | 4 +- .../modules/gradle/nodes/SubProjectsNode.java | 79 ++- .../modules/gradle/spi/GradleSettings.java | 2 +- .../actions/ActionMappingPropertyReaderTest.java | 22 +++--- .../modules/gradle/api/GradleDepandencyTest.java | 78 ++ .../java/completion/CompletionTestBase.java| 20 + 21 files changed, 381 insertions(+), 212 deletions(-) create mode 100644 groovy/gradle/test/unit/src/org/netbeans/modules/gradle/api/GradleDepandencyTest.java - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 06/12: [NETBEANS-2293] Fix possible NPE on selected method detection.
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch release110
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit 303ffe5b5c1177079539fda06b9e97a2e0ab804c
Author: Laszlo Kishalmi
AuthorDate: Sat Apr 6 15:23:06 2019 -0700
[NETBEANS-2293] Fix possible NPE on selected method detection.
---
.../gradle/java/GradleJavaTokenProvider.java | 86 ++
.../modules/gradle/java/action-mapping.xml | 4 +-
.../gradle/java/api/output/LocationOpener.java | 58 +++
3 files changed, 52 insertions(+), 96 deletions(-)
diff --git
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
index 87018fb..8e79ed4 100644
---
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
+++
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
@@ -24,24 +24,13 @@ import org.netbeans.modules.gradle.api.execute.RunUtils;
import org.netbeans.modules.gradle.java.api.GradleJavaProject;
import org.netbeans.modules.gradle.java.api.GradleJavaSourceSet;
import org.netbeans.modules.gradle.spi.actions.ReplaceTokenProvider;
-import com.sun.source.tree.CompilationUnitTree;
-import com.sun.source.tree.Tree;
-import com.sun.source.util.Trees;
import java.io.File;
-import java.io.IOException;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
-import java.util.List;
import java.util.Map;
import java.util.Set;
-import javax.lang.model.element.Element;
-import javax.lang.model.element.ElementKind;
-import javax.lang.model.element.TypeElement;
-import org.netbeans.api.java.source.CompilationController;
-import org.netbeans.api.java.source.JavaSource;
-import org.netbeans.api.java.source.Task;
import org.netbeans.api.project.Project;
import org.netbeans.spi.project.ProjectServiceProvider;
import org.netbeans.spi.project.SingleMethod;
@@ -85,32 +74,20 @@ public class GradleJavaTokenProvider implements
ReplaceTokenProvider {
private void processSelectedPackageAndClass(final Map map,
Lookup context) {
FileObject fo = RunUtils.extractFileObjectfromLookup(context);
GradleJavaProject gjp = GradleJavaProject.get(project);
-if ((gjp != null) && (fo != null)) {
-File f = FileUtil.toFile(fo);
-GradleJavaSourceSet sourceSet = gjp.containingSourceSet(f);
-if (sourceSet != null) {
-if (f.isFile()) {
-String relPath = sourceSet.relativePath(f);
-String className = (relPath.lastIndexOf('.') > 0 ?
-relPath.substring(0, relPath.lastIndexOf('.')) :
-relPath).replace('/', '.');
-map.put("selectedClass", className); //NOI18N
-f = f.getParentFile();
-} else {
-String pkg = sourceSet.relativePath(f).replace('/', '.');
-map.put("selectedClass", pkg + "*"); //NOI18N
-}
-}
+String className = evaluateClassName(gjp, fo);
+if (className != null) {
+map.put("selectedClass", className);
}
}
-private static void processSelectedMethod(final Map map,
Lookup context) {
+private void processSelectedMethod(final Map map, Lookup
context) {
SingleMethod method = context.lookup(SingleMethod.class);
FileObject fo = method != null ? method.getFile() :
RunUtils.extractFileObjectfromLookup(context);
-String methodName = method != null ? method.getMethodName() : null;
-if (fo != null) {
- String selectedMethod = evaluateSingleMethod(fo, methodName);
- map.put("selectedMethod", selectedMethod); //NOI18N
+if ((fo != null) && fo.isData()) {
+GradleJavaProject gjp = GradleJavaProject.get(project);
+String className = evaluateClassName(gjp, fo);
+String selectedMethod = method != null ? className + '.' +
method.getMethodName() : className;
+map.put("selectedMethod", selectedMethod);
}
}
@@ -137,37 +114,22 @@ public class GradleJavaTokenProvider implements
ReplaceTokenProvider {
}
}
-private static String evaluateSingleMethod(final FileObject fo, final
String method) {
-final Object[] ret = new Object[1];
-JavaSource javaSource = JavaSource.forFileObject(fo);
-if (javaSource != null) {
-try {
-javaSource.runUserActionTask(new Task()
{
-@Override
-public void run(CompilationController
compilationController) throws Exception {
-
compilationController.toPhase(JavaSource.Phase.ELEMENTS_RESOLVED);
-
[jira] [Closed] (NETBEANS-2527) Junit test results when run via gradle are incomplete.
[ https://issues.apache.org/jira/browse/NETBEANS-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Flacy closed NETBEANS-2527. Thank you for working on this. All test results have shown up on both my home Linux system and my work OSX system after I applied the update. > Junit test results when run via gradle are incomplete. > -- > > Key: NETBEANS-2527 > URL: https://issues.apache.org/jira/browse/NETBEANS-2527 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 11.0 > Environment: Product Version: Apache NetBeans IDE 11.0 (Build > incubator-netbeans-release-404-on-20190319) > Java: 11.0.2; OpenJDK 64-Bit Server VM 11.0.2+9 > Runtime: OpenJDK Runtime Environment 11.0.2+9 > System: Mac OS X version 10.14.4 running on x86_64; UTF-8; en_US (nb) > Product Version: Apache NetBeans IDE 11.0 (Build > incubator-netbeans-release-404-on-20190319) > Java: 11.0.1; OpenJDK 64-Bit Server VM 11.0.1+13 > Runtime: OpenJDK Runtime Environment 11.0.1+13 > System: Linux version 4.4.172 running on amd64; UTF-8; en_US (nb) >Reporter: Mark Flacy >Assignee: Laszlo Kishalmi >Priority: Major > Labels: 11.0-gradle-patch-1, pull-request-available > Fix For: Next > > Attachments: Gradle_false_positive.png, Maven_true_failures.png > > Time Spent: 20m > Remaining Estimate: 0h > > When running the test task, the Gradle Test Run window shows ONLY ONE test > file result. All other test results are invisible. > > I have a simple project at github that shows the behavior. > [https://github.com/Richard-Cranium/NB11GradleJunitExample] > The head of the master branch is the gradle based project that shows the > misleading behavior. > The head of the maven-version branch has the same source files, but > configured to use maven instead. > The maven project's behavior when _Run -> Test Project_ is selected is what I > would expect from the gradle project's behavior when _Run -> Test Project_ is > selected against it. See the attached images. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2371) Gradle projects not properly loaded
[ https://issues.apache.org/jira/browse/NETBEANS-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847206#comment-16847206 ] Lou Hamersly commented on NETBEANS-2371: The recent 1.0.1 patch did fix a worse issue I posted the other day, but I think I'm seeing the same issue as Shevek here with the same repo: [https://github.com/jMonkeyEngine/jmonkeyengine] I've been able to reproduce it here (on Linux) like this: * Load root project and all subprojects (close jme3-android-examples, I think this error can be ignored as unrelated) * There may be a few flagged red immediately; opening any file (I don't even need to build or edit/save) makes the flag vanish * Do a "gradle clean" from the project root * Wait a bit, red flags start popping up. A build on the subproject tends to remove the flag. * Open up one of the red flagged files. If there aren't missing import errors, I've seen this pretty reliably (post 1.0.1 patch) cause the "fake" error flag to vanish a second or two later. * Sometimes I'll need to do a manual clean/build inside NetBeans to resolve missing import errors, seems to be after a gradle clean from command line. Jumping around between those steps, at least on my system, I can get these fake error flags to appear fairly reliably in at least one of the subprojects. Not sure if the "errors" after a command line build and clean can be helped, but maybe it'll help you track down a way to get NB to clear the flags on its own. > Gradle projects not properly loaded > --- > > Key: NETBEANS-2371 > URL: https://issues.apache.org/jira/browse/NETBEANS-2371 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 11.0 > Environment: Netbeans 11 > Gradle 5 > Java 11 >Reporter: Netbeans User 2019 >Assignee: Laszlo Kishalmi >Priority: Major > Attachments: org-netbeans-modules-gradle-java.nbm > > > - gradle module (plugin) has problem to resolve dependencies in multi project > as seems I can removed reds only if I go over each one subproject and do > clean and build (clean and build on root has no affects) and additionally it > seems that for some test resources even this was not enough, but it seems > that works old trick so creation folder and adding some new class (possible > even delete) and possibly with including "refresh" from Action items window. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-2561) Gradle sub-projects report missing packages, but successful builds
[ https://issues.apache.org/jira/browse/NETBEANS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lou Hamersly resolved NETBEANS-2561. Resolution: Fixed The recent Gradle/Groovy 1.0.1 patch resolved this with the exception of an error in the android examples subproject, which seems to have unrelated issues. > Gradle sub-projects report missing packages, but successful builds > -- > > Key: NETBEANS-2561 > URL: https://issues.apache.org/jira/browse/NETBEANS-2561 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 11.0 > Environment: Linux / Windows >Reporter: Lou Hamersly >Priority: Major > Attachments: jme3-2.png, jme3.png > > > NetBeans 11 (w/Gradle integration) is reporting missing imports when loading > an open source project. > I'm fairly sure it's just an issue with the new Groovy/Gradle plugin, having > tried different configurations listed below. Also the Gradle build works fine > from the command line, including running examples. A few others have seen the > same problem and I've repeated it on two machines, so it's definitely not > some localized issue. > Configurations tested so far: > NetBeans 10 OpenJDK 8 Gradle 4.10.2 (using old Gradle plugin) - Success > NetBeans 10 OpenJDK 11 Gradle 4.10.2 (using old Gradle plugin) - Success* > NetBeans 11 OpenJDK 11 Gradle 4.10.2 - Errors reported (see screencap)* > NetBeans 11 OpenJDK 12 Gradle 4.10.2 - Errors reported (see screencap) > *Javadoc crash in one project due to apparent bug in JDK 9-11 but not a NB > issue > With a "Clean and Build Project" (on the root or subprojects), Gradle output > _reports_ build success, but NB still doesn't see the missing project > dependencies. Using the "run" task on the examples project also works (right > click jme3-examples sub-project->Run Gradle->Tasks->run), despite essential > packages being reported missing. > Unfortunately I haven't yet been able to create a minimal project to > reproduce the issues, but it should be fairly easy to reproduce by opening > the root project and all subprojects in NB 11. > [https://github.com/jMonkeyEngine/jmonkeyengine] > I'm willing to try tracking down what's going on here, but might need some > advice on a good method for doing so. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2593) What's an LSP module that I have a NullPointerException in it?
Shevek created NETBEANS-2593: Summary: What's an LSP module that I have a NullPointerException in it? Key: NETBEANS-2593 URL: https://issues.apache.org/jira/browse/NETBEANS-2593 Project: NetBeans Issue Type: Bug Affects Versions: 11.0 Reporter: Shevek SEVERE [org.openide.util.RequestProcessor]: Error in RequestProcessor org.netbeans.modules.lsp.client.LSPBindings$Cleanup java.lang.NullPointerException at org.netbeans.modules.lsp.client.LSPBindings$Cleanup.run(LSPBindings.java:243) at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) [catch] at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans-mavenutils-nb-repository-plugin] branch master updated: Use last released parent
This is an automated email from the ASF dual-hosted git repository. skygo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans-mavenutils-nb-repository-plugin.git The following commit(s) were added to refs/heads/master by this push: new 0826900 Use last released parent 0826900 is described below commit 0826900a389bad605fe83e89b6e3117f1bca4d16 Author: Eric Barboni AuthorDate: Thu May 23 21:06:24 2019 +0200 Use last released parent --- pom.xml | 2 +- src/site/site.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 8c6bacb..0850013 100644 --- a/pom.xml +++ b/pom.xml @@ -23,7 +23,7 @@ under the License. org.apache.netbeans.utilities utilities-parent -1-SNAPSHOT +1 4.0.0 diff --git a/src/site/site.xml b/src/site/site.xml index ac604db..3965618 100644 --- a/src/site/site.xml +++ b/src/site/site.xml @@ -17,7 +17,7 @@ under the License. --> http://maven.apache.org/DECORATION/1.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/DECORATION/1.0.0 http://maven.apache.org/xsd/decoration-1.0.0.xsd;> -org.apache.netbeans +org.apache.netbeans.utilities maven-netbeans-skin 1.0-SNAPSHOT - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans-mavenutils-nbm-maven-plugin] branch master updated: Use last released parent
This is an automated email from the ASF dual-hosted git repository. skygo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans-mavenutils-nbm-maven-plugin.git The following commit(s) were added to refs/heads/master by this push: new a9b9fe2 Use last released parent a9b9fe2 is described below commit a9b9fe2de8f82bbf6d71b92a557e4afc7b2ec055 Author: Eric Barboni AuthorDate: Thu May 23 21:03:33 2019 +0200 Use last released parent --- pom.xml | 2 +- src/site/site.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index aa46964..e13edea 100644 --- a/pom.xml +++ b/pom.xml @@ -23,7 +23,7 @@ under the License. org.apache.netbeans.utilities utilities-parent -1-SNAPSHOT +1 4.0.0 diff --git a/src/site/site.xml b/src/site/site.xml index 5beda36..ca5d8b0 100644 --- a/src/site/site.xml +++ b/src/site/site.xml @@ -17,7 +17,7 @@ under the License. --> http://maven.apache.org/DECORATION/1.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/DECORATION/1.0.0 http://maven.apache.org/xsd/decoration-1.0.0.xsd;> -org.netbeans.maven +org.apache.netbeans.utilities maven-netbeans-skin 1.0-SNAPSHOT - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] annotated tag 11.0-gradle-patch-1 updated (609a703 -> 5d45c69)
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a change to annotated tag 11.0-gradle-patch-1 in repository https://gitbox.apache.org/repos/asf/netbeans.git. *** WARNING: tag 11.0-gradle-patch-1 was modified! *** from 609a703 (commit) to 5d45c69 (tag) tagging 609a7039f5f3b27dc8951cbd90e9c5754e1b8e2a (commit) replaces 11.0 by Laszlo Kishalmi on Thu May 23 12:02:52 2019 -0700 - Log - NetBeans 11.0-gradle-patch-1 --- No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans-mavenutils-nbm-maven-harness] branch master updated: Use last released parent
This is an automated email from the ASF dual-hosted git repository. skygo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans-mavenutils-nbm-maven-harness.git The following commit(s) were added to refs/heads/master by this push: new 36ce59d Use last released parent 36ce59d is described below commit 36ce59df7d18fcca63a26c00da230945f19827d7 Author: Eric Barboni AuthorDate: Thu May 23 20:59:09 2019 +0200 Use last released parent --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 84f49b8..7911a6e 100644 --- a/pom.xml +++ b/pom.xml @@ -24,7 +24,7 @@ under the License. org.apache.netbeans.utilities utilities-parent -1-SNAPSHOT +1 nbm-maven-harness 11.0-SNAPSHOT - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans-mavenutils-nbm-shared] branch master updated: Use last released parent
This is an automated email from the ASF dual-hosted git repository. skygo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans-mavenutils-nbm-shared.git The following commit(s) were added to refs/heads/master by this push: new f2b8cd9 Use last released parent f2b8cd9 is described below commit f2b8cd9f25c76dd3026bf5ab0af783ab3553e61a Author: Eric Barboni AuthorDate: Thu May 23 20:56:04 2019 +0200 Use last released parent --- pom.xml | 2 +- src/site/site.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index a9d528c..a38098c 100644 --- a/pom.xml +++ b/pom.xml @@ -23,7 +23,7 @@ under the License. org.apache.netbeans.utilities utilities-parent -1-SNAPSHOT +1 4.0.0 diff --git a/src/site/site.xml b/src/site/site.xml index b254c53..d936135 100644 --- a/src/site/site.xml +++ b/src/site/site.xml @@ -17,7 +17,7 @@ under the License. --> http://maven.apache.org/DECORATION/1.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/DECORATION/1.0.0 http://maven.apache.org/xsd/decoration-1.0.0.xsd;> -org.apache.netbeans +org.apache.netbeans.utilities maven-netbeans-skin 1.0-SNAPSHOT - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans-webskin] branch master updated: Use last released parent
This is an automated email from the ASF dual-hosted git repository. skygo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans-webskin.git The following commit(s) were added to refs/heads/master by this push: new a3f91a2 Use last released parent a3f91a2 is described below commit a3f91a20dfc5991c87a1b6102a7631f708955fec Author: Eric Barboni AuthorDate: Thu May 23 20:55:20 2019 +0200 Use last released parent --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 850fb84..985da81 100644 --- a/pom.xml +++ b/pom.xml @@ -1,7 +1,7 @@ http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> -org.apache.netbeans +org.apache.netbeans.utilities utilities-parent 1 - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2592) Netbeans11 complies simple program but errors on RUN
Don Pearson created NETBEANS-2592: - Summary: Netbeans11 complies simple program but errors on RUN Key: NETBEANS-2592 URL: https://issues.apache.org/jira/browse/NETBEANS-2592 Project: NetBeans Issue Type: Bug Components: cnd - Execution Affects Versions: 11.0 Environment: windows 7, 64 bit. Reporter: Don Pearson Attachments: Data.txt, Exception.txt, source.txt Program works well in NB9. Using JDK1.8 Problem not related to importing Ptolemy packages (can comment those out and still get the same error). Have not yet stepped up to modules, but shouldn;'t need to with JDK1.8. Bug detected by NB11: java.lang.NullPointerException at org.netbeans.modules.java.api.common.project.ActionProviderSupport.invokeByJavaSource(ActionProviderSupport.java:915) at org.netbeans.modules.java.api.common.project.ActionProviderSupport.invokeTarget(ActionProviderSupport.java:207) at org.netbeans.modules.java.api.common.project.JavaActionProvider$ScriptAction.invoke(JavaActionProvider.java:465) at org.netbeans.modules.java.api.common.project.JavaActionProvider.lambda$invokeAction$1(JavaActionProvider.java:895) at java.util.Optional.ifPresent(Optional.java:159) at org.netbeans.modules.java.api.common.project.JavaActionProvider.invokeAction(JavaActionProvider.java:888) at org.netbeans.modules.java.api.common.project.BaseActionProvider.invokeAction(BaseActionProvider.java:225) at org.netbeans.modules.java.j2seproject.J2SEActionProvider.lambda$invokeAction$0(J2SEActionProvider.java:292) at org.netbeans.modules.java.j2seproject.J2SEActionProvider.invokeAction(J2SEActionProvider.java:337) at org.netbeans.spi.project.support.LookupProviderSupport$MergedActionProvider.invokeAction(LookupProviderSupport.java:262) at org.netbeans.modules.project.ui.actions.ProjectAction$2.run(ProjectAction.java:162) at org.netbeans.modules.openide.util.NbMutexEventProvider$Event.doEvent(NbMutexEventProvider.java:95) at org.netbeans.modules.openide.util.NbMutexEventProvider$Event.writeAccess(NbMutexEventProvider.java:60) at org.netbeans.modules.openide.util.LazyMutexImplementation.writeAccess(LazyMutexImplementation.java:56) at org.openide.util.Mutex.writeAccess(Mutex.java:285) at org.netbeans.modules.project.ui.actions.ProjectAction.runSequentially(ProjectAction.java:159) at org.netbeans.modules.project.ui.actions.MainProjectAction$1$1.run(MainProjectAction.java:115) at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758) at java.awt.EventQueue.access$500(EventQueue.java:97) at java.awt.EventQueue$3.run(EventQueue.java:709) at java.awt.EventQueue$3.run(EventQueue.java:703) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74) at java.awt.EventQueue.dispatchEvent(EventQueue.java:728) at org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:136) [catch] at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) at java.awt.EventDispatchThread.run(EventDispatchThread.java:82) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
svn commit: r34196 - /dev/netbeans/netbeans-maven-utilities/utilities-parent/utilities-parent-1/ /release/netbeans/netbeans-maven-utilities/ /release/netbeans/netbeans-maven-utilities/utilities-parent
Author: skygo Date: Thu May 23 17:25:44 2019 New Revision: 34196 Log: release of Apache Netbeans mavenutilies parent 1 Added: release/netbeans/netbeans-maven-utilities/ release/netbeans/netbeans-maven-utilities/utilities-parent/ release/netbeans/netbeans-maven-utilities/utilities-parent/utilities-parent-1/ release/netbeans/netbeans-maven-utilities/utilities-parent/utilities-parent-1/utilities-parent-1-source-release.zip - copied unchanged from r34195, dev/netbeans/netbeans-maven-utilities/utilities-parent/utilities-parent-1/take2/utilities-parent-1-source-release.zip release/netbeans/netbeans-maven-utilities/utilities-parent/utilities-parent-1/utilities-parent-1-source-release.zip.asc - copied unchanged from r34195, dev/netbeans/netbeans-maven-utilities/utilities-parent/utilities-parent-1/take2/utilities-parent-1-source-release.zip.asc release/netbeans/netbeans-maven-utilities/utilities-parent/utilities-parent-1/utilities-parent-1-source-release.zip.sha512 - copied unchanged from r34195, dev/netbeans/netbeans-maven-utilities/utilities-parent/utilities-parent-1/take2/utilities-parent-1-source-release.zip.sha512 Removed: dev/netbeans/netbeans-maven-utilities/utilities-parent/utilities-parent-1/ - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2573) PHPUNIT update breaks running single test
[
https://issues.apache.org/jira/browse/NETBEANS-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846861#comment-16846861
]
Alan Langford commented on NETBEANS-2573:
-
{quote}What I can say now is that I really don't get why PHPUnit does this.
What problem/situation are they solving by these changes?
{quote}
The commit comment from their repo is "Fixed a fatal TypeError when an invalid
file is given as the second argument". The change to PHPUnit is simply making
command line parsing more robust. A perfectly reasonable thing to do IMO. There
is no --run=... argument, and I'm pretty sure they're not going to be open to
adding some kind of argument pass-through mechanism.That said, their parser
does ignore additional arguments. I have a command line that gets through:
{code:java}
php.exe "{project_path}\vendor\phpunit\phpunit\phpunit" "--colors"
"--log-junit" "{temp}\nb-phpunit-log.xml" "--configuration"
"{project_path}\phpunit.xml" "--coverage-clover"
"{temp}\nb-phpunit-coverage.xml" "NetBeansSuite" "C:\Program Files\netbeans
11\php\phpunit\NetBeansSuite.php" "{project_path}\tests\SomeTest.php"
{code}
That adds "NetBeansSuite" as the explicit test name and removes the --run=
prefix on the file to be testedThis just requires that NetBeansTest.php extract
the last entry from $argv instead of looking for something prefixed by --run=
I still think generating a XML file by transforming the user's file is less
brittle. It puts all the logic inside Netbeans and keeps us form having to
track breaking changes in PHPUnit (like this, from the current
NetBeansTest.php):
{code:java}
// keep BC with PHPUnit versions < 6
if (!class_exists('PHPUnit_Framework_TestSuite')) {
class PHPUnit_Framework_TestSuite extends PHPUnit\Framework\TestSuite {}
}
{code}
> PHPUNIT update breaks running single test
> -
>
> Key: NETBEANS-2573
> URL: https://issues.apache.org/jira/browse/NETBEANS-2573
> Project: NetBeans
> Issue Type: Bug
> Components: php - PHPUnit
>Affects Versions: 11.0
> Environment: Netbeans 11.0, PHP 7.3
>Reporter: Alan Langford
>Assignee: Tomáš Myšík
>Priority: Major
>
> When running a single test file and PHPUnit installed via composer, Netbeans
> generates a command line of this general form:
> php.exe "\{project}\vendor\phpunit\phpunit\phpunit" "--colors" "log-junit"
> "\{temp}\nb-phpunit-log.xml" "configuration" "\{project}\phpunit.xml"
> "coverage-clover" "\{temp}\nb-phpunit-coverage.xml" "C:\Program
> Files\netbeans 11\php\phpunit\NetBeansSuite.php" "--"
> "–run=\{project}\tests\SomeTest.php"
> The "–" argument used to fool PHPUnit. PHPUnit would strip the dashes and
> pass a empty string for the name of the test file.
> NetBeansSuite.php would then extract the --run=argument and run the test.
> The latest master for PHPUnit (a79e18fe27) has changed the way command lines
> are parsed; the "–" is discarded. PHPUnit then reports an error:
> Cannot open file "–run=\{project}\tests\SomeTest.php"
> I believe passing
> NetBeansSuite "C:\Program Files\netbeans 11\php\phpunit\NetBeansSuite.php"
> instead of
> "C:\Program Files\netbeans 11\php\phpunit\NetBeansSuite.php" "–"
> Will resolve the problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2573) PHPUNIT update breaks running single test
[
https://issues.apache.org/jira/browse/NETBEANS-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846821#comment-16846821
]
Czukowski commented on NETBEANS-2573:
-
[~tmysik] in the past I've browsed some PHPUnit issues created by other people,
how the developers responded to them, and I concluded that the main developer
just isn't a people person and isn't very open to the outside ideas
(disclaimer: just my opinion and might be totally untrue). Still I don't think
there is a point in holding grudges because of that. In time I just came to
accept that if I had any issue with PHPUnit, I'd be basically on my own to
solve it somehow. So it's just one of those areas where communication doesn't
take you very far :)
As for the subject of temporary XML config, you are right, there would need to
be some well-thought merging logic. This makes the solution non-trivial, but
I'm afraid that XML configs are now the only reliable way of configuring a
PHPUnit runner (for instance, it is the only way that I know of to configure
code coverage I mentioned above, so the plugin integration is not working at
the moment).
There is also a hack I've mentioned above (about 2 days ago) that could perhaps
serve as a temporary fix and buy some time needed for bigger changes.
> PHPUNIT update breaks running single test
> -
>
> Key: NETBEANS-2573
> URL: https://issues.apache.org/jira/browse/NETBEANS-2573
> Project: NetBeans
> Issue Type: Bug
> Components: php - PHPUnit
>Affects Versions: 11.0
> Environment: Netbeans 11.0, PHP 7.3
>Reporter: Alan Langford
>Assignee: Tomáš Myšík
>Priority: Major
>
> When running a single test file and PHPUnit installed via composer, Netbeans
> generates a command line of this general form:
> php.exe "\{project}\vendor\phpunit\phpunit\phpunit" "--colors" "log-junit"
> "\{temp}\nb-phpunit-log.xml" "configuration" "\{project}\phpunit.xml"
> "coverage-clover" "\{temp}\nb-phpunit-coverage.xml" "C:\Program
> Files\netbeans 11\php\phpunit\NetBeansSuite.php" "--"
> "–run=\{project}\tests\SomeTest.php"
> The "–" argument used to fool PHPUnit. PHPUnit would strip the dashes and
> pass a empty string for the name of the test file.
> NetBeansSuite.php would then extract the --run=argument and run the test.
> The latest master for PHPUnit (a79e18fe27) has changed the way command lines
> are parsed; the "–" is discarded. PHPUnit then reports an error:
> Cannot open file "–run=\{project}\tests\SomeTest.php"
> I believe passing
> NetBeansSuite "C:\Program Files\netbeans 11\php\phpunit\NetBeansSuite.php"
> instead of
> "C:\Program Files\netbeans 11\php\phpunit\NetBeansSuite.php" "–"
> Will resolve the problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2573) PHPUNIT update breaks running single test
[
https://issues.apache.org/jira/browse/NETBEANS-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846786#comment-16846786
]
Tomáš Myšík commented on NETBEANS-2573:
---
I did not look into it yet but please note that the user can set her own
`phpunit.xml` (in the Project Properties dialog). In such a case, I am not sure
we can solve this situation. I strongly prefer using CLI since it is siply
flexible.
What I can say now is that I really don't get why PHPUnit does this. What
problem/situation are they solving by these changes? I don't know. But as I
wrote, this is definitely not the first time.
> to suggest PHPStorm
That is simply... hmm, not smart, IMHO. It is the same as I would say "don't
use PHPUnit, use another testing framework". Simply stupid.
> PHPUNIT update breaks running single test
> -
>
> Key: NETBEANS-2573
> URL: https://issues.apache.org/jira/browse/NETBEANS-2573
> Project: NetBeans
> Issue Type: Bug
> Components: php - PHPUnit
>Affects Versions: 11.0
> Environment: Netbeans 11.0, PHP 7.3
>Reporter: Alan Langford
>Assignee: Tomáš Myšík
>Priority: Major
>
> When running a single test file and PHPUnit installed via composer, Netbeans
> generates a command line of this general form:
> php.exe "\{project}\vendor\phpunit\phpunit\phpunit" "--colors" "log-junit"
> "\{temp}\nb-phpunit-log.xml" "configuration" "\{project}\phpunit.xml"
> "coverage-clover" "\{temp}\nb-phpunit-coverage.xml" "C:\Program
> Files\netbeans 11\php\phpunit\NetBeansSuite.php" "--"
> "–run=\{project}\tests\SomeTest.php"
> The "–" argument used to fool PHPUnit. PHPUnit would strip the dashes and
> pass a empty string for the name of the test file.
> NetBeansSuite.php would then extract the --run=argument and run the test.
> The latest master for PHPUnit (a79e18fe27) has changed the way command lines
> are parsed; the "–" is discarded. PHPUnit then reports an error:
> Cannot open file "–run=\{project}\tests\SomeTest.php"
> I believe passing
> NetBeansSuite "C:\Program Files\netbeans 11\php\phpunit\NetBeansSuite.php"
> instead of
> "C:\Program Files\netbeans 11\php\phpunit\NetBeansSuite.php" "–"
> Will resolve the problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2573) PHPUNIT update breaks running single test
[
https://issues.apache.org/jira/browse/NETBEANS-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846761#comment-16846761
]
Czukowski commented on NETBEANS-2573:
-
I also think temporary XML file would be the preferred solution. It will open a
way to solve other issues with PHPUnit, not related directly to this one (I'm
talking mainly about collecting code coverage that must be set up using the XML
config).
> PHPUNIT update breaks running single test
> -
>
> Key: NETBEANS-2573
> URL: https://issues.apache.org/jira/browse/NETBEANS-2573
> Project: NetBeans
> Issue Type: Bug
> Components: php - PHPUnit
>Affects Versions: 11.0
> Environment: Netbeans 11.0, PHP 7.3
>Reporter: Alan Langford
>Assignee: Tomáš Myšík
>Priority: Major
>
> When running a single test file and PHPUnit installed via composer, Netbeans
> generates a command line of this general form:
> php.exe "\{project}\vendor\phpunit\phpunit\phpunit" "--colors" "log-junit"
> "\{temp}\nb-phpunit-log.xml" "configuration" "\{project}\phpunit.xml"
> "coverage-clover" "\{temp}\nb-phpunit-coverage.xml" "C:\Program
> Files\netbeans 11\php\phpunit\NetBeansSuite.php" "--"
> "–run=\{project}\tests\SomeTest.php"
> The "–" argument used to fool PHPUnit. PHPUnit would strip the dashes and
> pass a empty string for the name of the test file.
> NetBeansSuite.php would then extract the --run=argument and run the test.
> The latest master for PHPUnit (a79e18fe27) has changed the way command lines
> are parsed; the "–" is discarded. PHPUnit then reports an error:
> Cannot open file "–run=\{project}\tests\SomeTest.php"
> I believe passing
> NetBeansSuite "C:\Program Files\netbeans 11\php\phpunit\NetBeansSuite.php"
> instead of
> "C:\Program Files\netbeans 11\php\phpunit\NetBeansSuite.php" "–"
> Will resolve the problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
svn commit: r34163 - in /release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms: ./ groovy/
Author: lkishalmi Date: Thu May 23 14:07:32 2019 New Revision: 34163 Log: Releasing Apache NetBeans 11.0 Gradle Patch 1 Added: release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/groovy/org-netbeans-modules-gradle-java.nbm - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/groovy/org-netbeans-modules-gradle-java.nbm release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/groovy/org-netbeans-modules-gradle-java.nbm.asc - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/groovy/org-netbeans-modules-gradle-java.nbm.asc release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/groovy/org-netbeans-modules-gradle-java.nbm.sha512 - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/groovy/org-netbeans-modules-gradle-java.nbm.sha512 release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/groovy/org-netbeans-modules-gradle-test.nbm - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/groovy/org-netbeans-modules-gradle-test.nbm release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/groovy/org-netbeans-modules-gradle-test.nbm.asc - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/groovy/org-netbeans-modules-gradle-test.nbm.asc release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/groovy/org-netbeans-modules-gradle-test.nbm.sha512 - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/groovy/org-netbeans-modules-gradle-test.nbm.sha512 release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/groovy/org-netbeans-modules-gradle.nbm - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/groovy/org-netbeans-modules-gradle.nbm release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/groovy/org-netbeans-modules-gradle.nbm.asc - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/groovy/org-netbeans-modules-gradle.nbm.asc release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/groovy/org-netbeans-modules-gradle.nbm.sha512 - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/groovy/org-netbeans-modules-gradle.nbm.sha512 release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/updates.xml.gz - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/updates.xml.gz release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/updates.xml.gz.asc - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/updates.xml.gz.asc release/incubator/netbeans/incubating-netbeans/incubating-11.0/nbms/updates.xml.gz.sha512 - copied unchanged from r34107, dev/netbeans/netbeans/11.0-gradle-patch-1/nbms/updates.xml.gz.sha512 - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
svn commit: r34163 - /dev/netbeans/netbeans/ /release/netbeans/netbeans/ /release/netbeans/netbeans/11.0-gradle-patch-1/nbms/
Author: lkishalmi Date: Thu May 23 14:07:32 2019 New Revision: 34163 Log: Releasing Apache NetBeans 11.0 Gradle Patch 1 Added: release/netbeans/netbeans/ - copied from r34162, dev/netbeans/netbeans/ Removed: dev/netbeans/netbeans/ release/netbeans/netbeans/11.0-gradle-patch-1/nbms/ - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2591) Tasks windows causes high CPU usage
Filippo created NETBEANS-2591: - Summary: Tasks windows causes high CPU usage Key: NETBEANS-2591 URL: https://issues.apache.org/jira/browse/NETBEANS-2591 Project: NetBeans Issue Type: Bug Affects Versions: 8.2 Environment: Windows 7 Enterprise Reporter: Filippo NetBeans Tasks window, even if not open (and never opened before), occasionally causes 100% (on a single core) usage, heavily affecting responsiveness on dual-core systems. Opening the Tasks window using CTRL+SHIFT+6 and then closing it seems to temporarily solve the problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1997) JaCoCo 0.8.2 breaks code coverage integration
[ https://issues.apache.org/jira/browse/NETBEANS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846590#comment-16846590 ] Mark Herkrath commented on NETBEANS-1997: - It got broken due to NETBEANS-1768 (NB 11). Will discuss at the mailing list how to proceed. > JaCoCo 0.8.2 breaks code coverage integration > - > > Key: NETBEANS-1997 > URL: https://issues.apache.org/jira/browse/NETBEANS-1997 > Project: NetBeans > Issue Type: Bug >Reporter: Philip Durbin >Assignee: John McDonnell >Priority: Minor > > I asked, "Does JaCoCo 0.8.2 break NetBeans code coverage?" on the users > mailing list: > [https://lists.apache.org/thread.html/509bfddb9273726a6e8dff1ca419790b40858d6a648b4413142e2abe@%3Cusers.netbeans.apache.org%3E] > Geertjan Wielenga said to go ahead and open an issue so I believe he agrees > that it does. > The main evidence seems to be in > [https://github.com/jacoco/jacoco/issues/772] where a JaCoCo developer, > Evgeny Mandrikov, said the following. > "AFAIK NetBeans integration reads XML Report, which was intentionally changed > in version 0.8.2 in a perfectly valid way by addition of new attribute - see > https://github.com/jacoco/jacoco/pull/702. NetBeans integration must be fixed > accordingly and ideally be less strict to cope with such updates in future. > This problem should reported to developers of NetBeans integration, since it > is not developed by us - as you can see on page > [https://www.jacoco.org/jacoco/trunk/doc/integrations.html] " > My workaround was to downgrade to JaCoCo 0.8.1, as I explained in > [https://github.com/IQSS/dataverse/issues/5483] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-1997) JaCoCo 0.8.2 breaks code coverage integration
[
https://issues.apache.org/jira/browse/NETBEANS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846066#comment-16846066
]
Mark Herkrath edited comment on NETBEANS-1997 at 5/23/19 7:52 AM:
--
Correction: I got NetBeans 11 and JaCoCo 0.8.2 to work now. However as stated
before, after "Run All Tests" was being clicked, the Report windows has to be
closed and re-opened after Maven is done.
This was working before. I have set the logger of
org.netbeans.modules.maven.coverage.MavenCoverageProvider to 100. The trace is
showing that the wrong file is being watched via FileChangeAdapter initially.
{{FINE [org.netbeans.modules.maven.coverage.MavenCoverageProvider]: missing
C:\Program Files\NetBeans 11.0\bin\jacoco.xml}}
If I get some time, I might take a closer look.
was (Author: herkrath):
Correction: I got NetBeans 11 and JaCoCo 0.8.2 to work now. However as stated
before, after "Run All Tests" was being clicked, the Report windows has to be
closed and re-opened after Maven is done.
This was working before. I have set the logger of
org.netbeans.modules.maven.coverage.MavenCoverageProvider to 100. The trace to
showing that the wrong file is being watched via FileChangeAdapter initially.
{\{FINE [org.netbeans.modules.maven.coverage.MavenCoverageProvider]: missing
C:\Program Files\NetBeans 11.0\bin\jacoco.xml}}
If I get some time, I might take a closer look.
> JaCoCo 0.8.2 breaks code coverage integration
> -
>
> Key: NETBEANS-1997
> URL: https://issues.apache.org/jira/browse/NETBEANS-1997
> Project: NetBeans
> Issue Type: Bug
>Reporter: Philip Durbin
>Assignee: John McDonnell
>Priority: Minor
>
> I asked, "Does JaCoCo 0.8.2 break NetBeans code coverage?" on the users
> mailing list:
> [https://lists.apache.org/thread.html/509bfddb9273726a6e8dff1ca419790b40858d6a648b4413142e2abe@%3Cusers.netbeans.apache.org%3E]
> Geertjan Wielenga said to go ahead and open an issue so I believe he agrees
> that it does.
> The main evidence seems to be in
> [https://github.com/jacoco/jacoco/issues/772] where a JaCoCo developer,
> Evgeny Mandrikov, said the following.
> "AFAIK NetBeans integration reads XML Report, which was intentionally changed
> in version 0.8.2 in a perfectly valid way by addition of new attribute - see
> https://github.com/jacoco/jacoco/pull/702. NetBeans integration must be fixed
> accordingly and ideally be less strict to cope with such updates in future.
> This problem should reported to developers of NetBeans integration, since it
> is not developed by us - as you can see on page
> [https://www.jacoco.org/jacoco/trunk/doc/integrations.html] "
> My workaround was to downgrade to JaCoCo 0.8.1, as I explained in
> [https://github.com/IQSS/dataverse/issues/5483]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-201) Replace plugin portal service
[ https://issues.apache.org/jira/browse/NETBEANS-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846477#comment-16846477 ] Christian Lenz commented on NETBEANS-201: - Maybe a bit offtopic, but to prevent handover from plugins to others like only via [~jkovalsky] it must be possible to add more than one contributor to a plugin (possible from the plugin creator) and to handover it by themself. > Replace plugin portal service > -- > > Key: NETBEANS-201 > URL: https://issues.apache.org/jira/browse/NETBEANS-201 > Project: NetBeans > Issue Type: Task > Components: website >Reporter: Wade Chandler >Assignee: Jiří Kovalský >Priority: Major > > The current NetBeans plugin portal site has a backing service used to help > upload, edit, list, etc plugin information for authors. We need something > similar to better support plugin authors and the plugin center. You can see > this at the following URL while it is still enabled > http://plugins.netbeans.org/ -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
