[jira] [Resolved] (NETBEANS-2480) Gradle UTF-8 Output not Displayed
[ https://issues.apache.org/jira/browse/NETBEANS-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi resolved NETBEANS-2480. --- Fix Version/s: 11.2 Resolution: Fixed > Gradle UTF-8 Output not Displayed > - > > Key: NETBEANS-2480 > URL: https://issues.apache.org/jira/browse/NETBEANS-2480 > Project: NetBeans > Issue Type: Bug > Components: groovy - Code, projects - Gradle >Affects Versions: 11.0, 11.1 > Environment: Windows 10 >Reporter: Eugene Pliskin >Assignee: Laszlo Kishalmi >Priority: Major > Labels: gradle, pull-request-available, utf-8 > Fix For: 11.2 > > Attachments: NetBeans-11.0-console.txt, NetBeans-8.2-console.txt > > Time Spent: 20m > Remaining Estimate: 0h > > Non-ASCII characters completely filtered out of Gradle error messages, > despite "netbeans_default_options" key in "netbeans.conf" file containing > "-J-Dfile.encoding=UTF-8" clause. > > Attached are two build logs of the same Groovy source file with intentional > error in it. > > 1) NetBeans version 8.2 CORRECTLY reports an error: > [Static type checking] - The variable [параметры] is undeclared. > @ line 72, column 38. > def платформы = rv.Платформы(параметры) > ^ > 2) While NetBeans versions 11.0 and 11.1 completely filteres out all > non-ascii letters: > [Static type checking] - The variable [] is undeclared. > @ line 72, column 38. > def = rv.() > ^ > > Note that both attached logs contain line: "Picked up JAVA_TOOL_OPTIONS: > -Dfile.encoding=UTF-8". > > Note also that outside of NetBeans this Gradle command: > > gradlew -x check build > a 2>&1 > > produces correct UTF-8 encoded report similar to NetBeans v.8.2 output. > -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-2480] Fixed filtering out UTF8 characters from Gradle output.
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 3efc6cf [NETBEANS-2480] Fixed filtering out UTF8 characters from
Gradle output.
3efc6cf is described below
commit 3efc6cf7f149e37b0c7c12029fae8abc93a510ef
Author: Laszlo Kishalmi
AuthorDate: Sun Aug 25 07:18:09 2019 -0700
[NETBEANS-2480] Fixed filtering out UTF8 characters from Gradle output.
---
.../execute/EscapeProcessingOutputStream.java | 2 +-
.../execute/EscapeProcessingOutputStreamTest.java | 98 ++
2 files changed, 99 insertions(+), 1 deletion(-)
diff --git
a/groovy/gradle/src/org/netbeans/modules/gradle/execute/EscapeProcessingOutputStream.java
b/groovy/gradle/src/org/netbeans/modules/gradle/execute/EscapeProcessingOutputStream.java
index d4f6d22..6675c8c 100644
---
a/groovy/gradle/src/org/netbeans/modules/gradle/execute/EscapeProcessingOutputStream.java
+++
b/groovy/gradle/src/org/netbeans/modules/gradle/execute/EscapeProcessingOutputStream.java
@@ -64,7 +64,7 @@ class EscapeProcessingOutputStream extends OutputStream {
if (b == '\n') {
buffer.put(b);
processBulk();
-} else if ((b >= 0x20) || (b == 0x09)) {
+} else if ((b >= 0x20) || (b == 0x09) || (b < 0)) {
buffer.put(b);
}
}
diff --git
a/groovy/gradle/test/unit/src/org/netbeans/modules/gradle/execute/EscapeProcessingOutputStreamTest.java
b/groovy/gradle/test/unit/src/org/netbeans/modules/gradle/execute/EscapeProcessingOutputStreamTest.java
new file mode 100644
index 000..29d1606
--- /dev/null
+++
b/groovy/gradle/test/unit/src/org/netbeans/modules/gradle/execute/EscapeProcessingOutputStreamTest.java
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.gradle.execute;
+
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.nio.charset.StandardCharsets;
+import static org.junit.Assert.*;
+import org.junit.Test;
+
+/**
+ *
+ * @author lkishalmi
+ */
+public class EscapeProcessingOutputStreamTest {
+
+private static final String COLORED_TEST = "Hello \033[31mRed
Robin\033[0m.";
+private static final String UTF8_TEST = "大通西（２０～２８丁目）";
+
+private static class DummyEscapeProcessor implements EscapeProcessor {
+
+final StringBuilder output = new StringBuilder();
+
+@Override
+public void processCommand(String sequence, char command, int... args)
{
+}
+
+@Override
+public void processText(String text) {
+output.append(text);
+}
+
+public String toString() {
+return output.toString();
+}
+}
+
+@Test
+public void testUTF8() {
+DummyEscapeProcessor ep = new DummyEscapeProcessor();
+try (EscapeProcessingOutputStream os = new
EscapeProcessingOutputStream(ep)) {
+os.write(UTF8_TEST.getBytes(StandardCharsets.UTF_8));
+os.flush();
+} catch(IOException ex) {
+fail(ex.getMessage());
+}
+assertEquals(UTF8_TEST, ep.toString());
+}
+
+@Test
+public void testEscape() {
+DummyEscapeProcessor ep = new DummyEscapeProcessor();
+try (EscapeProcessingOutputStream os = new
EscapeProcessingOutputStream(ep)) {
+os.write(COLORED_TEST.getBytes(StandardCharsets.UTF_8));
+} catch(IOException ex) {
+fail(ex.getMessage());
+}
+assertEquals("Hello Red Robin.", ep.toString());
+}
+
+@Test
+public void testMultiLine() {
+DummyEscapeProcessor ep = new DummyEscapeProcessor();
+try (PrintWriter out = new PrintWriter(new
EscapeProcessingOutputStream(ep), true)) {
+out.print("Line1");
+assertEquals("", ep.toString());
+out.println();
+assertEquals("Line1\n", ep.toString());
+out.print("Line2");
+}
+assertEquals("Line1\nLine2", ep.toString());
+}
+
+
[jira] [Resolved] (NETBEANS-3022) reduce the number of unchecked call warnings..
[
https://issues.apache.org/jira/browse/NETBEANS-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Kishalmi resolved NETBEANS-3022.
---
Fix Version/s: 11.2
Resolution: Implemented
Mark resolved as the corresponding PR got merged.
> reduce the number of unchecked call warnings..
> --
>
> Key: NETBEANS-3022
> URL: https://issues.apache.org/jira/browse/NETBEANS-3022
> Project: NetBeans
> Issue Type: Improvement
>Reporter: Brad Walker
>Priority: Major
> Labels: pull-request-available
> Fix For: 11.2
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Reduce the number of unchecked call warnings. like this..
> {code:java}
>[repeat]
> /home/bwalker/netbeans/webcommon/javascript2.nodejs/src/org/netbeans/modules/javascript2/nodejs/editor/model/NodeJsObjectInterceptor.java:101:
> warning: [unchecked] unchecked call to ArrayList(Collection) as
> a member of the raw type ArrayList
>[repeat] List childrenScopesCopy =
> new ArrayList(globalScope.getChildrenScopes());
>[repeat]
> ^
>[repeat] where E is a type-variable:
>[repeat] E extends Object declared in class ArrayList{code}
> This is done by simply adding the diamond operator <>..
> In addition, I also had to update the project.properties file at a few places
> to allow the use of the diamond operator..
> {code:java}
> compile:
>[depend] Deleted 14 out of date files in 0 seconds
> [nb-javac] Compiling 10 source files to
> /home/bwalker/netbeans/platform/masterfs/build/classes
>[repeat] warning: [options] bootstrap class path not set in conjunction
> with -source 1.6
>[repeat]
> /home/bwalker/netbeans/platform/masterfs/src/org/netbeans/modules/masterfs/filebasedfs/naming/NamingFactory.java:50:
> error: diamond operator is not supported in -source 1.6
>[repeat] final List list = new ArrayList<>(queue);
>[repeat] ^
>[repeat] (use -source 7 or higher to enable diamond operator)
>[repeat] 1 error
>[repeat] 1 warning
> [nbmerge] Failed to build target: all-masterfs
> {code}
> In these few places I changed the source to 1.8..
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3026) When IDE is loaded up, nothing opens. I re-click net-beans and it opens up small, empty window
[ https://issues.apache.org/jira/browse/NETBEANS-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915463#comment-16915463 ] Laszlo Kishalmi commented on NETBEANS-3026: --- Also try to start the IDE from Command line. It would display a lot of usable information to resolve this one on the console. > When IDE is loaded up, nothing opens. I re-click net-beans and it opens up > small, empty window > --- > > Key: NETBEANS-3026 > URL: https://issues.apache.org/jira/browse/NETBEANS-3026 > Project: NetBeans > Issue Type: Bug > Components: java - Beans >Affects Versions: 11.1 >Reporter: Daniel-John Karas >Priority: Critical > Labels: windows > > When I open net beans, I am shown the basic loading screen where it loads up > the modules and such. When it finishes, nothing happens. I try to relaunch > the app, then I am given nothing but an empty tiny empty window. I have been > trying to fix it for an hour, I am going to use a different IDE in the > meantime but I might as well try and get some help with this. Let me know if > you need any other information and I should be able to provide it. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3026) When IDE is loaded up, nothing opens. I re-click net-beans and it opens up small, empty window
[ https://issues.apache.org/jira/browse/NETBEANS-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915459#comment-16915459 ] Geertjan Wielenga commented on NETBEANS-3026: - Maybe you’re not using a JDK but a JRE? Best in any case to restart with a fresh user directory (see where the user directory is by looking in etc/netbeans.conf). > When IDE is loaded up, nothing opens. I re-click net-beans and it opens up > small, empty window > --- > > Key: NETBEANS-3026 > URL: https://issues.apache.org/jira/browse/NETBEANS-3026 > Project: NetBeans > Issue Type: Bug > Components: java - Beans >Affects Versions: 11.1 >Reporter: Daniel-John Karas >Priority: Critical > Labels: windows > > When I open net beans, I am shown the basic loading screen where it loads up > the modules and such. When it finishes, nothing happens. I try to relaunch > the app, then I am given nothing but an empty tiny empty window. I have been > trying to fix it for an hour, I am going to use a different IDE in the > meantime but I might as well try and get some help with this. Let me know if > you need any other information and I should be able to provide it. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3026) When IDE is loaded up, nothing opens. I re-click net-beans and it opens up small, empty window
[ https://issues.apache.org/jira/browse/NETBEANS-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915457#comment-16915457 ] Geertjan Wielenga commented on NETBEANS-3026: - Which version of NetBeans, which JDK, which operating system? > When IDE is loaded up, nothing opens. I re-click net-beans and it opens up > small, empty window > --- > > Key: NETBEANS-3026 > URL: https://issues.apache.org/jira/browse/NETBEANS-3026 > Project: NetBeans > Issue Type: Bug > Components: java - Beans >Affects Versions: 11.1 >Reporter: Daniel-John Karas >Priority: Critical > Labels: windows > > When I open net beans, I am shown the basic loading screen where it loads up > the modules and such. When it finishes, nothing happens. I try to relaunch > the app, then I am given nothing but an empty tiny empty window. I have been > trying to fix it for an hour, I am going to use a different IDE in the > meantime but I might as well try and get some help with this. Let me know if > you need any other information and I should be able to provide it. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-3026) When IDE is loaded up, nothing opens. I re-click net-beans and it opens up small, empty window
Daniel-John Karas created NETBEANS-3026: --- Summary: When IDE is loaded up, nothing opens. I re-click net-beans and it opens up small, empty window Key: NETBEANS-3026 URL: https://issues.apache.org/jira/browse/NETBEANS-3026 Project: NetBeans Issue Type: Bug Components: java - Beans Affects Versions: 11.1 Reporter: Daniel-John Karas When I open net beans, I am shown the basic loading screen where it loads up the modules and such. When it finishes, nothing happens. I try to relaunch the app, then I am given nothing but an empty tiny empty window. I have been trying to fix it for an hour, I am going to use a different IDE in the meantime but I might as well try and get some help with this. Let me know if you need any other information and I should be able to provide it. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2898) Clicked Oracle Jet ofrom project properties and error appeared
[
https://issues.apache.org/jira/browse/NETBEANS-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915306#comment-16915306
]
Geertjan Wielenga commented on NETBEANS-2898:
-
We should simply delete the ojet module, what it provides is broken or out of
date.
> Clicked Oracle Jet ofrom project properties and error appeared
> --
>
> Key: NETBEANS-2898
> URL: https://issues.apache.org/jira/browse/NETBEANS-2898
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle, web - Oracle JET
>Affects Versions: 11.1
>Reporter: Ruslan Lopez Carro
>Assignee: Geertjan Wielenga
>Priority: Minor
> Attachments: messages.log, uigestures.xml
>
>
> I was working on a gradle project.
> relevant part of the trace:
> {code:java}
> ava.lang.IllegalArgumentException: 2.0.0 is unknown version
> at
> org.netbeans.modules.html.ojet.data.DataProviderImpl.setCurrentVersion(DataProviderImpl.java:165)
> at org.netbeans.modules.html.ojet.ui.OJETPanel.save(OJETPanel.java:161)
> at
> org.netbeans.modules.html.ojet.ui.OJETPanel$1.actionPerformed(OJETPanel.java:66)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener.storePerformed(CustomizerDialog.java:332)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener.storePerformed(CustomizerDialog.java:335)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener.access$400(CustomizerDialog.java:228)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener$2$1$1.run(CustomizerDialog.java:291)
> at org.openide.filesystems.FileUtil$2.run(FileUtil.java:412)
> at org.openide.filesystems.EventControl.runAtomicAction(EventControl.java:102)
> at org.openide.filesystems.FileSystem.runAtomicAction(FileSystem.java:494)
> at org.openide.filesystems.FileUtil.runAtomicAction(FileUtil.java:396)
> at org.openide.filesystems.FileUtil.runAtomicAction(FileUtil.java:416)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2898) Clicked Oracle Jet ofrom project properties and error appeared
[
https://issues.apache.org/jira/browse/NETBEANS-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915304#comment-16915304
]
Laszlo Kishalmi commented on NETBEANS-2898:
---
[~GeertjanWielenga] It might be inside the ojet plugin. I do not know how to
install the support files, though:
the org.netbeans.modules.html.ojet.data.DataProviderImpl searches for the
available versions at:
{code:java}
File folder = InstalledFileLocator.getDefault().locate(zipFolder,
"org.netbeans.modules.html.ojet", false); //NOI18N
{code}
> Clicked Oracle Jet ofrom project properties and error appeared
> --
>
> Key: NETBEANS-2898
> URL: https://issues.apache.org/jira/browse/NETBEANS-2898
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle, web - Oracle JET
>Affects Versions: 11.1
>Reporter: Ruslan Lopez Carro
>Assignee: Geertjan Wielenga
>Priority: Minor
> Attachments: messages.log, uigestures.xml
>
>
> I was working on a gradle project.
> relevant part of the trace:
> {code:java}
> ava.lang.IllegalArgumentException: 2.0.0 is unknown version
> at
> org.netbeans.modules.html.ojet.data.DataProviderImpl.setCurrentVersion(DataProviderImpl.java:165)
> at org.netbeans.modules.html.ojet.ui.OJETPanel.save(OJETPanel.java:161)
> at
> org.netbeans.modules.html.ojet.ui.OJETPanel$1.actionPerformed(OJETPanel.java:66)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener.storePerformed(CustomizerDialog.java:332)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener.storePerformed(CustomizerDialog.java:335)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener.access$400(CustomizerDialog.java:228)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener$2$1$1.run(CustomizerDialog.java:291)
> at org.openide.filesystems.FileUtil$2.run(FileUtil.java:412)
> at org.openide.filesystems.EventControl.runAtomicAction(EventControl.java:102)
> at org.openide.filesystems.FileSystem.runAtomicAction(FileSystem.java:494)
> at org.openide.filesystems.FileUtil.runAtomicAction(FileUtil.java:396)
> at org.openide.filesystems.FileUtil.runAtomicAction(FileUtil.java:416)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-2898) Clicked Oracle Jet ofrom project properties and error appeared
[
https://issues.apache.org/jira/browse/NETBEANS-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Kishalmi reassigned NETBEANS-2898:
-
Assignee: Geertjan Wielenga (was: Laszlo Kishalmi)
> Clicked Oracle Jet ofrom project properties and error appeared
> --
>
> Key: NETBEANS-2898
> URL: https://issues.apache.org/jira/browse/NETBEANS-2898
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle, web - Oracle JET
>Affects Versions: 11.1
>Reporter: Ruslan Lopez Carro
>Assignee: Geertjan Wielenga
>Priority: Minor
> Attachments: messages.log, uigestures.xml
>
>
> I was working on a gradle project.
> relevant part of the trace:
> {code:java}
> ava.lang.IllegalArgumentException: 2.0.0 is unknown version
> at
> org.netbeans.modules.html.ojet.data.DataProviderImpl.setCurrentVersion(DataProviderImpl.java:165)
> at org.netbeans.modules.html.ojet.ui.OJETPanel.save(OJETPanel.java:161)
> at
> org.netbeans.modules.html.ojet.ui.OJETPanel$1.actionPerformed(OJETPanel.java:66)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener.storePerformed(CustomizerDialog.java:332)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener.storePerformed(CustomizerDialog.java:335)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener.access$400(CustomizerDialog.java:228)
> at
> org.netbeans.modules.project.uiapi.CustomizerDialog$OptionListener$2$1$1.run(CustomizerDialog.java:291)
> at org.openide.filesystems.FileUtil$2.run(FileUtil.java:412)
> at org.openide.filesystems.EventControl.runAtomicAction(EventControl.java:102)
> at org.openide.filesystems.FileSystem.runAtomicAction(FileSystem.java:494)
> at org.openide.filesystems.FileUtil.runAtomicAction(FileUtil.java:396)
> at org.openide.filesystems.FileUtil.runAtomicAction(FileUtil.java:416)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2832) Support System input into Gradle output window.
[ https://issues.apache.org/jira/browse/NETBEANS-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-2832: - Labels: pull-request-available (was: ) > Support System input into Gradle output window. > --- > > Key: NETBEANS-2832 > URL: https://issues.apache.org/jira/browse/NETBEANS-2832 > Project: NetBeans > Issue Type: Improvement > Components: projects - Gradle >Reporter: Laszlo Kishalmi >Assignee: Laszlo Kishalmi >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-3025) Netbeans editor looses dependent gradle module if the name of its jar changes frequently
[
https://issues.apache.org/jira/browse/NETBEANS-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Kishalmi resolved NETBEANS-3025.
---
Resolution: Information Provided
> Netbeans editor looses dependent gradle module if the name of its jar changes
> frequently
>
>
> Key: NETBEANS-3025
> URL: https://issues.apache.org/jira/browse/NETBEANS-3025
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle
>Affects Versions: 11.1
>Reporter: Adam Walczak
>Assignee: Laszlo Kishalmi
>Priority: Major
>
> Lets say I have the following multi module project:
>
> build.gralde
> {code:java}
> def projectVersion = new Date().format("-MM-dd-HH-mm")
> subprojects {
> apply plugin: 'java'
>
> sourceCompatibility = 11
> group = 'foo'
> version = projectVersion
> }
> {code}
> foo-commons/build.gradle
> {code:java}
> // nothing
> {code}
> foo-app/build.gradle
> {code:java}
> dependencies {
> compile project(":foo-commons")
> }
> {code}
> This will cause Netbeas to often looses sight of the foo-commons library code
> and classes from there will be not found when editing source code in foo-app.
> The project will however build without any problem in gradle.
>
> I think Netbeans has a problem with the fact that the name of the library jar
> build from foo-commons changes every time any thing changes in that code as
> the projects version is part of the name (foo-commons-2019-08-12-15-54.jar)
>
> A workaround to make Netbean never loose sight of the dependancy is to make
> its jar name constant like so:
>
> foo-commons/build.gradle
> {code:java}
> jar.archiveName = 'foo-commons.jar'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3025) Netbeans editor looses dependent gradle module if the name of its jar changes frequently
[
https://issues.apache.org/jira/browse/NETBEANS-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915289#comment-16915289
]
Laszlo Kishalmi commented on NETBEANS-3025:
---
The way projectVersion is used in the example above is pretty much an
anti-pattern. With that you are changing the name of the jars even if you just
build a sub-module.
The best practice:
I'd not recommend to use the version property in Gradle ing general. Use it
only whenever a released artifact has to be produced . Release build can use
{code:java}
-Pversion=
{code}
argument when the time comes.
The obsession of versions has always been there in developers, then it has been
planted deep by Maven.
Be happy that Gradle give you the freedom to live happily without it in
development time (when your version is actually your local copy).
> Netbeans editor looses dependent gradle module if the name of its jar changes
> frequently
>
>
> Key: NETBEANS-3025
> URL: https://issues.apache.org/jira/browse/NETBEANS-3025
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle
>Affects Versions: 11.1
>Reporter: Adam Walczak
>Assignee: Laszlo Kishalmi
>Priority: Major
>
> Lets say I have the following multi module project:
>
> build.gralde
> {code:java}
> def projectVersion = new Date().format("-MM-dd-HH-mm")
> subprojects {
> apply plugin: 'java'
>
> sourceCompatibility = 11
> group = 'foo'
> version = projectVersion
> }
> {code}
> foo-commons/build.gradle
> {code:java}
> // nothing
> {code}
> foo-app/build.gradle
> {code:java}
> dependencies {
> compile project(":foo-commons")
> }
> {code}
> This will cause Netbeas to often looses sight of the foo-commons library code
> and classes from there will be not found when editing source code in foo-app.
> The project will however build without any problem in gradle.
>
> I think Netbeans has a problem with the fact that the name of the library jar
> build from foo-commons changes every time any thing changes in that code as
> the projects version is part of the name (foo-commons-2019-08-12-15-54.jar)
>
> A workaround to make Netbean never loose sight of the dependancy is to make
> its jar name constant like so:
>
> foo-commons/build.gradle
> {code:java}
> jar.archiveName = 'foo-commons.jar'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2480) Gradle UTF-8 Output not Displayed
[ https://issues.apache.org/jira/browse/NETBEANS-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-2480: - Labels: gradle pull-request-available utf-8 (was: gradle utf-8) > Gradle UTF-8 Output not Displayed > - > > Key: NETBEANS-2480 > URL: https://issues.apache.org/jira/browse/NETBEANS-2480 > Project: NetBeans > Issue Type: Bug > Components: groovy - Code, projects - Gradle >Affects Versions: 11.0, 11.1 > Environment: Windows 10 >Reporter: Eugene Pliskin >Assignee: Laszlo Kishalmi >Priority: Major > Labels: gradle, pull-request-available, utf-8 > Attachments: NetBeans-11.0-console.txt, NetBeans-8.2-console.txt > > > Non-ASCII characters completely filtered out of Gradle error messages, > despite "netbeans_default_options" key in "netbeans.conf" file containing > "-J-Dfile.encoding=UTF-8" clause. > > Attached are two build logs of the same Groovy source file with intentional > error in it. > > 1) NetBeans version 8.2 CORRECTLY reports an error: > [Static type checking] - The variable [параметры] is undeclared. > @ line 72, column 38. > def платформы = rv.Платформы(параметры) > ^ > 2) While NetBeans versions 11.0 and 11.1 completely filteres out all > non-ascii letters: > [Static type checking] - The variable [] is undeclared. > @ line 72, column 38. > def = rv.() > ^ > > Note that both attached logs contain line: "Picked up JAVA_TOOL_OPTIONS: > -Dfile.encoding=UTF-8". > > Note also that outside of NetBeans this Gradle command: > > gradlew -x check build > a 2>&1 > > produces correct UTF-8 encoded report similar to NetBeans v.8.2 output. > -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-3025) Netbeans editor looses dependent gradle module if the name of its jar changes frequently
[
https://issues.apache.org/jira/browse/NETBEANS-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Walczak updated NETBEANS-3025:
---
Description:
Lets say I have the following multi module project:
build.gralde
{code:java}
def projectVersion = new Date().format("-MM-dd-HH-mm")
subprojects {
apply plugin: 'java'
sourceCompatibility = 11
group = 'foo'
version = projectVersion
}
{code}
foo-commons/build.gradle
{code:java}
// nothing
{code}
foo-app/build.gradle
{code:java}
dependencies {
compile project(":foo-commons")
}
{code}
This will cause Netbeas to often looses sight of the foo-commons library code
and classes from there will be not found when editing source code in foo-app.
The project will however build without any problem in gradle.
I think Netbeans has a problem with the fact that the name of the library jar
build from foo-commons changes every time any thing changes in that code as the
projects version is part of the name (foo-commons-2019-08-12-15-54.jar)
A workaround to make Netbean never loose sight of the dependancy is to make its
jar name constant like so:
foo-commons/build.gradle
{code:java}
jar.archiveName = 'foo-commons.jar'
{code}
was:
Lets say I have the following multi module project:
build.gralde
{code:java}
def projectVersion = new Date().format("-MM-dd-HH-mm")
subprojects {
apply plugin: 'java'
sourceCompatibility = 11
group = 'foo'
version = projectVersion
}
{code}
foo-commons/build.gradle
{code:java}
apply plugin: 'java'
{code}
foo-app/build.gradle
{code:java}
dependencies {
compile project(":foo-commons")
}
{code}
This will cause Netbeas to often looses sight of the foo-commons library code
and classes from there will be not found when editing source code in foo-app.
The project will however build without any problem in gradle.
I think Netbeans has a problem with the fact that the name of the library jar
build from foo-commons changes every time any thing changes in that code as the
projects version is part of the name (foo-commons-2019-08-12-15-54.jar)
A workaround to make Netbean never loose sight of the dependancy is to make its
jar name constant like so:
foo-commons/build.gradle
{code:java}
apply plugin: 'java'
jar.archiveName = 'foo-commons.jar'
{code}
> Netbeans editor looses dependent gradle module if the name of its jar changes
> frequently
>
>
> Key: NETBEANS-3025
> URL: https://issues.apache.org/jira/browse/NETBEANS-3025
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle
>Affects Versions: 11.1
>Reporter: Adam Walczak
>Assignee: Laszlo Kishalmi
>Priority: Major
>
> Lets say I have the following multi module project:
>
> build.gralde
> {code:java}
> def projectVersion = new Date().format("-MM-dd-HH-mm")
> subprojects {
> apply plugin: 'java'
>
> sourceCompatibility = 11
> group = 'foo'
> version = projectVersion
> }
> {code}
> foo-commons/build.gradle
> {code:java}
> // nothing
> {code}
> foo-app/build.gradle
> {code:java}
> dependencies {
> compile project(":foo-commons")
> }
> {code}
> This will cause Netbeas to often looses sight of the foo-commons library code
> and classes from there will be not found when editing source code in foo-app.
> The project will however build without any problem in gradle.
>
> I think Netbeans has a problem with the fact that the name of the library jar
> build from foo-commons changes every time any thing changes in that code as
> the projects version is part of the name (foo-commons-2019-08-12-15-54.jar)
>
> A workaround to make Netbean never loose sight of the dependancy is to make
> its jar name constant like so:
>
> foo-commons/build.gradle
> {code:java}
> jar.archiveName = 'foo-commons.jar'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-3025) Netbeans editor looses dependent gradle module if the name of its jar changes frequently
Adam Walczak created NETBEANS-3025:
--
Summary: Netbeans editor looses dependent gradle module if the
name of its jar changes frequently
Key: NETBEANS-3025
URL: https://issues.apache.org/jira/browse/NETBEANS-3025
Project: NetBeans
Issue Type: Bug
Components: projects - Gradle
Affects Versions: 11.1
Reporter: Adam Walczak
Assignee: Laszlo Kishalmi
Lets say I have the following multi module project:
build.gralde
{code:java}
def projectVersion = new Date().format("-MM-dd-HH-mm")
subprojects {
apply plugin: 'java'
sourceCompatibility = 11
group = 'foo'
version = projectVersion
}
{code}
foo-commons/build.gradle
{code:java}
apply plugin: 'java'
{code}
foo-app/build.gradle
{code:java}
dependencies {
compile project(":foo-commons")
}
{code}
This will cause Netbeas to often looses sight of the foo-commons library code
and classes from there will be not found when editing source code in foo-app.
The project will however build without any problem in gradle.
I think Netbeans has a problem with the fact that the name of the library jar
build from foo-commons changes every time any thing changes in that code as the
projects version is part of the name (foo-commons-2019-08-12-15-54.jar)
A workaround to make Netbean never loose sight of the dependancy is to make its
jar name constant like so:
foo-commons/build.gradle
{code:java}
apply plugin: 'java'
jar.archiveName = 'foo-commons.jar'
{code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2480) Gradle UTF-8 Output not Displayed
[ https://issues.apache.org/jira/browse/NETBEANS-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi updated NETBEANS-2480: -- Summary: Gradle UTF-8 Output not Displayed (was: Not a usual UTF8 question!) > Gradle UTF-8 Output not Displayed > - > > Key: NETBEANS-2480 > URL: https://issues.apache.org/jira/browse/NETBEANS-2480 > Project: NetBeans > Issue Type: Bug > Components: groovy - Code, projects - Gradle >Affects Versions: 11.0, 11.1 > Environment: Windows 10 >Reporter: Eugene Pliskin >Assignee: Laszlo Kishalmi >Priority: Major > Labels: gradle, utf-8 > Attachments: NetBeans-11.0-console.txt, NetBeans-8.2-console.txt > > > Non-ASCII characters completely filtered out of Gradle error messages, > despite "netbeans_default_options" key in "netbeans.conf" file containing > "-J-Dfile.encoding=UTF-8" clause. > > Attached are two build logs of the same Groovy source file with intentional > error in it. > > 1) NetBeans version 8.2 CORRECTLY reports an error: > [Static type checking] - The variable [параметры] is undeclared. > @ line 72, column 38. > def платформы = rv.Платформы(параметры) > ^ > 2) While NetBeans versions 11.0 and 11.1 completely filteres out all > non-ascii letters: > [Static type checking] - The variable [] is undeclared. > @ line 72, column 38. > def = rv.() > ^ > > Note that both attached logs contain line: "Picked up JAVA_TOOL_OPTIONS: > -Dfile.encoding=UTF-8". > > Note also that outside of NetBeans this Gradle command: > > gradlew -x check build > a 2>&1 > > produces correct UTF-8 encoded report similar to NetBeans v.8.2 output. > -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2480) Not a usual UTF8 question!
[ https://issues.apache.org/jira/browse/NETBEANS-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi updated NETBEANS-2480: -- Component/s: projects - Gradle > Not a usual UTF8 question! > -- > > Key: NETBEANS-2480 > URL: https://issues.apache.org/jira/browse/NETBEANS-2480 > Project: NetBeans > Issue Type: Bug > Components: groovy - Code, projects - Gradle >Affects Versions: 11.0, 11.1 > Environment: Windows 10 >Reporter: Eugene Pliskin >Assignee: Laszlo Kishalmi >Priority: Major > Labels: gradle, utf-8 > Attachments: NetBeans-11.0-console.txt, NetBeans-8.2-console.txt > > > Non-ASCII characters completely filtered out of Gradle error messages, > despite "netbeans_default_options" key in "netbeans.conf" file containing > "-J-Dfile.encoding=UTF-8" clause. > > Attached are two build logs of the same Groovy source file with intentional > error in it. > > 1) NetBeans version 8.2 CORRECTLY reports an error: > [Static type checking] - The variable [параметры] is undeclared. > @ line 72, column 38. > def платформы = rv.Платформы(параметры) > ^ > 2) While NetBeans versions 11.0 and 11.1 completely filteres out all > non-ascii letters: > [Static type checking] - The variable [] is undeclared. > @ line 72, column 38. > def = rv.() > ^ > > Note that both attached logs contain line: "Picked up JAVA_TOOL_OPTIONS: > -Dfile.encoding=UTF-8". > > Note also that outside of NetBeans this Gradle command: > > gradlew -x check build > a 2>&1 > > produces correct UTF-8 encoded report similar to NetBeans v.8.2 output. > -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-2480) Not a usual UTF8 question!
[ https://issues.apache.org/jira/browse/NETBEANS-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi reassigned NETBEANS-2480: - Assignee: Laszlo Kishalmi > Not a usual UTF8 question! > -- > > Key: NETBEANS-2480 > URL: https://issues.apache.org/jira/browse/NETBEANS-2480 > Project: NetBeans > Issue Type: Bug > Components: groovy - Code >Affects Versions: 11.0, 11.1 > Environment: Windows 10 >Reporter: Eugene Pliskin >Assignee: Laszlo Kishalmi >Priority: Major > Labels: gradle, utf-8 > Attachments: NetBeans-11.0-console.txt, NetBeans-8.2-console.txt > > > Non-ASCII characters completely filtered out of Gradle error messages, > despite "netbeans_default_options" key in "netbeans.conf" file containing > "-J-Dfile.encoding=UTF-8" clause. > > Attached are two build logs of the same Groovy source file with intentional > error in it. > > 1) NetBeans version 8.2 CORRECTLY reports an error: > [Static type checking] - The variable [параметры] is undeclared. > @ line 72, column 38. > def платформы = rv.Платформы(параметры) > ^ > 2) While NetBeans versions 11.0 and 11.1 completely filteres out all > non-ascii letters: > [Static type checking] - The variable [] is undeclared. > @ line 72, column 38. > def = rv.() > ^ > > Note that both attached logs contain line: "Picked up JAVA_TOOL_OPTIONS: > -Dfile.encoding=UTF-8". > > Note also that outside of NetBeans this Gradle command: > > gradlew -x check build > a 2>&1 > > produces correct UTF-8 encoded report similar to NetBeans v.8.2 output. > -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: JDK13 text block support
This is an automated email from the ASF dual-hosted git repository.
jlahoda pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new cb50c2f JDK13 text block support
cb50c2f is described below
commit cb50c2fede0387535900727e1abdcd4718ab02fd
Author: Reema Taneja <32299405+rtane...@users.noreply.github.com>
AuthorDate: Sun Aug 25 14:14:54 2019 +0530
JDK13 text block support
---
ide/editor.indent/apichanges.xml | 12 ++
.../modules/editor/indent/spi/Context.java | 32 -
.../src/org/netbeans/editor/BaseKit.java | 51 +--
.../editor/base/semantic/ColoringAttributes.java | 4 +-
.../base/semantic/SemanticHighlighterBase.java | 59 +++-
.../java/editor/base/semantic/TokenList.java | 24
.../java/editor/base/semantic/DetectorTest.java| 43 ++
.../java/editor/base/semantic/HighlightImpl.java | 1 +
.../java/editor/base/semantic/MarkOccDetTest.java | 17 ++-
.../java/editor/base/semantic/TestBase.java| 80 ++-
.../modules/editor/java/TypingCompletion.java | 53 +--
.../java/editor/imports/ClipboardHandler.java | 128 -
.../modules/java/editor/resources/fontsColors.xml | 1 +
.../java/editor/semantic/ColoringManager.java | 1 +
.../java/editor/semantic/SemanticHighlighter.java | 8 +-
.../editor/java/TypingCompletionUnitTest.java | 63 -
.../java/editor/imports/ClipboardHandlerTest.java | 15 ++
.../modules/java/hints/jdk/ConvertToTextBlock.java | 109 +++
.../modules/java/hints/resources/jdk13.properties | 17 +++
.../modules/java/hints/resources/layer.xml | 16 +++
.../java/hints/jdk/ConvertToTextBlockTest.java | 155 +
java/java.lexer/apichanges.xml | 12 ++
.../org/netbeans/api/java/lexer/JavaTokenId.java | 2 +
.../src/org/netbeans/lib/java/lexer/JavaLexer.java | 24 +++-
.../lib/java/lexer/JavaLexerBatchTest.java | 35 -
.../org/netbeans/api/java/source/SourceUtils.java | 26 +++-
.../modules/java/source/builder/TreeFactory.java | 2 +
.../modules/java/source/pretty/CharBuffer.java | 16 ++-
.../modules/java/source/pretty/VeryPretty.java | 34 -
.../modules/java/source/save/Reindenter.java | 34 -
.../netbeans/api/java/source/gen/LiteralTest.java | 88
.../modules/java/source/save/ReindenterTest.java | 35 -
32 files changed, 1104 insertions(+), 93 deletions(-)
diff --git a/ide/editor.indent/apichanges.xml b/ide/editor.indent/apichanges.xml
index 932020a..255737d 100644
--- a/ide/editor.indent/apichanges.xml
+++ b/ide/editor.indent/apichanges.xml
@@ -83,6 +83,18 @@ is the proper place.
+
+Indent can be given as a string
+
+
+
+
+
+Added method
org.netbeans.modules.editor.indent.spi.Context.modifyIndent(int, int, String),
+which allows to set indent by specifying particular indent
string.
+
+
+
Indentation Support module created
diff --git
a/ide/editor.indent/src/org/netbeans/modules/editor/indent/spi/Context.java
b/ide/editor.indent/src/org/netbeans/modules/editor/indent/spi/Context.java
index a9d1108..0ed70ad 100644
--- a/ide/editor.indent/src/org/netbeans/modules/editor/indent/spi/Context.java
+++ b/ide/editor.indent/src/org/netbeans/modules/editor/indent/spi/Context.java
@@ -170,23 +170,43 @@ public final class Context {
}
String newIndentString = IndentUtils.createIndentString(doc,
newIndent);
+
+modifyIndent(lineStartOffset, oldIndentEndOffset - lineStartOffset,
newIndentString);
+}
+
+/**
+ * Modify indent of the line at the offset passed as the parameter, by
stripping the given
+ * number of input characters and inserting the given indent.
+ *
+ * @param lineStartOffset start offset of a line where the indent is being
modified.
+ * @param oldIndentCharCount number of characters to remove.
+ * @param newIndent new indent.
+ * @throws javax.swing.text.BadLocationException if the given
lineStartOffset is not within
+ * corresponding document's bounds.
+ * @since 1.49
+ */
+public void modifyIndent(int lineStartOffset, int oldIndentCharCount,
String newIndent) throws BadLocationException {
+Document doc = document();
+IndentImpl.checkOffsetInDocument(doc, lineStartOffset);
+CharSequence docText = DocumentUtilities.getText(doc);
+int oldIndentEndOffset = lineStartOffset + oldIndentCharCount;
// Attempt to match the begining characters
int offset = lineStartOffset;
-for (int i = 0; i < newIndentString.length() && lineStartOffset + i <
