[netbeans] branch master updated: [NETBEANS-3380] Fix default of checkOnlyImmutables option in ConstantName hint.
This is an automated email from the ASF dual-hosted git repository.
emi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new b02fe57 [NETBEANS-3380] Fix default of checkOnlyImmutables option in
ConstantName hint.
new fe7ea52 Merge pull request #1642 from errael/fixConstNames
b02fe57 is described below
commit b02fe5735672432ea146491c4f7dfaddb7fcd06f
Author: Ernie Rael
AuthorDate: Wed Nov 20 03:39:29 2019 +
[NETBEANS-3380] Fix default of checkOnlyImmutables option in ConstantName
hint.
---
.../org/netbeans/modules/java/hints/suggestions/ConstantNameHint.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/java/java.hints/src/org/netbeans/modules/java/hints/suggestions/ConstantNameHint.java
b/java/java.hints/src/org/netbeans/modules/java/hints/suggestions/ConstantNameHint.java
index 1402482..3116267 100644
---
a/java/java.hints/src/org/netbeans/modules/java/hints/suggestions/ConstantNameHint.java
+++
b/java/java.hints/src/org/netbeans/modules/java/hints/suggestions/ConstantNameHint.java
@@ -127,7 +127,7 @@ public class ConstantNameHint {
}
Preferences prefs = ctx.getPreferences();
-boolean onlyImmClasses = prefs.getBoolean(PREF_CHECK_ONLY_IMMUTABLES,
false);
+boolean onlyImmClasses = prefs.getBoolean(PREF_CHECK_ONLY_IMMUTABLES,
DEFAULT_CHECK_ONLY_IMMUTABLES);
if (onlyImmClasses && !isImmutableValue(ctx.getInfo(), p,
ctx.getPreferences())) {
return null;
}
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-3380) "ConstantName" hint's flag "Check only immutable" uses incorrect prefs.getBoolean default
[ https://issues.apache.org/jira/browse/NETBEANS-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernie Rael updated NETBEANS-3380: - Summary: "ConstantName" hint's flag "Check only immutable" uses incorrect prefs.getBoolean default (was: "ConstantName" hint's flag "Check only immutable" uses incorrect default) > "ConstantName" hint's flag "Check only immutable" uses incorrect > prefs.getBoolean default > - > > Key: NETBEANS-3380 > URL: https://issues.apache.org/jira/browse/NETBEANS-3380 > Project: NetBeans > Issue Type: Bug > Components: java - Hints >Affects Versions: 11.2 > Environment: windows, jdk1.8 >Reporter: Ernie Rael >Priority: Minor > Labels: pull-request-available > Attachments: ConstantNameHint.java.diff > > Time Spent: 10m > Remaining Estimate: 0h > > For the indicated option, "prefs.getBoolean(str, default)" has different > "default" for when displaying the options dialog and checking value for use. > *FIX ATTACHED* for ConstantNameHint.java (haven't learned git yet...) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-3380) "ConstantName" hint's flag "Check only immutable" uses incorrect default
[ https://issues.apache.org/jira/browse/NETBEANS-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978064#comment-16978064 ] Ernie Rael edited comment on NETBEANS-3380 at 11/20/19 4:59 AM: Here's the entire trivial change in file .../java/hints/suggestions/ConstantNameHint.java old: boolean onlyImmClasses = prefs.getBoolean(PREF_CHECK_ONLY_IMMUTABLES, false); new: boolean onlyImmClasses = prefs.getBoolean(PREF_CHECK_ONLY_IMMUTABLES, DEFAULT_CHECK_ONLY_IMMUTABLES); Use the constant (which is defined to be "true") instead of primitive "false". This avoid inconsistencies between ui display and actual behavior. The ui uses the constant. was (Author: errael): Here's the entire trivial change in file .../java/hints/suggestions/ConstantNameHint.java - boolean onlyImmClasses = prefs.getBoolean(PREF_CHECK_ONLY_IMMUTABLES, false); + boolean onlyImmClasses = prefs.getBoolean(PREF_CHECK_ONLY_IMMUTABLES, DEFAULT_CHECK_ONLY_IMMUTABLES); Use the constant (which is defined to be "true") instead of primitive "false". This avoid inconsistencies between ui display and actual behavior. The ui uses the constant. > "ConstantName" hint's flag "Check only immutable" uses incorrect default > > > Key: NETBEANS-3380 > URL: https://issues.apache.org/jira/browse/NETBEANS-3380 > Project: NetBeans > Issue Type: Bug > Components: java - Hints >Affects Versions: 11.2 > Environment: windows, jdk1.8 >Reporter: Ernie Rael >Priority: Minor > Labels: pull-request-available > Attachments: ConstantNameHint.java.diff > > Time Spent: 10m > Remaining Estimate: 0h > > For the indicated option, "prefs.getBoolean(str, default)" has different > "default" for when displaying the options dialog and checking value for use. > *FIX ATTACHED* for ConstantNameHint.java (haven't learned git yet...) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-3380) "ConstantName" hint's flag "Check only immutable" uses incorrect default
[ https://issues.apache.org/jira/browse/NETBEANS-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernie Rael updated NETBEANS-3380: - Summary: "ConstantName" hint's flag "Check only immutable" uses incorrect default (was: hint "Constant naming conventions" defaults incorrectly for "Check only immutable types" flag) Here's the entire trivial change in file .../java/hints/suggestions/ConstantNameHint.java - boolean onlyImmClasses = prefs.getBoolean(PREF_CHECK_ONLY_IMMUTABLES, false); + boolean onlyImmClasses = prefs.getBoolean(PREF_CHECK_ONLY_IMMUTABLES, DEFAULT_CHECK_ONLY_IMMUTABLES); Use the constant (which is defined to be "true") instead of primitive "false". This avoid inconsistencies between ui display and actual behavior. The ui uses the constant. > "ConstantName" hint's flag "Check only immutable" uses incorrect default > > > Key: NETBEANS-3380 > URL: https://issues.apache.org/jira/browse/NETBEANS-3380 > Project: NetBeans > Issue Type: Bug > Components: java - Hints >Affects Versions: 11.2 > Environment: windows, jdk1.8 >Reporter: Ernie Rael >Priority: Minor > Labels: pull-request-available > Attachments: ConstantNameHint.java.diff > > Time Spent: 10m > Remaining Estimate: 0h > > For the indicated option, "prefs.getBoolean(str, default)" has different > "default" for when displaying the options dialog and checking value for use. > *FIX ATTACHED* for ConstantNameHint.java (haven't learned git yet...) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3380) hint "Constant naming conventions" defaults incorrectly for "Check only immutable types" flag
[ https://issues.apache.org/jira/browse/NETBEANS-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978058#comment-16978058 ] Laszlo Kishalmi commented on NETBEANS-3380: --- First of all, thank you for contributing! Could you reword the description, as I do not think it is obvious for everyone what is the issue here. Also attaching a few screenshots might help. > hint "Constant naming conventions" defaults incorrectly for "Check only > immutable types" flag > - > > Key: NETBEANS-3380 > URL: https://issues.apache.org/jira/browse/NETBEANS-3380 > Project: NetBeans > Issue Type: Bug > Components: java - Hints >Affects Versions: 11.2 > Environment: windows, jdk1.8 >Reporter: Ernie Rael >Priority: Minor > Labels: pull-request-available > Attachments: ConstantNameHint.java.diff > > Time Spent: 10m > Remaining Estimate: 0h > > For the indicated option, "prefs.getBoolean(str, default)" has different > "default" for when displaying the options dialog and checking value for use. > *FIX ATTACHED* for ConstantNameHint.java (haven't learned git yet...) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-3380) hint "Constant naming conventions" defaults incorrectly for "Check only immutable types" flag
[ https://issues.apache.org/jira/browse/NETBEANS-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernie Rael updated NETBEANS-3380: - Labels: pull-request-available (was: patch pull-request-available) > hint "Constant naming conventions" defaults incorrectly for "Check only > immutable types" flag > - > > Key: NETBEANS-3380 > URL: https://issues.apache.org/jira/browse/NETBEANS-3380 > Project: NetBeans > Issue Type: Bug > Components: java - Hints >Affects Versions: 11.2 > Environment: windows, jdk1.8 >Reporter: Ernie Rael >Priority: Minor > Labels: pull-request-available > Attachments: ConstantNameHint.java.diff > > Time Spent: 10m > Remaining Estimate: 0h > > For the indicated option, "prefs.getBoolean(str, default)" has different > "default" for when displaying the options dialog and checking value for use. > *FIX ATTACHED* for ConstantNameHint.java (haven't learned git yet...) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-3380) hint "Constant naming conventions" defaults incorrectly for "Check only immutable types" flag
[ https://issues.apache.org/jira/browse/NETBEANS-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernie Rael updated NETBEANS-3380: - Ignore patch. Made a pull request #1642 > hint "Constant naming conventions" defaults incorrectly for "Check only > immutable types" flag > - > > Key: NETBEANS-3380 > URL: https://issues.apache.org/jira/browse/NETBEANS-3380 > Project: NetBeans > Issue Type: Bug > Components: java - Hints >Affects Versions: 11.2 > Environment: windows, jdk1.8 >Reporter: Ernie Rael >Priority: Minor > Labels: patch, pull-request-available > Attachments: ConstantNameHint.java.diff > > Time Spent: 10m > Remaining Estimate: 0h > > For the indicated option, "prefs.getBoolean(str, default)" has different > "default" for when displaying the options dialog and checking value for use. > *FIX ATTACHED* for ConstantNameHint.java (haven't learned git yet...) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-3380) hint "Constant naming conventions" defaults incorrectly for "Check only immutable types" flag
[ https://issues.apache.org/jira/browse/NETBEANS-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-3380: - Labels: patch pull-request-available (was: patch) > hint "Constant naming conventions" defaults incorrectly for "Check only > immutable types" flag > - > > Key: NETBEANS-3380 > URL: https://issues.apache.org/jira/browse/NETBEANS-3380 > Project: NetBeans > Issue Type: Bug > Components: java - Hints >Affects Versions: 11.2 > Environment: windows, jdk1.8 >Reporter: Ernie Rael >Priority: Minor > Labels: patch, pull-request-available > Attachments: ConstantNameHint.java.diff > > > For the indicated option, "prefs.getBoolean(str, default)" has different > "default" for when displaying the options dialog and checking value for use. > *FIX ATTACHED* for ConstantNameHint.java (haven't learned git yet...) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2371) Gradle projects not properly loaded
[ https://issues.apache.org/jira/browse/NETBEANS-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978018#comment-16978018 ] Shevek commented on NETBEANS-2371: -- I think this has improved over time: Now, either * The project loads OK, OR: * The project fails to load because NetBeans simply doesn't see an entire set of input files (separate, as yet unreported issue, most likely to do with a race around masterfs). We don't tend to see the thing where 1 or 2 files in a project don't compile with no apparent reason. We do see a thing where if we add a non-cached dep to a build.gradle, the project fails to load in nb, and we must: * Run a build outside nb * Run download-sources within nb in order to get the project to behave. > Gradle projects not properly loaded > --- > > Key: NETBEANS-2371 > URL: https://issues.apache.org/jira/browse/NETBEANS-2371 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 11.0 > Environment: Netbeans 11 > Gradle 5 > Java 11 >Reporter: Netbeans User 2019 >Assignee: Laszlo Kishalmi >Priority: Major > Attachments: org-netbeans-modules-gradle-java.nbm > > > - gradle module (plugin) has problem to resolve dependencies in multi project > as seems I can removed reds only if I go over each one subproject and do > clean and build (clean and build on root has no affects) and additionally it > seems that for some test resources even this was not enough, but it seems > that works old trick so creation folder and adding some new class (possible > even delete) and possibly with including "refresh" from Action items window. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-2024) Gradle sub-project doesn't see compile depedencies
[ https://issues.apache.org/jira/browse/NETBEANS-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi resolved NETBEANS-2024. --- Resolution: Abandoned > Gradle sub-project doesn't see compile depedencies > -- > > Key: NETBEANS-2024 > URL: https://issues.apache.org/jira/browse/NETBEANS-2024 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: Next > Environment: Windows 8.1 x64 > OpenJDK 1.8.0_202 x64 > Netbeans dev #986 >Reporter: Oleg Schelykalnov >Priority: Major > Labels: gradle > Time Spent: 0.5h > Remaining Estimate: 0h > > When opening gradle projects with subprojects NetBeans doesn't see subproject > dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2371) Gradle projects not properly loaded
[ https://issues.apache.org/jira/browse/NETBEANS-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978016#comment-16978016 ] Laszlo Kishalmi commented on NETBEANS-2371: --- BTW, has this improved over the time? I had to rewrite the classpath support for 11.1 in order to get it compatible with jigsaw modules. That might improve/worsen this issue. I'm not doing too much hard core java development besides working on NetBeans. Can we close this issue? > Gradle projects not properly loaded > --- > > Key: NETBEANS-2371 > URL: https://issues.apache.org/jira/browse/NETBEANS-2371 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 11.0 > Environment: Netbeans 11 > Gradle 5 > Java 11 >Reporter: Netbeans User 2019 >Assignee: Laszlo Kishalmi >Priority: Major > Attachments: org-netbeans-modules-gradle-java.nbm > > > - gradle module (plugin) has problem to resolve dependencies in multi project > as seems I can removed reds only if I go over each one subproject and do > clean and build (clean and build on root has no affects) and additionally it > seems that for some test resources even this was not enough, but it seems > that works old trick so creation folder and adding some new class (possible > even delete) and possibly with including "refresh" from Action items window. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-3384) java.lang.NullPointerException in HtmlLexer
[ https://issues.apache.org/jira/browse/NETBEANS-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi updated NETBEANS-3384: -- Summary: java.lang.NullPointerException in HtmlLexer (was: java.lang.NullPointerException) > java.lang.NullPointerException in HtmlLexer > --- > > Key: NETBEANS-3384 > URL: https://issues.apache.org/jira/browse/NETBEANS-3384 > Project: NetBeans > Issue Type: Bug > Components: javascript - Editor >Affects Versions: 11.2 > Environment: Window 10 professional x64 >Reporter: Toni >Priority: Major > Fix For: 11.2 > > Attachments: IDE.log, UI.log, screenshot_191114_085134.jpg, > screenshot_191114_085138.jpg, screenshot_191114_085140.jpg, > screenshot_191114_085143.jpg, screenshot_191114_085154.jpg > > > In large javascript file (1 lines) when I press Enter I do not get new > line and IDE displays error. More you have in attached document. Problem I > have got with new version of Apache NetBeans 11.2. Now I am usin Java 11, > also I have tried Java 13, same problem. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-2555) When running any test, standard output is not shown in the panel to the right of the test file result.
[ https://issues.apache.org/jira/browse/NETBEANS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi resolved NETBEANS-2555. --- Fix Version/s: 11.3 Resolution: Implemented Marked resolved as the corresponding PR got merged. > When running any test, standard output is not shown in the panel to the right > of the test file result. > -- > > Key: NETBEANS-2555 > URL: https://issues.apache.org/jira/browse/NETBEANS-2555 > Project: NetBeans > Issue Type: Improvement > Components: projects - Gradle >Affects Versions: 11.0, 11.1 >Reporter: Mark Flacy >Assignee: Laszlo Kishalmi >Priority: Minor > Labels: pull-request-available > Fix For: 11.3 > > Time Spent: 20m > Remaining Estimate: 0h > > It isn't important that the output is available on the side panel while the > test is running; it is sufficient to me if the output is presented after the > tests have run if I select a specific test on the test panel. > I have a simple project at github that shows the behavior. > [https://github.com/Richard-Cranium/NB11GradleJunitExample] > The head of the master branch is the gradle based project that shows the > misleading behavior. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3414) Method not marked as unused
[
https://issues.apache.org/jira/browse/NETBEANS-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977845#comment-16977845
]
Tomáš Procházka commented on NETBEANS-3414:
---
Problem seems to be around this line:
[https://github.com/apache/netbeans/blob/aab31ed40d6e7a4da99608b5ef010b64fbb4d012/php/php.editor/src/org/netbeans/modules/php/editor/csl/SemanticAnalysis.java#L515]
Invoked method is compared only by its name, class where the method belongs is
not considered (or current class is used).
> Method not marked as unused
> ---
>
> Key: NETBEANS-3414
> URL: https://issues.apache.org/jira/browse/NETBEANS-3414
> Project: NetBeans
> Issue Type: Bug
> Components: php - Code Analysis, php - Editor
>Affects Versions: 11.2
>Reporter: Tomáš Procházka
>Priority: Minor
>
> Private method in class is not marked as unused when method with same name is
> used in class.
> Example:
> {code:java}
> class Car {
> public function isEmpty(): bool {
> }
> }
> class Garage {
> /** @var Car */
> private $car;
> public function isCarEmpty(): bool {
> return $this->car->isEmpty(); // Comment this line and
> self::isEmpty() is marked as unused.
> }
> private function isEmpty(): bool {
> }
> }
> {code}
> Method Garage::isEmpty() is not used, but is not marked as unused.
> After commenting/deleting content of method Garage::isCarEmpty() is method
> Garage::isEmpty() marked as unused.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated (ef55a1a -> aab31ed)
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from ef55a1a Merge pull request #1620 from pepness/asm72v3 add aab31ed [NETBEANS-2555] Display test output while running tests. No new revisions were added by this update. Summary of changes: .../gradle/test/GradleTestProgressListener.java| 31 +- 1 file changed, 30 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-3414) Method not marked as unused
Tomáš Procházka created NETBEANS-3414:
-
Summary: Method not marked as unused
Key: NETBEANS-3414
URL: https://issues.apache.org/jira/browse/NETBEANS-3414
Project: NetBeans
Issue Type: Bug
Components: php - Code Analysis, php - Editor
Affects Versions: 11.2
Reporter: Tomáš Procházka
Private method in class is not marked as unused when method with same name is
used in class.
Example:
{code:java}
class Car {
public function isEmpty(): bool {
}
}
class Garage {
/** @var Car */
private $car;
public function isCarEmpty(): bool {
return $this->car->isEmpty(); // Comment this line and self::isEmpty()
is marked as unused.
}
private function isEmpty(): bool {
}
}
{code}
Method Garage::isEmpty() is not used, but is not marked as unused.
After commenting/deleting content of method Garage::isCarEmpty() is method
Garage::isEmpty() marked as unused.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-3413) PHPDoc - implicit description inheritance
Tomáš Procházka created NETBEANS-3413:
-
Summary: PHPDoc - implicit description inheritance
Key: NETBEANS-3413
URL: https://issues.apache.org/jira/browse/NETBEANS-3413
Project: NetBeans
Issue Type: Improvement
Components: php - Editor
Affects Versions: 11.2
Reporter: Tomáš Procházka
Currently NetBeans IDE supports inheritance of docblocks containing @inheritdoc
annotation.
It would be useful if docblocks are inherited even in case when there is no
docblock present.
Example:
{code:java}
class Circle {
/**
* Hides circle
*/
public function hide() {
}
/**
* Shows circle
*/
public function show() {
}
}
class SpecialCircle extends Circle {
/**
* {@inheritdoc}
*/
public function hide() {
parent::hide();
}
public function show() {
parent::show();
}
public function redraw() {
$this->hide(); // Text "Hides circle" is shown
$this->show(); // Text "PHPDoc not found" is shown, expected "Shows
circle"
}
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-3346] -Upgrade asm-all-5.0.1 version to asm-7.2 -Add constructor parameter to use ASMv7 API -Visit @ConstructorDelegate parameters as array. (by sdedic) -Us
This is an automated email from the ASF dual-hosted git repository.
sdedic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 7eb2c43 [NETBEANS-3346] -Upgrade asm-all-5.0.1 version to asm-7.2
-Add constructor parameter to use ASMv7 API -Visit @ConstructorDelegate
parameters as array. (by sdedic) -Use only one license file for both jars
new ef55a1a Merge pull request #1620 from pepness/asm72v3
7eb2c43 is described below
commit 7eb2c431c259e1b5eb37cc6061e8d23c2329778a
Author: Jose Contreras
AuthorDate: Thu Nov 7 18:50:53 2019 -0600
[NETBEANS-3346]
-Upgrade asm-all-5.0.1 version to asm-7.2
-Add constructor parameter to use ASMv7 API
-Visit @ConstructorDelegate parameters as array. (by sdedic)
-Use only one license file for both jars
---
.../javaee/wildfly/WildflyDeploymentFactory.java | 2 +-
harness/apisupport.harness/build.xml | 4 +-
.../netbeans/lib/jshell/agent/NbJShellAgent.java | 4 +-
java/lib.jshell.agent/nbproject/project.properties | 2 +-
nbbuild/templates/common.xml | 6 +-
.../src/org/netbeans/core/startup/Asm.java | 67 ++
...m-all-5.0.1-license.txt => asm-7.2-license.txt} | 16 +++---
platform/libs.asm/external/binaries-list | 3 +-
platform/libs.asm/nbproject/project.properties | 7 ++-
platform/libs.asm/nbproject/project.xml| 16 ++
10 files changed, 83 insertions(+), 44 deletions(-)
diff --git
a/contrib/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/WildflyDeploymentFactory.java
b/contrib/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/WildflyDeploymentFactory.java
index 01e3246..4068b8c 100644
---
a/contrib/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/WildflyDeploymentFactory.java
+++
b/contrib/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/WildflyDeploymentFactory.java
@@ -153,7 +153,7 @@ public class WildflyDeploymentFactory implements
DeploymentFactory {
return super.getCommonSuperClass(string,
string1);
}
};
-ClassNode node = new ClassNode();
+ClassNode node = new ClassNode(Opcodes.ASM7);
cr.accept(node, 0);
for (MethodNode m : (Collection)
node.methods) {
diff --git a/harness/apisupport.harness/build.xml
b/harness/apisupport.harness/build.xml
index 548620f..d97a498 100644
--- a/harness/apisupport.harness/build.xml
+++ b/harness/apisupport.harness/build.xml
@@ -39,13 +39,13 @@
-2F7553F50B0D14ED811B849C282DA8C1FFC32AAE
org.ow2.asm:asm-all:5.0.1
+FA637EB67EB7628C915D73762B681AE7FF0B9731
org.ow2.asm:asm:7.2
-
+
diff --git
a/java/lib.jshell.agent/agentsrc/org/netbeans/lib/jshell/agent/NbJShellAgent.java
b/java/lib.jshell.agent/agentsrc/org/netbeans/lib/jshell/agent/NbJShellAgent.java
index 7282ae2..8fd0ee3 100644
---
a/java/lib.jshell.agent/agentsrc/org/netbeans/lib/jshell/agent/NbJShellAgent.java
+++
b/java/lib.jshell.agent/agentsrc/org/netbeans/lib/jshell/agent/NbJShellAgent.java
@@ -377,7 +377,7 @@ public class NbJShellAgent implements Runnable,
ClassFileTransformer {
*/
private void insertClassInit(String className, ClassNode target) {
// method void static clinit()
-MethodNode clinit = new MethodNode(Opcodes.ASM5,
+MethodNode clinit = new MethodNode(Opcodes.ASM7,
Opcodes.ACC_STATIC | Opcodes.ACC_SYNTHETIC,
CLASS_INIT_NAME,
CLASS_INIT_DESC,
@@ -400,7 +400,7 @@ public class NbJShellAgent implements Runnable,
ClassFileTransformer {
istm = new ByteArrayInputStream(classfileBuffer);
ClassReader reader = new ClassReader(istm);
ClassWriter wr = new ClassWriter(reader, 0);
-ClassNode clazz = new ClassNode();
+ClassNode clazz = new ClassNode(Opcodes.ASM7);
reader.accept(clazz, 0);
boolean found = false;
diff --git a/java/lib.jshell.agent/nbproject/project.properties
b/java/lib.jshell.agent/nbproject/project.properties
index 6641c35..0020ac6 100644
--- a/java/lib.jshell.agent/nbproject/project.properties
+++ b/java/lib.jshell.agent/nbproject/project.properties
@@ -21,5 +21,5 @@ javac.compilerargs=-Xlint -Xlint:-serial
extra.module.files=modules/ext/nb-custom-jshell-probe.jar,modules/ext/nb-mod-jshell-probe.jar
jnlp.indirect.jars=modules/ext/nb-custom-jshell-probe.jar,modules/ext/nb-mod-jshell-probe.jar
-agentsrc.asm.cp=${libs.asm.dir}/core/asm-all-5.0.1.jar
+agentsrc.asm.cp=${libs.asm.dir}/core/asm-7.2.jar
[jira] [Created] (NETBEANS-3412) Close tabs to the right from a selected tab
Bo Andersen created NETBEANS-3412: - Summary: Close tabs to the right from a selected tab Key: NETBEANS-3412 URL: https://issues.apache.org/jira/browse/NETBEANS-3412 Project: NetBeans Issue Type: New Feature Components: editor - Navigation Affects Versions: 11.1 Reporter: Bo Andersen Like Chrome og PhpStorm, it would be nice you could group your tabs to the left, and close all to the right ones from a selected tab (right click on a tab). Right now you only have the options to close all, or close others. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3385) Reload of dependencies in a gradle project always fails.
[ https://issues.apache.org/jira/browse/NETBEANS-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977561#comment-16977561 ] Laszlo Kishalmi commented on NETBEANS-3385: --- Interesting. I just opened did the following: # Opened the project: It reported missing dependencies (that can be an issue as based on my setting it shall download the dependencies) # Just did a build in the IDE, the dependencies has been loaded. IDE removed all error notifications and warnings. # Changed the dependency of javalin 3.5.0 -> 3.6.0. Saved the file # The ide reloaded the project, again without dependencies, so error markers appeared) # I did a build in the IDE, then the dependencies got resolved, and the project seems to be healthy. So I did not have to leave the IDE to fix the issues, however, I see that something is not happening. > Reload of dependencies in a gradle project always fails. > > > Key: NETBEANS-3385 > URL: https://issues.apache.org/jira/browse/NETBEANS-3385 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 11.2 >Reporter: Andrea Paternesi >Assignee: Laszlo Kishalmi >Priority: Major > Attachments: test-gradle-netbeans.tgz > > > When the project tries to reload dependencies for some strange reason it > stops and never download any file. > You are forced to open a shell and force the reload of dependencies by hand > using "./gradlew clean build". > After that you can "clean and build" also in netbeans and then the project > returns to compile without problems. > This bug coupled with this one > https://issues.apache.org/jira/browse/NETBEANS-2960 makes the ide basically > very hard to use with gradle. > Thanks for any patch you can provide. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-3411) Recognize Kotlin based buildscripts fot Gradle
Laszlo Kishalmi created NETBEANS-3411: - Summary: Recognize Kotlin based buildscripts fot Gradle Key: NETBEANS-3411 URL: https://issues.apache.org/jira/browse/NETBEANS-3411 Project: NetBeans Issue Type: Improvement Components: projects - Gradle Reporter: Laszlo Kishalmi Assignee: Laszlo Kishalmi -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3056) nb freezes and it is ferquent , close and open again is not fixig it
[ https://issues.apache.org/jira/browse/NETBEANS-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977547#comment-16977547 ] Laszlo Kishalmi commented on NETBEANS-3056: --- Has the 11.2 upgrade solved this issue? > nb freezes and it is ferquent , close and open again is not fixig it > > > Key: NETBEANS-3056 > URL: https://issues.apache.org/jira/browse/NETBEANS-3056 > Project: NetBeans > Issue Type: Bug > Environment: ubuntu 18.04 lts >Reporter: mohamed omar >Priority: Major > > log > --- > >Log Session: Tuesday, September 3, 2019 at 3:22:38 AM Eastern European > >Standard Time > >System Info: > Product Version = Apache NetBeans IDE 11.1 > Operating System = Linux version 4.15.0-58-generic running on amd64 > Java; VM; Vendor = 11.0.4; OpenJDK 64-Bit Server VM > 11.0.4+11-post-Ubuntu-1ubuntu218.04.3; Ubuntu > Runtime = OpenJDK Runtime Environment 11.0.4+11-post-Ubuntu-1ubuntu218.04.3 > Java Home = /usr/lib/jvm/java-11-openjdk-amd64 > System Locale; Encoding = en_US (nb); UTF-8 > Home Directory = /home/m7md > Current Directory = /home/m7md > User Directory = /home/m7md/snap/netbeans/common/data/11.1 > Cache Directory = /home/m7md/snap/netbeans/common/cache/11.1 > Installation = /snap/netbeans/10/netbeans/nb > /snap/netbeans/10/netbeans/ergonomics > /snap/netbeans/10/netbeans/ide > /snap/netbeans/10/netbeans/extide > /snap/netbeans/10/netbeans/java > /snap/netbeans/10/netbeans/apisupport > /snap/netbeans/10/netbeans/webcommon > /snap/netbeans/10/netbeans/websvccommon > /snap/netbeans/10/netbeans/enterprise > /snap/netbeans/10/netbeans/profiler > /snap/netbeans/10/netbeans/php > /snap/netbeans/10/netbeans/harness > /snap/netbeans/10/netbeans/groovy > /snap/netbeans/10/netbeans/extra > /snap/netbeans/10/netbeans/javafx > /snap/netbeans/10/netbeans/platform > Boot & Ext. Classpath = > Application Classpath = > /snap/netbeans/10/netbeans/platform/lib/boot.jar:/snap/netbeans/10/netbeans/platform/lib/org-openide-modules.jar:/snap/netbeans/10/netbeans/platform/lib/org-openide-util.jar:/snap/netbeans/10/netbeans/platform/lib/org-openide-util-lookup.jar:/snap/netbeans/10/netbeans/platform/lib/org-openide-util-ui.jar > Startup Classpath = > /snap/netbeans/10/netbeans/platform/core/asm-all-5.0.1.jar:/snap/netbeans/10/netbeans/platform/core/core-base.jar:/snap/netbeans/10/netbeans/platform/core/core.jar:/snap/netbeans/10/netbeans/platform/core/org-netbeans-libs-asm.jar:/snap/netbeans/10/netbeans/platform/core/org-openide-filesystems-compat8.jar:/snap/netbeans/10/netbeans/platform/core/org-openide-filesystems.jar:/snap/netbeans/10/netbeans/nb/core/org-netbeans-upgrader.jar:/snap/netbeans/10/netbeans/nb/core/locale/core_nb.jar > --- > INFO [org.netbeans.modules.netbinox]: Install area set to > file:/snap/netbeans/10/netbeans/ > WARNING [org.netbeans.core.modules]: the modules > [org.netbeans.modules.java.editor.lib, org.netbeans.modules.xml.text] use > org.netbeans.modules.editor.deprecated.pre65formatting which is deprecated. > WARNING [org.netbeans.core.modules]: the modules > [org.netbeans.modules.ide.kit, org.netbeans.modules.xml.text] use > org.netbeans.modules.editor.structure which is deprecated. > WARNING [org.netbeans.core.modules]: the modules > [org.netbeans.modules.java.hints, org.netbeans.modules.jshell.support, > org.netbeans.modules.maven.hints] use > org.netbeans.modules.java.hints.legacy.spi which is deprecated: Use Java > Hints SPI (org.netbeans.spi.java.hints) instead. > WARNING [org.openide.filesystems.Ordering]: Found same position 127 for both > Services/MIMEResolver/org-netbeans-modules-javascript-nodejs-file-PackageLockJsonDataObject-Registration.xml > and > Services/MIMEResolver/org-netbeans-modules-javascript-nodejs-file-NpmDebugLogDataObject-Registration.xml > WARNING [org.openide.filesystems.Ordering]: Found same position 127 for both > Services/MIMEResolver/org-netbeans-modules-javascript-nodejs-file-PackageLockJsonDataObject-Registration.xml > and > Services/MIMEResolver/org-netbeans-modules-javascript-nodejs-file-PackageJsonDataObject-Registration.xml > WARNING [org.openide.filesystems.Ordering]: Found same position 127 for both > Services/MIMEResolver/org-netbeans-modules-javascript-nodejs-file-NpmDebugLogDataObject-Registration.xml > and > Services/MIMEResolver/org-netbeans-modules-javascript-nodejs-file-PackageJsonDataObject-Registration.xml > WARNING [org.openide.filesystems.Ordering]: Not all children in > Services/MIMEResolver/ marked with the position attribute: > [draganbjedov-netbeans-csv-dataobject-CSVDataObject-Extension.xml, >
[jira] [Created] (NETBEANS-3410) MIssing "Go to Implementation" keymap shortcut
Jarek created NETBEANS-3410: --- Summary: MIssing "Go to Implementation" keymap shortcut Key: NETBEANS-3410 URL: https://issues.apache.org/jira/browse/NETBEANS-3410 Project: NetBeans Issue Type: Improvement Components: cnd - Navigation Affects Versions: 11.2 Environment: Linux Mint 18.3 Sylvia 64-bit Kernel Linux 4.15.0-70-generic x86_64 MATE 1.18.0 Reporter: Jarek Attachments: Screenshot at 2019-11-19 10-45-27.png Missing helpfull "Go to Implementation" action on Options -> keymap in NB 11.2 Profile NetBeans 5.5, Netbeans. Now it is only possible to call from context (rmb) menu. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-3409) Missing popup menu for sql editor tabs
Aldo Brucale created NETBEANS-3409:
--
Summary: Missing popup menu for sql editor tabs
Key: NETBEANS-3409
URL: https://issues.apache.org/jira/browse/NETBEANS-3409
Project: NetBeans
Issue Type: Bug
Components: db - SQL Editor
Affects Versions: 11.2
Reporter: Aldo Brucale
Clicking on a SQL Editor tab causes this exception, and the popup menu is not
shown.
{noformat}
java.lang.AbstractMethodError: Missing implementation of resolved method
'abstract org.openide.util.actions.SystemAction[] getActions()' of abstract
class org.openide.filesystems.FileSystemCompat.
at
org.openide.filesystems.FileSystemCompat.getActions(FileSystemCompat.java:79)
at
org.openide.filesystems.MultiFileSystemCompat.getActions(MultiFileSystemCompat.java:71)
at
org.openide.filesystems.MultiFileSystemCompat.getActions(MultiFileSystemCompat.java:71)
at
org.openide.filesystems.CompatFileExtrasLkp.beforeLookup(CompatFileExtrasLkp.java:58)
at
org.openide.util.lookup.AbstractLookup$R.allInstances(AbstractLookup.java:1014)
at
org.openide.util.lookup.AbstractLookup$R.allInstances(AbstractLookup.java:1010)
at org.openide.util.Lookup.lookupAll(Lookup.java:287)
at
org.openide.actions.FileSystemAction.createMenu(FileSystemAction.java:127)
at
org.openide.actions.FileSystemAction$Menu.(FileSystemAction.java:244)
at
org.openide.actions.FileSystemAction$DelegateAction.getPopupPresenter(FileSystemAction.java:333)
at org.openide.util.Utilities.actionsToPopup(Utilities.java:1704)
at
org.netbeans.core.windows.view.ui.TabbedHandler.handlePopupMenuShowing(TabbedHandler.java:439)
at
org.netbeans.core.windows.view.ui.TabbedHandler.actionPerformed(TabbedHandler.java:320)
at
org.netbeans.swing.tabcontrol.TabbedContainer.postActionEvent(TabbedContainer.java:705)
at
org.netbeans.swing.tabcontrol.TabbedContainerUI.shouldPerformAction(TabbedContainerUI.java:140)
at
org.netbeans.swing.tabcontrol.plaf.DefaultTabbedContainerUI.access$2700(DefaultTabbedContainerUI.java:87)
at
org.netbeans.swing.tabcontrol.plaf.DefaultTabbedContainerUI$DisplayerActionListener.actionPerformed(DefaultTabbedContainerUI.java:1261)
at
org.netbeans.swing.tabcontrol.TabDisplayer.postActionEvent(TabDisplayer.java:589)
at
org.netbeans.swing.tabcontrol.TabDisplayerUI.shouldPerformAction(TabDisplayerUI.java:168)
at
org.netbeans.swing.tabcontrol.plaf.BasicTabDisplayerUI.access$1700(BasicTabDisplayerUI.java:96)
at
org.netbeans.swing.tabcontrol.plaf.BasicTabDisplayerUI$BasicDisplayerMouseListener.performCommand(BasicTabDisplayerUI.java:757)
at
org.netbeans.swing.tabcontrol.plaf.BasicTabDisplayerUI$BasicDisplayerMouseListener.potentialCommand(BasicTabDisplayerUI.java:733)
at
org.netbeans.swing.tabcontrol.plaf.BasicTabDisplayerUI$BasicDisplayerMouseListener.mousePressed(BasicTabDisplayerUI.java:717)
at
java.desktop/java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:287)
at
java.desktop/java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:287)
at
java.desktop/java.awt.Component.processMouseEvent(Component.java:6633)
at
java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3342)
at java.desktop/java.awt.Component.processEvent(Component.java:6401)
at java.desktop/java.awt.Container.processEvent(Container.java:2263)
at
java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5012)
at
java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
at java.desktop/java.awt.Component.dispatchEvent(Component.java:4844)
at
java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4918)
at
java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4544)
at
java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4488)
at
java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2762)
at java.desktop/java.awt.Component.dispatchEvent(Component.java:4844)
at
java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
at
java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
at
java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
at
java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
at
