[netbeans] branch master updated: [TRAVIS] Remove timeouts for platform/api.htmlui tests (#1700)

2019-11-29 Thread matthiasblaesing
This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 1994f5b  [TRAVIS] Remove timeouts for platform/api.htmlui tests (#1700)
1994f5b is described below

commit 1994f5b9f8dada5fe1929086a67c3cab0442fa33
Author: hectorespert 
AuthorDate: Sat Nov 30 08:06:43 2019 +0100

[TRAVIS] Remove timeouts for platform/api.htmlui tests (#1700)

* Retry platform/api.htmlui tests
* Remove timeouts for api/htmlui tests
---
 .travis.yml   | 2 +-
 .../unit/src/org/netbeans/api/htmlui/HTMLViewProcessorTest.java   | 1 -
 .../test/unit/src/org/netbeans/modules/htmlui/ComponentsTest.java | 4 ++--
 .../test/unit/src/org/netbeans/modules/htmlui/DialogsTest.java| 6 +++---
 .../unit/src/org/netbeans/modules/htmlui/HtmlComponentTest.java   | 8 
 .../src/org/netbeans/modules/htmlui/OpenHTMLRegistrationTest.java | 2 +-
 .../src/org/netbeans/modules/htmlui/ShowDialogFromEDTTest.java| 2 +-
 .../org/netbeans/modules/htmlui/ShowDialogFromFXThreadTest.java   | 4 ++--
 8 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 797a36a..6a93d91 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -103,7 +103,7 @@ matrix:
 - ant $OPTS clean
 - ant $OPTS build
   script:
-- hide-logs.sh ant -Dcluster.config=platform 
-Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true -Dvanilla.javac.exists=true -f 
platform/api.htmlui test
+- hide-logs.sh ant $OPTS -f platform/api.htmlui test
 - hide-logs.sh ant $OPTS -f platform/api.intent test
 - hide-logs.sh ant $OPTS -f platform/api.io test
 - hide-logs.sh ant $OPTS -f platform/api.progress test
diff --git 
a/platform/api.htmlui/test/unit/src/org/netbeans/api/htmlui/HTMLViewProcessorTest.java
 
b/platform/api.htmlui/test/unit/src/org/netbeans/api/htmlui/HTMLViewProcessorTest.java
index 862ce5c..6269b4f 100644
--- 
a/platform/api.htmlui/test/unit/src/org/netbeans/api/htmlui/HTMLViewProcessorTest.java
+++ 
b/platform/api.htmlui/test/unit/src/org/netbeans/api/htmlui/HTMLViewProcessorTest.java
@@ -18,7 +18,6 @@
  */
 package org.netbeans.api.htmlui;
 
-import java.io.IOException;
 import java.util.Locale;
 import javax.tools.Diagnostic;
 import javax.tools.JavaFileObject;
diff --git 
a/platform/api.htmlui/test/unit/src/org/netbeans/modules/htmlui/ComponentsTest.java
 
b/platform/api.htmlui/test/unit/src/org/netbeans/modules/htmlui/ComponentsTest.java
index 65cdc51..fde6139 100644
--- 
a/platform/api.htmlui/test/unit/src/org/netbeans/modules/htmlui/ComponentsTest.java
+++ 
b/platform/api.htmlui/test/unit/src/org/netbeans/modules/htmlui/ComponentsTest.java
@@ -45,7 +45,7 @@ public class ComponentsTest {
 NbResloc.init();
 }
 
-@Test(timeOut = 9000)
+@Test
 public void loadSwing() throws Exception {
 CountDownLatch cdl = new CountDownLatch(1);
 JComponent p = TestPages.getSwing(10, cdl);
@@ -56,7 +56,7 @@ public class ComponentsTest {
 cdl.await();
 }
 
-@Test(timeOut = 9000)
+@Test
 public void loadFX() throws Exception {
 final CountDownLatch cdl = new CountDownLatch(1);
 final CountDownLatch done = new CountDownLatch(1);
diff --git 
a/platform/api.htmlui/test/unit/src/org/netbeans/modules/htmlui/DialogsTest.java
 
b/platform/api.htmlui/test/unit/src/org/netbeans/modules/htmlui/DialogsTest.java
index aeabeca..c947db4 100644
--- 
a/platform/api.htmlui/test/unit/src/org/netbeans/modules/htmlui/DialogsTest.java
+++ 
b/platform/api.htmlui/test/unit/src/org/netbeans/modules/htmlui/DialogsTest.java
@@ -45,7 +45,7 @@ public class DialogsTest {
 public DialogsTest() {
 }
 
-@BeforeClass(timeOut = 9000)
+@BeforeClass
 public static void initializeContext() throws Exception {
 final JFXPanel p = new JFXPanel();
 final URL u = 
DialogsTest.class.getResource("/org/netbeans/api/htmlui/empty.html");
@@ -71,7 +71,7 @@ public class DialogsTest {
 f.setVisible(true);
 }
 
-@Test(timeOut = 9000)
+@Test
 public void parseButtons() throws Throwable {
 final Throwable[] ex = { null };
 final JButton[] buttons = { null, null };
@@ -123,7 +123,7 @@ public class DialogsTest {
 });
 }
 
-@Test(timeOut = 9000)
+@Test
 public void noDefinedButtonsMeanOKCancel() throws Throwable {
 final Throwable[] ex = { null };
 final CountDownLatch done = new CountDownLatch(1);
diff --git 
a/platform/api.htmlui/test/unit/src/org/netbeans/modules/htmlui/HtmlComponentTest.java
 
b/platform/api.htmlui/test/unit/src/org/netbeans/modules/htmlui/HtmlComponentTest.java
index 11e13f9..fe57aac 10

[jira] [Updated] (NETBEANS-3498) Cannot add unimplemented methods to anonymous innerclasses

2019-11-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-3498:
-
Labels: pull-request-available  (was: )

> Cannot add unimplemented methods to anonymous innerclasses
> --
>
> Key: NETBEANS-3498
> URL: https://issues.apache.org/jira/browse/NETBEANS-3498
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Source
>Affects Versions: 11.2
>Reporter: Jan Lahoda
>Assignee: Jan Lahoda
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.3
>
>
> Consider code like this:
> ---
> public class Test2 {
> public static void main(String[] args) {
>  Comparator c = new Comparator() {
>  };
>  }
>  
> }
> 
>  
> There is a method missing in the anonymous class, but an attempt to add it 
> using the error fix leads to:
> ---
> java.lang.NullPointerException
>  at 
> org.netbeans.api.java.source.ElementUtilities.findUnimplementedMethods(ElementUtilities.java:904)
>  at 
> org.netbeans.api.java.source.ElementUtilities.findUnimplementedMethods(ElementUtilities.java:665)
>  at 
> org.netbeans.modules.java.editor.codegen.ImplementOverrideMethodGenerator.getImplementDescriptions(ImplementOverrideMethodGenerator.java:218)
>  at 
> org.netbeans.modules.java.editor.codegen.ImplementOverrideMethodGenerator.selectMethodsToImplement(ImplementOverrideMethodGenerator.java:145)
>  at 
> org.netbeans.modules.java.hints.errors.ImplementAllAbstractMethods$ImplementFixBase$1.run(ImplementAllAbstractMethods.java:320)
>  at 
> org.netbeans.modules.java.hints.errors.ImplementAllAbstractMethods$ImplementFixBase$1.run(ImplementAllAbstractMethods.java:316)
>  at org.netbeans.api.java.source.JavaSource$MultiTask.run(JavaSource.java:502)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
>  at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
>  at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
>  at 
> org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
>  at 
> org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
>  at 
> org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
>  at 
> org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
>  at 
> org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
>  at 
> org.netbeans.api.java.source.JavaSource.runUserActionTaskImpl(JavaSource.java:452)
>  at 
> org.netbeans.api.java.source.JavaSource.runUserActionTask(JavaSource.java:423)
>  at 
> org.netbeans.modules.java.hints.errors.ImplementAllAbstractMethods$ImplementFixBase.implement(ImplementAllAbstractMethods.java:316)
> [catch] at org.netbeans.modules.editor.hints.HintsUI$1.run(HintsUI.java:810)
>  at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
>  at 
> org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
>  at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
>  at 
> org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)
> ---
>  
> Originally reported here:
> [http://mail-archives.apache.org/mod_mbox/netbeans-users/201911.mbox/%3C2971b37b-5471-2ec8-f52d-28ac2b3e6165%40univ-cotedazur.fr%3E]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-3498) Cannot add unimplemented methods to anonymous innerclasses

2019-11-29 Thread Jan Lahoda (Jira)
Jan Lahoda created NETBEANS-3498:


 Summary: Cannot add unimplemented methods to anonymous innerclasses
 Key: NETBEANS-3498
 URL: https://issues.apache.org/jira/browse/NETBEANS-3498
 Project: NetBeans
  Issue Type: Bug
  Components: java - Source
Affects Versions: 11.2
Reporter: Jan Lahoda
Assignee: Jan Lahoda
 Fix For: 11.3


Consider code like this:

---

public class Test2 {

public static void main(String[] args) {
 Comparator c = new Comparator() {
 };
 }
 
}



 

There is a method missing in the anonymous class, but an attempt to add it 
using the error fix leads to:

---

java.lang.NullPointerException
 at 
org.netbeans.api.java.source.ElementUtilities.findUnimplementedMethods(ElementUtilities.java:904)
 at 
org.netbeans.api.java.source.ElementUtilities.findUnimplementedMethods(ElementUtilities.java:665)
 at 
org.netbeans.modules.java.editor.codegen.ImplementOverrideMethodGenerator.getImplementDescriptions(ImplementOverrideMethodGenerator.java:218)
 at 
org.netbeans.modules.java.editor.codegen.ImplementOverrideMethodGenerator.selectMethodsToImplement(ImplementOverrideMethodGenerator.java:145)
 at 
org.netbeans.modules.java.hints.errors.ImplementAllAbstractMethods$ImplementFixBase$1.run(ImplementAllAbstractMethods.java:320)
 at 
org.netbeans.modules.java.hints.errors.ImplementAllAbstractMethods$ImplementFixBase$1.run(ImplementAllAbstractMethods.java:316)
 at org.netbeans.api.java.source.JavaSource$MultiTask.run(JavaSource.java:502)
 at 
org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
 at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
 at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
 at 
org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
 at 
org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
 at 
org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
 at 
org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
 at 
org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
 at org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
 at 
org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
 at org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
 at 
org.netbeans.api.java.source.JavaSource.runUserActionTaskImpl(JavaSource.java:452)
 at 
org.netbeans.api.java.source.JavaSource.runUserActionTask(JavaSource.java:423)
 at 
org.netbeans.modules.java.hints.errors.ImplementAllAbstractMethods$ImplementFixBase.implement(ImplementAllAbstractMethods.java:316)
[catch] at org.netbeans.modules.editor.hints.HintsUI$1.run(HintsUI.java:810)
 at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
 at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
 at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
 at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)

---

 

Originally reported here:

[http://mail-archives.apache.org/mod_mbox/netbeans-users/201911.mbox/%3C2971b37b-5471-2ec8-f52d-28ac2b3e6165%40univ-cotedazur.fr%3E]

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3497) Allow custom LaF-s to prefer editor profile on switch.

2019-11-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-3497:
-
Labels: pull-request-available  (was: )

> Allow custom LaF-s to prefer editor profile on switch.
> --
>
> Key: NETBEANS-3497
> URL: https://issues.apache.org/jira/browse/NETBEANS-3497
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Window System
>Reporter: Laszlo Kishalmi
>Assignee: Laszlo Kishalmi
>Priority: Major
>  Labels: pull-request-available
>
> The current LaF panel offers to change the editor color profile to Norway 
> Today for dark look and feels. That might be good for Dark Metal and Dark 
> Nimbus, however it would be better if the preferred theme can be described 
> inside the Look and Feel itself by specifying the
> "nb.preferred.color.profile" property in its UIDefaults.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-3440) Allow to define a palette for editor color schemes.

2019-11-29 Thread Laszlo Kishalmi (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Kishalmi resolved NETBEANS-3440.
---
Fix Version/s: 11.3
   Resolution: Implemented

> Allow to define a palette for editor color schemes.
> ---
>
> Key: NETBEANS-3440
> URL: https://issues.apache.org/jira/browse/NETBEANS-3440
> Project: NetBeans
>  Issue Type: Improvement
>  Components: editor - Settings
>Reporter: Laszlo Kishalmi
>Assignee: Laszlo Kishalmi
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.3
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Motivation: I was looking for porting [Gruvbox color 
> scheme|https://github.com/morhetz/gruvbox] to the Editor. It defines a 
> palette with colors for light and dark schemes. Then the specific colors are 
> using palette references. As I've checked the editor settings does not 
> support custom palette, only a handful basic colors are defined by default.
> I though it would be easy and sufficient to enrich the XML schema to support 
> some color reference mapping.
> It is not goal to keep the defined palette on exporting the color scheme.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-3474) Add Dark LaF and Flatlaf to the Core RCP Platform

2019-11-29 Thread Laszlo Kishalmi (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Kishalmi resolved NETBEANS-3474.
---
Fix Version/s: 11.3
   Resolution: Fixed

> Add Dark LaF and Flatlaf to the Core RCP Platform
> -
>
> Key: NETBEANS-3474
> URL: https://issues.apache.org/jira/browse/NETBEANS-3474
> Project: NetBeans
>  Issue Type: Task
>Reporter: Laszlo Kishalmi
>Assignee: Laszlo Kishalmi
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.3
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> As a final act the two new LaF modules needs to be added to the core RPC 
> platform.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-3497) Allow custom LaF-s to prefer editor profile on switch.

2019-11-29 Thread Laszlo Kishalmi (Jira)
Laszlo Kishalmi created NETBEANS-3497:
-

 Summary: Allow custom LaF-s to prefer editor profile on switch.
 Key: NETBEANS-3497
 URL: https://issues.apache.org/jira/browse/NETBEANS-3497
 Project: NetBeans
  Issue Type: Improvement
  Components: platform - Window System
Reporter: Laszlo Kishalmi
Assignee: Laszlo Kishalmi


The current LaF panel offers to change the editor color profile to Norway Today 
for dark look and feels. That might be good for Dark Metal and Dark Nimbus, 
however it would be better if the preferred theme can be described inside the 
Look and Feel itself by specifying the

"nb.preferred.color.profile" property in its UIDefaults.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3428) Add Support for FlatLaf in the Platform

2019-11-29 Thread Laszlo Kishalmi (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Kishalmi updated NETBEANS-3428:
--
Fix Version/s: 11.3

> Add Support for FlatLaf in the Platform
> ---
>
> Key: NETBEANS-3428
> URL: https://issues.apache.org/jira/browse/NETBEANS-3428
> Project: NetBeans
>  Issue Type: Wish
>Reporter: Laszlo Kishalmi
>Assignee: Laszlo Kishalmi
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.3
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-3428) Add Support for FlatLaf in the Platform

2019-11-29 Thread Laszlo Kishalmi (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Kishalmi resolved NETBEANS-3428.
---
Resolution: Implemented

> Add Support for FlatLaf in the Platform
> ---
>
> Key: NETBEANS-3428
> URL: https://issues.apache.org/jira/browse/NETBEANS-3428
> Project: NetBeans
>  Issue Type: Wish
>Reporter: Laszlo Kishalmi
>Assignee: Laszlo Kishalmi
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated (cd54bb5 -> 4b81956)

2019-11-29 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git.


from cd54bb5  Merge pull request #1686 from 
BradWalker/cleanup_all_redundant_casts
 new 4d86329  [NETBEANS-3428] Upgraded and moved flatlaf to a library 
wrapper project.
 new 442168d  Changed Flatlaf module name org.netbeans.swing.flatlaf -> 
org.netbeans.swing.laf.flatlaf
 new 4b81956  Merge pull request #1699 from lkishalmi/NETBEANS-3428-lib

The 3185 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 nbbuild/cluster.properties|  3 ++-
 platform/core.kit/nbproject/project.xml   | 10 +-
 .../{o.n.swing.flatlaf => libs.flatlaf}/build.xml |  2 +-
 .../external/binaries-list|  2 +-
 .../external/flatlaf-0.20-license.txt}|  4 ++--
 platform/libs.flatlaf/manifest.mf |  6 ++
 .../nbproject/project.properties  |  3 ++-
 .../build.xml => libs.flatlaf/nbproject/project.xml}  | 19 +++
 .../src/org/netbeans/libs}/flatlaf/Bundle.properties  |  8 
 platform/o.n.swing.flatlaf/manifest.mf|  7 ---
 .../build.xml |  2 +-
 platform/o.n.swing.laf.flatlaf/manifest.mf|  7 +++
 .../nbproject/project.properties  |  2 --
 .../nbproject/project.xml | 14 +-
 .../org/netbeans/swing/laf}/flatlaf/Bundle.properties |  4 ++--
 .../org/netbeans/swing/laf}/flatlaf/Installer.java|  2 +-
 .../netbeans/swing/laf}/flatlaf/NbFlatDarkLaf.java|  2 +-
 17 files changed, 59 insertions(+), 38 deletions(-)
 copy platform/{o.n.swing.flatlaf => libs.flatlaf}/build.xml (92%)
 rename platform/{o.n.swing.flatlaf => libs.flatlaf}/external/binaries-list 
(92%)
 rename platform/{o.n.swing.flatlaf/external/flatlaf-0.18-license.txt => 
libs.flatlaf/external/flatlaf-0.20-license.txt} (99%)
 create mode 100644 platform/libs.flatlaf/manifest.mf
 copy platform/{o.n.swing.flatlaf => libs.flatlaf}/nbproject/project.properties 
(90%)
 copy platform/{o.n.swing.flatlaf/build.xml => 
libs.flatlaf/nbproject/project.xml} (55%)
 copy platform/{o.n.swing.flatlaf/src/org/netbeans/swing => 
libs.flatlaf/src/org/netbeans/libs}/flatlaf/Bundle.properties (80%)
 delete mode 100644 platform/o.n.swing.flatlaf/manifest.mf
 rename platform/{o.n.swing.flatlaf => o.n.swing.laf.flatlaf}/build.xml (92%)
 create mode 100644 platform/o.n.swing.laf.flatlaf/manifest.mf
 rename platform/{o.n.swing.flatlaf => 
o.n.swing.laf.flatlaf}/nbproject/project.properties (92%)
 rename platform/{o.n.swing.flatlaf => 
o.n.swing.laf.flatlaf}/nbproject/project.xml (83%)
 rename platform/{o.n.swing.flatlaf/src/org/netbeans/swing => 
o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf}/flatlaf/Bundle.properties 
(89%)
 rename platform/{o.n.swing.flatlaf/src/org/netbeans/swing => 
o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf}/flatlaf/Installer.java (97%)
 rename platform/{o.n.swing.flatlaf/src/org/netbeans/swing => 
o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf}/flatlaf/NbFlatDarkLaf.java 
(96%)


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3496) NPE on navigate-to-class

2019-11-29 Thread Shevek (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985186#comment-16985186
 ] 

Shevek commented on NETBEANS-3496:
--

Note that:
1. this is a multi-project gradle project,
2. the indexer recognized the target class name, and
3. the subproject containing the target class was NOT open.

> NPE on navigate-to-class
> 
>
> Key: NETBEANS-3496
> URL: https://issues.apache.org/jira/browse/NETBEANS-3496
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 11.1
>Reporter: Shevek
>Priority: Major
>
> Press ^1, ^O, type *Foo*Task, get this, and no class:
> java.lang.NullPointerException
>   at 
> org.netbeans.modules.java.source.pretty.ImportAnalysis2.getPackageOf(ImportAnalysis2.java:393)
>   at 
> org.netbeans.modules.java.source.pretty.ImportAnalysis2.resolveImport(ImportAnalysis2.java:310)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitMemberSelect(ImmutableTreeTranslator.java:475)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitMemberSelect(ImmutableTreeTranslator.java:74)
>   at 
> com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2203)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:123)
>   at 
> org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:871)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translateClassRef(ImmutableTreeTranslator.java:135)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.rewriteChildren(ImmutableTreeTranslator.java:593)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitClass(ImmutableTreeTranslator.java:335)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitClass(ImmutableTreeTranslator.java:74)
>   at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:818)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:123)
>   at 
> org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:871)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:198)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.rewriteChildren(ImmutableTreeTranslator.java:545)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitCompilationUnit(ImmutableTreeTranslator.java:322)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitCompilationUnit(ImmutableTreeTranslator.java:74)
>   at 
> com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:599)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:123)
>   at 
> org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:871)
>   at 
> org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:867)
>   at 
> org.netbeans.api.java.source.WorkingCopy.processCurrentCompilationUnit(WorkingCopy.java:899)
>   at 
> org.netbeans.api.java.source.WorkingCopy.getChanges(WorkingCopy.java:1326)
>   at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:676)
>   at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:663)
>   at 
> org.netbeans.api.java.source.JavaSource$MultiTask.run(JavaSource.java:502)
>   at 
> org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
>   at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
>   at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
>   at 
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
>   at 
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
>   at 
> org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
>   at 
> org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
>   at 
> org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
>   at 
> org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
>   at 
> org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
>   at 
> org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
>   at 
> org.netbeans.api.java.source.JavaSource.runUserActionTaskImpl(JavaSource.java:452)
>   at 

[jira] [Created] (NETBEANS-3496) NPE on navigate-to-class

2019-11-29 Thread Shevek (Jira)
Shevek created NETBEANS-3496:


 Summary: NPE on navigate-to-class
 Key: NETBEANS-3496
 URL: https://issues.apache.org/jira/browse/NETBEANS-3496
 Project: NetBeans
  Issue Type: Bug
Affects Versions: 11.1
Reporter: Shevek


Press ^1, ^O, type *Foo*Task, get this, and no class:

java.lang.NullPointerException
at 
org.netbeans.modules.java.source.pretty.ImportAnalysis2.getPackageOf(ImportAnalysis2.java:393)
at 
org.netbeans.modules.java.source.pretty.ImportAnalysis2.resolveImport(ImportAnalysis2.java:310)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitMemberSelect(ImmutableTreeTranslator.java:475)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitMemberSelect(ImmutableTreeTranslator.java:74)
at 
com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2203)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:123)
at 
org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:871)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translateClassRef(ImmutableTreeTranslator.java:135)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.rewriteChildren(ImmutableTreeTranslator.java:593)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitClass(ImmutableTreeTranslator.java:335)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitClass(ImmutableTreeTranslator.java:74)
at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:818)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:123)
at 
org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:871)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:198)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.rewriteChildren(ImmutableTreeTranslator.java:545)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitCompilationUnit(ImmutableTreeTranslator.java:322)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitCompilationUnit(ImmutableTreeTranslator.java:74)
at 
com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:599)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:123)
at 
org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:871)
at 
org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:867)
at 
org.netbeans.api.java.source.WorkingCopy.processCurrentCompilationUnit(WorkingCopy.java:899)
at 
org.netbeans.api.java.source.WorkingCopy.getChanges(WorkingCopy.java:1326)
at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:676)
at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:663)
at 
org.netbeans.api.java.source.JavaSource$MultiTask.run(JavaSource.java:502)
at 
org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
at 
org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
at 
org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
at 
org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
at 
org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
at 
org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
at 
org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
at 
org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
at 
org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
at 
org.netbeans.api.java.source.JavaSource.runUserActionTaskImpl(JavaSource.java:452)
at 
org.netbeans.api.java.source.JavaSource.runUserActionTask(JavaSource.java:423)
at 
org.netbeans.api.java.source.JavaSource.runModificationTask(JavaSource.java:684)
at 
org.netbeans.modules.java.classfile.CodeGenerator.generateCode(CodeGenerator.java:152)
at 
org.netbeans.modules.java.classfile.BinaryElementOpenImpl.open(BinaryElementOpenImpl.java:44)
at 
org.netbeans.api.java.source.ui.ElementOpen.binaryOpen(ElementOpen.java:118)
  

[jira] [Created] (NETBEANS-3495) Code Assistance adds

2019-11-29 Thread Mrugendra Deshpande (Jira)
Mrugendra Deshpande created NETBEANS-3495:
-

 Summary: Code Assistance adds 
 Key: NETBEANS-3495
 URL: https://issues.apache.org/jira/browse/NETBEANS-3495
 Project: NetBeans
  Issue Type: Bug
  Components: cnd - Code Completion
Affects Versions: 11.1, 8.2, 11.2
 Environment: Netbeans 11.2, Windows 10, MacOS 10.15.1
Reporter: Mrugendra Deshpande
 Attachments: Netbeans - Tool Chain.PNG

When we add a new Tool Collection from a custom location

for me it was from /usr/local/gcc-9.2.0, there is a redundant (extra 
/usr/local/gcc9.2.0) path gets added to the default paths in the "includes".

This affects the Code Assistance - it obviously fails to find the correct 
include files.

And once we correct it, after a restart of the IDE, these paths get added again 
when we click on the "Fix Code Assistance" prompt.

This happens in both Windows and Mac Environments



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-3476] - cleanup redundant casts..

2019-11-29 Thread matthiasblaesing
This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 3f36a44  [NETBEANS-3476] - cleanup redundant casts..
 new cd54bb5  Merge pull request #1686 from 
BradWalker/cleanup_all_redundant_casts
3f36a44 is described below

commit 3f36a44b713b253e78df4d7d455ec646e17e89a1
Author: Brad Walker 
AuthorDate: Wed Nov 27 14:06:23 2019 -0700

[NETBEANS-3476] - cleanup redundant casts..

There are a lot of places where the compiler tells us we are using 
redundant casts..

   [repeat] 
/home/bwalker/src/netbeans/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/parser/GroovyVirtualSourceProvider.java:436:
 warning: [cast] redundant cast to Statement
   [repeat] Statement stat = (Statement) stats.get(0);
   [repeat]  ^

This change removes all the redundant casts..
---
 .../netbeans/modules/glassfish/common/CommonServerSupport.java |  3 +--
 .../modules/glassfish/tooling/utils/StringPrefixTree.java  |  2 +-
 .../javaee/project/api/PersistenceProviderSupplierImpl.java|  2 +-
 .../javaee/project/api/ant/ui/J2EEProjectProperties.java   |  2 +-
 .../api/ant/ui/logicalview/AbstractLogicalViewProvider.java|  2 +-
 .../project/api/ant/ui/wizard/ProjectServerWizardPanel.java|  2 +-
 .../src/org/netbeans/modules/maven/j2ee/JPAStuffImpl.java  |  2 +-
 .../netbeans/modules/payara/common/CommonServerSupport.java|  3 +--
 .../src/org/netbeans/modules/payara/common/ui/IpComboBox.java  |  3 +--
 .../modules/payara/eecommon/dd/wizard/PayaraDDVisualPanel.java |  2 +-
 .../modules/payara/jakartaee/ResourceRegistrationHelper.java   |  2 +-
 .../modules/payara/jakartaee/verifier/VerifierImpl.java|  2 +-
 .../modules/payara/tooling/utils/StringPrefixTree.java |  2 +-
 .../src/org/netbeans/modules/web/el/ELTypeUtilities.java   |  2 +-
 .../src/org/netbeans/modules/web/jsf/JSFConfigDataObject.java  |  2 +-
 .../org/netbeans/modules/web/jsf/JSFConfigEditorSupport.java   |  2 +-
 .../modules/web/jsf/wizards/JSFConfigurationPanelVisual.java   |  2 +-
 .../netbeans/modules/websvc/manager/model/WebServiceGroup.java |  8 
 .../modules/websvc/manager/model/WebServiceListModel.java  |  2 +-
 .../modules/websvc/manager/ui/TestWebServiceMethodDlg.java |  2 +-
 .../modules/gradle/test/GradleTestProgressListener.java|  2 +-
 .../org/netbeans/modules/groovy/editor/api/GroovyIndexer.java  |  2 +-
 .../groovy/editor/api/parser/GroovyVirtualSourceProvider.java  |  2 +-
 .../support/debug/GroovyToggleBreakpointActionProvider.java|  2 +-
 .../org/netbeans/jellytools/actions/MaximizeWindowAction.java  |  2 +-
 .../properties/editors/ClasspathCustomEditorOperator.java  |  2 +-
 .../src/org/netbeans/spi/xml/cookies/DataObjectAdapters.java   |  2 +-
 ide/api.xml/src/org/netbeans/api/xml/services/UserCatalog.java |  2 +-
 .../netbeans/modules/css/editor/module/PropertiesReader.java   |  2 +-
 .../src/org/netbeans/modules/css/visual/CreateRulePanel.java   |  2 +-
 .../src/org/netbeans/modules/db/explorer/DbDriverManager.java  |  4 ++--
 .../nativeexecution/ui/AuthenticationSettingsPanel.java|  2 +-
 .../modules/nativeexecution/support/Win32APISupport.java   |  2 +-
 .../modules/editor/breadcrumbs/BreadCrumbComponent.java|  2 +-
 .../modules/editor/macros/storage/ui/MacrosNamePanel.java  |  2 +-
 .../modules/html/validation/NbValidationTransaction.java   |  3 +--
 .../src/org/netbeans/jellytools/EditorOperator.java|  4 ++--
 .../netbeans/modules/notifications/filter/FilterEditor.java|  2 +-
 .../parsing/impl/indexing/lucene/LayeredDocumentIndex.java |  2 +-
 .../modules/server/ui/wizard/AddServerInstanceWizard.java  |  2 +-
 .../netbeans/modules/server/ui/wizard/ServerWizardVisual.java  |  2 +-
 .../netbeans/modules/debugger/ui/views/debugging/TapPanel.java |  2 +-
 .../netbeans/modules/target/iterator/api/BrowseFolders.java|  3 +--
 .../src/org/netbeans/modules/terminal/ioprovider/Terminal.java |  2 +-
 .../netbeans/modules/terminal/support/OpenInEditorAction.java  |  2 +-
 .../netbeans/modules/xml/catalog/AddCatalogEntryAction.java|  2 +-
 .../src/org/netbeans/modules/xml/catalog/CatalogAction.java|  4 ++--
 .../src/org/netbeans/modules/xml/catalog/CatalogEntryNode.java |  2 +-
 .../src/org/netbeans/modules/xml/catalog/CatalogNode.java  |  2 +-
 .../org/netbeans/modules/xml/multiview/ItemOptionHelper.java   |  2 +-
 .../modules/xml/multiview/XmlMultiViewEditorSupport.java   |  2 +-
 .../netbeans/modules/xml/multiview/XmlMultiViewElement.java|  2 +-
 .../modules/xml/multiview/ui/AbstractDesignEditor.java |  4 ++--
 .../tax/beans/editor/TreeElementAttributeListCustomizer.java   |  2 +-
 ide/xml/src/org/netbean

[netbeans-html4j] branch master updated: Launching the Show.show always on the background

2019-11-29 Thread jtulach
This is an automated email from the ASF dual-hosted git repository.

jtulach pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans-html4j.git


The following commit(s) were added to refs/heads/master by this push:
 new 31d4adc  Launching the Show.show always on the background
31d4adc is described below

commit 31d4adc80587e756be67edd8f12a9958e664acf8
Author: Jaroslav Tulach 
AuthorDate: Fri Nov 29 15:50:31 2019 +0100

Launching the Show.show always on the background
---
 .../html/presenters/browser/ServerTest.java| 69 +++---
 1 file changed, 47 insertions(+), 22 deletions(-)

diff --git 
a/browser/src/test/java/org/netbeans/html/presenters/browser/ServerTest.java 
b/browser/src/test/java/org/netbeans/html/presenters/browser/ServerTest.java
index a127f3c..e3e5274 100644
--- a/browser/src/test/java/org/netbeans/html/presenters/browser/ServerTest.java
+++ b/browser/src/test/java/org/netbeans/html/presenters/browser/ServerTest.java
@@ -18,17 +18,25 @@
  */
 package org.netbeans.html.presenters.browser;
 
-import org.netbeans.html.presenters.browser.Browser;
 import org.netbeans.html.presenters.render.Show;
 import java.io.IOException;
 import java.io.InputStream;
+import java.net.HttpURLConnection;
 import java.net.ServerSocket;
 import java.net.URI;
 import java.net.URL;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
 import net.java.html.boot.BrowserBuilder;
 import net.java.html.js.JavaScriptBody;
 import org.testng.Assert;
 import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNull;
 import static org.testng.Assert.assertTrue;
 import static org.testng.Assert.fail;
 import org.testng.annotations.Test;
@@ -76,7 +84,10 @@ public class ServerTest {
 
 server.close();
 try {
-InputStream unavailable = connect.openStream();
+HttpURLConnection url =  (HttpURLConnection) 
connect.openConnection();
+url.setConnectTimeout(3000);
+url.setReadTimeout(3000);
+InputStream unavailable = url.getInputStream();
 fail("Stream can no longer be opened: " + unavailable);
 } catch (IOException ex) {
 // OK
@@ -105,27 +116,41 @@ public class ServerTest {
 private static native void closeSoon(int ms);
 
 private static void show(URI page) throws IOException {
-IOException one, two;
-try {
-String ui = System.getProperty("os.name").contains("Mac")
-? "Cocoa" : "GTK";
-Show.show(ui, page);
-return;
-} catch (IOException ex) {
-one = ex;
-}
-try {
-Show.show("AWT", page);
-return;
-} catch (IOException ex) {
-two = ex;
-}
+ExecutorService background = Executors.newSingleThreadExecutor();
+Future future = background.submit((Callable) () -> {
+IOException one, two;
+try {
+String ui = System.getProperty("os.name").contains("Mac")
+? "Cocoa" : "GTK";
+Show.show(ui, page);
+return null;
+} catch (IOException ex) {
+one = ex;
+}
+try {
+Show.show("AWT", page);
+return null;
+} catch (IOException ex) {
+two = ex;
+}
+try {
+Show.show(null, page);
+} catch (IOException ex) {
+two.initCause(one);
+ex.initCause(two);
+throw ex;
+}
+return null;
+});
+
 try {
-Show.show(null, page);
-} catch (IOException ex) {
-two.initCause(one);
-ex.initCause(two);
-throw ex;
+Void ignore = future.get(2, TimeUnit.SECONDS);
+assertNull(ignore);
+background.shutdown();
+} catch (InterruptedException | ExecutionException  ex) {
+throw new AssertionError(ex);
+} catch (TimeoutException ex) {
+// OK
 }
 }
 }


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3494) error when creating ejb project

2019-11-29 Thread Aristides Villarreal (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aristides Villarreal updated NETBEANS-3494:
---
Summary: error when creating ejb project  (was: when creating an ejb 
project it generates in the pom.xml file war, instead 
ejb.)

> error when creating ejb project
> ---
>
> Key: NETBEANS-3494
> URL: https://issues.apache.org/jira/browse/NETBEANS-3494
> Project: NetBeans
>  Issue Type: Bug
>  Components: javaee - EJB
>Affects Versions: 11.2
> Environment: ubuntu
>Reporter: Aristides Villarreal
>Priority: Minor
> Fix For: 11.2
>
> Attachments: change.png, pack.png
>
>
> when creating an ejb project it generates in the pom.xml file
> *{color:#FF}war{color}*
> instead
>  *{color:#0747a6}ejb.{color}*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-3494) when creating an ejb project it generates in the pom.xml file war, instead ejb.

2019-11-29 Thread Aristides Villarreal (Jira)
Aristides Villarreal created NETBEANS-3494:
--

 Summary: when creating an ejb project it generates in the pom.xml 
file war, instead ejb.
 Key: NETBEANS-3494
 URL: https://issues.apache.org/jira/browse/NETBEANS-3494
 Project: NetBeans
  Issue Type: Bug
  Components: javaee - EJB
Affects Versions: 11.2
 Environment: ubuntu
Reporter: Aristides Villarreal
 Fix For: 11.2
 Attachments: change.png, pack.png

when creating an ejb project it generates in the pom.xml file

*{color:#FF}war{color}*

instead

 *{color:#0747a6}ejb.{color}*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Closed] (NETBEANS-3493) Crash on Enter key in JSP editor

2019-11-29 Thread Junichi Yamamoto (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Junichi Yamamoto closed NETBEANS-3493.
--
Resolution: Duplicate

This should have been fixed.
You can also test it in a development version: 
https://builds.apache.org/view/M-R/view/NetBeans/job/netbeans-linux/lastSuccessfulBuild/artifact/nbbuild/

Maybe, NetBeans 11.2 should be updated after this vote: 
https://lists.apache.org/thread.html/0e8607fb94bbe5f9e3bc620a3e516a4a4a7c97c1b23f5305731d4ee6@%3Cdev.netbeans.apache.org%3E

> Crash on Enter key in JSP editor
> 
>
> Key: NETBEANS-3493
> URL: https://issues.apache.org/jira/browse/NETBEANS-3493
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 11.2
>Reporter: Stefano Peruzzi
>Priority: Critical
> Attachments: crash.log
>
>
> Opening a somewhat long jsp file in editor, and pressing enter result in a 
> crash.
>  
> Log attached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-3493) Crash on Enter key in JSP editor

2019-11-29 Thread Stefano Peruzzi (Jira)
Stefano Peruzzi created NETBEANS-3493:
-

 Summary: Crash on Enter key in JSP editor
 Key: NETBEANS-3493
 URL: https://issues.apache.org/jira/browse/NETBEANS-3493
 Project: NetBeans
  Issue Type: Bug
Affects Versions: 11.2
Reporter: Stefano Peruzzi
 Attachments: crash.log

Opening a somewhat long jsp file in editor, and pressing enter result in a 
crash.

 

Log attached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Closed] (NETBEANS-3264) Plugin image is not displayed on plugin detail page

2019-11-29 Thread Jan Pirek (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Pirek closed NETBEANS-3264.
---
Fix Version/s: 3.0
   Resolution: Fixed

fix deployed live

> Plugin image is not displayed on plugin detail page
> ---
>
> Key: NETBEANS-3264
> URL: https://issues.apache.org/jira/browse/NETBEANS-3264
> Project: NetBeans
>  Issue Type: Bug
>  Components: updatecenters - Pluginportal
>Affects Versions: 3.0
>Reporter: Jiří Kovalský
>Assignee: Jan Pirek
>Priority: Major
> Fix For: 3.0
>
>
> When I add a new plugin and select some image from my computer as a plugin 
> logo/screenshot before clicking *Save Plugin* button, the image is sent as 
> parameter of POST request but then not displayed on detail page of the plugin.
> *Steps to reproduce:*
>  # Visit [http://netbeans-vm.apache.org/pluginportal/] and sign in.
>  # Click *Add plugin* from toolbar.
>  # Provide _GroupID_ and _ArtifactID_ of your plugin and click *Add Plugin* 
> button.
>  # Set all required plugin properties, click _Browse ..._ button to select 
> some picture from your computer and click *Save Plugin* button.
>  # Wait until your plugin is approved. Then find it on the Plugin Portal home 
> page and click it.
> *Expected:* Plugin detail page is displayed including the picture you have 
> chosen.
> *Actual:* Plugin detail page is displayed but the picture you have chosen is 
> not visible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-3492) Allow admins to edit plugins to NetBeans versions mapping & verifications

2019-11-29 Thread Jira
Jiří Kovalský created NETBEANS-3492:
---

 Summary: Allow admins to edit plugins to NetBeans versions mapping 
& verifications
 Key: NETBEANS-3492
 URL: https://issues.apache.org/jira/browse/NETBEANS-3492
 Project: NetBeans
  Issue Type: Improvement
  Components: updatecenters - Pluginportal
Affects Versions: 3.0
Reporter: Jiří Kovalský


It is important for Plugin Portal administrators to have a UI how to add 
missing or fix incorrect mapping between plugin version(s) and NetBeans 
version(s) and also request/cancel verifications.

*Steps to reproduce:*
 # Login to [http://netbeans-vm.apache.org/pluginportal/] as administrator.
 # Click Admin menu in toolbar and find some plugin e.g. _NB Figletize_ [1]

*Expected:* There is a way to change NetBeans version for the 1.0 version of 
the plugin and it is also possible to remove existing verification and request 
a new one.

*Actual:* You cannot change version mapping and remove/add verification 
requests.

 [1] http://netbeans-vm.apache.org/pluginportal/admin/?search=NB+Figletize



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3264) Plugin image is not displayed on plugin detail page

2019-11-29 Thread Jira


[ 
https://issues.apache.org/jira/browse/NETBEANS-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984893#comment-16984893
 ] 

Jiří Kovalský commented on NETBEANS-3264:
-

Confirmed. Images uploaded during registration of plugins are visible 
immediately after approval. Thanks!

> Plugin image is not displayed on plugin detail page
> ---
>
> Key: NETBEANS-3264
> URL: https://issues.apache.org/jira/browse/NETBEANS-3264
> Project: NetBeans
>  Issue Type: Bug
>  Components: updatecenters - Pluginportal
>Affects Versions: 3.0
>Reporter: Jiří Kovalský
>Assignee: Jan Pirek
>Priority: Major
> Fix For: 3.0
>
>
> When I add a new plugin and select some image from my computer as a plugin 
> logo/screenshot before clicking *Save Plugin* button, the image is sent as 
> parameter of POST request but then not displayed on detail page of the plugin.
> *Steps to reproduce:*
>  # Visit [http://netbeans-vm.apache.org/pluginportal/] and sign in.
>  # Click *Add plugin* from toolbar.
>  # Provide _GroupID_ and _ArtifactID_ of your plugin and click *Add Plugin* 
> button.
>  # Set all required plugin properties, click _Browse ..._ button to select 
> some picture from your computer and click *Save Plugin* button.
>  # Wait until your plugin is approved. Then find it on the Plugin Portal home 
> page and click it.
> *Expected:* Plugin detail page is displayed including the picture you have 
> chosen.
> *Actual:* Plugin detail page is displayed but the picture you have chosen is 
> not visible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans-tools] branch master updated: Fixing order of JS libs loaded, fixing img upload from public registration proces.

2019-11-29 Thread jkovalsky
This is an automated email from the ASF dual-hosted git repository.

jkovalsky pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans-tools.git


The following commit(s) were added to refs/heads/master by this push:
 new 65f5c0f  Fixing order of JS libs loaded, fixing img upload from public 
registration proces.
 new 82aded7  Merge pull request #19 from jpirek/master
65f5c0f is described below

commit 65f5c0fd16e1c189f0c04d75c601304b4c024bb7
Author: Jan Pirek 
AuthorDate: Fri Nov 29 10:51:28 2019 +0100

Fixing order of JS libs loaded, fixing img upload from public registration 
proces.
---
 .../src/Application/Controller/PluginController.php  | 12 ++--
 pp3/module/Application/view/layout/layout.phtml  |  3 +--
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git 
a/pp3/module/Application/src/Application/Controller/PluginController.php 
b/pp3/module/Application/src/Application/Controller/PluginController.php
index fe1db41..dc21426 100644
--- a/pp3/module/Application/src/Application/Controller/PluginController.php
+++ b/pp3/module/Application/src/Application/Controller/PluginController.php
@@ -177,12 +177,6 @@ class PluginController extends AuthenticatedController {
 }
 }
 }
-// save image
-$im = 
$this->handleImgUpload($this->_config['pp3']['catalogSavepath'].'/plugins/'.$plugin->getId());
-if ($im) {
-$plugin->setImage($im);
-}
-
 // categ
 $plugin->removeCategories();
 $this->_pluginRepository->persist($plugin);
@@ -198,6 +192,12 @@ class PluginController extends AuthenticatedController {
 $plugin->addCategory($cat2);
 }
 }
+// save image
+$im = 
$this->handleImgUpload($this->_config['pp3']['catalogSavepath'].'/plugins/'.$plugin->getId());
+if ($im) {
+$plugin->setImage($im);
+}
+
 
 $this->_pluginRepository->persist($plugin);
 
$this->flashMessenger()->setNamespace('success')->addMessage('Plugin 
registered.');
diff --git a/pp3/module/Application/view/layout/layout.phtml 
b/pp3/module/Application/view/layout/layout.phtml
index 00a0176..7096bab 100755
--- a/pp3/module/Application/view/layout/layout.phtml
+++ b/pp3/module/Application/view/layout/layout.phtml
@@ -30,7 +30,6 @@
 ->appendName('viewport', 'width=device-width, 
initial-scale=1.0')
 ->appendHttpEquiv('X-UA-Compatible', 'IE=edge')
 ?>
-
 
 headLink()
@@ -48,8 +47,8 @@
 
->prependFile($this->basePath('js/jquery.ba-throttle-debounce.min.js'))
 ->prependFile($this->basePath('js/validator.min.js'))
 ->prependFile($this->basePath('js/bootstrap.min.js'))
-->prependFile($this->basePath('js/jquery.min.js'))
 ->prependFile($this->basePath('js/jquery-ui-1.12.1.min.js'))
+->prependFile($this->basePath('js/jquery.min.js'))
 ->prependFile($this->basePath('js/respond.min.js'), 
'text/javascript',
 array('conditional' => 'lt IE 9',))
 ->prependFile($this->basePath('js/html5shiv.min.js'), 
'text/javascript',


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3264) Plugin image is not displayed on plugin detail page

2019-11-29 Thread Jan Pirek (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984873#comment-16984873
 ] 

Jan Pirek commented on NETBEANS-3264:
-

Pull req: [https://github.com/apache/netbeans-tools/pull/19]

> Plugin image is not displayed on plugin detail page
> ---
>
> Key: NETBEANS-3264
> URL: https://issues.apache.org/jira/browse/NETBEANS-3264
> Project: NetBeans
>  Issue Type: Bug
>  Components: updatecenters - Pluginportal
>Affects Versions: 3.0
>Reporter: Jiří Kovalský
>Assignee: Jan Pirek
>Priority: Major
>
> When I add a new plugin and select some image from my computer as a plugin 
> logo/screenshot before clicking *Save Plugin* button, the image is sent as 
> parameter of POST request but then not displayed on detail page of the plugin.
> *Steps to reproduce:*
>  # Visit [http://netbeans-vm.apache.org/pluginportal/] and sign in.
>  # Click *Add plugin* from toolbar.
>  # Provide _GroupID_ and _ArtifactID_ of your plugin and click *Add Plugin* 
> button.
>  # Set all required plugin properties, click _Browse ..._ button to select 
> some picture from your computer and click *Save Plugin* button.
>  # Wait until your plugin is approved. Then find it on the Plugin Portal home 
> page and click it.
> *Expected:* Plugin detail page is displayed including the picture you have 
> chosen.
> *Actual:* Plugin detail page is displayed but the picture you have chosen is 
> not visible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans-tools] branch master updated: Removing :void return type decalration

2019-11-29 Thread geertjan
This is an automated email from the ASF dual-hosted git repository.

geertjan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans-tools.git


The following commit(s) were added to refs/heads/master by this push:
 new 966d2e4  Removing :void return type decalration
 new 8430be3  Merge pull request #18 from jpirek/master
966d2e4 is described below

commit 966d2e4c3abe6020a1bb90d2a29bb78339bf8dbe
Author: Jan Pirek 
AuthorDate: Thu Nov 28 17:07:28 2019 +0100

Removing :void return type decalration
---
 pp3/module/Application/src/Application/Entity/Base/Verification.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/pp3/module/Application/src/Application/Entity/Base/Verification.php 
b/pp3/module/Application/src/Application/Entity/Base/Verification.php
index 277495b..7839871 100644
--- a/pp3/module/Application/src/Application/Entity/Base/Verification.php
+++ b/pp3/module/Application/src/Application/Entity/Base/Verification.php
@@ -100,7 +100,7 @@ class Verification {
 return $this->nbVersionPluginVersion;
 }
 
-function setNbVersionPluginVersion($nbVersionPluginVersion): void {
+function setNbVersionPluginVersion($nbVersionPluginVersion) {
 $this->nbVersionPluginVersion = $nbVersionPluginVersion;
 }
 }


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists