[netbeans] branch master updated (9e5cafb -> 9c2b5c6)
This is an automated email from the ASF dual-hosted git repository. jlahoda pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 9e5cafb [NETBEANS-3713] FlatLaf: progress bar improvements - progress bar in status bar now always has large height - cancel button replaced with vector icon - fixed color of separator in "Processes" popup - remove separator of last row in "Processes" popup - use preferred height for progress bars in "Processes" popup add 3d6e0b5 Add TypeScript editor add 9c2b5c6 Integrating TypeScript icon by Junichi Yamamoto No new revisions were added by this update. Summary of changes: .../client/bindings/CompletionProviderImpl.java|3 + nbbuild/cluster.properties |1 + nbbuild/licenses/Apache-2.0-typescript | 55 + .../licenses/Apache-2.0-typescript-language-server | 201 + nbbuild/licenses/ISC-graceful-fs | 15 + nbbuild/licenses/MIT-command-exists| 22 + nbbuild/licenses/MIT-commander | 22 + nbbuild/licenses/MIT-fs-extra | 15 + nbbuild/licenses/MIT-jsonfile | 15 + ...nce-crypto-random-string-temp-dir-unique-string | 21 + nbbuild/licenses/MIT-tempy |9 + nbbuild/licenses/MIT-universalify | 20 + nbbuild/licenses/MIT-vscode| 23 + nbbuild/licenses/MIT-vscode-jsonrpc| 46 + nbbuild/licenses/MIT-vscode-languageserver | 50 + .../licenses/MIT-vscode-languageserver-protocol| 46 + nbbuild/licenses/MIT-vscode-languageserver-types | 11 + nbbuild/licenses/MIT-vscode-textbuffer | 21 + nbbuild/licenses/MIT-vscode-uri|9 + nbbuild/licenses/names.properties | 19 + webcommon/javascript.nodejs/nbproject/project.xml |1 + webcommon/typescript.editor/.gitignore |6 + webcommon/typescript.editor/build.xml | 31 + .../typescript.editor/bundles/package/package.json |5 + .../typescript.editor/bundles/prepare}/README |0 .../typescript.editor/bundles/prepare/pom.xml | 40 + .../modules/learning/prepare/PrepareBundles.java | 256 + webcommon/typescript.editor/external/binaries-list | 36 + .../external/command-exists-1.2.6-license.txt | 28 + .../external/commander-2.20.3-license.txt | 28 + .../crypto-random-string-1.0.0-license.txt | 27 + .../external/fs-extra-7.0.1-license.txt| 21 + .../external/graceful-fs-4.2.3-license.txt | 21 + .../external/jsonfile-4.0.0-license.txt| 21 + .../external/p-debounce-1.0.0-license.txt | 27 + .../external/temp-dir-1.0.0-license.txt| 27 + .../external/tempy-0.2.1-license.txt | 15 + .../external/typescript-2.8.3-license.txt | 61 + .../typescript-language-server-0.4.0-license.txt | 207 + .../external/unique-string-1.0.0-license.txt | 27 + .../external/universalify-0.1.2-license.txt| 26 + .../vscode-jsonrpc-5.0.0-next.4-license.txt| 52 + ...vscode-languageserver-5.3.0-next.10-license.txt | 56 + ...guageserver-protocol-3.15.0-next.11-license.txt | 52 + ...-languageserver-types-3.15.0-next.8-license.txt | 17 + .../external/vscode-textbuffer-1.0.0-license.txt | 27 + .../external/vscode-uri-1.0.8-license.txt | 15 + webcommon/typescript.editor/licenseinfo.xml| 36 + webcommon/typescript.editor/manifest.mf|6 + .../nbproject/project.properties |0 webcommon/typescript.editor/nbproject/project.xml | 174 + .../modules/typescript/editor/Bundle.properties| 18 + .../typescript/editor/TypeScript.tmLanguage.json | 4954 .../editor/TypeScriptDataObjectDataObject.java | 113 + .../editor/TypeScriptDataObjectTemplate.ts | 23 + .../modules/typescript/editor/TypeScriptLSP.java | 66 + .../netbeans/modules/typescript/editor/icon.png| Bin 0 -> 639 bytes .../modules/typescript/editor/package-info.java| 27 + 58 files changed, 7171 insertions(+) create mode 100644 nbbuild/licenses/Apache-2.0-typescript create mode 100644 nbbuild/licenses/Apache-2.0-typescript-language-server create mode 100644 nbbuild/licenses/ISC-graceful-fs create mode 100644 nbbuild/licenses/MIT-command-exists create mode 100644 nbbuild/licenses/MIT-commander create mode 100644 nbbuild/licenses/MIT-fs-extra create mode 100644 nbbuild/licenses/MIT-jsonfile create mode 100644 nbbuild/licenses/MIT-p-debounce-crypto-random-string-temp-dir-unique-string create mode 100644 nbbuild/licenses/MIT-tempy create mode 100644 nbbuild/licenses/MIT-universalify create mode 100644 nbbuild/licenses/MIT-vscode create mode 100644 nbbuild/licenses/MIT-vscode-jsonrpc create mode
[jira] [Commented] (NETBEANS-3707) Class names in auto-complete barely readable
[ https://issues.apache.org/jira/browse/NETBEANS-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018808#comment-17018808 ] Tomáš Procházka commented on NETBEANS-3707: --- You are right - classes, properties and keywords have better colors in Java than in PHP. Where to look for missing/wrong color settings for both languages? > Class names in auto-complete barely readable > > > Key: NETBEANS-3707 > URL: https://issues.apache.org/jira/browse/NETBEANS-3707 > Project: NetBeans > Issue Type: Bug > Components: editor - Settings, FlatLaf, php - Editor >Affects Versions: 11.3 > Environment: Product Version: Apache NetBeans IDE DEV (Build > dev-71270e6cd2ac4daf7bfd1baf3727aa90735c60fc) > Java: 1.8.0_201; Java HotSpot(TM) 64-Bit Server VM 25.201-b09 > Runtime: Java(TM) SE Runtime Environment 1.8.0_201-b09 > System: Linux version 4.15.0-74-generic running on amd64; UTF-8; en_US (nb) >Reporter: Tomáš Procházka >Priority: Minor > Attachments: netbeans-class-color.png > > > When using FlatLaf Dark look and feel then color of classes in auto-complete > window makes the names very hard to read. Color used for class is too dark > and makes very low contrast to background, see attached picture. > Also can't find if this color can be set in Options. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-3715) Project properties cannot be selected if the taskbar is at the bottom of the screen
Gergely Turi created NETBEANS-3715: -- Summary: Project properties cannot be selected if the taskbar is at the bottom of the screen Key: NETBEANS-3715 URL: https://issues.apache.org/jira/browse/NETBEANS-3715 Project: NetBeans Issue Type: Bug Affects Versions: 11.2 Environment: RELEASE=19.3 CODENAME=tricia EDITION="Cinnamon" DESCRIPTION="Linux Mint 19.3 Tricia" DESKTOP=Gnome TOOLKIT=GTK NEW_FEATURES_URL=https://www.linuxmint.com/rel_tricia_cinnamon_whatsnew.php RELEASE_NOTES_URL=https://www.linuxmint.com/rel_tricia_cinnamon.php USER_GUIDE_URL=https://www.linuxmint.com/documentation.php GRUB_TITLE=Linux Mint 19.3 Cinnamon Reporter: Gergely Turi When right-clicking on the project the menu appears but Properties can neither be selected nor clicked. The cause of the issue is that the taskbar seems to be somehow "in the way". If you try to click on Properties it will activate whatever application is behind it. But this doesn't occur if the taskbar is moved to either sides (or up). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-3713] FlatLaf: progress bar improvements - progress bar in status bar now always has large height - cancel button replaced with vector icon - fixed color of
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new 9e5cafb [NETBEANS-3713] FlatLaf: progress bar improvements - progress bar in status bar now always has large height - cancel button replaced with vector icon - fixed color of separator in "Processes" popup - remove separator of last row in "Processes" popup - use preferred height for progress bars in "Processes" popup 9e5cafb is described below commit 9e5cafb440fc655b03fa54f5a263ffc15f0c8f6f Author: Karl Tauber AuthorDate: Sat Jan 18 23:33:52 2020 +0100 [NETBEANS-3713] FlatLaf: progress bar improvements - progress bar in status bar now always has large height - cancel button replaced with vector icon - fixed color of separator in "Processes" popup - remove separator of last row in "Processes" popup - use preferred height for progress bars in "Processes" popup --- .../netbeans/swing/laf/flatlaf/FlatLFCustoms.java | 5 platform/progress.ui/nbproject/project.properties | 2 +- .../modules/progress/ui/AbstractWindowRunner.java | 13 + .../modules/progress/ui/ListComponent.java | 32 -- .../modules/progress/ui/NbProgressBar.java | 4 +++ .../netbeans/modules/progress/ui/PopupPane.java| 16 +-- .../modules/progress/ui/StatusLineComponent.java | 18 ++-- 7 files changed, 61 insertions(+), 29 deletions(-) diff --git a/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLFCustoms.java b/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLFCustoms.java index 570feb7..e6d5436 100644 --- a/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLFCustoms.java +++ b/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLFCustoms.java @@ -72,6 +72,11 @@ public class FlatLFCustoms extends LFCustoms { "nb.multitabs.button.right.icon", FlatTabControlIcon.get(TabControlButton.ID_SCROLL_RIGHT_BUTTON), // NOI18N "nb.multitabs.button.rollover", true, // NOI18N +// for module progress.ui +"nb.progress.cancel.icon", FlatTabControlIcon.get(TabControlButton.ID_CLOSE_BUTTON, TabControlButton.STATE_DEFAULT), // NOI18N +"nb.progress.cancel.icon.pressed", FlatTabControlIcon.get(TabControlButton.ID_CLOSE_BUTTON, TabControlButton.STATE_PRESSED), // NOI18N +"nb.progress.cancel.icon.mouseover", FlatTabControlIcon.get(TabControlButton.ID_CLOSE_BUTTON, TabControlButton.STATE_ROLLOVER), // NOI18N + // Change some colors from ColorUIResource to Color because they are used as // background colors for checkboxes (e.g. in org.netbeans.modules.palette.ui.CategoryButton), // which in FlatLaf paint background only if background color is not a UIResource. diff --git a/platform/progress.ui/nbproject/project.properties b/platform/progress.ui/nbproject/project.properties index 94a11b0..50d6a31 100644 --- a/platform/progress.ui/nbproject/project.properties +++ b/platform/progress.ui/nbproject/project.properties @@ -18,7 +18,7 @@ # Sample ResourceBundle properties file is.autoload=true javac.compilerargs=-Xlint:unchecked -javac.source=1.6 +javac.source=1.8 javadoc.arch=${basedir}/arch.xml test.config.stableBTD.includes=**/*Test.class diff --git a/platform/progress.ui/src/org/netbeans/modules/progress/ui/AbstractWindowRunner.java b/platform/progress.ui/src/org/netbeans/modules/progress/ui/AbstractWindowRunner.java index 7606967..a33d5c0 100644 --- a/platform/progress.ui/src/org/netbeans/modules/progress/ui/AbstractWindowRunner.java +++ b/platform/progress.ui/src/org/netbeans/modules/progress/ui/AbstractWindowRunner.java @@ -42,6 +42,7 @@ import java.util.concurrent.CountDownLatch; import java.util.concurrent.Future; import javax.swing.AbstractAction; import javax.swing.BorderFactory; +import javax.swing.Icon; import javax.swing.JButton; import javax.swing.JComponent; import javax.swing.JDialog; @@ -252,21 +253,21 @@ abstract class AbstractWindowRunner extends WindowAdapter implements Runnable closeButton.setOpaque(false); closeButton.setContentAreaFilled(false); -Image img = (Image)UIManager.get("nb.progress.cancel.icon"); //NOI18N +Object img = UIManager.get("nb.progress.cancel.icon"); //NOI18N if( null != img ) { -closeButton.setIcon( ImageUtilities.image2Icon( img ) ); +closeButton.setIcon( (img instanceof Icon) ? (Icon) img : ImageUtilities.image2Icon( (Image) img ) ); } else { closeButton.setText ( NbBundle.getMessage(AbstractWindowRunner.class, "ModalDialog.btnClose.text")); //NOI18N } -img =
[netbeans] branch master updated: [NETBEANS-3428] FlatLaf: improving editor and view tabs in main window
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new ab0fedf [NETBEANS-3428] FlatLaf: improving editor and view tabs in main window ab0fedf is described below commit ab0fedf0a11e6b428e062d6538c209b3b2740f17 Author: Karl Tauber AuthorDate: Sat Jan 18 17:40:20 2020 +0100 [NETBEANS-3428] FlatLaf: improving editor and view tabs in main window Editor and View tabs: - tab separators - tab text moved up 1px - smaller tab insets - minimize icon improved View tabs only: - minimized space between tab text and close button - center tab text if close button is hidden - make sure that as much tab text as possible is shown by dynamically reducing left/right margins - avoid empty tabs (truncate text if necessary) --- .../netbeans/swing/laf/flatlaf/FlatLaf.properties | 8 ++- .../laf/flatlaf/ui/FlatEditorTabCellRenderer.java | 29 +++-- .../laf/flatlaf/ui/FlatEditorTabDisplayerUI.java | 10 +++ .../swing/laf/flatlaf/ui/FlatTabControlIcon.java | 12 ++-- .../laf/flatlaf/ui/FlatViewTabDisplayerUI.java | 74 ++ 5 files changed, 106 insertions(+), 27 deletions(-) diff --git a/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLaf.properties b/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLaf.properties index 88ceb0b..affe2e0 100644 --- a/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLaf.properties +++ b/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLaf.properties @@ -34,16 +34,20 @@ TabbedContainer.view.contentBorderColor=$Component.borderColor # EditorTab -EditorTab.tabInsets=6,8,6,8 +EditorTab.tabInsets=5,6,7,6 EditorTab.underlineHeight=3 #EditorTab.underlineAtTop=true +EditorTab.tabSeparatorColor=$Component.borderColor +EditorTab.showTabSeparators=true # ViewTab -ViewTab.tabInsets=6,8,6,8 +ViewTab.tabInsets=5,6,7,0 ViewTab.underlineHeight=3 #ViewTab.underlineAtTop=true +ViewTab.tabSeparatorColor=$Component.borderColor +ViewTab.showTabSeparators=true # Multi-tabs diff --git a/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java b/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java index a4048aa..db7b332 100644 --- a/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java +++ b/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java @@ -58,14 +58,18 @@ public class FlatEditorTabCellRenderer extends AbstractTabCellRenderer { private static final Color underlineColor = UIManager.getColor("EditorTab.underlineColor"); // NOI18N private static final Color inactiveUnderlineColor = UIManager.getColor("EditorTab.inactiveUnderlineColor"); // NOI18N +private static final Color tabSeparatorColor = UIManager.getColor("EditorTab.tabSeparatorColor"); // NOI18N private static final Color contentBorderColor = UIManager.getColor("TabbedContainer.editor.contentBorderColor"); // NOI18N private static final Insets tabInsets = UIScale.scale(UIManager.getInsets("EditorTab.tabInsets")); // NOI18N private static final int underlineHeight = UIScale.scale(UIManager.getInt("EditorTab.underlineHeight")); // NOI18N private static final boolean underlineAtTop = UIManager.getBoolean("EditorTab.underlineAtTop"); // NOI18N +private static boolean showTabSeparators = UIManager.getBoolean("EditorTab.showTabSeparators"); // NOI18N private static final FlatTabPainter painter = new FlatTabPainter(); +boolean nextTabSelected; + public FlatEditorTabCellRenderer() { super(painter, new Dimension(tabInsets.left + tabInsets.right, tabInsets.top + tabInsets.bottom)); } @@ -198,25 +202,40 @@ public class FlatEditorTabCellRenderer extends AbstractTabCellRenderer { FlatEditorTabCellRenderer ren = (FlatEditorTabCellRenderer) c; boolean selected = ren.isSelected(); +// get background color +Color bg = ren.colorForState( +background, activeBackground, selectedBackground, +hoverBackground, attentionBackground); + +boolean showSeparator = showTabSeparators && !selected && !ren.nextTabSelected; + +// do not round tab separator width to get nice small lines at 125%, 150% and 175% +int tabSeparatorWidth = showSeparator ? (int) (1 * scale) : 0; + // paint background -g.setColor(ren.colorForState(background, activeBackground, selectedBackground, -hoverBackground, attentionBackground)); -
[jira] [Commented] (NETBEANS-3714) Applying options enable PHP cluster
[ https://issues.apache.org/jira/browse/NETBEANS-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018738#comment-17018738 ] Ernie Rael commented on NETBEANS-3714: -- The following, from org.netbeans.modules.ide.ergonomics.fod.OptionCntrl {code:java} @Override public JComponent call() throws Exception { assert EventQueue.isDispatchThread(); // it would be better not to close the dialog... EventQueue.invokeLater(this); return new JButton(); } @Override public void run() { OptionsDisplayer.getDefault().open(); } {code} makes me wonder... > Applying options enable PHP cluster > --- > > Key: NETBEANS-3714 > URL: https://issues.apache.org/jira/browse/NETBEANS-3714 > Project: NetBeans > Issue Type: Bug >Reporter: Laszlo Kishalmi >Priority: Critical > > I've noticed that since a few weeks ago, if I apply anything in the options > dialog box, the dialog box disappears, all PHP modules are turning on, then > the dialog box reappears. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3714) Applying options enable PHP cluster
[ https://issues.apache.org/jira/browse/NETBEANS-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018733#comment-17018733 ] Ernie Rael commented on NETBEANS-3714: -- I noticed this a few weeks ago as well. I'm curious about whether there is a _WARNING [org.netbeans.api.options.OptionsDisplayer]: Options Dialog is opened_ in the log. I thought the fix mentioned below got rid of this, but that wasn't the target of the fix and I'm not certain. I didn't carefully make sure one way or the other. A few weeks ago I noticed that after "Apply", a keymap listener in a plugin was being called when NOT in the EDT. I filed NETBEANS-3674 and fixed it. That report has a partial stack trace. While investigating, I saw that doing Tools>Options>Editor>Formatting and changing Language combo box from "AllLanguages" to "JavaScript" to "JSON" would usually enable the apply button even though nothing was changed. I'm guessing that hitting "Apply" causes things to happen relating to these editors which in turn cause the modules to be turned on. I wonder if there is something in or around the options dialog that detects stale information and that might be causing the dialog to disappear and re-appear. (For me, while investigating, the trick was figuring out how to reproduce; just close/open NetBeans around 5 times and it stops automatically turning on the php modules and then it is primed to turn on those modules because of actions from the options dialog) > Applying options enable PHP cluster > --- > > Key: NETBEANS-3714 > URL: https://issues.apache.org/jira/browse/NETBEANS-3714 > Project: NetBeans > Issue Type: Bug >Reporter: Laszlo Kishalmi >Priority: Critical > > I've noticed that since a few weeks ago, if I apply anything in the options > dialog box, the dialog box disappears, all PHP modules are turning on, then > the dialog box reappears. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-3713) Progress UI is ugly with FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-3713: - Labels: pull-request-available (was: ) > Progress UI is ugly with FlatLaf > > > Key: NETBEANS-3713 > URL: https://issues.apache.org/jira/browse/NETBEANS-3713 > Project: NetBeans > Issue Type: Bug > Components: FlatLaf >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Major > Labels: pull-request-available > Attachments: image-2020-01-18-17-27-18-089.png, > image-2020-01-18-19-38-15-514.png > > > Well originally, I just wanted to fix the width of the unbounded progress > bars. > Adding: > {code:java} > # ProgressBar > ProgressBar.horizontalSize=146,15 > {code} > to the FlatLaf.properties, as you suggested makes it work, then I realized, > that the close buttons are ugly and the separator in the Active running task > is out of LaL as well. > I've tried to use CloseButtonFactory.createCloseButton(); for those buttons, > while result was better, it was not perfect, so I decided to leave that to > the expert. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-3674) BaseKit manipulates JTextComponent and NOT in EDT
[ https://issues.apache.org/jira/browse/NETBEANS-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernie Rael resolved NETBEANS-3674. -- Fix Version/s: 11.3 Resolution: Fixed The pull request fix got rid of the Swing access when not in EDT that I was seeing. > BaseKit manipulates JTextComponent and NOT in EDT > - > > Key: NETBEANS-3674 > URL: https://issues.apache.org/jira/browse/NETBEANS-3674 > Project: NetBeans > Issue Type: Bug > Components: editor - Settings >Affects Versions: 11.2 > Environment: jdk1,8, win7,11.2u1 >Reporter: Ernie Rael >Priority: Major > Labels: pull-request-available > Fix For: 11.3 > > Time Spent: 40m > Remaining Estimate: 0h > > In editor.lib/.../BasKit.java a lookup listener does "c.setMap(keymap)". This > is required to run in the EventDisplatchThread. > KeybindingsAndPreferencesTracker::refreshShortcutsAndActions around line 4125 > For example: > "Editor-Setting-Files-Tracker-Keybindings" > at > org.netbeans.editor.BaseKit$KeybindingsAndPreferencesTracker.refreshShortcutsAndActions(BaseKit.java:4119) > at > org.netbeans.editor.BaseKit$KeybindingsAndPreferencesTracker.resultChanged(BaseKit.java:4081) > ... > at > org.netbeans.modules.editor.settings.storage.SettingsProvider$MyLookup.updateContents(SettingsProvider.java:275) > at > org.netbeans.modules.editor.settings.storage.SettingsProvider$MyLookup.propertyChange(SettingsProvider.java:188) > at > org.openide.util.WeakListenerImpl$PropertyChange.propertyChange(WeakListenerImpl.java:190) > ... > at > org.netbeans.modules.editor.settings.storage.keybindings.KeyBindingSettingsImpl$Listener.propertyChange(KeyBindingSettingsImpl.java:320) > at java.beans.PropertyChangeSupport.fire(PropertyChangeSupport.java:335) > at > java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:327) > at > java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:263) > at > org.netbeans.modules.editor.settings.storage.api.EditorSettingsStorage$2.call(EditorSettingsStorage.java:104) > at > org.netbeans.modules.editor.settings.storage.api.EditorSettingsStorage$2.call(EditorSettingsStorage.java:102) > at > org.netbeans.modules.editor.settings.storage.StorageImpl.refresh(StorageImpl.java:170) > at > org.netbeans.modules.editor.settings.storage.StorageImpl$FilesystemTracker.run(StorageImpl.java:591) > at > org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) > at > org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) > at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) > at > org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated (f1dd1d8 -> 7aec6ca)
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from f1dd1d8 Merge pull request #1849 from lhochet/NETBEANS-3254 add 7aec6ca [NETBEANS-3428] Update FlatLaf from 0.24 to 0.25.1 and other fixes No new revisions were added by this update. Summary of changes: platform/libs.flatlaf/external/binaries-list | 2 +- .../{flatlaf-0.24-license.txt => flatlaf-0.25.1-license.txt} | 4 ++-- platform/libs.flatlaf/nbproject/project.properties | 2 +- platform/libs.flatlaf/nbproject/project.xml| 4 ++-- .../src/org/netbeans/swing/laf/flatlaf/FlatDarkLaf.properties | 3 --- .../src/org/netbeans/swing/laf/flatlaf/FlatLaf.properties | 7 ++- 6 files changed, 12 insertions(+), 10 deletions(-) rename platform/libs.flatlaf/external/{flatlaf-0.24-license.txt => flatlaf-0.25.1-license.txt} (99%) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-3714) Applying options enable PHP cluster
Laszlo Kishalmi created NETBEANS-3714: - Summary: Applying options enable PHP cluster Key: NETBEANS-3714 URL: https://issues.apache.org/jira/browse/NETBEANS-3714 Project: NetBeans Issue Type: Bug Reporter: Laszlo Kishalmi I've noticed that since a few weeks ago, if I apply anything in the options dialog box, the dialog box disappears, all PHP modules are turning on, then the dialog box reappears. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3713) Progress UI is ugly with FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018687#comment-17018687 ] Laszlo Kishalmi commented on NETBEANS-3713: --- Yes, you've found it, second screenshot. > Progress UI is ugly with FlatLaf > > > Key: NETBEANS-3713 > URL: https://issues.apache.org/jira/browse/NETBEANS-3713 > Project: NetBeans > Issue Type: Bug > Components: FlatLaf >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Major > Attachments: image-2020-01-18-17-27-18-089.png, > image-2020-01-18-19-38-15-514.png > > > Well originally, I just wanted to fix the width of the unbounded progress > bars. > Adding: > {code:java} > # ProgressBar > ProgressBar.horizontalSize=146,15 > {code} > to the FlatLaf.properties, as you suggested makes it work, then I realized, > that the close buttons are ugly and the separator in the Active running task > is out of LaL as well. > I've tried to use CloseButtonFactory.createCloseButton(); for those buttons, > while result was better, it was not perfect, so I decided to leave that to > the expert. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-3713) Progress UI is ugly with FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Tauber updated NETBEANS-3713: -- Attachment: image-2020-01-18-19-38-15-514.png > Progress UI is ugly with FlatLaf > > > Key: NETBEANS-3713 > URL: https://issues.apache.org/jira/browse/NETBEANS-3713 > Project: NetBeans > Issue Type: Bug > Components: FlatLaf >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Major > Attachments: image-2020-01-18-17-27-18-089.png, > image-2020-01-18-19-38-15-514.png > > > Well originally, I just wanted to fix the width of the unbounded progress > bars. > Adding: > {code:java} > # ProgressBar > ProgressBar.horizontalSize=146,15 > {code} > to the FlatLaf.properties, as you suggested makes it work, then I realized, > that the close buttons are ugly and the separator in the Active running task > is out of LaL as well. > I've tried to use CloseButtonFactory.createCloseButton(); for those buttons, > while result was better, it was not perfect, so I decided to leave that to > the expert. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3713) Progress UI is ugly with FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018673#comment-17018673 ] Karl Tauber commented on NETBEANS-3713: --- I think I've found the "separator in the Active running task", right? !image-2020-01-18-19-38-15-514.png! > Progress UI is ugly with FlatLaf > > > Key: NETBEANS-3713 > URL: https://issues.apache.org/jira/browse/NETBEANS-3713 > Project: NetBeans > Issue Type: Bug > Components: FlatLaf >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Major > Attachments: image-2020-01-18-17-27-18-089.png, > image-2020-01-18-19-38-15-514.png > > > Well originally, I just wanted to fix the width of the unbounded progress > bars. > Adding: > {code:java} > # ProgressBar > ProgressBar.horizontalSize=146,15 > {code} > to the FlatLaf.properties, as you suggested makes it work, then I realized, > that the close buttons are ugly and the separator in the Active running task > is out of LaL as well. > I've tried to use CloseButtonFactory.createCloseButton(); for those buttons, > while result was better, it was not perfect, so I decided to leave that to > the expert. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated (3fb6652 -> f1dd1d8)
This is an automated email from the ASF dual-hosted git repository. skygo pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 3fb6652 Merge pull request #1880 from oli0044/patch-2 new 4f268e7 NETBEANS-3254 Remove allowAmbiguousCommands flag new dd58f19 revert the removal of the jdk.lang.Process.allowAmbiguousCommands=true as it could be of use for non Maven contexts new f1dd1d8 Merge pull request #1849 from lhochet/NETBEANS-3254 The 3479 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../maven/execute/MavenCommandLineExecutor.java| 42 +++--- 1 file changed, 30 insertions(+), 12 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3713) Progress UI is ugly with FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018638#comment-17018638 ] Karl Tauber commented on NETBEANS-3713: --- The progress bar height should be stable after merging [https://github.com/apache/netbeans/pull/1882.] Not sure what you mean with "separator in the Active running task". Is it the one in the below screenshot? !image-2020-01-18-17-27-18-089.png! > Progress UI is ugly with FlatLaf > > > Key: NETBEANS-3713 > URL: https://issues.apache.org/jira/browse/NETBEANS-3713 > Project: NetBeans > Issue Type: Bug > Components: FlatLaf >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Major > Attachments: image-2020-01-18-17-27-18-089.png > > > Well originally, I just wanted to fix the width of the unbounded progress > bars. > Adding: > {code:java} > # ProgressBar > ProgressBar.horizontalSize=146,15 > {code} > to the FlatLaf.properties, as you suggested makes it work, then I realized, > that the close buttons are ugly and the separator in the Active running task > is out of LaL as well. > I've tried to use CloseButtonFactory.createCloseButton(); for those buttons, > while result was better, it was not perfect, so I decided to leave that to > the expert. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-3713) Progress UI is ugly with FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Tauber updated NETBEANS-3713: -- Attachment: image-2020-01-18-17-27-18-089.png > Progress UI is ugly with FlatLaf > > > Key: NETBEANS-3713 > URL: https://issues.apache.org/jira/browse/NETBEANS-3713 > Project: NetBeans > Issue Type: Bug > Components: FlatLaf >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Major > Attachments: image-2020-01-18-17-27-18-089.png > > > Well originally, I just wanted to fix the width of the unbounded progress > bars. > Adding: > {code:java} > # ProgressBar > ProgressBar.horizontalSize=146,15 > {code} > to the FlatLaf.properties, as you suggested makes it work, then I realized, > that the close buttons are ugly and the separator in the Active running task > is out of LaL as well. > I've tried to use CloseButtonFactory.createCloseButton(); for those buttons, > while result was better, it was not perfect, so I decided to leave that to > the expert. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Closed] (NETBEANS-3647) FTP upload stops when uploading to IIS FTP service "550 "
[ https://issues.apache.org/jira/browse/NETBEANS-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oli4 closed NETBEANS-3647. -- > FTP upload stops when uploading to IIS FTP service "550 " > - > > Key: NETBEANS-3647 > URL: https://issues.apache.org/jira/browse/NETBEANS-3647 > Project: NetBeans > Issue Type: Bug > Components: cnd - Remote, php - FTP Support >Affects Versions: 11.0, 11.1, 11.2 >Reporter: Oli4 >Assignee: Oli4 >Priority: Major > Labels: pull-request-available > Fix For: 11.3 > > Time Spent: 3h > Remaining Estimate: 0h > > Hi > when uploading to a Microsoft IIS FTP server there are some cases, when IIS > FTP server does not conform strictly to RFC 959. For example when uploading > to a non-existing subfolder Microsoft IIS responds with "550 ", giving the > return code but omitting the reason. > This throws a MalformedServerReplyException in Netbeans. (Please see the > complete error log underneath). > I believe, that this behaviour can be optimized by using the function > [https://commons.apache.org/proper/commons-net/apidocs/org/apache/commons/net/ftp/FTP.html#setStrictReplyParsing(boolean)] > . > I understand, that this is strictly a Microsoft bug, but hopefully this can > be updated in Netbeans since I do not see any chance of Microsoft changing > this bug any time soon. > I would really apreciate it, if this can be "fixed" in the next version. > Thanks and Greetings from Germany > Oli4 > > Full error log: > FINE [org.netbeans.modules.php.project.connections.ftp.FtpClient]: Command > listener: CWD /test/test > FINE [org.netbeans.modules.php.project.connections.ftp.FtpClient]: Error > while changing directory /test/test > org.apache.commons.net.MalformedServerReplyException: Truncated server reply: > '550 ' > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:374) > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:300) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:523) > at org.apache.commons.net.ftp.FTPSClient.sendCommand(FTPSClient.java:568) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:648) > at org.apache.commons.net.ftp.FTP.cwd(FTP.java:868) > at > org.apache.commons.net.ftp.FTPClient.changeWorkingDirectory(FTPClient.java:1167) > [catch] at > org.netbeans.modules.php.project.connections.ftp.FtpClient.changeWorkingDirectory(FtpClient.java:468) > at > org.netbeans.modules.php.project.connections.RemoteClient.cdRemoteDirectory(RemoteClient.java:1200) > at > org.netbeans.modules.php.project.connections.RemoteClient.cdBaseRemoteDirectory(RemoteClient.java:1195) > at > org.netbeans.modules.php.project.connections.RemoteClient.uploadFileInternal(RemoteClient.java:382) > at > org.netbeans.modules.php.project.connections.RemoteClient.uploadFile(RemoteClient.java:347) > at > org.netbeans.modules.php.project.connections.RemoteClient.upload(RemoteClient.java:328) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.upload(UploadCommand.java:150) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.uploadFiles(UploadCommand.java:98) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.invokeActionImpl(UploadCommand.java:82) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand$1.run(UploadCommand.java:69) > at > org.netbeans.modules.php.project.ui.actions.RemoteCommand$1.run(RemoteCommand.java:84) > at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) > at > org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) > at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) > at > org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033) > INFO [org.netbeans.modules.php.project.connections.RemoteClient] > org.apache.commons.net.MalformedServerReplyException: Truncated server reply: > '550 ' > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:374) > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:300) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:523) > at org.apache.commons.net.ftp.FTPSClient.sendCommand(FTPSClient.java:568) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:648) > at org.apache.commons.net.ftp.FTP.cwd(FTP.java:868) > at > org.apache.commons.net.ftp.FTPClient.changeWorkingDirectory(FTPClient.java:1167) > [catch] at > org.netbeans.modules.php.project.connections.ftp.FtpClient.changeWorkingDirectory(FtpClient.java:468) > Caused: org.netbeans.modules.php.project.connections.RemoteException: Cannot > change directory to /test/test. > at > org.netbeans.modules.php.project.connections.ftp.FtpClient.changeWorkingDirectory(FtpClient.java:472) > at >
[jira] [Commented] (NETBEANS-3647) FTP upload stops when uploading to IIS FTP service "550 "
[ https://issues.apache.org/jira/browse/NETBEANS-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018568#comment-17018568 ] Oli4 commented on NETBEANS-3647: Solved in PR #1880 and merged for the 11.3 release > FTP upload stops when uploading to IIS FTP service "550 " > - > > Key: NETBEANS-3647 > URL: https://issues.apache.org/jira/browse/NETBEANS-3647 > Project: NetBeans > Issue Type: Bug > Components: cnd - Remote, php - FTP Support >Affects Versions: 11.0, 11.1, 11.2 >Reporter: Oli4 >Assignee: Oli4 >Priority: Major > Labels: pull-request-available > Fix For: 11.3 > > Time Spent: 3h > Remaining Estimate: 0h > > Hi > when uploading to a Microsoft IIS FTP server there are some cases, when IIS > FTP server does not conform strictly to RFC 959. For example when uploading > to a non-existing subfolder Microsoft IIS responds with "550 ", giving the > return code but omitting the reason. > This throws a MalformedServerReplyException in Netbeans. (Please see the > complete error log underneath). > I believe, that this behaviour can be optimized by using the function > [https://commons.apache.org/proper/commons-net/apidocs/org/apache/commons/net/ftp/FTP.html#setStrictReplyParsing(boolean)] > . > I understand, that this is strictly a Microsoft bug, but hopefully this can > be updated in Netbeans since I do not see any chance of Microsoft changing > this bug any time soon. > I would really apreciate it, if this can be "fixed" in the next version. > Thanks and Greetings from Germany > Oli4 > > Full error log: > FINE [org.netbeans.modules.php.project.connections.ftp.FtpClient]: Command > listener: CWD /test/test > FINE [org.netbeans.modules.php.project.connections.ftp.FtpClient]: Error > while changing directory /test/test > org.apache.commons.net.MalformedServerReplyException: Truncated server reply: > '550 ' > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:374) > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:300) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:523) > at org.apache.commons.net.ftp.FTPSClient.sendCommand(FTPSClient.java:568) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:648) > at org.apache.commons.net.ftp.FTP.cwd(FTP.java:868) > at > org.apache.commons.net.ftp.FTPClient.changeWorkingDirectory(FTPClient.java:1167) > [catch] at > org.netbeans.modules.php.project.connections.ftp.FtpClient.changeWorkingDirectory(FtpClient.java:468) > at > org.netbeans.modules.php.project.connections.RemoteClient.cdRemoteDirectory(RemoteClient.java:1200) > at > org.netbeans.modules.php.project.connections.RemoteClient.cdBaseRemoteDirectory(RemoteClient.java:1195) > at > org.netbeans.modules.php.project.connections.RemoteClient.uploadFileInternal(RemoteClient.java:382) > at > org.netbeans.modules.php.project.connections.RemoteClient.uploadFile(RemoteClient.java:347) > at > org.netbeans.modules.php.project.connections.RemoteClient.upload(RemoteClient.java:328) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.upload(UploadCommand.java:150) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.uploadFiles(UploadCommand.java:98) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.invokeActionImpl(UploadCommand.java:82) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand$1.run(UploadCommand.java:69) > at > org.netbeans.modules.php.project.ui.actions.RemoteCommand$1.run(RemoteCommand.java:84) > at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) > at > org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) > at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) > at > org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033) > INFO [org.netbeans.modules.php.project.connections.RemoteClient] > org.apache.commons.net.MalformedServerReplyException: Truncated server reply: > '550 ' > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:374) > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:300) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:523) > at org.apache.commons.net.ftp.FTPSClient.sendCommand(FTPSClient.java:568) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:648) > at org.apache.commons.net.ftp.FTP.cwd(FTP.java:868) > at > org.apache.commons.net.ftp.FTPClient.changeWorkingDirectory(FTPClient.java:1167) > [catch] at > org.netbeans.modules.php.project.connections.ftp.FtpClient.changeWorkingDirectory(FtpClient.java:468) > Caused: org.netbeans.modules.php.project.connections.RemoteException: Cannot > change directory to /test/test. > at >
[jira] [Resolved] (NETBEANS-3647) FTP upload stops when uploading to IIS FTP service "550 "
[ https://issues.apache.org/jira/browse/NETBEANS-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oli4 resolved NETBEANS-3647. Fix Version/s: 11.3 Resolution: Fixed > FTP upload stops when uploading to IIS FTP service "550 " > - > > Key: NETBEANS-3647 > URL: https://issues.apache.org/jira/browse/NETBEANS-3647 > Project: NetBeans > Issue Type: Bug > Components: cnd - Remote, php - FTP Support >Affects Versions: 11.0, 11.1, 11.2 >Reporter: Oli4 >Assignee: Oli4 >Priority: Major > Labels: pull-request-available > Fix For: 11.3 > > Time Spent: 3h > Remaining Estimate: 0h > > Hi > when uploading to a Microsoft IIS FTP server there are some cases, when IIS > FTP server does not conform strictly to RFC 959. For example when uploading > to a non-existing subfolder Microsoft IIS responds with "550 ", giving the > return code but omitting the reason. > This throws a MalformedServerReplyException in Netbeans. (Please see the > complete error log underneath). > I believe, that this behaviour can be optimized by using the function > [https://commons.apache.org/proper/commons-net/apidocs/org/apache/commons/net/ftp/FTP.html#setStrictReplyParsing(boolean)] > . > I understand, that this is strictly a Microsoft bug, but hopefully this can > be updated in Netbeans since I do not see any chance of Microsoft changing > this bug any time soon. > I would really apreciate it, if this can be "fixed" in the next version. > Thanks and Greetings from Germany > Oli4 > > Full error log: > FINE [org.netbeans.modules.php.project.connections.ftp.FtpClient]: Command > listener: CWD /test/test > FINE [org.netbeans.modules.php.project.connections.ftp.FtpClient]: Error > while changing directory /test/test > org.apache.commons.net.MalformedServerReplyException: Truncated server reply: > '550 ' > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:374) > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:300) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:523) > at org.apache.commons.net.ftp.FTPSClient.sendCommand(FTPSClient.java:568) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:648) > at org.apache.commons.net.ftp.FTP.cwd(FTP.java:868) > at > org.apache.commons.net.ftp.FTPClient.changeWorkingDirectory(FTPClient.java:1167) > [catch] at > org.netbeans.modules.php.project.connections.ftp.FtpClient.changeWorkingDirectory(FtpClient.java:468) > at > org.netbeans.modules.php.project.connections.RemoteClient.cdRemoteDirectory(RemoteClient.java:1200) > at > org.netbeans.modules.php.project.connections.RemoteClient.cdBaseRemoteDirectory(RemoteClient.java:1195) > at > org.netbeans.modules.php.project.connections.RemoteClient.uploadFileInternal(RemoteClient.java:382) > at > org.netbeans.modules.php.project.connections.RemoteClient.uploadFile(RemoteClient.java:347) > at > org.netbeans.modules.php.project.connections.RemoteClient.upload(RemoteClient.java:328) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.upload(UploadCommand.java:150) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.uploadFiles(UploadCommand.java:98) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.invokeActionImpl(UploadCommand.java:82) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand$1.run(UploadCommand.java:69) > at > org.netbeans.modules.php.project.ui.actions.RemoteCommand$1.run(RemoteCommand.java:84) > at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) > at > org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) > at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) > at > org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033) > INFO [org.netbeans.modules.php.project.connections.RemoteClient] > org.apache.commons.net.MalformedServerReplyException: Truncated server reply: > '550 ' > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:374) > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:300) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:523) > at org.apache.commons.net.ftp.FTPSClient.sendCommand(FTPSClient.java:568) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:648) > at org.apache.commons.net.ftp.FTP.cwd(FTP.java:868) > at > org.apache.commons.net.ftp.FTPClient.changeWorkingDirectory(FTPClient.java:1167) > [catch] at > org.netbeans.modules.php.project.connections.ftp.FtpClient.changeWorkingDirectory(FtpClient.java:468) > Caused: org.netbeans.modules.php.project.connections.RemoteException: Cannot > change directory to /test/test. > at > org.netbeans.modules.php.project.connections.ftp.FtpClient.changeWorkingDirectory(FtpClient.java:472) > at >
[jira] [Assigned] (NETBEANS-3647) FTP upload stops when uploading to IIS FTP service "550 "
[ https://issues.apache.org/jira/browse/NETBEANS-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oli4 reassigned NETBEANS-3647: -- Assignee: Oli4 > FTP upload stops when uploading to IIS FTP service "550 " > - > > Key: NETBEANS-3647 > URL: https://issues.apache.org/jira/browse/NETBEANS-3647 > Project: NetBeans > Issue Type: Bug > Components: cnd - Remote, php - FTP Support >Affects Versions: 11.0, 11.1, 11.2 >Reporter: Oli4 >Assignee: Oli4 >Priority: Major > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Hi > when uploading to a Microsoft IIS FTP server there are some cases, when IIS > FTP server does not conform strictly to RFC 959. For example when uploading > to a non-existing subfolder Microsoft IIS responds with "550 ", giving the > return code but omitting the reason. > This throws a MalformedServerReplyException in Netbeans. (Please see the > complete error log underneath). > I believe, that this behaviour can be optimized by using the function > [https://commons.apache.org/proper/commons-net/apidocs/org/apache/commons/net/ftp/FTP.html#setStrictReplyParsing(boolean)] > . > I understand, that this is strictly a Microsoft bug, but hopefully this can > be updated in Netbeans since I do not see any chance of Microsoft changing > this bug any time soon. > I would really apreciate it, if this can be "fixed" in the next version. > Thanks and Greetings from Germany > Oli4 > > Full error log: > FINE [org.netbeans.modules.php.project.connections.ftp.FtpClient]: Command > listener: CWD /test/test > FINE [org.netbeans.modules.php.project.connections.ftp.FtpClient]: Error > while changing directory /test/test > org.apache.commons.net.MalformedServerReplyException: Truncated server reply: > '550 ' > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:374) > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:300) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:523) > at org.apache.commons.net.ftp.FTPSClient.sendCommand(FTPSClient.java:568) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:648) > at org.apache.commons.net.ftp.FTP.cwd(FTP.java:868) > at > org.apache.commons.net.ftp.FTPClient.changeWorkingDirectory(FTPClient.java:1167) > [catch] at > org.netbeans.modules.php.project.connections.ftp.FtpClient.changeWorkingDirectory(FtpClient.java:468) > at > org.netbeans.modules.php.project.connections.RemoteClient.cdRemoteDirectory(RemoteClient.java:1200) > at > org.netbeans.modules.php.project.connections.RemoteClient.cdBaseRemoteDirectory(RemoteClient.java:1195) > at > org.netbeans.modules.php.project.connections.RemoteClient.uploadFileInternal(RemoteClient.java:382) > at > org.netbeans.modules.php.project.connections.RemoteClient.uploadFile(RemoteClient.java:347) > at > org.netbeans.modules.php.project.connections.RemoteClient.upload(RemoteClient.java:328) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.upload(UploadCommand.java:150) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.uploadFiles(UploadCommand.java:98) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand.invokeActionImpl(UploadCommand.java:82) > at > org.netbeans.modules.php.project.ui.actions.UploadCommand$1.run(UploadCommand.java:69) > at > org.netbeans.modules.php.project.ui.actions.RemoteCommand$1.run(RemoteCommand.java:84) > at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) > at > org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) > at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) > at > org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033) > INFO [org.netbeans.modules.php.project.connections.RemoteClient] > org.apache.commons.net.MalformedServerReplyException: Truncated server reply: > '550 ' > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:374) > at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:300) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:523) > at org.apache.commons.net.ftp.FTPSClient.sendCommand(FTPSClient.java:568) > at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:648) > at org.apache.commons.net.ftp.FTP.cwd(FTP.java:868) > at > org.apache.commons.net.ftp.FTPClient.changeWorkingDirectory(FTPClient.java:1167) > [catch] at > org.netbeans.modules.php.project.connections.ftp.FtpClient.changeWorkingDirectory(FtpClient.java:468) > Caused: org.netbeans.modules.php.project.connections.RemoteException: Cannot > change directory to /test/test. > at > org.netbeans.modules.php.project.connections.ftp.FtpClient.changeWorkingDirectory(FtpClient.java:472) > at >
[netbeans] branch master updated: [NETBEANS-3647] Update FtpClient.java - compatibility with IIS
This is an automated email from the ASF dual-hosted git repository. matthiasblaesing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new c7ca6ed [NETBEANS-3647] Update FtpClient.java - compatibility with IIS new 3fb6652 Merge pull request #1880 from oli0044/patch-2 c7ca6ed is described below commit c7ca6edda3df2773d50b1d04446ac49895e0730d Author: Olivier Seubert AuthorDate: Fri Jan 17 22:20:23 2020 +0100 [NETBEANS-3647] Update FtpClient.java - compatibility with IIS FTP upload stops when uploading to IIS FTP reporting a Truncated server reply: '550 '. The broken behavior can be worked around by configuring the ftp client to be lenitent when parsing server replies. --- .../src/org/netbeans/modules/php/project/connections/ftp/FtpClient.java | 1 + 1 file changed, 1 insertion(+) diff --git a/php/php.project/src/org/netbeans/modules/php/project/connections/ftp/FtpClient.java b/php/php.project/src/org/netbeans/modules/php/project/connections/ftp/FtpClient.java index 6ce7623..f40ad9b 100644 --- a/php/php.project/src/org/netbeans/modules/php/project/connections/ftp/FtpClient.java +++ b/php/php.project/src/org/netbeans/modules/php/project/connections/ftp/FtpClient.java @@ -158,6 +158,7 @@ public class FtpClient implements RemoteClient { if (LOGGER.isLoggable(Level.FINE)) { LOGGER.log(Level.FINE, "Connecting to {0} [timeout: {1} ms]", new Object[] {configuration.getHost(), timeout}); } +ftpClient.setStrictReplyParsing(false); ftpClient.setDefaultTimeout(timeout); ftpClient.setControlKeepAliveReplyTimeout(keepAliveInterval); if (LOGGER.isLoggable(Level.FINE)) { - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans-website] branch asf-site updated: Automated site publishing by Jenkins build 1127
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/netbeans-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 9b6824d Automated site publishing by Jenkins build 1127 9b6824d is described below commit 9b6824d37a3e0f314746e5685fae07b7460897a1 Author: jenkins AuthorDate: Sat Jan 18 10:30:51 2020 + Automated site publishing by Jenkins build 1127 --- content/help/index.html | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/content/help/index.html b/content/help/index.html index 77931f7..9a0835e 100644 --- a/content/help/index.html +++ b/content/help/index.html @@ -107,8 +107,17 @@ - -Note: The learning trails, tutorials, and related documentation are works in progress, incomplete, and being reviewed: https://issues.apache.org/jira/browse/NETBEANS-1867;>NETBEANS-1867. + + + + +Note + + +The learning trails, tutorials, and related documentation are works in progress, incomplete, and being reviewed: https://issues.apache.org/jira/browse/NETBEANS-1867;>NETBEANS-1867. See http://netbeans.apache.org/kb/docs/contributing.html;>our documentation contribution guidelines to learn how you can help us. + + + - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans-website] branch master updated: Updating the documentation main page.
This is an automated email from the ASF dual-hosted git repository. vieiro pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans-website.git The following commit(s) were added to refs/heads/master by this push: new f5c381d Updating the documentation main page. f5c381d is described below commit f5c381d30072cc27320b1851484075ff0484cd7d Author: Antonio Vieiro AuthorDate: Sat Jan 18 11:28:10 2020 +0100 Updating the documentation main page. --- netbeans.apache.org/src/content/help/index.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netbeans.apache.org/src/content/help/index.asciidoc b/netbeans.apache.org/src/content/help/index.asciidoc index 2dbf65c..6806782 100644 --- a/netbeans.apache.org/src/content/help/index.asciidoc +++ b/netbeans.apache.org/src/content/help/index.asciidoc @@ -36,7 +36,7 @@ The following learning trails provide you with everything you need to know to de - link:/kb/docs/ide/index.html[Integration with External Tools and Services] -*Note:* The learning trails, tutorials, and related documentation are works in progress, incomplete, and being reviewed: link:https://issues.apache.org/jira/browse/NETBEANS-1867[NETBEANS-1867]. +NOTE: The learning trails, tutorials, and related documentation are works in progress, incomplete, and being reviewed: link:https://issues.apache.org/jira/browse/NETBEANS-1867[NETBEANS-1867]. See link:http://netbeans.apache.org/kb/docs/contributing.html[our documentation contribution guidelines] to learn how you can help us. == Other resources - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists