[jira] [Created] (NETBEANS-4235) Formatting Issue in Records

2020-04-23 Thread Arunava Sinha (Jira)
Arunava Sinha created NETBEANS-4235:
---

 Summary: Formatting Issue in Records 
 Key: NETBEANS-4235
 URL: https://issues.apache.org/jira/browse/NETBEANS-4235
 Project: NetBeans
  Issue Type: Bug
  Components: java - Editor
Affects Versions: 11.3
Reporter: Arunava Sinha
Assignee: Arunava Sinha


Formatting of below code snippet is not proper in Jdk-14/jdk-15

public record Rec1{}

 

expected output

public record Rec1{

}

actual output

public record Rec1{

        }



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3972) Unable to git commit changes with GPG signing

2020-04-23 Thread Kevin Andrews (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091021#comment-17091021
 ] 

Kevin Andrews commented on NETBEANS-3972:
-

[https://github.com/apache/netbeans/pull/2103]

> Unable to git commit changes with GPG signing
> -
>
> Key: NETBEANS-3972
> URL: https://issues.apache.org/jira/browse/NETBEANS-3972
> Project: NetBeans
>  Issue Type: Bug
>  Components: versioncontrol - Git
>Affects Versions: 12.0, 11.3
>Reporter: Kevin Andrews
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> After setting up git GPG key signing on the repo config:
> {code:java}
> [user] 
> name = XX
> email =  XX
> signingkey = XX
> [commit] 
> gpgsign = true{code}
> I can commit in a terminal and commits are signed, however through NetBeans I 
> get the following error after entering a commit message and clicking commit:
> {code:java}
> 
>   2020-03-06T21:35:15
>   1583530515293
>   21894
>   org.netbeans.ui.focus
>   500
>   138
>   LOG_WINDOW_ACTIVATED
>   LOG_WINDOW_ACTIVATED
>   org.netbeans.core.ui.warmup.Bundle
>   25
> 
> 
>   2020-03-06T21:35:17
>   1583530517740
>   21895
>   org.netbeans.ui.actions
>   400
>   22
>   UI_ACTION_BUTTON_PRESS
>   UI_ACTION_BUTTON_PRESS
>   org.openide.awt.Bundle
>   javax.swing.JMenuItem[Commit...]
>   javax.swing.JMenuItem
>   
> org.netbeans.modules.versioning.util.SystemActionBridge[Commit...]
>   org.netbeans.modules.versioning.util.SystemActionBridge
>   Commit...
> 
> 
>   2020-03-06T21:35:17
>   1583530517740
>   21896
>   org.netbeans.ui.SystemActionBridge
>   400
>   22
>   UI_ACTION_BUTTON_PRESS
>   UI_ACTION_BUTTON_PRESS
>   org.openide.awt.Bundle
>   
>   
>   
> org.netbeans.modules.git.ui.commit.CommitAction[Co&mmit...]
>   org.netbeans.modules.git.ui.commit.CommitAction
>   Co&mmit...
> 
> 
>   2020-03-06T21:35:19
>   1583530519266
>   21898
>   org.netbeans.ui.vcs
>   800
>   138
>   USG_VCS_CMD
>   USG_VCS_CMD
>   org.netbeans.modules.versioning.util.Bundle
>   GIT
>   11
>   0
>   commit
>   INTERNAL
> 
> 
>   2020-03-06T21:35:19
>   1583530519266
>   21899
>   org.netbeans.modules.git
>   800
>   138
>   org.eclipse.jgit.api.errors.JGitInternalException: missing 
> credentials provider
>   
> org.netbeans.libs.git.GitException: 
> org.eclipse.jgit.api.errors.JGitInternalException: missing credentials 
> provider
> 
>   org.netbeans.libs.git.jgit.commands.CommitCommand
>   run
>   153
>   ${netBeansDir}modules/org-netbeans-libs-git.jar
> 
> 
>   org.netbeans.libs.git.jgit.commands.GitCommand$1
>   run
>   57
>   ${netBeansDir}modules/org-netbeans-libs-git.jar
> 
> 
>   org.netbeans.libs.git.jgit.commands.GitCommand$1
>   run
>   54
>   ${netBeansDir}modules/org-netbeans-libs-git.jar
> 
> 
>   java.security.AccessController
>   doPrivileged
>   jrt:/java.base/java/security/AccessController.class
> 
> 
>   org.netbeans.libs.git.jgit.commands.GitCommand
>   execute
>   54
>   ${netBeansDir}modules/org-netbeans-libs-git.jar
> 
> 
>   org.netbeans.libs.git.GitClient
>   commit
>   480
>   ${netBeansDir}modules/org-netbeans-libs-git.jar
> 
> 
>   org.netbeans.modules.git.client.GitClient$9
>   call
>   297
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   org.netbeans.modules.git.client.GitClient$9
>   call
>   293
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   
> org.netbeans.modules.git.client.GitClient$CommandInvoker$1$1
>   call
>   933
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   
> org.netbeans.modules.git.client.GitClient$CommandInvoker$1
>   call
>   956
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   org.netbeans.modules.git.FilesystemInterceptor
>   runWithoutExternalEvents
>   473
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   org.netbeans.modules.git.Git
>   runWithoutExternalEvents
>   259
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   org.netbeans.modules.git.client.GitClient$CommandInvoker
>   runMethodIntern
>   966
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   org.netbeans.modules.git.client.GitClient$CommandInvoker
>   runMethod
>   893
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   org.netbeans.modules.git.client.GitClient$CommandInvoker
>   access$300
>   869
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   org.netbeans.modules.git.client.GitClient
>

[jira] [Commented] (NETBEANS-3972) Unable to git commit changes with GPG signing

2020-04-23 Thread Kevin Andrews (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090997#comment-17090997
 ] 

Kevin Andrews commented on NETBEANS-3972:
-

[~geertjan] I've produced a successful implementation, which I'll pop up in a 
pull request to show the sample.

However personally i'm not happy with the implementation. It involves detecting 
gpgsign = true in the current repo being committed at the GIT UI module level, 
requesting the GPG Private Key Passphrase from the user then providing this to 
the commit() Command via a construct parameter (which changes the signature and 
breaks most of the unit tests (this is the bit i'm not happy with)) the command 
can then provide the gpg private key Passphrase to jgit which then uses 
bouncycastle to perform the gpg key access and signing.

Theoretically what would be a better way to provide this value from 
CommitAction.java through to CommitCommand.java?

The experience is also a little jaring as when selecting git -> commit you then 
get prompted for the GPG Passphrase before entering the commit message, 
selecting files and setting author/committer, so a few improvements needed but 
this is definitely a proof of concept at least :) 

> Unable to git commit changes with GPG signing
> -
>
> Key: NETBEANS-3972
> URL: https://issues.apache.org/jira/browse/NETBEANS-3972
> Project: NetBeans
>  Issue Type: Bug
>  Components: versioncontrol - Git
>Affects Versions: 12.0, 11.3
>Reporter: Kevin Andrews
>Priority: Minor
>
> After setting up git GPG key signing on the repo config:
> {code:java}
> [user] 
> name = XX
> email =  XX
> signingkey = XX
> [commit] 
> gpgsign = true{code}
> I can commit in a terminal and commits are signed, however through NetBeans I 
> get the following error after entering a commit message and clicking commit:
> {code:java}
> 
>   2020-03-06T21:35:15
>   1583530515293
>   21894
>   org.netbeans.ui.focus
>   500
>   138
>   LOG_WINDOW_ACTIVATED
>   LOG_WINDOW_ACTIVATED
>   org.netbeans.core.ui.warmup.Bundle
>   25
> 
> 
>   2020-03-06T21:35:17
>   1583530517740
>   21895
>   org.netbeans.ui.actions
>   400
>   22
>   UI_ACTION_BUTTON_PRESS
>   UI_ACTION_BUTTON_PRESS
>   org.openide.awt.Bundle
>   javax.swing.JMenuItem[Commit...]
>   javax.swing.JMenuItem
>   
> org.netbeans.modules.versioning.util.SystemActionBridge[Commit...]
>   org.netbeans.modules.versioning.util.SystemActionBridge
>   Commit...
> 
> 
>   2020-03-06T21:35:17
>   1583530517740
>   21896
>   org.netbeans.ui.SystemActionBridge
>   400
>   22
>   UI_ACTION_BUTTON_PRESS
>   UI_ACTION_BUTTON_PRESS
>   org.openide.awt.Bundle
>   
>   
>   
> org.netbeans.modules.git.ui.commit.CommitAction[Co&mmit...]
>   org.netbeans.modules.git.ui.commit.CommitAction
>   Co&mmit...
> 
> 
>   2020-03-06T21:35:19
>   1583530519266
>   21898
>   org.netbeans.ui.vcs
>   800
>   138
>   USG_VCS_CMD
>   USG_VCS_CMD
>   org.netbeans.modules.versioning.util.Bundle
>   GIT
>   11
>   0
>   commit
>   INTERNAL
> 
> 
>   2020-03-06T21:35:19
>   1583530519266
>   21899
>   org.netbeans.modules.git
>   800
>   138
>   org.eclipse.jgit.api.errors.JGitInternalException: missing 
> credentials provider
>   
> org.netbeans.libs.git.GitException: 
> org.eclipse.jgit.api.errors.JGitInternalException: missing credentials 
> provider
> 
>   org.netbeans.libs.git.jgit.commands.CommitCommand
>   run
>   153
>   ${netBeansDir}modules/org-netbeans-libs-git.jar
> 
> 
>   org.netbeans.libs.git.jgit.commands.GitCommand$1
>   run
>   57
>   ${netBeansDir}modules/org-netbeans-libs-git.jar
> 
> 
>   org.netbeans.libs.git.jgit.commands.GitCommand$1
>   run
>   54
>   ${netBeansDir}modules/org-netbeans-libs-git.jar
> 
> 
>   java.security.AccessController
>   doPrivileged
>   jrt:/java.base/java/security/AccessController.class
> 
> 
>   org.netbeans.libs.git.jgit.commands.GitCommand
>   execute
>   54
>   ${netBeansDir}modules/org-netbeans-libs-git.jar
> 
> 
>   org.netbeans.libs.git.GitClient
>   commit
>   480
>   ${netBeansDir}modules/org-netbeans-libs-git.jar
> 
> 
>   org.netbeans.modules.git.client.GitClient$9
>   call
>   297
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   org.netbeans.modules.git.client.GitClient$9
>   call
>   293
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   
> org.netbeans.modules.git.client.GitClient$CommandInvoker$1$1
>   call
>   933
>   ${netBeansDir}modules/org-netbeans-modules-git.jar
> 
> 
>   
> org.netbeans.modules.git.client.GitClient$CommandInvoker$1
>   call
>   956
>   ${net

[jira] [Commented] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Ty Young (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090937#comment-17090937
 ] 

Ty Young commented on NETBEANS-4234:


It's written in pure Java, no FXML.

 

The GUI source/binary combobox doesn't work. Clicking "safe" and reopening the 
GUI will show it stuck at 11. The only way to change it is by editing the POM.

 

Otherwise yes, it seems to. I'm having an issue related to incubating features 
but if I'm at that point everything else should be working.

 

> Maven JavaFX based project does not run due to nonvisible runtime
> -
>
> Key: NETBEANS-4234
> URL: https://issues.apache.org/jira/browse/NETBEANS-4234
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Project
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Attempting to run a Maven based JavaFX application, even if auto generated by 
> Netbeans using the Maven based JavaFX template, results in a runtime error 
> that runtime components could not be found:
>  
> Error: JavaFX runtime components are missing, and are required to run this 
> application
>  Command execution failed.
>  org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
> (Exit value: 1)
>  at org.apache.commons.exec.DefaultExecutor.executeInternal 
> (DefaultExecutor.java:404)
>  at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
>  at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>  at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:564)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090913#comment-17090913
 ] 

Geertjan Wielenga commented on NETBEANS-4234:
-

Great that they work fine. :-)

Well, to reproduce a problem, you'll need to provide complete steps.

But those two Gluon OpenJFX samples, between them, one or the other, should 
give you a great starting point.

> Maven JavaFX based project does not run due to nonvisible runtime
> -
>
> Key: NETBEANS-4234
> URL: https://issues.apache.org/jira/browse/NETBEANS-4234
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Project
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Attempting to run a Maven based JavaFX application, even if auto generated by 
> Netbeans using the Maven based JavaFX template, results in a runtime error 
> that runtime components could not be found:
>  
> Error: JavaFX runtime components are missing, and are required to run this 
> application
>  Command execution failed.
>  org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
> (Exit value: 1)
>  at org.apache.commons.exec.DefaultExecutor.executeInternal 
> (DefaultExecutor.java:404)
>  at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
>  at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>  at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:564)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Ty Young (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090909#comment-17090909
 ] 

Ty Young commented on NETBEANS-4234:


Right click dependencies, "add dependency", search for "openJFX", under  
"javafx.controls" select "11.0.1[jar]"? I don't think adding every step is 
adding any value here.

 

Yes, they both work fine. I have to move my project so that it's based on the 
non-FXML one yet.

> Maven JavaFX based project does not run due to nonvisible runtime
> -
>
> Key: NETBEANS-4234
> URL: https://issues.apache.org/jira/browse/NETBEANS-4234
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Project
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Attempting to run a Maven based JavaFX application, even if auto generated by 
> Netbeans using the Maven based JavaFX template, results in a runtime error 
> that runtime components could not be found:
>  
> Error: JavaFX runtime components are missing, and are required to run this 
> application
>  Command execution failed.
>  org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
> (Exit value: 1)
>  at org.apache.commons.exec.DefaultExecutor.executeInternal 
> (DefaultExecutor.java:404)
>  at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
>  at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>  at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:564)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Ty Young (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090909#comment-17090909
 ] 

Ty Young edited comment on NETBEANS-4234 at 4/23/20, 8:21 PM:
--

Right click dependencies, select "add dependency", search for "openJFX", under  
"javafx.controls" select "11.0.1[jar]"? I don't think adding every step is 
adding any value here.

 

Yes, they both work fine. I have to move my project so that it's based on the 
non-FXML one yet.


was (Author: bluegoliath):
Right click dependencies, "add dependency", search for "openJFX", under  
"javafx.controls" select "11.0.1[jar]"? I don't think adding every step is 
adding any value here.

 

Yes, they both work fine. I have to move my project so that it's based on the 
non-FXML one yet.

> Maven JavaFX based project does not run due to nonvisible runtime
> -
>
> Key: NETBEANS-4234
> URL: https://issues.apache.org/jira/browse/NETBEANS-4234
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Project
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Attempting to run a Maven based JavaFX application, even if auto generated by 
> Netbeans using the Maven based JavaFX template, results in a runtime error 
> that runtime components could not be found:
>  
> Error: JavaFX runtime components are missing, and are required to run this 
> application
>  Command execution failed.
>  org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
> (Exit value: 1)
>  at org.apache.commons.exec.DefaultExecutor.executeInternal 
> (DefaultExecutor.java:404)
>  at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
>  at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>  at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:564)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090899#comment-17090899
 ] 

Geertjan Wielenga commented on NETBEANS-4234:
-

OK, and then what must I do, from there?

Can you also try these two, further down in the same list:

FXML JavaFX Maven Archetype (Gluon)
Simple JavaFX Maven Archetype (Gluon)

> Maven JavaFX based project does not run due to nonvisible runtime
> -
>
> Key: NETBEANS-4234
> URL: https://issues.apache.org/jira/browse/NETBEANS-4234
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Project
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Attempting to run a Maven based JavaFX application, even if auto generated by 
> Netbeans using the Maven based JavaFX template, results in a runtime error 
> that runtime components could not be found:
>  
> Error: JavaFX runtime components are missing, and are required to run this 
> application
>  Command execution failed.
>  org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
> (Exit value: 1)
>  at org.apache.commons.exec.DefaultExecutor.executeInternal 
> (DefaultExecutor.java:404)
>  at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
>  at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>  at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:564)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Ty Young (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090894#comment-17090894
 ] 

Ty Young commented on NETBEANS-4234:


New Project -> Java with Maven -> Java Application?

> Maven JavaFX based project does not run due to nonvisible runtime
> -
>
> Key: NETBEANS-4234
> URL: https://issues.apache.org/jira/browse/NETBEANS-4234
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Project
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Attempting to run a Maven based JavaFX application, even if auto generated by 
> Netbeans using the Maven based JavaFX template, results in a runtime error 
> that runtime components could not be found:
>  
> Error: JavaFX runtime components are missing, and are required to run this 
> application
>  Command execution failed.
>  org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
> (Exit value: 1)
>  at org.apache.commons.exec.DefaultExecutor.executeInternal 
> (DefaultExecutor.java:404)
>  at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
>  at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>  at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:564)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090889#comment-17090889
 ] 

Geertjan Wielenga commented on NETBEANS-4234:
-

New Project -> Maven -> Application

That does not exist. I would like to help, but you need to provide step by step 
information to help me to help you.

> Maven JavaFX based project does not run due to nonvisible runtime
> -
>
> Key: NETBEANS-4234
> URL: https://issues.apache.org/jira/browse/NETBEANS-4234
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Project
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Attempting to run a Maven based JavaFX application, even if auto generated by 
> Netbeans using the Maven based JavaFX template, results in a runtime error 
> that runtime components could not be found:
>  
> Error: JavaFX runtime components are missing, and are required to run this 
> application
>  Command execution failed.
>  org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
> (Exit value: 1)
>  at org.apache.commons.exec.DefaultExecutor.executeInternal 
> (DefaultExecutor.java:404)
>  at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
>  at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>  at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:564)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Ty Young (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090884#comment-17090884
 ] 

Ty Young commented on NETBEANS-4234:


Sorry, was going by the Jira severity guide and thought they were.

 

Anyway, doing:

 

New Project -> Maven -> Application and manually adding JavaFX via Maven 
Central DOES NOT work. This what the project was currently made using.

 

However doing:

 

New Project -> Maven -> JavaFX Archetype seems to work fine.

 

I still think the bug report is valid since it should be possible to add JavaFX 
yourself and have everything still work.

> Maven JavaFX based project does not run due to nonvisible runtime
> -
>
> Key: NETBEANS-4234
> URL: https://issues.apache.org/jira/browse/NETBEANS-4234
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Project
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Attempting to run a Maven based JavaFX application, even if auto generated by 
> Netbeans using the Maven based JavaFX template, results in a runtime error 
> that runtime components could not be found:
>  
> Error: JavaFX runtime components are missing, and are required to run this 
> application
>  Command execution failed.
>  org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
> (Exit value: 1)
>  at org.apache.commons.exec.DefaultExecutor.executeInternal 
> (DefaultExecutor.java:404)
>  at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
>  at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>  at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:564)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090882#comment-17090882
 ] 

Geertjan Wielenga commented on NETBEANS-4234:
-

"copy/pasting the same plugins/nbactions into the JavaFX application(not JavaFX 
template)"

What does that mean, in detail? Can you open a new issue and close this one if 
the template you're using now runs correctly? 

Can you consider not making all the issues you create to be blockers?

> Maven JavaFX based project does not run due to nonvisible runtime
> -
>
> Key: NETBEANS-4234
> URL: https://issues.apache.org/jira/browse/NETBEANS-4234
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Project
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Attempting to run a Maven based JavaFX application, even if auto generated by 
> Netbeans using the Maven based JavaFX template, results in a runtime error 
> that runtime components could not be found:
>  
> Error: JavaFX runtime components are missing, and are required to run this 
> application
>  Command execution failed.
>  org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
> (Exit value: 1)
>  at org.apache.commons.exec.DefaultExecutor.executeInternal 
> (DefaultExecutor.java:404)
>  at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
>  at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>  at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:564)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090878#comment-17090878
 ] 

Geertjan Wielenga commented on NETBEANS-4234:
-

Can you help me and tell me what you mean by that template -- which one 
specifically, what is the label that you see in the New Project dialog? What 
are the steps, so that I can reproduce this, please?

> Maven JavaFX based project does not run due to nonvisible runtime
> -
>
> Key: NETBEANS-4234
> URL: https://issues.apache.org/jira/browse/NETBEANS-4234
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Project
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Attempting to run a Maven based JavaFX application, even if auto generated by 
> Netbeans using the Maven based JavaFX template, results in a runtime error 
> that runtime components could not be found:
>  
> Error: JavaFX runtime components are missing, and are required to run this 
> application
>  Command execution failed.
>  org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
> (Exit value: 1)
>  at org.apache.commons.exec.DefaultExecutor.executeInternal 
> (DefaultExecutor.java:404)
>  at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
>  at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>  at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:564)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4233) Modular Ant Based projects does not build on Java 15 due to Nashorn removal

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090874#comment-17090874
 ] 

Geertjan Wielenga commented on NETBEANS-4233:
-

Java 15 is not supported by any release of NetBeans right now.

> Modular Ant Based projects does not build on Java 15 due to Nashorn removal
> ---
>
> Key: NETBEANS-4233
> URL: https://issues.apache.org/jira/browse/NETBEANS-4233
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Ant
>Affects Versions: 12.1
>Reporter: Ty Young
>Priority: Blocker
>
> Modular Ant based projects will no longer build as of JDK 15 due to the 
> removal of the Nashorn Javascript engine. Attempting to build a project that 
> depends on Nashorn will result in the following error:
>  
> Unable to create javax script engine for javascript



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090873#comment-17090873
 ] 

Geertjan Wielenga commented on NETBEANS-4234:
-

Are you sure you're using 12.0 Beta 3:

https://builds.apache.org/view/M-R/view/NetBeans/job/netbeans-TLP/job/netbeans/job/release120/12/artifact/dist/netbeans/

And what, exactly, is "Maven JavaFX based project" -- can you provide the exact 
steps you're taking to create your project?

> Maven JavaFX based project does not run due to nonvisible runtime
> -
>
> Key: NETBEANS-4234
> URL: https://issues.apache.org/jira/browse/NETBEANS-4234
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Project
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Attempting to run a Maven based JavaFX application, even if auto generated by 
> Netbeans using the Maven based JavaFX template, results in a runtime error 
> that runtime components could not be found:
>  
> Error: JavaFX runtime components are missing, and are required to run this 
> application
>  Command execution failed.
>  org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
> (Exit value: 1)
>  at org.apache.commons.exec.DefaultExecutor.executeInternal 
> (DefaultExecutor.java:404)
>  at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
>  at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
>  at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>  at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:564)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Ty Young (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ty Young updated NETBEANS-4234:
---
Description: 
Attempting to run a Maven based JavaFX application, even if auto generated by 
Netbeans using the Maven based JavaFX template, results in a runtime error that 
runtime components could not be found:

 

Error: JavaFX runtime components are missing, and are required to run this 
application
 Command execution failed.
 org.apache.commons.exec.ExecuteException: Process exited with an error: 1 
(Exit value: 1)
 at org.apache.commons.exec.DefaultExecutor.executeInternal 
(DefaultExecutor.java:404)
 at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
 at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
 at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
 at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:210)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:156)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:148)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
 at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
 at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
 at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
 at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
 at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
 at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
 at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke (Method.java:564)
 at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)
 at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
 at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)
 at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

  was:
Attempting to run a Maven based JavaFX application, even if auto generated by 
Netbeans, results in a runtime error that runtime components could not be found:

 

Error: JavaFX runtime components are missing, and are required to run this 
application
Command execution failed.
org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit 
value: 1)
 at org.apache.commons.exec.DefaultExecutor.executeInternal 
(DefaultExecutor.java:404)
 at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
 at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
 at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
 at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:210)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:156)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:148)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
 at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
 at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
 at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
 at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
 at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
 at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
 at jdk.internal.reflect.Delegati

[jira] [Created] (NETBEANS-4234) Maven JavaFX based project does not run due to nonvisible runtime

2020-04-23 Thread Ty Young (Jira)
Ty Young created NETBEANS-4234:
--

 Summary: Maven JavaFX based project does not run due to nonvisible 
runtime
 Key: NETBEANS-4234
 URL: https://issues.apache.org/jira/browse/NETBEANS-4234
 Project: NetBeans
  Issue Type: Bug
  Components: javafx - Project
Affects Versions: 11.2, 12.0
Reporter: Ty Young


Attempting to run a Maven based JavaFX application, even if auto generated by 
Netbeans, results in a runtime error that runtime components could not be found:

 

Error: JavaFX runtime components are missing, and are required to run this 
application
Command execution failed.
org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit 
value: 1)
 at org.apache.commons.exec.DefaultExecutor.executeInternal 
(DefaultExecutor.java:404)
 at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
 at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:764)
 at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:711)
 at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:289)
 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:210)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:156)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:148)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
 at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
 at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
 at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
 at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
 at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
 at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
 at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke (Method.java:564)
 at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)
 at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
 at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)
 at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4233) Modular Ant Based projects does not build on Java 15 due to Nashorn removal

2020-04-23 Thread Ty Young (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090864#comment-17090864
 ] 

Ty Young commented on NETBEANS-4233:


Shouldn't Fix Version being 12.1 and Affects be what I had before(11.2/12)?

> Modular Ant Based projects does not build on Java 15 due to Nashorn removal
> ---
>
> Key: NETBEANS-4233
> URL: https://issues.apache.org/jira/browse/NETBEANS-4233
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Ant
>Affects Versions: 12.1
>Reporter: Ty Young
>Priority: Blocker
>
> Modular Ant based projects will no longer build as of JDK 15 due to the 
> removal of the Nashorn Javascript engine. Attempting to build a project that 
> depends on Nashorn will result in the following error:
>  
> Unable to create javax script engine for javascript



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4131) NetBeans Gradle support not using wrapper

2020-04-23 Thread Laszlo Kishalmi (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090837#comment-17090837
 ] 

Laszlo Kishalmi commented on NETBEANS-4131:
---

Well, that can be fixed. Telling the truth the command line in the output 
window is just for esthetic purpose only.

 

> NetBeans Gradle support not using wrapper
> -
>
> Key: NETBEANS-4131
> URL: https://issues.apache.org/jira/browse/NETBEANS-4131
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Gradle
>Affects Versions: 11.3
>Reporter: Charles George
>Assignee: Laszlo Kishalmi
>Priority: Critical
>
> The NetBeans Gradle support is not actually using the wrapper despite the 
> "Prefer to use Gradle Wrapper that Comes with the Project" checkbox selected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3903) Netbeans 11.2 fails to detect successful startup of Tomcat 9.0.31

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090765#comment-17090765
 ] 

Geertjan Wielenga commented on NETBEANS-3903:
-

This should be fixed in 12.0, can you try with 12.0 Beta 3:

https://builds.apache.org/view/M-R/view/NetBeans/job/netbeans-TLP/job/netbeans/job/release120/12/artifact/dist/netbeans/


> Netbeans 11.2 fails to detect successful startup of Tomcat 9.0.31
> -
>
> Key: NETBEANS-3903
> URL: https://issues.apache.org/jira/browse/NETBEANS-3903
> Project: NetBeans
>  Issue Type: Bug
>  Components: debugger - Java, serverplugins - Tomcat
>Affects Versions: 11.0, 11.1, 11.2, 11.3
> Environment: MacOS Catalina 10.15.3
> Netbeans 11.2 (using installer)
> Netbeans 11.0 (using binary download)
> Tomcat 9.0.31 (via brew and binary download)
> Tomcat 8.5.51 (via brew and binary download)
>Reporter: Rob
>Assignee: Nam Nguyen
>Priority: Blocker
>  Labels: ide, pull-request-available, server, tomcat, tomcat9
> Fix For: 12.0
>
> Attachments: Netbeans11.0-terminal-output.log, Screenshot 2020-02-20 
> at 21.17.36.png, apache-tomcat-9.0.31.zip, netbeans11-2-log.zip, 
> org-netbeans-modules-tomcat5.jar
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> * Example code - Not applicable 
>  * Example project - Not applicable
>  * Attachments...
>  * Screenshot 1) Console shows success whilst minutes later Netbeans error 
> appears
>  * Screenshot 2) Netbeans 11.0 terminal output included and I suspect it the 
> same error in Netbeans 11.2
>  * apache-tomcat-9.0.31.zip that includes the tomcat configuration and logs 
> for one attempt of running Tomcat (all looks good here) 
>  * netbeans11-2-log for the latest Netbeans 11.2 logs
>  * Exact steps 1. Add tomcat server 2. Run tomcat server, 3. Confirm it 
> starts (browser success and console logs success), 4. Minutes later error 
> appears to say "Starting of Tomcat Failed"
>  * Actual results - Tomcat should start than then Netbeans would usually 
> deploy the app, but Netbeans fails to detect Tomcat started successfully.  No 
> projects required to recreate this - starting Tomcat up from within the 
> Netbeans IDE shows success in the console <500ms but then reports as failed 
> minutes later
>  * Expected results - Netbeans should continue to deploy an application once 
> detecting tomcat has started
>  * NetBeans version - Multiple (11.0, 11.2)
>  * JDK version JDK 13 Open JDK and Sun JDK
>  * OS (Environment) Mac Catalina 10.15.3
> Deeper information follows...
> I installed the pre-requisite Open JDK 13 first.
> I had Netbeans 8.2 running on my iMac and decided to install the latest 
> version of Netbeans on my MacBook Pro running Mac OS Catalina 10.15.3, so I 
> opted for the latest NetBeans 11.2 installer.  
> I was surprised to see no 'customise' option during installation to choose 
> Tomcat (which is what used to happen in Netbeans 8.2).  Once Netbeans 11.2 
> was running I went to the server tab and added Tomcat 9.0.31 by pointing to 
> the Tomcat brew installation folder and added a private configuration folder, 
> I entered a new user 'ide' and password and ticked the 'Create user if does 
> not exist'.
> I can confirm it created the user in the tomcat-users.xml file correctly.
> ```
> 
> http://tomcat.apache.org/xml"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; version="1.0" 
> xsi:schemaLocation="http://tomcat.apache.org/xml tomcat-users.xsd">
>  
>  
>  
>   username="ide"/>
> 
> ```
> When I right-click on the server and choose "Start", or "Start in debug mode" 
> tomcat starts and it is confirmed as starting within 317 milliseconds.
> I can load a browser manually and navigate to 
> [http://localhost:8084/manager/status] and confirm Tomcat is indeed running.
> ```
> NOTE: Picked up JDK_JAVA_OPTIONS: --add-opens=java.base/java.lang=ALL-UNNAMED 
> --add-opens=java.base/java.io=ALL-UNNAMED 
> --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED
> 20-Feb-2020 21:09:28.879 INFO [main] 
> org.apache.catalina.startup.VersionLoggerListener.log Server version name: 
> Apache Tomcat/9.0.31
> 20-Feb-2020 21:09:28.883 INFO [main] 
> org.apache.catalina.startup.VersionLoggerListener.log Server built: Feb 5 
> 2020 19:32:12 UTC
> 20-Feb-2020 21:09:28.883 INFO [main] 
> org.apache.catalina.startup.VersionLoggerListener.log Server version number: 
> 9.0.31.0
> 20-Feb-2020 21:09:28.883 INFO [main] 
> org.apache.catalina.startup.VersionLoggerListener.log OS Name: Mac OS X
> 20-Feb-2020 21:09:28.883 INFO [main] 
> org.apache.catalina.startup.VersionLoggerListener.log OS Version: 10.15.3
> 20-Feb-2020 21:09:28.883 INFO [main] 
> org.apache.catalina.startup.VersionLoggerListener.log Architecture: x

[jira] [Commented] (NETBEANS-3903) Netbeans 11.2 fails to detect successful startup of Tomcat 9.0.31

2020-04-23 Thread Frederick Bowman (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090759#comment-17090759
 ] 

Frederick Bowman commented on NETBEANS-3903:


Hi All.

It is the first time I am commenting here.

I have the same issue with Netbeans 11.3 and Apache 9.0.34 on Linux (Fedora).

I have tried replacing the file [^org-netbeans-modules-tomcat5.jar] but had no 
success.

Is there anything else I can do, please? Am I missing something?

Thanks

> Netbeans 11.2 fails to detect successful startup of Tomcat 9.0.31
> -
>
> Key: NETBEANS-3903
> URL: https://issues.apache.org/jira/browse/NETBEANS-3903
> Project: NetBeans
>  Issue Type: Bug
>  Components: debugger - Java, serverplugins - Tomcat
>Affects Versions: 11.0, 11.1, 11.2, 11.3
> Environment: MacOS Catalina 10.15.3
> Netbeans 11.2 (using installer)
> Netbeans 11.0 (using binary download)
> Tomcat 9.0.31 (via brew and binary download)
> Tomcat 8.5.51 (via brew and binary download)
>Reporter: Rob
>Assignee: Nam Nguyen
>Priority: Blocker
>  Labels: ide, pull-request-available, server, tomcat, tomcat9
> Fix For: 12.0
>
> Attachments: Netbeans11.0-terminal-output.log, Screenshot 2020-02-20 
> at 21.17.36.png, apache-tomcat-9.0.31.zip, netbeans11-2-log.zip, 
> org-netbeans-modules-tomcat5.jar
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> * Example code - Not applicable 
>  * Example project - Not applicable
>  * Attachments...
>  * Screenshot 1) Console shows success whilst minutes later Netbeans error 
> appears
>  * Screenshot 2) Netbeans 11.0 terminal output included and I suspect it the 
> same error in Netbeans 11.2
>  * apache-tomcat-9.0.31.zip that includes the tomcat configuration and logs 
> for one attempt of running Tomcat (all looks good here) 
>  * netbeans11-2-log for the latest Netbeans 11.2 logs
>  * Exact steps 1. Add tomcat server 2. Run tomcat server, 3. Confirm it 
> starts (browser success and console logs success), 4. Minutes later error 
> appears to say "Starting of Tomcat Failed"
>  * Actual results - Tomcat should start than then Netbeans would usually 
> deploy the app, but Netbeans fails to detect Tomcat started successfully.  No 
> projects required to recreate this - starting Tomcat up from within the 
> Netbeans IDE shows success in the console <500ms but then reports as failed 
> minutes later
>  * Expected results - Netbeans should continue to deploy an application once 
> detecting tomcat has started
>  * NetBeans version - Multiple (11.0, 11.2)
>  * JDK version JDK 13 Open JDK and Sun JDK
>  * OS (Environment) Mac Catalina 10.15.3
> Deeper information follows...
> I installed the pre-requisite Open JDK 13 first.
> I had Netbeans 8.2 running on my iMac and decided to install the latest 
> version of Netbeans on my MacBook Pro running Mac OS Catalina 10.15.3, so I 
> opted for the latest NetBeans 11.2 installer.  
> I was surprised to see no 'customise' option during installation to choose 
> Tomcat (which is what used to happen in Netbeans 8.2).  Once Netbeans 11.2 
> was running I went to the server tab and added Tomcat 9.0.31 by pointing to 
> the Tomcat brew installation folder and added a private configuration folder, 
> I entered a new user 'ide' and password and ticked the 'Create user if does 
> not exist'.
> I can confirm it created the user in the tomcat-users.xml file correctly.
> ```
> 
> http://tomcat.apache.org/xml"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; version="1.0" 
> xsi:schemaLocation="http://tomcat.apache.org/xml tomcat-users.xsd">
>  
>  
>  
>   username="ide"/>
> 
> ```
> When I right-click on the server and choose "Start", or "Start in debug mode" 
> tomcat starts and it is confirmed as starting within 317 milliseconds.
> I can load a browser manually and navigate to 
> [http://localhost:8084/manager/status] and confirm Tomcat is indeed running.
> ```
> NOTE: Picked up JDK_JAVA_OPTIONS: --add-opens=java.base/java.lang=ALL-UNNAMED 
> --add-opens=java.base/java.io=ALL-UNNAMED 
> --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED
> 20-Feb-2020 21:09:28.879 INFO [main] 
> org.apache.catalina.startup.VersionLoggerListener.log Server version name: 
> Apache Tomcat/9.0.31
> 20-Feb-2020 21:09:28.883 INFO [main] 
> org.apache.catalina.startup.VersionLoggerListener.log Server built: Feb 5 
> 2020 19:32:12 UTC
> 20-Feb-2020 21:09:28.883 INFO [main] 
> org.apache.catalina.startup.VersionLoggerListener.log Server version number: 
> 9.0.31.0
> 20-Feb-2020 21:09:28.883 INFO [main] 
> org.apache.catalina.startup.VersionLoggerListener.log OS Name: Mac OS X
> 20-Feb-2020 21:09:28.883 INFO [main] 
> org.apache.catalina.startup.VersionLoggerListener.log OS Version: 10.15.3
>

[jira] [Updated] (NETBEANS-4233) Modular Ant Based projects no longer build due to Nashorn removal

2020-04-23 Thread Geertjan Wielenga (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Geertjan Wielenga updated NETBEANS-4233:

Affects Version/s: (was: 11.2)
   (was: 12.0)
   12.1

> Modular Ant Based projects no longer build due to Nashorn removal
> -
>
> Key: NETBEANS-4233
> URL: https://issues.apache.org/jira/browse/NETBEANS-4233
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Ant
>Affects Versions: 12.1
>Reporter: Ty Young
>Priority: Blocker
>
> Modular Ant based projects will no longer build as of JDK 15 due to the 
> removal of the Nashorn Javascript engine. Attempting to build a project that 
> depends on Nashorn will result in the following error:
>  
> Unable to create javax script engine for javascript



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4233) Modular Ant Based projects does not build on Java 15 due to Nashorn removal

2020-04-23 Thread Geertjan Wielenga (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Geertjan Wielenga updated NETBEANS-4233:

Summary: Modular Ant Based projects does not build on Java 15 due to 
Nashorn removal  (was: Modular Ant Based projects no longer build due to 
Nashorn removal)

> Modular Ant Based projects does not build on Java 15 due to Nashorn removal
> ---
>
> Key: NETBEANS-4233
> URL: https://issues.apache.org/jira/browse/NETBEANS-4233
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Ant
>Affects Versions: 12.1
>Reporter: Ty Young
>Priority: Blocker
>
> Modular Ant based projects will no longer build as of JDK 15 due to the 
> removal of the Nashorn Javascript engine. Attempting to build a project that 
> depends on Nashorn will result in the following error:
>  
> Unable to create javax script engine for javascript



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4233) Modular Ant Based projects no longer build due to Nashorn removal

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090755#comment-17090755
 ] 

Geertjan Wielenga commented on NETBEANS-4233:
-

 Note that NetBeans explicitly does not support Java 15 at this point. Java 15 
has not yet been released. The 12.1 release of NetBeans will target Java 15 at 
which point this issue should be resolved.

> Modular Ant Based projects no longer build due to Nashorn removal
> -
>
> Key: NETBEANS-4233
> URL: https://issues.apache.org/jira/browse/NETBEANS-4233
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Ant
>Affects Versions: 12.0, 11.2
>Reporter: Ty Young
>Priority: Blocker
>
> Modular Ant based projects will no longer build as of JDK 15 due to the 
> removal of the Nashorn Javascript engine. Attempting to build a project that 
> depends on Nashorn will result in the following error:
>  
> Unable to create javax script engine for javascript



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4233) Modular Ant Based projects no longer build due to Nashorn removal

2020-04-23 Thread Ty Young (Jira)
Ty Young created NETBEANS-4233:
--

 Summary: Modular Ant Based projects no longer build due to Nashorn 
removal
 Key: NETBEANS-4233
 URL: https://issues.apache.org/jira/browse/NETBEANS-4233
 Project: NetBeans
  Issue Type: Bug
  Components: projects - Ant
Affects Versions: 11.2, 12.0
Reporter: Ty Young


Modular Ant based projects will no longer build as of JDK 15 due to the removal 
of the Nashorn Javascript engine. Attempting to build a project that depends on 
Nashorn will result in the following error:

 

Unable to create javax script engine for javascript



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4203) org.netbeans.api.io.InputOutput.reset() doesn't work

2020-04-23 Thread Ernie Rael (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090749#comment-17090749
 ] 

Ernie Rael commented on NETBEANS-4203:
--

Here's a workaround that can be adapted to particular needs
{code:java}
if(true) {
// WORK AROUND RESET PROBLEM
io.close();
io = IOProvider.getDefault().getIO(tabTag, anyFlag);
} else {
io.reset();
}
{code}
 

> org.netbeans.api.io.InputOutput.reset() doesn't work
> 
>
> Key: NETBEANS-4203
> URL: https://issues.apache.org/jira/browse/NETBEANS-4203
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Output Window
>Reporter: Ernie Rael
>Priority: Major
> Attachments: InputOutputReset.jar
>
>
> Test module is attached. The module installs an action "Tools > Input 
> OutputReset Test"
> This test is taken verbatim from the _I/O API SPI Overview_, it is UseCase5:
>  
> [https://bits.netbeans.org/dev/javadoc/org-netbeans-api-io/overview-summary.html]
>  with the "io.show()" added to simplify the observation of the failure.
> After running the test, the output window should only have
> {code:java}
> The pane is now empty and we can reuse it simply
> {code}
> It doesn't; in addition the data from before the "reset()" is still there.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] 01/01: [Travis] Retry java module

2020-04-23 Thread hectorespert
This is an automated email from the ASF dual-hosted git repository.

hectorespert pushed a commit to branch hectorespert-patch-1
in repository https://gitbox.apache.org/repos/asf/netbeans.git

commit 41f57c51ebe7e88e4e2d8069439a41585248283d
Author: Hector Espert 
AuthorDate: Thu Apr 23 18:34:40 2020 +0200

[Travis] Retry java module
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 348e149..1fa0e30 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -449,7 +449,7 @@ matrix:
 - ant $OPTS build
   script:
 - ant $OPTS -f java/java.completion test
-- ant $OPTS -f java/refactoring.java test-unit
+- travis_retry ant $OPTS -f java/refactoring.java test-unit
 
 - name: Test apisupport modules
   jdk: openjdk8


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch hectorespert-patch-1 created (now 41f57c5)

2020-04-23 Thread hectorespert
This is an automated email from the ASF dual-hosted git repository.

hectorespert pushed a change to branch hectorespert-patch-1
in repository https://gitbox.apache.org/repos/asf/netbeans.git.


  at 41f57c5  [Travis] Retry java module

This branch includes the following new commits:

 new 41f57c5  [Travis] Retry java module

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2196) Move field "database" below "user name" & "password" on the new database connection wizard

2020-04-23 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090703#comment-17090703
 ] 

Eirik Bakke commented on NETBEANS-2196:
---

Beware of the difference between a database and a schema--on some backends, you 
can't login without specifying a database (PostgreSQL I believe), and I'm not 
sure it's possible to retrieve a list of databases (though you can retrieve a 
list of schemas within a database, which is shown on the next wizard page). The 
"database" field is something which becomes part of the JDBC URL, which you 
need in order to connect in the first place.

> Move field "database" below "user name" & "password" on the new database 
> connection wizard
> --
>
> Key: NETBEANS-2196
> URL: https://issues.apache.org/jira/browse/NETBEANS-2196
> Project: NetBeans
>  Issue Type: Improvement
>  Components: db - Code
>Affects Versions: Next
>Reporter: Christian Lenz
>Priority: Major
>  Labels: UX
> Attachments: current behaviour.png, wanted behaviour.png
>
>
> To make it clear, it is not that I don't like the Database field above the 
> user credentials, it is that it doesn't make sense for a specific context, 
> which will be handled in an other ticket. First I will choose the connection: 
> localhost + port. This is the first one. There is no login, so I don't know 
> the available databases. Now I want to add my credentials and after it, I 
> want to choose my database which can be known by asking the server to fetch 
> the databases to make it visible inside of the auto completion combo box 
> which is common these days to have this if you have a lot of entries.
> So this ticket is only to moving the field Databases below the credentials 
> because of a new feature coming later. It doesn't make sense to add the 
> database name, before filling all the credentials first. You can't see 
> databases if you not logged into phpmyadmin for example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1901) Font rendering issue - Display bug on a space followed by a tab

2020-04-23 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090697#comment-17090697
 ] 

Eirik Bakke commented on NETBEANS-1901:
---

Once NetBeans 12 is out, please see if this problem still exists. Some 
tab/space alignment issues were fixed by 
https://github.com/apache/netbeans/pull/2076 .

> Font rendering issue - Display bug on a space followed by a tab
> ---
>
> Key: NETBEANS-1901
> URL: https://issues.apache.org/jira/browse/NETBEANS-1901
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Painting & Printing
>Affects Versions: 10.0, 11.0, 11.1
> Environment: Windows 10, MacOS High Sierra & MacOS Mojave
> Netbeans 10, Netbeans 11 & Netbeans 11.1
> JRE 11 & 12
>Reporter: Admeen
>Priority: Minor
>  Labels: editor, formatting
> Attachments: 20190319_actual_result.png, 20190319_example_code.php, 
> 20190319_expected_result.png, 20190320_syntax_settings.png, 
> editor_bug_space_tab.png, formatting_settings.png, netbeans-1901-jy-01.png, 
> netbeans-1901-jy-02.png
>
>
> There appears to be a bug in the editor when a space is followed by a tab. 
> The editor does not display the space and tab, but the space and tab 
> characters are present in the file.
> The editor / code formatting does not appear to be functioning correctly here.
> UPDATE:
> In the tab "Fonts & Colors" in the "Syntax" subtab I had the "default" font 
> set to "Monospaced 16". The issue occurs when using this font size. When I 
> change it back to the default value "Monospaced 13" or "Monospaced 18" it 
> works just fine. After some more testing I found out that with the font set 
> to "Monospaced 10, 11, 12, 14, 15, 16, 17, 19 & 20" it does not work (didn't 
> test higher or lower values).
> UPDATE 2:
> The issue persists in Netbeans version 11.1 now with JRE 12.0.2 installed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-584) Find and Replace boxes not rendered correctly

2020-04-23 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke resolved NETBEANS-584.
--
Resolution: Duplicate

Partially fixed by https://github.com/apache/netbeans/pull/1777 ; further 
improvements depend on https://bugs.openjdk.java.net/browse/JDK-8241561 .

> Find and Replace boxes not rendered correctly
> -
>
> Key: NETBEANS-584
> URL: https://issues.apache.org/jira/browse/NETBEANS-584
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Painting & Printing, editor - Search
>Affects Versions: 9.0
> Environment: Product Version: Apache NetBeans IDE Dev (Build 
> incubator-netbeans-release-205-on-20180202)
> Updates: NetBeans IDE is updated to version NetBeans 8.2 Patch 2
> Java: 10; Java HotSpot(TM) 64-Bit Server VM 10+46
> Runtime: Java(TM) SE Runtime Environment 10+46
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_AU (nb)
> User directory: Z:\tmp\.other\user\netbeans\v09.00-beta\watchdog
> Cache directory: Z:\tmp\.other\cache\netbeans\watchdog-09
>Reporter: will mason
>Priority: Major
>  Labels: Regression, textfield
> Attachments: 2018-04-04 10_09_35-Handler.java - Find.png, 2018-04-04 
> 10_09_35-Handler.java - Replace.png
>
>
> h3. expected
> * Clear rendering with an outline on Find and Replace boxes in editor
> h3. actual
> *  See screenshots -- Both the replace and find boxes are rendered incorrectly
> h3. supporting materials
> * Find dialogue
> * Replace dialogue



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-346) Tabs, characters, and the right Margin don't line up

2020-04-23 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke resolved NETBEANS-346.
--
Fix Version/s: 12.0
   Resolution: Fixed

Marking as resolved as PR was merged.

> Tabs, characters, and the right Margin don't line up
> 
>
> Key: NETBEANS-346
> URL: https://issues.apache.org/jira/browse/NETBEANS-346
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Other
>Affects Versions: 9.0
> Environment: Mac OS 10.10 (at least)
>Reporter: Austin Stephens
>Priority: Critical
>  Labels: HiDPI, font, pull-request-available
> Fix For: 12.0
>
> Attachments: Screen Shot 2018-01-29 at 4.58.35 PM.png, Screen Shot 
> 2018-02-28 at 11.27.32 AM.png, linewidth.png
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When the Right Margin is set at 80 chars, it is drawn at 8*2* chars. This is 
> annoying because I have a 1440x900 screen that I split vertically in to two. 
> This results in two editing areas that are about 80 chars wide. I could see 
> the margin line in both editors when scrolled all the way to the left. Since 
> Netbeans (9.0 beta) is now drawing them at char 8*2*, it is not possible to 
> size those editors so I can see the line in both windows and it is driving me 
> crazy.
> This is a first world issue at the moment, but you might find code coming 
> from mac programmers coming in two or more chars too wide in the Netbeans 
> source code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-4177) IOOBE when editing Java file with temporarily missing comma in method parameter list

2020-04-23 Thread Benjamin Graf (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Graf resolved NETBEANS-4177.
-
Resolution: Fixed

> IOOBE when editing Java file with temporarily missing comma in method 
> parameter list
> 
>
> Key: NETBEANS-4177
> URL: https://issues.apache.org/jira/browse/NETBEANS-4177
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 11.3
> Environment: NetBeans 11.3 with nbjavac plugin installed
>Reporter: Eirik Bakke
>Assignee: Benjamin Graf
>Priority: Major
>  Labels: nbjavac, pull-request-available
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> If, during editing, a comma is momentarily deleted in the parameter list of a 
> method (in certain cases), an error dialog shows up showing an 
> IndexOutOfBoundsException in 
> SemanticHighlighterBase$DetectorVisitor.addParameterInlineHint. A minimized 
> example exhibiting this behavior is as follows:
> {code:java}
> public class BugSemanticHighlighterBase {
>   private Object testMethod(final String arg1 final String arg2) {
> return new String("");
>   }
> }
> {code}
> This example causes the IDE to throw the following exception:
> {noformat}
> java.lang.IndexOutOfBoundsException: -1
>   at com.sun.tools.javac.util.List.get(List.java:482)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.addParameterInlineHint(SemanticHighlighterBase.java:1241)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitLiteral(SemanticHighlighterBase.java:1180)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitLiteral(SemanticHighlighterBase.java:424)
>   at com.sun.tools.javac.tree.JCTree$JCLiteral.accept(JCTree.java:2410)
>   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1199)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:424)
>   at com.sun.source.util.TreeScanner.scan(TreeScanner.java:106)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitNewClass(SemanticHighlighterBase.java:1085)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitNewClass(SemanticHighlighterBase.java:424)
>   at com.sun.tools.javac.tree.JCTree$JCNewClass.accept(JCTree.java:1820)
>   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1199)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:424)
>   at com.sun.source.util.TreeScanner.visitReturn(TreeScanner.java:495)
>   at com.sun.tools.javac.tree.JCTree$JCReturn.accept(JCTree.java:1663)
>   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1199)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:424)
>   at com.sun.source.util.TreeScanner.scan(TreeScanner.java:106)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78)
>   at com.sun.source.util.TreeScanner.visitBlock(TreeScanner.java:249)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1048)
>   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1199)
>   at 
> org.netbeans.modules.java.editor

[jira] [Assigned] (NETBEANS-4177) IOOBE when editing Java file with temporarily missing comma in method parameter list

2020-04-23 Thread Benjamin Graf (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Graf reassigned NETBEANS-4177:
---

Assignee: Benjamin Graf

> IOOBE when editing Java file with temporarily missing comma in method 
> parameter list
> 
>
> Key: NETBEANS-4177
> URL: https://issues.apache.org/jira/browse/NETBEANS-4177
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 11.3
> Environment: NetBeans 11.3 with nbjavac plugin installed
>Reporter: Eirik Bakke
>Assignee: Benjamin Graf
>Priority: Major
>  Labels: nbjavac, pull-request-available
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> If, during editing, a comma is momentarily deleted in the parameter list of a 
> method (in certain cases), an error dialog shows up showing an 
> IndexOutOfBoundsException in 
> SemanticHighlighterBase$DetectorVisitor.addParameterInlineHint. A minimized 
> example exhibiting this behavior is as follows:
> {code:java}
> public class BugSemanticHighlighterBase {
>   private Object testMethod(final String arg1 final String arg2) {
> return new String("");
>   }
> }
> {code}
> This example causes the IDE to throw the following exception:
> {noformat}
> java.lang.IndexOutOfBoundsException: -1
>   at com.sun.tools.javac.util.List.get(List.java:482)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.addParameterInlineHint(SemanticHighlighterBase.java:1241)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitLiteral(SemanticHighlighterBase.java:1180)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitLiteral(SemanticHighlighterBase.java:424)
>   at com.sun.tools.javac.tree.JCTree$JCLiteral.accept(JCTree.java:2410)
>   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1199)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:424)
>   at com.sun.source.util.TreeScanner.scan(TreeScanner.java:106)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitNewClass(SemanticHighlighterBase.java:1085)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitNewClass(SemanticHighlighterBase.java:424)
>   at com.sun.tools.javac.tree.JCTree$JCNewClass.accept(JCTree.java:1820)
>   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1199)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:424)
>   at com.sun.source.util.TreeScanner.visitReturn(TreeScanner.java:495)
>   at com.sun.tools.javac.tree.JCTree$JCReturn.accept(JCTree.java:1663)
>   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1199)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:424)
>   at com.sun.source.util.TreeScanner.scan(TreeScanner.java:106)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78)
>   at com.sun.source.util.TreeScanner.visitBlock(TreeScanner.java:249)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1048)
>   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
>   at 
> org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69)
>   at 
> org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1199)
>   at 
> org.netbeans.modules.

[netbeans] branch master updated: [NETBEANS-346] Tabs, characters, and the right Margin don't line up

2020-04-23 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new d2e893c  [NETBEANS-346] Tabs, characters, and the right Margin don't 
line up
 new 1a8548d  Merge pull request #2076 from eirikbakke/NETBEANS-346
d2e893c is described below

commit d2e893c3b30611beb823e7d7c758b90acd41f6be
Author: Eirik Bakke 
AuthorDate: Mon Apr 13 17:36:46 2020 -0400

[NETBEANS-346] Tabs, characters, and the right Margin don't line up
---
 .../org/netbeans/modules/editor/lib2/view/FontInfo.java| 14 --
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git 
a/ide/editor.lib2/src/org/netbeans/modules/editor/lib2/view/FontInfo.java 
b/ide/editor.lib2/src/org/netbeans/modules/editor/lib2/view/FontInfo.java
index f188a2f..e9185d7 100644
--- a/ide/editor.lib2/src/org/netbeans/modules/editor/lib2/view/FontInfo.java
+++ b/ide/editor.lib2/src/org/netbeans/modules/editor/lib2/view/FontInfo.java
@@ -91,8 +91,18 @@ final class FontInfo {
 TextLayout rowHeightTextLayout = new TextLayout("A_|B", renderFont, 
frc);
 // Round the ascent to eliminate long mantissa without any visible 
effect on rendering.
 updateRowHeight(rowHeightTextLayout, rowHeightCorrection);
-// Ceil fractions to whole numbers since this measure may be used for 
background rendering
-charWidth = (float) Math.ceil(defaultCharTextLayout.getAdvance());
+/* We originally did Math.ceil() when setting charWidth, but this was 
the cause of NETBEANS-346,
+where the end-of-line marker (SimpleValueNames.TEXT_LIMIT_WIDTH) would 
appear in the wrong
+position due to rounding errors, and similar misalignments in tabs vs. 
spaces, on certain editor
+zoom levels. This was observed on Java 9 or above on both Windows and 
MacOS. Java 9 saw many
+changes in font metrics implementations, including a new font shaping 
engine (HarfBuzz) and
+fractional HiDPI support. Avoiding Math.ceil fixes the problem. The 
original Math.ceil was
+introduced by Miloslav Metelka on 2011-08-18, with a comment "Ceil 
fractions to whole numbers
+since this measure may be used for background rendering" in the commit 
titled "Improve
+AnnotationView performance" for the similarly titled BugZilla bug 
#201102. So the Math.ceil was
+intended to be an optimization rather than fixing a correctness bug, 
and it seems safe to remove
+it. */
+charWidth = defaultCharTextLayout.getAdvance();
 LineMetrics lineMetrics = renderFont.getLineMetrics(defaultCharText, 
frc);
 underlineAndStrike[0] = lineMetrics.getUnderlineOffset() * 
rowHeightCorrection;
 underlineAndStrike[1] = lineMetrics.getUnderlineThickness();


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated (b440455 -> 439d079)

2020-04-23 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git.


from b440455  Merge pull request #2097 from errael/MavenCreateNewModule
 new 834bd75  Preventing AssertionError from javac due to use of incorrect 
scope on JDK12+
 new 12200ba  Merge branch 'master' into avoid-assert-in-scope
 new 439d079  Merge pull request #2083 from jlahoda/avoid-assert-in-scope

The 3877 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../netbeans/api/java/source/TreeUtilities.java| 14 ++-
 .../api/java/source/TreeUtilitiesTest.java | 48 ++
 2 files changed, 61 insertions(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-4206] Only set project location once directly from PROJECT_PARENT_FOLDER

2020-04-23 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new d30ce07  [NETBEANS-4206] Only set project location once directly from 
PROJECT_PARENT_FOLDER
 new b440455  Merge pull request #2097 from errael/MavenCreateNewModule
d30ce07 is described below

commit d30ce073feb034aeaeae326de7a418585dd160ea
Author: Ernie Rael 
AuthorDate: Wed Apr 22 05:32:32 2020 +0100

[NETBEANS-4206] Only set project location once directly from 
PROJECT_PARENT_FOLDER
---
 .../modules/maven/newproject/BasicPanelVisual.java | 23 ++
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git 
a/java/maven/src/org/netbeans/modules/maven/newproject/BasicPanelVisual.java 
b/java/maven/src/org/netbeans/modules/maven/newproject/BasicPanelVisual.java
index 548c106..2f5b873 100644
--- a/java/maven/src/org/netbeans/modules/maven/newproject/BasicPanelVisual.java
+++ b/java/maven/src/org/netbeans/modules/maven/newproject/BasicPanelVisual.java
@@ -567,6 +567,7 @@ public class BasicPanelVisual extends JPanel implements 
DocumentListener, Window
 });
 }
 
+private static final String SETTINGS_HAVE_READ = 
"BasicPanelVisual-read-properties-before"; //NOI18N
 @Messages({
 "# {0} - project count", "TXT_MavenProjectName=mavenproject{0}",
 "TXT_Checking1=Checking additional creation properties..."
@@ -578,13 +579,27 @@ public class BasicPanelVisual extends JPanel implements 
DocumentListener, Window
 handle = null;
 }
 }
-// PROJECT_PARENT_FOLDER confusing, better name is PROJECT_BASE_FOLDER
+// PROJECT_PARENT_FOLDER usage is confusing. Sometimes it's the
+// parent directory, sometimes it's the project directory.
+// Maybe introduce PROJECT_BASE_FOLDER, to clarify and differentiate.
+// But for local fix [NETBEANS-4206] keep track of whether
+// these properties have been read before.
+boolean haveRead =  
Boolean.parseBoolean((String)settings.getProperty(SETTINGS_HAVE_READ)); //NOI18N
 File projectFolder = (File) 
settings.getProperty(CommonProjectActions.PROJECT_PARENT_FOLDER); //NOI18N
 File projectLocation;
-if (projectFolder == null || projectFolder.getParentFile() == null || 
!projectFolder.getParentFile().isDirectory()) {
-projectLocation = ProjectChooser.getProjectsFolder();
+if(!haveRead && projectFolder != null) {
+// First time in here, dialog was started with project folder;
+// example is creating a project from pom parent
+projectLocation = projectFolder;
 } else {
-projectLocation = projectFolder.getParentFile();
+if (projectFolder == null || projectFolder.getParentFile() == null 
|| !projectFolder.getParentFile().isDirectory()) {
+projectLocation = ProjectChooser.getProjectsFolder();
+} else {
+projectLocation = projectFolder.getParentFile();
+}
+}
+if(!haveRead) {
+settings.putProperty(SETTINGS_HAVE_READ, "true"); //NOI18N
 }
 
this.projectLocationTextField.setText(projectLocation.getAbsolutePath());
 


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-4173] Update FlatLaf from 0.30 to 0.31

2020-04-23 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 00465e5  [NETBEANS-4173] Update FlatLaf from 0.30 to 0.31
 new 601151b  Merge pull request #2094 from DevCharly/flatlaf-0.31
00465e5 is described below

commit 00465e52517a362b7397eaaa2db02d95819ed560
Author: Karl Tauber 
AuthorDate: Mon Apr 20 13:20:16 2020 +0200

[NETBEANS-4173] Update FlatLaf from 0.30 to 0.31
---
 platform/libs.flatlaf/external/binaries-list  | 2 +-
 .../external/{flatlaf-0.30-license.txt => flatlaf-0.31-license.txt}   | 4 ++--
 platform/libs.flatlaf/nbproject/project.properties| 2 +-
 platform/libs.flatlaf/nbproject/project.xml   | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/platform/libs.flatlaf/external/binaries-list 
b/platform/libs.flatlaf/external/binaries-list
index f281b16..c4846fd 100644
--- a/platform/libs.flatlaf/external/binaries-list
+++ b/platform/libs.flatlaf/external/binaries-list
@@ -15,4 +15,4 @@
 # specific language governing permissions and limitations
 # under the License.
 
-1EBD625C1844170CEBC7BCF02856E5E2DD396070 com.formdev:flatlaf:0.30
+AFD85ED83238E56BD032FB05471781C6E54AD6F2 com.formdev:flatlaf:0.31
diff --git a/platform/libs.flatlaf/external/flatlaf-0.30-license.txt 
b/platform/libs.flatlaf/external/flatlaf-0.31-license.txt
similarity index 99%
rename from platform/libs.flatlaf/external/flatlaf-0.30-license.txt
rename to platform/libs.flatlaf/external/flatlaf-0.31-license.txt
index 4287006..594cfba 100644
--- a/platform/libs.flatlaf/external/flatlaf-0.30-license.txt
+++ b/platform/libs.flatlaf/external/flatlaf-0.31-license.txt
@@ -1,7 +1,7 @@
 Name: FlatLaf Look and Feel
 Description: FlatLaf Look and Feel
-Version: 0.30
-Files: flatlaf-0.30.jar
+Version: 0.31
+Files: flatlaf-0.31.jar
 License: Apache-2.0
 Origin: FormDev Software GmbH.
 URL: https://www.formdev.com/flatlaf/
diff --git a/platform/libs.flatlaf/nbproject/project.properties 
b/platform/libs.flatlaf/nbproject/project.properties
index 9db7c18..151b673 100644
--- a/platform/libs.flatlaf/nbproject/project.properties
+++ b/platform/libs.flatlaf/nbproject/project.properties
@@ -20,4 +20,4 @@ javac.compilerargs=-Xlint:unchecked
 javac.source=1.8
 nbm.target.cluster=platform
 
-release.external/flatlaf-0.30.jar=modules/ext/flatlaf-0.30.jar
+release.external/flatlaf-0.31.jar=modules/ext/flatlaf-0.31.jar
diff --git a/platform/libs.flatlaf/nbproject/project.xml 
b/platform/libs.flatlaf/nbproject/project.xml
index ec7f9b7..d81c026 100644
--- a/platform/libs.flatlaf/nbproject/project.xml
+++ b/platform/libs.flatlaf/nbproject/project.xml
@@ -30,8 +30,8 @@
 com.formdev.flatlaf.util
 
 
-
ext/flatlaf-0.30.jar
-external/flatlaf-0.30.jar
+
ext/flatlaf-0.31.jar
+external/flatlaf-0.31.jar
 
 
 


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-4084] Fix Gradle Projects Wizard to remember the last used Project Directory

2020-04-23 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 605b4f3  [NETBEANS-4084] Fix Gradle Projects Wizard to remember the 
last used Project Directory
 new 9393d69  Merge pull request #2096 from lkishalmi/NETBEANS-4084
605b4f3 is described below

commit 605b4f3431428e1a5eab88c8232164eac7b3ada6
Author: Laszlo Kishalmi 
AuthorDate: Tue Apr 21 11:44:16 2020 -0700

[NETBEANS-4084] Fix Gradle Projects Wizard to remember the last used 
Project Directory
---
 .../modules/gradle/newproject/ProjectAttributesPanelVisual.java   | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/groovy/gradle/src/org/netbeans/modules/gradle/newproject/ProjectAttributesPanelVisual.java
 
b/groovy/gradle/src/org/netbeans/modules/gradle/newproject/ProjectAttributesPanelVisual.java
index 169bcac..caf8d26 100644
--- 
a/groovy/gradle/src/org/netbeans/modules/gradle/newproject/ProjectAttributesPanelVisual.java
+++ 
b/groovy/gradle/src/org/netbeans/modules/gradle/newproject/ProjectAttributesPanelVisual.java
@@ -368,8 +368,10 @@ public final class ProjectAttributesPanelVisual extends 
JPanel implements Docume
 }
 
 void write(WizardDescriptor settings) {
+File projectFolder = new File(tfProjectLocation.getText());
+ProjectChooser.setProjectsFolder(projectFolder);
 settings.putProperty(CommonProjectActions.PROJECT_PARENT_FOLDER,
-new File(tfProjectLocation.getText()));
+projectFolder);
 settings.putProperty(PROP_NAME, tfProjectName.getText());
 settings.putProperty(PROP_GROUP, tfGroup.getText());
 settings.putProperty(PROP_VERSION, tfVersion.getText());


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-4177] Add another check for valid parameter list position to avoid exception if sourcecode is incorrect

2020-04-23 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 5aea1fb  [NETBEANS-4177] Add another check for valid parameter list 
position to avoid exception if sourcecode is incorrect
 new 976501a  Merge pull request #2082 from graben/NETBEANS-4177
5aea1fb is described below

commit 5aea1fb3704f48abac571b04eb153507e39b59d3
Author: Benjamin Graf 
AuthorDate: Wed Apr 15 20:27:44 2020 +0200

[NETBEANS-4177] Add another check for valid parameter list position to 
avoid exception if sourcecode is incorrect
---
 .../base/semantic/SemanticHighlighterBase.java   | 20 +++-
 .../java/editor/base/semantic/DetectorTest.java  | 18 ++
 2 files changed, 29 insertions(+), 9 deletions(-)

diff --git 
a/java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
 
b/java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
index 51bf0a4..00d3687 100644
--- 
a/java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
+++ 
b/java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
@@ -1230,15 +1230,17 @@ public abstract class SemanticHighlighterBase extends 
JavaParserResultTask {
 long end = start + 1;
 ExecutableElement invokedMethod = (ExecutableElement) 
invoked;
 pos = Math.min(pos, 
invokedMethod.getParameters().size() - 1);
-boolean shouldBeAdded = true;
-if (tree.getKind() == Kind.IDENTIFIER &&
-
invokedMethod.getParameters().get(pos).getSimpleName().equals(
-
IdentifierTree.class.cast(tree).getName())) {
-shouldBeAdded = false;
-}
-if (shouldBeAdded) {
-preText.put(new int[] {(int) start, (int) end},
-
invokedMethod.getParameters().get(pos).getSimpleName() + ":");
+if (pos != (-1)) {
+boolean shouldBeAdded = true;
+if (tree.getKind() == Kind.IDENTIFIER &&
+
invokedMethod.getParameters().get(pos).getSimpleName().equals(
+
IdentifierTree.class.cast(tree).getName())) {
+shouldBeAdded = false;
+}
+if (shouldBeAdded) {
+preText.put(new int[] {(int) start, (int) end},
+
invokedMethod.getParameters().get(pos).getSimpleName() + ":");
+}
 }
 }
 }
diff --git 
a/java/java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/DetectorTest.java
 
b/java/java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/DetectorTest.java
index 52d3538..03cd5e6 100644
--- 
a/java/java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/DetectorTest.java
+++ 
b/java/java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/DetectorTest.java
@@ -646,6 +646,24 @@ public class DetectorTest extends TestBase {
 "[PUBLIC, METHOD], 2:46-2:53");
 }
 
+public void testInvalidParameterList() throws Exception {
+setShowPrependedText(true);
+performTest("Test.java",
+"public class BugSemanticHighlighterBase {\n" +
+"private Object testMethod(final String arg1 final 
String arg2) {\n" +
+"return new String(\"\");\n" +
+"}\n" +
+"}\n",
+"[PUBLIC, CLASS, DECLARATION], 0:13-0:39",
+"[PUBLIC, CLASS], 1:12-1:18",
+"[PRIVATE, METHOD, UNUSED, DECLARATION], 1:19-1:29",
+"[PUBLIC, CLASS], 1:36-1:42",
+"[PARAMETER, UNUSED, DECLARATION], 1:43-1:47",
+"[PUBLIC, CLASS], 1:54-1:60",
+"[PACKAGE_PRIVATE, FIELD, DECLARATION], 1:61-1:65",
+"[PACKAGE_PRIVATE, CONSTRUCTOR], 2:19-2:25");
+}
+
 private void performTest(String fileName) throws Exception {
 performTest(fileName, new Performer() {
 public void compute(CompilationController parameter, Document doc, 
final ErrorDescriptionSetter setter) {


-
To unsubscribe, e-mail: commits-unsubscr...@n

[jira] [Updated] (NETBEANS-4232) Have to restart NetBeans to Change JDK

2020-04-23 Thread Jira


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

高浩 updated NETBEANS-4232:
-
Issue Type: Bug  (was: Improvement)

> Have to restart NetBeans to Change JDK
> --
>
> Key: NETBEANS-4232
> URL: https://issues.apache.org/jira/browse/NETBEANS-4232
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Maven
>Affects Versions: 11.3
>Reporter: 高浩
>Priority: Major
> Attachments: change java dependencies.png
>
>
> To change the Jave Dependencies of a Maven project, choose another JDK via 
> Options > Java > Maven > Default JDK, but it doesn't work at once. I must 
> restart the IDE, which is annoying! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4131) NetBeans Gradle support not using wrapper

2020-04-23 Thread Noel Grandin (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090613#comment-17090613
 ] 

Noel Grandin commented on NETBEANS-4131:


One suggestion - gradle by default will have 2 wrapper files. One with name

  gradlew

which is meant to be executed on Unix systems

and

  gradlew.bat

which is meant to be executed on Windows systems.

Now you just do "./gradlew" from the command line, Windows will pick the right 
file.

But perhaps something changed recently in the Netbeans code to execute external 
stuff, and it is now picking the wrong file?

 

> NetBeans Gradle support not using wrapper
> -
>
> Key: NETBEANS-4131
> URL: https://issues.apache.org/jira/browse/NETBEANS-4131
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Gradle
>Affects Versions: 11.3
>Reporter: Charles George
>Assignee: Laszlo Kishalmi
>Priority: Critical
>
> The NetBeans Gradle support is not actually using the wrapper despite the 
> "Prefer to use Gradle Wrapper that Comes with the Project" checkbox selected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4232) Have to restart NetBeans to Change JDK

2020-04-23 Thread Jira


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

高浩 updated NETBEANS-4232:
-
Attachment: change java dependencies.png

> Have to restart NetBeans to Change JDK
> --
>
> Key: NETBEANS-4232
> URL: https://issues.apache.org/jira/browse/NETBEANS-4232
> Project: NetBeans
>  Issue Type: Improvement
>  Components: projects - Maven
>Affects Versions: 11.3
>Reporter: 高浩
>Priority: Major
> Attachments: change java dependencies.png
>
>
> To change the Jave Dependencies of a Maven project, choose another JDK via 
> Options > Java > Maven > Default JDK, but it doesn't work at once. I must 
> restart the IDE, which is annoying! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4232) Have to restart NetBeans to Change JDK

2020-04-23 Thread Jira
高浩 created NETBEANS-4232:


 Summary: Have to restart NetBeans to Change JDK
 Key: NETBEANS-4232
 URL: https://issues.apache.org/jira/browse/NETBEANS-4232
 Project: NetBeans
  Issue Type: Improvement
  Components: projects - Maven
Affects Versions: 11.3
Reporter: 高浩


To change the Jave Dependencies of a Maven project, choose another JDK via 
Options > Java > Maven > Default JDK, but it doesn't work at once. I must 
restart the IDE, which is annoying! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4231) Compilation errors on wrong referenced method signature not shown in java code editor

2020-04-23 Thread Br Tr (Jira)
Br Tr created NETBEANS-4231:
---

 Summary: Compilation errors on wrong referenced method signature 
not shown in java code editor
 Key: NETBEANS-4231
 URL: https://issues.apache.org/jira/browse/NETBEANS-4231
 Project: NetBeans
  Issue Type: Bug
  Components: java - Editor
Affects Versions: 11.3
 Environment: Windows 10, netbeans runs on Amazon Corretto JDK 11.
Reporter: Br Tr


Such errors as in the code below (a reference to the 'wrongMethod' - when the 
signature does not match) are not shown (not underlined in red with an error 
description on hovering cursor over it) in the java code editor.  This is a 
compilation error that's not shown.  You can see it in the 'Acion Items' 
window/pane though - it's the only place you can check what is wrong with the 
code (without compiling the project and looking at the compiler output).

Build systems checked for the issue - Gradle, Maven.
This issue slows down working with method references - an error is not visible 
as soon as it can be seen.

 

 
{code:java}
package some.package;

import java.util.HashMap; 
import java.util.Map;


public class NetbeansError {
  @FunctionalInterface
  public static interface FunctionalInterfaceToUse {
void doSomething(String whatSomething);
  }
  private final Map methodReferences = new 
HashMap<>();
  public NetbeansError() {
   methodReferences.put("correctReferenceKey", this::correctMethod);
   methodReferences.put("wrongReferenceKey", this::wrongMethod);// This line 
should be underlined in red with error description visible in the editor 
tooltip like other compilation errors
   }
  public void wrongMethod(Integer aStringParameterThatIsCorrect) {
  }
  public void correctMethod(String aStringParameterThatIsCorrect) {
  }
}
{code}
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4222) Open up more of APIs in Node and PropertySheet

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090373#comment-17090373
 ] 

Geertjan Wielenga commented on NETBEANS-4222:
-

Note there’ll need to be spec incrementation and an API review. Best would be 
to open a new thread about this proposal on the dev mailing list.

> Open up more of APIs in Node and PropertySheet
> --
>
> Key: NETBEANS-4222
> URL: https://issues.apache.org/jira/browse/NETBEANS-4222
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Explorer, platform - Nodes
>Reporter: Markus Sunela
>Priority: Minor
>
> Currently it is hard to customize Node, Explorer and PropertySheet behavior, 
> because there are too many private instead of protected methods, package 
> private and final classes in the API.
> Some examples I have stumbled on include
>  * private doSetNodes method in PropertySheet (no way to override the use of 
> ProxyNodes)
>  * final and package private ProxyNode class
>  * package private constructor in ProxyNode
>  * package private getOriginalNodes method in ProxyNode
>  * package private and final {color:#00}ProxyProperty{color} class in 
> ProxyNode
>  * final Sheet class and its inner class Sheet.Set
>  * most private methods in Sheet and Sheet.Set should be protected instead
>  * PropertySupport.Reflection class should have getters for read and write 
> methods
> I wonder, what is the rationale for so strict and static API design? I would 
> assume the performance gains from these limitations are meager. Opening these 
> classes for sub-classing and modifications would result in much more flexible 
> system with much less code duplication.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4222) Open up more of APIs in Node and PropertySheet

2020-04-23 Thread Markus Sunela (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Markus Sunela updated NETBEANS-4222:

External issue URL: https://github.com/apache/netbeans/pull/2099

Added a pull request on Github for this.

> Open up more of APIs in Node and PropertySheet
> --
>
> Key: NETBEANS-4222
> URL: https://issues.apache.org/jira/browse/NETBEANS-4222
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Explorer, platform - Nodes
>Reporter: Markus Sunela
>Priority: Minor
>
> Currently it is hard to customize Node, Explorer and PropertySheet behavior, 
> because there are too many private instead of protected methods, package 
> private and final classes in the API.
> Some examples I have stumbled on include
>  * private doSetNodes method in PropertySheet (no way to override the use of 
> ProxyNodes)
>  * final and package private ProxyNode class
>  * package private constructor in ProxyNode
>  * package private getOriginalNodes method in ProxyNode
>  * package private and final {color:#00}ProxyProperty{color} class in 
> ProxyNode
>  * final Sheet class and its inner class Sheet.Set
>  * most private methods in Sheet and Sheet.Set should be protected instead
>  * PropertySupport.Reflection class should have getters for read and write 
> methods
> I wonder, what is the rationale for so strict and static API design? I would 
> assume the performance gains from these limitations are meager. Opening these 
> classes for sub-classing and modifications would result in much more flexible 
> system with much less code duplication.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-4222) Open up more of APIs in Node and PropertySheet

2020-04-23 Thread Markus Sunela (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090372#comment-17090372
 ] 

Markus Sunela edited comment on NETBEANS-4222 at 4/23/20, 7:59 AM:
---

Added a pull request on Github for this: 
https://github.com/apache/netbeans/pull/2099.


was (Author: markus.sun...@fluidit.fi):
Added a pull request on Github for this.

> Open up more of APIs in Node and PropertySheet
> --
>
> Key: NETBEANS-4222
> URL: https://issues.apache.org/jira/browse/NETBEANS-4222
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Explorer, platform - Nodes
>Reporter: Markus Sunela
>Priority: Minor
>
> Currently it is hard to customize Node, Explorer and PropertySheet behavior, 
> because there are too many private instead of protected methods, package 
> private and final classes in the API.
> Some examples I have stumbled on include
>  * private doSetNodes method in PropertySheet (no way to override the use of 
> ProxyNodes)
>  * final and package private ProxyNode class
>  * package private constructor in ProxyNode
>  * package private getOriginalNodes method in ProxyNode
>  * package private and final {color:#00}ProxyProperty{color} class in 
> ProxyNode
>  * final Sheet class and its inner class Sheet.Set
>  * most private methods in Sheet and Sheet.Set should be protected instead
>  * PropertySupport.Reflection class should have getters for read and write 
> methods
> I wonder, what is the rationale for so strict and static API design? I would 
> assume the performance gains from these limitations are meager. Opening these 
> classes for sub-classing and modifications would result in much more flexible 
> system with much less code duplication.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4230) Window not updated after importing editor hints

2020-04-23 Thread Aldo Brucale (Jira)
Aldo Brucale created NETBEANS-4230:
--

 Summary: Window not updated after importing editor hints
 Key: NETBEANS-4230
 URL: https://issues.apache.org/jira/browse/NETBEANS-4230
 Project: NetBeans
  Issue Type: Bug
  Components: editor - Hints & Annotations
Affects Versions: 12.0
Reporter: Aldo Brucale


Steps from a NetCAT test:

 # open project properties
 # select hints tab
 # select *Use project specific options*
 # click on *Advanced*
 # select config file (from another project using project specific hints)
 # confirm

The layout of the tab is not updated correctly, and the checkboxes still show 
the previous values. Reopening the Properties tab shows the values as correctly 
imported, but the old cfg_hints.xml is still there



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4229) Missing JoinConsecutiveIfsIntoIfElse hint

2020-04-23 Thread Aldo Brucale (Jira)
Aldo Brucale created NETBEANS-4229:
--

 Summary: Missing JoinConsecutiveIfsIntoIfElse hint
 Key: NETBEANS-4229
 URL: https://issues.apache.org/jira/browse/NETBEANS-4229
 Project: NetBeans
  Issue Type: Bug
  Components: java - Hints
Affects Versions: 12.0
Reporter: Aldo Brucale


In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 in \{{JoinConsecutiveIfsIntoIfElse.java}} the hint at line 8 is missing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4228) Missing SuspiciousNamesCombination hint

2020-04-23 Thread Aldo Brucale (Jira)
Aldo Brucale created NETBEANS-4228:
--

 Summary: Missing SuspiciousNamesCombination hint
 Key: NETBEANS-4228
 URL: https://issues.apache.org/jira/browse/NETBEANS-4228
 Project: NetBeans
  Issue Type: Bug
  Components: java - Hints
Affects Versions: 12.0
Reporter: Aldo Brucale


In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 in {{SuspiciousNamesCombination.java}} the hint at line 18 is missing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4223) Missing UseSpecificCatch hint

2020-04-23 Thread Aldo Brucale (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aldo Brucale updated NETBEANS-4223:
---
Description: In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 in {{UseSpecificCatch.java}} the hint at line 20 is not shown, and the hint at 
line 26 is missing  (was: In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 in {{UseSpecificCatch.java}} the hint at line 20 is not shown, and the hint at 
line 26 is shown when it shouldn't

 

 

 )

> Missing UseSpecificCatch hint
> -
>
> Key: NETBEANS-4223
> URL: https://issues.apache.org/jira/browse/NETBEANS-4223
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Hints
>Affects Versions: 12.0
>Reporter: Aldo Brucale
>Priority: Minor
>
> In this [test 
> project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
>  in {{UseSpecificCatch.java}} the hint at line 20 is not shown, and the hint 
> at line 26 is missing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4227) Missing EqualsOnIncompatibleTypes hint

2020-04-23 Thread Aldo Brucale (Jira)
Aldo Brucale created NETBEANS-4227:
--

 Summary: Missing EqualsOnIncompatibleTypes hint
 Key: NETBEANS-4227
 URL: https://issues.apache.org/jira/browse/NETBEANS-4227
 Project: NetBeans
  Issue Type: Bug
  Components: java - Hints
Affects Versions: 12.0
Reporter: Aldo Brucale


In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 in \{{_EqualsOnIncompatibleTypes.java}} the hint at line 13 is missing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4226) Missing AddUnderscores hint

2020-04-23 Thread Aldo Brucale (Jira)
Aldo Brucale created NETBEANS-4226:
--

 Summary: Missing AddUnderscores hint
 Key: NETBEANS-4226
 URL: https://issues.apache.org/jira/browse/NETBEANS-4226
 Project: NetBeans
  Issue Type: Bug
  Components: java - Hints
Affects Versions: 12.0
Reporter: Aldo Brucale


In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 in \{{AddUnderscores.java}} the hint at line 10 is missing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4225) Missing StaticImports hint

2020-04-23 Thread Aldo Brucale (Jira)
Aldo Brucale created NETBEANS-4225:
--

 Summary: Missing StaticImports hint
 Key: NETBEANS-4225
 URL: https://issues.apache.org/jira/browse/NETBEANS-4225
 Project: NetBeans
  Issue Type: Bug
  Components: java - Hints
Affects Versions: 12.0
Reporter: Aldo Brucale


In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 in {{StaticImports.java}} the hint at line 5 is missing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4224) Missing TooBroadCatchClause hint

2020-04-23 Thread Aldo Brucale (Jira)
Aldo Brucale created NETBEANS-4224:
--

 Summary: Missing TooBroadCatchClause hint
 Key: NETBEANS-4224
 URL: https://issues.apache.org/jira/browse/NETBEANS-4224
 Project: NetBeans
  Issue Type: Bug
  Components: java - Hints
Affects Versions: 12.0
Reporter: Aldo Brucale


In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 in {{TooBroadCatchClause.java}} the hint at line 28 is missing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4223) Missing UseSpecificCatch hint

2020-04-23 Thread Aldo Brucale (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aldo Brucale updated NETBEANS-4223:
---
Description: 
In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 in {{UseSpecificCatch.java}} the hint at line 20 is not shown, and the hint at 
line 26 is shown when it shouldn't

 

 

 

  was:
In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 
in {{UseSpecificCatch.java}} the hint at line 20 is not shown, and the hint at 
line 26 is shown when it shouldn't

 

 

 


> Missing UseSpecificCatch hint
> -
>
> Key: NETBEANS-4223
> URL: https://issues.apache.org/jira/browse/NETBEANS-4223
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Hints
>Affects Versions: 12.0
>Reporter: Aldo Brucale
>Priority: Minor
>
> In this [test 
> project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
>  in {{UseSpecificCatch.java}} the hint at line 20 is not shown, and the hint 
> at line 26 is shown when it shouldn't
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4223) Missing UseSpecificCatch hint

2020-04-23 Thread Aldo Brucale (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aldo Brucale updated NETBEANS-4223:
---
Description: 
In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 
in {{UseSpecificCatch.java}} the hint at line 20 is not shown, and the hint at 
line 26 is shown when it shouldn't

 

 

 

  was:
In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 
in UseSpecificCatch.java from

 

 

 


> Missing UseSpecificCatch hint
> -
>
> Key: NETBEANS-4223
> URL: https://issues.apache.org/jira/browse/NETBEANS-4223
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Hints
>Affects Versions: 12.0
>Reporter: Aldo Brucale
>Priority: Minor
>
> In this [test 
> project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
>  
> in {{UseSpecificCatch.java}} the hint at line 20 is not shown, and the hint 
> at line 26 is shown when it shouldn't
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4223) Missing UseSpecificCatch hint

2020-04-23 Thread Aldo Brucale (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aldo Brucale updated NETBEANS-4223:
---
Priority: Minor  (was: Major)

> Missing UseSpecificCatch hint
> -
>
> Key: NETBEANS-4223
> URL: https://issues.apache.org/jira/browse/NETBEANS-4223
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Hints
>Affects Versions: 12.0
>Reporter: Aldo Brucale
>Priority: Minor
>
> In this [test 
> project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
>  
> in UseSpecificCatch.java from
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4223) Missing UseSpecificCatch hint

2020-04-23 Thread Aldo Brucale (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aldo Brucale updated NETBEANS-4223:
---
Description: 
In this [test 
project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
 
in UseSpecificCatch.java from

 

 

 

  was:
In the test case UseSpecificCatch.java from this

[

test project

 

 

https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294

 

 

 


> Missing UseSpecificCatch hint
> -
>
> Key: NETBEANS-4223
> URL: https://issues.apache.org/jira/browse/NETBEANS-4223
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Hints
>Affects Versions: 12.0
>Reporter: Aldo Brucale
>Priority: Major
>
> In this [test 
> project|https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294],
>  
> in UseSpecificCatch.java from
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4223) Missing UseSpecificCatch hint

2020-04-23 Thread Aldo Brucale (Jira)
Aldo Brucale created NETBEANS-4223:
--

 Summary: Missing UseSpecificCatch hint
 Key: NETBEANS-4223
 URL: https://issues.apache.org/jira/browse/NETBEANS-4223
 Project: NetBeans
  Issue Type: Bug
  Components: java - Hints
Affects Versions: 12.0
Reporter: Aldo Brucale


In the test case UseSpecificCatch.java from this

[

test project

 

 

https://netbeans-vm.apache.org/synergy/server/api/attachment.php?id=294

 

 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4222) Open up more of APIs in Node and PropertySheet

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090332#comment-17090332
 ] 

Geertjan Wielenga commented on NETBEANS-4222:
-

Well, the best solution would be -- since all the code is on GitHub -- for you 
to make these changes and make sure to engage with the community via the 
mailing lists for API reviews, etc.

> Open up more of APIs in Node and PropertySheet
> --
>
> Key: NETBEANS-4222
> URL: https://issues.apache.org/jira/browse/NETBEANS-4222
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Explorer, platform - Nodes
>Reporter: Markus Sunela
>Priority: Minor
>
> Currently it is hard to customize Node, Explorer and PropertySheet behavior, 
> because there are too many private instead of protected methods, package 
> private and final classes in the API.
> Some examples I have stumbled on include
>  * private doSetNodes method in PropertySheet (no way to override the use of 
> ProxyNodes)
>  * final and package private ProxyNode class
>  * package private constructor in ProxyNode
>  * package private getOriginalNodes method in ProxyNode
>  * package private and final {color:#00}ProxyProperty{color} class in 
> ProxyNode
>  * final Sheet class and its inner class Sheet.Set
>  * most private methods in Sheet and Sheet.Set should be protected instead
>  * PropertySupport.Reflection class should have getters for read and write 
> methods
> I wonder, what is the rationale for so strict and static API design? I would 
> assume the performance gains from these limitations are meager. Opening these 
> classes for sub-classing and modifications would result in much more flexible 
> system with much less code duplication.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4221) Cannot select function from suggested list

2020-04-23 Thread Eugene Pliskin (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eugene Pliskin updated NETBEANS-4221:
-
Description: 
Fails when pressing Enter key to select a function from suggested completion 
list. See attached screenshot. May be related to my non-ascii variable names.

Reproduced occasionally after extensive editing. When this fail happens, it 
keeps occuring at that point in code even after restarting Netbeans.


  was:
Crash when pressing Enter key to select a function from suggested completion 
list. See attached screenshot. May be related to my non-ascii class and 
variable names.

Reproduced occasionally after extensive editing. Cannot reproduce with pure 
ascii class and variable names.




> Cannot select function from suggested list
> --
>
> Key: NETBEANS-4221
> URL: https://issues.apache.org/jira/browse/NETBEANS-4221
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Completion & Templates
>Affects Versions: 11.3
> Environment: windows 10
>Reporter: Eugene Pliskin
>Priority: Minor
> Attachments: netbeans-crash.png, netbeans-crash.xml
>
>
> Fails when pressing Enter key to select a function from suggested completion 
> list. See attached screenshot. May be related to my non-ascii variable names.
> Reproduced occasionally after extensive editing. When this fail happens, it 
> keeps occuring at that point in code even after restarting Netbeans.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4222) Open up more of APIs in Node and PropertySheet

2020-04-23 Thread Markus Sunela (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090327#comment-17090327
 ] 

Markus Sunela commented on NETBEANS-4222:
-

Thanks for the really quick reply. Of course I could, but when the nice and 
working infrastructure is already there, it would feel such a shame to 
duplicate its code and functionality just change certain small bits.

> Open up more of APIs in Node and PropertySheet
> --
>
> Key: NETBEANS-4222
> URL: https://issues.apache.org/jira/browse/NETBEANS-4222
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Explorer, platform - Nodes
>Reporter: Markus Sunela
>Priority: Minor
>
> Currently it is hard to customize Node, Explorer and PropertySheet behavior, 
> because there are too many private instead of protected methods, package 
> private and final classes in the API.
> Some examples I have stumbled on include
>  * private doSetNodes method in PropertySheet (no way to override the use of 
> ProxyNodes)
>  * final and package private ProxyNode class
>  * package private constructor in ProxyNode
>  * package private getOriginalNodes method in ProxyNode
>  * package private and final {color:#00}ProxyProperty{color} class in 
> ProxyNode
>  * final Sheet class and its inner class Sheet.Set
>  * most private methods in Sheet and Sheet.Set should be protected instead
>  * PropertySupport.Reflection class should have getters for read and write 
> methods
> I wonder, what is the rationale for so strict and static API design? I would 
> assume the performance gains from these limitations are meager. Opening these 
> classes for sub-classing and modifications would result in much more flexible 
> system with much less code duplication.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4222) Open up more of APIs in Node and PropertySheet

2020-04-23 Thread Geertjan Wielenga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090325#comment-17090325
 ] 

Geertjan Wielenga commented on NETBEANS-4222:
-

Well, you can always simply replace the Properties window infrastructure with 
your own. :-)

Listen to the global Lookup and populate your own TopComponent with values from 
your domain objects.

> Open up more of APIs in Node and PropertySheet
> --
>
> Key: NETBEANS-4222
> URL: https://issues.apache.org/jira/browse/NETBEANS-4222
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Explorer, platform - Nodes
>Reporter: Markus Sunela
>Priority: Minor
>
> Currently it is hard to customize Node, Explorer and PropertySheet behavior, 
> because there are too many private instead of protected methods, package 
> private and final classes in the API.
> Some examples I have stumbled on include
>  * private doSetNodes method in PropertySheet (no way to override the use of 
> ProxyNodes)
>  * final and package private ProxyNode class
>  * package private constructor in ProxyNode
>  * package private getOriginalNodes method in ProxyNode
>  * package private and final {color:#00}ProxyProperty{color} class in 
> ProxyNode
>  * final Sheet class and its inner class Sheet.Set
>  * most private methods in Sheet and Sheet.Set should be protected instead
>  * PropertySupport.Reflection class should have getters for read and write 
> methods
> I wonder, what is the rationale for so strict and static API design? I would 
> assume the performance gains from these limitations are meager. Opening these 
> classes for sub-classing and modifications would result in much more flexible 
> system with much less code duplication.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists