date:20200921

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Eirik Bakke updated NETBEANS-2617:
--
Description:
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE:
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
is a Google Sheet where we can track progress of contributions and
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of
a typical icon in Adobe Illustrator. See the attached illustration and
Illustrator template. The Illustrator template includes a few icons which have
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now
migrated to the Google Sheet above). By redrawing the most commonly seen icons
first, we can get the greatest "bang for the buck" in terms of improving
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file
has been copied around to various places in the NetBeans codebase, the
spreadsheet includes only one location, picked arbitrarily. Once we have a
batch of icons ready to integrate into the NetBeans repository, Eirik will redo
the duplicate detection and ensure the SVGs end up in all relevant locations,
and start creating pull requests.

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

If you wish to contribute to this effort, comment here; Eirik will coordinate
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape
or another free tool. In Illustrator, each icon should be one named artboard,
sized to the correct size in pixels. See the attached Illustrator template.
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month.
If cost is a problem but you want to contribute your time to draw icons, ask
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute icons, that's
fine; just make sure to follow the same consistent style as the other icons. If
using Inkscape, perhaps pick another group of icons than the ones that are
currently being drawn in Illustrator. It's best to draw all similar-looking
icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in a
separate layer ("Old Bitmap Icons" in the Illustrator template). You can then
draw the vectorized version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual
style, and to simplify the job of creating new icons, it is best to keep the
shape of the new vectorized icons the same as in the old bitmap icons. For
instance, a rectangle of size 5x4px in the bitmap icon should probably become a
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the
existing bitmap icons. The new icons should look consistent with the existing
bitmap icons, especially since we may see bitmap icons and vector icons
side-by-side for a long time. Within shapes, 0.5px strokes can be used for
finer details. (0.5px strokes become 1 device pixel on Retina screens, which
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33%
transparent black on top of the shape's background color, or of similar
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g.
the small magnifying glass in find_selection.png vs. the large magnifying glass
in zoom_in.png), strokes and borders should still remain at the same thickness
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of
applying boolean operations (e.g. subtracting another shape from the stroke
only), strokes should be left as strokes whenever possible, as this leads to
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller
16x16 one, which is sometimes simpler. (This is already done in the prioritized

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

If you wish to contribute to this effort, comment here; Eirik will coordinate
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape
or another free tool. In Illustrator, each icon should be one named artboard,
sized to the correct size in pixels. See the attached Illustrator template.
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month.
If cost is a problem but you want to contribute your time to draw icons, ask
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute icons, that's
fine; just make sure to follow the same consistent style as the other icons. If
using Inkscape, perhaps pick another group of icons than the ones that are
currently being drawn in Illustrator. It's best to draw all similar-looking
icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual
style, and to simplify the job of creating new icons, it is best to keep the
shape of the new vectorized icons the same as in the old bitmap icons. For
instance, a rectangle of size 5x4px in the bitmap icon should probably become a
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the
existing bitmap icons. The new icons should look consistent with the existing
bitmap icons, especially since we may see bitmap icons and vector icons
side-by-side for a long time. Within shapes, 0.5px strokes can be used for
finer details. (0.5px strokes become 1 device pixel on Retina screens, which
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33%
transparent black on top of the shape's background color, or of similar
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g.
the small magnifying glass in find_selection.png vs. the large magnifying glass
in zoom_in.png), strokes and borders should still remain at the same thickness
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of
applying boolean operations (e.g. subtracting another shape from the stroke
only), strokes should be left as strokes whenever possible, as this leads to
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller
16x16 one, which is sometimes simpler. (This is already done in the prioritized
icon list above.)
*

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

If you wish to contribute to this effort, comment here; Eirik will coordinate
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape
or another free tool. In Illustrator, each icon should be one named artboard,
sized to the correct size in pixels. See the attached Illustrator template.
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month.
If cost is a problem but you want to contribute your time to draw icons, ask
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen
icons, that's fine; just make sure to follow the same consistent style as the
other icons. If using Inkscape, perhaps pick another group of icons than the
ones that are currently being drawn in Illustrator. It's best to draw all
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual
style, and to simplify the job of creating new icons, it is best to keep the
shape of the new vectorized icons the same as in the old bitmap icons. For
instance, a rectangle of size 5x4px in the bitmap icon should probably become a
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the
existing bitmap icons. The new icons should look consistent with the existing
bitmap icons, especially since we may see bitmap icons and vector icons
side-by-side for a long time. Within shapes, 0.5px strokes can be used for
finer details. (0.5px strokes become 1 device pixel on Retina screens, which
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33%
transparent black on top of the shape's background color, or of similar
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g.
the small magnifying glass in find_selection.png vs. the large magnifying glass
in zoom_in.png), strokes and borders should still remain at the same thickness
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of
applying boolean operations (e.g. subtracting another shape from the stroke
only), strokes should be left as strokes whenever possible, as this leads to
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller
16x16 one, which is sometimes simpler. (This is already done in the prioritized
icon

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

If you wish to contribute to this effort, comment here; Eirik will coordinate
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape
or another free tool. In Illustrator, each icon should be one named artboard,
sized to the correct size in pixels. See the attached Illustrator template.
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month.
If cost is a problem but you want to contribute your time to draw icons, ask
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen
icons, that's fine; just make sure to follow the same consistent style as the
other icons. If using Inkscape, perhaps pick another group of icons than the
ones that are currently being drawn in Illustrator. It's best to draw all
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual
style, and to simplify the job of creating new icons, it is best to keep the
shape of the new vectorized icons the same as in the old bitmap icons. For
instance, a rectangle of size 5x4px in the bitmap icon should probably become a
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the
existing bitmap icons. The new icons should look consistent with the existing
bitmap icons, especially since we may see bitmap icons and vector icons
side-by-side for a long time. Within shapes, 0.5px strokes can be used for
finer details. (0.5px strokes become 1 device pixel on Retina screens, which
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33%
transparent black on top of the shape's background color, or of similar
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g.
the small magnifying glass in find_selection.png vs. the large magnifying glass
in zoom_in.png), strokes and borders should still remain at the same thickness
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of
applying boolean operations (e.g. subtracting another shape from the stroke
only), strokes should be left as strokes whenever possible, as this leads to
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller
16x16 one, which is sometimes simpler. (This is already done in the prioritized
icon

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

If you wish to contribute to this effort, comment here; Eirik will coordinate
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape
or another free tool. In Illustrator, each icon should be one named artboard,
sized to the correct size in pixels. See the attached Illustrator template.
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month.
If cost is a problem but you want to contribute your time to draw icons, ask
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen
icons, that's fine; just make sure to follow the same consistent style as the
other icons. If using Inkscape, perhaps pick another group of icons than the
ones that are currently being drawn in Illustrator. It's best to draw all
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual
style, and to simplify the job of creating new icons, it is best to keep the
shape of the new vectorized icons the same as in the old bitmap icons. For
instance, a rectangle of size 5x4px in the bitmap icon should probably become a
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the
existing bitmap icons. The new icons should look consistent with the existing
bitmap icons, especially since we may see bitmap icons and vector icons
side-by-side for a long time. Within shapes, 0.5px strokes can be used for
finer details. (0.5px strokes become 1 device pixel on Retina screens, which
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33%
transparent black on top of the shape's background color, or of similar
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g.
the small magnifying glass in find_selection.png vs. the large magnifying glass
in zoom_in.png), strokes and borders should still remain at the same thickness
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of
applying boolean operations (e.g. subtracting another shape from the stroke
only), strokes should be left as strokes whenever possible, as this leads to
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller
16x16 one, which is sometimes simpler. (This is already done in the prioritized
icon

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

If you wish to contribute to this effort, comment here; Eirik will coordinate
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape
or another free tool. In Illustrator, each icon should be one named artboard,
sized to the correct size in pixels. See the attached Illustrator template.
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month.
If cost is a problem but you want to contribute your time to draw icons, ask
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen
icons, that's fine; just make sure to follow the same consistent style as the
other icons. If using Inkscape, perhaps pick another group of icons than the
ones that are currently being drawn in Illustrator. It's best to draw all
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual
style, and to simplify the job of creating new icons, it is best to keep the
shape of the new vectorized icons the same as in the old bitmap icons. For
instance, a rectangle of size 5x4px in the bitmap icon should probably become a
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the
existing bitmap icons. The new icons should look consistent with the existing
bitmap icons, especially since we may see bitmap icons and vector icons
side-by-side for a long time. Within shapes, 0.5px strokes can be used for
finer details. (0.5px strokes become 1 device pixel on Retina screens, which
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33%
transparent black on top of the shape's background color, or of similar
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g.
the small magnifying glass in find_selection.png vs. the large magnifying glass
in zoom_in.png), strokes and borders should still remain at the same thickness
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of
applying boolean operations (e.g. subtracting another shape from the stroke
only), strokes should be left as strokes whenever possible, as this leads to
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller
16x16 one, which is sometimes simpler. (This is already done in the prioritized
icon

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

If you wish to contribute to this effort, comment here; Eirik will coordinate
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape
or another free tool. In Illustrator, each icon should be one named artboard,
sized to the correct size in pixels. See the attached Illustrator template.
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month.
If cost is a problem but you want to contribute your time to draw icons, ask
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen
icons, that's fine; just make sure to follow the same consistent style as the
other icons. If using Inkscape, perhaps pick another group of icons than the
ones that are currently being drawn in Illustrator. It's best to draw all
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual
style, and to simplify the job of creating new icons, it is best to keep the
shape of the new vectorized icons the same as in the old bitmap icons. For
instance, a rectangle of size 5x4px in the bitmap icon should probably become a
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the
existing bitmap icons. The new icons should look consistent with the existing
bitmap icons, especially since we may see bitmap icons and vector icons
side-by-side for a long time. Within shapes, 0.5px strokes can be used for
finer details. (0.5px strokes become 1 device pixel on Retina screens, which
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33%
transparent black on top of the shape's background color, or of similar
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g.
the small magnifying glass in find_selection.png vs. the large magnifying glass
in zoom_in.png), strokes and borders should still remain at the same thickness
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of
applying boolean operations (e.g. subtracting another shape from the stroke
only), strokes should be left as strokes whenever possible, as this leads to
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector
version on the smaller 16x16 one, which is sometimes simpler. (This is already
done in the prioritized icon list above.)
* Avoid unnecessary anchor points

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

If you wish to contribute to this effort, comment here; Eirik will coordinate
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape
or another free tool. In Illustrator, each icon should be one named artboard,
sized to the correct size in pixels. See the attached Illustrator template.
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month.
If cost is a problem but you want to contribute your time to draw icons, ask
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen
icons, that's fine; just make sure to follow the same consistent style as the
other icons. If using Inkscape, perhaps pick another group of icons than the
ones that are currently being drawn in Illustrator. It's best to draw all
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual
style, and to simplify the job of creating new icons, it is best to keep the
shape of the new vectorized icons the same as in the old bitmap icons. For
instance, a rectangle of size 5x4px in the bitmap icon should probably become a
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old
bitmap icons. (The color scheme is not too hard to change later, but we should
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the
existing bitmap icons. The new icons should look consistent with the existing
bitmap icons, especially since we may see bitmap icons and vector icons
side-by-side for a long time. Within shapes, 0.5px strokes can be used for
finer details. (0.5px strokes become 1 device pixel on Retina screens, which
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33%
transparent black on top of the shape's background color, or of similar
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g.
the small magnifying glass in find_selection.png vs. the large magnifying glass
in zoom_in.png), strokes and borders should still remain at the same thickness
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of
applying boolean operations (e.g. subtracting another shape from the stroke
only), strokes should be left as strokes whenever possible, as this leads to
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector
version on the smaller 16x16 one,

[jira] [Updated] (NETBEANS-4832) fxml code completion fails with modular java



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernie Rael updated NETBEANS-4832:
-
Attachment: AllModulesAssert-messages-2.log

> fxml code completion fails with modular java
> 
>
> Key: NETBEANS-4832
> URL: https://issues.apache.org/jira/browse/NETBEANS-4832
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Editor
> Environment: NB-12.1, jdk-14, no nb-javac, Win7, no userdir/cachedir,
> startup do not import settings
>Reporter: Ernie Rael
>Priority: Major
>  Labels: modularization
> Attachments: AllModulesAssert-messages-2.log
>
>
> To reproduce (create/open fxml file)
>  # NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
>  # Open primary.fxml, in "other sources" "source/main/resources" 
>  # put cursor within xml, for example after ""
>  # Enter Ctrl-Space to bring up code completion
> Observe:
>  * Typically have to go through a couple web certification dialogs
>  * Typically repeat Ctrl-Space and there's a "downloading..." that never 
> finishes
> Note: Works OK when running on and using jdk1.8 with nb-javac.
> Fails with JDK assertion: Assert.checkNonNull(allModules)
> (full message log attached)
> {code}
> java.lang.AssertionError at 
> jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155) at 
> jdk.compiler/com.sun.tools.javac.util.Assert.checkNonNull(Assert.java:62) at 
> jdk.compiler/com.sun.tools.javac.comp.Modules.allModules(Modules.java:1205) 
> at 
> jdk.compiler/com.sun.tools.javac.model.JavacElements.getAllModuleElements(JavacElements.java:126)
>  at 
> org.netbeans.modules.java.source.ElementUtils.getTypeElementByBinaryName(ElementUtils.java:49)
>  at 
> org.netbeans.api.java.source.ElementHandle.getTypeElementByBinaryName(ElementHandle.java:666)
>  at 
> org.netbeans.api.java.source.ElementHandle.resolveImpl(ElementHandle.java:163)
>  at 
> org.netbeans.api.java.source.ElementHandle.resolve(ElementHandle.java:132) at 
> org.netbeans.modules.javafx2.editor.completion.impl.InstanceCompleter.(InstanceCompleter.java:54)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-4832) fxml code completion fails with modular java



[ 
https://issues.apache.org/jira/browse/NETBEANS-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199727#comment-17199727
 ] 

Ernie Rael commented on NETBEANS-4832:
--

[~sdedic] I can't even propose a fix for this one... If a fix is not obvious, I 
can gather info, if you'd like. If you can outline a fix, I can try to put 
together a PR.

For the error annotator parser (which works ok and has a list of modules)
{code}
 ParserManager.MimeTaskAction.run
 userTask: FxmlParser$1UT
{code}

For the completion parser, after Ctrl-Space
{code}
 ParserManager.UserTaskAction.run
 userTask: FXMLCompletion2$Q$Task@4ccbdf93
{code}

The compiler info for the completion parser does not have the list of modules.


> fxml code completion fails with modular java
> 
>
> Key: NETBEANS-4832
> URL: https://issues.apache.org/jira/browse/NETBEANS-4832
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Editor
> Environment: NB-12.1, jdk-14, no nb-javac, Win7, no userdir/cachedir,
> startup do not import settings
>Reporter: Ernie Rael
>Priority: Major
>  Labels: modularization
>
> To reproduce (create/open fxml file)
>  # NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
>  # Open primary.fxml, in "other sources" "source/main/resources" 
>  # put cursor within xml, for example after ""
>  # Enter Ctrl-Space to bring up code completion
> Observe:
>  * Typically have to go through a couple web certification dialogs
>  * Typically repeat Ctrl-Space and there's a "downloading..." that never 
> finishes
> Note: Works OK when running on and using jdk1.8 with nb-javac.
> Fails with JDK assertion: Assert.checkNonNull(allModules)
> (full message log attached)
> {code}
> java.lang.AssertionError at 
> jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155) at 
> jdk.compiler/com.sun.tools.javac.util.Assert.checkNonNull(Assert.java:62) at 
> jdk.compiler/com.sun.tools.javac.comp.Modules.allModules(Modules.java:1205) 
> at 
> jdk.compiler/com.sun.tools.javac.model.JavacElements.getAllModuleElements(JavacElements.java:126)
>  at 
> org.netbeans.modules.java.source.ElementUtils.getTypeElementByBinaryName(ElementUtils.java:49)
>  at 
> org.netbeans.api.java.source.ElementHandle.getTypeElementByBinaryName(ElementHandle.java:666)
>  at 
> org.netbeans.api.java.source.ElementHandle.resolveImpl(ElementHandle.java:163)
>  at 
> org.netbeans.api.java.source.ElementHandle.resolve(ElementHandle.java:132) at 
> org.netbeans.modules.javafx2.editor.completion.impl.InstanceCompleter.(InstanceCompleter.java:54)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Issue Comment Deleted] (NETBEANS-4745) fxml editor shows errors for Insets (immutable objects in general?)



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernie Rael updated NETBEANS-4745:
-
Comment: was deleted

(was: [~sdedic] I can't even propose a fix for this one... If a fix is not 
obvious, I can gather info, if you'd like. If you can outline a fix, I can try 
to put together a PR.

For the error annotator parser (which works ok and has a list of modules)
{code}
 ParserManager.MimeTaskAction.run
 userTask: FxmlParser$1UT
{code}

For the completion parser, after Ctrl-Space
{code}
 ParserManager.UserTaskAction.run
 userTask: FXMLCompletion2$Q$Task@4ccbdf93
{code}

The compiler info for the completion parser does not have the list of modules.
)

> fxml editor shows errors for Insets (immutable objects in general?)
> ---
>
> Key: NETBEANS-4745
> URL: https://issues.apache.org/jira/browse/NETBEANS-4745
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Editor
>Reporter: Ernie Rael
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> To recreate:
> NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
> Open primary.fxml, in "other sources" "source/main/resources" 
> Observe that the lines like:
> {code}
> 
> {code}
> show errors, in particular
> {code}
> Instances of javafx.geometry.Insets cannot be created by FXML loader
> Class 'javafx.geometry.Insets' does not support property 'bottom'
> {code}
> examining the code in NetBeans "JavaFX 2 Support" module
> {code:java}
> package org.netbeans.modules.javafx2.editor.completion.beans;
> public final class BeanModelBuilder
> {code}
> The problem seems to start with Insets not having a no argument constructor; 
> and the properties are not recognized because they have no setters. So it 
> looks like immutable objects are not handled.
> Look near the begginning of BeanModelBuilder.process() around
> {code}
> if (c.getParameters().isEmpty() &&
> {code}
> and then BeanModelBuilder.inspectMembers(), addProperty(), findPropertyName
> {code}
> if (!name.startsWith(SET_NAME_PREFIX) || name.length() == 
> SET_NAME_PREFIX_LEN ||
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-4745) fxml editor shows errors for Insets (immutable objects in general?)



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernie Rael updated NETBEANS-4745:
-
Attachment: (was: AllModulesAssert-messages-2.log)

> fxml editor shows errors for Insets (immutable objects in general?)
> ---
>
> Key: NETBEANS-4745
> URL: https://issues.apache.org/jira/browse/NETBEANS-4745
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Editor
>Reporter: Ernie Rael
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> To recreate:
> NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
> Open primary.fxml, in "other sources" "source/main/resources" 
> Observe that the lines like:
> {code}
> 
> {code}
> show errors, in particular
> {code}
> Instances of javafx.geometry.Insets cannot be created by FXML loader
> Class 'javafx.geometry.Insets' does not support property 'bottom'
> {code}
> examining the code in NetBeans "JavaFX 2 Support" module
> {code:java}
> package org.netbeans.modules.javafx2.editor.completion.beans;
> public final class BeanModelBuilder
> {code}
> The problem seems to start with Insets not having a no argument constructor; 
> and the properties are not recognized because they have no setters. So it 
> looks like immutable objects are not handled.
> Look near the begginning of BeanModelBuilder.process() around
> {code}
> if (c.getParameters().isEmpty() &&
> {code}
> and then BeanModelBuilder.inspectMembers(), addProperty(), findPropertyName
> {code}
> if (!name.startsWith(SET_NAME_PREFIX) || name.length() == 
> SET_NAME_PREFIX_LEN ||
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-4745) fxml editor shows errors for Insets (immutable objects in general?)



[ 
https://issues.apache.org/jira/browse/NETBEANS-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199725#comment-17199725
 ] 

Ernie Rael commented on NETBEANS-4745:
--

[~sdedic] I can't even propose a fix for this one... If a fix is not obvious, I 
can gather info, if you'd like. If you can outline a fix, I can try to put 
together a PR.

For the error annotator parser (which works ok and has a list of modules)
{code}
 ParserManager.MimeTaskAction.run
 userTask: FxmlParser$1UT
{code}

For the completion parser, after Ctrl-Space
{code}
 ParserManager.UserTaskAction.run
 userTask: FXMLCompletion2$Q$Task@4ccbdf93
{code}

The compiler info for the completion parser does not have the list of modules.


> fxml editor shows errors for Insets (immutable objects in general?)
> ---
>
> Key: NETBEANS-4745
> URL: https://issues.apache.org/jira/browse/NETBEANS-4745
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Editor
>Reporter: Ernie Rael
>Priority: Major
>  Labels: pull-request-available
> Attachments: AllModulesAssert-messages-2.log
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> To recreate:
> NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
> Open primary.fxml, in "other sources" "source/main/resources" 
> Observe that the lines like:
> {code}
> 
> {code}
> show errors, in particular
> {code}
> Instances of javafx.geometry.Insets cannot be created by FXML loader
> Class 'javafx.geometry.Insets' does not support property 'bottom'
> {code}
> examining the code in NetBeans "JavaFX 2 Support" module
> {code:java}
> package org.netbeans.modules.javafx2.editor.completion.beans;
> public final class BeanModelBuilder
> {code}
> The problem seems to start with Insets not having a no argument constructor; 
> and the properties are not recognized because they have no setters. So it 
> looks like immutable objects are not handled.
> Look near the begginning of BeanModelBuilder.process() around
> {code}
> if (c.getParameters().isEmpty() &&
> {code}
> and then BeanModelBuilder.inspectMembers(), addProperty(), findPropertyName
> {code}
> if (!name.startsWith(SET_NAME_PREFIX) || name.length() == 
> SET_NAME_PREFIX_LEN ||
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-4745) fxml editor shows errors for Insets (immutable objects in general?)



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernie Rael updated NETBEANS-4745:
-
Attachment: AllModulesAssert-messages-2.log

> fxml editor shows errors for Insets (immutable objects in general?)
> ---
>
> Key: NETBEANS-4745
> URL: https://issues.apache.org/jira/browse/NETBEANS-4745
> Project: NetBeans
>  Issue Type: Bug
>  Components: javafx - Editor
>Reporter: Ernie Rael
>Priority: Major
>  Labels: pull-request-available
> Attachments: AllModulesAssert-messages-2.log
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> To recreate:
> NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
> Open primary.fxml, in "other sources" "source/main/resources" 
> Observe that the lines like:
> {code}
> 
> {code}
> show errors, in particular
> {code}
> Instances of javafx.geometry.Insets cannot be created by FXML loader
> Class 'javafx.geometry.Insets' does not support property 'bottom'
> {code}
> examining the code in NetBeans "JavaFX 2 Support" module
> {code:java}
> package org.netbeans.modules.javafx2.editor.completion.beans;
> public final class BeanModelBuilder
> {code}
> The problem seems to start with Insets not having a no argument constructor; 
> and the properties are not recognized because they have no setters. So it 
> looks like immutable objects are not handled.
> Look near the begginning of BeanModelBuilder.process() around
> {code}
> if (c.getParameters().isEmpty() &&
> {code}
> and then BeanModelBuilder.inspectMembers(), addProperty(), findPropertyName
> {code}
> if (!name.startsWith(SET_NAME_PREFIX) || name.length() == 
> SET_NAME_PREFIX_LEN ||
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Created] (NETBEANS-4832) fxml code completion fails with modular java

Ernie Rael created NETBEANS-4832:


 Summary: fxml code completion fails with modular java
 Key: NETBEANS-4832
 URL: https://issues.apache.org/jira/browse/NETBEANS-4832
 Project: NetBeans
  Issue Type: Bug
  Components: javafx - Editor
 Environment: NB-12.1, jdk-14, no nb-javac, Win7, no userdir/cachedir,
startup do not import settings
Reporter: Ernie Rael


To reproduce (create/open fxml file)
 # NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
 # Open primary.fxml, in "other sources" "source/main/resources" 
 # put cursor within xml, for example after ""
 # Enter Ctrl-Space to bring up code completion

Observe:
 * Typically have to go through a couple web certification dialogs
 * Typically repeat Ctrl-Space and there's a "downloading..." that never 
finishes

Note: Works OK when running on and using jdk1.8 with nb-javac.

Fails with JDK assertion: Assert.checkNonNull(allModules)

(full message log attached)

{code}
java.lang.AssertionError at 
jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155) at 
jdk.compiler/com.sun.tools.javac.util.Assert.checkNonNull(Assert.java:62) at 
jdk.compiler/com.sun.tools.javac.comp.Modules.allModules(Modules.java:1205) at 
jdk.compiler/com.sun.tools.javac.model.JavacElements.getAllModuleElements(JavacElements.java:126)
 at 
org.netbeans.modules.java.source.ElementUtils.getTypeElementByBinaryName(ElementUtils.java:49)
 at 
org.netbeans.api.java.source.ElementHandle.getTypeElementByBinaryName(ElementHandle.java:666)
 at 
org.netbeans.api.java.source.ElementHandle.resolveImpl(ElementHandle.java:163) 
at org.netbeans.api.java.source.ElementHandle.resolve(ElementHandle.java:132) 
at 
org.netbeans.modules.javafx2.editor.completion.impl.InstanceCompleter.(InstanceCompleter.java:54)
{code}




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-2617) Redraw common icons in SVG



[ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199719#comment-17199719
 ] 

Eirik Bakke commented on NETBEANS-2617:
---

For the SVG icons drawn up to now, I have created the JIRA issue NETBEANS-4830 
and pull request at https://github.com/apache/netbeans/pull/2387 . Pete, thanks 
for the icons you drew--they work perfectly!

> Redraw common icons in SVG
> --
>
> Key: NETBEANS-2617
> URL: https://issues.apache.org/jira/browse/NETBEANS-2617
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
> Environment: Windows, Linux, and MacOS
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: ScreenshotExample.png, ide.editor.bookmarks.ai, 
> ide.editor.macros.ai, ide.seperator.breadcrumbs.ai, 
> netbeans_icons_illustrator_template.ai, style example (dark filter).png, 
> style example.png
>
>
> Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
> icons with SVG versions, for improved appearance on Retina/HiDPI displays.
> h2. UPDATE: 
> [Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
>  is a Google Sheet where we can track progress of contributions and 
> prioritization of icons.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration and 
> Illustrator template. The Illustrator template includes a few icons which 
> have already been converted.
> In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
> migrated to the Google Sheet above). By redrawing the most commonly seen 
> icons first, we can get the greatest "bang for the buck" in terms of 
> improving NetBeans' appearance on HiDPI displays. Note that in cases where an 
> icon file has been copied around to various places in the NetBeans codebase, 
> the spreadsheet includes only one location, picked arbitrarily. Once we have 
> a batch of icons ready to integrate into the NetBeans repository, Eirik will 
> redo the duplicate detection and ensure the SVGs end up in all relevant 
> locations, and start creating pull requests.
> See also the overview page for HiDPI improvements on 
> https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
>  .
> If you wish to contribute to this effort, comment here; Eirik will coordinate 
> to make sure multiple people are not working on the same icons.
> h2. Proposed Style Guide for Vectorized Icons
> * Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
> named artboard, sized to the correct size in pixels. See the attached 
> Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
> which it's $35/month. If cost is a problem but you want to contribute your 
> time to draw icons, ask Eirik...)
> * If you prefer to use Inkscape instead, and want to contribute a few dozen 
> icons, that's fine; just make sure to follow the same consistent style as the 
> other icons. If using Inkscape, perhaps pick another group of icons than the 
> ones that are currently being drawn in Illustrator. It's best to draw all 
> similar-looking icons in the same tool.
> * For each icon to be vectorized, place the old bitmap version of the icon in 
> the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
> version on top.
> * Since most of the existing NetBeans icons follow a quite consistent visual 
> style, and to simplify the job of creating new icons, it is best to keep the 
> shape of the new vectorized icons the same as in the old bitmap icons. For 
> instance, a rectangle of size 5x4px in the bitmap icon should probably become 
> a rectangle of 5x4px in the vector version.
> * Keep the same general colors in vectorized icons as in the corresponding 
> old bitmap icons. (The color scheme is not too hard to change later, but we 
> should do this only once most of the IDE icons have been vectorized.)
> * If the old bitmap icon is complex, it is fine to simplify it a bit when 
> drawing vectorized versions.
> * Omit gradients, bevels, and unnecessary drop shadows. They take more time 
> to draw, and with "flat design", they are now out of fashion in any case.
> * Use a stroke width of 1px around the main shapes in the icon, like in the 
> existing bitmap icons. The new icons should look consistent with the existing 
> bitmap icons, especially since we may see bitmap icons and vector icons 
> side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
> finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
> have a 2x scaling.)
> * The 1px strokes that outline the icon's shapes should

[jira] [Updated] (NETBEANS-4830) Redraw common icons in SVG: First Batch



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4830:
--
Attachment: NETBEANS-4830 Icons Drawn by Eirik.ai

> Redraw common icons in SVG: First Batch
> ---
>
> Key: NETBEANS-4830
> URL: https://issues.apache.org/jira/browse/NETBEANS-4830
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Reporter: Eirik Bakke
>Assignee: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: NETBEANS-4830 Icons Drawn by Eirik.ai, 
> ide.editor.bookmarks (from Pete Whelpton for NETBEANS-4830).ai, 
> ide.editor.macros (from Pete Whelpton for NETBEANS-4830).ai, 
> ide.seperator.breadcrumbs (from Pete Whelpton for NETBEANS-4830).ai
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Part of the SVG icon drawing process tracked under NETBEANS-2617. Create a 
> separate issue to label the upcoming PR with.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-4830) Redraw common icons in SVG: First Batch



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4830:
--
Attachment: ide.seperator.breadcrumbs (from Pete Whelpton for 
NETBEANS-4830).ai
ide.editor.macros (from Pete Whelpton for NETBEANS-4830).ai
ide.editor.bookmarks (from Pete Whelpton for NETBEANS-4830).ai

> Redraw common icons in SVG: First Batch
> ---
>
> Key: NETBEANS-4830
> URL: https://issues.apache.org/jira/browse/NETBEANS-4830
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Reporter: Eirik Bakke
>Assignee: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: NETBEANS-4830 Icons Drawn by Eirik.ai, 
> ide.editor.bookmarks (from Pete Whelpton for NETBEANS-4830).ai, 
> ide.editor.macros (from Pete Whelpton for NETBEANS-4830).ai, 
> ide.seperator.breadcrumbs (from Pete Whelpton for NETBEANS-4830).ai
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Part of the SVG icon drawing process tracked under NETBEANS-2617. Create a 
> separate issue to label the upcoming PR with.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG



 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Attachment: (was: Icons drawn by Eirik as of 2020-09-18 (this file for 
visual reference only).pdf)

> Redraw common icons in SVG
> --
>
> Key: NETBEANS-2617
> URL: https://issues.apache.org/jira/browse/NETBEANS-2617
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
> Environment: Windows, Linux, and MacOS
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: ScreenshotExample.png, ide.editor.bookmarks.ai, 
> ide.editor.macros.ai, ide.seperator.breadcrumbs.ai, 
> netbeans_icons_illustrator_template.ai, style example (dark filter).png, 
> style example.png
>
>
> Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
> icons with SVG versions, for improved appearance on Retina/HiDPI displays.
> h2. UPDATE: 
> [Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
>  is a Google Sheet where we can track progress of contributions and 
> prioritization of icons.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration and 
> Illustrator template. The Illustrator template includes a few icons which 
> have already been converted.
> In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
> migrated to the Google Sheet above). By redrawing the most commonly seen 
> icons first, we can get the greatest "bang for the buck" in terms of 
> improving NetBeans' appearance on HiDPI displays. Note that in cases where an 
> icon file has been copied around to various places in the NetBeans codebase, 
> the spreadsheet includes only one location, picked arbitrarily. Once we have 
> a batch of icons ready to integrate into the NetBeans repository, Eirik will 
> redo the duplicate detection and ensure the SVGs end up in all relevant 
> locations, and start creating pull requests.
> See also the overview page for HiDPI improvements on 
> https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
>  .
> If you wish to contribute to this effort, comment here; Eirik will coordinate 
> to make sure multiple people are not working on the same icons.
> h2. Proposed Style Guide for Vectorized Icons
> * Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
> named artboard, sized to the correct size in pixels. See the attached 
> Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
> which it's $35/month. If cost is a problem but you want to contribute your 
> time to draw icons, ask Eirik...)
> * If you prefer to use Inkscape instead, and want to contribute a few dozen 
> icons, that's fine; just make sure to follow the same consistent style as the 
> other icons. If using Inkscape, perhaps pick another group of icons than the 
> ones that are currently being drawn in Illustrator. It's best to draw all 
> similar-looking icons in the same tool.
> * For each icon to be vectorized, place the old bitmap version of the icon in 
> the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
> version on top.
> * Since most of the existing NetBeans icons follow a quite consistent visual 
> style, and to simplify the job of creating new icons, it is best to keep the 
> shape of the new vectorized icons the same as in the old bitmap icons. For 
> instance, a rectangle of size 5x4px in the bitmap icon should probably become 
> a rectangle of 5x4px in the vector version.
> * Keep the same general colors in vectorized icons as in the corresponding 
> old bitmap icons. (The color scheme is not too hard to change later, but we 
> should do this only once most of the IDE icons have been vectorized.)
> * If the old bitmap icon is complex, it is fine to simplify it a bit when 
> drawing vectorized versions.
> * Omit gradients, bevels, and unnecessary drop shadows. They take more time 
> to draw, and with "flat design", they are now out of fashion in any case.
> * Use a stroke width of 1px around the main shapes in the icon, like in the 
> existing bitmap icons. The new icons should look consistent with the existing 
> bitmap icons, especially since we may see bitmap icons and vector icons 
> side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
> finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
> have a 2x scaling.)
> * The 1px strokes that outline the icon's shapes should typically be 33% 
> transparent black on top of the shape's background color, or of similar 
> darkness. See the examples in the attached

[jira] [Resolved] (NETBEANS-4824) General Availability for javadoc 15

2020-09-21 Thread Jose (Jira)



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jose resolved NETBEANS-4824.

Resolution: Implemented

Merged via [PR-2383|https://github.com/apache/netbeans/pull/2383]

> General Availability for javadoc 15
> ---
>
> Key: NETBEANS-4824
> URL: https://issues.apache.org/jira/browse/NETBEANS-4824
> Project: NetBeans
>  Issue Type: Improvement
>  Components: java - Javadoc
>Affects Versions: 12.1
>Reporter: Jose
>Assignee: Jose
>Priority: Minor
> Fix For: 12.2
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Update link to javadoc 15 now that is in general availability
> Before:
> https://download.java.net/java/early_access/jdk15/docs/api/
> After:
> https://docs.oracle.com/en/java/javase/15/docs/api/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

If you wish to contribute to this effort, comment here; Eirik will coordinate
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one
named artboard, sized to the correct size in pixels. See the attached
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after
which it's $35/month. If cost is a problem but you want to contribute your time
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen
icons, that's fine; just make sure to follow the same consistent style as the
other icons. If using Inkscape, perhaps pick another group of icons than the
ones that are currently being drawn in Illustrator. It's best to draw all
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual
style, and to simplify the job of creating new icons, it is best to keep the
shape of the new vectorized icons the same as in the old bitmap icons. For
instance, a rectangle of size 5x4px in the bitmap icon should probably become a
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old
bitmap icons. (The color scheme is not too hard to change later, but we should
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the
existing bitmap icons. The new icons should look consistent with the existing
bitmap icons, especially since we may see bitmap icons and vector icons
side-by-side for a long time. Within shapes, 0.5px strokes can be used for
finer details. (0.5px strokes become 1 device pixel on Retina screens, which
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33%
transparent black on top of the shape's background color, or of similar
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g.
the small magnifying glass in find_selection.png vs. the large magnifying glass
in zoom_in.png), strokes and borders should still remain at the same thickness
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of
applying boolean operations (e.g. subtracting another shape from the stroke
only), strokes should be left as strokes whenever possible, as this leads to
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector
version on the smaller 16x16 one, which is sometimes simpler. (This is already
done in the

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

[netbeans] branch master updated: General Availability for javadoc 15

2020-09-21 Thread matthiasblaesing

This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 1c15692  General Availability for javadoc 15
 new bb0e205  Merge pull request #2383 from pepness/ga-javadoc-15
1c15692 is described below

commit 1c1569221a214d83b1ac6ce04b923e4eefd13214
Author: Jose Contreras 
AuthorDate: Sun Sep 20 13:34:03 2020 -0500

General Availability for javadoc 15
---
 .../j2seplatform/platformdefinition/J2SEPlatformDefaultJavadocImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/platformdefinition/J2SEPlatformDefaultJavadocImpl.java
 
b/java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/platformdefinition/J2SEPlatformDefaultJavadocImpl.java
index b453916..5e58951 100644
--- 
a/java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/platformdefinition/J2SEPlatformDefaultJavadocImpl.java
+++ 
b/java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/platformdefinition/J2SEPlatformDefaultJavadocImpl.java
@@ -63,7 +63,7 @@ public final class J2SEPlatformDefaultJavadocImpl implements 
J2SEPlatformDefault
 OFFICIAL_JAVADOC.put("12", 
"https://docs.oracle.com/en/java/javase/12/docs/api/;); // NOI18N
 OFFICIAL_JAVADOC.put("13", 
"https://docs.oracle.com/en/java/javase/13/docs/api/;); // NOI18N
 OFFICIAL_JAVADOC.put("14", 
"https://docs.oracle.com/en/java/javase/14/docs/api/;); // NOI18N
-OFFICIAL_JAVADOC.put("15", 
"https://download.java.net/java/early_access/jdk15/docs/api/;); // NOI18N Early 
access
+OFFICIAL_JAVADOC.put("15", 
"https://docs.oracle.com/en/java/javase/15/docs/api/;); // NOI18N
 OFFICIAL_JAVADOC.put("16", 
"https://download.java.net/java/early_access/jdk16/docs/api/;); // NOI18N Early 
access
 }
 


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

[
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

See also the overview page for HiDPI improvements on
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
.

[jira] [Created] (NETBEANS-4830) Redraw common icons in SVG: First Batch

Eirik Bakke created NETBEANS-4830:
-

 Summary: Redraw common icons in SVG: First Batch
 Key: NETBEANS-4830
 URL: https://issues.apache.org/jira/browse/NETBEANS-4830
 Project: NetBeans
  Issue Type: Improvement
  Components: platform - Other
Reporter: Eirik Bakke
Assignee: Eirik Bakke


Part of the SVG icon drawing process tracked under NETBEANS-2617. Create a 
separate issue to label the upcoming PR with.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Created] (NETBEANS-4829) Incorrect hint about unused assigned value in switch statement

2020-09-21 Thread dennis lucero (Jira)

dennis lucero created NETBEANS-4829:
---

 Summary: Incorrect hint about unused assigned value in switch 
statement
 Key: NETBEANS-4829
 URL: https://issues.apache.org/jira/browse/NETBEANS-4829
 Project: NetBeans
  Issue Type: Bug
  Components: java - Hints
Affects Versions: 12.1
 Environment: Java 15, Windows 10
Reporter: dennis lucero


In some switch statements NetBeans displays a hint saying the assigned value is 
never used even though it is:
{code:java}
public final class SwitchAssignedValueNeverUsed {

public enum E {
A,
B;
}

public static void main(final String[] args) {
E e = E.A;
String s;
switch (e) {
case A -> s = "a"; // Hint: The assigned value is never used
case B -> s = "b";
default ->
throw new AssertionError(e.name());
}
System.out.println(s);
}
}
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[netbeans] branch master updated (811ccc5 -> 5b8c56e)

2020-09-21 Thread lkishalmi

This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git.


from 811ccc5  Merge pull request #2368 from hectorespert/autoupdate-ui-doc
 add 5b8c56e  Update Spring Framework to version 4.3.29 (#2374)

No new revisions were added by this update.

Summary of changes:
 .../spring/webmvc/resources/Bundle.properties  |  2 +-
 .../spring/webmvc/resources/spring-webmvc-4.0.xml  |  4 +-
 java/libs.springframework/external/binaries-list   | 40 +--
 ...=> spring-framework-4.3.29.RELEASE-license.txt} | 34 ++---
 ... => spring-framework-4.3.29.RELEASE-notice.txt} |  0
 .../nbproject/project.properties   | 80 ++---
 .../libs/springframework/Bundle.properties |  2 +-
 .../libs/springframework/spring-framework400.xml   | 82 +++---
 ...he-2.0-spring4.3.25 => Apache-2.0-spring4.3.29} | 28 ++--
 9 files changed, 150 insertions(+), 122 deletions(-)
 rename 
java/libs.springframework/external/{spring-framework-4.3.25.RELEASE-license.txt 
=> spring-framework-4.3.29.RELEASE-license.txt} (89%)
 rename 
java/libs.springframework/external/{spring-framework-4.3.25.RELEASE-notice.txt 
=> spring-framework-4.3.29.RELEASE-notice.txt} (100%)
 rename nbbuild/licenses/{Apache-2.0-spring4.3.25 => Apache-2.0-spring4.3.29} 
(93%)


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-4821) Cannot attach sources to Gradle library

2020-09-21 Thread Laszlo Kishalmi (Jira)



[ 
https://issues.apache.org/jira/browse/NETBEANS-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199482#comment-17199482
 ] 

Laszlo Kishalmi commented on NETBEANS-4821:
---

Well, please ping this issue once again when the sources are on maven central. 
I've checked the Gradle artifact cache handling upon this issue and found a 
better way to read the Gradle cache. I'm curious how would that work in this 
case. (The another big hit would be to get it work with JavaFx)

> Cannot attach sources to Gradle library
> ---
>
> Key: NETBEANS-4821
> URL: https://issues.apache.org/jira/browse/NETBEANS-4821
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Gradle
>Affects Versions: 12.1
>Reporter: Jaroslav Tulach
>Assignee: Laszlo Kishalmi
>Priority: Trivial
> Attachments: image-2020-09-20-08-06-46-654.png
>
>
> I am developing a sample demo using Gradle and I am unable to debug into a 
> library used in a test, as the source isn't available. To try:
> {code:java}
> $ git clone --single-branch --branch react4jdemo 
> https://github.com/jtulach/netbeans-html4j react4jdemo
> $ cd react4jdemo
> # following identifies the exact version I have on local disk:
> react4jdemo$ git log | head -n5
> commit 1e18917d0be1fc090cc9500c8286119710a29fde
> Author: Jaroslav Tulach 
> Date:   Sun Sep 20 07:50:11 2020 +0200Verify component class is 
> accessible before generating subclass{code}
> and open that and its {{api}} subproject in NetBeans 12.1. The following 
> picture...  !image-2020-09-20-08-06-46-654.png! ... shows what I did:
>  * expand the API's project junit-browser-runner library
>  * select BrowserRunner.class file
>  * right click, Open => opens the bytecode
>  * click "Attach Sources" and "Download"
>  * an error is shown
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Resolved] (NETBEANS-4823) ClassCastException saving GradleSettings

2020-09-21 Thread Laszlo Kishalmi (Jira)



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Kishalmi resolved NETBEANS-4823.
---
Fix Version/s: 12.2
   Resolution: Fixed

> ClassCastException saving GradleSettings
> 
>
> Key: NETBEANS-4823
> URL: https://issues.apache.org/jira/browse/NETBEANS-4823
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Gradle
>Reporter: Laszlo Kishalmi
>Assignee: Laszlo Kishalmi
>Priority: Major
> Fix For: 12.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Applying Ok on Options dialog results a ClassCast exception as the 
> GradleDistribution is set as a String in the version ComboBox.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-4827) TypeScript: toggle comment feature is disabled

2020-09-21 Thread Christian Lenz (Jira)



[ 
https://issues.apache.org/jira/browse/NETBEANS-4827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199422#comment-17199422
 ] 

Christian Lenz commented on NETBEANS-4827:
--

Reproducible, thx :)

> TypeScript: toggle comment feature is disabled
> --
>
> Key: NETBEANS-4827
> URL: https://issues.apache.org/jira/browse/NETBEANS-4827
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Other
>Affects Versions: 12.0.1
> Environment: Linux edevelop 5.8.10-arch1-1 #1 SMP PREEMPT Thu, 17 Sep 
> 2020 18:01:06 + x86_64 GNU/Linux
>Reporter: Ilya
>Assignee: Jan Lahoda
>Priority: Minor
>
> For TypeScript file toggle comment feature is disabled in "Menu" -> "Source" 
> -> "Toggle Comment".
> Also it not works using shortcuts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Assigned] (NETBEANS-4827) TypeScript: toggle comment feature is disabled

2020-09-21 Thread Christian Lenz (Jira)



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Lenz reassigned NETBEANS-4827:


Assignee: Jan Lahoda

> TypeScript: toggle comment feature is disabled
> --
>
> Key: NETBEANS-4827
> URL: https://issues.apache.org/jira/browse/NETBEANS-4827
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Other
>Affects Versions: 12.0.1
> Environment: Linux edevelop 5.8.10-arch1-1 #1 SMP PREEMPT Thu, 17 Sep 
> 2020 18:01:06 + x86_64 GNU/Linux
>Reporter: Ilya
>Assignee: Jan Lahoda
>Priority: Minor
>
> For TypeScript file toggle comment feature is disabled in "Menu" -> "Source" 
> -> "Toggle Comment".
> Also it not works using shortcuts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Assigned] (NETBEANS-4682) Java Record Formatting issue with use of annotation

2020-09-21 Thread Arunava Sinha (Jira)



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arunava Sinha reassigned NETBEANS-4682:
---

Assignee: Akhilesh Singh  (was: Arunava Sinha)

> Java Record Formatting issue with use of annotation
> ---
>
> Key: NETBEANS-4682
> URL: https://issues.apache.org/jira/browse/NETBEANS-4682
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 12.0
>Reporter: Arunava Sinha
>Assignee: Akhilesh Singh
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-4828) Review PayaraDescriptor loader & data object registrations.



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Svatopluk Dedic updated NETBEANS-4828:
--
Priority: Major  (was: Minor)

> Review PayaraDescriptor loader & data object registrations.
> ---
>
> Key: NETBEANS-4828
> URL: https://issues.apache.org/jira/browse/NETBEANS-4828
> Project: NetBeans
>  Issue Type: Bug
>  Components: javaee - DD Editor
>Affects Versions: 12.0
>Reporter: Svatopluk Dedic
>Priority: Major
> Fix For: 12.2
>
>
> During *commit-validation* cleanup, I have removed 
> {{@DataObject.Registration}} for 
> {{org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject}}.
>  
> The registration duplicates the one on {{PayaraDescriptorDataLoader}} and, 
> since it is position-ordered after it is not used during recognition IMHO.
> In addition, the registration requires that DataObject has a specific 
> constructor signature, which PayaraDescriptorDataObject does not satisfy: if 
> the registration was selected for DO construction, the creation would fail 
> with reflection exception:
> {code:bash}
> [junit] java.lang.NoSuchMethodException: 
> org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.(org.openide.filesystems.FileObj
> ect, org.openide.loaders.MultiFileLoader)
> [junit] at java.lang.Class.getConstructor0(Class.java:3082)
> [junit] at java.lang.Class.getConstructor(Class.java:1825)
> [junit] at org.openide.loaders.MimeFactory.(MimeFactory.java:54)
> [junit] Caused: java.lang.IllegalStateException: 
> org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.(org.openide.filesystems
> .FileObject, org.openide.loaders.MultiFileLoader)
> [junit] at org.openide.loaders.MimeFactory.(MimeFactory.java:57)
> [junit] at org.openide.loaders.MimeFactory.layer(MimeFactory.java:77)
> [junit] at 
> org.openide.loaders.DataLoaderPool.factory(DataLoaderPool.java:641)
> [junit] Caused: java.lang.reflect.InvocationTargetException
> {code}
> *Please review the registrations*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-4828) Review PayaraDescriptor loader & data object registrations.



 [ 
https://issues.apache.org/jira/browse/NETBEANS-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Svatopluk Dedic updated NETBEANS-4828:
--
Fix Version/s: 12.2

> Review PayaraDescriptor loader & data object registrations.
> ---
>
> Key: NETBEANS-4828
> URL: https://issues.apache.org/jira/browse/NETBEANS-4828
> Project: NetBeans
>  Issue Type: Bug
>  Components: javaee - DD Editor
>Affects Versions: 12.0
>Reporter: Svatopluk Dedic
>Priority: Minor
> Fix For: 12.2
>
>
> During *commit-validation* cleanup, I have removed 
> {{@DataObject.Registration}} for 
> {{org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject}}.
>  
> The registration duplicates the one on {{PayaraDescriptorDataLoader}} and, 
> since it is position-ordered after it is not used during recognition IMHO.
> In addition, the registration requires that DataObject has a specific 
> constructor signature, which PayaraDescriptorDataObject does not satisfy: if 
> the registration was selected for DO construction, the creation would fail 
> with reflection exception:
> {code:bash}
> [junit] java.lang.NoSuchMethodException: 
> org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.(org.openide.filesystems.FileObj
> ect, org.openide.loaders.MultiFileLoader)
> [junit] at java.lang.Class.getConstructor0(Class.java:3082)
> [junit] at java.lang.Class.getConstructor(Class.java:1825)
> [junit] at org.openide.loaders.MimeFactory.(MimeFactory.java:54)
> [junit] Caused: java.lang.IllegalStateException: 
> org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.(org.openide.filesystems
> .FileObject, org.openide.loaders.MultiFileLoader)
> [junit] at org.openide.loaders.MimeFactory.(MimeFactory.java:57)
> [junit] at org.openide.loaders.MimeFactory.layer(MimeFactory.java:77)
> [junit] at 
> org.openide.loaders.DataLoaderPool.factory(DataLoaderPool.java:641)
> [junit] Caused: java.lang.reflect.InvocationTargetException
> {code}
> *Please review the registrations*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Created] (NETBEANS-4828) Review PayaraDescriptor loader & data object registrations.

Svatopluk Dedic created NETBEANS-4828:
-

 Summary: Review PayaraDescriptor loader & data object 
registrations.
 Key: NETBEANS-4828
 URL: https://issues.apache.org/jira/browse/NETBEANS-4828
 Project: NetBeans
  Issue Type: Bug
  Components: javaee - DD Editor
Affects Versions: 12.0
Reporter: Svatopluk Dedic


During *commit-validation* cleanup, I have removed {{@DataObject.Registration}} 
for 
{{org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject}}. 
The registration duplicates the one on {{PayaraDescriptorDataLoader}} and, 
since it is position-ordered after it is not used during recognition IMHO.
In addition, the registration requires that DataObject has a specific 
constructor signature, which PayaraDescriptorDataObject does not satisfy: if 
the registration was selected for DO construction, the creation would fail with 
reflection exception:

{code:bash}
[junit] java.lang.NoSuchMethodException: 
org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.(org.openide.filesystems.FileObj
ect, org.openide.loaders.MultiFileLoader)
[junit] at java.lang.Class.getConstructor0(Class.java:3082)
[junit] at java.lang.Class.getConstructor(Class.java:1825)
[junit] at org.openide.loaders.MimeFactory.(MimeFactory.java:54)
[junit] Caused: java.lang.IllegalStateException: 
org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.(org.openide.filesystems
.FileObject, org.openide.loaders.MultiFileLoader)
[junit] at org.openide.loaders.MimeFactory.(MimeFactory.java:57)
[junit] at org.openide.loaders.MimeFactory.layer(MimeFactory.java:77)
[junit] at 
org.openide.loaders.DataLoaderPool.factory(DataLoaderPool.java:641)
[junit] Caused: java.lang.reflect.InvocationTargetException
{code}

*Please review the registrations*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Created] (NETBEANS-4827) TypeScript: toggle comment feature is disabled

2020-09-21 Thread Ilya (Jira)

Ilya created NETBEANS-4827:
--

 Summary: TypeScript: toggle comment feature is disabled
 Key: NETBEANS-4827
 URL: https://issues.apache.org/jira/browse/NETBEANS-4827
 Project: NetBeans
  Issue Type: Bug
  Components: editor - Other
Affects Versions: 12.0.1
 Environment: Linux edevelop 5.8.10-arch1-1 #1 SMP PREEMPT Thu, 17 Sep 
2020 18:01:06 + x86_64 GNU/Linux
Reporter: Ilya


For TypeScript file toggle comment feature is disabled in "Menu" -> "Source" -> 
"Toggle Comment".

Also it not works using shortcuts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Created] (NETBEANS-4826) Groovy completion tests fail when JavaIndexer reference in Groovy layer is fixed.

Svatopluk Dedic created NETBEANS-4826:
-

 Summary: Groovy completion tests fail when JavaIndexer reference 
in Groovy layer is fixed.
 Key: NETBEANS-4826
 URL: https://issues.apache.org/jira/browse/NETBEANS-4826
 Project: NetBeans
  Issue Type: Bug
  Components: groovy - Editor
Reporter: Svatopluk Dedic


For reference see [PR-2359|https://github.com/apache/netbeans/pull/2359]. The 
JavaIndexer .shadow file is broken (fails commit-validation task), but when 
fixed, tests in Groovy editor fail. Possibly the tests need to be updated 
appropriately.

I've removed (commented out) the indexer, as it was ineffective for years, but 
the change should be reviewed / fixed by someone knowledgeable in Groovy code.

Setting as major, as having / not having Java indexer may have quite an impact 
on the project's symbols.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Comment Edited] (NETBEANS-4314) java/maven dependency graph extremely slow



[ 
https://issues.apache.org/jira/browse/NETBEANS-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199196#comment-17199196
 ] 

Max Calderoni edited comment on NETBEANS-4314 at 9/21/20, 6:56 AM:
---

Same behavior on macOS Catalina. Steps to reproduce:
 * clone [https://github.com/jenkinsci/ci.jenkins.io-runner]
 * open pom.xml in the editor
 * click on Graph

NetBeans takes close to 400% of the CPU and takes more than 15 minutes (did not 
wait for completion, forced quit)

[^messages.log]


was (Author: max_asf):
Same behavior on macOS Catalina. Steps to reproduce:
 * clone [https://github.com/jenkinsci/ci.jenkins.io-runner]
 * open pom.xml in the editor
 * click on Graph

NetBeans takes close to 400% of the CPU and takes more than 15 minutes (did 
wait for completion, forced quit)

[^messages.log]

> java/maven dependency graph extremely slow
> --
>
> Key: NETBEANS-4314
> URL: https://issues.apache.org/jira/browse/NETBEANS-4314
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bernd Wahlen
>Priority: Major
> Attachments: messages.log
>
>
> when selecting graph in maven pom.xml, UI hangs for about 10 minues in 
> medium-sized (~70 dependencies) project. Experienced this issue for for long 
> time and still in 11.3, but definitely not in nb8. And btw graph calculation 
> is using only 1 cpu core.
> environment: ubuntu 20.04 lts / adopt 14.0.1 / nb 11.3 via snap / i3-6100



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Comment Edited] (NETBEANS-4314) java/maven dependency graph extremely slow



[ 
https://issues.apache.org/jira/browse/NETBEANS-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199196#comment-17199196
 ] 

Max Calderoni edited comment on NETBEANS-4314 at 9/21/20, 6:55 AM:
---

Same behavior on macOS Catalina. Steps to reproduce:
 * clone [https://github.com/jenkinsci/ci.jenkins.io-runner]
 * open pom.xml in the editor
 * click on Graph

NetBeans takes close to 400% of the CPU and takes more than 15 minutes (did 
wait for completion, forced quit)

[^messages.log]


was (Author: max_asf):
Same behavior on macOS Catalina. Steps to reproduce:
 * clone [https://github.com/jenkinsci/ci.jenkins.io-runner]
 * open pom.xml in the editor
 * click on Graph

NetBeans will take close to 400% of the CPU and takes more than 15 minutes (did 
wait for completion, forced quit)

[^messages.log]

> java/maven dependency graph extremely slow
> --
>
> Key: NETBEANS-4314
> URL: https://issues.apache.org/jira/browse/NETBEANS-4314
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bernd Wahlen
>Priority: Major
> Attachments: messages.log
>
>
> when selecting graph in maven pom.xml, UI hangs for about 10 minues in 
> medium-sized (~70 dependencies) project. Experienced this issue for for long 
> time and still in 11.3, but definitely not in nb8. And btw graph calculation 
> is using only 1 cpu core.
> environment: ubuntu 20.04 lts / adopt 14.0.1 / nb 11.3 via snap / i3-6100



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-4314) java/maven dependency graph extremely slow



[ 
https://issues.apache.org/jira/browse/NETBEANS-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199196#comment-17199196
 ] 

Max Calderoni commented on NETBEANS-4314:
-

Same behavior on macOS Catalina. Steps to reproduce:
 * clone [https://github.com/jenkinsci/ci.jenkins.io-runner]
 * open pom.xml in the editor
 * click on Graph

NetBeans will take close to 400% of the CPU and takes more than 15 minutes (did 
wait for completion, forced quit)

[^messages.log]

> java/maven dependency graph extremely slow
> --
>
> Key: NETBEANS-4314
> URL: https://issues.apache.org/jira/browse/NETBEANS-4314
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bernd Wahlen
>Priority: Major
> Attachments: messages.log
>
>
> when selecting graph in maven pom.xml, UI hangs for about 10 minues in 
> medium-sized (~70 dependencies) project. Experienced this issue for for long 
> time and still in 11.3, but definitely not in nb8. And btw graph calculation 
> is using only 1 cpu core.
> environment: ubuntu 20.04 lts / adopt 14.0.1 / nb 11.3 via snap / i3-6100



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-4314) java/maven dependency graph extremely slow