[jira] [Updated] (NETBEANS-5049) Crash in SemanticHighlighterBased for JSP
[ https://issues.apache.org/jira/browse/NETBEANS-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-5049: - Labels: pull-request-available (was: ) > Crash in SemanticHighlighterBased for JSP > - > > Key: NETBEANS-5049 > URL: https://issues.apache.org/jira/browse/NETBEANS-5049 > Project: NetBeans > Issue Type: Bug >Affects Versions: 12.2 >Reporter: Jan Lahoda >Assignee: Jan Lahoda >Priority: Critical > Labels: pull-request-available > Fix For: 12.3 > > Time Spent: 10m > Remaining Estimate: 0h > > The exception: > {noformat} > SEVERE [org.openide.util.Exceptions] > java.lang.NullPointerException: Cannot invoke > "org.netbeans.api.lexer.TokenSequence.index()" because "this.ts" is null > at > org.netbeans.modules.java.editor.base.semantic.TokenList.index(TokenList.java:364) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitExpressionStatement(SemanticHighlighterBase.java:740) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitExpressionStatement(SemanticHighlighterBase.java:280) > at > jdk.compiler/com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1540) > at > jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86) > at > org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:280) > at > jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:109) > at > org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78) > at > jdk.compiler/com.sun.source.util.TreeScanner.visitBlock(TreeScanner.java:254) > at > jdk.compiler/com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1059) > at > jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86) > at > org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:280) > at > jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:94) > at > jdk.compiler/com.sun.source.util.TreeScanner.visitMethod(TreeScanner.java:212) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitMethod(SemanticHighlighterBase.java:789) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitMethod(SemanticHighlighterBase.java:280) > at > jdk.compiler/com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:925) > at > jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86) > at > org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:280) > at > jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:109) > at > org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitClass(SemanticHighlighterBase.java:944) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitClass(SemanticHighlighterBase.java:280) > at > jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:832) > at > jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86) > at > org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) > at > org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) > at > org.netbeans.modules.java.editor.base.
[jira] [Created] (NETBEANS-5049) Crash in SemanticHighlighterBased for JSP
Jan Lahoda created NETBEANS-5049: Summary: Crash in SemanticHighlighterBased for JSP Key: NETBEANS-5049 URL: https://issues.apache.org/jira/browse/NETBEANS-5049 Project: NetBeans Issue Type: Bug Affects Versions: 12.2 Reporter: Jan Lahoda Assignee: Jan Lahoda Fix For: 12.3 The exception: {noformat} SEVERE [org.openide.util.Exceptions] java.lang.NullPointerException: Cannot invoke "org.netbeans.api.lexer.TokenSequence.index()" because "this.ts" is null at org.netbeans.modules.java.editor.base.semantic.TokenList.index(TokenList.java:364) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitExpressionStatement(SemanticHighlighterBase.java:740) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitExpressionStatement(SemanticHighlighterBase.java:280) at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1540) at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:280) at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:109) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78) at jdk.compiler/com.sun.source.util.TreeScanner.visitBlock(TreeScanner.java:254) at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1059) at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:280) at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:94) at jdk.compiler/com.sun.source.util.TreeScanner.visitMethod(TreeScanner.java:212) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitMethod(SemanticHighlighterBase.java:789) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitMethod(SemanticHighlighterBase.java:280) at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:925) at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:280) at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:109) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitClass(SemanticHighlighterBase.java:944) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitClass(SemanticHighlighterBase.java:280) at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:832) at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:69) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:1021) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.scan(SemanticHighlighterBase.java:280) at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:109) at org.netbeans.api.java.source.support.CancellableTreePathScanner.scan(CancellableTreePathScanner.java:78) at org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase$DetectorVisitor.visitCompilationUnit(SemanticHighlighterBase.java:561) at
svn commit: r44612 - in /dev/netbeans: netbeans-platform/12.2/vc1/ netbeans-platform/12.2/vc2/ netbeans/12.2/vc1/ netbeans/12.2/vc2/ netbeans/12.2/vc2/nbms/ netbeans/12.2/vc2/nbms/apisupport/ netbeans
Author: lkishalmi Date: Sat Nov 21 06:42:09 2020 New Revision: 44612 Log: Apache NetBeans 12.2 [This commit notification would consist of 197 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.] - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5048) Find Usages can't be cancelled
[ https://issues.apache.org/jira/browse/NETBEANS-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomáš Procházka updated NETBEANS-5048: -- Description: Action "Find Usages" in PHP editor can't be cancelled. This is usually problem when finding usages of public/protected methods with generic names like "create()", "get()" or "add()" in large codebases. These generic names are defined and used in a lot of places and Find Usages has to check them all. Steps to reproduce: # Clone Symfony repository ({{git clone [https://github.com/symfony/symfony.git]}}) # Open repository in NetBeans # Open file {{src/Component/Form/FormBuilderInterface.php}} # Run "Find Usages" on method {{create()}} # Try to cancel "Initializing data" process - nothing happens was: Action "Find Usages" in PHP editor can't be cancelled. This is usually problem when finding usages of public/private methods with generic names like "create()", "get()" or "add()" in large codebases. These generic names are defined and used in a lot of places and Find Usages has to check them all. Steps to reproduce: # Clone Symfony repository ({{git clone [https://github.com/symfony/symfony.git]}}) # Open repository in NetBeans # Open file {{src/Component/Form/FormBuilderInterface.php}} # Run "Find Usages" on method {{create()}} # Try to cancel "Initializing data" process - nothing happens > Find Usages can't be cancelled > -- > > Key: NETBEANS-5048 > URL: https://issues.apache.org/jira/browse/NETBEANS-5048 > Project: NetBeans > Issue Type: Bug > Components: php - Refactoring >Affects Versions: 12.2 >Reporter: Tomáš Procházka >Assignee: Tomáš Procházka >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Action "Find Usages" in PHP editor can't be cancelled. > This is usually problem when finding usages of public/protected methods with > generic names like "create()", "get()" or "add()" in large codebases. These > generic names are defined and used in a lot of places and Find Usages has to > check them all. > Steps to reproduce: > # Clone Symfony repository ({{git clone > [https://github.com/symfony/symfony.git]}}) > # Open repository in NetBeans > # Open file {{src/Component/Form/FormBuilderInterface.php}} > # Run "Find Usages" on method {{create()}} > # Try to cancel "Initializing data" process - nothing happens -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Closed] (NETBEANS-867) Refactoring popup does not close
[ https://issues.apache.org/jira/browse/NETBEANS-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomáš Procházka closed NETBEANS-867. Resolution: Duplicate Duplicate of NETBEANS-1729 > Refactoring popup does not close > > > Key: NETBEANS-867 > URL: https://issues.apache.org/jira/browse/NETBEANS-867 > Project: NetBeans > Issue Type: Bug > Components: php - Refactoring >Affects Versions: 8.2 > Environment: Product Version: NetBeans IDE 8.2 (Build 201609300101) > Updates: NetBeans IDE is updated to version NetBeans 8.2 Patch 2 > Java: 1.8.0_171; OpenJDK 64-Bit Server VM 25.171-b10 > Runtime: OpenJDK Runtime Environment 1.8.0_171-b10 > System: Linux version 4.16.11-200.fc27.x86_64 running on amd64; UTF-8; en_US > (nb) > User directory: /home/chopin/.netbeans/8.2 > Cache directory: /home/chopin/.cache/netbeans/8.2 >Reporter: chopin xiao >Priority: Major > Attachments: 2018-05-27 11-30-21屏幕截图.png > > > when refactor-rename php code many times, the refactoring popup box will does > not close > This issue reproduce only while refactor after many times, may be after > refactor three times reproduce > like below unsolve bug: > [https://netbeans.org/bugzilla/show_bug.cgi?id=252972] > [https://netbeans.org/bugzilla/show_bug.cgi?id=258261] > [https://netbeans.org/bugzilla/show_bug.cgi?id=268493] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5048) Find Usages can't be cancelled
[ https://issues.apache.org/jira/browse/NETBEANS-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-5048: - Labels: pull-request-available (was: ) > Find Usages can't be cancelled > -- > > Key: NETBEANS-5048 > URL: https://issues.apache.org/jira/browse/NETBEANS-5048 > Project: NetBeans > Issue Type: Bug > Components: php - Refactoring >Affects Versions: 12.2 >Reporter: Tomáš Procházka >Assignee: Tomáš Procházka >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Action "Find Usages" in PHP editor can't be cancelled. > This is usually problem when finding usages of public/private methods with > generic names like "create()", "get()" or "add()" in large codebases. These > generic names are defined and used in a lot of places and Find Usages has to > check them all. > Steps to reproduce: > # Clone Symfony repository ({{git clone > [https://github.com/symfony/symfony.git]}}) > # Open repository in NetBeans > # Open file {{src/Component/Form/FormBuilderInterface.php}} > # Run "Find Usages" on method {{create()}} > # Try to cancel "Initializing data" process - nothing happens -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5048) Find Usages can't be cancelled
[ https://issues.apache.org/jira/browse/NETBEANS-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomáš Procházka updated NETBEANS-5048: -- Description: Action "Find Usages" in PHP editor can't be cancelled. This is usually problem when finding usages of public/private methods with generic names like "create()", "get()" or "add()" in large codebases. These generic names are defined and used in a lot of places and Find Usages has to check them all. Steps to reproduce: # Clone Symfony repository ({{git clone [https://github.com/symfony/symfony.git]}}) # Open repository in NetBeans # Open file {{src/Component/Form/FormBuilderInterface.php}} # Run "Find Usages" on method {{create()}} # Try to cancel "Initializing data" process - nothing happens was: Action "Find Usages" in PHP editor can't be cancelled. This is usually problem when finding usages of public/private methods with generic names like "create()", "get()" or "add()" in large codebases. These generic names are defined and used in a lot of places and Find Usages has to check them all. Steps to reproduce: # Clone Symfony repository ({{git clone [https://github.com/symfony/symfony.git]}}) # Open repository in NetBeans # Open file {{src/Component/Form/FormBuilderInterface.php}} # Run "Find Usages" on method {{create()}}{{}} # Try to cancel "Initializing data" process - nothing happens > Find Usages can't be cancelled > -- > > Key: NETBEANS-5048 > URL: https://issues.apache.org/jira/browse/NETBEANS-5048 > Project: NetBeans > Issue Type: Bug > Components: php - Refactoring >Affects Versions: 12.2 >Reporter: Tomáš Procházka >Assignee: Tomáš Procházka >Priority: Minor > > Action "Find Usages" in PHP editor can't be cancelled. > This is usually problem when finding usages of public/private methods with > generic names like "create()", "get()" or "add()" in large codebases. These > generic names are defined and used in a lot of places and Find Usages has to > check them all. > Steps to reproduce: > # Clone Symfony repository ({{git clone > [https://github.com/symfony/symfony.git]}}) > # Open repository in NetBeans > # Open file {{src/Component/Form/FormBuilderInterface.php}} > # Run "Find Usages" on method {{create()}} > # Try to cancel "Initializing data" process - nothing happens -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-5048) Find Usages can't be cancelled
Tomáš Procházka created NETBEANS-5048: - Summary: Find Usages can't be cancelled Key: NETBEANS-5048 URL: https://issues.apache.org/jira/browse/NETBEANS-5048 Project: NetBeans Issue Type: Bug Components: php - Refactoring Affects Versions: 12.2 Reporter: Tomáš Procházka Assignee: Tomáš Procházka Action "Find Usages" in PHP editor can't be cancelled. This is usually problem when finding usages of public/private methods with generic names like "create()", "get()" or "add()" in large codebases. These generic names are defined and used in a lot of places and Find Usages has to check them all. Steps to reproduce: # Clone Symfony repository ({{git clone [https://github.com/symfony/symfony.git]}}) # Open repository in NetBeans # Open file {{src/Component/Form/FormBuilderInterface.php}} # Run "Find Usages" on method {{create()}}{{}} # Try to cancel "Initializing data" process - nothing happens -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans-jenkins-lib] branch master updated: Prepare for 2nd round of Vote for NetBeans 12.2
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans-jenkins-lib.git The following commit(s) were added to refs/heads/master by this push: new ff762b4 Prepare for 2nd round of Vote for NetBeans 12.2 ff762b4 is described below commit ff762b4a31c244a1ae05db7d2ace8a93c5e611e3 Author: Laszlo Kishalmi AuthorDate: Fri Nov 20 14:34:38 2020 -0800 Prepare for 2nd round of Vote for NetBeans 12.2 --- meta/netbeansrelease.json | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/netbeansrelease.json b/meta/netbeansrelease.json index cf7479b..0e635a8 100644 --- a/meta/netbeansrelease.json +++ b/meta/netbeansrelease.json @@ -336,6 +336,7 @@ }, "d73d3dd898acc440c460924dabf8ad5feb90369f": { "version": "rc3", +"vote": "2", "position": "6" } }, - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4509) PHP - code completion for function returning array
[ https://issues.apache.org/jira/browse/NETBEANS-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236478#comment-17236478 ] Tomáš Procházka commented on NETBEANS-4509: --- [~czukowski] Please, file issue dedicated only to {{NoClassDefFoundError}} in PHP Editor. We can continue discussion there. > PHP - code completion for function returning array > -- > > Key: NETBEANS-4509 > URL: https://issues.apache.org/jira/browse/NETBEANS-4509 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 12.0 >Reporter: Tomáš Procházka >Assignee: Tomáš Procházka >Priority: Major > Labels: pull-request-available > Fix For: 12.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > NetBeans support code completion for array items when their type is specified. > Code completion does not work for methods which have return type {{array}} in > signature and specific type in {{@return}} annotation. > In following code methods from {{\SplFileInfo}} are offered for variable > {{$file}}. > {code:php} > /** > * @param \SplFileInfo[] $files > */ > function walkFiles(array $files) { > foreach ($files as $file) { > $file-> // Offers methods from \SplFileInfo > } > } > {code} > In following code is expected same behavior, but no methods are offered. > {code:php} > /** > * @return \SplFileInfo[] > */ > function getFiles(): array { } > foreach (getFiles() as $file) { > $file-> // Does not offer methods from \SplFileInfo > } > {code} > If return type is removed from {{getFiles()}} method, then methods are > offered for {{$file}}. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-5028) PHP - improved display of constant in code completion
[ https://issues.apache.org/jira/browse/NETBEANS-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomáš Procházka resolved NETBEANS-5028. --- Fix Version/s: 12.3 Resolution: Fixed PR was merged. > PHP - improved display of constant in code completion > - > > Key: NETBEANS-5028 > URL: https://issues.apache.org/jira/browse/NETBEANS-5028 > Project: NetBeans > Issue Type: Improvement > Components: php - Editor >Affects Versions: 12.2 >Reporter: Tomáš Procházka >Assignee: Tomáš Procházka >Priority: Minor > Labels: pull-request-available > Fix For: 12.3 > > Attachments: netbeans5028-after.png, netbeans5028-before.png > > Time Spent: 40m > Remaining Estimate: 0h > > Constant containing array has in code completion its content displayed only > as question mark character. > It would be nice to have indication that constant contains array. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-5028] PHP - improved display of constant in code completion
This is an automated email from the ASF dual-hosted git repository. tmysik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new c36a4fa [NETBEANS-5028] PHP - improved display of constant in code completion new 96a7656 Merge pull request #2536 from KacerCZ/netbeans-5028-array-constant-completion c36a4fa is described below commit c36a4fa5aecdc9ba12ab09f2d680b8220daf9341 Author: Tomas Prochazka AuthorDate: Sat Nov 14 22:39:52 2020 +0100 [NETBEANS-5028] PHP - improved display of constant in code completion https://issues.apache.org/jira/browse/NETBEANS-5028 Improves display of array constant in code completion. Uses short array format, displays first item in array, indicates more elements in array. --- .../model/nodes/ConstantDeclarationInfo.java | 60 +- ...stSpreadOperatorInArrayExpression_02.completion | 16 +++--- ...tSpreadOperatorInArrayExpression_02a.completion | 16 +++--- ...stSpreadOperatorInArrayExpression_03.completion | 16 +++--- ...stSpreadOperatorInArrayExpression_04.completion | 16 +++--- ...atorInArrayExpression_GlobalConst_01.completion | 16 +++--- ...atorInArrayExpression_GlobalConst_02.completion | 16 +++--- ...atorInArrayExpression_GlobalConst_03.completion | 14 ++--- ...atorInArrayExpression_GlobalConst_05.completion | 2 +- ...atorInArrayExpression_GlobalConst_09.completion | 16 +++--- 10 files changed, 123 insertions(+), 65 deletions(-) diff --git a/php/php.editor/src/org/netbeans/modules/php/editor/model/nodes/ConstantDeclarationInfo.java b/php/php.editor/src/org/netbeans/modules/php/editor/model/nodes/ConstantDeclarationInfo.java index 3913bdf..a8246d9 100644 --- a/php/php.editor/src/org/netbeans/modules/php/editor/model/nodes/ConstantDeclarationInfo.java +++ b/php/php.editor/src/org/netbeans/modules/php/editor/model/nodes/ConstantDeclarationInfo.java @@ -16,12 +16,14 @@ * specific language governing permissions and limitations * under the License. */ - package org.netbeans.modules.php.editor.model.nodes; import java.util.ArrayList; import java.util.List; +import org.netbeans.api.annotations.common.CheckForNull; import org.netbeans.modules.php.editor.model.nodes.ASTNodeInfo.Kind; +import org.netbeans.modules.php.editor.parser.astnodes.ArrayCreation; +import org.netbeans.modules.php.editor.parser.astnodes.ArrayElement; import org.netbeans.modules.php.editor.parser.astnodes.ConstantDeclaration; import org.netbeans.modules.php.editor.parser.astnodes.Expression; import org.netbeans.modules.php.editor.parser.astnodes.Identifier; @@ -32,6 +34,7 @@ import org.netbeans.modules.php.editor.parser.astnodes.UnaryOperation; * @author Radek Matous */ public class ConstantDeclarationInfo extends ClassConstantDeclarationInfo { + ConstantDeclarationInfo(final Identifier node, final String value, final ConstantDeclaration constantDeclaration) { super(node, value, constantDeclaration); } @@ -42,6 +45,11 @@ public class ConstantDeclarationInfo extends ClassConstantDeclarationInfo { for (Identifier identifier : names) { String value = null; for (final Expression expression : constantDeclaration.getInitializers()) { +value = getConstantValue(expression); +if (value != null) { +break; +} +/* if (expression instanceof Scalar) { value = ((Scalar) expression).getStringValue(); break; @@ -54,6 +62,7 @@ public class ConstantDeclarationInfo extends ClassConstantDeclarationInfo { break; } } + */ } retval.add(new ConstantDeclarationInfo(identifier, value, constantDeclaration)); } @@ -64,4 +73,53 @@ public class ConstantDeclarationInfo extends ClassConstantDeclarationInfo { public Kind getKind() { return Kind.CONSTANT; } + +@CheckForNull +private static String getConstantValue(Expression expr) { +if (expr instanceof Scalar) { +return ((Scalar) expr).getStringValue(); +} +if (expr instanceof UnaryOperation) { +UnaryOperation up = (UnaryOperation) expr; +if (up.getOperator() == UnaryOperation.Operator.MINUS +&& up.getExpression() instanceof Scalar) { +return "-" + ((Scalar) up.getExpression()).getStringValue(); +} +} +if (expr instanceof ArrayCreation) { +return getConstantValue((ArrayCreation) expr); +} +return null; +} + +private static String getConstantValue(ArrayCreation expr) { +StringBuilder sb = new StringBuilder("["); //NOI18N +boolean itemAdded = false; +List elements =
[netbeans] tag 12.2-rc3 created (now d73d3dd)
This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a change to tag 12.2-rc3 in repository https://gitbox.apache.org/repos/asf/netbeans.git. at d73d3dd (commit) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-5029) PHP - generate methods as public by default
[ https://issues.apache.org/jira/browse/NETBEANS-5029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomáš Procházka resolved NETBEANS-5029. --- Fix Version/s: 12.3 Resolution: Fixed PR was merged. > PHP - generate methods as public by default > --- > > Key: NETBEANS-5029 > URL: https://issues.apache.org/jira/browse/NETBEANS-5029 > Project: NetBeans > Issue Type: Improvement > Components: php - Editor >Affects Versions: 12.2 >Reporter: Tomáš Procházka >Assignee: Tomáš Procházka >Priority: Minor > Labels: pull-request-available > Fix For: 12.3 > > Attachments: constructor-generator.png > > Time Spent: 50m > Remaining Estimate: 0h > > It is common and recommended practice to use visibility modifier for all > members of classes > ([PSR-12|https://www.php-fig.org/psr/psr-12/#44-methods-and-functions]). > It is useful to tick public modifier when generating > constructor/getters/setters. > !constructor-generator.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5045) in https://netbeans.apache.org/nb/plugins/12.0/catalog.xml.gz, module distribution have double "/" and broke download
[ https://issues.apache.org/jira/browse/NETBEANS-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236090#comment-17236090 ] Philippe FICHET commented on NETBEANS-5045: --- It work for me, thanks :) > in https://netbeans.apache.org/nb/plugins/12.0/catalog.xml.gz, module > distribution have double "/" and broke download > - > > Key: NETBEANS-5045 > URL: https://issues.apache.org/jira/browse/NETBEANS-5045 > Project: NetBeans > Issue Type: Bug >Affects Versions: 12.0 >Reporter: Philippe FICHET >Priority: Blocker > Attachments: NetbeansModueDownloadFailedWithDoubleSlash.png > > > In [https://netbeans.apache.org/nb/plugins/12.0/catalog.xml.gz,] some modules > have double "/" in "distribution" attribute. > With double "/", the download failed with http code 404. > When remove one "/", the download work. > > Example: > [https://plugins.netbeans.apache.org/catalogue/download//134/guipopup-netbeans-plugin-0.1.1.nbm] > -> cannot download > [https://plugins.netbeans.apache.org/catalogue/download/134/guipopup-netbeans-plugin-0.1.1.nbm] > -> download work > > My Netbeans details: > Product Version: Apache NetBeans IDE 12.0 > Java: 11.0.2; OpenJDK 64-Bit Server VM 11.0.2+9 > Runtime: OpenJDK Runtime Environment 11.0.2+9 > System: Windows 10 version 10.0 running on amd64; Cp1252; fr_FR (nb) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-4650] Fix code completion for traits of use and group use statements
This is an automated email from the ASF dual-hosted git repository. tmysik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new f2bad76 [NETBEANS-4650] Fix code completion for traits of use and group use statements new f986c03 Merge pull request #2533 from junichi11/netbeans-4650 f2bad76 is described below commit f2bad76137cb79840af39ac1bf2f48688eedd2d1 Author: Junichi Yamamoto AuthorDate: Sun Nov 15 00:20:45 2020 +0900 [NETBEANS-4650] Fix code completion for traits of use and group use statements --- .../php/editor/completion/PHPCodeCompletion.java | 14 ++ .../testfiles/completion/lib/nb4650/nb4650.php | 30 .../lib/nb4650/nb4650.php.testNb4650_01.completion | 4 ++ .../lib/nb4650/nb4650.php.testNb4650_02.completion | 4 ++ .../issue241902.php.testUseCase1.completion| 1 + .../completion/PHPCodeCompletionNb4650Test.java| 57 ++ 6 files changed, 110 insertions(+) diff --git a/php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCodeCompletion.java b/php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCodeCompletion.java index 62cf1e8..c9c85cc 100644 --- a/php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCodeCompletion.java +++ b/php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCodeCompletion.java @@ -920,6 +920,13 @@ public class PHPCodeCompletion implements CodeCompletionHandler2 { } completionResult.add(new PHPCompletionItem.InterfaceItem(iface, request, QualifiedNameKind.FULLYQUALIFIED, false)); } +// NETBEANS-4650 +for (TraitElement trait : request.index.getTraits(nameQuery)) { +if (CancelSupport.getDefault().isCancelled()) { +return; +} +completionResult.add(new PHPCompletionItem.TraitItem(trait, request)); +} break; case CONST: for (ConstantElement constant : request.index.getConstants(nameQuery)) { @@ -975,6 +982,13 @@ public class PHPCodeCompletion implements CodeCompletionHandler2 { } completionResult.add(new PHPCompletionItem.InterfaceItem(iface, request, kind, false)); } +// NETBEANS-4650 +for (TraitElement trait : request.index.getTraits(nameQuery)) { +if (CancelSupport.getDefault().isCancelled()) { +return; +} +completionResult.add(new PHPCompletionItem.TraitItem(trait, request)); +} break; case CONST: for (ConstantElement constant : request.index.getConstants(nameQuery)) { diff --git a/php/php.editor/test/unit/data/testfiles/completion/lib/nb4650/nb4650.php b/php/php.editor/test/unit/data/testfiles/completion/lib/nb4650/nb4650.php new file mode 100644 index 000..6c1279c --- /dev/null +++ b/php/php.editor/test/unit/data/testfiles/completion/lib/nb4650/nb4650.php @@ -0,0 +1,30 @@ +http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +namespace Test; +trait MyTrait{} + +namespace TestTrait; + +use Test\MyTrait; +use Test\{ +MyTrait +}; + +class MyClass{} diff --git a/php/php.editor/test/unit/data/testfiles/completion/lib/nb4650/nb4650.php.testNb4650_01.completion b/php/php.editor/test/unit/data/testfiles/completion/lib/nb4650/nb4650.php.testNb4650_01.completion new file mode 100644 index 000..7b3e17a --- /dev/null +++ b/php/php.editor/test/unit/data/testfiles/completion/lib/nb4650/nb4650.php.testNb4650_01.completion @@ -0,0 +1,4 @@ +Code completion result for source line: +use Test\M|yTrait; +(QueryType=COMPLETION, prefixSearch=true, caseSensitive=true) +CLASS MyTrait [PUBLIC] Test diff --git a/php/php.editor/test/unit/data/testfiles/completion/lib/nb4650/nb4650.php.testNb4650_02.completion b/php/php.editor/test/unit/data/testfiles/completion/lib/nb4650/nb4650.php.testNb4650_02.completion new file mode 100644 index 000..980d4c2 --- /dev/null +++ b/php/php.editor/test/unit/data/testfiles/completion/lib/nb4650/nb4650.php.testNb4650_02.completion @@ -0,0 +1,4 @@ +Code completion result for source line: +My|Trait +(QueryType=COMPLETION, prefixSearch=true, caseSensitive=true) +CLASS MyTrait [PUBLIC] Test diff --git a/php/php.editor/test/unit/data/testfile
[netbeans] branch master updated: [NETBEANS-5029] PHP - generated methods are public by default
This is an automated email from the ASF dual-hosted git repository. tmysik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new 5d115a7 [NETBEANS-5029] PHP - generated methods are public by default new 43c2cea Merge pull request #2537 from KacerCZ/netbeans-5029-generator-default-public 5d115a7 is described below commit 5d115a793d01c690b1a8b1ff95559bb46fb72442 Author: Tomas Prochazka AuthorDate: Sun Nov 15 06:55:08 2020 +0100 [NETBEANS-5029] PHP - generated methods are public by default https://issues.apache.org/jira/browse/NETBEANS-5029 Changes default value for generating public modifier of constructor/getters/setters to enabled. --- .../src/org/netbeans/modules/php/editor/codegen/CGSGenerator.java | 2 +- .../src/org/netbeans/modules/php/editor/codegen/CGSInfo.java | 2 +- .../php/editor/codegen/SelectedPropertyMethodsCreatorTest.java| 4 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSGenerator.java b/php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSGenerator.java index adfeb83..5ca6da2 100644 --- a/php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSGenerator.java +++ b/php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSGenerator.java @@ -425,7 +425,7 @@ public final class CGSGenerator implements CodeGenerator { cgsInfo.setHowToGenerate(GenWay.AS_JAVA); } cgsInfo.setFluentSetter(preferences.getBoolean(FLUENT_SETTER_PROJECT_PROPERTY, false)); - cgsInfo.setPublicModifier(preferences.getBoolean(PUBLIC_MODIFIER_PROJECT_PROPERTY, false)); + cgsInfo.setPublicModifier(preferences.getBoolean(PUBLIC_MODIFIER_PROJECT_PROPERTY, true)); } DialogDescriptor desc = new DialogDescriptor(genType.createPanel(cgsInfo), genType.getDialogTitle()); Dialog dialog = DialogDisplayer.getDefault().createDialog(desc); diff --git a/php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSInfo.java b/php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSInfo.java index 4df39f4..810fd69 100644 --- a/php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSInfo.java +++ b/php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSInfo.java @@ -116,7 +116,7 @@ public final class CGSInfo { hasConstructor = false; this.generateDoc = true; fluentSetter = false; -isPublicModifier = false; +isPublicModifier = true; this.howToGenerate = CGSGenerator.GenWay.AS_JAVA; this.phpVersion = phpVersion != null ? phpVersion : PhpVersion.getDefault(); } diff --git a/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/codegen/SelectedPropertyMethodsCreatorTest.java b/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/codegen/SelectedPropertyMethodsCreatorTest.java index 94176ff..72581f7 100644 --- a/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/codegen/SelectedPropertyMethodsCreatorTest.java +++ b/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/codegen/SelectedPropertyMethodsCreatorTest.java @@ -212,24 +212,28 @@ public class SelectedPropertyMethodsCreatorTest extends PHPTestBase { public void testGetterWithType_01() throws Exception { CGSInfo cgsInfo = getCgsInfo("class Foo {^", PhpVersion.PHP_70); +cgsInfo.setPublicModifier(false); checkResult(new SelectedPropertyMethodsCreator().create( selectAllProperties(cgsInfo.getPossibleGetters()), new SinglePropertyMethodCreator.SingleGetterCreator(cgsInfo))); } public void testGetterWithType_02() throws Exception { CGSInfo cgsInfo = getCgsInfo("class Foo {^", PhpVersion.PHP_55); +cgsInfo.setPublicModifier(false); checkResult(new SelectedPropertyMethodsCreator().create( selectAllProperties(cgsInfo.getPossibleGetters()), new SinglePropertyMethodCreator.SingleGetterCreator(cgsInfo))); } public void testGetterWithMoreTypes_01() throws Exception { CGSInfo cgsInfo = getCgsInfo("class Foo {^", PhpVersion.PHP_70); +cgsInfo.setPublicModifier(false); checkResult(new SelectedPropertyMethodsCreator().create( selectAllProperties(cgsInfo.getPossibleGetters()), new SinglePropertyMethodCreator.SingleGetterCreator(cgsInfo))); } public void testGetterWithMoreTypes_02() throws Exception { CGSInfo cgsInfo = getCgsInfo("class Foo {^", PhpVersion.PHP_56); +cgsInfo.setPublicModifier(false); checkResult(new SelectedPropertyMethodsCreator().create( selectAllProperties(cgsInfo.getPossibleGetters()), new SinglePropertyMethodCreator.SingleGetterCreator(cgsInfo))); }