[jira] [Commented] (NETBEANS-377) Only underline the non-matching part of namespace
[ https://issues.apache.org/jira/browse/NETBEANS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280403#comment-17280403 ] Tomáš Procházka commented on NETBEANS-377: -- I filed NETBEANS-5341 as follow-up improvement. > Only underline the non-matching part of namespace > - > > Key: NETBEANS-377 > URL: https://issues.apache.org/jira/browse/NETBEANS-377 > Project: NetBeans > Issue Type: Improvement > Components: php - Editor >Affects Versions: 8.2 >Reporter: Simon Heimberg >Assignee: Tomáš Procházka >Priority: Minor > Labels: pull-request-available > Fix For: 12.3 > > Attachments: image-2021-01-01-14-48-29-774.png > > Time Spent: 2h 50m > Remaining Estimate: 0h > > When the namespace does not correspondent to the directory structure, the > namespace is underlined. Fine! > But with PSR4 structure, the start of the namespace is often different to the > directory structure. But the end should match. > I suppose to only underline the part of the namespace, which does not match > the directory structure. Then the user can determine himself if this part is > because of PSR-4 or because of a typo. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-5341) PSR-4 hints - read namespace mapping from Composer
Tomáš Procházka created NETBEANS-5341: - Summary: PSR-4 hints - read namespace mapping from Composer Key: NETBEANS-5341 URL: https://issues.apache.org/jira/browse/NETBEANS-5341 Project: NetBeans Issue Type: Improvement Components: php - Editor Reporter: Tomáš Procházka File {{composer.json}} contains mapping from namespace to path. This definition can be used during check if namespace matches directory. Composer documentation: https://getcomposer.org/doc/04-schema.md#psr-4 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-4637) Update PHP Code Templates
[ https://issues.apache.org/jira/browse/NETBEANS-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280326#comment-17280326 ] Tomáš Procházka edited comment on NETBEANS-4637 at 2/7/21, 7:22 AM: Please accept my apology for this misbehavior. I was too eager to help - solution was trivial so I prepared PR. My intentions were not bad, I just wanted to help you and spare your time. PR is closed and issue assigned back. I'm sorry. was (Author: kacer): Sorry, I will not do it again. > Update PHP Code Templates > - > > Key: NETBEANS-4637 > URL: https://issues.apache.org/jira/browse/NETBEANS-4637 > Project: NetBeans > Issue Type: Improvement > Components: php - Editor >Affects Versions: 12.0 >Reporter: Los Vitaly >Assignee: Junichi Yamamoto >Priority: Minor > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > For *while* loop Netbeans give obsolete auto suggestion related for mysql > function > There are my_fa, my-fo, my_fr abbreviation in PHP Code Templates that should > be deleted -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-4637) Update PHP Code Templates
[ https://issues.apache.org/jira/browse/NETBEANS-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomáš Procházka reassigned NETBEANS-4637: - Assignee: Junichi Yamamoto (was: Tomáš Procházka) > Update PHP Code Templates > - > > Key: NETBEANS-4637 > URL: https://issues.apache.org/jira/browse/NETBEANS-4637 > Project: NetBeans > Issue Type: Improvement > Components: php - Editor >Affects Versions: 12.0 >Reporter: Los Vitaly >Assignee: Junichi Yamamoto >Priority: Minor > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > For *while* loop Netbeans give obsolete auto suggestion related for mysql > function > There are my_fa, my-fo, my_fr abbreviation in PHP Code Templates that should > be deleted -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5340) Possible NPE in Gradle Favorite Task Node
[ https://issues.apache.org/jira/browse/NETBEANS-5340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-5340: - Labels: pull-request-available (was: ) > Possible NPE in Gradle Favorite Task Node > - > > Key: NETBEANS-5340 > URL: https://issues.apache.org/jira/browse/NETBEANS-5340 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Reporter: Laszlo Kishalmi >Assignee: Laszlo Kishalmi >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Under some conditions when there is no projects selected and a Gradle project > would be freshly opened the TaskNode creation for Gradle can result an NPE. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-5340) Possible NPE in Gradle Favorite Task Node
Laszlo Kishalmi created NETBEANS-5340: - Summary: Possible NPE in Gradle Favorite Task Node Key: NETBEANS-5340 URL: https://issues.apache.org/jira/browse/NETBEANS-5340 Project: NetBeans Issue Type: Bug Components: projects - Gradle Reporter: Laszlo Kishalmi Assignee: Laszlo Kishalmi Under some conditions when there is no projects selected and a Gradle project would be freshly opened the TaskNode creation for Gradle can result an NPE. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-5321) GAV resolving error in gradle composite project
[ https://issues.apache.org/jira/browse/NETBEANS-5321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi resolved NETBEANS-5321. --- Resolution: Duplicate > GAV resolving error in gradle composite project > --- > > Key: NETBEANS-5321 > URL: https://issues.apache.org/jira/browse/NETBEANS-5321 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 12.2 >Reporter: Walery Wysotsky >Assignee: Walery Wysotsky >Priority: Critical > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Exception like: > Invalig GAV format: project: :db > appeared after gradle composite project opened > This is due to in gradle composite not defined neither group, nor version by > default, like: > includeBuild 'db' > > Same project builds normally in command line -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5090) JSF CDI bean code created without "implements Serializable"
[ https://issues.apache.org/jira/browse/NETBEANS-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280329#comment-17280329 ] Stephen Brooksbank commented on NETBEANS-5090: -- Also please note @SessionScoped and @ConversationScoped are also passivating scope types. ??Source: Specification: Jakarta Contexts and Dependency Injection Version: 2.0 Status: Final Release: Aug 10 2019?? {noformat} 6.7.2. Session context lifecycle The session context is provided by a built-in context object for the built-in passivating scope type@SessionScoped. {noformat} and {noformat} 6.7.4. Conversation context lifecycle The conversation context is provided by a built-in context object for the built-in passivating scopetype @ConversationScoped. {noformat} Thanks. > JSF CDI bean code created without "implements Serializable" > --- > > Key: NETBEANS-5090 > URL: https://issues.apache.org/jira/browse/NETBEANS-5090 > Project: NetBeans > Issue Type: Bug > Components: javaee - JSF >Affects Versions: 12.1 > Environment: Windows / NetBeans 12.1 >Reporter: Stephen Brooksbank >Assignee: Jakub Herkel >Priority: Minor > > When using the file -> new option to create "JSF CDI Bean" for View scope > (and others) the bean file gets created without the "implements Serializable" > option included on the class name. The deploy subsequently fails if this > doesn't get added manually. It would obviously be better if the code was > generated correctly. > The relevent template file does include: > {{ <#if passivationCapable??>}} > {{import java.io.Serializable;}} > {{ }} > and > {{public class ${name} <#if passivationCapable??>implements > Serializable{}} > So behind the hood the "passivationCapable" variable is not being correctly > set for the CDI scope(s). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4637) Update PHP Code Templates
[ https://issues.apache.org/jira/browse/NETBEANS-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280326#comment-17280326 ] Tomáš Procházka commented on NETBEANS-4637: --- Sorry, I will not do it again. > Update PHP Code Templates > - > > Key: NETBEANS-4637 > URL: https://issues.apache.org/jira/browse/NETBEANS-4637 > Project: NetBeans > Issue Type: Improvement > Components: php - Editor >Affects Versions: 12.0 >Reporter: Los Vitaly >Assignee: Tomáš Procházka >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > For *while* loop Netbeans give obsolete auto suggestion related for mysql > function > There are my_fa, my-fo, my_fr abbreviation in PHP Code Templates that should > be deleted -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-95) Code templates for HTML/XHTML will not shown in code completion
[ https://issues.apache.org/jira/browse/NETBEANS-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280318#comment-17280318 ] Tomáš Procházka commented on NETBEANS-95: - Templates in HTML were improved in NetBeans 12.1 by NETBEANS-4576. Please try if it solves your problem. > Code templates for HTML/XHTML will not shown in code completion > --- > > Key: NETBEANS-95 > URL: https://issues.apache.org/jira/browse/NETBEANS-95 > Project: NetBeans > Issue Type: Improvement > Components: web - HTML Editor >Affects Versions: 8.2 >Reporter: Christian Lenz >Priority: Major > > Unfortunately, custom templates, the one that already exists like d -> TAB -> > content or custom ones, will not shown in the code completion of > HTML. This is really weird and a big problem, because if you have smth like > this: a-ngFor-trackBy this is first hard to know and second hard to type it > everytime to the full name. > The problem is, that there is no context set like for JS, Java or PHP. So JS, > PHP and Java works fine, if you create a code template and check the checkbox > of the context. So please add the functionality, that all code templates will > shown in the code completion. > Regards > Chris -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4637) Update PHP Code Templates
[ https://issues.apache.org/jira/browse/NETBEANS-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280316#comment-17280316 ] Junichi Yamamoto commented on NETBEANS-4637: Well, I don't think your behavior is good. I assigned this me, right? > Update PHP Code Templates > - > > Key: NETBEANS-4637 > URL: https://issues.apache.org/jira/browse/NETBEANS-4637 > Project: NetBeans > Issue Type: Improvement > Components: php - Editor >Affects Versions: 12.0 >Reporter: Los Vitaly >Assignee: Tomáš Procházka >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > For *while* loop Netbeans give obsolete auto suggestion related for mysql > function > There are my_fa, my-fo, my_fr abbreviation in PHP Code Templates that should > be deleted -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Closed] (NETBEANS-147) Content in string literals are formatted by Format
[ https://issues.apache.org/jira/browse/NETBEANS-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomáš Procházka closed NETBEANS-147. Resolution: Cannot Reproduce I tested it in NetBeans 12.3 beta2 and I can't reproduce the issue - text stays without formatting. > Content in string literals are formatted by Format > -- > > Key: NETBEANS-147 > URL: https://issues.apache.org/jira/browse/NETBEANS-147 > Project: NetBeans > Issue Type: Bug > Components: web - HTML Editor >Affects Versions: 8.2, 10.0 >Reporter: Gunnar Grim >Priority: Critical > Labels: format, html > > When formatting a HTML page/PHP file, string literal content is formatted. > Before formatting I had this attribute on a div in an Agular view: > ng-class="($first ? '' : 'hidden-xs hidden-sm')" > After formatting, NetBeans changed it into this: > ng-class="($first ? '' : 'hidden - xs hidden - sm')" > This is pretty serious IMO since the page presentation is messed up by > incorrect classes. > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Closed] (NETBEANS-5136) double checked locking idiom wrong in inspect and transform
[ https://issues.apache.org/jira/browse/NETBEANS-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Hammer closed NETBEANS-5136. > double checked locking idiom wrong in inspect and transform > --- > > Key: NETBEANS-5136 > URL: https://issues.apache.org/jira/browse/NETBEANS-5136 > Project: NetBeans > Issue Type: Bug > Components: java - Refactoring >Affects Versions: 12.2 >Reporter: Carsten Hammer >Priority: Critical > > The pattern implemented in > [https://bz.apache.org/netbeans/show_bug.cgi?id=248740] seems to be wrong > according to > [https://docs.google.com/document/d/1mAeEgQu4H4ADxa03k7YaVDjIP5vJBvjVIjg3DIvoc8E/edit] > The right pattern looks like this: > # 334, Second code example. *_This is a serious error!_* The current code > can return null if multiple threads race to initialize the field. Here’s how > the code should look: > > {code:java} > // Double-check idiom for lazy initialization of instance fields > private volatile FieldType field; > > private FieldType getField() { > FieldType result = field; > if (result != null) // First check (no locking) > return result; > > synchronized(this){ > if (field == null) // Second check (with locking) > field = computeFieldValue(); > return field; > } > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1046) Ctrl+click not working in xhtml pages
[ https://issues.apache.org/jira/browse/NETBEANS-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280309#comment-17280309 ] Tomáš Procházka commented on NETBEANS-1046: --- Please test if this issue is still present in latest version of NetBeans (currently 12.2). If it is still a problem, then please attach sample project to reproduce the issue. Thank you. > Ctrl+click not working in xhtml pages > - > > Key: NETBEANS-1046 > URL: https://issues.apache.org/jira/browse/NETBEANS-1046 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Project, web - HTML Editor >Affects Versions: 9.0, 11.2 > Environment: openjdk-10, (also 1.8), Linux j4.17.5-200.fc28, x86_64 >Reporter: John Whitley >Priority: Minor > > Although ctrl+click works with java source, it no longer does so in xhtml/jsf > pages. This appears to be a regression from netbeans 8.2. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-5120) Javadoc blocks freezing IDE
[ https://issues.apache.org/jira/browse/NETBEANS-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280305#comment-17280305 ] Wayne Wilson edited comment on NETBEANS-5120 at 2/6/21, 10:05 PM: -- [~jherkel], 12.0 was, and is, the latest LTS release. So before making non-contributory comments like this that don't contribute in any way, how about verifying the current LTS version? Not everyone wants a bunch of beta versions on their system, especially when that software comes from a service that can't even make sure that it's LTS/Stable track is properly functioning. was (Author: ww91): [~jherkel], 12.0 was, and is, the latest LTS release. So before making useless comments like this that don't contribute in any way, how about verifying the current LTS version? Not everyone wants a bunch of beta versions on their system, especially when that software comes from a service that can't even make sure that it's LTS/Stable track is properly functioning. > Javadoc blocks freezing IDE > --- > > Key: NETBEANS-5120 > URL: https://issues.apache.org/jira/browse/NETBEANS-5120 > Project: NetBeans > Issue Type: Bug > Components: java - Javadoc >Affects Versions: 12.0 >Reporter: Wayne Wilson >Priority: Major > Labels: JavaDoc, netbeans-12 > > When placing a Javadoc block in the first line of a file, it crashes the IDE. > This issue occurs in basic Java files, but also in package-info files, as > well. > This issue also occurs if there are less than 3 lines following the end of > the Javadoc Block. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1682) Adding real formatting for SQL
[ https://issues.apache.org/jira/browse/NETBEANS-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomáš Procházka updated NETBEANS-1682: -- Component/s: db - SQL Editor > Adding real formatting for SQL > -- > > Key: NETBEANS-1682 > URL: https://issues.apache.org/jira/browse/NETBEANS-1682 > Project: NetBeans > Issue Type: Improvement > Components: db - SQL Editor, web - HTML Editor >Affects Versions: 8.2, 10.0 >Reporter: Christian Lenz >Priority: Major > > Unfortunately there is no real formatter for SQL files. > So this: {code:sql}SELECT * FROM tableName WHERE ...{code} > Should expand to: > {code:sql} > SELECT >* > FROM >tableName > WHERE >... > {code} > For this, we need formatting options for SQL, which will be handled in this > ticket: NETBEANS-1681. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1776) Netbeans 9.0 locks up on save of HTML file. Get spinning circle of DEATH
[ https://issues.apache.org/jira/browse/NETBEANS-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280307#comment-17280307 ] Tomáš Procházka commented on NETBEANS-1776: --- Can you please test if this issue is still present in recent version of NetBeans (12.2 at time of comment). > Netbeans 9.0 locks up on save of HTML file. Get spinning circle of DEATH > > > Key: NETBEANS-1776 > URL: https://issues.apache.org/jira/browse/NETBEANS-1776 > Project: NetBeans > Issue Type: Bug > Components: web - HTML Editor >Affects Versions: 9.0 >Reporter: PETER BORREGGINE >Priority: Major > Fix For: 9.0 > > > I'm working on a simple HTML file removing << HEAD and other merge > conflicts. When I click the SAVE button, NETBEANS LOCKS UP...the MEMORY keeps > increasing and the cursor is a SPINNING CIRCLE OF DEATH and I can't click on > anything. Check for EXTERNAL changes is suspended and I am relegated to end > task in Task Manager. > This is a continual problem with 9.0 and it is not reliable or consistent. > Please advise. > > OF NOTE: All caps is not yelling, just emphasis. Sorry. It's how I type. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5120) Javadoc blocks freezing IDE
[ https://issues.apache.org/jira/browse/NETBEANS-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280305#comment-17280305 ] Wayne Wilson commented on NETBEANS-5120: [~jherkel], 12.0 was, and is, the latest LTS release. So before making useless comments like this that don't contribute in any way, how about verifying the current LTS version? Not everyone wants a bunch of beta versions on their system, especially when that software comes from a service that can't even make sure that it's LTS/Stable track is properly functioning. > Javadoc blocks freezing IDE > --- > > Key: NETBEANS-5120 > URL: https://issues.apache.org/jira/browse/NETBEANS-5120 > Project: NetBeans > Issue Type: Bug > Components: java - Javadoc >Affects Versions: 12.0 >Reporter: Wayne Wilson >Priority: Major > Labels: JavaDoc, netbeans-12 > > When placing a Javadoc block in the first line of a file, it crashes the IDE. > This issue occurs in basic Java files, but also in package-info files, as > well. > This issue also occurs if there are less than 3 lines following the end of > the Javadoc Block. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-5136) double checked locking idiom wrong in inspect and transform
[ https://issues.apache.org/jira/browse/NETBEANS-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Hammer resolved NETBEANS-5136. -- Resolution: Invalid Thanks for your time and for having a look! > double checked locking idiom wrong in inspect and transform > --- > > Key: NETBEANS-5136 > URL: https://issues.apache.org/jira/browse/NETBEANS-5136 > Project: NetBeans > Issue Type: Bug > Components: java - Refactoring >Affects Versions: 12.2 >Reporter: Carsten Hammer >Priority: Critical > > The pattern implemented in > [https://bz.apache.org/netbeans/show_bug.cgi?id=248740] seems to be wrong > according to > [https://docs.google.com/document/d/1mAeEgQu4H4ADxa03k7YaVDjIP5vJBvjVIjg3DIvoc8E/edit] > The right pattern looks like this: > # 334, Second code example. *_This is a serious error!_* The current code > can return null if multiple threads race to initialize the field. Here’s how > the code should look: > > {code:java} > // Double-check idiom for lazy initialization of instance fields > private volatile FieldType field; > > private FieldType getField() { > FieldType result = field; > if (result != null) // First check (no locking) > return result; > > synchronized(this){ > if (field == null) // Second check (with locking) > field = computeFieldValue(); > return field; > } > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5136) double checked locking idiom wrong in inspect and transform
[ https://issues.apache.org/jira/browse/NETBEANS-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280303#comment-17280303 ] Carsten Hammer commented on NETBEANS-5136: -- Hi Jan, the code that works according to the github bug description looks like this: {code:java} private volatile String init; public String get() { String init= this.init; if (init == null) { // First check (no locking) synchronized (this) { if (this.init == null) // Second check (with locking) this.init = init= computeFieldValue(); else init= this.init; } } return init; } {code} So the difference is {code:java} init = this.init; if (init == null) { this.init = init = ""; } {code} vs {code:java} if (this.init == null) // Second check (with locking) this.init = init= computeFieldValue(); else init= this.init; {code} within the synchronized section. Is this the same? It doesn't look like it is the same. But maybe similar enough and in the end the netbeans variant is identical to the older code from Joshua Bloch published at https://www.oracle.com/technical-resources/articles/javase/bloch-effective-08-qa.html that seems to be fine too. So - apologies - your code seems to be ok! I close this now. As a sidenote I still prefer the variant in the description of this issue but of course this is a matter of personal preference. > double checked locking idiom wrong in inspect and transform > --- > > Key: NETBEANS-5136 > URL: https://issues.apache.org/jira/browse/NETBEANS-5136 > Project: NetBeans > Issue Type: Bug > Components: java - Refactoring >Affects Versions: 12.2 >Reporter: Carsten Hammer >Priority: Critical > > The pattern implemented in > [https://bz.apache.org/netbeans/show_bug.cgi?id=248740] seems to be wrong > according to > [https://docs.google.com/document/d/1mAeEgQu4H4ADxa03k7YaVDjIP5vJBvjVIjg3DIvoc8E/edit] > The right pattern looks like this: > # 334, Second code example. *_This is a serious error!_* The current code > can return null if multiple threads race to initialize the field. Here’s how > the code should look: > > {code:java} > // Double-check idiom for lazy initialization of instance fields > private volatile FieldType field; > > private FieldType getField() { > FieldType result = field; > if (result != null) // First check (no locking) > return result; > > synchronized(this){ > if (field == null) // Second check (with locking) > field = computeFieldValue(); > return field; > } > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4436) Format Code in HTML script block may fail when the type attribute value is "text/html"
[ https://issues.apache.org/jira/browse/NETBEANS-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280302#comment-17280302 ] Tomáš Procházka commented on NETBEANS-4436: --- Reproducible also in NetBeans 12.3 beta2. Ending {{}} should be indented by one more space and also whole content of {{}} too. Thank you for the report. > Format Code in HTML script block may fail when the type attribute value is > "text/html" > -- > > Key: NETBEANS-4436 > URL: https://issues.apache.org/jira/browse/NETBEANS-4436 > Project: NetBeans > Issue Type: Bug > Components: editor - Formatting & Indentation, web - HTML Editor >Affects Versions: 12.0, 11.3, 12.3 >Reporter: KoKo >Priority: Major > Attachments: image-2020-06-13-02-53-43-819.png > > > Take this HTML code below for example: > {code:java} >