[jira] [Commented] (NETBEANS-5481) Netbeans 12.3 refuses to start on macOS 10.13.6

2021-03-30 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311864#comment-17311864
 ] 

Eirik Bakke commented on NETBEANS-5481:
---

Given the description in https://support.apple.com/kb/dl1998, we might consider 
adding

{noformat}
LSMinimumSystemVersion
10.14.4
{noformat}

to Info.plist in the MacOS application bundle, to ensure that users get a 
user-friendly error message here. Though I wonder if the new Swift launcher 
bundle could just be compiled with an older version of XCode that is capable of 
linking in the libraries in question via "swift build 
-c--static-swift-stdlib"...

Though after https://github.com/apache/netbeans/pull/2717, the launcher binary 
becomes quite minimal. Perhaps it could just be rewritten in Objective C to 
avoid this problem...

> Netbeans 12.3 refuses to start on macOS 10.13.6
> ---
>
> Key: NETBEANS-5481
> URL: https://issues.apache.org/jira/browse/NETBEANS-5481
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 12.3
>Reporter: Malte Müller
>Assignee: Christian Oyarzun
>Priority: Blocker
> Attachments: report-installed.txt
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> After successful installation via the macOS installer, Netbeans 12.3 refuses 
> to start because of a problem. Nothing has been changed on the system 
> recently and Netbeans 12.2 works as always. Here is the report macOS 
> generates:
> Process: netbeans [4555]
> Path: /Applications/NetBeans/Apache NetBeans 12.3.app/Contents/MacOS/netbeans
> Identifier: org.netbeans.ide.nbide.12.3
> Version: 12.3 (12.3)
> Code Type: X86-64 (Native)
> Parent Process: ??? [1]
> Responsible: netbeans [4555]
> User ID: 501
> Date/Time: 2021-03-23 13:50:58.466 +0100
> OS Version: Mac OS X 10.13.6 (17G14042)
> Report Version: 12
> Anonymous UUID: FBFCE304-8AE4-5CEB-A2A5-E332E51F58CC
> Sleep/Wake UUID: 5468675E-19DD-4419-B58A-5BD3C96C0D7F
> Time Awake Since Boot: 19000 seconds
> Time Since Wake: 7100 seconds
> System Integrity Protection: enabled
> Crashed Thread: 0
> Exception Type: EXC_CRASH (SIGABRT)
> Exception Codes: 0x, 0x
> Exception Note: EXC_CORPSE_NOTIFY
> Termination Reason: DYLD, [0x1] Library missing
> Application Specific Information:
> dyld: launch, loading dependent libraries
> Dyld Error Message:
>  Library not loaded: @rpath/libswiftCore.dylib
>  Referenced from: /Applications/NetBeans/Apache NetBeans 
> 12.3.app/Contents/MacOS/netbeans
>  Reason: image not found
> Binary Images:
>  0x1084eb000 - 0x1084f1ff7 +org.netbeans.ide.nbide.12.3 (12.3 - 12.3) 
> <72C28A65-4256-3EB6-B4A3-56D8F679C709> /Applications/NetBeans/Apache NetBeans 
> 12.3.app/Contents/MacOS/netbeans
>  0x10edbf000 - 0x10ee09adf dyld (551.5) 
>  /usr/lib/dyld
>  0x7fff3ec2a000 - 0x7fff3eff1ffb com.apple.Foundation (6.9 - 1455.300) 
> <0479E072-1DD0-3881-A9A2-EDAD3EE58C23> 
> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
>  0x7fff627be000 - 0x7fff627bfffb libSystem.B.dylib (1252.50.4) 
> <5A02016C-8F9D-3F47-8C39-AD2CD4F9F11D> /usr/lib/libSystem.B.dylib
>  0x7fff63ef9000 - 0x7fff642ea3b7 libobjc.A.dylib (723) 
> <616AB826-9179-3924-AA61-AF760363A3F5> /usr/lib/libobjc.A.dylib
> Model: iMac12,1, BootROM 87.0.0.0.0, 4 processors, Intel Core i5, 2,5 GHz, 12 
> GB, SMC 1.71f22
> Graphics: AMD Radeon HD 6750M, AMD Radeon HD 6750M, PCIe
> Memory Module: BANK 0/DIMM0, 4 GB, DDR3, 1333 MHz, 0x0198, 
> 0x393930353432382D3035312E4130304C4620
> Memory Module: BANK 1/DIMM0, 4 GB, DDR3, 1333 MHz, 0x0198, 
> 0x393930353432382D3035312E4130304C4620
> Memory Module: BANK 0/DIMM1, 2 GB, DDR3, 1333 MHz, 0x80CE, 
> 0x4D34373142353737334448302D4348392020
> Memory Module: BANK 1/DIMM1, 2 GB, DDR3, 1333 MHz, 0x80CE, 
> 0x4D34373142353737334448302D4348392020
> AirPort: spairport_wireless_card_type_airport_extreme (0x168C, 0x9A), Atheros 
> 9380: 4.0.74.0-P2P
> Bluetooth: Version 6.0.7f22, 3 services, 27 devices, 1 incoming serial ports
> Network Service: Ethernet, Ethernet, en0
> Serial ATA Device: ST3500418AS, 500,11 GB
> Serial ATA Device: HL-DT-STDVDRW GA32N
> USB Device: USB 2.0 Bus
> USB Device: FaceTime HD Camera (Built-in)
> USB Device: Hub
> USB Device: USB 2.0 Hub
> USB Device: Elements 25A3
> USB Device: Ext HDD 1021
> USB Device: BRCM2046 Hub
> USB Device: Bluetooth USB Host Controller
> USB Device: USB 2.0 Bus
> USB Device: Hub
> USB Device: USB2.0 Hub
> USB Device: Wacom Intuos Pro M
> USB Device: Ext HDD 1021
> USB Device: IR Receiver
> USB Device: Internal Memory Card Reader
> Thunderbolt Bus: iMac, Apple Inc., 22.1



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, 

[jira] [Commented] (NETBEANS-5458) Upgrade Apache Batik to 1.14

2021-03-16 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302642#comment-17302642
 ] 

Eirik Bakke commented on NETBEANS-5458:
---

Feel free to bump the version; just make sure the SVG icons in the editor 
toolbar still render as before.

> Upgrade Apache Batik to 1.14
> 
>
> Key: NETBEANS-5458
> URL: https://issues.apache.org/jira/browse/NETBEANS-5458
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Reporter: Svatopluk Dedic
>Assignee: Svatopluk Dedic
>Priority: Major
> Fix For: 12.4
>
>
> Apache Batik 1.13 and 1.14 have some security fixes. Although (AFAIK) neither 
> of the reported vulnerabilities affect NetBeans, 1.12 is from 10/2019, so we 
> could eventually upgrade anyway.
>  
> // cc: [~ebakke]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1428) Fatal error when profiling

2020-12-01 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241870#comment-17241870
 ] 

Eirik Bakke commented on NETBEANS-1428:
---

[~lbruby] Those warnings can be disregarded; they are benign and unrelated to 
the profiler.

> Fatal error when profiling
> --
>
> Key: NETBEANS-1428
> URL: https://issues.apache.org/jira/browse/NETBEANS-1428
> Project: NetBeans
>  Issue Type: Bug
>  Components: profiler - Base
>Affects Versions: 9.0, 10.0, 11.0
> Environment: Windows 10, JDK11 (OpenJDK 11.0+28)
>Reporter: Peter Hull
>Priority: Major
>  Labels: netcat, pull-request-available
> Attachments: hs_err_pid2496.log, hs_err_pid38528.log
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Attempting to profile a Java freeform project (Netcat 10, Profiling FreeForm, 
> Step 2)
> I get the following error
> {{#}}
> {{# A fatal error has been detected by the Java Runtime Environment:}}
> {{#}}
> {{#  EXCEPTION_ACCESS_VIOLATION (0xc005) at pc=0x7ff8e831c775, 
> pid=38528, tid=38596}}
> {{#}}
> {{# JRE version: OpenJDK Runtime Environment (11.0+28) (build 11+28)}}
> {{# Java VM: OpenJDK 64-Bit Server VM (11+28, mixed mode, tiered, compressed 
> oops, g1 gc, windows-amd64)}}
> {{# Problematic frame:}}
> {{# V  [jvm.dll+0x5ec775]}}
> {{#}}
> {{# No core dump will be written. Minidumps are not enabled by default on 
> client versions of Windows}}
> {{#}}
> {{# An error report file with more information is saved as:}}
> {{# D:\Libraries\Downloads\TS_Profiler_freeform\freeform\hs_err_pid38528.log}}
> {{#}}
> {{# If you would like to submit a bug report, please visit:}}
> {{#   http://bugreport.java.com/bugreport/crash.jsp}}
> {{#}}
> Seems reproducible, I have attached the crash log.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1914) NetBeans fails to start after being moved to new directory

2020-11-29 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240405#comment-17240405
 ] 

Eirik Bakke commented on NETBEANS-1914:
---

The act of moving the NetBeans binaries to a new directory seems to break 
various links from the all-layers.dat file in the cache directory. Workaround 
is to delete the NetBeans cache directory.

> NetBeans fails to start after being moved to new directory
> --
>
> Key: NETBEANS-1914
> URL: https://issues.apache.org/jira/browse/NETBEANS-1914
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 10.0
> Environment: Windows 10 64-bit
>Reporter: Sven Thuri
>Assignee: Johan Persson
>Priority: Major
>
> So I don't know a lot about JIRA, bugs and all this stuff so bear with me.
> I just installed netbeans, extracted the zip folder first into my downloads 
> folder I believe and then moved the extracted netbeans folder to my desktop 
> for ease of access.
> When I started up the netbeans .exe file from bin folder it looked okay but I 
> noticed a notification to the right on the bottom bar. It said netbeans could 
> not find a specific jar that it was looking for, but it was looking for it in 
> the wrong place, the Downloads folder, which is not the current directory of 
> the netbeans folder and where I'm starting the program from. However it said 
> it was a silent error, or something like that so I didn't think much of it.
> So I tried just checking out the program and the first thing I do is pressing 
> the File button from the menubar at the top. The program then becomes 
> unresponsive so I ended the task in Task Manager. Then I tried starting the 
> program up again about 5 more times and it kept on happening, so now it tells 
> me I have found a bug and asks me to report it which is what I'm doing  :)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-1914) NetBeans fails to start after being moved to new directory

2020-11-29 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-1914:
--
Summary: NetBeans fails to start after being moved to new directory  (was: 
NetBeans bad startup)

> NetBeans fails to start after being moved to new directory
> --
>
> Key: NETBEANS-1914
> URL: https://issues.apache.org/jira/browse/NETBEANS-1914
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 10.0
> Environment: Windows 10 64-bit
>Reporter: Sven Thuri
>Assignee: Johan Persson
>Priority: Major
>
> So I don't know a lot about JIRA, bugs and all this stuff so bear with me.
> I just installed netbeans, extracted the zip folder first into my downloads 
> folder I believe and then moved the extracted netbeans folder to my desktop 
> for ease of access.
> When I started up the netbeans .exe file from bin folder it looked okay but I 
> noticed a notification to the right on the bottom bar. It said netbeans could 
> not find a specific jar that it was looking for, but it was looking for it in 
> the wrong place, the Downloads folder, which is not the current directory of 
> the netbeans folder and where I'm starting the program from. However it said 
> it was a silent error, or something like that so I didn't think much of it.
> So I tried just checking out the program and the first thing I do is pressing 
> the File button from the menubar at the top. The program then becomes 
> unresponsive so I ended the task in Task Manager. Then I tried starting the 
> program up again about 5 more times and it kept on happening, so now it tells 
> me I have found a bug and asks me to report it which is what I'm doing  :)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2360) HiDPI scaling not applied automatically on Linux

2020-11-18 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235014#comment-17235014
 ] 

Eirik Bakke commented on NETBEANS-2360:
---

As of the latest Ubuntu release, Ubuntu 20.04, the "Displays" control panel has 
a "Scale" factor option. I believe this sets a gnome property known as 
"Xft/DPI". Java does not seem to react to this property at the 
GraphicsConfiguration level, however; that should probably be reported as an 
OpenJDK bug/feature request. Meanwhile, GDK_SCALE works fine.

Nevertheless, the default LAF on Linux (GTK+) gets into trouble when Xft/DPI is 
set, because some UI elements end up being scaled and others don't.

What does work is to set GDK_SCALE and use FlatLAF. In that case, all the UI 
elements appear properly scaled, regardless of whether Xft/DPI is set in 
addition.

Perhaps FlatLAF should be made the default LAF on Linux, and the NetBeans 
startup script should set GDK_SCALE automatically based on the value of Xft/DPI.

> HiDPI scaling not applied automatically on Linux
> 
>
> Key: NETBEANS-2360
> URL: https://issues.apache.org/jira/browse/NETBEANS-2360
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - LaunchersCLI
>Affects Versions: 11.0
> Environment: Kubuntu 18.03
> Oracle JDK 11.0.2
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI, Linux
> Attachments: kubunt.jpg
>
>
> Running NetBeans 11 on Kubuntu 18.03, GUI text size does not seem to take 
> into account the system's default HiDPI scaling. This was reported in a 
> Twitter thread on https://twitter.com/nicktail/status/1114789604337405952 . 
> Note that Window decorations seem to be the correct size.
> Setting the GDK_SCALE environment variable seems to fix the problem, if I 
> understand the originally reporter correctly. This could probably be done 
> easily from the NetBeans launcher script (netbeans/bin). But it wouldn't fix 
> the problem in multi-monitor setups. We should investigate what could be done 
> to make scaling work properly in multi-monitor setups involving one HiDPI 
> screen and one non-HiDPI screen.
> Before merging a patch to the launcher script, it should be tested on a 
> couple of different Linux environments, using both HiDPI and non-HiDPI 
> screens. Note that the UNIX launcher script is also used on MacOS.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-2360) HiDPI scaling not applied automatically on Linux

2020-11-18 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235014#comment-17235014
 ] 

Eirik Bakke edited comment on NETBEANS-2360 at 11/18/20, 9:34 PM:
--

As of the latest Ubuntu release, Ubuntu 20.04, the "Displays" control panel has 
a "Scale" factor option. I believe this sets a gnome property known as 
"Xft/DPI". Java does not seem to react to this property at the 
GraphicsConfiguration level, however; that should probably be reported as an 
OpenJDK bug/feature request. Meanwhile, GDK_SCALE works fine for setting the 
scaling level at the GraphicsConfiguration transform level.

Note that the default LAF on Linux (GTK+) gets into trouble when Xft/DPI is 
set, because some UI elements end up being scaled and others don't.

What does work is to set GDK_SCALE and use FlatLAF. In that case, all the UI 
elements appear properly scaled, regardless of whether Xft/DPI is set in 
addition.

Perhaps FlatLAF should be made the default LAF on Linux, and the NetBeans 
startup script should set GDK_SCALE automatically based on the value of Xft/DPI.


was (Author: ebakke):
As of the latest Ubuntu release, Ubuntu 20.04, the "Displays" control panel has 
a "Scale" factor option. I believe this sets a gnome property known as 
"Xft/DPI". Java does not seem to react to this property at the 
GraphicsConfiguration level, however; that should probably be reported as an 
OpenJDK bug/feature request. Meanwhile, GDK_SCALE works fine for setting the 
scaling level at the GraphicsConfiguration transform level.

Nevertheless, the default LAF on Linux (GTK+) gets into trouble when Xft/DPI is 
set, because some UI elements end up being scaled and others don't.

What does work is to set GDK_SCALE and use FlatLAF. In that case, all the UI 
elements appear properly scaled, regardless of whether Xft/DPI is set in 
addition.

Perhaps FlatLAF should be made the default LAF on Linux, and the NetBeans 
startup script should set GDK_SCALE automatically based on the value of Xft/DPI.

> HiDPI scaling not applied automatically on Linux
> 
>
> Key: NETBEANS-2360
> URL: https://issues.apache.org/jira/browse/NETBEANS-2360
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - LaunchersCLI
>Affects Versions: 11.0
> Environment: Kubuntu 18.03
> Oracle JDK 11.0.2
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI, Linux
> Attachments: kubunt.jpg
>
>
> Running NetBeans 11 on Kubuntu 18.03, GUI text size does not seem to take 
> into account the system's default HiDPI scaling. This was reported in a 
> Twitter thread on https://twitter.com/nicktail/status/1114789604337405952 . 
> Note that Window decorations seem to be the correct size.
> Setting the GDK_SCALE environment variable seems to fix the problem, if I 
> understand the originally reporter correctly. This could probably be done 
> easily from the NetBeans launcher script (netbeans/bin). But it wouldn't fix 
> the problem in multi-monitor setups. We should investigate what could be done 
> to make scaling work properly in multi-monitor setups involving one HiDPI 
> screen and one non-HiDPI screen.
> Before merging a patch to the launcher script, it should be tested on a 
> couple of different Linux environments, using both HiDPI and non-HiDPI 
> screens. Note that the UNIX launcher script is also used on MacOS.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-2360) HiDPI scaling not applied automatically on Linux

2020-11-18 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235014#comment-17235014
 ] 

Eirik Bakke edited comment on NETBEANS-2360 at 11/18/20, 9:34 PM:
--

As of the latest Ubuntu release, Ubuntu 20.04, the "Displays" control panel has 
a "Scale" factor option. I believe this sets a gnome property known as 
"Xft/DPI". Java does not seem to react to this property at the 
GraphicsConfiguration level, however; that should probably be reported as an 
OpenJDK bug/feature request. Meanwhile, GDK_SCALE works fine for setting the 
scaling level at the GraphicsConfiguration transform level.

Nevertheless, the default LAF on Linux (GTK+) gets into trouble when Xft/DPI is 
set, because some UI elements end up being scaled and others don't.

What does work is to set GDK_SCALE and use FlatLAF. In that case, all the UI 
elements appear properly scaled, regardless of whether Xft/DPI is set in 
addition.

Perhaps FlatLAF should be made the default LAF on Linux, and the NetBeans 
startup script should set GDK_SCALE automatically based on the value of Xft/DPI.


was (Author: ebakke):
As of the latest Ubuntu release, Ubuntu 20.04, the "Displays" control panel has 
a "Scale" factor option. I believe this sets a gnome property known as 
"Xft/DPI". Java does not seem to react to this property at the 
GraphicsConfiguration level, however; that should probably be reported as an 
OpenJDK bug/feature request. Meanwhile, GDK_SCALE works fine.

Nevertheless, the default LAF on Linux (GTK+) gets into trouble when Xft/DPI is 
set, because some UI elements end up being scaled and others don't.

What does work is to set GDK_SCALE and use FlatLAF. In that case, all the UI 
elements appear properly scaled, regardless of whether Xft/DPI is set in 
addition.

Perhaps FlatLAF should be made the default LAF on Linux, and the NetBeans 
startup script should set GDK_SCALE automatically based on the value of Xft/DPI.

> HiDPI scaling not applied automatically on Linux
> 
>
> Key: NETBEANS-2360
> URL: https://issues.apache.org/jira/browse/NETBEANS-2360
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - LaunchersCLI
>Affects Versions: 11.0
> Environment: Kubuntu 18.03
> Oracle JDK 11.0.2
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI, Linux
> Attachments: kubunt.jpg
>
>
> Running NetBeans 11 on Kubuntu 18.03, GUI text size does not seem to take 
> into account the system's default HiDPI scaling. This was reported in a 
> Twitter thread on https://twitter.com/nicktail/status/1114789604337405952 . 
> Note that Window decorations seem to be the correct size.
> Setting the GDK_SCALE environment variable seems to fix the problem, if I 
> understand the originally reporter correctly. This could probably be done 
> easily from the NetBeans launcher script (netbeans/bin). But it wouldn't fix 
> the problem in multi-monitor setups. We should investigate what could be done 
> to make scaling work properly in multi-monitor setups involving one HiDPI 
> screen and one non-HiDPI screen.
> Before merging a patch to the launcher script, it should be tested on a 
> couple of different Linux environments, using both HiDPI and non-HiDPI 
> screens. Note that the UNIX launcher script is also used on MacOS.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4092) package.json icon is to big

2020-11-16 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232837#comment-17232837
 ] 

Eirik Bakke commented on NETBEANS-4092:
---

The SVG loading support was added later, so now, when ImageLoader is asked to 
load "someicon.png", it looks for "someicon.svg" first, and loads the SVG 
instead if available. I thought I went through all the SVG files to verify 
their sizes matches their corresponding PNG files, but I think I got this one 
wrong.

> package.json icon is to big
> ---
>
> Key: NETBEANS-4092
> URL: https://issues.apache.org/jira/browse/NETBEANS-4092
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Generic Projects UI
>Affects Versions: 11.2, 11.3
> Environment: Product Version: Apache NetBeans IDE 11.3
> Java: 9.0.4; Java HotSpot(TM) 64-Bit Server VM 9.0.4+11
> Runtime: Java(TM) SE Runtime Environment 9.0.4+11
> System: Windows 10 version 10.0 running on amd64; Cp1252; de_DE (nb)
> User directory: C:\Projekte\Netbeans Plugins\MinifierBeans\build\testuserdir
> Cache directory: C:\Projekte\Netbeans 
> Plugins\MinifierBeans\build\testuserdir\var\cache
>Reporter: Christian Lenz
>Priority: Major
> Attachments: image-2020-03-31-14-40-41-931.png, 
> image-2020-03-31-14-41-47-408.png
>
>
> In my current IDE 11.1 there is no problem with the npm icon for the 
> package.json file. You can see it in this my attached file  
> image-2020-03-31-14-43-07-177.png. it is 16x16 px small. When I use 11.3 the 
> icon is bigger see image-2020-03-31-14-40-41-931. I also tested ith with 11.2 
> and there is the same problem. So smth changed from 11.1 to 11.2 with icons 
> or HiDPI maybe?
> Steps to reprocuce:
> * open a project with a package.json file
> * open the tree nodes in the project view to see the package.json file
> * Icon is to big.
> Both IDEs are running on JDK 9.0.4, same PC (Surface Book 1 with HiDPI 
> resolution)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4092) package.json icon is to big

2020-11-13 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231912#comment-17231912
 ] 

Eirik Bakke commented on NETBEANS-4092:
---

Should be trivial to fix... just change

width="24" height="24"

to

width="16" height="16"

in 
webcommon/javascript.nodejs/src/org/netbeans/modules/javascript/nodejs/ui/resources/npm.svg

to have the size match the corresponding PNG file.

> package.json icon is to big
> ---
>
> Key: NETBEANS-4092
> URL: https://issues.apache.org/jira/browse/NETBEANS-4092
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Generic Projects UI
>Affects Versions: 11.2, 11.3
> Environment: Product Version: Apache NetBeans IDE 11.3
> Java: 9.0.4; Java HotSpot(TM) 64-Bit Server VM 9.0.4+11
> Runtime: Java(TM) SE Runtime Environment 9.0.4+11
> System: Windows 10 version 10.0 running on amd64; Cp1252; de_DE (nb)
> User directory: C:\Projekte\Netbeans Plugins\MinifierBeans\build\testuserdir
> Cache directory: C:\Projekte\Netbeans 
> Plugins\MinifierBeans\build\testuserdir\var\cache
>Reporter: Christian Lenz
>Priority: Major
> Attachments: image-2020-03-31-14-40-41-931.png, 
> image-2020-03-31-14-41-47-408.png
>
>
> In my current IDE 11.1 there is no problem with the npm icon for the 
> package.json file. You can see it in this my attached file  
> image-2020-03-31-14-43-07-177.png. it is 16x16 px small. When I use 11.3 the 
> icon is bigger see image-2020-03-31-14-40-41-931. I also tested ith with 11.2 
> and there is the same problem. So smth changed from 11.1 to 11.2 with icons 
> or HiDPI maybe?
> Steps to reprocuce:
> * open a project with a package.json file
> * open the tree nodes in the project view to see the package.json file
> * Icon is to big.
> Both IDEs are running on JDK 9.0.4, same PC (Surface Book 1 with HiDPI 
> resolution)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-453) "Incorrect number of type arguments" exception during Java editing

2020-11-01 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224340#comment-17224340
 ] 

Eirik Bakke commented on NETBEANS-453:
--

Haven't seen this one in a while. Fine to close.

> "Incorrect number of type arguments" exception during Java editing
> --
>
> Key: NETBEANS-453
> URL: https://issues.apache.org/jira/browse/NETBEANS-453
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Hints
>Affects Versions: 9.0
> Environment: Apache NetBeans IDE Dev (Build 
> incubator-netbeans-release-205-on-20180202) on OpenJDK 64-Bit Server VM 
> 9.0.4.1+11, Mac OS X version 10.9.5 running on x86_64; UTF-8; en_US (nb)
>Reporter: Eirik Bakke
>Priority: Major
>
> I got the following Exception while editing a Java file in NetBeans 9.0 Beta:
> {noformat}
> java.lang.IllegalArgumentException: Incorrect number of type arguments
>  at com.sun.tools.javac.model.JavacTypes.getDeclaredType0(JavacTypes.java:270)
>  at com.sun.tools.javac.model.JavacTypes.getDeclaredType(JavacTypes.java:245)
>  at 
> org.netbeans.modules.java.hints.errors.Utilities.resolveCapturedTypeInt(Utilities.java:619)
>  at 
> org.netbeans.modules.java.hints.errors.Utilities.resolveCapturedType(Utilities.java:538)
>  at 
> org.netbeans.modules.java.hints.errors.Utilities.resolveTypeForDeclaration(Utilities.java:519)
>  at 
> org.netbeans.modules.java.hints.errors.AddCast.computeType(AddCast.java:193)
>  at org.netbeans.modules.java.hints.errors.AddCast.run(AddCast.java:222)
>  at 
> org.netbeans.modules.java.hints.infrastructure.CreatorBasedLazyFixList.compute(CreatorBasedLazyFixList.java:123)
>  at 
> org.netbeans.modules.java.hints.infrastructure.LazyHintComputation.run(LazyHintComputation.java:87)
>  at 
> org.netbeans.modules.java.hints.infrastructure.LazyHintComputation.run(LazyHintComputation.java:33)
>  [catch] at 
> org.netbeans.modules.java.source.JavaSourceAccessor$CancelableTaskWrapper.run(JavaSourceAccessor.java:273)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor.callParserResultTask(TaskProcessor.java:561)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.run(TaskProcessor.java:786)
>  at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.execute(TaskProcessor.java:702)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor$CompilationJob.run(TaskProcessor.java:663)
>  at 
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:514)
>  at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>  at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
>  at 
> org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
>  at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
>  at 
> org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033){noformat}
> Reporting this as a new JIRA issue since the old NetBeans exception reporter 
> no longer seems to be in use.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4960) Parser error when indexing javax.swing.JComponent

2020-10-27 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4960:
--
Description: 
On NetBeans 12.1 running on OpenJDK 15.0.1, I opened the platform/o.n.core 
project from the NetBeans sources, and got the following exception:

{noformat}
Annotation: An error occurred during parsing of 
'java.desktop/javax/swing/JComponent.java in C:\Program 
Files\Java\zulu15.28.13-ca-jdk15.0.1\lib\src.zip'. Please report a bug against 
java/source and attach dump file 
'C:\Users\ebakke\AppData\Roaming\NetBeans\dev\var\log\JComponent_1.dump'.
Annotation: An error occurred during parsing of 
'java.desktop/javax/swing/JComponent.java in C:\Program 
Files\Java\zulu15.28.13-ca-jdk15.0.1\lib\src.zip'. Please report a bug against 
java/source and attach dump file 
'C:\Users\ebakke\AppData\Roaming\NetBeans\dev\var\log\JComponent_1.dump'.
An error occurred during parsing of 'java.desktop/javax/swing/JComponent.java 
in C:\Program Files\Java\zulu15.28.13-ca-jdk15.0.1\lib\src.zip'. Please report 
a bug against java/source and attach dump file 
'C:\Users\ebakke\AppData\Roaming\NetBeans\dev\var\log\JComponent_1.dump'.
An error occurred during parsing of 'java.desktop/javax/swing/JComponent.java 
in C:\Program Files\Java\zulu15.28.13-ca-jdk15.0.1\lib\src.zip'. Please report 
a bug against java/source and attach dump file 
'C:\Users\ebakke\AppData\Roaming\NetBeans\dev\var\log\JComponent_1.dump'.
Caused: com.sun.tools.javac.code.Symbol$CompletionFailure: class file for 
java.lang.annotation.Annotation not found
at 
com.sun.tools.javac.code.ClassFinder.newCompletionFailure(ClassFinder.java:432)
at 
com.sun.tools.javac.code.ClassFinder.classFileNotFound(ClassFinder.java:419)
at com.sun.tools.javac.code.ClassFinder.fillIn(ClassFinder.java:414)
at com.sun.tools.javac.code.ClassFinder.complete(ClassFinder.java:301)
at com.sun.tools.javac.code.Symbol.complete(Symbol.java:673)
at 
com.sun.tools.javac.code.Symbol$ClassSymbol.complete(Symbol.java:1409)
at com.sun.tools.javac.code.Symbol.apiComplete(Symbol.java:679)
at 
com.sun.tools.javac.code.Symbol$ClassSymbol.getSuperclass(Symbol.java:1436)
at com.sun.tools.javac.code.Types$15.visitClassType(Types.java:2483)
at com.sun.tools.javac.code.Types$15.visitClassType(Types.java:2472)
at com.sun.tools.javac.code.Type$ClassType.accept(Type.java:1011)
at com.sun.tools.javac.code.Types$UnaryVisitor.visit(Types.java:4948)
at com.sun.tools.javac.code.Types.supertype(Types.java:2469)
at com.sun.tools.javac.code.Types$12.visitClassType(Types.java:2132)
at com.sun.tools.javac.code.Types$12.visitClassType(Types.java:2121)
at com.sun.tools.javac.code.Type$ClassType.accept(Type.java:1011)
at 
com.sun.tools.javac.code.Types$DefaultTypeVisitor.visit(Types.java:4868)
at com.sun.tools.javac.code.Types.asSuper(Types.java:2118)
at com.sun.tools.javac.code.Types$12.visitClassType(Types.java:2146)
at com.sun.tools.javac.code.Types$12.visitClassType(Types.java:2121)
at com.sun.tools.javac.code.Type$ClassType.accept(Type.java:1011)
at 
com.sun.tools.javac.code.Types$DefaultTypeVisitor.visit(Types.java:4868)
at com.sun.tools.javac.code.Types.asSuper(Types.java:2118)
at com.sun.tools.javac.code.Types$4.visitClassType(Types.java:1182)
at com.sun.tools.javac.code.Types$4.visitClassType(Types.java:1102)
at com.sun.tools.javac.code.Type$ClassType.accept(Type.java:1011)
at 
com.sun.tools.javac.code.Types$DefaultTypeVisitor.visit(Types.java:4868)
at com.sun.tools.javac.code.Types.isSubtype(Types.java:1098)
at 
com.sun.tools.javac.code.Types.isSubtypeUncheckedInternal(Types.java:1024)
at com.sun.tools.javac.code.Types.isSubtypeUnchecked(Types.java:1010)
at com.sun.tools.javac.code.Types.isConvertible(Types.java:608)
at com.sun.tools.javac.code.Types.isAssignable(Types.java:2326)
at com.sun.tools.javac.comp.Check$1.compatible(Check.java:566)
at com.sun.tools.javac.comp.Check.checkType(Check.java:607)
at com.sun.tools.javac.comp.Check.checkType(Check.java:594)
at 
com.sun.tools.javac.comp.Annotate.attributeAnnotationValues(Annotate.java:476)
at 
com.sun.tools.javac.comp.Annotate.attributeAnnotation(Annotate.java:432)
at com.sun.tools.javac.comp.Annotate.annotateNow(Annotate.java:341)
at 
com.sun.tools.javac.comp.Annotate.lambda$annotateLater$0(Annotate.java:267)
at com.sun.tools.javac.comp.Annotate.flush(Annotate.java:191)
at 
com.sun.tools.javac.comp.Annotate.unblockAnnotations(Annotate.java:144)
at com.sun.tools.javac.comp.Annotate.enterDone(Annotate.java:157)
at 
com.sun.tools.javac.main.JavaCompiler.enterDone(JavaCompiler.java:1868)
at 

[jira] [Created] (NETBEANS-4960) Parser error when indexing javax.swing.JComponent

2020-10-27 Thread Eirik Bakke (Jira)
Eirik Bakke created NETBEANS-4960:
-

 Summary: Parser error when indexing javax.swing.JComponent
 Key: NETBEANS-4960
 URL: https://issues.apache.org/jira/browse/NETBEANS-4960
 Project: NetBeans
  Issue Type: Improvement
  Components: java - Compiler
Affects Versions: 12.1
 Environment: NetBeans 12.1 (private build) running on 15.0.1
Reporter: Eirik Bakke
 Attachments: JComponent_1.dump

On NetBeans 12.1 running on OpenJDK 15.0.1, I opened the platform/o.n.core 
project from the NetBeans sources, and got the following exception:

{noformat}
Annotation: An error occurred during parsing of 
'java.desktop/javax/swing/JComponent.java in C:\Program 
Files\Java\zulu15.28.13-ca-jdk15.0.1\lib\src.zip'. Please report a bug against 
java/source and attach dump file 
'C:\Users\ebakke\AppData\Roaming\NetBeans\dev\var\log\JComponent_1.dump'.
Annotation: An error occurred during parsing of 
'java.desktop/javax/swing/JComponent.java in C:\Program 
Files\Java\zulu15.28.13-ca-jdk15.0.1\lib\src.zip'. Please report a bug against 
java/source and attach dump file 
'C:\Users\ebakke\AppData\Roaming\NetBeans\dev\var\log\JComponent_1.dump'.
An error occurred during parsing of 'java.desktop/javax/swing/JComponent.java 
in C:\Program Files\Java\zulu15.28.13-ca-jdk15.0.1\lib\src.zip'. Please report 
a bug against java/source and attach dump file 
'C:\Users\ebakke\AppData\Roaming\NetBeans\dev\var\log\JComponent_1.dump'.
An error occurred during parsing of 'java.desktop/javax/swing/JComponent.java 
in C:\Program Files\Java\zulu15.28.13-ca-jdk15.0.1\lib\src.zip'. Please report 
a bug against java/source and attach dump file 
'C:\Users\ebakke\AppData\Roaming\NetBeans\dev\var\log\JComponent_1.dump'.
Caused: com.sun.tools.javac.code.Symbol$CompletionFailure: class file for 
java.lang.annotation.Annotation not found
at 
com.sun.tools.javac.code.ClassFinder.newCompletionFailure(ClassFinder.java:432)
at 
com.sun.tools.javac.code.ClassFinder.classFileNotFound(ClassFinder.java:419)
at com.sun.tools.javac.code.ClassFinder.fillIn(ClassFinder.java:414)
at com.sun.tools.javac.code.ClassFinder.complete(ClassFinder.java:301)
at com.sun.tools.javac.code.Symbol.complete(Symbol.java:673)
at 
com.sun.tools.javac.code.Symbol$ClassSymbol.complete(Symbol.java:1409)
at com.sun.tools.javac.code.Symbol.apiComplete(Symbol.java:679)
at 
com.sun.tools.javac.code.Symbol$ClassSymbol.getSuperclass(Symbol.java:1436)
at com.sun.tools.javac.code.Types$15.visitClassType(Types.java:2483)
at com.sun.tools.javac.code.Types$15.visitClassType(Types.java:2472)
at com.sun.tools.javac.code.Type$ClassType.accept(Type.java:1011)
at com.sun.tools.javac.code.Types$UnaryVisitor.visit(Types.java:4948)
at com.sun.tools.javac.code.Types.supertype(Types.java:2469)
at com.sun.tools.javac.code.Types$12.visitClassType(Types.java:2132)
at com.sun.tools.javac.code.Types$12.visitClassType(Types.java:2121)
at com.sun.tools.javac.code.Type$ClassType.accept(Type.java:1011)
at 
com.sun.tools.javac.code.Types$DefaultTypeVisitor.visit(Types.java:4868)
at com.sun.tools.javac.code.Types.asSuper(Types.java:2118)
at com.sun.tools.javac.code.Types$12.visitClassType(Types.java:2146)
at com.sun.tools.javac.code.Types$12.visitClassType(Types.java:2121)
at com.sun.tools.javac.code.Type$ClassType.accept(Type.java:1011)
at 
com.sun.tools.javac.code.Types$DefaultTypeVisitor.visit(Types.java:4868)
at com.sun.tools.javac.code.Types.asSuper(Types.java:2118)
at com.sun.tools.javac.code.Types$4.visitClassType(Types.java:1182)
at com.sun.tools.javac.code.Types$4.visitClassType(Types.java:1102)
at com.sun.tools.javac.code.Type$ClassType.accept(Type.java:1011)
at 
com.sun.tools.javac.code.Types$DefaultTypeVisitor.visit(Types.java:4868)
at com.sun.tools.javac.code.Types.isSubtype(Types.java:1098)
at 
com.sun.tools.javac.code.Types.isSubtypeUncheckedInternal(Types.java:1024)
at com.sun.tools.javac.code.Types.isSubtypeUnchecked(Types.java:1010)
at com.sun.tools.javac.code.Types.isConvertible(Types.java:608)
at com.sun.tools.javac.code.Types.isAssignable(Types.java:2326)
at com.sun.tools.javac.comp.Check$1.compatible(Check.java:566)
at com.sun.tools.javac.comp.Check.checkType(Check.java:607)
at com.sun.tools.javac.comp.Check.checkType(Check.java:594)
at 
com.sun.tools.javac.comp.Annotate.attributeAnnotationValues(Annotate.java:476)
at 
com.sun.tools.javac.comp.Annotate.attributeAnnotation(Annotate.java:432)
at com.sun.tools.javac.comp.Annotate.annotateNow(Annotate.java:341)
at 
com.sun.tools.javac.comp.Annotate.lambda$annotateLater$0(Annotate.java:267)
at 

[jira] [Comment Edited] (NETBEANS-430) "Invalid or deleted file", "Absent Code attribute" exceptions during Java editing and app/test running

2020-10-26 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220983#comment-17220983
 ] 

Eirik Bakke edited comment on NETBEANS-430 at 10/26/20, 8:39 PM:
-

Still encountered this error on NetBeans 12.1 with the IDE running on Java 
15.0.1 and a maven-based multi-module NetBeans Platform project compiling and 
running on JDK 11.0.9, with nbjavac installed and Compile-on-Save enabled.

{noformat}
java.lang.ClassFormatError: Absent Code attribute in method that is not native 
or abstract in class file com/ultorg/datamodel/proptypes/ViewPropertyTypes$2
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
at org.netbeans.JarClassLoader.doLoadClass(JarClassLoader.java:287)
at 
org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:246)
at org.netbeans.ProxyClassLoader.doFindClass(ProxyClassLoader.java:174)
at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:125)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
at com.ultorg.datamodel.view.CProp.(CProp.java:45)
at com.ultorg.datamodel.query.Queries.(Queries.java:69)
at 
com.ultorg.project.result.ViewResultProvider.(ViewResultProvider.java:93)
at 
com.ultorg.project.installer.Installer.performWarmupTasks(Installer.java:139)
at 
com.ultorg.project.installer.Installer.lambda$restored$3(Installer.java:121)
at 
org.netbeans.modules.openide.util.NbMutexEventProvider$Event$1AWTWorker.run(NbMutexEventProvider.java:133)
at 
java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:303)
at 
java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at 
java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740)
at 
java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at 
java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at 
java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at 
java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at 
java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
[catch] at 
java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

{noformat}

This exception occurred after the following sequence of actions
1) Clean build of entire multi-module project.
2) Run application; no error. Exit application.
3) Edit a single Java file in the project. This triggers Compile-on-Save. The 
edited file was _not_ the class mentioned in the exception above 
(ViewPropertyTypes). In fact, the edited file was in a different module.
4) Run the application again.
5) The exception above occurs.



was (Author: ebakke):
Still encountered this error on NetBeans 12.1 with the IDE running on Java 
15.0.1 and a maven-based multi-module NetBeans Platform project compiling and 
running on JDK 11.0.9, with nbjavac installed and Compile-on-Save enabled.

{noformat}
java.lang.ClassFormatError: Absent Code attribute in method that is not native 
or abstract in class file com/ultorg/datamodel/proptypes/ViewPropertyTypes$2
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
at org.netbeans.JarClassLoader.doLoadClass(JarClassLoader.java:287)
at 
org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:246)
at org.netbeans.ProxyClassLoader.doFindClass(ProxyClassLoader.java:174)
at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:125)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
at com.ultorg.datamodel.view.CProp.(CProp.java:45)
at com.ultorg.datamodel.query.Queries.(Queries.java:69)
at 
com.ultorg.project.result.ViewResultProvider.(ViewResultProvider.java:93)
at 
com.ultorg.project.installer.Installer.performWarmupTasks(Installer.java:139)
at 
com.ultorg.project.installer.Installer.lambda$restored$3(Installer.java:121)
at 
org.netbeans.modules.openide.util.NbMutexEventProvider$Event$1AWTWorker.run(NbMutexEventProvider.java:133)
at 
java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:303)
at 

[jira] [Comment Edited] (NETBEANS-430) "Invalid or deleted file", "Absent Code attribute" exceptions during Java editing and app/test running

2020-10-26 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220983#comment-17220983
 ] 

Eirik Bakke edited comment on NETBEANS-430 at 10/26/20, 8:36 PM:
-

Still encountered this error on NetBeans 12.1 with the IDE running on Java 
15.0.1 and a maven-based multi-module NetBeans Platform project compiling and 
running on JDK 11.0.9, with nbjavac installed and Compile-on-Save enabled.

{noformat}
java.lang.ClassFormatError: Absent Code attribute in method that is not native 
or abstract in class file com/ultorg/datamodel/proptypes/ViewPropertyTypes$2
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
at org.netbeans.JarClassLoader.doLoadClass(JarClassLoader.java:287)
at 
org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:246)
at org.netbeans.ProxyClassLoader.doFindClass(ProxyClassLoader.java:174)
at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:125)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
at com.ultorg.datamodel.view.CProp.(CProp.java:45)
at com.ultorg.datamodel.query.Queries.(Queries.java:69)
at 
com.ultorg.project.result.ViewResultProvider.(ViewResultProvider.java:93)
at 
com.ultorg.project.installer.Installer.performWarmupTasks(Installer.java:139)
at 
com.ultorg.project.installer.Installer.lambda$restored$3(Installer.java:121)
at 
org.netbeans.modules.openide.util.NbMutexEventProvider$Event$1AWTWorker.run(NbMutexEventProvider.java:133)
at 
java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:303)
at 
java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at 
java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740)
at 
java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at 
java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at 
java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at 
java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at 
java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
[catch] at 
java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

{noformat}

This exception occurred after a clean build of the entire project was made, and 
a single Java file (not the class mentioned in the exception) was changed, 
triggering CoS, and the application run.



was (Author: ebakke):
Still encountered this error on NetBeans 12.1 with the IDE running on Java 
15.0.1 and a maven-based multi-module NetBeans Platform project compiling and 
running on JDK 11.0.9, with nbjavac installed and Compile-on-Save enabled.

{noformat}
java.lang.ClassFormatError: Absent Code attribute in method that is not native 
or abstract in class file com/ultorg/datamodel/proptypes/ViewPropertyTypes$2
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
at org.netbeans.JarClassLoader.doLoadClass(JarClassLoader.java:287)
at 
org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:246)
at org.netbeans.ProxyClassLoader.doFindClass(ProxyClassLoader.java:174)
at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:125)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
at com.ultorg.datamodel.view.CProp.(CProp.java:45)
at com.ultorg.datamodel.query.Queries.(Queries.java:69)
at 
com.ultorg.project.result.ViewResultProvider.(ViewResultProvider.java:93)
at 
com.ultorg.project.installer.Installer.performWarmupTasks(Installer.java:139)
at 
com.ultorg.project.installer.Installer.lambda$restored$3(Installer.java:121)
at 
org.netbeans.modules.openide.util.NbMutexEventProvider$Event$1AWTWorker.run(NbMutexEventProvider.java:133)
at 
java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:303)
at 
java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
at 

[jira] [Commented] (NETBEANS-430) "Invalid or deleted file", "Absent Code attribute" exceptions during Java editing and app/test running

2020-10-26 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220983#comment-17220983
 ] 

Eirik Bakke commented on NETBEANS-430:
--

Still encountered this error on NetBeans 12.1 with the IDE running on Java 
15.0.1 and a maven-based multi-module NetBeans Platform project compiling and 
running on JDK 11.0.9, with nbjavac installed and Compile-on-Save enabled.

{noformat}
java.lang.ClassFormatError: Absent Code attribute in method that is not native 
or abstract in class file com/ultorg/datamodel/proptypes/ViewPropertyTypes$2
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
at org.netbeans.JarClassLoader.doLoadClass(JarClassLoader.java:287)
at 
org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:246)
at org.netbeans.ProxyClassLoader.doFindClass(ProxyClassLoader.java:174)
at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:125)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
at com.ultorg.datamodel.view.CProp.(CProp.java:45)
at com.ultorg.datamodel.query.Queries.(Queries.java:69)
at 
com.ultorg.project.result.ViewResultProvider.(ViewResultProvider.java:93)
at 
com.ultorg.project.installer.Installer.performWarmupTasks(Installer.java:139)
at 
com.ultorg.project.installer.Installer.lambda$restored$3(Installer.java:121)
at 
org.netbeans.modules.openide.util.NbMutexEventProvider$Event$1AWTWorker.run(NbMutexEventProvider.java:133)
at 
java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:303)
at 
java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at 
java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740)
at 
java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at 
java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at 
java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at 
java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at 
java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
[catch] at 
java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

{noformat}


> "Invalid or deleted file", "Absent Code attribute" exceptions during Java 
> editing and app/test running
> --
>
> Key: NETBEANS-430
> URL: https://issues.apache.org/jira/browse/NETBEANS-430
> Project: NetBeans
>  Issue Type: Bug
>  Components: guibuilder - Code, java - Classfile, java - Source, 
> projects - Maven
>Affects Versions: 9.0
> Environment: Apache NetBeans IDE Dev (Build 
> incubator-netbeans-release-205-on-20180202), OpenJDK 64-Bit Server VM 
> 9.0.4.1+11, Mac OS X version 10.9.5
>Reporter: Eirik Bakke
>Priority: Major
> Attachments: Class Files causing Trouble.zip, parseerror.txt
>
>
> While editing Java sources in a maven-based multi-module NetBeans Platform 
> application on NetBeans 9.0 beta, the following IDE exception happens at 
> irregular intervals, while editing unrelated files in a different module:
> {noformat}
> ALL [null]: An error occurred during parsing of 
> '/var/folders/38/g_r_gdts0wx49_kbz5sjfj30gn/T/vcs-1518825448194/vcs-1519673427266/FilterPanel.java'.
>  Please report a bug against java/source and attach dump file 
> '/Users/ebakke/Library/Application 
> Support/NetBeans/dev/var/log/FilterPanel_8.dump'.
> {noformat}
> See the attached text file for the complete log dump and stack trace (can't 
> attach the ".dump" file as it contains source code). The source file in 
> question, FilterPanel.java, is generated in part by the Matisse GUI builder 
> (so there's also a FilterPanel.form file). I've also got maven 
> Compile-on-Save enabled.
> At other times, occasionally when running the same NetBeans Platform-based 
> application, the application itself throws the following exception, 
> mentioning the same file:
> {noformat}
> java.lang.ClassFormatError: Absent Code attribute in method that is not 
> native or abstract in class file com/somepackage/project/filter/FilterPanel$2
> {noformat}
> See again the attached text file 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-10-09 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute icons, that's 
fine; just make sure to follow the same consistent style as the other icons. If 
using Inkscape, perhaps pick another group of icons than the ones that are 
currently being drawn in Illustrator. It's best to draw all similar-looking 
icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in a 
separate layer ("Old Bitmap Icons" in the Illustrator template). You can then 
draw the vectorized version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* Some of the old bitmap icons use grays with a slightly blue tint (e.g. the 
[file 
icons|https://raw.githubusercontent.com/apache/netbeans/master/java/refactoring.java/src/org/netbeans/modules/refactoring/java/resources/newFile.png]).
 This style is out of fashion (resembling 1990s Solaris GUIs etc.); use neutral 
greys instead.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-10-09 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute icons, that's 
fine; just make sure to follow the same consistent style as the other icons. If 
using Inkscape, perhaps pick another group of icons than the ones that are 
currently being drawn in Illustrator. It's best to draw all similar-looking 
icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in a 
separate layer ("Old Bitmap Icons" in the Illustrator template). You can then 
draw the vectorized version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* Some of the old bitmap icons use grays with a slightly blue tint (e.g. the 
[file 
icons|java/refactoring.java/src/org/netbeans/modules/refactoring/java/resources/newFile.pngccc]).
 This style is out of fashion (resembling 1990s Solaris GUIs etc.); use neutral 
greys instead.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-10-09 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute icons, that's 
fine; just make sure to follow the same consistent style as the other icons. If 
using Inkscape, perhaps pick another group of icons than the ones that are 
currently being drawn in Illustrator. It's best to draw all similar-looking 
icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in a 
separate layer ("Old Bitmap Icons" in the Illustrator template). You can then 
draw the vectorized version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* Some of the old bitmap icons use grays with a slightly blue tint (e.g. the 
[file 
icons|https://raw.githubusercontent.com/apache/netbeans/master/java/refactoring.java/src/org/netbeans/modules/refactoring/java/resources/newFile.pngccc]).
 This style is out of fashion (resembling 1990s Solaris GUIs etc.); use neutral 
greys instead.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes 

[jira] [Commented] (NETBEANS-2617) Redraw common icons in SVG

2020-10-09 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211150#comment-17211150
 ] 

Eirik Bakke commented on NETBEANS-2617:
---

With the first batch of icons now merged, here's a list of the next ones which 
would be good to get drawn (in case anyone wants to volunteer):

ide/editor/src/org/netbeans/modules/editor/resources/comment.png
ide/editor/src/org/netbeans/modules/editor/resources/last_edit_location_16.png
ide/editor/src/org/netbeans/modules/editor/resources/navigate_back_16.png
ide/editor/src/org/netbeans/modules/editor/resources/navigate_forward_16.png
ide/editor/src/org/netbeans/modules/editor/resources/rect_select_16x16.png
ide/editor/src/org/netbeans/modules/editor/resources/shift_line_left.png
ide/editor/src/org/netbeans/modules/editor/resources/shift_line_right.png
ide/editor/src/org/netbeans/modules/editor/resources/uncomment.png
ide/bugtracking/src/org/netbeans/modules/bugtracking/ui/resources/find_next.png
ide/bugtracking/src/org/netbeans/modules/bugtracking/ui/resources/find_previous.png
ide/editor.search/src/org/netbeans/modules/editor/search/resources/find_selection.png
ide/editor.search/src/org/netbeans/modules/editor/search/resources/toggle_highlight.png

This would cover all of the editor toolbar.

> Redraw common icons in SVG
> --
>
> Key: NETBEANS-2617
> URL: https://issues.apache.org/jira/browse/NETBEANS-2617
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
> Environment: Windows, Linux, and MacOS
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: ScreenshotExample.png, ide.editor.bookmarks.ai, 
> ide.editor.macros.ai, ide.seperator.breadcrumbs.ai, 
> netbeans_icons_illustrator_template.ai, style example (dark filter).png, 
> style example.png
>
>
> Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
> icons with SVG versions, for improved appearance on Retina/HiDPI displays.
> h2. UPDATE: 
> [Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
>  is a Google Sheet where we can track progress of contributions and 
> prioritization of icons.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration and 
> Illustrator template. The Illustrator template includes a few icons which 
> have already been converted.
> In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
> migrated to the Google Sheet above). By redrawing the most commonly seen 
> icons first, we can get the greatest "bang for the buck" in terms of 
> improving NetBeans' appearance on HiDPI displays. Note that in cases where an 
> icon file has been copied around to various places in the NetBeans codebase, 
> the spreadsheet includes only one location, picked arbitrarily. Once we have 
> a batch of icons ready to integrate into the NetBeans repository, Eirik will 
> redo the duplicate detection and ensure the SVGs end up in all relevant 
> locations, and start creating pull requests.
> See also the overview page for HiDPI improvements on 
> https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
>  .
> If you wish to contribute to this effort, comment here; Eirik will coordinate 
> to make sure multiple people are not working on the same icons.
> h2. Proposed Style Guide for Vectorized Icons
> * Vector icons should be drawn in Adobe Illustrator, or alternatively 
> Inkscape or another free tool. In Illustrator, each icon should be one named 
> artboard, sized to the correct size in pixels. See the attached Illustrator 
> template. (Adobe Illustrator comes with a free 7-day trial, after which it's 
> $35/month. If cost is a problem but you want to contribute your time to draw 
> icons, ask Eirik...)
> * If you prefer to use Inkscape instead, and want to contribute icons, that's 
> fine; just make sure to follow the same consistent style as the other icons. 
> If using Inkscape, perhaps pick another group of icons than the ones that are 
> currently being drawn in Illustrator. It's best to draw all similar-looking 
> icons in the same tool.
> * For each icon to be vectorized, place the old bitmap version of the icon in 
> a separate layer ("Old Bitmap Icons" in the Illustrator template). You can 
> then draw the vectorized version on top.
> * Since most of the existing NetBeans icons follow a quite consistent visual 
> style, and to simplify the job of creating new icons, it is best to keep the 
> shape of the new vectorized icons the same as in the old bitmap icons. For 
> instance, a rectangle of size 5x4px in the bitmap icon should probably become 
> a rectangle of 5x4px in 

[jira] [Resolved] (NETBEANS-4830) Redraw common icons in SVG: First Batch

2020-10-09 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke resolved NETBEANS-4830.
---
Fix Version/s: Next
   Resolution: Fixed

PR was merged; marking issue resolved.

> Redraw common icons in SVG: First Batch
> ---
>
> Key: NETBEANS-4830
> URL: https://issues.apache.org/jira/browse/NETBEANS-4830
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Reporter: Eirik Bakke
>Assignee: Eirik Bakke
>Priority: Major
>  Labels: HiDPI, pull-request-available
> Fix For: Next
>
> Attachments: NETBEANS-4830 Icons Drawn by Eirik.ai, 
> ide.editor.bookmarks (from Pete Whelpton for NETBEANS-4830).ai, 
> ide.editor.macros (from Pete Whelpton for NETBEANS-4830).ai, 
> ide.seperator.breadcrumbs (from Pete Whelpton for NETBEANS-4830).ai
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Part of the SVG icon drawing process tracked under NETBEANS-2617. Create a 
> separate issue to label the upcoming PR with.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-23 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute icons, that's 
fine; just make sure to follow the same consistent style as the other icons. If 
using Inkscape, perhaps pick another group of icons than the ones that are 
currently being drawn in Illustrator. It's best to draw all similar-looking 
icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in a 
separate layer ("Old Bitmap Icons" in the Illustrator template). You can then 
draw the vectorized version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which 
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller 
16x16 one, which is sometimes simpler. (This is already done in the prioritized 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-23 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute icons, that's 
fine; just make sure to follow the same consistent style as the other icons. If 
using Inkscape, perhaps pick another group of icons than the ones that are 
currently being drawn in Illustrator. It's best to draw all similar-looking 
icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in a 
separate layer ("Old Bitmap Icons" in the Illustrator template). You can then 
draw the vectorized version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which 
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller 
16x16 one, which is sometimes simpler. (This is already done in the prioritized 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-23 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute icons, that's 
fine; just make sure to follow the same consistent style as the other icons. If 
using Inkscape, perhaps pick another group of icons than the ones that are 
currently being drawn in Illustrator. It's best to draw all similar-looking 
icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in a 
separate layer ("Old Bitmap Icons" in the Illustrator template). You can then 
draw the vectorized version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which 
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller 
16x16 one, which is sometimes simpler. (This is already done in the prioritized 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute icons, that's 
fine; just make sure to follow the same consistent style as the other icons. If 
using Inkscape, perhaps pick another group of icons than the ones that are 
currently being drawn in Illustrator. It's best to draw all similar-looking 
icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in a 
separate layer ("Old Bitmap Icons" in the Illustrator template). You can then 
draw the vectorized version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which 
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller 
16x16 one, which is sometimes simpler. (This is already done in the prioritized 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute icons, that's 
fine; just make sure to follow the same consistent style as the other icons. If 
using Inkscape, perhaps pick another group of icons than the ones that are 
currently being drawn in Illustrator. It's best to draw all similar-looking 
icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which 
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller 
16x16 one, which is sometimes simpler. (This is already done in the prioritized 
icon list above.)
* 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which 
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller 
16x16 one, which is sometimes simpler. (This is already done in the prioritized 
icon 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which 
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller 
16x16 one, which is sometimes simpler. (This is already done in the prioritized 
icon 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which 
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller 
16x16 one, which is sometimes simpler. (This is already done in the prioritized 
icon 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For icons in the main IDE toolbar (as opposed to the editor toolbar), which 
exist in both 16x16 and 24x24 sizes, base the vector version on the smaller 
16x16 one, which is sometimes simpler. (This is already done in the prioritized 
icon 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons.
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)
* Avoid unnecessary anchor points 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator, or alternatively Inkscape 
or another free tool. In Illustrator, each icon should be one named artboard, 
sized to the correct size in pixels. See the attached Illustrator template. 
(Adobe Illustrator comes with a free 7-day trial, after which it's $35/month. 
If cost is a problem but you want to contribute your time to draw icons, ask 
Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, 

[jira] [Commented] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199719#comment-17199719
 ] 

Eirik Bakke commented on NETBEANS-2617:
---

For the SVG icons drawn up to now, I have created the JIRA issue NETBEANS-4830 
and pull request at https://github.com/apache/netbeans/pull/2387 . Pete, thanks 
for the icons you drew--they work perfectly!

> Redraw common icons in SVG
> --
>
> Key: NETBEANS-2617
> URL: https://issues.apache.org/jira/browse/NETBEANS-2617
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
> Environment: Windows, Linux, and MacOS
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: ScreenshotExample.png, ide.editor.bookmarks.ai, 
> ide.editor.macros.ai, ide.seperator.breadcrumbs.ai, 
> netbeans_icons_illustrator_template.ai, style example (dark filter).png, 
> style example.png
>
>
> Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
> icons with SVG versions, for improved appearance on Retina/HiDPI displays.
> h2. UPDATE: 
> [Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
>  is a Google Sheet where we can track progress of contributions and 
> prioritization of icons.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration and 
> Illustrator template. The Illustrator template includes a few icons which 
> have already been converted.
> In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
> migrated to the Google Sheet above). By redrawing the most commonly seen 
> icons first, we can get the greatest "bang for the buck" in terms of 
> improving NetBeans' appearance on HiDPI displays. Note that in cases where an 
> icon file has been copied around to various places in the NetBeans codebase, 
> the spreadsheet includes only one location, picked arbitrarily. Once we have 
> a batch of icons ready to integrate into the NetBeans repository, Eirik will 
> redo the duplicate detection and ensure the SVGs end up in all relevant 
> locations, and start creating pull requests.
> See also the overview page for HiDPI improvements on 
> https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
>  .
> If you wish to contribute to this effort, comment here; Eirik will coordinate 
> to make sure multiple people are not working on the same icons.
> h2. Proposed Style Guide for Vectorized Icons
> * Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
> named artboard, sized to the correct size in pixels. See the attached 
> Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
> which it's $35/month. If cost is a problem but you want to contribute your 
> time to draw icons, ask Eirik...)
> * If you prefer to use Inkscape instead, and want to contribute a few dozen 
> icons, that's fine; just make sure to follow the same consistent style as the 
> other icons. If using Inkscape, perhaps pick another group of icons than the 
> ones that are currently being drawn in Illustrator. It's best to draw all 
> similar-looking icons in the same tool.
> * For each icon to be vectorized, place the old bitmap version of the icon in 
> the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
> version on top.
> * Since most of the existing NetBeans icons follow a quite consistent visual 
> style, and to simplify the job of creating new icons, it is best to keep the 
> shape of the new vectorized icons the same as in the old bitmap icons. For 
> instance, a rectangle of size 5x4px in the bitmap icon should probably become 
> a rectangle of 5x4px in the vector version.
> * Keep the same general colors in vectorized icons as in the corresponding 
> old bitmap icons. (The color scheme is not too hard to change later, but we 
> should do this only once most of the IDE icons have been vectorized.)
> * If the old bitmap icon is complex, it is fine to simplify it a bit when 
> drawing vectorized versions.
> * Omit gradients, bevels, and unnecessary drop shadows. They take more time 
> to draw, and with "flat design", they are now out of fashion in any case.
> * Use a stroke width of 1px around the main shapes in the icon, like in the 
> existing bitmap icons. The new icons should look consistent with the existing 
> bitmap icons, especially since we may see bitmap icons and vector icons 
> side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
> finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
> have a 2x scaling.)
> * The 1px strokes that outline the icon's shapes should 

[jira] [Updated] (NETBEANS-4830) Redraw common icons in SVG: First Batch

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4830:
--
Attachment: NETBEANS-4830 Icons Drawn by Eirik.ai

> Redraw common icons in SVG: First Batch
> ---
>
> Key: NETBEANS-4830
> URL: https://issues.apache.org/jira/browse/NETBEANS-4830
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Reporter: Eirik Bakke
>Assignee: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: NETBEANS-4830 Icons Drawn by Eirik.ai, 
> ide.editor.bookmarks (from Pete Whelpton for NETBEANS-4830).ai, 
> ide.editor.macros (from Pete Whelpton for NETBEANS-4830).ai, 
> ide.seperator.breadcrumbs (from Pete Whelpton for NETBEANS-4830).ai
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Part of the SVG icon drawing process tracked under NETBEANS-2617. Create a 
> separate issue to label the upcoming PR with.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4830) Redraw common icons in SVG: First Batch

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4830:
--
Attachment: ide.seperator.breadcrumbs (from Pete Whelpton for 
NETBEANS-4830).ai
ide.editor.macros (from Pete Whelpton for NETBEANS-4830).ai
ide.editor.bookmarks (from Pete Whelpton for NETBEANS-4830).ai

> Redraw common icons in SVG: First Batch
> ---
>
> Key: NETBEANS-4830
> URL: https://issues.apache.org/jira/browse/NETBEANS-4830
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Reporter: Eirik Bakke
>Assignee: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: NETBEANS-4830 Icons Drawn by Eirik.ai, 
> ide.editor.bookmarks (from Pete Whelpton for NETBEANS-4830).ai, 
> ide.editor.macros (from Pete Whelpton for NETBEANS-4830).ai, 
> ide.seperator.breadcrumbs (from Pete Whelpton for NETBEANS-4830).ai
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Part of the SVG icon drawing process tracked under NETBEANS-2617. Create a 
> separate issue to label the upcoming PR with.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Attachment: (was: Icons drawn by Eirik as of 2020-09-18 (this file for 
visual reference only).pdf)

> Redraw common icons in SVG
> --
>
> Key: NETBEANS-2617
> URL: https://issues.apache.org/jira/browse/NETBEANS-2617
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
> Environment: Windows, Linux, and MacOS
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: ScreenshotExample.png, ide.editor.bookmarks.ai, 
> ide.editor.macros.ai, ide.seperator.breadcrumbs.ai, 
> netbeans_icons_illustrator_template.ai, style example (dark filter).png, 
> style example.png
>
>
> Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
> icons with SVG versions, for improved appearance on Retina/HiDPI displays.
> h2. UPDATE: 
> [Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
>  is a Google Sheet where we can track progress of contributions and 
> prioritization of icons.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration and 
> Illustrator template. The Illustrator template includes a few icons which 
> have already been converted.
> In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
> migrated to the Google Sheet above). By redrawing the most commonly seen 
> icons first, we can get the greatest "bang for the buck" in terms of 
> improving NetBeans' appearance on HiDPI displays. Note that in cases where an 
> icon file has been copied around to various places in the NetBeans codebase, 
> the spreadsheet includes only one location, picked arbitrarily. Once we have 
> a batch of icons ready to integrate into the NetBeans repository, Eirik will 
> redo the duplicate detection and ensure the SVGs end up in all relevant 
> locations, and start creating pull requests.
> See also the overview page for HiDPI improvements on 
> https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
>  .
> If you wish to contribute to this effort, comment here; Eirik will coordinate 
> to make sure multiple people are not working on the same icons.
> h2. Proposed Style Guide for Vectorized Icons
> * Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
> named artboard, sized to the correct size in pixels. See the attached 
> Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
> which it's $35/month. If cost is a problem but you want to contribute your 
> time to draw icons, ask Eirik...)
> * If you prefer to use Inkscape instead, and want to contribute a few dozen 
> icons, that's fine; just make sure to follow the same consistent style as the 
> other icons. If using Inkscape, perhaps pick another group of icons than the 
> ones that are currently being drawn in Illustrator. It's best to draw all 
> similar-looking icons in the same tool.
> * For each icon to be vectorized, place the old bitmap version of the icon in 
> the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
> version on top.
> * Since most of the existing NetBeans icons follow a quite consistent visual 
> style, and to simplify the job of creating new icons, it is best to keep the 
> shape of the new vectorized icons the same as in the old bitmap icons. For 
> instance, a rectangle of size 5x4px in the bitmap icon should probably become 
> a rectangle of 5x4px in the vector version.
> * Keep the same general colors in vectorized icons as in the corresponding 
> old bitmap icons. (The color scheme is not too hard to change later, but we 
> should do this only once most of the IDE icons have been vectorized.)
> * If the old bitmap icon is complex, it is fine to simplify it a bit when 
> drawing vectorized versions.
> * Omit gradients, bevels, and unnecessary drop shadows. They take more time 
> to draw, and with "flat design", they are now out of fashion in any case.
> * Use a stroke width of 1px around the main shapes in the icon, like in the 
> existing bitmap icons. The new icons should look consistent with the existing 
> bitmap icons, especially since we may see bitmap icons and vector icons 
> side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
> finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
> have a 2x scaling.)
> * The 1px strokes that outline the icon's shapes should typically be 33% 
> transparent black on top of the shape's background color, or of similar 
> darkness. See the examples in the attached 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)
* Avoid unnecessary anchor points (illustration from IntelliJ's style guide: 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)
* Avoid unnecessary anchor points (illustration from IntelliJ's style guide: 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)
* Avoid unnecessary anchor points (illustration from IntelliJ's style guide: 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)
* Avoid unnecessary anchor points (illustration from IntelliJ's style guide: 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-21 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)
* Avoid unnecessary anchor points (illustration from IntelliJ's style guide: 

[jira] [Created] (NETBEANS-4830) Redraw common icons in SVG: First Batch

2020-09-21 Thread Eirik Bakke (Jira)
Eirik Bakke created NETBEANS-4830:
-

 Summary: Redraw common icons in SVG: First Batch
 Key: NETBEANS-4830
 URL: https://issues.apache.org/jira/browse/NETBEANS-4830
 Project: NetBeans
  Issue Type: Improvement
  Components: platform - Other
Reporter: Eirik Bakke
Assignee: Eirik Bakke


Part of the SVG icon drawing process tracked under NETBEANS-2617. Create a 
separate issue to label the upcoming PR with.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-18 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we have a 
batch of icons ready to integrate into the NetBeans repository, Eirik will redo 
the duplicate detection and ensure the SVGs end up in all relevant locations, 
and start creating pull requests.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)
* Avoid unnecessary anchor points (illustration from IntelliJ's style guide: 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-18 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we are ready 
to install the icons into the repo, Eirik will redo the duplicate detection and 
ensure the SVGs end up in all relevant locations.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)
* Avoid unnecessary anchor points (illustration from IntelliJ's style guide: 
[correct|https://jetbrains.design/intellij/images/icons/stroke_anchors_corr...@2x.png]
 vs. 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-18 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we are ready 
to install the icons into the repo, Eirik will redo the duplicate detection and 
ensure the SVGs end up in all relevant locations.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* When the same shape occurs in different icons but at different sizes (e.g. 
the small magnifying glass in find_selection.png vs. the large magnifying glass 
in zoom_in.png), strokes and borders should still remain at the same thickness 
(1px for external borders and 0.5px for internal strokes).
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.



  was:
Once NETBEANS-2604 is done, 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-18 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Attachment: Icons drawn by Eirik as of 2020-09-18 (this file for visual 
reference only).pdf

> Redraw common icons in SVG
> --
>
> Key: NETBEANS-2617
> URL: https://issues.apache.org/jira/browse/NETBEANS-2617
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
> Environment: Windows, Linux, and MacOS
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: Icons drawn by Eirik as of 2020-09-18 (this file for 
> visual reference only).pdf, ScreenshotExample.png, ide.editor.bookmarks.ai, 
> ide.editor.macros.ai, ide.seperator.breadcrumbs.ai, 
> netbeans_icons_illustrator_template.ai, style example (dark filter).png, 
> style example.png
>
>
> Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
> icons with SVG versions, for improved appearance on Retina/HiDPI displays.
> h2. UPDATE: 
> [Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
>  is a Google Sheet where we can track progress of contributions and 
> prioritization of icons.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration and 
> Illustrator template. The Illustrator template includes a few icons which 
> have already been converted.
> In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
> migrated to the Google Sheet above). By redrawing the most commonly seen 
> icons first, we can get the greatest "bang for the buck" in terms of 
> improving NetBeans' appearance on HiDPI displays. Note that in cases where an 
> icon file has been copied around to various places in the NetBeans codebase, 
> the spreadsheet includes only one location, picked arbitrarily. Once we are 
> ready to install the icons into the repo, Eirik will redo the duplicate 
> detection and ensure the SVGs end up in all relevant locations.
> See also the overview page for HiDPI improvements on 
> https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
>  .
> h2. Proposed Style Guide for Vectorized Icons
> * Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
> named artboard, sized to the correct size in pixels. See the attached 
> Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
> which it's $35/month. If cost is a problem but you want to contribute your 
> time to draw icons, ask Eirik...)
> * If you prefer to use Inkscape instead, and want to contribute a few dozen 
> icons, that's fine; just make sure to follow the same consistent style as the 
> other icons. If using Inkscape, perhaps pick another group of icons than the 
> ones that are currently being drawn in Illustrator. It's best to draw all 
> similar-looking icons in the same tool.
> * For each icon to be vectorized, place the old bitmap version of the icon in 
> the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
> version on top.
> * Since most of the existing NetBeans icons follow a quite consistent visual 
> style, and to simplify the job of creating new icons, it is best to keep the 
> shape of the new vectorized icons the same as in the old bitmap icons. For 
> instance, a rectangle of size 5x4px in the bitmap icon should probably become 
> a rectangle of 5x4px in the vector version.
> * Keep the same general colors in vectorized icons as in the corresponding 
> old bitmap icons. (The color scheme is not too hard to change later, but we 
> should do this only once most of the IDE icons have been vectorized.)
> * If the old bitmap icon is complex, it is fine to simplify it a bit when 
> drawing vectorized versions.
> * Omit gradients, bevels, and unnecessary drop shadows. They take more time 
> to draw, and with "flat design", they are now out of fashion in any case.
> * Use a stroke width of 1px around the main shapes in the icon, like in the 
> existing bitmap icons. The new icons should look consistent with the existing 
> bitmap icons, especially since we may see bitmap icons and vector icons 
> side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
> finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
> have a 2x scaling.)
> * The 1px strokes that outline the icon's shapes should typically be 33% 
> transparent black on top of the shape's background color, or of similar 
> darkness. See the examples in the attached "style example.png" file.
> * Horizontal and vertical strokes must be aligned to the pixel grid.
> * While it may sometimes be necessary 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-18 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and 
prioritization of icons.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
migrated to the Google Sheet above). By redrawing the most commonly seen icons 
first, we can get the greatest "bang for the buck" in terms of improving 
NetBeans' appearance on HiDPI displays. Note that in cases where an icon file 
has been copied around to various places in the NetBeans codebase, the 
spreadsheet includes only one location, picked arbitrarily. Once we are ready 
to install the icons into the repo, Eirik will redo the duplicate detection and 
ensure the SVGs end up in all relevant locations.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.



  was:
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of 

[jira] [Commented] (NETBEANS-2605) Prioritize icons to vectorize for HiDPI support

2020-09-18 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198537#comment-17198537
 ] 

Eirik Bakke commented on NETBEANS-2605:
---

The prioritization list has now been migrated to this Google Sheet, which 
supersedes the previous link:

https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing

> Prioritize icons to vectorize for HiDPI support
> ---
>
> Key: NETBEANS-2605
> URL: https://issues.apache.org/jira/browse/NETBEANS-2605
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: Prioritization Indication.png, effort_required.png
>
>
> As part of the higher-level 
> [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements]
>  to support HiDPI for the NetBeans IDE and for NetBeans Platform 
> applications, a commonly used subset of icons should be recreated using the 
> scalable SVG format (see NETBEANS-2604).
> As of 2019-05-27, there are 2740 unique files with extension 'png' or 'gif' 
> in non-test sources in the [NetBeans codebase's master 
> branch|https://github.com/apache/netbeans]. The page at 
> https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these 
> images. When there are multiple files with the same SHA256 checksum, only one 
> is shown.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration (and 
> [this Illustrator 
> template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]).
>  Thus it's infeasible to do this for every icon in the codebase. Instead, 
> icons commonly seen on the screen during a typical NetBeans IDE session 
> should be prioritized.
> This issue tracks the task of providing a prioritized list of icons (with 
> file names) for which we should try to provide SVG versions. For example, in 
> prioritized order:
> # Every icon in the editor toolbar
> # Every icon in the application toolbar, with default NetBeans settings.
> # Icons used in the menu bar menus.
> # Any other icon seen on the screen when a blank NetBeans IDE installation is 
> started up.
> # Icons shown in the Projects pane when working with a simple Java project.
> # Icons shown in the Projects pane when working with a Java project in a git 
> repository.
> # etc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-2605) Prioritize icons to vectorize for HiDPI support

2020-09-18 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198537#comment-17198537
 ] 

Eirik Bakke edited comment on NETBEANS-2605 at 9/18/20, 9:19 PM:
-

The prioritization list has now been migrated to this Google Sheet, which 
supersedes the previous link:

https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing

See https://issues.apache.org/jira/browse/NETBEANS-2617 for the continued 
tracking of this effort.


was (Author: ebakke):
The prioritization list has now been migrated to this Google Sheet, which 
supersedes the previous link:

https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing

> Prioritize icons to vectorize for HiDPI support
> ---
>
> Key: NETBEANS-2605
> URL: https://issues.apache.org/jira/browse/NETBEANS-2605
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: Prioritization Indication.png, effort_required.png
>
>
> As part of the higher-level 
> [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements]
>  to support HiDPI for the NetBeans IDE and for NetBeans Platform 
> applications, a commonly used subset of icons should be recreated using the 
> scalable SVG format (see NETBEANS-2604).
> As of 2019-05-27, there are 2740 unique files with extension 'png' or 'gif' 
> in non-test sources in the [NetBeans codebase's master 
> branch|https://github.com/apache/netbeans]. The page at 
> https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these 
> images. When there are multiple files with the same SHA256 checksum, only one 
> is shown.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration (and 
> [this Illustrator 
> template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]).
>  Thus it's infeasible to do this for every icon in the codebase. Instead, 
> icons commonly seen on the screen during a typical NetBeans IDE session 
> should be prioritized.
> This issue tracks the task of providing a prioritized list of icons (with 
> file names) for which we should try to provide SVG versions. For example, in 
> prioritized order:
> # Every icon in the editor toolbar
> # Every icon in the application toolbar, with default NetBeans settings.
> # Icons used in the menu bar menus.
> # Any other icon seen on the screen when a blank NetBeans IDE installation is 
> started up.
> # Icons shown in the Projects pane when working with a simple Java project.
> # Icons shown in the Projects pane when working with a Java project in a git 
> repository.
> # etc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-18 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and remaining 
prioritized icons:

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, the following prioritized list of icons to convert was 
produced:

https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html (this 
list now migrated to the Google Sheet above)

By redrawing the most commonly seen icons first, we can get the greatest "bang 
for the buck" in terms of improving NetBeans' appearance on HiDPI displays. 
Note that in cases where an icon file has been copied around to various places 
in the NetBeans codebase, only one of the paths is shown in the list above.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.



  was:
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and remaining 
prioritized icons:

With some 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-18 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and remaining 
prioritized icons:

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, the following prioritized list of icons to convert was 
produced:

https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html

By redrawing the most commonly seen icons first, we can get the greatest "bang 
for the buck" in terms of improving NetBeans' appearance on HiDPI displays. 
Note that in cases where an icon file has been copied around to various places 
in the NetBeans codebase, only one of the paths is shown in the list above.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (These will come out to 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.



  was:
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and remaining 
prioritized icons:

With some practice, it takes on average 30 minutes to create an 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-18 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and remaining 
prioritized icons:

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, the following prioritized list of icons to convert was 
produced:

https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html

By redrawing the most commonly seen icons first, we can get the greatest "bang 
for the buck" in terms of improving NetBeans' appearance on HiDPI displays. 
Note that in cases where an icon file has been copied around to various places 
in the NetBeans codebase, only one of the paths is shown in the list above.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details. (0.5px strokes become 1 device pixel on Retina screens, which 
have a 2x scaling.)
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.



  was:
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and remaining 
prioritized icons:

With some practice, it takes on average 30 minutes to create an SVG 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-18 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and remaining 
prioritized icons:

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, the following prioritized list of icons to convert was 
produced:

https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html

By redrawing the most commonly seen icons first, we can get the greatest "bang 
for the buck" in terms of improving NetBeans' appearance on HiDPI displays. 
Note that in cases where an icon file has been copied around to various places 
in the NetBeans codebase, only one of the paths is shown in the list above.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details.
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.



  was:
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, the following prioritized list of icons to convert was 
produced:


[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-18 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, the following prioritized list of icons to convert was 
produced:

https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html

By redrawing the most commonly seen icons first, we can get the greatest "bang 
for the buck" in terms of improving NetBeans' appearance on HiDPI displays. 
Note that in cases where an icon file has been copied around to various places 
in the NetBeans codebase, only one of the paths is shown in the list above.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* If you prefer to use Inkscape instead, and want to contribute a few dozen 
icons, that's fine; just make sure to follow the same consistent style as the 
other icons. If using Inkscape, perhaps pick another group of icons than the 
ones that are currently being drawn in Illustrator. It's best to draw all 
similar-looking icons in the same tool.
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details.
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and remaining 
prioritized icons:



  was:
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, the following prioritized list of icons to convert was 
produced:


[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-18 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Description: 
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, the following prioritized list of icons to convert was 
produced:

https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html

By redrawing the most commonly seen icons first, we can get the greatest "bang 
for the buck" in terms of improving NetBeans' appearance on HiDPI displays. 
Note that in cases where an icon file has been copied around to various places 
in the NetBeans codebase, only one of the paths is shown in the list above.

See also the overview page for HiDPI improvements on 
https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
 .

h2. Proposed Style Guide for Vectorized Icons
* Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
named artboard, sized to the correct size in pixels. See the attached 
Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
which it's $35/month. If cost is a problem but you want to contribute your time 
to draw icons, ask Eirik...)
* For each icon to be vectorized, place the old bitmap version of the icon in 
the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
version on top.
* Since most of the existing NetBeans icons follow a quite consistent visual 
style, and to simplify the job of creating new icons, it is best to keep the 
shape of the new vectorized icons the same as in the old bitmap icons. For 
instance, a rectangle of size 5x4px in the bitmap icon should probably become a 
rectangle of 5x4px in the vector version.
* Keep the same general colors in vectorized icons as in the corresponding old 
bitmap icons. (The color scheme is not too hard to change later, but we should 
do this only once most of the IDE icons have been vectorized.)
* If the old bitmap icon is complex, it is fine to simplify it a bit when 
drawing vectorized versions.
* Omit gradients, bevels, and unnecessary drop shadows. They take more time to 
draw, and with "flat design", they are now out of fashion in any case.
* Use a stroke width of 1px around the main shapes in the icon, like in the 
existing bitmap icons. The new icons should look consistent with the existing 
bitmap icons, especially since we may see bitmap icons and vector icons 
side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
finer details.
* The 1px strokes that outline the icon's shapes should typically be 33% 
transparent black on top of the shape's background color, or of similar 
darkness. See the examples in the attached "style example.png" file.
* Horizontal and vertical strokes must be aligned to the pixel grid.
* While it may sometimes be necessary to "outline" strokes for the purposes of 
applying boolean operations (e.g. subtracting another shape from the stroke 
only), strokes should be left as strokes whenever possible, as this leads to 
smaller SVG files, and makes shapes within the icon easier to modify.
* For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the vector 
version on the smaller 16x16 one, which is sometimes simpler. (This is already 
done in the prioritized icon list above.)

If you wish to contribute to this effort, comment here; Eirik will coordinate 
to make sure multiple people are not working on the same icons.

h2. UPDATE: 
[Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
 is a Google Sheet where we can track progress of contributions and remaining 
prioritized icons:



  was:
Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
icons with SVG versions, for improved appearance on Retina/HiDPI displays.

With some practice, it takes on average 30 minutes to create an SVG version of 
a typical icon in Adobe Illustrator. See the attached illustration and 
Illustrator template. The Illustrator template includes a few icons which have 
already been converted.

In NETBEANS-2605, the following prioritized list of icons to convert was 
produced:

https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html

By redrawing the most commonly seen icons first, we can get the greatest "bang 
for the buck" in terms of improving NetBeans' appearance on HiDPI displays. 
Note that in cases where an icon file has been copied around to various places 
in the NetBeans codebase, only one of the paths is shown in the 

[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-08 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Attachment: style example (dark filter).png

> Redraw common icons in SVG
> --
>
> Key: NETBEANS-2617
> URL: https://issues.apache.org/jira/browse/NETBEANS-2617
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
> Environment: Windows, Linux, and MacOS
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: ScreenshotExample.png, ide.editor.bookmarks.ai, 
> ide.editor.macros.ai, ide.seperator.breadcrumbs.ai, 
> netbeans_icons_illustrator_template.ai, style example (dark filter).png, 
> style example.png
>
>
> Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
> icons with SVG versions, for improved appearance on Retina/HiDPI displays.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration and 
> Illustrator template. The Illustrator template includes a few icons which 
> have already been converted.
> In NETBEANS-2605, the following prioritized list of icons to convert was 
> produced:
> https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html
> By redrawing the most commonly seen icons first, we can get the greatest 
> "bang for the buck" in terms of improving NetBeans' appearance on HiDPI 
> displays. Note that in cases where an icon file has been copied around to 
> various places in the NetBeans codebase, only one of the paths is shown in 
> the list above.
> See also the overview page for HiDPI improvements on 
> https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
>  .
> h2. Proposed Style Guide for Vectorized Icons
> * Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
> named artboard, sized to the correct size in pixels. See the attached 
> Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
> which it's $35/month. If cost is a problem but you want to contribute your 
> time to draw icons, ask Eirik...)
> * For each icon to be vectorized, place the old bitmap version of the icon in 
> the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
> version on top.
> * Since most of the existing NetBeans icons follow a quite consistent visual 
> style, and to simplify the job of creating new icons, it is best to keep the 
> shape of the new vectorized icons the same as in the old bitmap icons. For 
> instance, a rectangle of size 5x4px in the bitmap icon should probably become 
> a rectangle of 5x4px in the vector version.
> * Keep the same general colors in vectorized icons as in the corresponding 
> old bitmap icons. (The color scheme is not too hard to change later, but we 
> should do this only once most of the IDE icons have been vectorized.)
> * If the old bitmap icon is complex, it is fine to simplify it a bit when 
> drawing vectorized versions.
> * Omit gradients, bevels, and unnecessary drop shadows. They take more time 
> to draw, and with "flat design", they are now out of fashion in any case.
> * Use a stroke width of 1px around the main shapes in the icon, like in the 
> existing bitmap icons. The new icons should look consistent with the existing 
> bitmap icons, especially since we may see bitmap icons and vector icons 
> side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
> finer details.
> * The 1px strokes that outline the icon's shapes should typically be 33% 
> transparent black on top of the shape's background color, or of similar 
> darkness. See the examples in the attached "style example.png" file.
> * Horizontal and vertical strokes must be aligned to the pixel grid.
> * While it may sometimes be necessary to "outline" strokes for the purposes 
> of applying boolean operations (e.g. subtracting another shape from the 
> stroke only), strokes should be left as strokes whenever possible, as this 
> leads to smaller SVG files, and makes shapes within the icon easier to modify.
> * For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the 
> vector version on the smaller 16x16 one, which is sometimes simpler. (This is 
> already done in the prioritized icon list above.)
> If you wish to contribute to this effort, comment here; Eirik will coordinate 
> to make sure multiple people are not working on the same icons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information 

[jira] [Commented] (NETBEANS-2617) Redraw common icons in SVG

2020-09-08 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192471#comment-17192471
 ] 

Eirik Bakke commented on NETBEANS-2617:
---

Also adding a screenshot showing what these icons would look like with a "Dark 
Mode" filter applied (invert L channel in LAB color space).

> Redraw common icons in SVG
> --
>
> Key: NETBEANS-2617
> URL: https://issues.apache.org/jira/browse/NETBEANS-2617
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
> Environment: Windows, Linux, and MacOS
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: ScreenshotExample.png, ide.editor.bookmarks.ai, 
> ide.editor.macros.ai, ide.seperator.breadcrumbs.ai, 
> netbeans_icons_illustrator_template.ai, style example (dark filter).png, 
> style example.png
>
>
> Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
> icons with SVG versions, for improved appearance on Retina/HiDPI displays.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration and 
> Illustrator template. The Illustrator template includes a few icons which 
> have already been converted.
> In NETBEANS-2605, the following prioritized list of icons to convert was 
> produced:
> https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html
> By redrawing the most commonly seen icons first, we can get the greatest 
> "bang for the buck" in terms of improving NetBeans' appearance on HiDPI 
> displays. Note that in cases where an icon file has been copied around to 
> various places in the NetBeans codebase, only one of the paths is shown in 
> the list above.
> See also the overview page for HiDPI improvements on 
> https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
>  .
> h2. Proposed Style Guide for Vectorized Icons
> * Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
> named artboard, sized to the correct size in pixels. See the attached 
> Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
> which it's $35/month. If cost is a problem but you want to contribute your 
> time to draw icons, ask Eirik...)
> * For each icon to be vectorized, place the old bitmap version of the icon in 
> the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
> version on top.
> * Since most of the existing NetBeans icons follow a quite consistent visual 
> style, and to simplify the job of creating new icons, it is best to keep the 
> shape of the new vectorized icons the same as in the old bitmap icons. For 
> instance, a rectangle of size 5x4px in the bitmap icon should probably become 
> a rectangle of 5x4px in the vector version.
> * Keep the same general colors in vectorized icons as in the corresponding 
> old bitmap icons. (The color scheme is not too hard to change later, but we 
> should do this only once most of the IDE icons have been vectorized.)
> * If the old bitmap icon is complex, it is fine to simplify it a bit when 
> drawing vectorized versions.
> * Omit gradients, bevels, and unnecessary drop shadows. They take more time 
> to draw, and with "flat design", they are now out of fashion in any case.
> * Use a stroke width of 1px around the main shapes in the icon, like in the 
> existing bitmap icons. The new icons should look consistent with the existing 
> bitmap icons, especially since we may see bitmap icons and vector icons 
> side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
> finer details.
> * The 1px strokes that outline the icon's shapes should typically be 33% 
> transparent black on top of the shape's background color, or of similar 
> darkness. See the examples in the attached "style example.png" file.
> * Horizontal and vertical strokes must be aligned to the pixel grid.
> * While it may sometimes be necessary to "outline" strokes for the purposes 
> of applying boolean operations (e.g. subtracting another shape from the 
> stroke only), strokes should be left as strokes whenever possible, as this 
> leads to smaller SVG files, and makes shapes within the icon easier to modify.
> * For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the 
> vector version on the smaller 16x16 one, which is sometimes simpler. (This is 
> already done in the prioritized icon list above.)
> If you wish to contribute to this effort, comment here; Eirik will coordinate 
> to make sure multiple people are not working on the same icons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: 

[jira] [Commented] (NETBEANS-2617) Redraw common icons in SVG

2020-09-08 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192419#comment-17192419
 ] 

Eirik Bakke commented on NETBEANS-2617:
---

I'm adding a screenshot of my NetBeans Platform application, which uses the 
icon style proposed here, to give an idea of what this would look like in the 
IDE (especially in the Projects pane and editor toolbar).

> Redraw common icons in SVG
> --
>
> Key: NETBEANS-2617
> URL: https://issues.apache.org/jira/browse/NETBEANS-2617
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
> Environment: Windows, Linux, and MacOS
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: ScreenshotExample.png, ide.editor.bookmarks.ai, 
> ide.editor.macros.ai, ide.seperator.breadcrumbs.ai, 
> netbeans_icons_illustrator_template.ai, style example.png
>
>
> Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
> icons with SVG versions, for improved appearance on Retina/HiDPI displays.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration and 
> Illustrator template. The Illustrator template includes a few icons which 
> have already been converted.
> In NETBEANS-2605, the following prioritized list of icons to convert was 
> produced:
> https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html
> By redrawing the most commonly seen icons first, we can get the greatest 
> "bang for the buck" in terms of improving NetBeans' appearance on HiDPI 
> displays. Note that in cases where an icon file has been copied around to 
> various places in the NetBeans codebase, only one of the paths is shown in 
> the list above.
> See also the overview page for HiDPI improvements on 
> https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
>  .
> h2. Proposed Style Guide for Vectorized Icons
> * Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
> named artboard, sized to the correct size in pixels. See the attached 
> Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
> which it's $35/month. If cost is a problem but you want to contribute your 
> time to draw icons, ask Eirik...)
> * For each icon to be vectorized, place the old bitmap version of the icon in 
> the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
> version on top.
> * Since most of the existing NetBeans icons follow a quite consistent visual 
> style, and to simplify the job of creating new icons, it is best to keep the 
> shape of the new vectorized icons the same as in the old bitmap icons. For 
> instance, a rectangle of size 5x4px in the bitmap icon should probably become 
> a rectangle of 5x4px in the vector version.
> * Keep the same general colors in vectorized icons as in the corresponding 
> old bitmap icons. (The color scheme is not too hard to change later, but we 
> should do this only once most of the IDE icons have been vectorized.)
> * If the old bitmap icon is complex, it is fine to simplify it a bit when 
> drawing vectorized versions.
> * Omit gradients, bevels, and unnecessary drop shadows. They take more time 
> to draw, and with "flat design", they are now out of fashion in any case.
> * Use a stroke width of 1px around the main shapes in the icon, like in the 
> existing bitmap icons. The new icons should look consistent with the existing 
> bitmap icons, especially since we may see bitmap icons and vector icons 
> side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
> finer details.
> * The 1px strokes that outline the icon's shapes should typically be 33% 
> transparent black on top of the shape's background color, or of similar 
> darkness. See the examples in the attached "style example.png" file.
> * Horizontal and vertical strokes must be aligned to the pixel grid.
> * While it may sometimes be necessary to "outline" strokes for the purposes 
> of applying boolean operations (e.g. subtracting another shape from the 
> stroke only), strokes should be left as strokes whenever possible, as this 
> leads to smaller SVG files, and makes shapes within the icon easier to modify.
> * For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the 
> vector version on the smaller 16x16 one, which is sometimes simpler. (This is 
> already done in the prioritized icon list above.)
> If you wish to contribute to this effort, comment here; Eirik will coordinate 
> to make sure multiple people are not working on the same icons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (NETBEANS-2617) Redraw common icons in SVG

2020-09-08 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2617:
--
Attachment: ScreenshotExample.png

> Redraw common icons in SVG
> --
>
> Key: NETBEANS-2617
> URL: https://issues.apache.org/jira/browse/NETBEANS-2617
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
> Environment: Windows, Linux, and MacOS
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: ScreenshotExample.png, ide.editor.bookmarks.ai, 
> ide.editor.macros.ai, ide.seperator.breadcrumbs.ai, 
> netbeans_icons_illustrator_template.ai, style example.png
>
>
> Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
> icons with SVG versions, for improved appearance on Retina/HiDPI displays.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration and 
> Illustrator template. The Illustrator template includes a few icons which 
> have already been converted.
> In NETBEANS-2605, the following prioritized list of icons to convert was 
> produced:
> https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html
> By redrawing the most commonly seen icons first, we can get the greatest 
> "bang for the buck" in terms of improving NetBeans' appearance on HiDPI 
> displays. Note that in cases where an icon file has been copied around to 
> various places in the NetBeans codebase, only one of the paths is shown in 
> the list above.
> See also the overview page for HiDPI improvements on 
> https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
>  .
> h2. Proposed Style Guide for Vectorized Icons
> * Vector icons should be drawn in Adobe Illustrator. Each icon should be one 
> named artboard, sized to the correct size in pixels. See the attached 
> Illustrator template. (Adobe Illustrator comes with a free 7-day trial, after 
> which it's $35/month. If cost is a problem but you want to contribute your 
> time to draw icons, ask Eirik...)
> * For each icon to be vectorized, place the old bitmap version of the icon in 
> the "Old Bitmap Icons" layer in Illustrator. You can then draw the vectorized 
> version on top.
> * Since most of the existing NetBeans icons follow a quite consistent visual 
> style, and to simplify the job of creating new icons, it is best to keep the 
> shape of the new vectorized icons the same as in the old bitmap icons. For 
> instance, a rectangle of size 5x4px in the bitmap icon should probably become 
> a rectangle of 5x4px in the vector version.
> * Keep the same general colors in vectorized icons as in the corresponding 
> old bitmap icons. (The color scheme is not too hard to change later, but we 
> should do this only once most of the IDE icons have been vectorized.)
> * If the old bitmap icon is complex, it is fine to simplify it a bit when 
> drawing vectorized versions.
> * Omit gradients, bevels, and unnecessary drop shadows. They take more time 
> to draw, and with "flat design", they are now out of fashion in any case.
> * Use a stroke width of 1px around the main shapes in the icon, like in the 
> existing bitmap icons. The new icons should look consistent with the existing 
> bitmap icons, especially since we may see bitmap icons and vector icons 
> side-by-side for a long time. Within shapes, 0.5px strokes can be used for 
> finer details.
> * The 1px strokes that outline the icon's shapes should typically be 33% 
> transparent black on top of the shape's background color, or of similar 
> darkness. See the examples in the attached "style example.png" file.
> * Horizontal and vertical strokes must be aligned to the pixel grid.
> * While it may sometimes be necessary to "outline" strokes for the purposes 
> of applying boolean operations (e.g. subtracting another shape from the 
> stroke only), strokes should be left as strokes whenever possible, as this 
> leads to smaller SVG files, and makes shapes within the icon easier to modify.
> * For toolbar icons, which exist in both 16x16 and 24x24 sizes, base the 
> vector version on the smaller 16x16 one, which is sometimes simpler. (This is 
> already done in the prioritized icon list above.)
> If you wish to contribute to this effort, comment here; Eirik will coordinate 
> to make sure multiple people are not working on the same icons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:

[jira] [Commented] (NETBEANS-4754) Action gets called with wrong context until garbage collection

2020-09-01 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188233#comment-17188233
 ] 

Eirik Bakke commented on NETBEANS-4754:
---

I'll sneak in a question before bedtime--how does enabler get initialized? Is 
there reflection magic happening somewhere?

(If so, then I'm not exactly sure how the patch should work, since it wouldn't 
be enough to just rip out instDelegate. But you probably have an idea...)

> Action gets called with wrong context until garbage collection
> --
>
> Key: NETBEANS-4754
> URL: https://issues.apache.org/jira/browse/NETBEANS-4754
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Actions
>Affects Versions: 12.0
> Environment: NetBeans Platform application running on NetBeans 
> Platform 12.0 on Windows 10 / Java 13.0.2.
>Reporter: Eirik Bakke
>Assignee: Svatopluk Dedic
>Priority: Major
> Attachments: netbeans-4754-eiriktest.patch
>
>
> My NetBeans Platform application has an action declared as follows:
> {code:java}
> @ActionID(category = "Ultorg", id = "com.ultorg.actionids.FieldsAction")
> @ActionRegistration(displayName = "#CTL_FieldsAction")
> @Messages("CTL_FieldsAction=Fields & Joins...")
> public class FieldsAction implements ActionListener {
>   private final ToolboxInvoker invoker;
>   public FieldsAction(ToolboxInvoker invoker) {
> Preconditions.checkNotNull(invoker);
> this.invoker = invoker;
>   }
>   @Override
>   public void actionPerformed(ActionEvent e) {
> invoker.invoke();
>   }
> }
> {code}
> The ToolboxInvoker context is provided by the lookup of a custom TopComponent 
> implementation. When I have multiple such TopComponent tabs open, switching 
> between them, and invoking the action above with a keyboard shortcut, the 
> wrong FieldsAction instance will occasionally be called (i.e. an instance 
> with the wrong ToolboxInvoker context).
> After some debugging, the problem seems to be caused by 
> https://github.com/apache/netbeans/pull/652 , specifically by 
> ContextAction.delegate0 assuming that instDelegate can be used as a cached 
> value without checking whether the lookup (data parameter) has changed. Or 
> perhaps instDelegate was supposed to be cleared elsewhere whenever the lookup 
> changes--but this is not happening properly.
> Because the instDelegate field holds only weak references, the buggy state 
> only lasts until the next garbage collection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4754) Action gets called with wrong context until garbage collection

2020-09-01 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188229#comment-17188229
 ] 

Eirik Bakke commented on NETBEANS-4754:
---

Thanks for your help! Going to bed now here in the US...

> Action gets called with wrong context until garbage collection
> --
>
> Key: NETBEANS-4754
> URL: https://issues.apache.org/jira/browse/NETBEANS-4754
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Actions
>Affects Versions: 12.0
> Environment: NetBeans Platform application running on NetBeans 
> Platform 12.0 on Windows 10 / Java 13.0.2.
>Reporter: Eirik Bakke
>Assignee: Svatopluk Dedic
>Priority: Major
> Attachments: netbeans-4754-eiriktest.patch
>
>
> My NetBeans Platform application has an action declared as follows:
> {code:java}
> @ActionID(category = "Ultorg", id = "com.ultorg.actionids.FieldsAction")
> @ActionRegistration(displayName = "#CTL_FieldsAction")
> @Messages("CTL_FieldsAction=Fields & Joins...")
> public class FieldsAction implements ActionListener {
>   private final ToolboxInvoker invoker;
>   public FieldsAction(ToolboxInvoker invoker) {
> Preconditions.checkNotNull(invoker);
> this.invoker = invoker;
>   }
>   @Override
>   public void actionPerformed(ActionEvent e) {
> invoker.invoke();
>   }
> }
> {code}
> The ToolboxInvoker context is provided by the lookup of a custom TopComponent 
> implementation. When I have multiple such TopComponent tabs open, switching 
> between them, and invoking the action above with a keyboard shortcut, the 
> wrong FieldsAction instance will occasionally be called (i.e. an instance 
> with the wrong ToolboxInvoker context).
> After some debugging, the problem seems to be caused by 
> https://github.com/apache/netbeans/pull/652 , specifically by 
> ContextAction.delegate0 assuming that instDelegate can be used as a cached 
> value without checking whether the lookup (data parameter) has changed. Or 
> perhaps instDelegate was supposed to be cleared elsewhere whenever the lookup 
> changes--but this is not happening properly.
> Because the instDelegate field holds only weak references, the buggy state 
> only lasts until the next garbage collection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4754) Action gets called with wrong context until garbage collection

2020-09-01 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188224#comment-17188224
 ] 

Eirik Bakke commented on NETBEANS-4754:
---

I tried clearing instDelegate at the beginning of 
ContextAction.Performer.delegate0 in my private NetBeans Platform build, and 
built my platform application against it (netbeans-4754-eiriktest.patch). This 
does appear to fix the bug--and action enablement reacts as expected in the 
toolbar as well.

Examining ContextAction.Performer, there seems to be two members, 
"StatefulMonitor enabler" and "PropertyChangeListener weakActionListener" that 
are never actually initialized. But there are methods that try to handle them: 
stopListeners, startListeners, and detached. Is this actually dead code that 
could just be removed?

Happy to try any other patch and confirm that the bug remains fixed.

> Action gets called with wrong context until garbage collection
> --
>
> Key: NETBEANS-4754
> URL: https://issues.apache.org/jira/browse/NETBEANS-4754
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Actions
>Affects Versions: 12.0
> Environment: NetBeans Platform application running on NetBeans 
> Platform 12.0 on Windows 10 / Java 13.0.2.
>Reporter: Eirik Bakke
>Assignee: Svatopluk Dedic
>Priority: Major
> Attachments: netbeans-4754-eiriktest.patch
>
>
> My NetBeans Platform application has an action declared as follows:
> {code:java}
> @ActionID(category = "Ultorg", id = "com.ultorg.actionids.FieldsAction")
> @ActionRegistration(displayName = "#CTL_FieldsAction")
> @Messages("CTL_FieldsAction=Fields & Joins...")
> public class FieldsAction implements ActionListener {
>   private final ToolboxInvoker invoker;
>   public FieldsAction(ToolboxInvoker invoker) {
> Preconditions.checkNotNull(invoker);
> this.invoker = invoker;
>   }
>   @Override
>   public void actionPerformed(ActionEvent e) {
> invoker.invoke();
>   }
> }
> {code}
> The ToolboxInvoker context is provided by the lookup of a custom TopComponent 
> implementation. When I have multiple such TopComponent tabs open, switching 
> between them, and invoking the action above with a keyboard shortcut, the 
> wrong FieldsAction instance will occasionally be called (i.e. an instance 
> with the wrong ToolboxInvoker context).
> After some debugging, the problem seems to be caused by 
> https://github.com/apache/netbeans/pull/652 , specifically by 
> ContextAction.delegate0 assuming that instDelegate can be used as a cached 
> value without checking whether the lookup (data parameter) has changed. Or 
> perhaps instDelegate was supposed to be cleared elsewhere whenever the lookup 
> changes--but this is not happening properly.
> Because the instDelegate field holds only weak references, the buggy state 
> only lasts until the next garbage collection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4754) Action gets called with wrong context until garbage collection

2020-09-01 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4754:
--
Attachment: netbeans-4754-eiriktest.patch

> Action gets called with wrong context until garbage collection
> --
>
> Key: NETBEANS-4754
> URL: https://issues.apache.org/jira/browse/NETBEANS-4754
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Actions
>Affects Versions: 12.0
> Environment: NetBeans Platform application running on NetBeans 
> Platform 12.0 on Windows 10 / Java 13.0.2.
>Reporter: Eirik Bakke
>Assignee: Svatopluk Dedic
>Priority: Major
> Attachments: netbeans-4754-eiriktest.patch
>
>
> My NetBeans Platform application has an action declared as follows:
> {code:java}
> @ActionID(category = "Ultorg", id = "com.ultorg.actionids.FieldsAction")
> @ActionRegistration(displayName = "#CTL_FieldsAction")
> @Messages("CTL_FieldsAction=Fields & Joins...")
> public class FieldsAction implements ActionListener {
>   private final ToolboxInvoker invoker;
>   public FieldsAction(ToolboxInvoker invoker) {
> Preconditions.checkNotNull(invoker);
> this.invoker = invoker;
>   }
>   @Override
>   public void actionPerformed(ActionEvent e) {
> invoker.invoke();
>   }
> }
> {code}
> The ToolboxInvoker context is provided by the lookup of a custom TopComponent 
> implementation. When I have multiple such TopComponent tabs open, switching 
> between them, and invoking the action above with a keyboard shortcut, the 
> wrong FieldsAction instance will occasionally be called (i.e. an instance 
> with the wrong ToolboxInvoker context).
> After some debugging, the problem seems to be caused by 
> https://github.com/apache/netbeans/pull/652 , specifically by 
> ContextAction.delegate0 assuming that instDelegate can be used as a cached 
> value without checking whether the lookup (data parameter) has changed. Or 
> perhaps instDelegate was supposed to be cleared elsewhere whenever the lookup 
> changes--but this is not happening properly.
> Because the instDelegate field holds only weak references, the buggy state 
> only lasts until the next garbage collection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4754) Action gets called with wrong context until garbage collection

2020-09-01 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4754:
--
Attachment: (was: netbeans-4754-eiriktest.patch)

> Action gets called with wrong context until garbage collection
> --
>
> Key: NETBEANS-4754
> URL: https://issues.apache.org/jira/browse/NETBEANS-4754
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Actions
>Affects Versions: 12.0
> Environment: NetBeans Platform application running on NetBeans 
> Platform 12.0 on Windows 10 / Java 13.0.2.
>Reporter: Eirik Bakke
>Assignee: Svatopluk Dedic
>Priority: Major
>
> My NetBeans Platform application has an action declared as follows:
> {code:java}
> @ActionID(category = "Ultorg", id = "com.ultorg.actionids.FieldsAction")
> @ActionRegistration(displayName = "#CTL_FieldsAction")
> @Messages("CTL_FieldsAction=Fields & Joins...")
> public class FieldsAction implements ActionListener {
>   private final ToolboxInvoker invoker;
>   public FieldsAction(ToolboxInvoker invoker) {
> Preconditions.checkNotNull(invoker);
> this.invoker = invoker;
>   }
>   @Override
>   public void actionPerformed(ActionEvent e) {
> invoker.invoke();
>   }
> }
> {code}
> The ToolboxInvoker context is provided by the lookup of a custom TopComponent 
> implementation. When I have multiple such TopComponent tabs open, switching 
> between them, and invoking the action above with a keyboard shortcut, the 
> wrong FieldsAction instance will occasionally be called (i.e. an instance 
> with the wrong ToolboxInvoker context).
> After some debugging, the problem seems to be caused by 
> https://github.com/apache/netbeans/pull/652 , specifically by 
> ContextAction.delegate0 assuming that instDelegate can be used as a cached 
> value without checking whether the lookup (data parameter) has changed. Or 
> perhaps instDelegate was supposed to be cleared elsewhere whenever the lookup 
> changes--but this is not happening properly.
> Because the instDelegate field holds only weak references, the buggy state 
> only lasts until the next garbage collection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4754) Action gets called with wrong context until garbage collection

2020-09-01 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4754:
--
Attachment: netbeans-4754-eiriktest.patch

> Action gets called with wrong context until garbage collection
> --
>
> Key: NETBEANS-4754
> URL: https://issues.apache.org/jira/browse/NETBEANS-4754
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Actions
>Affects Versions: 12.0
> Environment: NetBeans Platform application running on NetBeans 
> Platform 12.0 on Windows 10 / Java 13.0.2.
>Reporter: Eirik Bakke
>Assignee: Svatopluk Dedic
>Priority: Major
> Attachments: netbeans-4754-eiriktest.patch
>
>
> My NetBeans Platform application has an action declared as follows:
> {code:java}
> @ActionID(category = "Ultorg", id = "com.ultorg.actionids.FieldsAction")
> @ActionRegistration(displayName = "#CTL_FieldsAction")
> @Messages("CTL_FieldsAction=Fields & Joins...")
> public class FieldsAction implements ActionListener {
>   private final ToolboxInvoker invoker;
>   public FieldsAction(ToolboxInvoker invoker) {
> Preconditions.checkNotNull(invoker);
> this.invoker = invoker;
>   }
>   @Override
>   public void actionPerformed(ActionEvent e) {
> invoker.invoke();
>   }
> }
> {code}
> The ToolboxInvoker context is provided by the lookup of a custom TopComponent 
> implementation. When I have multiple such TopComponent tabs open, switching 
> between them, and invoking the action above with a keyboard shortcut, the 
> wrong FieldsAction instance will occasionally be called (i.e. an instance 
> with the wrong ToolboxInvoker context).
> After some debugging, the problem seems to be caused by 
> https://github.com/apache/netbeans/pull/652 , specifically by 
> ContextAction.delegate0 assuming that instDelegate can be used as a cached 
> value without checking whether the lookup (data parameter) has changed. Or 
> perhaps instDelegate was supposed to be cleared elsewhere whenever the lookup 
> changes--but this is not happening properly.
> Because the instDelegate field holds only weak references, the buggy state 
> only lasts until the next garbage collection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4754) Action gets called with wrong context until garbage collection

2020-08-31 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187970#comment-17187970
 ] 

Eirik Bakke commented on NETBEANS-4754:
---

That might be one way to fix it, but I don't understand the 
ContextManager/ContextAction code well enough to give an opinion here. Another 
question: Is it actually necessary to cache instDelegate here? Is the delegate0 
method expected to be called every time the context changes, or only when the 
user invokes the action?

> it's a job of the ctx aware instance to monitor the data changes
Which instance are you referring to here? Which class?

Another, possibly related problem: if you put the action in question in the 
toolbar, its enabled/disabled state does not update properly when focus is 
shifted from the TopComponent that provides the context object to, say, the 
"Files" sidebar tab. I'm not sure this would be fixed by making changes in 
delegate0.

It's been hard to debug this, as I can only reproduce the problem in my 
platform app, and not in a standalone NetBeans Platform application. There are 
a lot of weak references in this code (not just in instDelegate, but e.g. in 
ContextManager.LSet), which makes references come and go depending on when 
garbage collection is done.


> Action gets called with wrong context until garbage collection
> --
>
> Key: NETBEANS-4754
> URL: https://issues.apache.org/jira/browse/NETBEANS-4754
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Actions
>Affects Versions: 12.0
> Environment: NetBeans Platform application running on NetBeans 
> Platform 12.0 on Windows 10 / Java 13.0.2.
>Reporter: Eirik Bakke
>Assignee: Svatopluk Dedic
>Priority: Major
>
> My NetBeans Platform application has an action declared as follows:
> {code:java}
> @ActionID(category = "Ultorg", id = "com.ultorg.actionids.FieldsAction")
> @ActionRegistration(displayName = "#CTL_FieldsAction")
> @Messages("CTL_FieldsAction=Fields & Joins...")
> public class FieldsAction implements ActionListener {
>   private final ToolboxInvoker invoker;
>   public FieldsAction(ToolboxInvoker invoker) {
> Preconditions.checkNotNull(invoker);
> this.invoker = invoker;
>   }
>   @Override
>   public void actionPerformed(ActionEvent e) {
> invoker.invoke();
>   }
> }
> {code}
> The ToolboxInvoker context is provided by the lookup of a custom TopComponent 
> implementation. When I have multiple such TopComponent tabs open, switching 
> between them, and invoking the action above with a keyboard shortcut, the 
> wrong FieldsAction instance will occasionally be called (i.e. an instance 
> with the wrong ToolboxInvoker context).
> After some debugging, the problem seems to be caused by 
> https://github.com/apache/netbeans/pull/652 , specifically by 
> ContextAction.delegate0 assuming that instDelegate can be used as a cached 
> value without checking whether the lookup (data parameter) has changed. Or 
> perhaps instDelegate was supposed to be cleared elsewhere whenever the lookup 
> changes--but this is not happening properly.
> Because the instDelegate field holds only weak references, the buggy state 
> only lasts until the next garbage collection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4754) Action gets called with wrong context until garbage collection

2020-08-29 Thread Eirik Bakke (Jira)
Eirik Bakke created NETBEANS-4754:
-

 Summary: Action gets called with wrong context until garbage 
collection
 Key: NETBEANS-4754
 URL: https://issues.apache.org/jira/browse/NETBEANS-4754
 Project: NetBeans
  Issue Type: Bug
  Components: platform - Actions
Affects Versions: 12.0
 Environment: NetBeans Platform application running on NetBeans 
Platform 12.0 on Windows 10 / Java 13.0.2.
Reporter: Eirik Bakke


My NetBeans Platform application has an action declared as follows:

{code:java}
@ActionID(category = "Ultorg", id = "com.ultorg.actionids.FieldsAction")
@ActionRegistration(displayName = "#CTL_FieldsAction")
@Messages("CTL_FieldsAction=Fields & Joins...")
public class FieldsAction implements ActionListener {
  private final ToolboxInvoker invoker;

  public FieldsAction(ToolboxInvoker invoker) {
Preconditions.checkNotNull(invoker);
this.invoker = invoker;
  }

  @Override
  public void actionPerformed(ActionEvent e) {
invoker.invoke();
  }
}
{code}

The ToolboxInvoker context is provided by the lookup of a custom TopComponent 
implementation. When I have multiple such TopComponent tabs open, switching 
between them, and invoking the action above with a keyboard shortcut, the wrong 
FieldsAction instance will occasionally be called (i.e. an instance with the 
wrong ToolboxInvoker context).

After some debugging, the problem seems to be caused by 
https://github.com/apache/netbeans/pull/652 , specifically by 
ContextAction.delegate0 assuming that instDelegate can be used as a cached 
value without checking whether the lookup (data parameter) has changed. Or 
perhaps instDelegate was supposed to be cleared elsewhere whenever the lookup 
changes--but this is not happening properly.

Because the instDelegate field holds only weak references, the buggy state only 
lasts until the next garbage collection.






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-4095) NPE saving Java file with type error in for-each

2020-08-05 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171563#comment-17171563
 ] 

Eirik Bakke edited comment on NETBEANS-4095 at 8/5/20, 3:05 PM:


Great; thank you! Out of curiosity, is there a unit test for this case in 
nb-javac somewhere?


was (Author: ebakke):
Great--thank you! Out of curiosity--is there a unit test for this case in 
nb-javac somewhere?

> NPE saving Java file with type error in for-each
> 
>
> Key: NETBEANS-4095
> URL: https://issues.apache.org/jira/browse/NETBEANS-4095
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Source
>Affects Versions: 11.3
> Environment: Java 14, NetBeans with nbjavac plugin installed
>Reporter: Eirik Bakke
>Assignee: Arunava Sinha
>Priority: Major
>  Labels: nbjavac
> Fix For: 12.1
>
>
> If, during editing, a for-each loop appears with an incorrect pair of types, 
> an error dialog shows up showing a NullPointerException every time the Java 
> source file is saved, interrupting the user. A minimized example exhibiting 
> this behavior is as follows:
> {code:java}
> public final class CausesVisitIterableForeachLoopNPE {
>   public static final void main(String args[]) {
> final Map someMap = null;
> for (Object someVar : someMap) { }
>   }
> }
> {code}
> This example causes the IDE to throw the following exception:
> {noformat}
> java.lang.NullPointerException
>   at 
> com.sun.tools.javac.comp.Lower.visitIterableForeachLoop(Lower.java:3275)
>   at com.sun.tools.javac.comp.Lower.visitForeachLoop(Lower.java:3162)
>   at 
> com.sun.tools.javac.tree.JCTree$JCEnhancedForLoop.accept(JCTree.java:1176)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.Lower.translate(Lower.java:2080)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitBlock(TreeTranslator.java:167)
>   at com.sun.tools.javac.comp.Lower.visitBlock(Lower.java:3347)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1036)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.Lower.translate(Lower.java:2080)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitMethodDef(TreeTranslator.java:150)
>   at 
> com.sun.tools.javac.comp.Lower.visitMethodDefInternal(Lower.java:2538)
>   at com.sun.tools.javac.comp.Lower.visitMethodDef(Lower.java:2448)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:882)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.Lower.translate(Lower.java:2080)
>   at com.sun.tools.javac.comp.Lower.visitClassDef(Lower.java:2219)
>   at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:788)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.Lower.translate(Lower.java:2080)
>   at com.sun.tools.javac.comp.Lower.translate(Lower.java:2099)
>   at 
> com.sun.tools.javac.comp.Lower.translateTopLevelClass(Lower.java:3813)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1691)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1532)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:574)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:651)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:577)
> [catch] at 
> org.netbeans.modules.java.source.nbjavac.indexing.MultiPassCompileWorker.compile(MultiPassCompileWorker.java:303)
>   at 
> org.netbeans.modules.java.source.indexing.JavaCustomIndexer.index(JavaCustomIndexer.java:361)
>   at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor$2.run(Indexable.java:138)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runIndexer(RepositoryUpdater.java:275)
>   at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor.index(Indexable.java:136)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doIndex(RepositoryUpdater.java:2750)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.access$800(RepositoryUpdater.java:2154)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2636)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2634)
>   at 
> 

[jira] [Commented] (NETBEANS-4095) NPE saving Java file with type error in for-each

2020-08-05 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171563#comment-17171563
 ] 

Eirik Bakke commented on NETBEANS-4095:
---

Great--thank you! Out of curiosity--is there a unit test for this case in 
nb-javac somewhere?

> NPE saving Java file with type error in for-each
> 
>
> Key: NETBEANS-4095
> URL: https://issues.apache.org/jira/browse/NETBEANS-4095
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Source
>Affects Versions: 11.3
> Environment: Java 14, NetBeans with nbjavac plugin installed
>Reporter: Eirik Bakke
>Assignee: Arunava Sinha
>Priority: Major
>  Labels: nbjavac
> Fix For: 12.1
>
>
> If, during editing, a for-each loop appears with an incorrect pair of types, 
> an error dialog shows up showing a NullPointerException every time the Java 
> source file is saved, interrupting the user. A minimized example exhibiting 
> this behavior is as follows:
> {code:java}
> public final class CausesVisitIterableForeachLoopNPE {
>   public static final void main(String args[]) {
> final Map someMap = null;
> for (Object someVar : someMap) { }
>   }
> }
> {code}
> This example causes the IDE to throw the following exception:
> {noformat}
> java.lang.NullPointerException
>   at 
> com.sun.tools.javac.comp.Lower.visitIterableForeachLoop(Lower.java:3275)
>   at com.sun.tools.javac.comp.Lower.visitForeachLoop(Lower.java:3162)
>   at 
> com.sun.tools.javac.tree.JCTree$JCEnhancedForLoop.accept(JCTree.java:1176)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.Lower.translate(Lower.java:2080)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitBlock(TreeTranslator.java:167)
>   at com.sun.tools.javac.comp.Lower.visitBlock(Lower.java:3347)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1036)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.Lower.translate(Lower.java:2080)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitMethodDef(TreeTranslator.java:150)
>   at 
> com.sun.tools.javac.comp.Lower.visitMethodDefInternal(Lower.java:2538)
>   at com.sun.tools.javac.comp.Lower.visitMethodDef(Lower.java:2448)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:882)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.Lower.translate(Lower.java:2080)
>   at com.sun.tools.javac.comp.Lower.visitClassDef(Lower.java:2219)
>   at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:788)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.Lower.translate(Lower.java:2080)
>   at com.sun.tools.javac.comp.Lower.translate(Lower.java:2099)
>   at 
> com.sun.tools.javac.comp.Lower.translateTopLevelClass(Lower.java:3813)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1691)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1532)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:574)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:651)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:577)
> [catch] at 
> org.netbeans.modules.java.source.nbjavac.indexing.MultiPassCompileWorker.compile(MultiPassCompileWorker.java:303)
>   at 
> org.netbeans.modules.java.source.indexing.JavaCustomIndexer.index(JavaCustomIndexer.java:361)
>   at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor$2.run(Indexable.java:138)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runIndexer(RepositoryUpdater.java:275)
>   at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor.index(Indexable.java:136)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doIndex(RepositoryUpdater.java:2750)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.access$800(RepositoryUpdater.java:2154)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2636)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2634)
>   at 
> org.netbeans.modules.parsing.impl.indexing.errors.TaskCache.refreshTransaction(TaskCache.java:540)
>   at 
> 

[jira] [Resolved] (NETBEANS-4066) Inaccurate text measurement in editor tabs on HiDPI displays on Windows

2020-07-10 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke resolved NETBEANS-4066.
---
Fix Version/s: Next
   Resolution: Fixed

PR was merged; marking resolved.

> Inaccurate text measurement in editor tabs on HiDPI displays on Windows
> ---
>
> Key: NETBEANS-4066
> URL: https://issues.apache.org/jira/browse/NETBEANS-4066
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.3
> Environment: Windows 10 with HiDPI scaling enabled (e.g. 150% or 
> 200%--not necessarily fractional scalings only)
>Reporter: Eirik Bakke
>Priority: Minor
>  Labels: HiDPI
> Fix For: Next
>
> Attachments: Inaccurate tab text mesaurement.png
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Having fixed NETBEANS-2543, I see there is a similar issue in the NetBeans 
> tab component, e.g. in the editor tabs. On Windows 10, with HiDPI scaling 
> enabled on either 150% or 200% (for example), a tab title 
> "AaaiA" will overshoot its 
> allocated space. See the attached screenshot.
> Presumably this is another case where text measurement is done on a 
> FontRenderContext that hasn't properly had the appropriate monitor's HiDPI 
> scaling applied.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2360) HiDPI scaling not applied automatically on Linux

2020-06-27 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147031#comment-17147031
 ] 

Eirik Bakke commented on NETBEANS-2360:
---

Looking at the OpenJDK HiDPI implementation on Linux ( 
https://github.com/openjdk/jdk/blob/6bab0f539fba8fb441697846347597b4a0ade428/src/java.desktop/unix/native/common/awt/systemscale/systemScale.c
 ), there seems to be an attempt to get per-monitor scaling factors on GNOME 
via the "com.ubuntu.user-interface"/"scale-factor" setting. I don't have an 
Ubuntu machine to test on, though.

> HiDPI scaling not applied automatically on Linux
> 
>
> Key: NETBEANS-2360
> URL: https://issues.apache.org/jira/browse/NETBEANS-2360
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - LaunchersCLI
>Affects Versions: 11.0
> Environment: Kubuntu 18.03
> Oracle JDK 11.0.2
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI, Linux
> Attachments: kubunt.jpg
>
>
> Running NetBeans 11 on Kubuntu 18.03, GUI text size does not seem to take 
> into account the system's default HiDPI scaling. This was reported in a 
> Twitter thread on https://twitter.com/nicktail/status/1114789604337405952 . 
> Note that Window decorations seem to be the correct size.
> Setting the GDK_SCALE environment variable seems to fix the problem, if I 
> understand the originally reporter correctly. This could probably be done 
> easily from the NetBeans launcher script (netbeans/bin). But it wouldn't fix 
> the problem in multi-monitor setups. We should investigate what could be done 
> to make scaling work properly in multi-monitor setups involving one HiDPI 
> screen and one non-HiDPI screen.
> Before merging a patch to the launcher script, it should be tested on a 
> couple of different Linux environments, using both HiDPI and non-HiDPI 
> screens. Note that the UNIX launcher script is also used on MacOS.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4063) Application Hang

2020-06-22 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142224#comment-17142224
 ] 

Eirik Bakke commented on NETBEANS-4063:
---

Have you experienced this more than once?

The next time it occurs, can you see if pressing Alt+Shift+Enter twice will 
un-freeze the IDE? (This enters and exits Full Screen mode, resetting some 
window state.)

> Application Hang
> 
>
> Key: NETBEANS-4063
> URL: https://issues.apache.org/jira/browse/NETBEANS-4063
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 11.3
> Environment: Windows 10 x64
> Laptop connected to two external monitors via Targus DisplayLink dock
>Reporter: Jim Stack
>Priority: Major
> Attachments: IDE.log, UI.log, image-2020-03-24-09-17-55-321.png
>
>
> I left NetBeans open overnight after completing my work. My power settings 
> are set to turn off screens after 10 minutes of inactivity but to never go to 
> sleep. When I sat down to resume work in the morning, my NetBeans windows 
> were unresponsive. I had three windows open across two monitors. UI and IDE 
> logs are attached. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-4367) DEFAULT_CACHEDIR_ROOT not propagating to platform application (Linux and MacOS)

2020-06-22 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke resolved NETBEANS-4367.
---
Fix Version/s: 12.1
   Resolution: Fixed

PR was merged; marking as resolved.

> DEFAULT_CACHEDIR_ROOT not propagating to platform application (Linux and 
> MacOS)
> ---
>
> Key: NETBEANS-4367
> URL: https://issues.apache.org/jira/browse/NETBEANS-4367
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - LaunchersCLI
>Affects Versions: 11.3
> Environment: NetBeans Platform applications on MacOS or Linux.
>Reporter: Eirik Bakke
>Priority: Major
> Fix For: 12.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> (The following issue description pasted from Patrik Karlström's email to 
> d...@netbeans.apache.org on 2020-05-23. Eirik Bakke had the same issue in his 
> NetBeans platform application, and has a patch ready.)
> The following is done with NB Platform 11.3 and Java 11 on Kubuntu 20.04.
> While I was about to use the cache dir logic provided by the platform I ran 
> into this problem.
> My cache dir is in
> ${HOME}/.${APPNAME}/var/cache
> and not as expected,
> ${HOME}/.cache/${APPNAME}
> The app.conf contains
> default_userdir="${DEFAULT_USERDIR_ROOT}/dev"
> default_cachedir="${DEFAULT_CACHEDIR_ROOT}/dev"
> Did some echoing in the bin/appname and DEFAULT_CACHEDIR_ROOT was set ok, but 
> not picked up by the application.
> When specifying --cachedir it gets picked up by the application.
> I created a simple testapp and this problem is there too.
> So I guess the question is, Is this related to my doing or the platform?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3870) Smooth scrolling for FlatLaF inside the editor is hacky/lacky

2020-06-13 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134859#comment-17134859
 ] 

Eirik Bakke commented on NETBEANS-3870:
---

[~chrizzly] This patch seems to apply to the editor code rather than a specific 
LAF, so I think it should already work for all LAFs.

Feel free to add an issue for tab scrolling--I didn't even know you could do 
that!

> Smooth scrolling for FlatLaF inside the editor is hacky/lacky
> -
>
> Key: NETBEANS-3870
> URL: https://issues.apache.org/jira/browse/NETBEANS-3870
> Project: NetBeans
>  Issue Type: Improvement
>  Components: FlatLaf, ide - UI
>Affects Versions: 11.3
> Environment: Product Version: Apache NetBeans IDE 11.3-beta2
> Updates: Updates available to version NetBeans 8.2 Patch 2
> Java: 11.0.2; Java HotSpot(TM) 64-Bit Server VM 11.0.2+9-LTS
> Runtime: Java(TM) SE Runtime Environment 11.0.2+9-LTS
> System: Windows 10 version 10.0 running on amd64; Cp1252; de_DE (nb)
> User directory: C:\Users\Chrl\AppData\Roaming\NetBeans\11.3-beta2
> Cache directory: C:\Users\Chrl\AppData\Local\NetBeans\Cache\11.3-beta2
>Reporter: Christian Lenz
>Assignee: Karl Tauber
>Priority: Major
>  Labels: pull-request-available
> Fix For: 12.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I use the latest 11.3 beta 2 with the new Flat LaF. The smooth scrolling 
> works perfect inside of those UI elements:
> - Navigator
> - Options (tested with Editor and Team tab)
> - Project View
> - Files View 
> - Services View
> But the smooth scrolling is hacky/lacky in the editor. I use Windows 10 64 
> bit with a Surface Book and the touchpad on it, no extra mouse.
> We can make a skype session or I will try to make a little video, a 
> screencapture (gif) will not work well here. I already commented about the 
> problem here: https://issues.apache.org/jira/browse/NETBEANS-49. The problem 
> happens with the implementation of [~ebakke] for the default NetBeans LaF.
> Please let me know, what you need from my site :)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-1901) Font rendering issue - Display bug on a space followed by a tab

2020-06-13 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-1901:
--
Labels: HiDPI editor formatting  (was: editor formatting)

> Font rendering issue - Display bug on a space followed by a tab
> ---
>
> Key: NETBEANS-1901
> URL: https://issues.apache.org/jira/browse/NETBEANS-1901
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Painting  Printing
>Affects Versions: 10.0, 11.0, 11.1
> Environment: Windows 10, MacOS High Sierra & MacOS Mojave
> Netbeans 10, Netbeans 11 & Netbeans 11.1
> JRE 11 & 12
>Reporter: Admeen
>Priority: Minor
>  Labels: HiDPI, editor, formatting
> Fix For: 12.0
>
> Attachments: 20190319_actual_result.png, 20190319_example_code.php, 
> 20190319_expected_result.png, 20190320_syntax_settings.png, 
> editor_bug_space_tab.png, formatting_settings.png, netbeans-1901-jy-01.png, 
> netbeans-1901-jy-02.png
>
>
> There appears to be a bug in the editor when a space is followed by a tab. 
> The editor does not display the space and tab, but the space and tab 
> characters are present in the file.
> The editor / code formatting does not appear to be functioning correctly here.
> UPDATE:
> In the tab "Fonts & Colors" in the "Syntax" subtab I had the "default" font 
> set to "Monospaced 16". The issue occurs when using this font size. When I 
> change it back to the default value "Monospaced 13" or "Monospaced 18" it 
> works just fine. After some more testing I found out that with the font set 
> to "Monospaced 10, 11, 12, 14, 15, 16, 17, 19 & 20" it does not work (didn't 
> test higher or lower values).
> UPDATE 2:
> The issue persists in Netbeans version 11.1 now with JRE 12.0.2 installed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1901) Font rendering issue - Display bug on a space followed by a tab

2020-06-13 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134858#comment-17134858
 ] 

Eirik Bakke commented on NETBEANS-1901:
---

Great--thank you!

> Font rendering issue - Display bug on a space followed by a tab
> ---
>
> Key: NETBEANS-1901
> URL: https://issues.apache.org/jira/browse/NETBEANS-1901
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Painting  Printing
>Affects Versions: 10.0, 11.0, 11.1
> Environment: Windows 10, MacOS High Sierra & MacOS Mojave
> Netbeans 10, Netbeans 11 & Netbeans 11.1
> JRE 11 & 12
>Reporter: Admeen
>Priority: Minor
>  Labels: editor, formatting
> Fix For: 12.0
>
> Attachments: 20190319_actual_result.png, 20190319_example_code.php, 
> 20190319_expected_result.png, 20190320_syntax_settings.png, 
> editor_bug_space_tab.png, formatting_settings.png, netbeans-1901-jy-01.png, 
> netbeans-1901-jy-02.png
>
>
> There appears to be a bug in the editor when a space is followed by a tab. 
> The editor does not display the space and tab, but the space and tab 
> characters are present in the file.
> The editor / code formatting does not appear to be functioning correctly here.
> UPDATE:
> In the tab "Fonts & Colors" in the "Syntax" subtab I had the "default" font 
> set to "Monospaced 16". The issue occurs when using this font size. When I 
> change it back to the default value "Monospaced 13" or "Monospaced 18" it 
> works just fine. After some more testing I found out that with the font set 
> to "Monospaced 10, 11, 12, 14, 15, 16, 17, 19 & 20" it does not work (didn't 
> test higher or lower values).
> UPDATE 2:
> The issue persists in Netbeans version 11.1 now with JRE 12.0.2 installed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3870) Smooth scrolling for FlatLaF inside the editor is hacky/lacky

2020-06-10 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130951#comment-17130951
 ] 

Eirik Bakke commented on NETBEANS-3870:
---

Great work! [~chrizzly] did this solve the old problems you said remained in 
https://issues.apache.org/jira/browse/NETBEANS-49 ?

> Smooth scrolling for FlatLaF inside the editor is hacky/lacky
> -
>
> Key: NETBEANS-3870
> URL: https://issues.apache.org/jira/browse/NETBEANS-3870
> Project: NetBeans
>  Issue Type: Improvement
>  Components: FlatLaf, ide - UI
>Affects Versions: 11.3
> Environment: Product Version: Apache NetBeans IDE 11.3-beta2
> Updates: Updates available to version NetBeans 8.2 Patch 2
> Java: 11.0.2; Java HotSpot(TM) 64-Bit Server VM 11.0.2+9-LTS
> Runtime: Java(TM) SE Runtime Environment 11.0.2+9-LTS
> System: Windows 10 version 10.0 running on amd64; Cp1252; de_DE (nb)
> User directory: C:\Users\Chrl\AppData\Roaming\NetBeans\11.3-beta2
> Cache directory: C:\Users\Chrl\AppData\Local\NetBeans\Cache\11.3-beta2
>Reporter: Christian Lenz
>Assignee: Karl Tauber
>Priority: Major
>  Labels: pull-request-available
> Fix For: 12.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I use the latest 11.3 beta 2 with the new Flat LaF. The smooth scrolling 
> works perfect inside of those UI elements:
> - Navigator
> - Options (tested with Editor and Team tab)
> - Project View
> - Files View 
> - Services View
> But the smooth scrolling is hacky/lacky in the editor. I use Windows 10 64 
> bit with a Surface Book and the touchpad on it, no extra mouse.
> We can make a skype session or I will try to make a little video, a 
> screencapture (gif) will not work well here. I already commented about the 
> problem here: https://issues.apache.org/jira/browse/NETBEANS-49. The problem 
> happens with the implementation of [~ebakke] for the default NetBeans LaF.
> Please let me know, what you need from my site :)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4066) Inaccurate text measurement in editor tabs on HiDPI displays on Windows

2020-06-04 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126363#comment-17126363
 ] 

Eirik Bakke commented on NETBEANS-4066:
---

Pull request available at https://github.com/apache/netbeans/pull/2167

> Inaccurate text measurement in editor tabs on HiDPI displays on Windows
> ---
>
> Key: NETBEANS-4066
> URL: https://issues.apache.org/jira/browse/NETBEANS-4066
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.3
> Environment: Windows 10 with HiDPI scaling enabled (e.g. 150% or 
> 200%--not necessarily fractional scalings only)
>Reporter: Eirik Bakke
>Priority: Minor
>  Labels: HiDPI
> Attachments: Inaccurate tab text mesaurement.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Having fixed NETBEANS-2543, I see there is a similar issue in the NetBeans 
> tab component, e.g. in the editor tabs. On Windows 10, with HiDPI scaling 
> enabled on either 150% or 200% (for example), a tab title 
> "AaaiA" will overshoot its 
> allocated space. See the attached screenshot.
> Presumably this is another case where text measurement is done on a 
> FontRenderContext that hasn't properly had the appropriate monitor's HiDPI 
> scaling applied.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4367) DEFAULT_CACHEDIR_ROOT not propagating to platform application (Linux and MacOS)

2020-06-04 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126259#comment-17126259
 ] 

Eirik Bakke commented on NETBEANS-4367:
---

PR available at https://github.com/apache/netbeans/pull/2153

> DEFAULT_CACHEDIR_ROOT not propagating to platform application (Linux and 
> MacOS)
> ---
>
> Key: NETBEANS-4367
> URL: https://issues.apache.org/jira/browse/NETBEANS-4367
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - LaunchersCLI
>Affects Versions: 11.3
> Environment: NetBeans Platform applications on MacOS or Linux.
>Reporter: Eirik Bakke
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> (The following issue description pasted from Patrik Karlström's email to 
> d...@netbeans.apache.org on 2020-05-23. Eirik Bakke had the same issue in his 
> NetBeans platform application, and has a patch ready.)
> The following is done with NB Platform 11.3 and Java 11 on Kubuntu 20.04.
> While I was about to use the cache dir logic provided by the platform I ran 
> into this problem.
> My cache dir is in
> ${HOME}/.${APPNAME}/var/cache
> and not as expected,
> ${HOME}/.cache/${APPNAME}
> The app.conf contains
> default_userdir="${DEFAULT_USERDIR_ROOT}/dev"
> default_cachedir="${DEFAULT_CACHEDIR_ROOT}/dev"
> Did some echoing in the bin/appname and DEFAULT_CACHEDIR_ROOT was set ok, but 
> not picked up by the application.
> When specifying --cachedir it gets picked up by the application.
> I created a simple testapp and this problem is there too.
> So I guess the question is, Is this related to my doing or the platform?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4403) Toolbar buttons get weird borders on FlatLAF

2020-06-03 Thread Eirik Bakke (Jira)
Eirik Bakke created NETBEANS-4403:
-

 Summary: Toolbar buttons get weird borders on FlatLAF
 Key: NETBEANS-4403
 URL: https://issues.apache.org/jira/browse/NETBEANS-4403
 Project: NetBeans
  Issue Type: Bug
  Components: ide - UI
Affects Versions: 11.3
 Environment: FlatLAF dark or light on Windows or Linux
Reporter: Eirik Bakke
 Attachments: darkNormal.png, darkProblem.png, lightNormal.png, 
lightProblem.png

Users on the mailing list report toolbar buttons intermittently being painted 
with unwanted borders (see "[11.3 FlatLaf] Weird Toolbar Icon" email thread). I 
have attached their screenshots here.

Bilu Al: "this happens sometimes like 2 times out of 5 at the start. And 
sometimes when restarting it is back again at normal without doing anything"

Juan Algaba: "I have the same problem 7 times out of 10."



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2494) autocomplete deletes instead of completes

2020-06-01 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121268#comment-17121268
 ] 

Eirik Bakke commented on NETBEANS-2494:
---

Here's another test case that provokes this stack trace:

{code:java}
public final class AutoCompletionBugExhibit {
  public void someMethod() {
Object foo1, foo2, foo3, foo4, foo5, foo6, foo7;
/* BUG: Place the cursor before the semicolon, press control+space to open 
autocomplete, and
press enter to fill in the constructor. An AssertionError in 
com.sun.tools.javac will
result. */
String tableForPrimary = new ;
  }
}
{code}

The problem seems to occur whenever a certain minimum number of variables are 
in scope to be considered as arguments to the constructor.

> autocomplete deletes instead of completes
> -
>
> Key: NETBEANS-2494
> URL: https://issues.apache.org/jira/browse/NETBEANS-2494
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 11.0
> Environment: OS X 10.14.3 (18D109)
> Java 1.8.0_181
> Product Version: Apache NetBeans IDE 11.0 (Build 
> incubator-netbeans-release-404-on-20190319)
> Java: 1.8.0_181; Java HotSpot(TM) 64-Bit Server VM 25.181-b13
> Runtime: Java(TM) SE Runtime Environment 1.8.0_181-b13
> System: Mac OS X version 10.14.3 running on x86_64; UTF-8; en_US (nb)
> User directory: ~/Library/Application Support/NetBeans/11.0
> Cache directory: ~/Library/Caches/NetBeans/11.0
>Reporter: Paul
>Priority: Critical
> Attachments: Test.java
>
>
> easily reproducible (on Mac anyway).
> In any java class, inside method body type this:
>  
> OutputStream os = new ByteArra
> then press Ctrl-Space, press down-cursor to go to 
> java.io.ByteArrayOutputStream constructor., press Enter.
> Instead of completing as requestedor offering user input to choose what to 
> actually put there, NB11 deletes the new ByteArra.
> The only way to get it to actually complete is mouse-click.
> Super-long time NB user here - grew accustomed to a pleasurable dev 
> experience, and loss of this functionality is so taxing it's worth just using 
> Eclipse at this point.
>  
> Looking forward to a fix
>  
> Related: NETBEANS-2490



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-2978) Assertion error in code completion in Java code

2020-06-01 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke resolved NETBEANS-2978.
---
Resolution: Duplicate

Marking as duplicate of NETBEANS-2494, which has the same stack trace, since 
there's already some discussion of the bug there.

> Assertion error in code completion in Java code
> ---
>
> Key: NETBEANS-2978
> URL: https://issues.apache.org/jira/browse/NETBEANS-2978
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 11.1, 11.2, 11.3
>Reporter: Petr Miksik
>Priority: Critical
>  Labels: autocomplete, autocompletion, codecompletion, nbjavac
> Attachments: ide.log
>
>
> The exception occurs after selecting an item from the provided "Code 
> completion" list and nothing is inserted into code. 
> How to reproduce:
> {noformat}
> public class XXX {
> private static class CellRenderer implements TableCellRenderer {
> @Override
> public Component getTableCellRendererComponent(JTable table, Object 
> value, boolean isSelected, boolean hasFocus, int row, int column) {
> JLabel result = new JLabel <-- code completion fails here
> JLabel result2 = new JLabel <-- it works on this line already. 
> Only the first line is not working
> }
> }
> }
> {noformat}
> {noformat}
> java.lang.AssertionError
>   at com.sun.tools.javac.util.Assert.error(Assert.java:155)
>   at com.sun.tools.javac.util.Assert.check(Assert.java:46)
>   at com.sun.tools.javac.code.Scope$ScopeImpl.dble(Scope.java:410)
>   at com.sun.tools.javac.code.Scope$ScopeImpl.enter(Scope.java:433)
>   at 
> com.sun.tools.javac.comp.MemberEnter.visitVarDef(MemberEnter.java:480)
>   at 
> com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:972)
>   at 
> com.sun.tools.javac.comp.MemberEnter.memberEnter(MemberEnter.java:172)
>   at com.sun.tools.javac.comp.Attr.visitVarDef(Attr.java:1191)
>   at 
> com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:972)
>   at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:674)
>   at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:754)
>   at com.sun.tools.javac.comp.Attr.attribStats(Attr.java:778)
>   at com.sun.tools.javac.comp.Attr.visitBlock(Attr.java:1357)
>   at org.netbeans.lib.nbjavac.services.NBAttr.visitBlock(NBAttr.java:78)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1036)
>   at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:674)
>   at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:754)
>   at 
> org.netbeans.api.java.source.TreeUtilities.attributeTree(TreeUtilities.java:892)
>   at 
> org.netbeans.api.java.source.TreeUtilities.attributeTree(TreeUtilities.java:822)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.type(JavaCodeTemplateProcessor.java:718)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.getProposedValue(JavaCodeTemplateProcessor.java:433)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.updateDefaultValues(JavaCodeTemplateProcessor.java:145)
>   at 
> org.netbeans.lib.editor.codetemplates.CodeTemplateInsertHandler.processTemplate(CodeTemplateInsertHandler.java:225)
>   at 
> org.netbeans.lib.editor.codetemplates.CodeTemplateManagerOperation.insert(CodeTemplateManagerOperation.java:273)
>   at 
> org.netbeans.lib.editor.codetemplates.api.CodeTemplate.insert(CodeTemplate.java:82)
>   at 
> org.netbeans.modules.editor.java.JavaCompletionItem.process(JavaCompletionItem.java:570)
>   at 
> org.netbeans.modules.editor.java.JavaCompletionItem.defaultAction(JavaCompletionItem.java:290)
>   at 
> org.netbeans.modules.editor.completion.CompletionImpl.dispatchKeyEvent(CompletionImpl.java:785)
>   at 
> org.netbeans.modules.editor.completion.CompletionImpl.keyPressed(CompletionImpl.java:386)
>   at 
> java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:258)
>   at 
> java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:257)
>   at 
> java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:257)
>   at java.desktop/java.awt.Component.processKeyEvent(Component.java:6590)
>   at 
> java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2849)
>   at java.desktop/java.awt.Component.processEvent(Component.java:6409)
>   at java.desktop/java.awt.Container.processEvent(Container.java:2263)
>   at 
> java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5008)
>   at 
> java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
>   at 

[jira] [Resolved] (NETBEANS-4193) Intellisense doesn't type selected code to editor

2020-06-01 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke resolved NETBEANS-4193.
---
Resolution: Duplicate

Consolidate likely duplicates with similar stack trace.

> Intellisense  doesn't type selected code to editor
> --
>
> Key: NETBEANS-4193
> URL: https://issues.apache.org/jira/browse/NETBEANS-4193
> Project: NetBeans
>  Issue Type: Bug
> Environment: windows 10 64 bit
>Reporter: heldy
>Priority: Major
>
> Intellisense  doesn't type selected code to editor
> SEVERE [global]
> java.lang.AssertionError
>  at com.sun.tools.javac.util.Assert.error(Assert.java:155)
>  at com.sun.tools.javac.util.Assert.check(Assert.java:46)
>  at com.sun.tools.javac.code.Scope$ScopeImpl.dble(Scope.java:410)
>  at com.sun.tools.javac.code.Scope$ScopeImpl.enter(Scope.java:433)
>  at com.sun.tools.javac.comp.MemberEnter.visitVarDef(MemberEnter.java:480)
>  at 
> com.sun.tools.javadoc.main.JavadocMemberEnter.visitVarDef(JavadocMemberEnter.java:84)
>  at 
> org.netbeans.lib.nbjavac.services.NBJavadocMemberEnter.visitVarDef(NBJavadocMemberEnter.java:92)
>  at com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:968)
>  at com.sun.tools.javac.comp.MemberEnter.memberEnter(MemberEnter.java:172)
>  at com.sun.tools.javac.comp.Attr.visitVarDef(Attr.java:1187)
>  at com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:968)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:672)
>  at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:752)
>  at com.sun.tools.javac.comp.Attr.attribStats(Attr.java:776)
>  at com.sun.tools.javac.comp.Attr.visitBlock(Attr.java:1353)
>  at org.netbeans.lib.nbjavac.services.NBAttr.visitBlock(NBAttr.java:78)
>  at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1032)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:672)
>  at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:752)
>  at 
> org.netbeans.api.java.source.TreeUtilities.attributeTree(TreeUtilities.java:880)
>  at 
> org.netbeans.api.java.source.TreeUtilities.attributeTree(TreeUtilities.java:810)
>  at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.type(JavaCodeTemplateProcessor.java:716)
>  at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.getProposedValue(JavaCodeTemplateProcessor.java:431)
>  at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.updateDefaultValues(JavaCodeTemplateProcessor.java:143)
>  at 
> org.netbeans.lib.editor.codetemplates.CodeTemplateInsertHandler.processTemplate(CodeTemplateInsertHandler.java:225)
>  at 
> org.netbeans.lib.editor.codetemplates.CodeTemplateManagerOperation.insert(CodeTemplateManagerOperation.java:273)
>  at 
> org.netbeans.lib.editor.codetemplates.api.CodeTemplate.insert(CodeTemplate.java:82)
>  at 
> org.netbeans.modules.editor.java.JavaCompletionItem.process(JavaCompletionItem.java:566)
>  at 
> org.netbeans.modules.editor.java.JavaCompletionItem.defaultAction(JavaCompletionItem.java:286)
>  at 
> org.netbeans.modules.editor.completion.CompletionImpl.dispatchKeyEvent(CompletionImpl.java:785)
>  at 
> org.netbeans.modules.editor.completion.CompletionImpl.keyPressed(CompletionImpl.java:386)
>  at java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:250)
>  at java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:249)
>  at java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:249)
>  at java.awt.Component.processKeyEvent(Component.java:6497)
>  at javax.swing.JComponent.processKeyEvent(JComponent.java:2832)
>  at java.awt.Component.processEvent(Component.java:6316)
>  at java.awt.Container.processEvent(Container.java:2239)
>  at java.awt.Component.dispatchEventImpl(Component.java:4889)
>  at java.awt.Container.dispatchEventImpl(Container.java:2297)
>  at java.awt.Component.dispatchEvent(Component.java:4711)
>  at 
> java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1954)
>  at 
> java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:835)
>  at 
> java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1103)
>  at 
> java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:974)
>  at 
> java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:800)
>  at java.awt.Component.dispatchEventImpl(Component.java:4760)
>  at java.awt.Container.dispatchEventImpl(Container.java:2297)
>  at java.awt.Window.dispatchEventImpl(Window.java:2746)
>  at java.awt.Component.dispatchEvent(Component.java:4711)
>  at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760)
>  at java.awt.EventQueue.access$500(EventQueue.java:97)
>  at java.awt.EventQueue$3.run(EventQueue.java:709)
>  at 

[jira] [Updated] (NETBEANS-2978) Assertion error in code completion in Java code

2020-06-01 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2978:
--
Priority: Critical  (was: Major)

> Assertion error in code completion in Java code
> ---
>
> Key: NETBEANS-2978
> URL: https://issues.apache.org/jira/browse/NETBEANS-2978
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 11.1, 11.2, 11.3
>Reporter: Petr Miksik
>Priority: Critical
>  Labels: autocomplete, autocompletion, codecompletion, nbjavac
> Attachments: ide.log
>
>
> The exception occurs after selecting an item from the provided "Code 
> completion" list and nothing is inserted into code. 
> How to reproduce:
> {noformat}
> public class XXX {
> private static class CellRenderer implements TableCellRenderer {
> @Override
> public Component getTableCellRendererComponent(JTable table, Object 
> value, boolean isSelected, boolean hasFocus, int row, int column) {
> JLabel result = new JLabel <-- code completion fails here
> JLabel result2 = new JLabel <-- it works on this line already. 
> Only the first line is not working
> }
> }
> }
> {noformat}
> {noformat}
> java.lang.AssertionError
>   at com.sun.tools.javac.util.Assert.error(Assert.java:155)
>   at com.sun.tools.javac.util.Assert.check(Assert.java:46)
>   at com.sun.tools.javac.code.Scope$ScopeImpl.dble(Scope.java:410)
>   at com.sun.tools.javac.code.Scope$ScopeImpl.enter(Scope.java:433)
>   at 
> com.sun.tools.javac.comp.MemberEnter.visitVarDef(MemberEnter.java:480)
>   at 
> com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:972)
>   at 
> com.sun.tools.javac.comp.MemberEnter.memberEnter(MemberEnter.java:172)
>   at com.sun.tools.javac.comp.Attr.visitVarDef(Attr.java:1191)
>   at 
> com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:972)
>   at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:674)
>   at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:754)
>   at com.sun.tools.javac.comp.Attr.attribStats(Attr.java:778)
>   at com.sun.tools.javac.comp.Attr.visitBlock(Attr.java:1357)
>   at org.netbeans.lib.nbjavac.services.NBAttr.visitBlock(NBAttr.java:78)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1036)
>   at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:674)
>   at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:754)
>   at 
> org.netbeans.api.java.source.TreeUtilities.attributeTree(TreeUtilities.java:892)
>   at 
> org.netbeans.api.java.source.TreeUtilities.attributeTree(TreeUtilities.java:822)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.type(JavaCodeTemplateProcessor.java:718)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.getProposedValue(JavaCodeTemplateProcessor.java:433)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.updateDefaultValues(JavaCodeTemplateProcessor.java:145)
>   at 
> org.netbeans.lib.editor.codetemplates.CodeTemplateInsertHandler.processTemplate(CodeTemplateInsertHandler.java:225)
>   at 
> org.netbeans.lib.editor.codetemplates.CodeTemplateManagerOperation.insert(CodeTemplateManagerOperation.java:273)
>   at 
> org.netbeans.lib.editor.codetemplates.api.CodeTemplate.insert(CodeTemplate.java:82)
>   at 
> org.netbeans.modules.editor.java.JavaCompletionItem.process(JavaCompletionItem.java:570)
>   at 
> org.netbeans.modules.editor.java.JavaCompletionItem.defaultAction(JavaCompletionItem.java:290)
>   at 
> org.netbeans.modules.editor.completion.CompletionImpl.dispatchKeyEvent(CompletionImpl.java:785)
>   at 
> org.netbeans.modules.editor.completion.CompletionImpl.keyPressed(CompletionImpl.java:386)
>   at 
> java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:258)
>   at 
> java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:257)
>   at 
> java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:257)
>   at java.desktop/java.awt.Component.processKeyEvent(Component.java:6590)
>   at 
> java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2849)
>   at java.desktop/java.awt.Component.processEvent(Component.java:6409)
>   at java.desktop/java.awt.Container.processEvent(Container.java:2263)
>   at 
> java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5008)
>   at 
> java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
>   at java.desktop/java.awt.Component.dispatchEvent(Component.java:4840)
>   at 
> 

[jira] [Commented] (NETBEANS-2978) Assertion error in code completion in Java code

2020-06-01 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121256#comment-17121256
 ] 

Eirik Bakke commented on NETBEANS-2978:
---

This bug is easy to reproduce, and has a lot of duplicates (search JIRA for 
"ScopeImpl.dble"). Here's an even simpler exhibit that causes the same stack 
trace:

{code:java}
public final class AutoCompletionBugExhibit {
  public void someMethod() {
Object foo1, foo2, foo3, foo4, foo5, foo6, foo7;
/* BUG: Place the cursor before the semicolon, press control+space to open 
autocomplete, and
press enter to fill in the constructor. An AssertionError in 
com.sun.tools.javac will
result. */
String tableForPrimary = new ;
  }
}
{code}

The problem seems to occur whenever a certain minimum number of variables are 
in scope to be considered as arguments to the constructor.

> Assertion error in code completion in Java code
> ---
>
> Key: NETBEANS-2978
> URL: https://issues.apache.org/jira/browse/NETBEANS-2978
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 11.1, 11.2, 11.3
>Reporter: Petr Miksik
>Priority: Major
>  Labels: autocomplete, autocompletion, codecompletion, nbjavac
> Attachments: ide.log
>
>
> The exception occurs after selecting an item from the provided "Code 
> completion" list and nothing is inserted into code. 
> How to reproduce:
> {noformat}
> public class XXX {
> private static class CellRenderer implements TableCellRenderer {
> @Override
> public Component getTableCellRendererComponent(JTable table, Object 
> value, boolean isSelected, boolean hasFocus, int row, int column) {
> JLabel result = new JLabel <-- code completion fails here
> JLabel result2 = new JLabel <-- it works on this line already. 
> Only the first line is not working
> }
> }
> }
> {noformat}
> {noformat}
> java.lang.AssertionError
>   at com.sun.tools.javac.util.Assert.error(Assert.java:155)
>   at com.sun.tools.javac.util.Assert.check(Assert.java:46)
>   at com.sun.tools.javac.code.Scope$ScopeImpl.dble(Scope.java:410)
>   at com.sun.tools.javac.code.Scope$ScopeImpl.enter(Scope.java:433)
>   at 
> com.sun.tools.javac.comp.MemberEnter.visitVarDef(MemberEnter.java:480)
>   at 
> com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:972)
>   at 
> com.sun.tools.javac.comp.MemberEnter.memberEnter(MemberEnter.java:172)
>   at com.sun.tools.javac.comp.Attr.visitVarDef(Attr.java:1191)
>   at 
> com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:972)
>   at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:674)
>   at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:754)
>   at com.sun.tools.javac.comp.Attr.attribStats(Attr.java:778)
>   at com.sun.tools.javac.comp.Attr.visitBlock(Attr.java:1357)
>   at org.netbeans.lib.nbjavac.services.NBAttr.visitBlock(NBAttr.java:78)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1036)
>   at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:674)
>   at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:754)
>   at 
> org.netbeans.api.java.source.TreeUtilities.attributeTree(TreeUtilities.java:892)
>   at 
> org.netbeans.api.java.source.TreeUtilities.attributeTree(TreeUtilities.java:822)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.type(JavaCodeTemplateProcessor.java:718)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.getProposedValue(JavaCodeTemplateProcessor.java:433)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.updateDefaultValues(JavaCodeTemplateProcessor.java:145)
>   at 
> org.netbeans.lib.editor.codetemplates.CodeTemplateInsertHandler.processTemplate(CodeTemplateInsertHandler.java:225)
>   at 
> org.netbeans.lib.editor.codetemplates.CodeTemplateManagerOperation.insert(CodeTemplateManagerOperation.java:273)
>   at 
> org.netbeans.lib.editor.codetemplates.api.CodeTemplate.insert(CodeTemplate.java:82)
>   at 
> org.netbeans.modules.editor.java.JavaCompletionItem.process(JavaCompletionItem.java:570)
>   at 
> org.netbeans.modules.editor.java.JavaCompletionItem.defaultAction(JavaCompletionItem.java:290)
>   at 
> org.netbeans.modules.editor.completion.CompletionImpl.dispatchKeyEvent(CompletionImpl.java:785)
>   at 
> org.netbeans.modules.editor.completion.CompletionImpl.keyPressed(CompletionImpl.java:386)
>   at 
> java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:258)
>   at 
> java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:257)
>   at 
> 

[jira] [Updated] (NETBEANS-2978) Assertion error in code completion in Java code

2020-06-01 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-2978:
--
Labels: autocomplete autocompletion codecompletion nbjavac  (was: 
autocomplete autocompletion codecompletion)

> Assertion error in code completion in Java code
> ---
>
> Key: NETBEANS-2978
> URL: https://issues.apache.org/jira/browse/NETBEANS-2978
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 11.1, 11.2, 11.3
>Reporter: Petr Miksik
>Priority: Major
>  Labels: autocomplete, autocompletion, codecompletion, nbjavac
> Attachments: ide.log
>
>
> The exception occurs after selecting an item from the provided "Code 
> completion" list and nothing is inserted into code. 
> How to reproduce:
> {noformat}
> public class XXX {
> private static class CellRenderer implements TableCellRenderer {
> @Override
> public Component getTableCellRendererComponent(JTable table, Object 
> value, boolean isSelected, boolean hasFocus, int row, int column) {
> JLabel result = new JLabel <-- code completion fails here
> JLabel result2 = new JLabel <-- it works on this line already. 
> Only the first line is not working
> }
> }
> }
> {noformat}
> {noformat}
> java.lang.AssertionError
>   at com.sun.tools.javac.util.Assert.error(Assert.java:155)
>   at com.sun.tools.javac.util.Assert.check(Assert.java:46)
>   at com.sun.tools.javac.code.Scope$ScopeImpl.dble(Scope.java:410)
>   at com.sun.tools.javac.code.Scope$ScopeImpl.enter(Scope.java:433)
>   at 
> com.sun.tools.javac.comp.MemberEnter.visitVarDef(MemberEnter.java:480)
>   at 
> com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:972)
>   at 
> com.sun.tools.javac.comp.MemberEnter.memberEnter(MemberEnter.java:172)
>   at com.sun.tools.javac.comp.Attr.visitVarDef(Attr.java:1191)
>   at 
> com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:972)
>   at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:674)
>   at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:754)
>   at com.sun.tools.javac.comp.Attr.attribStats(Attr.java:778)
>   at com.sun.tools.javac.comp.Attr.visitBlock(Attr.java:1357)
>   at org.netbeans.lib.nbjavac.services.NBAttr.visitBlock(NBAttr.java:78)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1036)
>   at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:674)
>   at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:754)
>   at 
> org.netbeans.api.java.source.TreeUtilities.attributeTree(TreeUtilities.java:892)
>   at 
> org.netbeans.api.java.source.TreeUtilities.attributeTree(TreeUtilities.java:822)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.type(JavaCodeTemplateProcessor.java:718)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.getProposedValue(JavaCodeTemplateProcessor.java:433)
>   at 
> org.netbeans.modules.editor.java.JavaCodeTemplateProcessor.updateDefaultValues(JavaCodeTemplateProcessor.java:145)
>   at 
> org.netbeans.lib.editor.codetemplates.CodeTemplateInsertHandler.processTemplate(CodeTemplateInsertHandler.java:225)
>   at 
> org.netbeans.lib.editor.codetemplates.CodeTemplateManagerOperation.insert(CodeTemplateManagerOperation.java:273)
>   at 
> org.netbeans.lib.editor.codetemplates.api.CodeTemplate.insert(CodeTemplate.java:82)
>   at 
> org.netbeans.modules.editor.java.JavaCompletionItem.process(JavaCompletionItem.java:570)
>   at 
> org.netbeans.modules.editor.java.JavaCompletionItem.defaultAction(JavaCompletionItem.java:290)
>   at 
> org.netbeans.modules.editor.completion.CompletionImpl.dispatchKeyEvent(CompletionImpl.java:785)
>   at 
> org.netbeans.modules.editor.completion.CompletionImpl.keyPressed(CompletionImpl.java:386)
>   at 
> java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:258)
>   at 
> java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:257)
>   at 
> java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:257)
>   at java.desktop/java.awt.Component.processKeyEvent(Component.java:6590)
>   at 
> java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2849)
>   at java.desktop/java.awt.Component.processEvent(Component.java:6409)
>   at java.desktop/java.awt.Container.processEvent(Container.java:2263)
>   at 
> java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5008)
>   at 
> java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
>   at java.desktop/java.awt.Component.dispatchEvent(Component.java:4840)
>   at 
> 

[jira] [Updated] (NETBEANS-4384) Assertion error ("Invalid pool entry") in javac when accessing inaccessible field in enclosing class

2020-05-28 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4384:
--
Affects Version/s: 11.3

> Assertion error ("Invalid pool entry") in javac when accessing inaccessible 
> field in enclosing class
> 
>
> Key: NETBEANS-4384
> URL: https://issues.apache.org/jira/browse/NETBEANS-4384
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler
>Affects Versions: 11.3
> Environment: NetBeans 11.3 on Java 13 (or Java 14) with nbjavac 
> plugin installed
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: nbjavac
>
> The following example, where a field in an enclosing class is referenced from 
> a method in an inner static class (e.g. during editing, before the user has 
> removed the "static" keyword) causes an assertion error in javac:
> {code:java}
> public class TestClass {
>   Object someField;
>  
>   private static class Foo {
> public void someMethod() {
>   System.out.println(someField);
> }
>   }
> }
> {code}
> The error, which pops up consistently every time, is as follows:
> {noformat}
> java.lang.AssertionError: Invalid pool entry
>   at com.sun.tools.javac.code.Type.poolTag(Type.java:134)
>   at 
> com.sun.tools.javac.jvm.PoolWriter$WriteablePoolHelper.writeConstant(PoolWriter.java:362)
>   at 
> com.sun.tools.javac.jvm.PoolWriter$WriteablePoolHelper.writeIfNeeded(PoolWriter.java:353)
>   at 
> com.sun.tools.javac.jvm.PoolWriter$WriteablePoolHelper.access$000(PoolWriter.java:331)
>   at com.sun.tools.javac.jvm.PoolWriter.putMember(PoolWriter.java:125)
>   at com.sun.tools.javac.jvm.Code.emitop2(Code.java:1004)
>   at com.sun.tools.javac.jvm.Items$MemberItem.load(Items.java:518)
>   at com.sun.tools.javac.jvm.Gen.genArgs(Gen.java:889)
>   at com.sun.tools.javac.jvm.Gen.visitApply(Gen.java:1855)
>   at 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1743)
>   at com.sun.tools.javac.jvm.Gen.genExpr(Gen.java:864)
>   at com.sun.tools.javac.jvm.Gen.visitExec(Gen.java:1723)
>   at 
> com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1529)
>   at com.sun.tools.javac.jvm.Gen.genDef(Gen.java:601)
>   at com.sun.tools.javac.jvm.Gen.genStat(Gen.java:636)
>   at com.sun.tools.javac.jvm.Gen.genStat(Gen.java:622)
>   at com.sun.tools.javac.jvm.Gen.genStats(Gen.java:673)
>   at com.sun.tools.javac.jvm.Gen.visitBlock(Gen.java:1084)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1036)
>   at com.sun.tools.javac.jvm.Gen.genDef(Gen.java:601)
>   at com.sun.tools.javac.jvm.Gen.genStat(Gen.java:636)
>   at com.sun.tools.javac.jvm.Gen.genMethod(Gen.java:954)
>   at com.sun.tools.javac.jvm.Gen.visitMethodDef(Gen.java:917)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:882)
>   at com.sun.tools.javac.jvm.Gen.genDef(Gen.java:601)
>   at com.sun.tools.javac.jvm.Gen.genClass(Gen.java:2398)
>   at com.sun.tools.javac.main.JavaCompiler.genCode(JavaCompiler.java:786)
>   at 
> com.sun.tools.javac.main.JavaCompiler.generate(JavaCompiler.java:1749)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:574)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:651)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:577)
> [catch] at 
> org.netbeans.modules.java.source.nbjavac.indexing.MultiPassCompileWorker.compile(MultiPassCompileWorker.java:303)
>   at 
> org.netbeans.modules.java.source.indexing.JavaCustomIndexer.index(JavaCustomIndexer.java:361)
>   at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor$2.run(Indexable.java:138)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runIndexer(RepositoryUpdater.java:275)
>   at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor.index(Indexable.java:136)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doIndex(RepositoryUpdater.java:2750)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.access$800(RepositoryUpdater.java:2154)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2636)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2634)
>   at 
> org.netbeans.modules.parsing.impl.indexing.errors.TaskCache.refreshTransaction(TaskCache.java:540)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.index(RepositoryUpdater.java:2634)
>   at 
> 

[jira] [Updated] (NETBEANS-4384) Assertion error ("Invalid pool entry") in javac when accessing inaccessible field in enclosing class

2020-05-27 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4384:
--
Environment: NetBeans 11.3 on Java 13 (or Java 14) with nbjavac plugin 
installed  (was: NetBeans 11.3 on Java 13 with nbjavac plugin installed)

> Assertion error ("Invalid pool entry") in javac when accessing inaccessible 
> field in enclosing class
> 
>
> Key: NETBEANS-4384
> URL: https://issues.apache.org/jira/browse/NETBEANS-4384
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler
> Environment: NetBeans 11.3 on Java 13 (or Java 14) with nbjavac 
> plugin installed
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: nbjavac
>
> The following example, where a field in an enclosing class is referenced from 
> a method in an inner static class (e.g. during editing, before the user has 
> removed the "static" keyword) causes an assertion error in javac:
> {code:java}
> public class TestClass {
>   Object someField;
>  
>   private static class Foo {
> public void someMethod() {
>   System.out.println(someField);
> }
>   }
> }
> {code}
> The error, which pops up consistently every time, is as follows:
> {noformat}
> java.lang.AssertionError: Invalid pool entry
>   at com.sun.tools.javac.code.Type.poolTag(Type.java:134)
>   at 
> com.sun.tools.javac.jvm.PoolWriter$WriteablePoolHelper.writeConstant(PoolWriter.java:362)
>   at 
> com.sun.tools.javac.jvm.PoolWriter$WriteablePoolHelper.writeIfNeeded(PoolWriter.java:353)
>   at 
> com.sun.tools.javac.jvm.PoolWriter$WriteablePoolHelper.access$000(PoolWriter.java:331)
>   at com.sun.tools.javac.jvm.PoolWriter.putMember(PoolWriter.java:125)
>   at com.sun.tools.javac.jvm.Code.emitop2(Code.java:1004)
>   at com.sun.tools.javac.jvm.Items$MemberItem.load(Items.java:518)
>   at com.sun.tools.javac.jvm.Gen.genArgs(Gen.java:889)
>   at com.sun.tools.javac.jvm.Gen.visitApply(Gen.java:1855)
>   at 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1743)
>   at com.sun.tools.javac.jvm.Gen.genExpr(Gen.java:864)
>   at com.sun.tools.javac.jvm.Gen.visitExec(Gen.java:1723)
>   at 
> com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1529)
>   at com.sun.tools.javac.jvm.Gen.genDef(Gen.java:601)
>   at com.sun.tools.javac.jvm.Gen.genStat(Gen.java:636)
>   at com.sun.tools.javac.jvm.Gen.genStat(Gen.java:622)
>   at com.sun.tools.javac.jvm.Gen.genStats(Gen.java:673)
>   at com.sun.tools.javac.jvm.Gen.visitBlock(Gen.java:1084)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1036)
>   at com.sun.tools.javac.jvm.Gen.genDef(Gen.java:601)
>   at com.sun.tools.javac.jvm.Gen.genStat(Gen.java:636)
>   at com.sun.tools.javac.jvm.Gen.genMethod(Gen.java:954)
>   at com.sun.tools.javac.jvm.Gen.visitMethodDef(Gen.java:917)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:882)
>   at com.sun.tools.javac.jvm.Gen.genDef(Gen.java:601)
>   at com.sun.tools.javac.jvm.Gen.genClass(Gen.java:2398)
>   at com.sun.tools.javac.main.JavaCompiler.genCode(JavaCompiler.java:786)
>   at 
> com.sun.tools.javac.main.JavaCompiler.generate(JavaCompiler.java:1749)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:574)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:651)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:577)
> [catch] at 
> org.netbeans.modules.java.source.nbjavac.indexing.MultiPassCompileWorker.compile(MultiPassCompileWorker.java:303)
>   at 
> org.netbeans.modules.java.source.indexing.JavaCustomIndexer.index(JavaCustomIndexer.java:361)
>   at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor$2.run(Indexable.java:138)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runIndexer(RepositoryUpdater.java:275)
>   at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor.index(Indexable.java:136)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doIndex(RepositoryUpdater.java:2750)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.access$800(RepositoryUpdater.java:2154)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2636)
>   at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2634)
>   at 
> org.netbeans.modules.parsing.impl.indexing.errors.TaskCache.refreshTransaction(TaskCache.java:540)
>   at 
> 

[jira] [Created] (NETBEANS-4384) Assertion error ("Invalid pool entry") in javac when accessing inaccessible field in enclosing class

2020-05-27 Thread Eirik Bakke (Jira)
Eirik Bakke created NETBEANS-4384:
-

 Summary: Assertion error ("Invalid pool entry") in javac when 
accessing inaccessible field in enclosing class
 Key: NETBEANS-4384
 URL: https://issues.apache.org/jira/browse/NETBEANS-4384
 Project: NetBeans
  Issue Type: Bug
  Components: java - Compiler
 Environment: NetBeans 11.3 on Java 13 with nbjavac plugin installed
Reporter: Eirik Bakke


The following example, where a field in an enclosing class is referenced from a 
method in an inner static class (e.g. during editing, before the user has 
removed the "static" keyword) causes an assertion error in javac:

{code:java}
public class TestClass {
  Object someField;
 
  private static class Foo {
public void someMethod() {
  System.out.println(someField);
}
  }
}
{code}

The error, which pops up consistently every time, is as follows:

{noformat}
java.lang.AssertionError: Invalid pool entry
at com.sun.tools.javac.code.Type.poolTag(Type.java:134)
at 
com.sun.tools.javac.jvm.PoolWriter$WriteablePoolHelper.writeConstant(PoolWriter.java:362)
at 
com.sun.tools.javac.jvm.PoolWriter$WriteablePoolHelper.writeIfNeeded(PoolWriter.java:353)
at 
com.sun.tools.javac.jvm.PoolWriter$WriteablePoolHelper.access$000(PoolWriter.java:331)
at com.sun.tools.javac.jvm.PoolWriter.putMember(PoolWriter.java:125)
at com.sun.tools.javac.jvm.Code.emitop2(Code.java:1004)
at com.sun.tools.javac.jvm.Items$MemberItem.load(Items.java:518)
at com.sun.tools.javac.jvm.Gen.genArgs(Gen.java:889)
at com.sun.tools.javac.jvm.Gen.visitApply(Gen.java:1855)
at 
com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1743)
at com.sun.tools.javac.jvm.Gen.genExpr(Gen.java:864)
at com.sun.tools.javac.jvm.Gen.visitExec(Gen.java:1723)
at 
com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1529)
at com.sun.tools.javac.jvm.Gen.genDef(Gen.java:601)
at com.sun.tools.javac.jvm.Gen.genStat(Gen.java:636)
at com.sun.tools.javac.jvm.Gen.genStat(Gen.java:622)
at com.sun.tools.javac.jvm.Gen.genStats(Gen.java:673)
at com.sun.tools.javac.jvm.Gen.visitBlock(Gen.java:1084)
at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1036)
at com.sun.tools.javac.jvm.Gen.genDef(Gen.java:601)
at com.sun.tools.javac.jvm.Gen.genStat(Gen.java:636)
at com.sun.tools.javac.jvm.Gen.genMethod(Gen.java:954)
at com.sun.tools.javac.jvm.Gen.visitMethodDef(Gen.java:917)
at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:882)
at com.sun.tools.javac.jvm.Gen.genDef(Gen.java:601)
at com.sun.tools.javac.jvm.Gen.genClass(Gen.java:2398)
at com.sun.tools.javac.main.JavaCompiler.genCode(JavaCompiler.java:786)
at 
com.sun.tools.javac.main.JavaCompiler.generate(JavaCompiler.java:1749)
at 
com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:574)
at 
com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:651)
at 
com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:577)
[catch] at 
org.netbeans.modules.java.source.nbjavac.indexing.MultiPassCompileWorker.compile(MultiPassCompileWorker.java:303)
at 
org.netbeans.modules.java.source.indexing.JavaCustomIndexer.index(JavaCustomIndexer.java:361)
at 
org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor$2.run(Indexable.java:138)
at 
org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runIndexer(RepositoryUpdater.java:275)
at 
org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor.index(Indexable.java:136)
at 
org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doIndex(RepositoryUpdater.java:2750)
at 
org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.access$800(RepositoryUpdater.java:2154)
at 
org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2636)
at 
org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2634)
at 
org.netbeans.modules.parsing.impl.indexing.errors.TaskCache.refreshTransaction(TaskCache.java:540)
at 
org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.index(RepositoryUpdater.java:2634)
at 
org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$3.call(RepositoryUpdater.java:3300)
at 
org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$3.call(RepositoryUpdater.java:3255)
at 
org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$4.run(RepositoryUpdater.java:2127)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279)
at 

[jira] [Created] (NETBEANS-4367) DEFAULT_CACHEDIR_ROOT not propagating to platform application (Linux and MacOS)

2020-05-23 Thread Eirik Bakke (Jira)
Eirik Bakke created NETBEANS-4367:
-

 Summary: DEFAULT_CACHEDIR_ROOT not propagating to platform 
application (Linux and MacOS)
 Key: NETBEANS-4367
 URL: https://issues.apache.org/jira/browse/NETBEANS-4367
 Project: NetBeans
  Issue Type: Bug
  Components: platform - LaunchersCLI
Affects Versions: 11.3
 Environment: NetBeans Platform applications on MacOS or Linux.
Reporter: Eirik Bakke


(The following issue description pasted from Patrik Karlström's email to 
d...@netbeans.apache.org on 2020-05-23. Eirik Bakke had the same issue in his 
NetBeans platform application, and has a patch ready.)

The following is done with NB Platform 11.3 and Java 11 on Kubuntu 20.04.

While I was about to use the cache dir logic provided by the platform I ran 
into this problem.

My cache dir is in
${HOME}/.${APPNAME}/var/cache
and not as expected,
${HOME}/.cache/${APPNAME}

The app.conf contains
default_userdir="${DEFAULT_USERDIR_ROOT}/dev"
default_cachedir="${DEFAULT_CACHEDIR_ROOT}/dev"

Did some echoing in the bin/appname and DEFAULT_CACHEDIR_ROOT was set ok, but 
not picked up by the application.

When specifying --cachedir it gets picked up by the application.

I created a simple testapp and this problem is there too.

So I guess the question is, Is this related to my doing or the platform?




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-4344) Use high-resolution icon in Twitter avatar

2020-05-16 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke resolved NETBEANS-4344.
---
Resolution: Fixed

> Use high-resolution icon in Twitter avatar
> --
>
> Key: NETBEANS-4344
> URL: https://issues.apache.org/jira/browse/NETBEANS-4344
> Project: NetBeans
>  Issue Type: Bug
>  Components: website
>Reporter: Eirik Bakke
>Priority: Major
> Attachments: Apache NetBeans Logo Cropped.png, Apache NetBeans 
> Logo.png
>
>
> The twitter avatar for https://twitter.com/netbeans is blurry... attached is 
> a recreated version that uses the same crop but which is higher resolution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4344) Use high-resolution icon in Twitter avatar

2020-05-16 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4344:
--
Attachment: Apache NetBeans Logo.png

> Use high-resolution icon in Twitter avatar
> --
>
> Key: NETBEANS-4344
> URL: https://issues.apache.org/jira/browse/NETBEANS-4344
> Project: NetBeans
>  Issue Type: Bug
>  Components: website
>Reporter: Eirik Bakke
>Priority: Major
> Attachments: Apache NetBeans Logo Cropped.png, Apache NetBeans 
> Logo.png
>
>
> The twitter avatar for https://twitter.com/netbeans is blurry... attached is 
> a recreated version that uses the same crop but which is higher resolution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4344) Use high-resolution icon in Twitter avatar

2020-05-16 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4344:
--
Description: The twitter avatar for https://twitter.com/netbeans is 
blurry... attached is a recreated version that uses the same crop but which is 
higher resolution.  (was: The twitter avatar for https://twitter.com/netbeans 
is blurry... attached is a recreated version that has exactly the same crop and 
dimensions, but which is sharp.)

> Use high-resolution icon in Twitter avatar
> --
>
> Key: NETBEANS-4344
> URL: https://issues.apache.org/jira/browse/NETBEANS-4344
> Project: NetBeans
>  Issue Type: Bug
>  Components: website
>Reporter: Eirik Bakke
>Priority: Major
> Attachments: Apache NetBeans Logo Cropped.png
>
>
> The twitter avatar for https://twitter.com/netbeans is blurry... attached is 
> a recreated version that uses the same crop but which is higher resolution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4344) Use high-resolution icon in Twitter avatar

2020-05-16 Thread Eirik Bakke (Jira)
Eirik Bakke created NETBEANS-4344:
-

 Summary: Use high-resolution icon in Twitter avatar
 Key: NETBEANS-4344
 URL: https://issues.apache.org/jira/browse/NETBEANS-4344
 Project: NetBeans
  Issue Type: Bug
  Components: website
Reporter: Eirik Bakke
 Attachments: Apache NetBeans Logo Cropped.png

The twitter avatar for https://twitter.com/netbeans is blurry... attached is a 
recreated version that has exactly the same crop and dimensions, but which is 
sharp.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2082) Scroll to the caret position when code fold feature is run

2020-05-14 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107401#comment-17107401
 ] 

Eirik Bakke commented on NETBEANS-2082:
---

This can probably be debugged by adding a listener to the vertical scroll pane 
in org.netbeans.modules.editor.NbEditorUI.createExtComponent, and printing a 
stack trace from it. (See for example the scrolling bug at 
https://bz.apache.org/netbeans/show_bug.cgi?id=269451 / 
https://github.com/emilianbold/netbeans-releases/pull/6 )

I have never used the code folding feature, but it sounds like some users like 
it a lot.

> Scroll to the caret position when code fold feature is run
> --
>
> Key: NETBEANS-2082
> URL: https://issues.apache.org/jira/browse/NETBEANS-2082
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Code folding
>Affects Versions: 10.0, 11.0, 11.1, 11.2
> Environment: Netbeans 11 with OpenJDK 12. 
> Darwin MacBook-Pro-2.local 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11 
> 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64
> Netbeans 10 with OpenJDK 11.
> Darwin MacBook-Pro-2.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 
> 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64
>Reporter: Pier Luigi
>Assignee: Svatopluk Dedic
>Priority: Critical
> Attachments: DemoPHPCodeFoldingProblem_NB11.php, netbeans-2082.gif
>
>
> Collapsing a block often results in a jump of the editor to an incorrect 
> editing position (and scrolling the page cause a rejump to that position 
> after a second of scroll inactivity).
> The same sources works perfectly with Netbeans 8.2.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4322) JavaCompletionTask.inferDeclaredType causes IllegalArgumentException in javac's getDeclaredType

2020-05-10 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-4322:
--
Description: 
In the following example (minimized based on an actual editing session), 
opening code completion with Ctrl+Space after "obj." causes an exception:

{code:java}
public class SomeClass {
  private void someMethod() {
String obj = null;
SomeClass2.SomeClass3 foozle = obj. // To trigger error, open code 
completion after "obj."
  }

  class SomeClass2 {
class SomeClass3 {
}
  }
}
{code}

The exception is as follows:

{noformat}
java.lang.IllegalArgumentException: 
com.mycompany.exihibitcompletion.SomeClass.SomeClass2.SomeClass3
at 
com.sun.tools.javac.model.JavacTypes.getDeclaredType(JavacTypes.java:243)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.inferDeclaredType(JavaCompletionTask.java:5855)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.isOfSmartType(JavaCompletionTask.java:4938)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.addMembers(JavaCompletionTask.java:3692)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.insideMemberSelect(JavaCompletionTask.java:1836)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.resolve(JavaCompletionTask.java:375)
at org.netbeans.modules.java.completion.BaseTask.run(BaseTask.java:94)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.run(JavaCompletionTask.java:60)
at 
org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
at 
org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
at 
org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
at 
org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
at 
org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
at 
org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
at 
org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
at 
org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
Caused: org.netbeans.modules.parsing.spi.ParseException
at 
org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:186)
at 
org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
[catch] at 
org.netbeans.modules.editor.java.JavaCompletionProvider$JavaCompletionQuery.query(JavaCompletionProvider.java:193)
at 
org.netbeans.spi.editor.completion.support.AsyncCompletionTask.run(AsyncCompletionTask.java:198)
at 
org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
at 
org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
at 
org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)
{noformat}



  was:
In the following example, opening code completion with Ctrl+Space after "obj." 
causes an exception:

{code:java}
public class SomeClass {
  private void someMethod() {
String obj = null;
SomeClass2.SomeClass3 foozle = obj. // To trigger error, open code 
completion after "obj."
  }

  class SomeClass2 {
class SomeClass3 {
}
  }
}
{code}

The exception is as follows:

{noformat}
java.lang.IllegalArgumentException: 
com.mycompany.exihibitcompletion.SomeClass.SomeClass2.SomeClass3
at 
com.sun.tools.javac.model.JavacTypes.getDeclaredType(JavacTypes.java:243)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.inferDeclaredType(JavaCompletionTask.java:5855)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.isOfSmartType(JavaCompletionTask.java:4938)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.addMembers(JavaCompletionTask.java:3692)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.insideMemberSelect(JavaCompletionTask.java:1836)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.resolve(JavaCompletionTask.java:375)
at org.netbeans.modules.java.completion.BaseTask.run(BaseTask.java:94)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.run(JavaCompletionTask.java:60)
at 
org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
at 

[jira] [Created] (NETBEANS-4322) JavaCompletionTask.inferDeclaredType causes IllegalArgumentException in javac's getDeclaredType

2020-05-10 Thread Eirik Bakke (Jira)
Eirik Bakke created NETBEANS-4322:
-

 Summary: JavaCompletionTask.inferDeclaredType causes 
IllegalArgumentException in javac's getDeclaredType
 Key: NETBEANS-4322
 URL: https://issues.apache.org/jira/browse/NETBEANS-4322
 Project: NetBeans
  Issue Type: Bug
  Components: java - Source
Affects Versions: 11.3
 Environment: Java 14
Reporter: Eirik Bakke


In the following example, opening code completion with Ctrl+Space after "obj." 
causes an exception:

{code:java}
public class SomeClass {
  private void someMethod() {
String obj = null;
SomeClass2.SomeClass3 foozle = obj. // To trigger error, open code 
completion after "obj."
  }

  class SomeClass2 {
class SomeClass3 {
}
  }
}
{code}

The exception is as follows:

{noformat}
java.lang.IllegalArgumentException: 
com.mycompany.exihibitcompletion.SomeClass.SomeClass2.SomeClass3
at 
com.sun.tools.javac.model.JavacTypes.getDeclaredType(JavacTypes.java:243)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.inferDeclaredType(JavaCompletionTask.java:5855)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.isOfSmartType(JavaCompletionTask.java:4938)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.addMembers(JavaCompletionTask.java:3692)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.insideMemberSelect(JavaCompletionTask.java:1836)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.resolve(JavaCompletionTask.java:375)
at org.netbeans.modules.java.completion.BaseTask.run(BaseTask.java:94)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.run(JavaCompletionTask.java:60)
at 
org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
at 
org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
at 
org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
at 
org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
at 
org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
at 
org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
at 
org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
at 
org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
Caused: org.netbeans.modules.parsing.spi.ParseException
at 
org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:186)
at 
org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
[catch] at 
org.netbeans.modules.editor.java.JavaCompletionProvider$JavaCompletionQuery.query(JavaCompletionProvider.java:193)
at 
org.netbeans.spi.editor.completion.support.AsyncCompletionTask.run(AsyncCompletionTask.java:198)
at 
org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
at 
org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
at 
org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)
{noformat}





--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-4286) Disregarded mouse clicks

2020-05-03 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098556#comment-17098556
 ] 

Eirik Bakke edited comment on NETBEANS-4286 at 5/3/20, 8:35 PM:


Like Eric S., I can reproduce the breakpoint problem consistently, but have 
never observed the problem with the "X" buttons.

I think these are two different bugs which will require patches in different 
parts of the code (and eventually two separate JIRA issues--though we can keep 
this one as an "umbrella" issue).

The breakpoint bug is probably an easy one to fix--as Alan says, somewhere 
there's a listener listening for a mouseClicked event, but those events are not 
triggered if the mouse moves a teeny bit between the mouse press and the mouse 
release.

The tab "X" bug (which, again, I think is unrelated) is trickier--we need to 
figure out how to reproduce it before we can fix it.

Those of you who can observe the tab "X" bug--which Look and Feel do you use?


was (Author: ebakke):
Like Eric S., I can reproduce the breakpoint problem consistently, but have 
never observed the problem with the "X" buttons.

I think these are two different bugs which will require patches in different 
parts of the code (and eventually two separate JIRA issues--though we can keep 
this one as an "umbrella" issue).

The breakpoint bug is probably an easy one to fix--as Alan says, somewhere 
there's a listener listening for a mouseClicked event, but those events are not 
triggered if the mouse moves a teeny bit between the mouse press and the mouse 
release.

The tab "X" bug--which, again, I think is unrelated, is trickier--we need to 
figure out how to reproduce it before we can fix it.

Those of you who can observe the tab "X" bug--which Look and Feel do you use?

> Disregarded mouse clicks 
> -
>
> Key: NETBEANS-4286
> URL: https://issues.apache.org/jira/browse/NETBEANS-4286
> Project: NetBeans
>  Issue Type: Improvement
>  Components: ide - UI
>Affects Versions: 11.0, 11.1, 11.2, 11.3
> Environment: Multiple reports. See "Mouse Quirks" on mailing list.
>Reporter: Alan Langford
>Priority: Major
>
> Mouse clicks appear to be disregarded if there is mouse motion between the 
> mouse-down and mouse-up events.
> The problem appears to be more prevalent as monitor resolution increases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4286) Disregarded mouse clicks

2020-05-03 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098556#comment-17098556
 ] 

Eirik Bakke commented on NETBEANS-4286:
---

Like Eric S., I can reproduce the breakpoint problem consistently, but have 
never observed the problem with the "X" buttons.

I think these are two different bugs which will require patches in different 
parts of the code (and eventually two separate JIRA issues--though we can keep 
this one as an "umbrella" issue).

The breakpoint bug is probably an easy one to fix--as Alan says, somewhere 
there's a listener listening for a mouseClicked event, but those events are not 
triggered if the mouse moves a teeny bit between the mouse press and the mouse 
release.

The tab "X" bug--which, again, I think is unrelated, is trickier--we need to 
figure out how to reproduce it before we can fix it.

Those of you who can observe the tab "X" bug--which Look and Feel do you use?

> Disregarded mouse clicks 
> -
>
> Key: NETBEANS-4286
> URL: https://issues.apache.org/jira/browse/NETBEANS-4286
> Project: NetBeans
>  Issue Type: Improvement
>  Components: ide - UI
>Affects Versions: 11.0, 11.1, 11.2, 11.3
> Environment: Multiple reports. See "Mouse Quirks" on mailing list.
>Reporter: Alan Langford
>Priority: Major
>
> Mouse clicks appear to be disregarded if there is mouse motion between the 
> mouse-down and mouse-up events.
> The problem appears to be more prevalent as monitor resolution increases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



  1   2   3   4   5   6   >