[jira] [Resolved] (NETBEANS-97) Improve java source reformatting of try and synchronized blocks with control structures
[
https://issues.apache.org/jira/browse/NETBEANS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mike duigou resolved NETBEANS-97.
-
Fix Version/s: 11.2
Resolution: Fixed
> Improve java source reformatting of try and synchronized blocks with control
> structures
> ---
>
> Key: NETBEANS-97
> URL: https://issues.apache.org/jira/browse/NETBEANS-97
> Project: NetBeans
> Issue Type: Bug
> Components: java - Source
>Affects Versions: 9.0
>Reporter: mike duigou
>Assignee: mike duigou
>Priority: Minor
> Labels: pull-request-available
> Fix For: 11.2
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> This issue recreates [https://netbeans.org/bugzilla/show_bug.cgi?id=269050
> Netbeans bug 269050]. New bug database, new hope for integration!
> Currently the java source reformatter (java.source.base
> org.netbeans.modules.java.source.save.Reformatter) does not treat try and
> synchronized blocks as blocks when it encounters them with control
> structures. So
> {code:java}
> if (foo == bar) try {
>baz();
> } catch (Exception all) {
>log.();
> }
> {code}
> is reformatted as :
> {code:java}
> if (foo == bar) {
> try {
> baz();
> } catch (Exception all) {
> log.();
> }
> }
> {code}
> The additional added basic block layer is not needed as the try is already a
> block. The same applies for a synchronized block as well.
> {code:java}
> if (foo == bar) synchronized(quux) {
>baz();
> }
> {code}
> is currently reformatted as :
> {code:java}
> if (foo == bar) {
> synchronized(quux) {
> baz();
> }
> }
> {code}
> In addition to "if/else" this formatting all affects other control structures
> such as "for", "for-each" and "while".
> Line breaks are preserved so existing source
> {code:java}
> if (foo == bar) {
> synchronized(quux) {
> baz();
> }
> }
> {code}
> will be reformatted with line breaks intact--only the braces will be removed
> {code:java}
> if (foo == bar)
> synchronized(quux) {
> baz();
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-97) Improve java source reformatting of try and synchronized blocks with control structures
[
https://issues.apache.org/jira/browse/NETBEANS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mike duigou updated NETBEANS-97:
Issue Type: Bug (was: Improvement)
> Improve java source reformatting of try and synchronized blocks with control
> structures
> ---
>
> Key: NETBEANS-97
> URL: https://issues.apache.org/jira/browse/NETBEANS-97
> Project: NetBeans
> Issue Type: Bug
> Components: java - Source
>Affects Versions: 9.0
>Reporter: mike duigou
>Assignee: mike duigou
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> This issue recreates [https://netbeans.org/bugzilla/show_bug.cgi?id=269050
> Netbeans bug 269050]. New bug database, new hope for integration!
> Currently the java source reformatter (java.source.base
> org.netbeans.modules.java.source.save.Reformatter) does not treat try and
> synchronized blocks as blocks when it encounters them with control
> structures. So
> {code:java}
> if (foo == bar) try {
>baz();
> } catch (Exception all) {
>log.();
> }
> {code}
> is reformatted as :
> {code:java}
> if (foo == bar) {
> try {
> baz();
> } catch (Exception all) {
> log.();
> }
> }
> {code}
> The additional added basic block layer is not needed as the try is already a
> block. The same applies for a synchronized block as well.
> {code:java}
> if (foo == bar) synchronized(quux) {
>baz();
> }
> {code}
> is currently reformatted as :
> {code:java}
> if (foo == bar) {
> synchronized(quux) {
> baz();
> }
> }
> {code}
> In addition to "if/else" this formatting all affects other control structures
> such as "for", "for-each" and "while".
> Line breaks are preserved so existing source
> {code:java}
> if (foo == bar) {
> synchronized(quux) {
> baz();
> }
> }
> {code}
> will be reformatted with line breaks intact--only the braces will be removed
> {code:java}
> if (foo == bar)
> synchronized(quux) {
> baz();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-540) Lost diff history after refactoring changed file name
[ https://issues.apache.org/jira/browse/NETBEANS-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mike duigou updated NETBEANS-540: - Summary: Lost diff history after refactoring changed file name (was: Mercurial versioning. Lost diff history after refactoring) > Lost diff history after refactoring changed file name > - > > Key: NETBEANS-540 > URL: https://issues.apache.org/jira/browse/NETBEANS-540 > Project: NetBeans > Issue Type: Bug > Components: versioncontrol - Git, versioncontrol - Mercurial >Affects Versions: 9.0 >Reporter: Vldimir Orlyansky >Priority: Minor > > Found through NetCat 9.0 > After refactoring file Mercurial history from Editor page does not show diff > to previous version. > Search history for file does not show history before renaming (history for > file when it had previous name). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-540) Mercurial versioning. Lost diff history after refactoring
[ https://issues.apache.org/jira/browse/NETBEANS-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734545#comment-16734545 ] mike duigou commented on NETBEANS-540: -- The same issue applies for git > Mercurial versioning. Lost diff history after refactoring > - > > Key: NETBEANS-540 > URL: https://issues.apache.org/jira/browse/NETBEANS-540 > Project: NetBeans > Issue Type: Bug > Components: versioncontrol - Mercurial >Affects Versions: 9.0 >Reporter: Vldimir Orlyansky >Priority: Minor > > Found through NetCat 9.0 > After refactoring file Mercurial history from Editor page does not show diff > to previous version. > Search history for file does not show history before renaming (history for > file when it had previous name). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-110) Maven code coverage does not consider integraton tests when using jacoco
[ https://issues.apache.org/jira/browse/NETBEANS-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456783#comment-16456783 ] mike duigou commented on NETBEANS-110: -- I have a patch which reads both of the jacoco report files but the UI doesn't seem to refresh properly. The only way you can see the results is to turn off code coverage and then turn it back on and then use the "Run All Tests" action. In all of the other use cases the UI doesn't refresh and I haven't figured out why. > Maven code coverage does not consider integraton tests when using jacoco > > > Key: NETBEANS-110 > URL: https://issues.apache.org/jira/browse/NETBEANS-110 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Affects Versions: 9.0 >Reporter: mike duigou >Assignee: mike duigou >Priority: Minor > Labels: maven > Fix For: 9.0 > > > jacoco records integration test coverage results to jacoco-it.xml which are > not currently included in coverage statistics. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
